From debbugs-submit-bounces@debbugs.gnu.org Fri May 03 04:54:52 2019 Received: (at submit) by debbugs.gnu.org; 3 May 2019 08:54:52 +0000 Received: from localhost ([127.0.0.1]:47678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMTy0-0001zv-GP for submit@debbugs.gnu.org; Fri, 03 May 2019 04:54:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMTxy-0001zi-Qn for submit@debbugs.gnu.org; Fri, 03 May 2019 04:54:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:36469) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMTxt-0001pT-Kn for submit@debbugs.gnu.org; Fri, 03 May 2019 04:54:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMTxs-0000aM-OJ for bug-guix@gnu.org; Fri, 03 May 2019 04:54:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMTxr-0001k8-UI for bug-guix@gnu.org; Fri, 03 May 2019 04:54:44 -0400 Received: from pelzflorian.de ([5.45.111.108]:52828 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMTxr-0001hU-O6 for bug-guix@gnu.org; Fri, 03 May 2019 04:54:43 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 2E77C360038 for ; Fri, 3 May 2019 10:54:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1556873678; bh=YnbordzjgI0im9yXrAKSrfWp2v0L1RlRZdpojoH5nsQ=; h=Date:From:To:Subject; b=QW9ZG/kr/nfhqwpYD760/V9On2lcCH75+VAzYY2kvJLkNL+zvYISU4Ba0B/IYRxhb b5urj5RvyB2Pk6k9ZuCArvnaVKGDj5GWp5OlOQC00Ot9YBxOA3fmAdCzcuq8f8IyeJ g50rEoBO1ThSk8EGPZA6HEJ/MsxGsSSjzTDr3DXY= Date: Fri, 3 May 2019 10:54:37 +0200 From: "pelzflorian (Florian Pelz)" To: bug-guix@gnu.org Subject: Installer displays encrypted partition password entry in cleartext Message-ID: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20180716 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 5.45.111.108 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) When creating an encrypted partition in Manual partitioning (maybe also Guided?) in the Newt installer, it asks for a password with which to encrypt the partition. However only the password confirmation password entry diplays ******* instead of the typed password, the password entry before displays the password in cleartext. From debbugs-submit-bounces@debbugs.gnu.org Fri May 03 05:30:27 2019 Received: (at 35540) by debbugs.gnu.org; 3 May 2019 09:30:27 +0000 Received: from localhost ([127.0.0.1]:47744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMUWQ-00037I-LW for submit@debbugs.gnu.org; Fri, 03 May 2019 05:30:26 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:59624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMUWP-00034Y-5E for 35540@debbugs.gnu.org; Fri, 03 May 2019 05:30:25 -0400 Received: from localhost (77.116.218.251.wireless.dyn.drei.com [77.116.218.251]) by dd26836.kasserver.com (Postfix) with ESMTPSA id D995D3360CD2; Fri, 3 May 2019 11:30:22 +0200 (CEST) Date: Fri, 3 May 2019 11:30:18 +0200 From: Danny Milosavljevic To: "pelzflorian (Florian Pelz)" Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext Message-ID: <20190503113018.5be80808@scratchpost.org> In-Reply-To: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/3b/r9ZKbZRorTK4b0udN4Vv"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35540 Cc: 35540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/3b/r9ZKbZRorTK4b0udN4Vv Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, On Fri, 3 May 2019 10:54:37 +0200 "pelzflorian (Florian Pelz)" wrote: > When creating an encrypted partition in Manual partitioning (maybe > also Guided?) in the Newt installer, it asks for a password with which > to encrypt the partition. However only the password confirmation > password entry diplays ******* instead of the typed password, the > password entry before displays the password in cleartext. Yes. What about it is a bug? It would be very bad if you had a typo in the partition encryption password, so it's good that it's visible. If you want, we can make the password visible in both boxes. But we shouldn't make it invisible in both boxes. --Sig_/3b/r9ZKbZRorTK4b0udN4Vv Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlzMCioACgkQ5xo1VCww uqWL2AgAj9aAEKsH03pKBAjguHsdDpHQOffrqzC6S2uBwVNtZ+SIZh4lBvWS7zfX A9W68nZzMeSZiYmH/sYk6iq68MaZNBydAWFspX1qpzsyCs0ENiTa2WVpbLEqV7kr kb1V1XV3iotOvfhO/mv+soQ3sxFtLlP0Ewc5B5TkEoCDV2UubKihRbvEeqGKD3+4 1GRc0dONYrQKW1ZvoV7INz/ZvQhd9eKw1ulljcVxDUknAunUbOnxq9b9lQPDUj5k CNC2rLvBcVqK6JaKEFmsTp2hnWdkT6CQD7pmHMFkVkrw4/R/4rXnbOFWAg3UzfX9 U0qv8S6W1IT32bbbNh34o3vzP1y9eg== =WUYM -----END PGP SIGNATURE----- --Sig_/3b/r9ZKbZRorTK4b0udN4Vv-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 03 05:50:35 2019 Received: (at 35540) by debbugs.gnu.org; 3 May 2019 09:50:35 +0000 Received: from localhost ([127.0.0.1]:47765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMUpv-0005Qu-4A for submit@debbugs.gnu.org; Fri, 03 May 2019 05:50:35 -0400 Received: from lepiller.eu ([89.234.186.109]:60746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMUpt-0005Ql-4a for 35540@debbugs.gnu.org; Fri, 03 May 2019 05:50:33 -0400 Received: from sybil.lepiller.eu (89-92-10-229.hfc.dyn.abo.bbox.fr [89.92.10.229]) by lepiller.eu (OpenSMTPD) with ESMTPSA id d400e812 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 3 May 2019 09:50:29 +0000 (UTC) Date: Fri, 3 May 2019 11:50:24 +0200 From: Julien Lepiller To: Danny Milosavljevic Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext Message-ID: <20190503115024.20787d13@sybil.lepiller.eu> In-Reply-To: <20190503113018.5be80808@scratchpost.org> References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35540 Cc: 35540@debbugs.gnu.org, "pelzflorian \(Florian Pelz\)" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le Fri, 3 May 2019 11:30:18 +0200, Danny Milosavljevic a =C3=A9crit : > Hi, >=20 > On Fri, 3 May 2019 10:54:37 +0200 > "pelzflorian (Florian Pelz)" wrote: >=20 > > When creating an encrypted partition in Manual partitioning (maybe > > also Guided?) in the Newt installer, it asks for a password with > > which to encrypt the partition. However only the password > > confirmation password entry diplays ******* instead of the typed > > password, the password entry before displays the password in > > cleartext. =20 >=20 > Yes. What about it is a bug? It would be very bad if you had a typo > in the partition encryption password, so it's good that it's visible. >=20 > If you want, we can make the password visible in both boxes. > But we shouldn't make it invisible in both boxes. The role of the confirmation is to make sure you didn't make a typo somewhere. If it's visible from the start, you know you didn't make a typo, so the confirmation is useless, no? On android when you enter a wifi password for instance, it's invisible when you type it (replace by *) by there is a small button on the side of the text entry to allow you to see it in plaintext to check that you didn't make a mistake. Could we implement that instead? There won't be a need for a confirmation either in that case. From debbugs-submit-bounces@debbugs.gnu.org Fri May 03 06:08:01 2019 Received: (at 35540) by debbugs.gnu.org; 3 May 2019 10:08:01 +0000 Received: from localhost ([127.0.0.1]:47782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMV6m-0005pi-WA for submit@debbugs.gnu.org; Fri, 03 May 2019 06:08:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMV6l-0005pU-7N for 35540@debbugs.gnu.org; Fri, 03 May 2019 06:07:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMV6d-0007vq-BU; Fri, 03 May 2019 06:07:54 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=55628 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hMV6c-0002sz-FX; Fri, 03 May 2019 06:07:51 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "pelzflorian \(Florian Pelz\)" Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 =?utf-8?Q?Flor=C3=A9al?= an 227 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 03 May 2019 12:07:49 +0200 In-Reply-To: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Fri, 3 May 2019 10:54:37 +0200") Message-ID: <87muk3etqi.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35540 Cc: 35540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, "pelzflorian (Florian Pelz)" skribis: > When creating an encrypted partition in Manual partitioning (maybe > also Guided?) in the Newt installer, it asks for a password with which > to encrypt the partition. However only the password confirmation > password entry diplays ******* instead of the typed password, the > password entry before displays the password in cleartext. This is done on purpose as I wrote in commit 453c976501bb4d5c4c6b832b7c0c1ec3d493b80f: ;; Note: Don't use FLAG-PASSWORD here because this is the ;; first bit of text that the user types in, so it's ;; probably safer if they can see that the keyboard layout ;; they chose is in effect. I=E2=80=99m not entirely sure this is the right thing to do, but I thought = that as a user I=E2=80=99d want to make sure I really typed what I thought I typ= ed. WDYT? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri May 03 09:51:07 2019 Received: (at 35540) by debbugs.gnu.org; 3 May 2019 13:51:07 +0000 Received: from localhost ([127.0.0.1]:48127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMYaf-000768-7I for submit@debbugs.gnu.org; Fri, 03 May 2019 09:51:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMYab-00075Z-2m for 35540@debbugs.gnu.org; Fri, 03 May 2019 09:51:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMYaU-00009d-LF; Fri, 03 May 2019 09:50:54 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=56804 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hMYaU-0004Bc-93; Fri, 03 May 2019 09:50:54 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Julien Lepiller Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> <20190503115024.20787d13@sybil.lepiller.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 =?utf-8?Q?Flor=C3=A9al?= an 227 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 03 May 2019 15:50:52 +0200 In-Reply-To: <20190503115024.20787d13@sybil.lepiller.eu> (Julien Lepiller's message of "Fri, 3 May 2019 11:50:24 +0200") Message-ID: <87tvebbq9v.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35540 Cc: Danny Milosavljevic , 35540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Julien Lepiller skribis: > Le Fri, 3 May 2019 11:30:18 +0200, > Danny Milosavljevic a =C3=A9crit : > >> Hi, >>=20 >> On Fri, 3 May 2019 10:54:37 +0200 >> "pelzflorian (Florian Pelz)" wrote: >>=20 >> > When creating an encrypted partition in Manual partitioning (maybe >> > also Guided?) in the Newt installer, it asks for a password with >> > which to encrypt the partition. However only the password >> > confirmation password entry diplays ******* instead of the typed >> > password, the password entry before displays the password in >> > cleartext.=20=20 >>=20 >> Yes. What about it is a bug? It would be very bad if you had a typo >> in the partition encryption password, so it's good that it's visible. >>=20 >> If you want, we can make the password visible in both boxes. >> But we shouldn't make it invisible in both boxes. > > The role of the confirmation is to make sure you didn't make a typo > somewhere. But that=E2=80=99s a different thing. Suppose you type a passphrase assumi= ng you have a Dvorak keyboard but it=E2=80=99s actually QWERTY. You=E2=80=99l= l get the confirmation right. Then when you boot, if for some reason you get the wrong keyboard layout, you=E2=80=99re screwed. That=E2=80=99s why I think that seeing what you actually type is useful. Other options include: 1. Hiding the passphrase, but display right above it something like: Keyboard layout: 2. Adding a checkbox to toggle password visibility. #1 is probably not great because it doesn=E2=80=99t help if you don=E2=80= =99t know precisely the layout. #2 would be nice; not sure how to do it, though. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat May 04 17:06:45 2019 Received: (at 35540) by debbugs.gnu.org; 4 May 2019 21:06:45 +0000 Received: from localhost ([127.0.0.1]:52450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN1rp-0005HY-CS for submit@debbugs.gnu.org; Sat, 04 May 2019 17:06:45 -0400 Received: from pelzflorian.de ([5.45.111.108]:41004 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN1rm-0005HP-JL for 35540@debbugs.gnu.org; Sat, 04 May 2019 17:06:43 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 319F7360038; Sat, 4 May 2019 23:06:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1557003993; bh=oKBn/8BwXjNhr7XI01tn4FGmtYI2V9QxzY8rQRA3V/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=mQQLd0825uNgS9hyOxTLXrQtXYaT4smXxZRp2CwqxkBGi/Jo8cOAYU7GOjk7aGiKO AO7vhcc4QAnCwTx7awYOA6+kaDJwFQFyWqapUJ6vAMUGDNBYbHbMQBRAl7pcMPJY4r LuLz6I9QHHKOC48By7fOtMhTUNa5LwDomHvkTyGk= Date: Sat, 4 May 2019 23:06:32 +0200 From: "pelzflorian (Florian Pelz)" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext Message-ID: <20190504210632.i3tyhzisfw6anpyb@pelzflorian.localdomain> References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> <20190503115024.20787d13@sybil.lepiller.eu> <87tvebbq9v.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87tvebbq9v.fsf@gnu.org> User-Agent: NeoMutt/20180716 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35540 Cc: Julien Lepiller , Mathieu Othacehe , 35540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, May 03, 2019 at 03:50:52PM +0200, Ludovic Courtès wrote: > That’s why I think that seeing what you actually type is useful. > Seeing the password is useful, unless someone is shoulder surfing while you install, which is possible. > Other options include: > > 1. Hiding the passphrase, but display right above it something like: > > Keyboard layout: > > 2. Adding a checkbox to toggle password visibility. > > #1 is probably not great because it doesn’t help if you don’t know > precisely the layout. > > #2 would be nice; not sure how to do it, though. > > Ludo’. > #2 would please everybody, but I do not know what widgets Newt provides for this. Mathieu, would you know if changing the visibility with e.g. a checkbox is doable? Regards, Florian From debbugs-submit-bounces@debbugs.gnu.org Sun May 05 07:04:15 2019 Received: (at 35540) by debbugs.gnu.org; 5 May 2019 11:04:15 +0000 Received: from localhost ([127.0.0.1]:53092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNEwI-0004vh-MZ for submit@debbugs.gnu.org; Sun, 05 May 2019 07:04:15 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:40994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNEwG-0004vT-D0 for 35540@debbugs.gnu.org; Sun, 05 May 2019 07:04:13 -0400 Received: by mail-wr1-f45.google.com with SMTP id c12so13496295wrt.8 for <35540@debbugs.gnu.org>; Sun, 05 May 2019 04:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=6mWasQTkhxptd7eXNUdIiqQ0NEeisZ9vSi9P0qFkDII=; b=nC3iYqkU55FeG/V+WdXdZG0EsBQqChsU81OR9JadxGK8QPNkEj+rYQuMacLJPzAjvB acn/SQupVaxn8BsrgNbihQOtJjVXDQ4ECxSN9b5uKXjSkw+PJYl/hXUug4NAdpwvEZYo RLA3pIP33vNRkkS+w2PjBBXktZLBBWnlUat+1HGGbryN/nd48w78dXUO6nrmnfBfU0BL AdH/I7NCCWJ0WUUZ1wQMBmc/JG4DUCKPBiPnrZru1x4Cg70tSzitcral8bbKQbuc6V5x emZ1ysSOopxD3ddmbWiaxUNd5Vbks6PFLjcGlB5aHJdw+UEpRuypATMNZTJsS06u+XUE rRdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=6mWasQTkhxptd7eXNUdIiqQ0NEeisZ9vSi9P0qFkDII=; b=SdT23cRxdEvWj87OOoHhLvpcnUX5J6a5WHvZu5dahp0LNNhzMix5s3ZGbqwTbgbI1j 0WkOuU+sqVIueo1idq2qSRV0SYXr4nxXOtddm8dKvZ0yScV+igFy7JaUVjiXbTrTWmK8 lVkpw38JdEOrrgYYhKmTrj3YzZvsEjtkgR2LrXdGfyx+2cY/K6hrRrBeagZfNFbZoBpR 2CSLCuWlV9E6sss69+mwdfN3DMi6J+wx2BZd0PkIgo8nuE/d1wRMxmTCtYL8rkoVx3Fn QuCUPBve0FfhwAqq/KW48nIKn+C+4QOtVuy8+Fk0bH8xXgOFGApiRpZyToYaGMTqY5dm 2cDQ== X-Gm-Message-State: APjAAAUXqn0R1P+CJdtpySY4uC5RdeCBGDowvboa6Q7gNnnNgfkae2zr BM3puKXJi7pydsY8ddL8+KzLqnjX X-Google-Smtp-Source: APXvYqxNosL1n95MY5GPbc5dH0G9M7L5yq/+CNwJcHQEHKXDD/pQB4q8+JFaOBmuu4I7f8pkBZjwwg== X-Received: by 2002:a5d:6944:: with SMTP id r4mr12506466wrw.62.1557054246182; Sun, 05 May 2019 04:04:06 -0700 (PDT) Received: from cervin ([78.192.96.126]) by smtp.gmail.com with ESMTPSA id s7sm6566866wrn.84.2019.05.05.04.04.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 May 2019 04:04:04 -0700 (PDT) References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> <20190503115024.20787d13@sybil.lepiller.eu> <87tvebbq9v.fsf@gnu.org> <20190504210632.i3tyhzisfw6anpyb@pelzflorian.localdomain> User-agent: mu4e 1.2.0; emacs 26.2 From: Mathieu Othacehe To: "pelzflorian \(Florian Pelz\)" Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext In-reply-to: <20190504210632.i3tyhzisfw6anpyb@pelzflorian.localdomain> Date: Sun, 05 May 2019 13:04:03 +0200 Message-ID: <877eb5duxo.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35540 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , Julien Lepiller , 35540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hello, > #2 would please everybody, but I do not know what widgets Newt > provides for this. Mathieu, would you know if changing the > visibility with e.g. a checkbox is doable? You'll find a patch attached that adds a checkbox to toggle password hiding. Every password input now has such a checkbox, WDYT? Thanks, Mathieu --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-installer-Add-password-hide-checkbox.patch >From fba1d82b2e27917a5efef339b326fe2d98e62bc0 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Sun, 5 May 2019 12:54:40 +0200 Subject: [PATCH] installer: Add password 'hide' checkbox. * gnu/installer/newt/page.scm (run-input-page)[input-hide-checkbox?]: New parameter adding a checkbox to toggle password hiding. By default, the checkbox is active and the password is hence hided. * gnu/installer/newt/partition.scm (prompt-luks-passwords): Enable the previous parameter on both password input pages. * gnu/installer/newt/user.scm (run-root-password-page): Enable the previous parameter, (confirm-password): ditto, (run-user-add-page): add a checkbox to toggle password hiding. --- gnu/installer/newt/page.scm | 34 +++++++++++++++++++++++--------- gnu/installer/newt/partition.scm | 9 +++------ gnu/installer/newt/user.scm | 22 ++++++++++++++++++--- 3 files changed, 47 insertions(+), 18 deletions(-) diff --git a/gnu/installer/newt/page.scm b/gnu/installer/newt/page.scm index 8a32c403df..4645486ff7 100644 --- a/gnu/installer/newt/page.scm +++ b/gnu/installer/newt/page.scm @@ -75,6 +75,7 @@ this page to TITLE." #:key (allow-empty-input? #f) (default-text #f) + (input-hide-checkbox? #f) (input-field-width 40) (input-flags 0)) "Run a page to prompt user for an input. The given TEXT will be displayed @@ -86,22 +87,37 @@ input box, such as FLAG-PASSWORD." (make-reflowed-textbox -1 -1 text input-field-width #:flags FLAG-BORDER)) - (grid (make-grid 1 3)) + (input-visible-cb + (make-checkbox -1 -1 (G_ "Hide") #\x "x ")) + (input-flags* (if input-hide-checkbox? + (logior FLAG-PASSWORD input-flags) + input-flags)) (input-entry (make-entry -1 -1 20 - #:flags input-flags)) + #:flags input-flags*)) (ok-button (make-button -1 -1 (G_ "OK"))) + (grid (vertically-stacked-grid + GRID-ELEMENT-COMPONENT text-box + GRID-ELEMENT-SUBGRID + (apply + horizontal-stacked-grid + GRID-ELEMENT-COMPONENT input-entry + `(,@(if input-hide-checkbox? + (list GRID-ELEMENT-COMPONENT input-visible-cb) + '()))) + GRID-ELEMENT-COMPONENT ok-button)) (form (make-form))) + (add-component-callback + input-visible-cb + (lambda (component) + (set-entry-flags input-entry + FLAG-PASSWORD + FLAG-ROLE-TOGGLE))) + (when default-text (set-entry-text input-entry default-text)) - (set-grid-field grid 0 0 GRID-ELEMENT-COMPONENT text-box) - (set-grid-field grid 0 1 GRID-ELEMENT-COMPONENT input-entry - #:pad-top 1) - (set-grid-field grid 0 2 GRID-ELEMENT-COMPONENT ok-button - #:pad-top 1) - - (add-components-to-form form text-box input-entry ok-button) + (add-form-to-grid grid form #t) (make-wrapped-grid-window grid title) (let ((error-page (lambda () (run-error-page (G_ "Please enter a non empty input.") diff --git a/gnu/installer/newt/partition.scm b/gnu/installer/newt/partition.scm index 3fb6c5079e..ecf241b8e2 100644 --- a/gnu/installer/newt/partition.scm +++ b/gnu/installer/newt/partition.scm @@ -153,21 +153,18 @@ USER-PARTITIONS list. Return this list with password fields filled-in." (file-name (user-partition-file-name user-part)) (password-page (lambda () - ;; Note: Don't use FLAG-PASSWORD here because this is the - ;; first bit of text that the user types in, so it's - ;; probably safer if they can see that the keyboard layout - ;; they chose is in effect. (run-input-page (format #f (G_ "Please enter the password for the \ encryption of partition ~a (label: ~a).") file-name crypt-label) - (G_ "Password required")))) + (G_ "Password required") + #:input-hide-checkbox? #t))) (password-confirm-page (lambda () (run-input-page (format #f (G_ "Please confirm the password for the \ encryption of partition ~a (label: ~a).") file-name crypt-label) (G_ "Password confirmation required") - #:input-flags FLAG-PASSWORD)))) + #:input-hide-checkbox? #t)))) (if crypt-label (let loop () (let ((password (password-page)) diff --git a/gnu/installer/newt/user.scm b/gnu/installer/newt/user.scm index deab056e0c..6aa103aa5a 100644 --- a/gnu/installer/newt/user.scm +++ b/gnu/installer/newt/user.scm @@ -51,9 +51,11 @@ REAL-NAME, and HOME-DIRECTORY as the initial values in the form." #:initial-value real-name)) (entry-home-directory (make-entry -1 -1 entry-width #:initial-value home-directory)) + (password-visible-cb + (make-checkbox -1 -1 (G_ "Hide") #\x "x ")) (entry-password (make-entry -1 -1 entry-width #:flags FLAG-PASSWORD)) - (entry-grid (make-grid 2 5)) + (entry-grid (make-grid 3 5)) (button-grid (make-grid 1 1)) (ok-button (make-button -1 -1 (G_ "OK"))) (grid (make-grid 1 2)) @@ -71,6 +73,12 @@ REAL-NAME, and HOME-DIRECTORY as the initial values in the form." (set-entry-grid-field 0 3 label-password) (set-entry-grid-field 1 3 entry-password) + (set-grid-field entry-grid + 2 3 + GRID-ELEMENT-COMPONENT + password-visible-cb + #:pad-left 1) + (set-grid-field button-grid 0 0 GRID-ELEMENT-COMPONENT ok-button) (add-component-callback @@ -83,11 +91,19 @@ REAL-NAME, and HOME-DIRECTORY as the initial values in the form." (set-entry-text entry-real-name (string-titlecase (entry-value entry-name)))))) + (add-component-callback + password-visible-cb + (lambda (component) + (set-entry-flags entry-password + FLAG-PASSWORD + FLAG-ROLE-TOGGLE))) + (add-components-to-form form label-name label-real-name label-home-directory label-password entry-name entry-real-name entry-home-directory entry-password + password-visible-cb ok-button) (make-wrapped-grid-window (vertically-stacked-grid @@ -136,7 +152,7 @@ a thunk, if the confirmation doesn't match PASSWORD, and return its result." (run-input-page (G_ "Please confirm the password.") (G_ "Password confirmation required") #:allow-empty-input? #t - #:input-flags FLAG-PASSWORD)) + #:input-hide-checkbox? #t)) (if (string=? password confirmation) password @@ -153,7 +169,7 @@ a thunk, if the confirmation doesn't match PASSWORD, and return its result." (run-input-page (G_ "Please choose a password for the system \ administrator (\"root\").") (G_ "System administrator password") - #:input-flags FLAG-PASSWORD)) + #:input-hide-checkbox? #t)) (confirm-password password run-root-password-page)) -- 2.17.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 05 10:37:13 2019 Received: (at 35540) by debbugs.gnu.org; 5 May 2019 14:37:13 +0000 Received: from localhost ([127.0.0.1]:54634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNIGO-0006FB-Tn for submit@debbugs.gnu.org; Sun, 05 May 2019 10:37:13 -0400 Received: from pelzflorian.de ([5.45.111.108]:42062 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNIGN-0006F1-6m for 35540@debbugs.gnu.org; Sun, 05 May 2019 10:37:12 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 9A45F360038; Sun, 5 May 2019 16:36:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1557067020; bh=hDQS1vmUo0yi6lSVh6Ow30jA8HlspQ1oKgL63KQG85k=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=SpcuR7bV0QszJ1l56SojSgbceCqc8dpJmOD7hyswXoopZergW+bsMCtWDWXcsIM0T SKVlfm+K7UambtOP+lEkBFGl9GzageZyPrRGegi2tRTNKkQ0EVT7E6dABMR7d8/Rkr VBJsK0qQfG+JvkO8J39DOFv1xTWRF3aaBAhb46vk= Date: Sun, 5 May 2019 16:36:57 +0200 From: "pelzflorian (Florian Pelz)" To: Mathieu Othacehe Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext Message-ID: <20190505143657.sc7lu67zbn6hu3bx@pelzflorian.localdomain> References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> <20190503115024.20787d13@sybil.lepiller.eu> <87tvebbq9v.fsf@gnu.org> <20190504210632.i3tyhzisfw6anpyb@pelzflorian.localdomain> <877eb5duxo.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <877eb5duxo.fsf@gmail.com> User-Agent: NeoMutt/20180716 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35540 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , Julien Lepiller , 35540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, May 05, 2019 at 01:04:03PM +0200, Mathieu Othacehe wrote: > > Hello, > > > #2 would please everybody, but I do not know what widgets Newt > > provides for this. Mathieu, would you know if changing the > > visibility with e.g. a checkbox is doable? > > You'll find a patch attached that adds a checkbox to toggle password > hiding. Every password input now has such a checkbox, WDYT? > > Thanks, > > Mathieu This looks great and appears to work fine (I did not finish the installation due to the wpa-supplicant bug). “Hide” of course has no translations yet. Regards, Florian From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 06:02:28 2019 Received: (at 35540) by debbugs.gnu.org; 6 May 2019 10:02:28 +0000 Received: from localhost ([127.0.0.1]:55750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNaS3-0007Hk-P7 for submit@debbugs.gnu.org; Mon, 06 May 2019 06:02:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNaS2-0007HW-Av for 35540@debbugs.gnu.org; Mon, 06 May 2019 06:02:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNaRv-0004YO-N7; Mon, 06 May 2019 06:02:19 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=48094 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hNaRv-00073l-9c; Mon, 06 May 2019 06:02:19 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> <20190503115024.20787d13@sybil.lepiller.eu> <87tvebbq9v.fsf@gnu.org> <20190504210632.i3tyhzisfw6anpyb@pelzflorian.localdomain> <877eb5duxo.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 =?utf-8?Q?Flor=C3=A9al?= an 227 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 06 May 2019 12:02:16 +0200 In-Reply-To: <877eb5duxo.fsf@gmail.com> (Mathieu Othacehe's message of "Sun, 05 May 2019 13:04:03 +0200") Message-ID: <87sgtrkijb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35540 Cc: Julien Lepiller , "pelzflorian \(Florian Pelz\)" , 35540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Mathieu Othacehe skribis: >> #2 would please everybody, but I do not know what widgets Newt >> provides for this. Mathieu, would you know if changing the >> visibility with e.g. a checkbox is doable? > > You'll find a patch attached that adds a checkbox to toggle password > hiding. Every password input now has such a checkbox, WDYT? It looks great! I would perhaps add that checkbox only for the passphrase, in part because when I test an install I prefer to have fewer keystrokes :-), but also because this might clutter dialog boxes and cause troubles: what if the translation of =E2=80=9CHide=E2=80=9D is takes up more space? i= s it still going to fit? WDYT? Thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 08:15:18 2019 Received: (at 35540) by debbugs.gnu.org; 6 May 2019 12:15:18 +0000 Received: from localhost ([127.0.0.1]:55837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNcWc-0004YU-F0 for submit@debbugs.gnu.org; Mon, 06 May 2019 08:15:18 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:39570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNcWa-0004YE-Hh for 35540@debbugs.gnu.org; Mon, 06 May 2019 08:15:17 -0400 Received: by mail-wr1-f46.google.com with SMTP id v10so4678020wrt.6 for <35540@debbugs.gnu.org>; Mon, 06 May 2019 05:15:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=YnKXQgmlSvnT1JyoYZzn0Cs1mbDWHSfwvqFTgP3Nob4=; b=hAuN+XN12s+cQqjGOA6yap/QynSPnLgCRj7wo9TF+Zd3BpEecyHNZivIsfrluYRqNf iKj3WdVixB2CvYjZraS3CwsTSZCoftLxMkBh1vaubIwg3qzUOClWKN9Lt+arMRLOkKmu 6EVlQ8L1HXBop1QgwIFkjuN3Bc0/xFFOC5yKiLDEnEhizKQ5AW+zFptjxDG2zoiCSFxj xk2F9Auo4xTnIz5Wugb3Niu5XROyWJmOHCrnzDtYdjMH5uNvkq39NnthmlStuOSexj37 +h0EWXgFkbDTqXPJXBCW5TljLXsK4MBA9Ld7jRqiL3WlyCTz8sQU2vjiKpB5mHWBC8aU 2Uhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=YnKXQgmlSvnT1JyoYZzn0Cs1mbDWHSfwvqFTgP3Nob4=; b=dkPX4hqDKRNwvDkr/JngOop5HzauN4G96wfmZh0AEfLgjKVzYn9thHIqpsZGP/IOEH OudgYJK3DsLTmNtVsDx0cu/S52AigGkFp1dXSBHjNyqVPndCzJHOuY0LUCBdvSejSVSN Vj6Wj8cPgV8TQ23aHp3YOPgYbZQg+aTSn8uFyWlNHcZPcD3zUv0Idc2DdcH2U+U0mL7Y f0eEicSTGUlEQkbWxikeXaZOh0MeuR4M7gnOicfJSq+Wb74zJXuGpnDe7lyt/sLyNazL 01GTa8+NNK8w9+4ipAgwKieAcpPf9+0K2wtvUJ9mfeq61oX+lY0utsQ1J/P1xMkiZyiP FsJg== X-Gm-Message-State: APjAAAU2findsuWg794gEZ1jr7oMB2F2VmTRxQYH9/UncaLpvXYdu8i3 IOuBQW+9O0u1XQ7AQSX+vUEYbGxc X-Google-Smtp-Source: APXvYqx2DRSwzJ/a9TJzt1hjbwc6DScCo2e98lOWFh0YIjdJwPL3MHY+kl93418S9RYvDcDYjTGAFA== X-Received: by 2002:adf:ebd2:: with SMTP id v18mr16849386wrn.108.1557144910367; Mon, 06 May 2019 05:15:10 -0700 (PDT) Received: from fuji (smtp.parrot.biz. [62.23.167.188]) by smtp.gmail.com with ESMTPSA id g185sm10444856wmf.30.2019.05.06.05.15.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 May 2019 05:15:07 -0700 (PDT) References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> <20190503115024.20787d13@sybil.lepiller.eu> <87tvebbq9v.fsf@gnu.org> <20190504210632.i3tyhzisfw6anpyb@pelzflorian.localdomain> <877eb5duxo.fsf@gmail.com> <87sgtrkijb.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 26.1 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext In-reply-to: <87sgtrkijb.fsf@gnu.org> Date: Mon, 06 May 2019 14:15:06 +0200 Message-ID: <874l67kcdx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35540 Cc: Julien Lepiller , "pelzflorian \(Florian Pelz\)" , 35540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hey Ludo, > I would perhaps add that checkbox only for the passphrase, in part > because when I test an install I prefer to have fewer keystrokes :-), The parameter is disabled by default and enabled only for disk encryption and root/user passwords so I'm not sure I get what you mean. > but also because this might clutter dialog boxes and cause troubles: > what if the translation of =E2=80=9CHide=E2=80=9D is takes up more space?= is it still > going to fit? Hard to say :p, the checkbox is added to widget grids which should adapt to terminal size. So unless the translation is really long and the screen really small, I hope it fits! Mathieu From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 09:41:25 2019 Received: (at 35540) by debbugs.gnu.org; 6 May 2019 13:41:25 +0000 Received: from localhost ([127.0.0.1]:55927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNdrv-0006m8-75 for submit@debbugs.gnu.org; Mon, 06 May 2019 09:41:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNdrt-0006lt-0q for 35540@debbugs.gnu.org; Mon, 06 May 2019 09:41:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNdrm-0000W7-FO; Mon, 06 May 2019 09:41:14 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=49822 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hNdrk-0004NY-1G; Mon, 06 May 2019 09:41:13 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> <20190503115024.20787d13@sybil.lepiller.eu> <87tvebbq9v.fsf@gnu.org> <20190504210632.i3tyhzisfw6anpyb@pelzflorian.localdomain> <877eb5duxo.fsf@gmail.com> <87sgtrkijb.fsf@gnu.org> <874l67kcdx.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 =?utf-8?Q?Flor=C3=A9al?= an 227 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 06 May 2019 15:41:10 +0200 In-Reply-To: <874l67kcdx.fsf@gmail.com> (Mathieu Othacehe's message of "Mon, 06 May 2019 14:15:06 +0200") Message-ID: <87tve7hf9l.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35540 Cc: Julien Lepiller , "pelzflorian \(Florian Pelz\)" , 35540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mathieu Othacehe skribis: >> I would perhaps add that checkbox only for the passphrase, in part >> because when I test an install I prefer to have fewer keystrokes :-), > > The parameter is disabled by default and enabled only for disk > encryption and root/user passwords so I'm not sure I get what you mean. I mean that when I do a test install, I essentially hit RET RET RET RET, and sometimes TAB ludo foo, and this change adds an additional TAB into the mix; but nevermind, my muscle memory will get used to it. :-) >> but also because this might clutter dialog boxes and cause troubles: >> what if the translation of =E2=80=9CHide=E2=80=9D is takes up more space= ? is it still >> going to fit? > > Hard to say :p, the checkbox is added to widget grids which should adapt > to terminal size. So unless the translation is really long and the > screen really small, I hope it fits! Isn=E2=80=99t the grid constrained by the side of the outer box? Perhaps we should enlarge that outer box a bit? Anyway, I think you can push, it=E2=80=99s already a great improvement IMO. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 14:15:02 2019 Received: (at 35540) by debbugs.gnu.org; 6 May 2019 18:15:02 +0000 Received: from localhost ([127.0.0.1]:57354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNi8k-0005zl-8W for submit@debbugs.gnu.org; Mon, 06 May 2019 14:15:02 -0400 Received: from pelzflorian.de ([5.45.111.108]:43864 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNi8i-0005z4-BZ for 35540@debbugs.gnu.org; Mon, 06 May 2019 14:15:01 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 66A3E360038; Mon, 6 May 2019 20:14:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1557166486; bh=KtK6905KPQ+lHzyPbuSR2DAQ02s2cuk2YD7FT3/Rv0I=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=EbIDaCzXXVYp3lp0XstKkQW/zn3pnqslFdfsvYKme41AWYNs/Hx1GH/septTla7W/ f+ydwSunkOGjQF4SofkHlAXPYjLGCUtvpT6xYhkJdKc4vEge+l8aUjhvSIF/rzfJqx vbyOr1Uh1tBtKekxwbbx7Nv/WZhj/6/ANWmze/1o= Date: Mon, 6 May 2019 20:14:46 +0200 From: "pelzflorian (Florian Pelz)" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext Message-ID: <20190506181446.qsakunri5ewvanph@pelzflorian.localdomain> References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> <20190503115024.20787d13@sybil.lepiller.eu> <87tvebbq9v.fsf@gnu.org> <20190504210632.i3tyhzisfw6anpyb@pelzflorian.localdomain> <877eb5duxo.fsf@gmail.com> <87sgtrkijb.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87sgtrkijb.fsf@gnu.org> User-Agent: NeoMutt/20180716 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35540 Cc: Julien Lepiller , Mathieu Othacehe , 35540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sorry for being late to the feedback party. On Mon, May 06, 2019 at 12:02:16PM +0200, Ludovic Courtès wrote: > I would perhaps add that checkbox only for the passphrase, in part I disagree, people would expect it (and file bugs) for other passwords for the same reasons (other people watching while you install Guix vs. wanting to visually confirm you have not mistyped etc.) > because when I test an install I prefer to have fewer keystrokes :-), > but also because this might clutter dialog boxes and cause troubles: > what if the translation of “Hide” is takes up more space? is it still > going to fit? > German “Verbergen” is somewhat longer than “Hide”; I tried translating it locally and it still fits perfectly on my low res AMD GPU screen. When creating a user account, the translation for Home Directory (“Persönliches Verzeichnis”) gets cut off to “Persönliches Verzeic”, but I believe this is not important. Regards, Florian From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 15:29:53 2019 Received: (at 35540) by debbugs.gnu.org; 6 May 2019 19:29:53 +0000 Received: from localhost ([127.0.0.1]:57453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNjJA-0007xo-Nx for submit@debbugs.gnu.org; Mon, 06 May 2019 15:29:53 -0400 Received: from pelzflorian.de ([5.45.111.108]:43938 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNjJ7-0007xd-UP for 35540@debbugs.gnu.org; Mon, 06 May 2019 15:29:51 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id B5431360038; Mon, 6 May 2019 21:29:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1557170975; bh=mGvoDhkiuKXrtuCIbWsAIEx1Z9L2xl+cUAOdCa5HvIk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=oXjBWosGMwBm/5jkUSNebqI1i5sIVV+jP8sV3TbnXvInoQ5JbqAo5JFpweyIWin4g l0OZUdmRyiph+T/6II5h/PAeYTik6l4JSoF6pG9Xn7OTO8sz6LaL/4x0SmUWmRayhI UmsRcfmGUvQFPCJqecAVRzklNo5R5GLToI5rlReI= Date: Mon, 6 May 2019 21:29:35 +0200 From: "pelzflorian (Florian Pelz)" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext Message-ID: <20190506192935.agzovjt2uwktoqys@pelzflorian.localdomain> References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> <20190503115024.20787d13@sybil.lepiller.eu> <87tvebbq9v.fsf@gnu.org> <20190504210632.i3tyhzisfw6anpyb@pelzflorian.localdomain> <877eb5duxo.fsf@gmail.com> <87sgtrkijb.fsf@gnu.org> <20190506181446.qsakunri5ewvanph@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190506181446.qsakunri5ewvanph@pelzflorian.localdomain> User-Agent: NeoMutt/20180716 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35540 Cc: 35540@debbugs.gnu.org, Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, May 06, 2019 at 08:14:46PM +0200, pelzflorian (Florian Pelz) wrote: > When creating a user account, the translation for Home Directory > (“Persönliches Verzeichnis”) gets cut off to “Persönliches Verzeic”, > but I believe this is not important. > This cut-off happens even on higher resolution screens. Hmm well it would be nicer if the space for the Home Directory were 4 letters wider, but it is not all that important. Regards, Florian From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 15:44:06 2019 Received: (at 35540) by debbugs.gnu.org; 6 May 2019 19:44:07 +0000 Received: from localhost ([127.0.0.1]:57493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNjWw-0008Mm-Ko for submit@debbugs.gnu.org; Mon, 06 May 2019 15:44:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNjWv-0008M9-2U for 35540@debbugs.gnu.org; Mon, 06 May 2019 15:44:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNjWp-0006Nb-Il; Mon, 06 May 2019 15:43:59 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57888 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hNjWo-0000Dg-UN; Mon, 06 May 2019 15:43:59 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "pelzflorian \(Florian Pelz\)" Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> <20190503115024.20787d13@sybil.lepiller.eu> <87tvebbq9v.fsf@gnu.org> <20190504210632.i3tyhzisfw6anpyb@pelzflorian.localdomain> <877eb5duxo.fsf@gmail.com> <87sgtrkijb.fsf@gnu.org> <20190506181446.qsakunri5ewvanph@pelzflorian.localdomain> <20190506192935.agzovjt2uwktoqys@pelzflorian.localdomain> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 =?utf-8?Q?Flor=C3=A9al?= an 227 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 06 May 2019 21:43:55 +0200 In-Reply-To: <20190506192935.agzovjt2uwktoqys@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Mon, 6 May 2019 21:29:35 +0200") Message-ID: <87zhnzfjwk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35540 Cc: 35540@debbugs.gnu.org, Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "pelzflorian (Florian Pelz)" skribis: > On Mon, May 06, 2019 at 08:14:46PM +0200, pelzflorian (Florian Pelz) wrot= e: >> When creating a user account, the translation for Home Directory >> (=E2=80=9CPers=C3=B6nliches Verzeichnis=E2=80=9D) gets cut off to =E2=80= =9CPers=C3=B6nliches Verzeic=E2=80=9D, >> but I believe this is not important. >>=20 > > This cut-off happens even on higher resolution screens. Hmm well it > would be nicer if the space for the Home Directory were 4 letters > wider, but it is not all that important. I agree. I=E2=80=99ll commit the patch below, which works fine for German = (at least before the =E2=80=9CHide=E2=80=9D checkbox patch). Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/installer/newt/user.scm b/gnu/installer/newt/user.scm index deab056e0c..ac07d26c8b 100644 --- a/gnu/installer/newt/user.scm +++ b/gnu/installer/newt/user.scm @@ -34,7 +34,7 @@ "Run a form to enter the user name, home directory, and password. Use NAME, REAL-NAME, and HOME-DIRECTORY as the initial values in the form." (define (pad-label label) - (string-pad-right label 20)) + (string-pad-right label 25)) (let* ((label-name (make-label -1 -1 (pad-label (G_ "Name")))) @@ -44,7 +44,7 @@ REAL-NAME, and HOME-DIRECTORY as the initial values in the form." (make-label -1 -1 (pad-label (G_ "Home directory")))) (label-password (make-label -1 -1 (pad-label (G_ "Password")))) - (entry-width 30) + (entry-width 35) (entry-name (make-entry -1 -1 entry-width #:initial-value name)) (entry-real-name (make-entry -1 -1 entry-width --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 15:45:22 2019 Received: (at 35540) by debbugs.gnu.org; 6 May 2019 19:45:22 +0000 Received: from localhost ([127.0.0.1]:57497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNjYA-0008P9-1P for submit@debbugs.gnu.org; Mon, 06 May 2019 15:45:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNjY8-0008Ow-P4 for 35540@debbugs.gnu.org; Mon, 06 May 2019 15:45:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNjY3-00076L-4n; Mon, 06 May 2019 15:45:15 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57892 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hNjY2-0000Kz-FF; Mon, 06 May 2019 15:45:14 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "pelzflorian \(Florian Pelz\)" Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> <20190503115024.20787d13@sybil.lepiller.eu> <87tvebbq9v.fsf@gnu.org> <20190504210632.i3tyhzisfw6anpyb@pelzflorian.localdomain> <877eb5duxo.fsf@gmail.com> <87sgtrkijb.fsf@gnu.org> <20190506181446.qsakunri5ewvanph@pelzflorian.localdomain> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 =?utf-8?Q?Flor=C3=A9al?= an 227 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 06 May 2019 21:45:12 +0200 In-Reply-To: <20190506181446.qsakunri5ewvanph@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Mon, 6 May 2019 20:14:46 +0200") Message-ID: <87v9ynfjuf.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35540 Cc: Julien Lepiller , Mathieu Othacehe , 35540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "pelzflorian (Florian Pelz)" skribis: > On Mon, May 06, 2019 at 12:02:16PM +0200, Ludovic Court=C3=A8s wrote: >> I would perhaps add that checkbox only for the passphrase, in part > > I disagree, people would expect it (and file bugs) for other passwords > for the same reasons (other people watching while you install Guix > vs. wanting to visually confirm you have not mistyped etc.) Yeah OK, that makes sense to me. >> because when I test an install I prefer to have fewer keystrokes :-), >> but also because this might clutter dialog boxes and cause troubles: >> what if the translation of =E2=80=9CHide=E2=80=9D is takes up more space= ? is it still >> going to fit? >> > > German =E2=80=9CVerbergen=E2=80=9D is somewhat longer than =E2=80=9CHide= =E2=80=9D; I tried translating > it locally and it still fits perfectly on my low res AMD GPU screen. Perfect. So I guess you can go ahead and push, Mathieu! Thank you, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue May 07 03:27:20 2019 Received: (at 35540) by debbugs.gnu.org; 7 May 2019 07:27:21 +0000 Received: from localhost ([127.0.0.1]:58136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNuVU-00006A-NU for submit@debbugs.gnu.org; Tue, 07 May 2019 03:27:20 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:36731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNuVS-00005n-Hc for 35540@debbugs.gnu.org; Tue, 07 May 2019 03:27:19 -0400 Received: by mail-wm1-f48.google.com with SMTP id j187so2346346wmj.1 for <35540@debbugs.gnu.org>; Tue, 07 May 2019 00:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=Xn+JIlF0ALZsNRWasYMUI8XlI1UlIGMZyqUIBnaY0yo=; b=tWLvGaSo9xdODSc3GzhN6EmxEEpMUOSVFL81I5OfWvC+pTKxc59hGtxTBUr1jQsl3p yqZ4niEWgSSHc2mwY+X9ct4ZVbtTC5uxotW5988V4ymGfCDpTDitxjgxmPfSyev4NlNN DWGP6OSzgkd7pPGYkrR0RdD7K6PVB2wU3poSL6rjk/RY7h5GurPNlm1Rbr9WxCqeyZL8 jDtVhteyZlaLlMaNL3o3bxAmtfEyqC6ciYs0rDx3z3LwgO4MnrcgLBTJcXymBgeooLt8 AlwoZUAuG9SlvE6sFjhiFj0n6ItCrpTebN8uxxQSzvaIvlPmy2eTCQ5Vt9cT0cEx9oWr QNYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=Xn+JIlF0ALZsNRWasYMUI8XlI1UlIGMZyqUIBnaY0yo=; b=blRmGbJl7F7uAO0mS3tj/TTRYBd/x0RL2e/7koiFKSqsIUPotonbnhJj1eko1S4ENp fBquEMWEc4mYdvyBMyZffzsC0rlAwtIyLuXZoni+Ut/4h00ijeida750onCMq2lVo163 hqZ7TbcBP10WQ3ftPRDLfy9GbM/kcuFSmKtZDcQRpTYlXtgrynDlrG60/utZbe8HK8eS PZ68SJfwNNpvTPTVhTRjbJ0n2e8pfysr4+XoUuCWhCA25TadEkkBK4xhwtm+wX8aPGi8 SZa8KpbLQAqtsyrEGaIEi58IQMYqvILlnQ4F6LuwRfj1e7stMjIpTFakEHYsr7fZKapr Ps3g== X-Gm-Message-State: APjAAAVu+5AS6/usD1P6piGv1zhN/2itgJHbDXnem+mEhMBmdTnJ3anH s+TLUtK/IrhmO7bHLVl97x1WAVwR X-Google-Smtp-Source: APXvYqycwIO9fdQ/BFz3XgOhpAOa5fPKEdW1nbhzMpuD7kMUTbPQHRdwnyjfKzGnyWpkKdAieYRyAg== X-Received: by 2002:a1c:9689:: with SMTP id y131mr20944047wmd.74.1557214032526; Tue, 07 May 2019 00:27:12 -0700 (PDT) Received: from fuji (smtp.parrot.biz. [62.23.167.188]) by smtp.gmail.com with ESMTPSA id z17sm11399430wrm.33.2019.05.07.00.27.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 May 2019 00:27:11 -0700 (PDT) References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> <20190503115024.20787d13@sybil.lepiller.eu> <87tvebbq9v.fsf@gnu.org> <20190504210632.i3tyhzisfw6anpyb@pelzflorian.localdomain> <877eb5duxo.fsf@gmail.com> <87sgtrkijb.fsf@gnu.org> <20190506181446.qsakunri5ewvanph@pelzflorian.localdomain> <87v9ynfjuf.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 26.1 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= , "pelzflorian \(Florian Pelz\)" Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext In-reply-to: <87v9ynfjuf.fsf@gnu.org> Date: Tue, 07 May 2019 09:27:11 +0200 Message-ID: <8736lqk9m8.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35540 Cc: Julien Lepiller , 35540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hey, > So I guess you can go ahead and push, Mathieu! Pushed as 445bd4d5e5, thanks to both of you for reviewing it :) Mathieu From debbugs-submit-bounces@debbugs.gnu.org Tue May 07 04:14:02 2019 Received: (at 35540) by debbugs.gnu.org; 7 May 2019 08:14:02 +0000 Received: from localhost ([127.0.0.1]:58154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNvEg-0001NT-5i for submit@debbugs.gnu.org; Tue, 07 May 2019 04:14:02 -0400 Received: from pelzflorian.de ([5.45.111.108]:44678 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNvEb-0001N4-F6 for 35540@debbugs.gnu.org; Tue, 07 May 2019 04:14:00 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id E21CC360038; Tue, 7 May 2019 10:13:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1557216821; bh=9ncEGh1U9zv6GTFRNPngI3yHOQoxKm8/+RWYc5f4Ryc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=sdN2ZxKEuuO+0guDQnsOzvEEQx4QfE79wx71tqfAqAaH8dumsV+/xImqVaXxE/4Jd VlSWyWj5TSAeG6YXaKBL/QIWSf1asscIquTBW7KHYLPpUJuBdVdU3LoSQBQyOm/PKC nxVdVCW9Bbyha3asH+tOLqs4BsgF0zGzkRr850mQ= Date: Tue, 7 May 2019 10:13:40 +0200 From: "pelzflorian (Florian Pelz)" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#35540: Installer displays encrypted partition password entry in cleartext Message-ID: <20190507081340.qa25xrc7pngxsxkt@pelzflorian.localdomain> References: <20190503085437.opsw5whdkzmwrbrm@pelzflorian.localdomain> <20190503113018.5be80808@scratchpost.org> <20190503115024.20787d13@sybil.lepiller.eu> <87tvebbq9v.fsf@gnu.org> <20190504210632.i3tyhzisfw6anpyb@pelzflorian.localdomain> <877eb5duxo.fsf@gmail.com> <87sgtrkijb.fsf@gnu.org> <20190506181446.qsakunri5ewvanph@pelzflorian.localdomain> <20190506192935.agzovjt2uwktoqys@pelzflorian.localdomain> <87zhnzfjwk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87zhnzfjwk.fsf@gnu.org> User-Agent: NeoMutt/20180716 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35540 Cc: 35540@debbugs.gnu.org, Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, May 06, 2019 at 09:43:55PM +0200, Ludovic Courtès wrote: >> I agree. I’ll commit the patch below, which works fine for German (at > least before the “Hide” checkbox patch). > > Thanks, > Ludo’. > Fits perfectly. Thank you all of you! Regards, Florian From debbugs-submit-bounces@debbugs.gnu.org Wed May 08 15:21:26 2019 Received: (at control) by debbugs.gnu.org; 8 May 2019 19:21:26 +0000 Received: from localhost ([127.0.0.1]:34062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOS86-0001ua-Bw for submit@debbugs.gnu.org; Wed, 08 May 2019 15:21:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOS83-0001uL-VQ for control@debbugs.gnu.org; Wed, 08 May 2019 15:21:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOS7y-0004XB-OQ for control@debbugs.gnu.org; Wed, 08 May 2019 15:21:18 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39072 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hOS7w-00061c-Ea for control@debbugs.gnu.org; Wed, 08 May 2019 15:21:18 -0400 Date: Wed, 08 May 2019 21:21:13 +0200 Message-Id: <87woj0vjkm.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #35540 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 35540 fixed close 35540 From unknown Thu Aug 14 21:55:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 06 Jun 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator