From unknown Mon Jun 23 09:35:33 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#3552 <3552@debbugs.gnu.org> To: bug#3552 <3552@debbugs.gnu.org> Subject: Status: 23.0.94; backward-prefix-chars: Point before start of properties Reply-To: bug#3552 <3552@debbugs.gnu.org> Date: Mon, 23 Jun 2025 16:35:33 +0000 retitle 3552 23.0.94; backward-prefix-chars: Point before start of properti= es reassign 3552 emacs submitter 3552 bojohan+mail@dd.chalmers.se (Johan Bockg=C3=A5rd) severity 3552 important tag 3552 confirmed patch thanks From bojohan+mail@dd.chalmers.se Sat Jun 13 03:40:48 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 13 Jun 2009 10:40:48 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.9 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5DAeggi015272 for ; Sat, 13 Jun 2009 03:40:45 -0700 Received: from mail.gnu.org ([199.232.76.166]:59896 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MFQfB-0007ES-Ai for emacs-pretest-bug@gnu.org; Sat, 13 Jun 2009 06:40:41 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MFQf9-0001Nb-Pt for emacs-pretest-bug@gnu.org; Sat, 13 Jun 2009 06:40:40 -0400 Received: from atum.ita.chalmers.se ([129.16.4.148]:48889) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MFQf9-0001Lz-0A for emacs-pretest-bug@gnu.org; Sat, 13 Jun 2009 06:40:39 -0400 Received: from remote2.student.chalmers.se (remote2.student.chalmers.se [129.16.29.80]) by atum.ita.chalmers.se (Postfix) with ESMTP id EF730835A for ; Sat, 13 Jun 2009 12:40:25 +0200 (CEST) Received: by remote2.student.chalmers.se (Postfix, from userid 61540) id B31B3AC05C; Sat, 13 Jun 2009 12:40:25 +0200 (CEST) From: bojohan+mail@dd.chalmers.se (Johan =?utf-8?Q?Bockg=C3=A5rd?=) To: emacs-pretest-bug@gnu.org Subject: 23.0.94; backward-prefix-chars: Point before start of properties Date: Sat, 13 Jun 2009 12:40:25 +0200 Message-ID: User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/23.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) emacs -Q /tmp/empty.pl @x C-M-b => error "Point before start of properties" The syntax of "@" in perl-mode is `. p' (punctuation/prefix char). From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 02 23:34:31 2016 Received: (at 3552) by debbugs.gnu.org; 3 Jun 2016 03:34:31 +0000 Received: from localhost ([127.0.0.1]:52217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8fsV-0002ta-Ct for submit@debbugs.gnu.org; Thu, 02 Jun 2016 23:34:31 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:34214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8fsT-0002tN-IH for 3552@debbugs.gnu.org; Thu, 02 Jun 2016 23:34:29 -0400 Received: by mail-oi0-f53.google.com with SMTP id e72so108622275oib.1 for <3552@debbugs.gnu.org>; Thu, 02 Jun 2016 20:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to; bh=sJxIno0wc9f5vkOfqS6BiiXvCbL3rTibzwLspc2CAtM=; b=h0eRdDMuMEbpJoTt1aRW0JdCT4qiccg15GxYB8we3Yl8lnu6TcvduMLHgDv4DeqEij QPbu/8t8OCrIri/A7Y8BKadIQJbRiSYoPSdekLNaGtRSzZ0qeBFlAQ7YKfvP34mKXBSP pvATJTfMwNPD95Vqsz2sclwv7qOOtvFYmNZFODQ8QIjdRoENnAGkTt3BHY/bMEFroMcT 0XD1yhuPdqeIxMg3kCY6NXOUuvNK6EvvN+eJ2BODhnpopImJLa71xYRq7WplTMYgvUt/ Eb7KHpTrNahjgrNELecf6eEh8cQi+YLR8FQguDYWgehCNsFgCSx+jD6zX0SpL9guX9ks /gDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:date:message-id:subject:from :to; bh=sJxIno0wc9f5vkOfqS6BiiXvCbL3rTibzwLspc2CAtM=; b=MqGX5SROKBp517muS5sPo/OOGHvRhWeOh0E6jKZc8H2L6lHT0+uDGeFHvucLp7bfXR yjVsQHluhKRF6DBvaIdiOHzJLIvxlrtWmEKOv/8AvJQRExiGNa9KHG5mt1WMN6nWSO7e l4oR138ZgFavdjLt00Dl/kLO6pLOVK6mpe4EE5C+uP5yWTzbpZa1uvShOPmki0VlXTEx OSnNnzFx4CNVk0UUeYSuKr7RtXfmQMpQbonoBk8x9TZ5M+Hgnh/1gzosIt1kdqoT1Rnt 8rLFOguskmY8h9dYw+amU62ZWIQhxWInGWPhIhvLBHf6oS6rU02CZKkssHMEhhdRvCRs bqHw== X-Gm-Message-State: ALyK8tJnb/jJnCdbRgiG6ur3XxiPfE5Ea+Ix7fa3hdKu4YHPZidtyHMWoLSsVoE9MsoowSjncq/zXMi49zgnYA== MIME-Version: 1.0 X-Received: by 10.157.13.167 with SMTP id 36mr790393ots.134.1464924864051; Thu, 02 Jun 2016 20:34:24 -0700 (PDT) Received: by 10.157.34.169 with HTTP; Thu, 2 Jun 2016 20:34:24 -0700 (PDT) Date: Thu, 2 Jun 2016 23:34:24 -0400 X-Google-Sender-Auth: BBOoOrw8Sphi71Ho1QAAFtlCaf0 Message-ID: Subject: 23.0.94; backward-prefix-chars: Point before start of properties From: Noam Postavsky To: 3552@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 3552 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) found 3552 24.5 found 3552 25.0.94 tag 3552 + confirmed quit Still a problem with latest Emacs 25 pretest, and on Windows 8, Emacs 25.0.94 this actually crashes Emacs too. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 09:35:11 2016 Received: (at 3552) by debbugs.gnu.org; 4 Jun 2016 13:35:11 +0000 Received: from localhost ([127.0.0.1]:53867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9BjL-0004xv-22 for submit@debbugs.gnu.org; Sat, 04 Jun 2016 09:35:11 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:35749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9BjI-0004xb-IM for 3552@debbugs.gnu.org; Sat, 04 Jun 2016 09:35:08 -0400 Received: by mail-oi0-f68.google.com with SMTP id h125so21819387oib.2 for <3552@debbugs.gnu.org>; Sat, 04 Jun 2016 06:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=29lJpa6AF5fJINHZBrcrCndZphpqgPdQRfTAVYtDJ5w=; b=RxqQWlWPbIe0LHvc4bITju96yoXNnF1ZD2OOUeNDDAQfXFxYgmgTG2CzXreMiUCfZu NsrZ28ZHNNvsleigYOFjmo+t/l3hUS9CMsC+Oqk3Nwm1rYzYSdYauGm/ioe3gvI+AYo0 eRknF62xmgQAIq89dT9p3NSiJNLx2IkObow2aEAiewqBEDky4nGE3eZ+VcaNCoWl6zJm EnlyhALbp7NK+Ad4rq0wZDnXLAtKfQfKP1bOY03C4gfg3iD1bGlUkJvMdCWtRrGhLXaC sT1OXjfTyAstbSzuLhXfay7yZel1wfcBArXDSLOHfHTePXdPp2vUEI/tASmeEfMfBrEI oKqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=29lJpa6AF5fJINHZBrcrCndZphpqgPdQRfTAVYtDJ5w=; b=Dj3XvHcJSf8kIDkeGBZK47YG4B62Ecq1hgKbWIwxTTyn53xVqk37+R793tAyVthwOx T8Kf0T3bf1Wifau/4/Mefz6MzrqJ2pmtchMrMzCplWqj+2OSkQGqU73O5fG94wa6CWXp V5xQ5rbe4rIueflI3oaxnCiuwXduYVEueVhLL07hQm//l3WDQYcYwh8TiduxyZw0Rqmg CC7YHobijYY7vfQMNceU5zDYV1zkXQ6CWYN5pqoymP9ktpxCHj1LzRpwZsmhDIoa4jJ3 zEeycpss3/YE/H9E5uJBYc+I0Ty31TNH/f/3xDGVVs2Pc/EW851E/13IxMrAL/MqeS3w sjEw== X-Gm-Message-State: ALyK8tJiCehommTes0VWeFEZXAwAqioRmjGQS67qUqIq+gTWe3Ws1c9BplLJ776eB8Lo6Z56HvN0YjGX+DKKZA== X-Received: by 10.202.77.129 with SMTP id a123mr3803473oib.143.1465047302905; Sat, 04 Jun 2016 06:35:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.168 with HTTP; Sat, 4 Jun 2016 06:35:02 -0700 (PDT) In-Reply-To: References: From: Noam Postavsky Date: Sat, 4 Jun 2016 09:35:02 -0400 X-Google-Sender-Auth: luwRCSKaj3hHhmIHptlIaaR87iM Message-ID: Subject: Re: bug#3552: 23.0.94; backward-prefix-chars: Point before start of properties To: 3552@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 3552 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) # bumping severity due to crash potential severity 3352 important tag 3352 + patch quit On Thu, Jun 2, 2016 at 11:34 PM, Noam Postavsky wrote: > Still a problem with latest Emacs 25 pretest, and on Windows 8, Emacs > 25.0.94 this actually crashes Emacs too. Running under valgrind I get "invalid read of size 1" in Fbackward_prefix_chars on GNU/Linux as well (see below). I think this is a long standing bug that allows reading from before beginning of the buffer. It was introduced way back in 1998, 1fd3172dd4819 "(Fbackward_prefix_chars): Set point properly while scanning." diff --git a/src/syntax.c b/src/syntax.c index 4ac1c8d..0235767 100644 --- a/src/syntax.c +++ b/src/syntax.c @@ -2174,12 +2174,16 @@ DEFUN ("backward-prefix-chars", Fbackward_prefix_chars, Sbackward_prefix_chars, DEC_BOTH (pos, pos_byte); - while (pos + 1 > beg && !char_quoted (pos, pos_byte) + while (!char_quoted (pos, pos_byte) /* Previous statement updates syntax table. */ && ((c = FETCH_CHAR (pos_byte), SYNTAX (c) == Squote) || SYNTAX_PREFIX (c))) { - DEC_BOTH (pos, pos_byte); + opoint = pos; + opoint_byte = pos_byte; + + if (pos + 1 > beg) + DEC_BOTH (pos, pos_byte); } SET_PT_BOTH (opoint, opoint_byte); The (pos + 1 > beg) check originally followed the decrementing of pos, but after that commit the check came before (and also doesn't end the loop anymore). Therefore, if (pos == beg), we decrement and then try to look at the syntax of the character at position (beg-1). This may segfault, or trigger the "point before start of properties" error in update_interval (eventually called from char_quoted). I propose the following patch be applied to the emacs-25 branch: @@ -3109,8 +3109,9 @@ DEFUN ("backward-prefix-chars", Fbackward_prefix_chars, Sbackward_prefix_chars, opoint = pos; opoint_byte = pos_byte; - if (pos + 1 > beg) - DEC_BOTH (pos, pos_byte); + DEC_BOTH (pos, pos_byte); + if (pos < beg) + break; } SET_PT_BOTH (opoint, opoint_byte); This fixes the originally reported error, and the invalid read, cf the valgrind output mentioned above: ==2557== Invalid read of size 1 ==2557== at 0x56691D: Fbackward_prefix_chars (syntax.c:3113) ==2557== by 0x541543: Ffuncall (eval.c:2690) ==2557== by 0x5704D9: exec_byte_code (bytecode.c:880) ==2557== by 0x541151: funcall_lambda (eval.c:2855) ==2557== by 0x54167E: Ffuncall (eval.c:2742) ==2557== by 0x5704D9: exec_byte_code (bytecode.c:880) ==2557== by 0x541151: funcall_lambda (eval.c:2855) ==2557== by 0x54167E: Ffuncall (eval.c:2742) ==2557== by 0x53D941: Ffuncall_interactively (callint.c:252) ==2557== by 0x5414E2: Ffuncall (eval.c:2673) ==2557== by 0x53F07D: Fcall_interactively (callint.c:840) ==2557== by 0x54157F: Ffuncall (eval.c:2700) ==2557== Address 0x146aab9f is 1 bytes before a block of size 2,146 alloc'd ==2557== at 0x4C2CB1D: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==2557== by 0x527F90: lrealloc (alloc.c:1427) ==2557== by 0x529628: xrealloc (alloc.c:856) ==2557== by 0x4F837F: enlarge_buffer_text (buffer.c:4974) ==2557== by 0x4FB610: make_gap_larger (insdel.c:393) ==2557== by 0x4FB6D7: make_gap (insdel.c:491) ==2557== by 0x4FC5D7: insert_from_string_1 (insdel.c:926) ==2557== by 0x4FD157: insert_from_string (insdel.c:872) ==2557== by 0x535103: general_insert_function (editfns.c:2468) ==2557== by 0x53514C: Finsert (editfns.c:2504) ==2557== by 0x571D28: exec_byte_code (bytecode.c:1509) ==2557== by 0x541151: funcall_lambda (eval.c:2855) From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 10:01:37 2016 Received: (at control) by debbugs.gnu.org; 4 Jun 2016 14:01:37 +0000 Received: from localhost ([127.0.0.1]:54444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9C8u-0007KE-TN for submit@debbugs.gnu.org; Sat, 04 Jun 2016 10:01:37 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:33493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9C8t-0007K0-No for control@debbugs.gnu.org; Sat, 04 Jun 2016 10:01:36 -0400 Received: by mail-oi0-f45.google.com with SMTP id k23so167187512oih.0 for ; Sat, 04 Jun 2016 07:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to; bh=+x+pv5jaJcrXNocYvsvzHABbc7wOZ43SfdsHV8b0HCE=; b=ArHq6CwVHpu2w5gPqgPDbi7FCnBmx0WYSfrL3XL13k4hvNH6CZoUiAmGtTp3htGFgx ZMzpz3WmXl/+PuoZ4y49slg8KMiaTFfdQMczeemndUJFeScrxIHroyYEmIbfKkX98any 9f7acXsjcJXYm4Pq6C0sKzyQNcn4fUgPmukI+0Uni20KKLoOZGUbNhlb95pYmgGyoeYK uWiSdCBaYXfHyEHuqlhom47mmL1JfSwPvNY38827THxUe0W1e8detrHqSW2ZK51WKN7n oVlqcHPIpaGI4r9XJDaHHbCGczsw2f82305cufkU6YHv5NcttCu7Pddm4PTw23auJmeK rJeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=+x+pv5jaJcrXNocYvsvzHABbc7wOZ43SfdsHV8b0HCE=; b=gNMeVNHRQfgSsoUqDNBF50ZVXDvZUKL88U26JY9BAFJGpghVI11QExjoEK4oFJiIUJ w8PBxq4SWljKxUGwnK5zQZ1Gc4BpZS37CHsotKGNZ0AQy5SQc6E0Lxr3ixN1XyNesfnS FQg0dhL4HCPBwJOlMPxmLUJGOegPXnlSpT9BQ7wZpoXmIATjOkIEjCHFZCkH0Nqy5G3r lpp6faj2Hz7kR6Ga6qD6Nigw03eGFe8xqHoxuGskKVa5sbqEdb2TEX+f8uldvy3/72tB 8JuvsKmvCpwf5Q7P9bAkgPt/0IpiRCcz/WbUaUAfEOgjj4Wv6ZHSWllrL6HqfjkV0KVx T1yw== X-Gm-Message-State: ALyK8tIHDY3vnv8hqgWHXxZofC+gjhvxy1AQIITFp1VUsUc7BOT7MgMLetJXFl1iOXwU0Pdg8Ci3t6tZjomvBA== X-Received: by 10.202.51.133 with SMTP id z127mr3849843oiz.202.1465048890111; Sat, 04 Jun 2016 07:01:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.168 with HTTP; Sat, 4 Jun 2016 07:01:29 -0700 (PDT) From: Noam Postavsky Date: Sat, 4 Jun 2016 10:01:29 -0400 X-Google-Sender-Auth: wXcZPxybqOTh-zO3yj1MwzxaStw Message-ID: Subject: Re: bug#3552: 23.0.94; backward-prefix-chars: Point before start of properties To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) # resending due typoing bug number in previous message # bumping severity due to crash potential severity 3552 important tag 3552 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 11:22:32 2016 Received: (at 3552) by debbugs.gnu.org; 4 Jun 2016 15:22:32 +0000 Received: from localhost ([127.0.0.1]:54498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9DPE-0005gU-2U for submit@debbugs.gnu.org; Sat, 04 Jun 2016 11:22:32 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:34131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9DPB-0005gG-IH for 3552@debbugs.gnu.org; Sat, 04 Jun 2016 11:22:30 -0400 Received: by mail-oi0-f44.google.com with SMTP id e72so168908616oib.1 for <3552@debbugs.gnu.org>; Sat, 04 Jun 2016 08:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=R5itFYS0b2Aj9LD451K/hF2zXuE7oRKHycSrQXQsP6s=; b=yUQH/g4NKmhUJhUCnjy4lIuBIDfJkDRGD8A0JrFxUva9Yme8RSfa6OnfaI7llMDSqE AFCiVJktO034/iMERA7SiKs4dmeI1Ex3mRcsmF80rAI8WeoffFwCqQD+Ss4bje1ERasE /HMGLRaIk2FzATLmRRvkj+WD9CGMD3COjWjc6OLgD7G8z1h/pVkdFMvuAeXMaZXjUTTd wGLxo1klBUoXiSEE3YdSFskbHgOdpAwYf3NIMI+7el3o05/ZeYCFO30tV3iNLJ8j+hdu TSlQtujlMwydz+92ED+10rS+/BDp9oxn27l6NelLP/5BdhTfcWfx9jBXqhZVUKz6DR9t Km5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=R5itFYS0b2Aj9LD451K/hF2zXuE7oRKHycSrQXQsP6s=; b=GrGCaauVncJGbqAr3wbhJGch9oR7SjCUI7JCuKLIQJ9sA4FCa0Ov9WyWo71tH5yOR7 B9IL8SM8E11H0UIRD0/bNEF4O3Qc3U3smZb4BgqMWV3Y6S+TjGM80QRvaU9Dx0KPg3/i w5sBuDVq2u6eW7f4D9pzTDhKzE5xLYEEdt1il2RoQZZ1HJmx3WqrnzkUu/BCWlOxWYdD YGxWx+Tp3U6Dt8Apz+Ml5UeEF15V+gi+R8rztg0KlwL8NQ00Etv+uMqrmwZPXIofX79s wJDgrnDHVtpsuSRnlSIzpM9MCNk8RATAHr1iuBiosOT/07hCes6M78zpKzmZUxh0dCjr Np+Q== X-Gm-Message-State: ALyK8tIpNQVH0hUQAWh9OkR1JZEdkxpyzkpvbvjACIftqYTSO6mXMDqoB+hQS1W5GQ9oYHNC/LpeFXesNck2xQ== X-Received: by 10.202.77.129 with SMTP id a123mr3954271oib.143.1465053743892; Sat, 04 Jun 2016 08:22:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.168 with HTTP; Sat, 4 Jun 2016 08:22:23 -0700 (PDT) In-Reply-To: References: From: Noam Postavsky Date: Sat, 4 Jun 2016 11:22:23 -0400 X-Google-Sender-Auth: C_BLIsN8T7GTFb3De3xewHnQMEw Message-ID: Subject: Re: bug#3552: 23.0.94; backward-prefix-chars: Point before start of properties To: 3552@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 3552 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sat, Jun 4, 2016 at 9:35 AM, Noam Postavsky wrote: > I propose the following patch be applied to the emacs-25 branch: Sorry, that's not quite right, I didn't realize DEC_BOTH also reads from the buffer, here is a patch that actually fixes the invalid read: @@ -3109,8 +3109,10 @@ DEFUN ("backward-prefix-chars", Fbackward_prefix_chars, Sbackward_prefix_chars, opoint = pos; opoint_byte = pos_byte; - if (pos + 1 > beg) + if (pos > beg) DEC_BOTH (pos, pos_byte); + else + break; } SET_PT_BOTH (opoint, opoint_byte); From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 13:55:21 2016 Received: (at 3552) by debbugs.gnu.org; 4 Jun 2016 17:55:22 +0000 Received: from localhost ([127.0.0.1]:54625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9Fn7-0005s8-OI for submit@debbugs.gnu.org; Sat, 04 Jun 2016 13:55:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9Fn6-0005rw-Du for 3552@debbugs.gnu.org; Sat, 04 Jun 2016 13:55:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9Fmx-0006tC-94 for 3552@debbugs.gnu.org; Sat, 04 Jun 2016 13:55:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9Fmx-0006sj-5d; Sat, 04 Jun 2016 13:55:11 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2885 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b9Fmu-0008V4-KY; Sat, 04 Jun 2016 13:55:09 -0400 Date: Sat, 04 Jun 2016 20:55:30 +0300 Message-Id: <837fe4vnxp.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Sat, 4 Jun 2016 11:22:23 -0400) Subject: Re: bug#3552: 23.0.94; backward-prefix-chars: Point before start of properties References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 3552 Cc: 3552@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Noam Postavsky > Date: Sat, 4 Jun 2016 11:22:23 -0400 > > - if (pos + 1 > beg) > + if (pos > beg) > DEC_BOTH (pos, pos_byte); > + else > + break; I would use if (pos <= beg) break; DEC_BOTH (pos, pos_byte); But I don't insist. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 17:25:28 2016 Received: (at 3552) by debbugs.gnu.org; 4 Jun 2016 21:25:28 +0000 Received: from localhost ([127.0.0.1]:54654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9J4R-0005Vf-QW for submit@debbugs.gnu.org; Sat, 04 Jun 2016 17:25:27 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:36461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9J4P-0005VS-Jd for 3552@debbugs.gnu.org; Sat, 04 Jun 2016 17:25:25 -0400 Received: by mail-oi0-f52.google.com with SMTP id j1so175744796oih.3 for <3552@debbugs.gnu.org>; Sat, 04 Jun 2016 14:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=zB1+hDMzNj9fKKSBbWjA5UyVI4+j88G12hrFntjJ1jY=; b=yamMHNlI5yKRraKXj+zawh/O6Xz98UwTaogNUMg35VrRe/2BaQ6Se1FqGs1m4Yirfb c15Xz6TUP/bBiijpGQ3GrbhYKJGXRY6EWM0Umvp9oRilg9JNkgvJSGj81wP5JpPIRiuU lJ8GmkYYj944GJGpSD81+NxSVGoTMBHM4/SHWEEdtoxw4iSX3mowlZZhTYS2HzSSiKB0 gna6IPggRV+qyR9FuoFCnW44AwJ6J2fIWi2GXS3ZSylbYjilXrgZx6sqLKMmLXPtPEKY FD6mRe0X1EoLmERclXkaFF99/dcvOH1bJmJ4m2cUKuizQnvAzoHJfApC5hDBLBg7yYl1 7+Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=zB1+hDMzNj9fKKSBbWjA5UyVI4+j88G12hrFntjJ1jY=; b=i77Rl9eMJ3jRvqL+OXcIZtPgnnKsWPVX5Y6JicZ5RuuuGPG8Og027LKUcU3HOrzhdX hAO8AeNZPGyKD3A//mllsBa47pl2FHc/KwCwraSTYqDbw/bQrWDtoXLxLSCHUmdkc9qk 2It7svVnSikJdtB7EAIcFV0rgO92RMbUkdZGBzYZNtsdE2nTKSYTW4iGGc746O2AzLMq XJB3aS4MC8G322NnOI03CyZoEyeoTc/Arj9ru+3lKNbyna0rQwoThnMJF1FUi9UIFy+Q AiqvtUd756KZMXsSEJQCv6Li0COQB3BiDShUUcKsXLHBaFuB7JpdjnBxSKUxkn3pDZRq xujQ== X-Gm-Message-State: ALyK8tLBq3JH3HcvZl1mcVDePpwTF97J3VFk9VxauDwBsFIQWRt2ChqNLZ5irjOcozBJ0W+9uiFLK4wXB4uliQ== X-Received: by 10.157.23.195 with SMTP id j61mr5780946otj.92.1465075520043; Sat, 04 Jun 2016 14:25:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.168 with HTTP; Sat, 4 Jun 2016 14:25:19 -0700 (PDT) In-Reply-To: <837fe4vnxp.fsf@gnu.org> References: <837fe4vnxp.fsf@gnu.org> From: Noam Postavsky Date: Sat, 4 Jun 2016 17:25:19 -0400 X-Google-Sender-Auth: OT0QEoXvsQVuAarzyXklHlK8ITo Message-ID: Subject: Re: bug#3552: 23.0.94; backward-prefix-chars: Point before start of properties To: Eli Zaretskii Content-Type: multipart/mixed; boundary=94eb2c094b18f1149805347a79df X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 3552 Cc: 3552@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --94eb2c094b18f1149805347a79df Content-Type: text/plain; charset=UTF-8 On Sat, Jun 4, 2016 at 1:55 PM, Eli Zaretskii wrote: > I would use > > if (pos <= beg) > break; > DEC_BOTH (pos, pos_byte); Oh yeah, that makes sense; parallels with the same check at the beginning of the function. Full patch attached. --94eb2c094b18f1149805347a79df Content-Type: text/x-diff; charset=US-ASCII; name="0001-Fbackward_prefix_chars-stay-within-buffer-bounds.patch" Content-Disposition: attachment; filename="0001-Fbackward_prefix_chars-stay-within-buffer-bounds.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ip1o2k9t0 RnJvbSBmYjczOWVlMmY4M2RmNTgyNjZjOGJmYzZhMGU0NDI2ZmVkNWI1ODkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBTYXQsIDQgSnVuIDIwMTYgMDk6MDI6MjAgLTA0MDAKU3ViamVjdDogW1BBVENIXSBGYmFj a3dhcmRfcHJlZml4X2NoYXJzOiBzdGF5IHdpdGhpbiBidWZmZXIgYm91bmRzCgpUaGUgY29tbWl0 IDFmZDMxNzJkICIoRmJhY2t3YXJkX3ByZWZpeF9jaGFycyk6IFNldCBwb2ludCBwcm9wZXJseSB3 aGlsZQpzY2FubmluZyIgKDE5OTgtMDMtMTgpLCBtb3ZlZCB0aGUgY2hlY2sgYWdhaW5zdCBvZiB0 aGUgcG9zaXRpb24gYWdhaW5zdCB0aGUKYnVmZmVyIGJlZ2lubmluZyBvdXQgdGhlIGxvb3AgY29u ZGl0aW9uIHNvIHRoYXQgd2UgbWlnaHQgZW5kIHVwIGNoZWNraW5nCnRoZSBzeW50YXggb2YgY2hh cmFjdGVycyBiZWZvcmUgdGhlIGJlZ2lubmluZyBvZiB0aGUgYnVmZmVyLiAgVGhpcyBjYW4KY2F1 c2Ugc2VnZmF1bHRzIG9yIHRyaWdnZXIgYSAiUG9pbnQgYmVmb3JlIHN0YXJ0IG9mIHByb3BlcnRp ZXMiIGVycm9yIGluCmB1cGRhdGVfaW50ZXJ2YWwnIChjYWxsZWQgaW5kaXJlY3RseSBmcm9tIGBj aGFyX3F1b3RlZCcpLgoKKiBzcmMvc3ludGF4LmMgKEZiYWNrd2FyZF9wcmVmaXhfY2hhcnMpOiBT dG9wIHRoZSBsb29wIHdoZW4gYmVnaW5uaW5nIG9mCmJ1ZmZlciBpcyByZWFjaGVkIChCdWcgIzM1 NTIpLgotLS0KIHNyYy9zeW50YXguYyB8IDUgKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3N5bnRheC5jIGIvc3Jj L3N5bnRheC5jCmluZGV4IDhlMTRiZjMuLmIxYmE1YzYgMTAwNjQ0Ci0tLSBhL3NyYy9zeW50YXgu YworKysgYi9zcmMvc3ludGF4LmMKQEAgLTMxMDksOCArMzEwOSw5IEBAIERFRlVOICgiYmFja3dh cmQtcHJlZml4LWNoYXJzIiwgRmJhY2t3YXJkX3ByZWZpeF9jaGFycywgU2JhY2t3YXJkX3ByZWZp eF9jaGFycywKICAgICAgIG9wb2ludCA9IHBvczsKICAgICAgIG9wb2ludF9ieXRlID0gcG9zX2J5 dGU7CiAKLSAgICAgIGlmIChwb3MgKyAxID4gYmVnKQotCURFQ19CT1RIIChwb3MsIHBvc19ieXRl KTsKKyAgICAgIGlmIChwb3MgPD0gYmVnKQorICAgICAgICBicmVhazsKKyAgICAgIERFQ19CT1RI IChwb3MsIHBvc19ieXRlKTsKICAgICB9CiAKICAgU0VUX1BUX0JPVEggKG9wb2ludCwgb3BvaW50 X2J5dGUpOwotLSAKMi44LjAKCg== --94eb2c094b18f1149805347a79df-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 05 05:59:06 2016 Received: (at 3552) by debbugs.gnu.org; 5 Jun 2016 09:59:07 +0000 Received: from localhost ([127.0.0.1]:54905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9Upm-0004lL-N5 for submit@debbugs.gnu.org; Sun, 05 Jun 2016 05:59:06 -0400 Received: from mout.gmx.net ([212.227.17.21]:61872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9Upl-0004kP-4j for 3552@debbugs.gnu.org; Sun, 05 Jun 2016 05:59:05 -0400 Received: from [192.168.1.100] ([212.95.7.119]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LZlZ2-1bucpO3Cpw-00lYP9; Sun, 05 Jun 2016 11:58:46 +0200 Message-ID: <5753D686.1020204@gmx.at> Date: Sun, 05 Jun 2016 09:36:38 +0200 From: martin rudalics MIME-Version: 1.0 To: Noam Postavsky , Eli Zaretskii Subject: Re: bug#3552: 23.0.94; backward-prefix-chars: Point before start of properties References: <837fe4vnxp.fsf@gnu.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:loVND0kypZWoD1u1Ezdtb+XK0/j1YujHIOfBXXW9jeMHpXqIxwr xuTH+aWSnUOeQRLkdXsanv1vMby3L7g3SPkYhBPbVBDPrPG1//yVZqLYI/YfyKwjCsFzqtN f2vcS1W8MZC8vNRsDJ/mQzi4hxapb1sgDOjr8ldh6ZDyYGqdZIhFafc7Zo9WMo4WJ1iVg36 cUbp3h/dfYinxKim1VmvQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:DaAatUGX3Gw=:Zb2UrgmL/sZvbX9JaDVXTO QcNDJKW8NN3StZsytCfcX4OXYHnfG/zOJcESxijIQaeTV7M7qGdwa/JfD4mKjDANrgJtZN045 TkVO27jsEbju6xxT1lumaER/jR0U+16b/gKwEXe1geuq36WSpLLMBqyJVTMbGZBER/nr6LRWi l0zlyuHHzKaE+Sb0YY3PdW9ZFUngMJuhFpwBL0Sr/Ig4UySANVqq/zHaJ8c1ZKQ3wvC5XRtV9 +HB6Bi9Qu1lSRS9AHsh0yzlquqSnHDudm2Ar5upu0fdm4hWqWVlmIOjpdtyFg7jv+UNch83x3 L34mUbBcGVDqmukRte3DjNxd9PV4P47zGr/ENVKbEKOBNFLXfgKgULkos7QPHOO5dvqvl2Pd4 9LKpBO0+7ezZagA0oeyKAaMmtV3bmLQXNUAtICd7Z9p+FBQbC5HtmL36+elwLp18feX/Pnnru eMNfoEydCDch9B74qMk7Gdm6CO5SJWhwbzeyGrNUXRdRwlgd6s99EJDPDGh7BQFHS9dKS76ho cIS/DrGuqWgwmqxPVy3uBFACEGAU+jV1NOGjD+KS4/sX6UHieAlfszxxmGLySLfq/8IVIt56e fmzytnHUBumbivjAVZB3lyCxzPRVWIGIgTVCP5DN/gfSHye8b7OIK5bQIp8zJIy7UnRDl3qTj 08WrmCSO8Fzm0rG8QLAOul3+tOgFGwK2x6wf0+CxfrBr8jrALzuPiBROmti8/CylA6Hmtz76+ cBAlnh+Wc6tIM3J03Xz1LA7WpKPgdXiV7TEIgCS4l5rrIdhnYsB/PDerhwedpUP7gYm1xuU+z hqkS4COJoksPJOe+Sdv4tHibH3SNA== X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 3552 Cc: 3552@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) > * src/syntax.c (Fbackward_prefix_chars): Stop the loop when beginning of > buffer is reached (Bug #3552). Make it * src/syntax.c (Fbackward_prefix_chars): Stop the loop when beginning of buffer is reached (Bug#3552, Bug#19379). martin From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 05 09:35:58 2016 Received: (at 3552) by debbugs.gnu.org; 5 Jun 2016 13:35:58 +0000 Received: from localhost ([127.0.0.1]:54979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9YDe-00036C-Cm for submit@debbugs.gnu.org; Sun, 05 Jun 2016 09:35:58 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:35216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9YDc-00035z-Ps for 3552@debbugs.gnu.org; Sun, 05 Jun 2016 09:35:57 -0400 Received: by mail-oi0-f46.google.com with SMTP id w184so191028194oiw.2 for <3552@debbugs.gnu.org>; Sun, 05 Jun 2016 06:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=PAqK74MSA407m2TPZBmRJ7NI9Z6HRbhV1z5N7PBBW3U=; b=Twtub86OWVlWWJfZL26/XYrHEtQOlz7+FG/93X1uU//BEWYpH9DLwT1hiHyArEyTbh uoENxCuxocgGU9JAT6A0mZaeXDjDboPrCkRVnwBzmE39NVmfRIxl0DSIwuk4jZR3HJ1x raqmEk1pJpezwYRNZ4NZUWbwk4HkxgsdPx65/5jMavaUq78UU81LQHpeqKYT1udNOnEp XbMlw5Z9weOpmJX8uakFA/WDvZr1szra98a5Uer2gNt8PwP/3ueeAaer1fu7LWeHakjU UyOTX9xFN5v0/BYacPIkLCDeiG4nhaEk5SuT+85pYjiPmrf+hd8+xMqdWYkCp647xjFs GSWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=PAqK74MSA407m2TPZBmRJ7NI9Z6HRbhV1z5N7PBBW3U=; b=jcSi96Phh/Adb6xaSBjPNkRpCjG18bS8fNSIjk3CSjSAUXiX/2SC+XEE8GECDEOIjH oEeFgzHjRaJLCyc2uQM6e8fvvuIRK1EWMpq02VBDGZkUpKAWr/lVAdVETDs7Frzik7iS FZ8iXL5BDHskEAwPq6fFh1lr8JoarEZmjtxtwYzSMyOfnoB+7PqN7USqJ5WDUlzCAyOj uPgno7FIdFfFuq6iGq4w+YDaEPaYeCkHCJX3UojzPGPf8U8xX0aox7FdqAzb+r7omn6W ShoeT3zH3fIOxkZXujh0JGt1fuAPQXIyU4ZnBLRL/r8gtaoNhmpZLO99jhR4MybK9TT2 DnOg== X-Gm-Message-State: ALyK8tJjVLIKsuPU7YnG1Zy62W9rkMPbpVYaH7Jw4YhvIGOwi9NuR67YyaQHviMqEeXwswY8iis+sT40zM6XKA== X-Received: by 10.157.23.195 with SMTP id j61mr7029598otj.92.1465133751429; Sun, 05 Jun 2016 06:35:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.168 with HTTP; Sun, 5 Jun 2016 06:35:50 -0700 (PDT) In-Reply-To: <5753D686.1020204@gmx.at> References: <837fe4vnxp.fsf@gnu.org> <5753D686.1020204@gmx.at> From: Noam Postavsky Date: Sun, 5 Jun 2016 09:35:50 -0400 X-Google-Sender-Auth: 6HlYt-iuXUYdIGPESh_uP9hKN90 Message-ID: Subject: Re: bug#3552: 23.0.94; backward-prefix-chars: Point before start of properties To: martin rudalics Content-Type: multipart/mixed; boundary=94eb2c094b18cd816a0534880804 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 3552 Cc: Eli Zaretskii , 3552@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --94eb2c094b18cd816a0534880804 Content-Type: text/plain; charset=UTF-8 forcemerge 3552 17132 19379 quit On Sun, Jun 5, 2016 at 3:36 AM, martin rudalics wrote: > Make it > > * src/syntax.c (Fbackward_prefix_chars): Stop the loop when beginning of > buffer is reached (Bug#3552, Bug#19379). Heh, seeing that I decided to search the bug database for backwards-prefix-chars and found also Bug #17132. Updated patch attached. --94eb2c094b18cd816a0534880804 Content-Type: text/x-diff; charset=US-ASCII; name="0001-Fbackward_prefix_chars-stay-within-buffer-bounds.patch" Content-Disposition: attachment; filename="0001-Fbackward_prefix_chars-stay-within-buffer-bounds.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ip2mj8j90 RnJvbSA5ODU4NzRlYmNmYWU5Njk4Mzg1N2U4MTlmNTcwY2FjMzU1MTA1MmM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBTYXQsIDQgSnVuIDIwMTYgMDk6MDI6MjAgLTA0MDAKU3ViamVjdDogW1BBVENIXSBGYmFj a3dhcmRfcHJlZml4X2NoYXJzOiBzdGF5IHdpdGhpbiBidWZmZXIgYm91bmRzCgpUaGUgY29tbWl0 IDFmZDMxNzJkICIoRmJhY2t3YXJkX3ByZWZpeF9jaGFycyk6IFNldCBwb2ludCBwcm9wZXJseSB3 aGlsZQpzY2FubmluZyIgKDE5OTgtMDMtMTgpLCBtb3ZlZCB0aGUgY2hlY2sgYWdhaW5zdCBvZiB0 aGUgcG9zaXRpb24gYWdhaW5zdCB0aGUKYnVmZmVyIGJlZ2lubmluZyBvdXQgdGhlIGxvb3AgY29u ZGl0aW9uIHNvIHRoYXQgd2UgbWlnaHQgZW5kIHVwIGNoZWNraW5nCnRoZSBzeW50YXggb2YgY2hh cmFjdGVycyBiZWZvcmUgdGhlIGJlZ2lubmluZyBvZiB0aGUgYnVmZmVyLiAgVGhpcyBjYW4KY2F1 c2Ugc2VnZmF1bHRzIG9yIHRyaWdnZXIgYSAiUG9pbnQgYmVmb3JlIHN0YXJ0IG9mIHByb3BlcnRp ZXMiIGVycm9yIGluCmB1cGRhdGVfaW50ZXJ2YWwnIChjYWxsZWQgaW5kaXJlY3RseSBmcm9tIGBj aGFyX3F1b3RlZCcpLgoKKiBzcmMvc3ludGF4LmMgKEZiYWNrd2FyZF9wcmVmaXhfY2hhcnMpOiBT dG9wIHRoZSBsb29wIHdoZW4gYmVnaW5uaW5nIG9mCmJ1ZmZlciBpcyByZWFjaGVkIChCdWcgIzM1 NTIsIEJ1ZyAjMTcxMzIsIEJ1ZyAjMTkzNzkpLgotLS0KIHNyYy9zeW50YXguYyB8IDUgKysrLS0K IDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvc3JjL3N5bnRheC5jIGIvc3JjL3N5bnRheC5jCmluZGV4IDhlMTRiZjMuLmIxYmE1YzYg MTAwNjQ0Ci0tLSBhL3NyYy9zeW50YXguYworKysgYi9zcmMvc3ludGF4LmMKQEAgLTMxMDksOCAr MzEwOSw5IEBAIERFRlVOICgiYmFja3dhcmQtcHJlZml4LWNoYXJzIiwgRmJhY2t3YXJkX3ByZWZp eF9jaGFycywgU2JhY2t3YXJkX3ByZWZpeF9jaGFycywKICAgICAgIG9wb2ludCA9IHBvczsKICAg ICAgIG9wb2ludF9ieXRlID0gcG9zX2J5dGU7CiAKLSAgICAgIGlmIChwb3MgKyAxID4gYmVnKQot CURFQ19CT1RIIChwb3MsIHBvc19ieXRlKTsKKyAgICAgIGlmIChwb3MgPD0gYmVnKQorICAgICAg ICBicmVhazsKKyAgICAgIERFQ19CT1RIIChwb3MsIHBvc19ieXRlKTsKICAgICB9CiAKICAgU0VU X1BUX0JPVEggKG9wb2ludCwgb3BvaW50X2J5dGUpOwotLSAKMi44LjAKCg== --94eb2c094b18cd816a0534880804-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 15 22:07:51 2016 Received: (at 3552) by debbugs.gnu.org; 16 Jun 2016 02:07:51 +0000 Received: from localhost ([127.0.0.1]:42744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDMil-0000NT-Mw for submit@debbugs.gnu.org; Wed, 15 Jun 2016 22:07:51 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:32948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDMik-0000NG-5I for 3552@debbugs.gnu.org; Wed, 15 Jun 2016 22:07:50 -0400 Received: by mail-oi0-f50.google.com with SMTP id u201so48270393oie.0 for <3552@debbugs.gnu.org>; Wed, 15 Jun 2016 19:07:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Pc/ulJgG0WLNzIDBAv3X6ilNBZ6Zny7KnpmDK+oZZZM=; b=yQwWwWu/itxjfIPg9ccFnjjrTwFppIPe8JpThZOipB7NhpsjctcaTIMWzcK82hHKoD VQgoVlKupnQWulhJtkqGKVDgHsAY1Kj4HmZ4HnLJnpRt8SNoVg+RL/hdo7GxRpKQvMsk iedNtVrRzoRvkvsjEd5I/Oa6Dg2LTrk5mFBoayamAlML67FDA9nNWGc+MFKGLa4mEU72 MVTzZXU3jUjKrgikkcZX3vk657TTQyUKe48SUNs7YLkdHLf5b7Y2UMMwoe7AfNYFamqV dshizdBl8kQEU2KkUK3+mAfLDTiEibLEIlxyiTHAPxvG/ZFTp1gtoxvBGhOSW4VpHYZy fyGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Pc/ulJgG0WLNzIDBAv3X6ilNBZ6Zny7KnpmDK+oZZZM=; b=Npw8woUuMkmEFFAYzKb+Xe1r1Azf/8vb1IgaJ2A8Ag78bw7Sz//vLdvYZb8CmWTPAA aK0Bw2HtId7n6xJgooPbi7s7Ognw4R53ap8GXA80qXIZ6n5dbx/14c46wOl/QEperZq4 Mn/7UP+HwroiYomiFIbok/+YnGjzQcUJoDRHJdhAs6UUbic5kIHhkiBsqRLxEFl49xcL gI2rUUTSa5lN9lJw2h+s6eUxXUeG84HkQ2i5UR/qudeBlyrkPDwjG593qXzixrMjZuoC Gs1jzn8otRN/nYG57SJnWNTZKPMGihS5ResDvbWUkV33G6JtxlpjGTvA3Mi/X0JU0+dC u8bA== X-Gm-Message-State: ALyK8tIVLo+gF96UDpy9O3kAtK9/gWkCcM4CAAgQRC6AeVXK8FOFpk2PCETKVc4cLoJThOZtfO1yuBTzzO7v4A== X-Received: by 10.202.197.137 with SMTP id v131mr916754oif.178.1466042864784; Wed, 15 Jun 2016 19:07:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.44.103 with HTTP; Wed, 15 Jun 2016 19:07:43 -0700 (PDT) In-Reply-To: References: <837fe4vnxp.fsf@gnu.org> <5753D686.1020204@gmx.at> From: Noam Postavsky Date: Wed, 15 Jun 2016 22:07:43 -0400 X-Google-Sender-Auth: LgLRn1EpA92N4Jnw9mV7oDrzX2g Message-ID: Subject: Re: bug#3552: 23.0.94; backward-prefix-chars: Point before start of properties To: martin rudalics Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 3552 Cc: Eli Zaretskii , 3552@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Is it okay to install this to emacs-25? While the bug is long-standing, I think it's important enough to go in the release since it can crash Emacs. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 16 11:04:53 2016 Received: (at 3552) by debbugs.gnu.org; 16 Jun 2016 15:04:54 +0000 Received: from localhost ([127.0.0.1]:43435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDYqj-0005fd-Lk for submit@debbugs.gnu.org; Thu, 16 Jun 2016 11:04:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDYqh-0005fR-SN for 3552@debbugs.gnu.org; Thu, 16 Jun 2016 11:04:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDYqY-0006So-HV for 3552@debbugs.gnu.org; Thu, 16 Jun 2016 11:04:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47532) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDYqY-0006Si-E7; Thu, 16 Jun 2016 11:04:42 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3116 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bDYqX-0002q9-Iv; Thu, 16 Jun 2016 11:04:42 -0400 Date: Thu, 16 Jun 2016 18:05:41 +0300 Message-Id: <83lh25cgxm.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Wed, 15 Jun 2016 22:07:43 -0400) Subject: Re: bug#3552: 23.0.94; backward-prefix-chars: Point before start of properties References: <837fe4vnxp.fsf@gnu.org> <5753D686.1020204@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 3552 Cc: rudalics@gmx.at, 3552@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Noam Postavsky > Date: Wed, 15 Jun 2016 22:07:43 -0400 > Cc: Eli Zaretskii , 3552@debbugs.gnu.org > > Is it okay to install this to emacs-25? I was sure you already did. Yes, please. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 16 23:21:05 2016 Received: (at 3552-done) by debbugs.gnu.org; 17 Jun 2016 03:21:05 +0000 Received: from localhost ([127.0.0.1]:43661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDkLB-0007ph-5k for submit@debbugs.gnu.org; Thu, 16 Jun 2016 23:21:05 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:36305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDkLA-0007ot-75 for 3552-done@debbugs.gnu.org; Thu, 16 Jun 2016 23:21:04 -0400 Received: by mail-oi0-f54.google.com with SMTP id p204so99304673oih.3 for <3552-done@debbugs.gnu.org>; Thu, 16 Jun 2016 20:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=UlNILXIstl3mCjdJgCqCIo6S+v3aBMsLG6OgOg0x+7U=; b=0xgxn4aV9ruB7DRki2Alr60UES8gLwsXoD5zdM5LqpUEV0HFPM+RAoCVgUVsnJb66U jn6rksJwf4C67GIGlLvpHCrIWl6nMOMSz08xnoUdvNpygGWHckbpvkNXp/5K17QptO4B Cak49IU+Rvax2R2rY0bjPAon/z2foYUnr2yciCMkLv4ir2agzlLAEiRS/5NHW4cSz8wZ GjZDb6Iij14BJdomtKnIjr+29Derp6mfSfn89cpgpfpOkox0rHE+5/341ph/lZRjDied mtGCHzTWjl7FVfAdMsXb40EQC3edOpkgROpP3g0MOfvkla647L0FAXOM/7Fhtw6AAl4+ z5nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=UlNILXIstl3mCjdJgCqCIo6S+v3aBMsLG6OgOg0x+7U=; b=box2/D/kKGbImYj3zRpyMjGSjRNZAuLLpXf9R+pakJgOD8fXtZlqOKBSMHL6BfEbGM vEg5Ypvs1Ca4VjnCX/LSmZxvU8WrU00T/ywojTvpYx1kNhKfuEKgQBtAaQxy3EXKxBe2 k6UWpwqy0ukmNeOJHW5EGBIWn8wibwIC2XuU/3ijB8t/74fdYflJR1RagoIzPOjzxkvJ 20gf2cYtQXihI9f5a/3bBuuJJCwQq2qjujAJOg55LHbC97yn/PpWNsUsPc5DVDu9Oni7 UDfPTBIoJjdY40gZRosNIhWQsT6SQQFtGbV5ucoVXOoxmtfTBtQ8peIWQBvpGgREyIJb vg8g== X-Gm-Message-State: ALyK8tInY3zoJ2TI3GG0Sq2d6eLIzaIn1ecNH9lO81Isov9E1pcGqBbIBCfM0xIcGibeMI2cnnQb3NXmxN0Aiw== X-Received: by 10.202.80.148 with SMTP id e142mr4565302oib.144.1466133658732; Thu, 16 Jun 2016 20:20:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.44.103 with HTTP; Thu, 16 Jun 2016 20:20:58 -0700 (PDT) In-Reply-To: <83lh25cgxm.fsf@gnu.org> References: <837fe4vnxp.fsf@gnu.org> <5753D686.1020204@gmx.at> <83lh25cgxm.fsf@gnu.org> From: Noam Postavsky Date: Thu, 16 Jun 2016 23:20:58 -0400 X-Google-Sender-Auth: vpj2UR5j5FOba-3gPYcDMY1JrY0 Message-ID: Subject: Re: bug#3552: 23.0.94; backward-prefix-chars: Point before start of properties To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 3552-done Cc: martin rudalics , 3552-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Version: 25.1 On Thu, Jun 16, 2016 at 11:05 AM, Eli Zaretskii wrote: >> From: Noam Postavsky >> Date: Wed, 15 Jun 2016 22:07:43 -0400 >> Cc: Eli Zaretskii , 3552@debbugs.gnu.org >> >> Is it okay to install this to emacs-25? > > I was sure you already did. > > Yes, please. Now pushed as b49cb0ab From unknown Mon Jun 23 09:35:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 15 Jul 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator