GNU bug report logs - #35518
gnu: guile-pfds bugfix

Previous Next

Full log

Message #23 received at 35518 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: amirouche <at> hyper.dev
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 35518 <at> debbugs.gnu.org
Subject: Re: [bug#35518] gnu: guile-pfds bugfix
Date: Mon, 06 May 2019 10:05:52 +0200

Hi Amirouche,

amirouche <at> hyper.dev skribis:

> On 2019-05-01 08:20, Ricardo Wurmus wrote:
>>
>> I’d prefer not to add a patch file here but to add a build phase after
>> unpack that uses substitute* to patch the file.
>>
>
> new patch
>
> From de22b734f37c2701121b990fe1fda5ead67ece31 Mon Sep 17 00:00:00 2001
> From: Amirouche <amirouche+dev <at> hyper.dev>
> Date: Wed, 1 May 2019 13:41:59 +0200
> Subject: [PATCH] gnu: guile-pfds bugfix
>
> - gnu/packages/guile-xyz.scm(guile-pfds)[version]: upgrade to 0.3-0
> - gnu/packages/guile-xyz.scm(guile-pfds)[commit]: hardcode v0.3
> - gnu/packages/guile-xyz.scm(guile-pfds)[arguments]: New phase 'patch'

[...]

> +                  (add-after 'unpack 'patch
> +                    (lambda _
> +                      (substitute* "hamts.sls"
> +                        (("subtrie-vector vector")
> +                         "subtrie-vector trie"))
> +                        #t))

Like Ricardo wrote: “there should be a note about the upstream status of
this change.”  Someone reading this cannot understand what this change
is about nor what upstream thinks about it.

Could you address this issue?

Bonus points if you change it to follow our conventions for the commit
log and for the Git checkouts.  :-)

  https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html
  https://www.gnu.org/software/guix/manual/en/html_node/Version-Numbers.html

Thanks in advance,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.