GNU bug report logs - #35507
Gnus mojibakifies UTF-8 text/x-patch attachments from Thunderbird

Previous Next

Packages: emacs, gnus;

Reported by: Paul Eggert <eggert <at> cs.ucla.edu>

Date: Tue, 30 Apr 2019 19:22:02 UTC

Severity: minor

Tags: fixed

Found in version 27

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Robert Pluim <rpluim <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 35507 <at> debbugs.gnu.org, Andy Moreton <andrewjmoreton <at> gmail.com>
Subject: bug#35507: Gnus mojibakifies UTF-8 text/x-patch attachments from	Thunderbird
Date: Thu, 02 May 2019 18:29:52 +0200
>>>>> On Thu, 02 May 2019 18:57:23 +0300, Eli Zaretskii <eliz <at> gnu.org> said:

    >> From: Andy Moreton <andrewjmoreton <at> gmail.com> Date: Thu, 02 May
    >> 2019 16:43:31 +0100
    >> 
    >> > So yes, I think Noam is right, and 'undecided' is a better
    >> alternative here.
    >> 
    >> That is arguing for the existing code, which does not work
    >> correctly.

    Eli> No, the existing code simply uses the undecoded string.

    Eli> What I argue for is to do this:

    >diff --git a/lisp/gnus/mm-view.el b/lisp/gnus/mm-view.el
    >index 1e1d264b99..173ebfab48 100644
    >--- a/lisp/gnus/mm-view.el
    >+++ b/lisp/gnus/mm-view.el
    >@@ -475,7 +475,7 @@ mm-display-inline-fontify
    > 		    (charset
    > 		     (mm-decode-string text charset))
    > 		    (t
    >- text)))
    >+ (mm-decode-string text 'undecided))))
    >       (let ((font-lock-verbose nil) ; font-lock is a bit too verbose.
    > 	    (enable-local-variables nil))
    >         ;; We used to set font-lock-mode-hook to nil to avoid enabling

That fixes things for me, thanks (I tested against Paul's original
message).

I donʼt see any need for it to be configurable, but thatʼs up to you.

Robert




This bug report was last modified 6 years and 81 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.