GNU bug report logs - #35507
Gnus mojibakifies UTF-8 text/x-patch attachments from Thunderbird

Previous Next

Full log

Message #23 received at 35507 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andy Moreton <andrewjmoreton <at> gmail.com>
Cc: 35507 <at> debbugs.gnu.org
Subject: Re: bug#35507: Gnus mojibakifies UTF-8 text/x-patch attachments from
 Thunderbird
Date: Wed, 01 May 2019 20:33:31 +0300

> From: Andy Moreton <andrewjmoreton <at> gmail.com>
> Date: Wed, 01 May 2019 01:35:09 +0100
> 
> After a bit of experimenting, this minimal patch appears to fix things.
> Should this also allow the user to choose the charset if none is
> specified, or just hardwire it to utf-8 ?
> 
> diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el
> index 3f255419e7..a99d52a7e7 100644
> --- a/lisp/gnus/mm-decode.el
> +++ b/lisp/gnus/mm-decode.el
> @@ -665,6 +665,9 @@ mm-dissect-buffer
>  	(setq type (split-string (car ctl) "/"))
>  	(setq subtype (cadr type)
>  	      type (car type))
> +        ;; Fix missing charset in Thunderbird
> +        (unless (assq 'charset (cdr ctl))
> +          (push '(charset . utf-8) (cdr ctl)))

Please don't unconditionally force UTF-8 on users.  At the very least
this should be a user option, if at all.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.