GNU bug report logs - #35504
26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer

Previous Next

Full log

Message #36 received at 35504 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 35504 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 Rudi Schlatte <rudi <at> constantly.at>
Subject: Re: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the
 *Packages* buffer
Date: Fri, 4 Oct 2019 16:36:10 +0200

Basil L. Contovounesios <contovob <at> tcd.ie> writes:

> > -(defun package-menu-refresh ()
> > +(defun package-menu-revert (&optional arg noconfirm)
>
> If the arguments aren't used, they should be prefixed with underscores.

Indeed, fixed.

> >    "In Package Menu, download the Emacs Lisp package archive.
> >  Fetch the contents of each archive specified in
> >  `package-archives', and then refresh the package menu.  Signal a
> > -user-error if there is already a refresh running asynchronously."
> > +user-error if there is already a refresh running asynchronously.
> > +
> > +`package-menu-mode' sets ‘revert-buffer-function’ to this
> > +function.  The args ARG and NOCONFIRM, passed from
> > +‘revert-buffer’, are ignored."
>
> revert-buffer-function and revert-buffer are quoted with curly single
> quotes instead of the usual grave+apostrophe.

Well spotted, fixed.  Thanks for the review.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.