From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 30 10:53:39 2019 Received: (at submit) by debbugs.gnu.org; 30 Apr 2019 14:53:39 +0000 Received: from localhost ([127.0.0.1]:42093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLU8Z-000123-4f for submit@debbugs.gnu.org; Tue, 30 Apr 2019 10:53:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLU8W-00011o-U2 for submit@debbugs.gnu.org; Tue, 30 Apr 2019 10:53:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:38825) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLU8R-0006BK-BU for submit@debbugs.gnu.org; Tue, 30 Apr 2019 10:53:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLU8Q-00038C-EV for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 10:53:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLU8M-000697-GS for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 10:53:30 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:41403) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLU8M-00068a-Aj for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 10:53:26 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3C62D22E76; Tue, 30 Apr 2019 10:53:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 30 Apr 2019 10:53:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=3u3EP/ kpPpSXAms/8qanNHr6uIyjdasH3X1n7BnEfd0=; b=dpdXL18vF9DZnnqVsrgR9i cR+I/nDhhfkeRq/+rDgjizKKtGnz/1J3MxxxQaQ+Qv7S1gEmqS8NDGZ4mCR/QVab dF9QkYDvUTYa2ftJGwSGk0/1Movy3mdrtz/OhzhJHHu7J5mp7J3zmhWGo6BEq1F9 qD1Vg4VMsUHLZx2SFKaFZ6JTeTY5DMevSR/+b5lVu1NzJGRA9+GwC9+xn1w8SFkl pq1UfpLZGIYTcHD5/li6FHhJquipt0oVWopdjNuLFuHJ4uiD1NJcPeW5c2mg/VD4 2YQnYHewPwdGMfTmqavvLx+zHGoWT5fX4FF8Yx/4A/NZd8KGfZsBvTl8jroGnBDA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieehgddvfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephfgtgfggfffukffvofesthhqmhdthh dtjeenucfhrhhomheptfhuughiucfutghhlhgrthhtvgcuoehruhguihestghonhhsthgr nhhtlhihrdgrtheqnecukfhppeduvdelrddvgedtrdeikedrudeggeenucfrrghrrghmpe hmrghilhhfrhhomheprhhuughisegtohhnshhtrghnthhlhidrrghtnecuvehluhhsthgv rhfuihiivgeptd X-ME-Proxy: Received: from relax.ifi.uio.no (relax.ifi.uio.no [129.240.68.144]) by mail.messagingengine.com (Postfix) with ESMTPA id 67A5AE44B6; Tue, 30 Apr 2019 10:53:22 -0400 (EDT) From: Rudi Schlatte Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Date: Tue, 30 Apr 2019 16:52:46 +0200 Subject: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer Message-Id: To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3445.104.8) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.26 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) The =E2=80=98g=E2=80=99 key seems to be the standard way to refresh a = list of things. For example, =E2=80=98g=E2=80=99 runs =E2=80=98gnus-group-get-new-news=E2=80= =99 in the gnus *Group* buffer and =E2=80=98revert-buffer=E2=80=99 in vc-dir-mode. In the = package list, =E2=80=98package-menu-refresh=E2=80=99 is run by the =E2=80=98r=E2=80=99 = key instead. Since =E2=80=98g=E2=80=99 is unbound in =E2=80=98package-menu-mode=E2=80=99= , could a binding be added to run =E2=80=98package-menu-refresh=E2=80=99 for that key? From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 30 11:48:05 2019 Received: (at 35504) by debbugs.gnu.org; 30 Apr 2019 15:48:05 +0000 Received: from localhost ([127.0.0.1]:42213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLUzF-0002Sx-3H for submit@debbugs.gnu.org; Tue, 30 Apr 2019 11:48:05 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:44162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLUzC-0002SR-2t for 35504@debbugs.gnu.org; Tue, 30 Apr 2019 11:48:03 -0400 Received: by mail-wr1-f44.google.com with SMTP id c5so21581319wrs.11 for <35504@debbugs.gnu.org>; Tue, 30 Apr 2019 08:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=NBTu+RsXaNhLQ0y23q1Xn0TtwcYd//6psi/Aykmefn4=; b=Hmj0H2jG3Pzm7E2xFiutohPiZcStnIf9smXuGkHM+kOnuPHM8TBaJKnWyLjZC9C7hj MBfetk+TSTOvmSgJDxessOUpnU2mv160Dr7eAcfI/N2PXl3YM8rtDV3NEbTPTY6jq4O0 qg7vHGvOejqzIWj0LGe0LE0FrkupPSHxuqyjVoQJ//l1actVPqWK+o9RfBIjK+QbtIMG sKUoCGOBoYmzpX12ZJ8GdueGSYExmO9SmvTq87Cr2bIsiDuKsnYyyf2mUfLxdA/3BYuQ 3wqeSAC1frCDOzkTINlma43P3I5OD/tO1rWAFSdLnFyImpt615kfJiFtq8R9qNTbqzQa RmQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=NBTu+RsXaNhLQ0y23q1Xn0TtwcYd//6psi/Aykmefn4=; b=ffV8mk2YPBQ8hf9fpNbrakJyv6ONZnzpq5jtNVntcBchFn53KH12p0jpvsyfSoDoh7 bfPDzKWNFXABNfzFd0LXmP5zr52xgUoBM/ygQHrnDbGdS3tWaVJt0fIS3YCvD4QWSs1J 6xGJPTx2a/f7PY6y/8dV7LhpJCWvPUFXgWsnGy2DWHZpNMPOzLKCQ0r6gXGvXQFAgAdP lUe02KO2kXI9qat0iQ27cDTAWXP95+SZyc1m84gb1Ca2m3kBYpAU7wiVCte9H/u/f6Ew BWZtu1/ZdeMoS7jR7UAEq4ijldQoiu8j7AUyCCz9ljagH53alaWEpMlNz4G5mjsaFkS0 rhNg== X-Gm-Message-State: APjAAAXVBEKF2I4iatJNk6ILppTyBMsH5fORdVoQNR81yIX7XjhfZElP kKCWH1izxHFrZ8hFi8k0IM3zsg== X-Google-Smtp-Source: APXvYqwHsKSQV6I9mjXHAEgdBA++fF9BBgmUzDjfSTR1QhuVAldUoEH8YYhTYMQZowCqoj3IisMksg== X-Received: by 2002:a5d:654a:: with SMTP id z10mr19843524wrv.153.1556639276085; Tue, 30 Apr 2019 08:47:56 -0700 (PDT) Received: from localhost ([163.172.211.46]) by smtp.gmail.com with ESMTPSA id x20sm18216816wrg.29.2019.04.30.08.47.54 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Apr 2019 08:47:55 -0700 (PDT) From: "Basil L. Contovounesios" To: Rudi Schlatte Subject: Re: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer References: Date: Tue, 30 Apr 2019 16:47:53 +0100 In-Reply-To: (Rudi Schlatte's message of "Tue, 30 Apr 2019 16:52:46 +0200") Message-ID: <871s1jwl3q.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 35504 wishlist quit Rudi Schlatte writes: > The ‘g’ key seems to be the standard way to refresh a list of things. > For example, ‘g’ runs ‘gnus-group-get-new-news’ in the gnus *Group* > buffer and ‘revert-buffer’ in vc-dir-mod [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [163.172.211.46 listed in zen.spamhaus.org] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.44 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.44 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 35504 Cc: 35504@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 35504 wishlist quit Rudi Schlatte writes: > The ‘g’ key seems to be the standard way to refresh a list of things. > For example, ‘g’ runs ‘gnus-group-get-new-news’ in the gnus *Group* > buffer and ‘revert-buffer’ in vc-dir-mod [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: constantly.at] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.44 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.44 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [163.172.211.46 listed in zen.spamhaus.org] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager severity 35504 wishlist quit Rudi Schlatte writes: > The =E2=80=98g=E2=80=99 key seems to be the standard way to refresh a lis= t of things. > For example, =E2=80=98g=E2=80=99 runs =E2=80=98gnus-group-get-new-news=E2= =80=99 in the gnus *Group* > buffer and =E2=80=98revert-buffer=E2=80=99 in vc-dir-mode. In the packag= e list, > =E2=80=98package-menu-refresh=E2=80=99 is run by the =E2=80=98r=E2=80=99 = key instead. > > Since =E2=80=98g=E2=80=99 is unbound in =E2=80=98package-menu-mode=E2=80= =99, could a binding be added to > run =E2=80=98package-menu-refresh=E2=80=99 for that key? It is not unbound; it is bound to the standard command revert-buffer, which in this case calls tabulated-list-revert, which in turn runs tabulated-list-revert-hook, which in turn calls package-menu--refresh. [The command revert-buffer is bound to 'g' by default in modes derived from special-mode; see (info "(elisp) Basic Major Modes").] Having said that, I know neither what the intention is behind having two keys bound to different commands, nor why the 'g' key is not documented under (info "(emacs) Package Menu"). Hopefully someone else can shed some light upon this. At least two other people, including Stefan (CCed), share your preference: https://lists.gnu.org/archive/html/emacs-devel/2010-10/msg01092.html https://lists.gnu.org/archive/html/emacs-devel/2010-10/msg01097.html FWIW, as someone who doesn't understand the purpose of the package-menu--refresh binding, I am also in favour of merging the 'r' and 'g' bindings. Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 30 11:57:34 2019 Received: (at control) by debbugs.gnu.org; 30 Apr 2019 15:57:34 +0000 Received: from localhost ([127.0.0.1]:42229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLV8P-0002h7-PV for submit@debbugs.gnu.org; Tue, 30 Apr 2019 11:57:34 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:42864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLV8O-0002gu-AU for control@debbugs.gnu.org; Tue, 30 Apr 2019 11:57:32 -0400 Received: by mail-wr1-f52.google.com with SMTP id l2so5984043wrb.9 for ; Tue, 30 Apr 2019 08:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:user-agent:mime-version; bh=AsIdT/ZgzULjYgNYYSf93Od3wlUjYWtB6S3+kpLS9G4=; b=N1lyE9QQuTSIy8gPr4WEU7gd8wKg4cMY619qq2daZm43CGsIEedVDd/nm2Gj657FsP I6sfH1RIMV5b64uexHJzRE1diFn9CoYYW6ME0Lv/g/EKnIQhuajUzSIzuUgyhwEOFt/b jg7c+g7Xm5OZWUXPdlh/nQaqIQcV4uDb2XMDNxG4WPyVY+Cdk1FxEVdlYcncyVlKAnME 1MuRjMrfRFjUdiJ8TsJy261RYo1tlcWd0/cFto2xTpGQykFHckMsgSXas/j+GcH7oYtt bx5wRb9rYTVY8HImw+vn9xndVk9JOOPIsj0+j6PA+UvSCXila38LRSh2qwyUTzPV/WED AsUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=AsIdT/ZgzULjYgNYYSf93Od3wlUjYWtB6S3+kpLS9G4=; b=naUczrINRAYip2AgkxAKDdbvvw9d4u3+llOHL9MMLFB7yKyi/uYCdpVgLe8CZmXVWN LrwPJhn/1HeRBWz03LWMCOw30Dut7wzUmhqscd6HVh6fI/0ww6dAHRQadE7H2lVsEWcM oSgdvBHxghzFsMPsaZ94hP+7osypsZhbWochx9p/HoO04yNaB6qxo0vXCJAklVSjn1aa N6HGQQqmKxsrDwVle8fXTMU1eB6zOzjdZuDmEgvgBtCOzP/wWlwn4ivXVrz38zcVUYOM oIyVtCppiXXhbcX12Cp9tSMP8k/9/veDUu9XBED/xzeJyLBoa1oI1neV8hluheNMFXnD P3aw== X-Gm-Message-State: APjAAAWB5sKtIbRQPHMEGFDhUaWXIrYx9R8rNkE/1f3UeCSvhZinN9d7 BjwbmEQg746b8Lbbh7w7Knezrc/4ZJwkMA== X-Google-Smtp-Source: APXvYqz8zicD5iSCenJol2wEgjUMiRNc0vU81fyxjOAeBOoinJXmq4wo4osTbi3ckKW82W3bqhe+zw== X-Received: by 2002:adf:a28b:: with SMTP id s11mr5060943wra.16.1556639846196; Tue, 30 Apr 2019 08:57:26 -0700 (PDT) Received: from localhost ([163.172.211.46]) by smtp.gmail.com with ESMTPSA id z140sm5249297wmc.27.2019.04.30.08.57.25 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Apr 2019 08:57:25 -0700 (PDT) From: "Basil L. Contovounesios" To: Subject: Control message for bug#35504 Date: Tue, 30 Apr 2019 16:57:24 +0100 Message-ID: <87sgtzv63f.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 35504 wishlist quit [I forgot to Bcc the control server in my last reply to the bug address.] -- Basil Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [163.172.211.46 listed in zen.spamhaus.org] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.52 listed in list.dnswl.org] X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 35504 wishlist quit [I forgot to Bcc the control server in my last reply to the bug address.] -- Basil Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.52 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [163.172.211.46 listed in zen.spamhaus.org] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager severity 35504 wishlist quit [I forgot to Bcc the control server in my last reply to the bug address.] -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 30 12:01:17 2019 Received: (at 35504) by debbugs.gnu.org; 30 Apr 2019 16:01:17 +0000 Received: from localhost ([127.0.0.1]:42247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLVC0-0003t5-R5 for submit@debbugs.gnu.org; Tue, 30 Apr 2019 12:01:17 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:48711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLVBy-0003n7-Sx for 35504@debbugs.gnu.org; Tue, 30 Apr 2019 12:01:15 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7671422703; Tue, 30 Apr 2019 12:01:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 30 Apr 2019 12:01:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=F3xKTDPa59iTsom3f2fN4yso7BvPzkwmkW5M+IJ+v q4=; b=eR2K3aO63DGY/Gmz8/qc6V367HWFZ341Tu09VUVB8lJQuAlvxl98Yqh7p Q+9+OSInQQIgTr5C6eJm48HRSKkEtcwTXbRhMkWD6fiYuyahFQKXAQKzc3CXeg10 KYkqI8AkTYYGRPCURIhaBA9GTUD0O6jDGNQs96tYNTz/T6Nen/vSJVsgGJxUKCoK j0Et3Myl5tCEb/q5nLc1tVf+OMyBBtbtyNXM6sPipCV+e8Rko70vuNuCmIiukFQF p8rrA0elbh01VohlcSBZKBKg1jLQ2W+5SO39pQsSyTWtcAdtstTf9+c4Dj6kzCC2 ot2aSp4pB6FQz/0zpfUbmGmMgnLRQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieehgdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtggfuhfgjfffgkfhfvffosehtqhhmtdhhtdejnecuhfhrohhmpeftuhguihcu ufgthhhlrghtthgvuceorhhuughisegtohhnshhtrghnthhlhidrrghtqeenucfkphepud dvledrvdegtddrieekrddugeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehruhguihes tghonhhsthgrnhhtlhihrdgrthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from relax.ifi.uio.no (relax.ifi.uio.no [129.240.68.144]) by mail.messagingengine.com (Postfix) with ESMTPA id 3E121E44B6; Tue, 30 Apr 2019 12:01:06 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer From: Rudi Schlatte In-Reply-To: <871s1jwl3q.fsf@tcd.ie> Date: Tue, 30 Apr 2019 18:00:27 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <871s1jwl3q.fsf@tcd.ie> To: "Basil L. Contovounesios" X-Mailer: Apple Mail (2.3445.104.8) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35504 Cc: 35504@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > On 30 Apr 2019, at 17:47, Basil L. Contovounesios = wrote: >=20 > Rudi Schlatte writes: >=20 >> The =E2=80=98g=E2=80=99 key seems to be the standard way to refresh a = list of things. >> For example, =E2=80=98g=E2=80=99 runs =E2=80=98gnus-group-get-new-news=E2= =80=99 in the gnus *Group* >> buffer and =E2=80=98revert-buffer=E2=80=99 in vc-dir-mode. In the = package list, >> =E2=80=98package-menu-refresh=E2=80=99 is run by the =E2=80=98r=E2=80=99= key instead. >>=20 >> Since =E2=80=98g=E2=80=99 is unbound in =E2=80=98package-menu-mode=E2=80= =99, could a binding be added to >> run =E2=80=98package-menu-refresh=E2=80=99 for that key? >=20 > It is not unbound; it is bound to the standard command revert-buffer, > which in this case calls tabulated-list-revert, which in turn runs > tabulated-list-revert-hook, which in turn calls package-menu--refresh. Thanks for having a look! I could swear I checked whether `g' was bound = or not, but apparently I didn't. Anyway, allow me to rephrase my bug = report from a more end-user-y perspective. Pressing `g' in a gnus group buffer connects to the network, fetches new = data from various servers, and updates the buffer accordingly. The key = `r' achieves the same effect in a package list buffer: I can see Emacs = contacting the servers set up in `package-archives', get a message how = many packages can be updated, etc. The `g' key, on the other hand, does = not do that in a package list buffer. I find my fingers still wanting to press `g' to achieve the effect of = `r' after some months of retraining, hence the bug report. FWIW, I completely agree with the "Wishlist" severity you set for the = bug. Thanks again, Rudi= From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 30 12:59:23 2019 Received: (at 35504) by debbugs.gnu.org; 30 Apr 2019 16:59:23 +0000 Received: from localhost ([127.0.0.1]:42287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLW6F-0006Gc-BW for submit@debbugs.gnu.org; Tue, 30 Apr 2019 12:59:23 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:48512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLW6C-0006GR-IQ for 35504@debbugs.gnu.org; Tue, 30 Apr 2019 12:59:21 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x3UGxCKY019179; Tue, 30 Apr 2019 12:59:13 -0400 Received: by pastel.home (Postfix, from userid 20848) id 94B3969B4D; Tue, 30 Apr 2019 12:59:11 -0400 (EDT) From: Stefan Monnier To: Rudi Schlatte Subject: Re: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer Message-ID: References: <871s1jwl3q.fsf@tcd.ie> Date: Tue, 30 Apr 2019 12:59:11 -0400 In-Reply-To: (Rudi Schlatte's message of "Tue, 30 Apr 2019 18:00:27 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.5 X-NAI-Spam-Rules: 6 Rules triggered SORT_LNK_1HTP_CTPLN=0.2, GEN_SPAM_FEATRE=0.1, SORT_LNK_1HTP_CTPLN_W_GEN_SPAM_FEATRE=0.1, TRK_NCM1=0.1, EDT_SA_DN_PASS=0, RV6536=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6536> : inlines <7063> : streams <1820180> : uri <2838952> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35504 Cc: "Basil L. Contovounesios" , 35504@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I find my fingers still wanting to press `g' to achieve the effect of `r' > after some months of retraining, hence the bug report. Agreed (IOW my opinion hasn't changed since https://lists.gnu.org/archive/html/emacs-devel/2010-10/msg01097.html). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 14 15:22:12 2019 Received: (at 35504) by debbugs.gnu.org; 14 Sep 2019 19:22:12 +0000 Received: from localhost ([127.0.0.1]:47160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9Dca-0006k7-0Q for submit@debbugs.gnu.org; Sat, 14 Sep 2019 15:22:12 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:32969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9DcX-0006jl-Lt for 35504@debbugs.gnu.org; Sat, 14 Sep 2019 15:22:10 -0400 Received: by mail-pg1-f194.google.com with SMTP id n190so17051404pgn.0 for <35504@debbugs.gnu.org>; Sat, 14 Sep 2019 12:22:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=dhxe0hMIkgvIYJ/FMxTMSzPtNO3lFHMxo2imryLwuao=; b=IoQD19aq9K0inPcjRRCIwPG16aUQLY/TkrOMQp0uYX1zWXTmK28MQlF5j27tKsyt36 BPG+EtNkzSG6Gzlah6B4HBcd6/vKX8D8h3h74qDS8JDIOhOHByhNOixfi6aCC15Ru+y9 uGl9K/fSAxXyz80CZpxmWKR5bGleKk3kpdD6e34enP8OOzW1Hakk2RBo+ASrwznRMesd k7rlmtK9CQrrcU66AB+nV4nVh0Vu5jnFaOXsIl9RJd32anDxP/OSfCPV9NLGr/T/j3f0 38Wr4uOqG0sOt9GlL1aqTJ5+DDshnksb0mran3A5owBvzAJ5ifIpeHqpd9yUprH7yR8x LdUw== X-Gm-Message-State: APjAAAXrmmPTFXwF3xNzKJXsfOvhkiHP8WXwggeSSzDSU+ZDWVP6+X8i 1z4yLvbdNBDF1NYfikO6GT1Hwfpziq9QTWSCbAk= X-Google-Smtp-Source: APXvYqwCyCf2AaqwxI+mkwm8uWCHjhxYJiVK5h+1ISwkX9FJlip33vrqJexKGVVeDzwXrlAo+ql7api48UjXHLKa5eM= X-Received: by 2002:a63:ef4d:: with SMTP id c13mr12468032pgk.200.1568488923298; Sat, 14 Sep 2019 12:22:03 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Sat, 14 Sep 2019 21:21:51 +0200 Message-ID: Subject: Re: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer To: Stefan Monnier Content-Type: multipart/mixed; boundary="0000000000001bd0d805928849c9" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35504 Cc: "Basil L. Contovounesios" , 35504@debbugs.gnu.org, Rudi Schlatte X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000001bd0d805928849c9 Content-Type: text/plain; charset="UTF-8" Stefan Monnier writes: >> I find my fingers still wanting to press `g' to achieve the effect of `r' >> after some months of retraining, hence the bug report. > > Agreed (IOW my opinion hasn't changed since > https://lists.gnu.org/archive/html/emacs-devel/2010-10/msg01097.html). I also agree. How about the attached patch? Best regards, Stefan Kangas --0000000000001bd0d805928849c9 Content-Type: application/octet-stream; name="0001-Bind-g-to-package-menu-refresh-in-package-menu.patch" Content-Disposition: attachment; filename="0001-Bind-g-to-package-menu-refresh-in-package-menu.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k0jxs8bb0 RnJvbSA3OWJjN2QzOWYyZDZkZjhhNWQyNTJlMDJlNzg1ZTlhZjU3ZDRhZTVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBGcmksIDI2IEp1bCAyMDE5IDEyOjQ5OjM1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g QmluZCAnZycgdG8gJ3BhY2thZ2UtbWVudS1yZWZyZXNoJyBpbiBwYWNrYWdlIG1lbnUKCiogbGlz cC9lbWFjcy1saXNwL3BhY2thZ2UuZWwgKHBhY2thZ2UtbWVudS1tb2RlLW1hcCk6IEJpbmQgJ2cn IHRvCidwYWNrYWdlLW1lbnUtcmVmcmVzaCcgaW5zdGVhZCBvZiAncmV2ZXJ0LWJ1ZmZlcicuICAo QnVnIzM1NTA0KQoqIGRvYy9lbWFjcy9wYWNrYWdlLnRleGkgKFBhY2thZ2UgTWVudSk6IERvY3Vt ZW50IGl0LgoqIGV0Yy9ORVdTOiBBbm5vdW5jZSBpdC4KLS0tCiBkb2MvZW1hY3MvcGFja2FnZS50 ZXhpICAgICB8IDEyICsrKysrKysrKysrKwogZXRjL05FV1MgICAgICAgICAgICAgICAgICAgfCAg NSArKysrKwogbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwgfCAgMSArCiAzIGZpbGVzIGNoYW5n ZWQsIDE4IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9kb2MvZW1hY3MvcGFja2FnZS50ZXhp IGIvZG9jL2VtYWNzL3BhY2thZ2UudGV4aQppbmRleCA0YjMzZjI1MGM0Li4zNWZhMWY4NmQyIDEw MDY0NAotLS0gYS9kb2MvZW1hY3MvcGFja2FnZS50ZXhpCisrKyBiL2RvYy9lbWFjcy9wYWNrYWdl LnRleGkKQEAgLTg1LDE2ICs4NSwxOSBAQCBQYWNrYWdlIE1lbnUKIAogQHRhYmxlIEBrYmQKIEBp dGVtIGgKK0BmaW5kZXggcGFja2FnZS1tZW51LXF1aWNrLWhlbHAKIFByaW50IGEgc2hvcnQgbWVz c2FnZSBzdW1tYXJpemluZyBob3cgdG8gdXNlIHRoZSBwYWNrYWdlIG1lbnUKIChAY29kZXtwYWNr YWdlLW1lbnUtcXVpY2staGVscH0pLgogCiBAaXRlbSA/CiBAaXRlbXggQGtleXtSRVR9CitAZmlu ZGV4IHBhY2thZ2UtbWVudS1kZXNjcmliZS1wYWNrYWdlCiBEaXNwbGF5IGEgaGVscCBidWZmZXIg Zm9yIHRoZSBwYWNrYWdlIG9uIHRoZSBjdXJyZW50IGxpbmUKIChAY29kZXtwYWNrYWdlLW1lbnUt ZGVzY3JpYmUtcGFja2FnZX0pLCBzaW1pbGFyIHRvIHRoZSBoZWxwIHdpbmRvdwogZGlzcGxheWVk IGJ5IHRoZSBAa2Jke0MtaCBQfSBjb21tYW5kIChAcHhyZWZ7UGFja2FnZXN9KS4KIAogQGl0ZW0g aQorQGZpbmRleCBwYWNrYWdlLW1lbnUtbWFyay1pbnN0YWxsCiBNYXJrIHRoZSBwYWNrYWdlIG9u IHRoZSBjdXJyZW50IGxpbmUgZm9yIGluc3RhbGxhdGlvbgogKEBjb2Rle3BhY2thZ2UtbWVudS1t YXJrLWluc3RhbGx9KS4gIElmIHRoZSBwYWNrYWdlIHN0YXR1cyBpcwogQHNhbXB7YXZhaWxhYmxl fSwgdGhpcyBhZGRzIGFuIEBzYW1we0l9IGNoYXJhY3RlciB0byB0aGUgc3RhcnQgb2YgdGhlCkBA IC0xMDIsNiArMTA1LDcgQEAgUGFja2FnZSBNZW51CiBwYWNrYWdlLgogCiBAaXRlbSBkCitAZmlu ZGV4IHBhY2thZ2UtbWVudS1tYXJrLWRlbGV0ZQogTWFyayB0aGUgcGFja2FnZSBvbiB0aGUgY3Vy cmVudCBsaW5lIGZvciBkZWxldGlvbgogKEBjb2Rle3BhY2thZ2UtbWVudS1tYXJrLWRlbGV0ZX0p LiAgSWYgdGhlIHBhY2thZ2Ugc3RhdHVzIGlzCiBAc2FtcHtpbnN0YWxsZWR9LCB0aGlzIGFkZHMg YSBAc2FtcHtEfSBjaGFyYWN0ZXIgdG8gdGhlIHN0YXJ0IG9mIHRoZQpAQCAtMTEwLDYgKzExNCw3 IEBAIFBhY2thZ2UgTWVudQogZW50YWlscy4KIAogQGl0ZW0gfgorQGZpbmRleCBwYWNrYWdlLW1l bnUtbWFyay1vYnNvbGV0ZS1mb3ItZGVsZXRpb24KIE1hcmsgYWxsIG9ic29sZXRlIHBhY2thZ2Vz IGZvciBkZWxldGlvbgogKEBjb2Rle3BhY2thZ2UtbWVudS1tYXJrLW9ic29sZXRlLWZvci1kZWxl dGlvbn0pLiAgVGhpcyBtYXJrcyBmb3IKIGRlbGV0aW9uIGFsbCB0aGUgcGFja2FnZXMgd2hvc2Ug c3RhdHVzIGlzIEBzYW1we29ic29sZXRlfS4KQEAgLTEyMCw2ICsxMjUsNyBAQCBQYWNrYWdlIE1l bnUKIGN1cnJlbnQgbGluZSBieSBhbiBAa2Jke2l9IG9yIEBrYmR7ZH0gY29tbWFuZC4KIAogQGl0 ZW0gVQorQGZpbmRleCBwYWNrYWdlLW1lbnUtbWFyay11cGdyYWRlcwogTWFyayBhbGwgcGFja2Fn ZSB3aXRoIGEgbmV3ZXIgYXZhaWxhYmxlIHZlcnNpb24gZm9yIHVwZ3JhZGluZwogKEBjb2Rle3Bh Y2thZ2UtbWVudS1tYXJrLXVwZ3JhZGVzfSkuICBUaGlzIHBsYWNlcyBhbiBpbnN0YWxsYXRpb24g bWFyawogb24gdGhlIG5ldyBhdmFpbGFibGUgdmVyc2lvbnMsIGFuZCBhIGRlbGV0aW9uIG1hcmsg b24gdGhlIG9sZApAQCAtMTI3LDI2ICsxMzMsMzIgQEAgUGFja2FnZSBNZW51CiAKIEBpdGVtIHgK IEB2aW5kZXggcGFja2FnZS1tZW51LWFzeW5jCitAZmluZGV4IHBhY2thZ2UtbWVudS1leGVjdXRl CiBEb3dubG9hZCBhbmQgaW5zdGFsbCBhbGwgcGFja2FnZXMgbWFya2VkIHdpdGggQGtiZHtpfSwg YW5kIHRoZWlyCiBkZXBlbmRlbmNpZXM7IGFsc28sIGRlbGV0ZSBhbGwgcGFja2FnZXMgbWFya2Vk IHdpdGggQGtiZHtkfQogKEBjb2Rle3BhY2thZ2UtbWVudS1leGVjdXRlfSkuICBUaGlzIGFsc28g cmVtb3ZlcyB0aGUgbWFya3MuCiAKK0BpdGVtIGcKIEBpdGVtIHIKK0BmaW5kZXggcGFja2FnZS1t ZW51LXJlZnJlc2gKIFJlZnJlc2ggdGhlIHBhY2thZ2UgbGlzdCAoQGNvZGV7cGFja2FnZS1tZW51 LXJlZnJlc2h9KS4gIFRoaXMgZmV0Y2hlcwogdGhlIGxpc3Qgb2YgYXZhaWxhYmxlIHBhY2thZ2Vz IGZyb20gdGhlIHBhY2thZ2UgYXJjaGl2ZSBhZ2FpbiwgYW5kCiByZWNvbXB1dGVzIHRoZSBwYWNr YWdlIGxpc3QuCiAKIEBpdGVtIGYKK0BmaW5kZXggcGFja2FnZS1tZW51LWZpbHRlcgogRmlsdGVy IHRoZSBwYWNrYWdlIGxpc3QgKEBjb2Rle3BhY2thZ2UtbWVudS1maWx0ZXJ9KS4gIFRoaXMgcHJv bXB0cwogZm9yIGEga2V5d29yZCAoZS5nLiwgQHNhbXB7Z2FtZXN9KSwgdGhlbiBzaG93cyBvbmx5 IHRoZSBwYWNrYWdlcwogdGhhdCByZWxhdGUgdG8gdGhhdCBrZXl3b3JkLiAgVG8gcmVzdG9yZSB0 aGUgZnVsbCBwYWNrYWdlIGxpc3QsCiB0eXBlIEBrYmR7cX0uCiAKIEBpdGVtIEgKK0BmaW5kZXgg cGFja2FnZS1tZW51LWhpZGUtcGFja2FnZQogUGVybWFuZW50bHkgaGlkZSBwYWNrYWdlcyB0aGF0 IG1hdGNoIGEgcmVnZXhwCiAoQGNvZGV7cGFja2FnZS1tZW51LWhpZGUtcGFja2FnZX0pLgogCiBA aXRlbSAoCitAZmluZGV4IHBhY2thZ2UtbWVudS10b2dnbGUtaGlkaW5nCiBUb2dnbGUgdmlzaWJp bGl0eSBvZiBvbGQgdmVyc2lvbnMgb2YgcGFja2FnZXMgYW5kIGFsc28gb2YgdmVyc2lvbnMKIGZy b20gbG93ZXItcHJpb3JpdHkgYXJjaGl2ZXMgKEBjb2Rle3BhY2thZ2UtbWVudS10b2dnbGUtaGlk aW5nfSkuCiBAZW5kIHRhYmxlCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4 IDI1MmM2YmY5YjkuLjI5YjljNmMzNTQgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9O RVdTCkBAIC05NzEsNiArOTcxLDExIEBAIGVhcmx5IGluaXQgZmlsZS4KIC0tLQogKioqIEltZW51 IHN1cHBvcnQgaGFzIGJlZW4gYWRkZWQgdG8gJ3BhY2thZ2UtbWVudS1tb2RlJy4KIAorKysrCisq KiogJ2cnIGlzIG5vdyBib3VuZCB0byAncGFja2FnZS1tZW51LXJlZnJlc2gnLgorJ2cnIHVzZWQg dG8gYmUgYm91bmQgdG8gJ3JldmVydC1idWZmZXInLCB3aGljaCBub3cgcmVxdWlyZXMgeW91IHRv Cit0eXBlICdNLXggcmV2ZXJ0LWJ1ZmZlcicgaW5zdGVhZC4KKwogKiogSW5mbwogCiArKysKZGlm ZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsIGIvbGlzcC9lbWFjcy1saXNwL3Bh Y2thZ2UuZWwKaW5kZXggZWYwYzUxNzFkZS4uYTc5NzU5Yzk3NiAxMDA2NDQKLS0tIGEvbGlzcC9l bWFjcy1saXNwL3BhY2thZ2UuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKQEAg LTI2MTksNiArMjYxOSw3IEBAIHBhY2thZ2UtbWVudS1tb2RlLW1hcAogICAgIChkZWZpbmUta2V5 IG1hcCAiZCIgJ3BhY2thZ2UtbWVudS1tYXJrLWRlbGV0ZSkKICAgICAoZGVmaW5lLWtleSBtYXAg ImkiICdwYWNrYWdlLW1lbnUtbWFyay1pbnN0YWxsKQogICAgIChkZWZpbmUta2V5IG1hcCAiVSIg J3BhY2thZ2UtbWVudS1tYXJrLXVwZ3JhZGVzKQorICAgIChkZWZpbmUta2V5IG1hcCAiZyIgJ3Bh Y2thZ2UtbWVudS1yZWZyZXNoKQogICAgIChkZWZpbmUta2V5IG1hcCAiciIgJ3BhY2thZ2UtbWVu dS1yZWZyZXNoKQogICAgIChkZWZpbmUta2V5IG1hcCAiZiIgJ3BhY2thZ2UtbWVudS1maWx0ZXIp CiAgICAgKGRlZmluZS1rZXkgbWFwICJ+IiAncGFja2FnZS1tZW51LW1hcmstb2Jzb2xldGUtZm9y LWRlbGV0aW9uKQotLSAKMi4yMy4wCgo= --0000000000001bd0d805928849c9-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 14 15:22:34 2019 Received: (at control) by debbugs.gnu.org; 14 Sep 2019 19:22:34 +0000 Received: from localhost ([127.0.0.1]:47163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9Dcw-0006kw-CQ for submit@debbugs.gnu.org; Sat, 14 Sep 2019 15:22:34 -0400 Received: from mail-pg1-f181.google.com ([209.85.215.181]:40470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9Dcu-0006kd-F9 for control@debbugs.gnu.org; Sat, 14 Sep 2019 15:22:32 -0400 Received: by mail-pg1-f181.google.com with SMTP id w10so17044703pgj.7 for ; Sat, 14 Sep 2019 12:22:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=79n/nSRO7drZzT9F+DrIMShS7khCUi7ufCktt2FYQDs=; b=llk5XiifpEsFXWa7wNRKLr68/guiGD1jBVusAUKe0QErth5l8OBdAltQnCNwhUx7gd Bt7lOrvXnO0WnED4nh5SxFv7AX+lBxan5Cff8DxAPeS1A5GZ/PYObNfdCGJaJchywmB5 2RBw1TZGUiuEuNDtlt83paeaziuuUByj25+3ZC7eCIe+BZ4ayOrvvYL6pfMqXfutxK41 0n/HNwsRCinZt3UgssmZWUEq+w1VJi7qVBfP728LqHzE4o75C2W2Cq/zuBQaPWPtBahD foNpcPKnxhFzr72UXwViCiXllqvOlh/4wpMY/KsKdnvC4fXpR6ardiFc2ZxJUHIk+aGE xELw== X-Gm-Message-State: APjAAAUjiS9TvAejuG97GMIQVEhPBIBG629euVqzix6TyjuHUcblVfpA dLWspAk7jk7uhnBCl7yvvxOxe0ULSecVyMA6mQ5uxU8Z X-Google-Smtp-Source: APXvYqzaPNaWIQWWLBI0EtW7zXbRTHxD5oCN51qlgBF/YM/0cE8W23ee2wmK9R4nOXObB9hbA01qSB6qTGFtv6rZSKc= X-Received: by 2002:a63:4c5c:: with SMTP id m28mr51559653pgl.333.1568488946591; Sat, 14 Sep 2019 12:22:26 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Sat, 14 Sep 2019 21:22:15 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 35504 + patch quit Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.215.181 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.181 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 BLANK_SUBJECT Subject is present but empty 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 35504 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 16 14:12:19 2019 Received: (at 35504) by debbugs.gnu.org; 16 Sep 2019 18:12:19 +0000 Received: from localhost ([127.0.0.1]:51016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9vU2-0000n4-UD for submit@debbugs.gnu.org; Mon, 16 Sep 2019 14:12:19 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9vTy-0000mo-II for 35504@debbugs.gnu.org; Mon, 16 Sep 2019 14:12:14 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 09009447DD4; Mon, 16 Sep 2019 14:12:09 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BB2BB447DD1; Mon, 16 Sep 2019 14:12:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1568657527; bh=KJW+kL20LnckZ7nMboieKyrzw4dTm3fZ1Ua0Ms/1qUE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HQUDaqkHN40z55s4F7oWhx9upFkl917wXcjJ6jK83wdBuydaUuaPhpkamaCfJs1/q GVWULXv01HlofkMX6etG+VMbnngQYOTIGrRssl5UsGhb/UUgt1KD0PEwOxzpYPh0o7 l2A2bG4Rx/TL3uoRtNFLj9S6nkGpvFl66eSlG2d01McE4Yp1I3NOfA3HmWtgssLSUK o1WfCM/q0JH2yZXRhibK1EtYHVPJmq1c6zIBxOI8btJhqLJbACURt50Gh1lQ5uNNmI 6lR8mYTKDm+hIHrZmtK39bOcxCRHZlgqsVR5QmhPeO3Z907fXarTCwEvaNTqYNot6u QkRgvqvUbAw4Q== Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 85ABA1204F5; Mon, 16 Sep 2019 14:12:07 -0400 (EDT) From: Stefan Monnier To: Stefan Kangas Subject: Re: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer Message-ID: References: Date: Mon, 16 Sep 2019 14:12:06 -0400 In-Reply-To: (Stefan Kangas's message of "Sat, 14 Sep 2019 21:21:51 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.077 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35504 Cc: "Basil L. Contovounesios" , 35504@debbugs.gnu.org, Rudi Schlatte X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I also agree. How about the attached patch? Fine by me. I wonder, tho: why not set revert-buffer-function and then redefine `package-menu-refresh` as an obsolete alias for `revert-buffer`? Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 19:59:45 2019 Received: (at 35504) by debbugs.gnu.org; 2 Oct 2019 23:59:45 +0000 Received: from localhost ([127.0.0.1]:38526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFoX2-0000Te-HK for submit@debbugs.gnu.org; Wed, 02 Oct 2019 19:59:44 -0400 Received: from mail-pg1-f180.google.com ([209.85.215.180]:43497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFoX0-0000TQ-Rq for 35504@debbugs.gnu.org; Wed, 02 Oct 2019 19:59:43 -0400 Received: by mail-pg1-f180.google.com with SMTP id v27so572584pgk.10 for <35504@debbugs.gnu.org>; Wed, 02 Oct 2019 16:59:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o+tfCAEGYGm3jIG79EWLWLV8TY5+7h2IyFViN14F2ew=; b=FN36BulogT7+PXISATVhlOntZUnoGgNbZ14eVlDLv413dSZUIg5MX2l3QFpxdhAX6G m0sVT73beNRGCj65qX2d2r0m/3PUwBFJfyJllqCp7b4IsSZJ6wUigbEfYLvstdBMzqfn nJbJm7dfHTJgL4RVZYWyqYnomTkr0lRjqThQkUgDUzM85LTWGEDMDkQ8PJiQATQTFD6H wOParZRmXL30hywGKz3CIC2muoUoQBvjBQkzoaPsEQCCi16Q5UV/+PMZdoIzb1jJOLQ0 lmpvpLQqB9XAS8u6HPhgzef5cZDleA45WZQ82dOuRm6PJHkXjVa1iEYkiA5zHCPeVxny D4Kg== X-Gm-Message-State: APjAAAX9+cjrIj3EqqcvOrttlb5QfPWGX6nlaM54WibuiEgJ+KUtMgOx /gDgvb+Qs2HAvWjcelpaaEUq0WTMH4/4rBsGsgw= X-Google-Smtp-Source: APXvYqxt0AFoSIlshberexnodsZlktrLmghcWf6oTDdascwTMVF2p4ueAnltZ90ngVMNMxFcpf2K+9w+/rhcy5c5ZQY= X-Received: by 2002:a17:90a:1150:: with SMTP id d16mr7563905pje.2.1570060776935; Wed, 02 Oct 2019 16:59:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stefan Kangas Date: Thu, 3 Oct 2019 01:59:25 +0200 Message-ID: Subject: Re: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer To: Stefan Monnier Content-Type: multipart/mixed; boundary="000000000000e2bc4c0593f6423d" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 35504 Cc: "Basil L. Contovounesios" , 35504@debbugs.gnu.org, Rudi Schlatte X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000e2bc4c0593f6423d Content-Type: text/plain; charset="UTF-8" Stefan Monnier writes: > > I also agree. How about the attached patch? > > Fine by me. I wonder, tho: why not set revert-buffer-function and then > redefine `package-menu-refresh` as an obsolete alias for `revert-buffer`? Sure, I've tried to do that in the attached patch. WDYT? Best regards, Stefan Kangas --000000000000e2bc4c0593f6423d Content-Type: text/x-patch; charset="UTF-8"; name="0001-Make-g-refresh-package-data-in-package-menu.patch" Content-Disposition: attachment; filename="0001-Make-g-refresh-package-data-in-package-menu.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k19xmxwt0 RnJvbSBlNWJkMjIzMjIyMGEyNWM4Yzk3N2FiMjAwOWFkMGY5NmZjYTI5Y2FjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBGcmksIDI2IEp1bCAyMDE5IDEyOjQ5OjM1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g TWFrZSAnZycgcmVmcmVzaCBwYWNrYWdlIGRhdGEgaW4gcGFja2FnZSBtZW51CgoqIGxpc3AvZW1h Y3MtbGlzcC9wYWNrYWdlLmVsIChwYWNrYWdlLW1lbnUtcmV2ZXJ0KTogUmVuYW1lIGZyb20KJ3Bh Y2thZ2UtbWVudS1yZWZyZXNoJy4KKHBhY2thZ2UtbWVudS1yZWZyZXNoKTogRGVmaW5lIG9ic29s ZXRlIGZ1Y3Rpb24gYWxpYXMgZm9yIHRoZSBhYm92ZS4KKHBhY2thZ2UtbWVudS1tb2RlKTogU2V0 ICdwYWNrYWdlLW1lbnUtcmVmcmVzaCcgdG8gdXNlIHRoZSBuZXcgbmFtZS4KKHBhY2thZ2UtbWVu dS1tb2RlLW1hcCk6IFVwZGF0ZSBiaW5kaW5nIHRvIHVzZSB0aGUgbmV3Cm5hbWUuICAoQnVnIzM1 NTA0KQoKKiBkb2MvZW1hY3MvcGFja2FnZS50ZXhpIChQYWNrYWdlIE1lbnUpOiBEb2N1bWVudCBp dC4KKiBldGMvTkVXUzogQW5ub3VuY2UgaXQuCi0tLQogZG9jL2VtYWNzL3BhY2thZ2UudGV4aSAg ICAgfCAxNCArKysrKysrKysrKysrLQogZXRjL05FV1MgICAgICAgICAgICAgICAgICAgfCAgOCAr KysrKysrKwogbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwgfCAxMiArKysrKysrKystLS0KIDMg ZmlsZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9kb2MvZW1hY3MvcGFja2FnZS50ZXhpIGIvZG9jL2VtYWNzL3BhY2thZ2UudGV4aQppbmRl eCAyYzA5Y2E4OTAyLi44YTJkY2E5MTkzIDEwMDY0NAotLS0gYS9kb2MvZW1hY3MvcGFja2FnZS50 ZXhpCisrKyBiL2RvYy9lbWFjcy9wYWNrYWdlLnRleGkKQEAgLTg1LDE2ICs4NSwxOSBAQCBQYWNr YWdlIE1lbnUKIAogQHRhYmxlIEBrYmQKIEBpdGVtIGgKK0BmaW5kZXggcGFja2FnZS1tZW51LXF1 aWNrLWhlbHAKIFByaW50IGEgc2hvcnQgbWVzc2FnZSBzdW1tYXJpemluZyBob3cgdG8gdXNlIHRo ZSBwYWNrYWdlIG1lbnUKIChAY29kZXtwYWNrYWdlLW1lbnUtcXVpY2staGVscH0pLgogCiBAaXRl bSA/CiBAaXRlbXggQGtleXtSRVR9CitAZmluZGV4IHBhY2thZ2UtbWVudS1kZXNjcmliZS1wYWNr YWdlCiBEaXNwbGF5IGEgaGVscCBidWZmZXIgZm9yIHRoZSBwYWNrYWdlIG9uIHRoZSBjdXJyZW50 IGxpbmUKIChAY29kZXtwYWNrYWdlLW1lbnUtZGVzY3JpYmUtcGFja2FnZX0pLCBzaW1pbGFyIHRv IHRoZSBoZWxwIHdpbmRvdwogZGlzcGxheWVkIGJ5IHRoZSBAa2Jke0MtaCBQfSBjb21tYW5kIChA cHhyZWZ7UGFja2FnZXN9KS4KIAogQGl0ZW0gaQorQGZpbmRleCBwYWNrYWdlLW1lbnUtbWFyay1p bnN0YWxsCiBNYXJrIHRoZSBwYWNrYWdlIG9uIHRoZSBjdXJyZW50IGxpbmUgZm9yIGluc3RhbGxh dGlvbgogKEBjb2Rle3BhY2thZ2UtbWVudS1tYXJrLWluc3RhbGx9KS4gIElmIHRoZSBwYWNrYWdl IHN0YXR1cyBpcwogQHNhbXB7YXZhaWxhYmxlfSwgdGhpcyBhZGRzIGFuIEBzYW1we0l9IGNoYXJh Y3RlciB0byB0aGUgc3RhcnQgb2YgdGhlCkBAIC0xMDIsNiArMTA1LDcgQEAgUGFja2FnZSBNZW51 CiBwYWNrYWdlLgogCiBAaXRlbSBkCitAZmluZGV4IHBhY2thZ2UtbWVudS1tYXJrLWRlbGV0ZQog TWFyayB0aGUgcGFja2FnZSBvbiB0aGUgY3VycmVudCBsaW5lIGZvciBkZWxldGlvbgogKEBjb2Rl e3BhY2thZ2UtbWVudS1tYXJrLWRlbGV0ZX0pLiAgSWYgdGhlIHBhY2thZ2Ugc3RhdHVzIGlzCiBA c2FtcHtpbnN0YWxsZWR9LCB0aGlzIGFkZHMgYSBAc2FtcHtEfSBjaGFyYWN0ZXIgdG8gdGhlIHN0 YXJ0IG9mIHRoZQpAQCAtMTEwLDYgKzExNCw3IEBAIFBhY2thZ2UgTWVudQogZW50YWlscy4KIAog QGl0ZW0gfgorQGZpbmRleCBwYWNrYWdlLW1lbnUtbWFyay1vYnNvbGV0ZS1mb3ItZGVsZXRpb24K IE1hcmsgYWxsIG9ic29sZXRlIHBhY2thZ2VzIGZvciBkZWxldGlvbgogKEBjb2Rle3BhY2thZ2Ut bWVudS1tYXJrLW9ic29sZXRlLWZvci1kZWxldGlvbn0pLiAgVGhpcyBtYXJrcyBmb3IKIGRlbGV0 aW9uIGFsbCB0aGUgcGFja2FnZXMgd2hvc2Ugc3RhdHVzIGlzIEBzYW1we29ic29sZXRlfS4KQEAg LTEyMCw2ICsxMjUsNyBAQCBQYWNrYWdlIE1lbnUKIGN1cnJlbnQgbGluZSBieSBhbiBAa2Jke2l9 IG9yIEBrYmR7ZH0gY29tbWFuZC4KIAogQGl0ZW0gVQorQGZpbmRleCBwYWNrYWdlLW1lbnUtbWFy ay11cGdyYWRlcwogTWFyayBhbGwgcGFja2FnZSB3aXRoIGEgbmV3ZXIgYXZhaWxhYmxlIHZlcnNp b24gZm9yIHVwZ3JhZGluZwogKEBjb2Rle3BhY2thZ2UtbWVudS1tYXJrLXVwZ3JhZGVzfSkuICBU aGlzIHBsYWNlcyBhbiBpbnN0YWxsYXRpb24gbWFyawogb24gdGhlIG5ldyBhdmFpbGFibGUgdmVy c2lvbnMsIGFuZCBhIGRlbGV0aW9uIG1hcmsgb24gdGhlIG9sZApAQCAtMTI3LDI2ICsxMzMsMzIg QEAgUGFja2FnZSBNZW51CiAKIEBpdGVtIHgKIEB2aW5kZXggcGFja2FnZS1tZW51LWFzeW5jCitA ZmluZGV4IHBhY2thZ2UtbWVudS1leGVjdXRlCiBEb3dubG9hZCBhbmQgaW5zdGFsbCBhbGwgcGFj a2FnZXMgbWFya2VkIHdpdGggQGtiZHtpfSwgYW5kIHRoZWlyCiBkZXBlbmRlbmNpZXM7IGFsc28s IGRlbGV0ZSBhbGwgcGFja2FnZXMgbWFya2VkIHdpdGggQGtiZHtkfQogKEBjb2Rle3BhY2thZ2Ut bWVudS1leGVjdXRlfSkuICBUaGlzIGFsc28gcmVtb3ZlcyB0aGUgbWFya3MuCiAKK0BpdGVtIGcK IEBpdGVtIHIKLVJlZnJlc2ggdGhlIHBhY2thZ2UgbGlzdCAoQGNvZGV7cGFja2FnZS1tZW51LXJl ZnJlc2h9KS4gIFRoaXMgZmV0Y2hlcworQGZpbmRleCBwYWNrYWdlLW1lbnUtcmV2ZXJ0CitSZWZy ZXNoIHRoZSBwYWNrYWdlIGxpc3QgKEBjb2Rle3BhY2thZ2UtbWVudS1yZXZlcnR9KS4gIFRoaXMg ZmV0Y2hlcwogdGhlIGxpc3Qgb2YgYXZhaWxhYmxlIHBhY2thZ2VzIGZyb20gdGhlIHBhY2thZ2Ug YXJjaGl2ZSBhZ2FpbiwgYW5kCiByZWNvbXB1dGVzIHRoZSBwYWNrYWdlIGxpc3QuCiAKIEBpdGVt IGYKK0BmaW5kZXggcGFja2FnZS1tZW51LWZpbHRlcgogRmlsdGVyIHRoZSBwYWNrYWdlIGxpc3Qg KEBjb2Rle3BhY2thZ2UtbWVudS1maWx0ZXJ9KS4gIFRoaXMgcHJvbXB0cwogZm9yIGEga2V5d29y ZCAoZS5nLiwgQHNhbXB7Z2FtZXN9KSwgdGhlbiBzaG93cyBvbmx5IHRoZSBwYWNrYWdlcwogdGhh dCByZWxhdGUgdG8gdGhhdCBrZXl3b3JkLiAgVG8gcmVzdG9yZSB0aGUgZnVsbCBwYWNrYWdlIGxp c3QsCiB0eXBlIEBrYmR7cX0uCiAKIEBpdGVtIEgKK0BmaW5kZXggcGFja2FnZS1tZW51LWhpZGUt cGFja2FnZQogUGVybWFuZW50bHkgaGlkZSBwYWNrYWdlcyB0aGF0IG1hdGNoIGEgcmVnZXhwCiAo QGNvZGV7cGFja2FnZS1tZW51LWhpZGUtcGFja2FnZX0pLgogCiBAaXRlbSAoCitAZmluZGV4IHBh Y2thZ2UtbWVudS10b2dnbGUtaGlkaW5nCiBUb2dnbGUgdmlzaWJpbGl0eSBvZiBvbGQgdmVyc2lv bnMgb2YgcGFja2FnZXMgYW5kIGFsc28gb2YgdmVyc2lvbnMKIGZyb20gbG93ZXItcHJpb3JpdHkg YXJjaGl2ZXMgKEBjb2Rle3BhY2thZ2UtbWVudS10b2dnbGUtaGlkaW5nfSkuCiBAZW5kIHRhYmxl CmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IGNiOGI2ZmNhYzEuLjJkYzIy YmE4OWYgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC05ODksNiArOTg5 LDE0IEBAIGVhcmx5IGluaXQgZmlsZS4KIC0tLQogKioqIFRoZSBwYWNrYWdlIGxpc3QgY2FuIG5v dyBiZSBzb3J0ZWQgYnkgdmVyc2lvbiBvciBkZXNjcmlwdGlvbi4KIAorKysrCisqKiogJ3BhY2th Z2UtbWVudS1yZWZyZXNoJyBpcyBhbiBvYnNvbGV0ZSBhbGlhcyBmb3IgJ3BhY2thZ2UtbWVudS1y ZXZlcnQnLgorCisrKysKKyoqKiAnZycgd2lsbCBub3cgdXBkYXRlIHBhY2thZ2VzIGZyb20gYXJj aGl2ZXMgaW4gUGFja2FnZSBNZW51LgorUHJldmlvdXNseSwgJ2cnIGludm9rZWQgJ3RhYnVsYXRl ZC1saXN0LXJldmVydCcgd2hpY2ggZGlkIG5vdCByZWZyZXNoCit0aGUgY2FjaGVkIGFyY2hpdmUg ZGF0YS4KKwogKiogSW5mbwogCiArKysKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9wYWNr YWdlLmVsIGIvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKaW5kZXggYWIxZmI4YjkwZi4uZDcy ZTk4M2MzOSAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKKysrIGIvbGlz cC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKQEAgLTI2NjYsNyArMjY2Niw3IEBAIHBhY2thZ2UtbWVu dS1tb2RlLW1hcAogICAgIChkZWZpbmUta2V5IG1hcCAiZCIgJ3BhY2thZ2UtbWVudS1tYXJrLWRl bGV0ZSkKICAgICAoZGVmaW5lLWtleSBtYXAgImkiICdwYWNrYWdlLW1lbnUtbWFyay1pbnN0YWxs KQogICAgIChkZWZpbmUta2V5IG1hcCAiVSIgJ3BhY2thZ2UtbWVudS1tYXJrLXVwZ3JhZGVzKQot ICAgIChkZWZpbmUta2V5IG1hcCAiciIgJ3BhY2thZ2UtbWVudS1yZWZyZXNoKQorICAgIChkZWZp bmUta2V5IG1hcCAiciIgJ3BhY2thZ2UtbWVudS1yZXZlcnQpCiAgICAgKGRlZmluZS1rZXkgbWFw ICJmIiAncGFja2FnZS1tZW51LWZpbHRlcikKICAgICAoZGVmaW5lLWtleSBtYXAgIn4iICdwYWNr YWdlLW1lbnUtbWFyay1vYnNvbGV0ZS1mb3ItZGVsZXRpb24pCiAgICAgKGRlZmluZS1rZXkgbWFw ICJ4IiAncGFja2FnZS1tZW51LWV4ZWN1dGUpCkBAIC0yNzM0LDYgKzI3MzQsNyBAQCBwYWNrYWdl LW1lbnUtbW9kZQogICAoc2V0cSB0YWJ1bGF0ZWQtbGlzdC1zb3J0LWtleSAoY29ucyAiU3RhdHVz IiBuaWwpKQogICAoYWRkLWhvb2sgJ3RhYnVsYXRlZC1saXN0LXJldmVydC1ob29rICMncGFja2Fn ZS1tZW51LS1yZWZyZXNoIG5pbCB0KQogICAodGFidWxhdGVkLWxpc3QtaW5pdC1oZWFkZXIpCisg IChzZXRxIHJldmVydC1idWZmZXItZnVuY3Rpb24gJ3BhY2thZ2UtbWVudS1yZXZlcnQpCiAgIChz ZXRmIGltZW51LXByZXYtaW5kZXgtcG9zaXRpb24tZnVuY3Rpb24KICAgICAgICAgIydwYWNrYWdl LS1pbWVudS1wcmV2LWluZGV4LXBvc2l0aW9uLWZ1bmN0aW9uKQogICAoc2V0ZiBpbWVudS1leHRy YWN0LWluZGV4LW5hbWUtZnVuY3Rpb24KQEAgLTMxMzIsMTEgKzMxMzMsMTUgQEAgcGFja2FnZS1t ZW51LS1wcmludC1pbmZvLXNpbXBsZQogKGRlZnZhciBwYWNrYWdlLW1lbnUtLW9sZC1hcmNoaXZl LWNvbnRlbnRzIG5pbAogICAiYHBhY2thZ2UtYXJjaGl2ZS1jb250ZW50cycgYmVmb3JlIHRoZSBs YXRlc3QgcmVmcmVzaC4iKQogCi0oZGVmdW4gcGFja2FnZS1tZW51LXJlZnJlc2ggKCkKKyhkZWZ1 biBwYWNrYWdlLW1lbnUtcmV2ZXJ0ICgmb3B0aW9uYWwgYXJnIG5vY29uZmlybSkKICAgIkluIFBh Y2thZ2UgTWVudSwgZG93bmxvYWQgdGhlIEVtYWNzIExpc3AgcGFja2FnZSBhcmNoaXZlLgogRmV0 Y2ggdGhlIGNvbnRlbnRzIG9mIGVhY2ggYXJjaGl2ZSBzcGVjaWZpZWQgaW4KIGBwYWNrYWdlLWFy Y2hpdmVzJywgYW5kIHRoZW4gcmVmcmVzaCB0aGUgcGFja2FnZSBtZW51LiAgU2lnbmFsIGEKLXVz ZXItZXJyb3IgaWYgdGhlcmUgaXMgYWxyZWFkeSBhIHJlZnJlc2ggcnVubmluZyBhc3luY2hyb25v dXNseS4iCit1c2VyLWVycm9yIGlmIHRoZXJlIGlzIGFscmVhZHkgYSByZWZyZXNoIHJ1bm5pbmcg YXN5bmNocm9ub3VzbHkuCisKK2BwYWNrYWdlLW1lbnUtbW9kZScgc2V0cyDigJhyZXZlcnQtYnVm ZmVyLWZ1bmN0aW9u4oCZIHRvIHRoaXMKK2Z1bmN0aW9uLiAgVGhlIGFyZ3MgQVJHIGFuZCBOT0NP TkZJUk0sIHBhc3NlZCBmcm9tCivigJhyZXZlcnQtYnVmZmVy4oCZLCBhcmUgaWdub3JlZC4iCiAg IChpbnRlcmFjdGl2ZSkKICAgKHVubGVzcyAoZGVyaXZlZC1tb2RlLXAgJ3BhY2thZ2UtbWVudS1t b2RlKQogICAgICh1c2VyLWVycm9yICJUaGUgY3VycmVudCBidWZmZXIgaXMgbm90IGEgUGFja2Fn ZSBNZW51IikpCkBAIC0zMTQ1LDYgKzMxNTAsNyBAQCBwYWNrYWdlLW1lbnUtcmVmcmVzaAogICAo c2V0cSBwYWNrYWdlLW1lbnUtLW9sZC1hcmNoaXZlLWNvbnRlbnRzIHBhY2thZ2UtYXJjaGl2ZS1j b250ZW50cykKICAgKHNldHEgcGFja2FnZS1tZW51LS1uZXctcGFja2FnZS1saXN0IG5pbCkKICAg KHBhY2thZ2UtcmVmcmVzaC1jb250ZW50cyBwYWNrYWdlLW1lbnUtYXN5bmMpKQorKGRlZmluZS1v YnNvbGV0ZS1mdW5jdGlvbi1hbGlhcyAncGFja2FnZS1tZW51LXJlZnJlc2ggJ3BhY2thZ2UtbWVu dS1yZXZlcnQgIjI3LjEiKQogCiAoZGVmdW4gcGFja2FnZS1tZW51LWhpZGUtcGFja2FnZSAoKQog ICAiSGlkZSBhIHBhY2thZ2UgdW5kZXIgcG9pbnQgaW4gUGFja2FnZSBNZW51LgotLSAKMi4yMC4x Cgo= --000000000000e2bc4c0593f6423d-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 21:47:12 2019 Received: (at 35504) by debbugs.gnu.org; 3 Oct 2019 01:47:13 +0000 Received: from localhost ([127.0.0.1]:38612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFqD2-0002uI-NG for submit@debbugs.gnu.org; Wed, 02 Oct 2019 21:47:12 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFqCz-0002tw-Pr for 35504@debbugs.gnu.org; Wed, 02 Oct 2019 21:47:10 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 01F3F851D5; Wed, 2 Oct 2019 21:47:04 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BC04F811E8; Wed, 2 Oct 2019 21:47:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1570067222; bh=zjpF+483xVD1rNeMNFnhTueF0VOrktawmRVfjPL/hVc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lZ7zyLVSF7sklV7W7e/ihxQZ9BB61bpA5x7MiJ/06b10bW0G05VEQhsPTrf1MUb/7 F+2E7xT8BnpznzkxrQ837NxlL/0O2ECF9oWTE4IcooShAXJ9D8TQPMo4AT11shy0dX Rqxtcfeb2/pAsL5sc8C/6P6jy27nQBsbXGCM4GdncM97+S5e7R1qxvi8xKgLl7Cgkp JOw2WmfeA0nIRa8ycw58+wpDVW9dOzZ2a2QYG5p/r8YKkqkW67+yr8TjkolHjtcXoW 4CEgWMhzWmK0enPaZN3W15TZrkS/p0zuM1M8W97eP2iuwTJ3XXviS2PrAIMwPS40oa srtBoK413o5Qg== Received: from pastel (76-10-181-40.dsl.teksavvy.com [76.10.181.40]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3E1C51203E2; Wed, 2 Oct 2019 21:47:02 -0400 (EDT) From: Stefan Monnier To: Stefan Kangas Subject: Re: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer Message-ID: References: Date: Wed, 02 Oct 2019 21:47:00 -0400 In-Reply-To: (Stefan Kangas's message of "Thu, 3 Oct 2019 01:59:25 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35504 Cc: "Basil L. Contovounesios" , 35504@debbugs.gnu.org, Rudi Schlatte X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Fine by me. I wonder, tho: why not set revert-buffer-function and then >> redefine `package-menu-refresh` as an obsolete alias for `revert-buffer`? > Sure, I've tried to do that in the attached patch. WDYT? [...] > + (setq revert-buffer-function 'package-menu-revert) [...] > +(define-obsolete-function-alias 'package-menu-refresh 'package-menu-revert "27.1") Could we make package-menu-refresh to be an (obsolete) alias of `revert-buffer` instead (and make package-menu-revert an internal non-interactive function)? Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 21:54:04 2019 Received: (at 35504) by debbugs.gnu.org; 3 Oct 2019 01:54:04 +0000 Received: from localhost ([127.0.0.1]:38626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFqJg-00035e-4Y for submit@debbugs.gnu.org; Wed, 02 Oct 2019 21:54:04 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:50924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFqJe-000350-Bc for 35504@debbugs.gnu.org; Wed, 02 Oct 2019 21:54:03 -0400 Received: by mail-wm1-f67.google.com with SMTP id 5so781762wmg.0 for <35504@debbugs.gnu.org>; Wed, 02 Oct 2019 18:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=BaotlDb1DJ6o+hBQdQyXqp5SKFkgsAVImqTpLVCdW0s=; b=zy8rYsgxK4GPOoaOKTnxPcO2mLOUozR3CXLhbp+HFHUd28Gm/6CYu/Uh8fcXUYNYQS Acm2H2mTtMwd9DOidEJxOaFjM1gFZI+pK5MJZXMbCtMGDPrZ+xqI2NBYEEHL6MeXFHd9 NigpVJK5lQq91FNmQNAkfgjBgyTJ9ctZfczLadZMicQaGJZDBgUSnRftzve2D2vVLUQk omTKR2lc95ToPWDvgyH+MC1tj5Z2m99Xdb63VyFsVaFu9BT2SG++hEYP0o3y2t7hPe6S TWxWlGZJDPSg8WjMSNo0jGc/FWeeIHo/BMwaTfqfWQydbYvoU9OJ3oWe8P62Xk70ubeg W6CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=BaotlDb1DJ6o+hBQdQyXqp5SKFkgsAVImqTpLVCdW0s=; b=F4qz89CCwq0HnqAlej/8BZ0vcKrGSkE69UUBrCRvsfmSKIgswSAIsDeXODvsv6eZ0e LcVvNvdKufYPmE50ok0vMNsx5W2Lzt3VWsV40NerIRpt19VegPwW10cfxvUen72103bf dxhFo1pbL10okf+XtLPddBCK6m0Ryy5fFM46y49/mu2qMeEz9E2tpLrYUQ7+qvDiFTPK x5buwJzGoRHtuzD3AP5cqVFrydBlbYxJZfH+IwKzucQm7g7fg2ipcGfqaklnlb3y3Qv9 2V7+saJaeqa0X2wcL0FIDcI1B2r0HsQTysp4o9D1G2Bporb2M6VhXk84n13LrAaElGp0 NPYg== X-Gm-Message-State: APjAAAWz/vR2tFaj8HmI293iVdaPWsiqsSD37ruTRAJEC+KOVYPg1969 codUXr2cyClf6GiafHzBu8+3sA== X-Google-Smtp-Source: APXvYqyty2crm4jwDs+BsazmyzYk7ao76HRtm7m2OQYpPDCOZ3+mK+CO3587YoGu9uUKT3Cuc7xJJQ== X-Received: by 2002:a1c:a697:: with SMTP id p145mr4547789wme.24.1570067636288; Wed, 02 Oct 2019 18:53:56 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id l11sm903252wmh.34.2019.10.02.18.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2019 18:53:55 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer References: Date: Thu, 03 Oct 2019 02:53:54 +0100 In-Reply-To: (Stefan Kangas's message of "Thu, 3 Oct 2019 01:59:25 +0200") Message-ID: <87pnje8uh9.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35504 Cc: 35504@debbugs.gnu.org, Stefan Monnier , Rudi Schlatte X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Stefan Monnier writes: > >> > I also agree. How about the attached patch? >> >> Fine by me. I wonder, tho: why not set revert-buffer-function and then >> redefine `package-menu-refresh` as an obsolete alias for `revert-buffer`? > > Sure, I've tried to do that in the attached patch. WDYT? In addition to Stefan M.'s comments, I just noticed a couple of nits: > -(defun package-menu-refresh () > +(defun package-menu-revert (&optional arg noconfirm) If the arguments aren't used, they should be prefixed with underscores. > "In Package Menu, download the Emacs Lisp package archive. > Fetch the contents of each archive specified in > `package-archives', and then refresh the package menu. Signal a > -user-error if there is already a refresh running asynchronously." > +user-error if there is already a refresh running asynchronously. > + > +`package-menu-mode' sets =E2=80=98revert-buffer-function=E2=80=99 to this > +function. The args ARG and NOCONFIRM, passed from > +=E2=80=98revert-buffer=E2=80=99, are ignored." revert-buffer-function and revert-buffer are quoted with curly single quotes instead of the usual grave+apostrophe. Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 04 10:36:32 2019 Received: (at 35504) by debbugs.gnu.org; 4 Oct 2019 14:36:32 +0000 Received: from localhost ([127.0.0.1]:43326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGOh6-0005sO-77 for submit@debbugs.gnu.org; Fri, 04 Oct 2019 10:36:32 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:34920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGOh4-0005sC-L5 for 35504@debbugs.gnu.org; Fri, 04 Oct 2019 10:36:31 -0400 Received: by mail-pl1-f196.google.com with SMTP id c3so1761617plo.2 for <35504@debbugs.gnu.org>; Fri, 04 Oct 2019 07:36:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BYteSBoalBUc6XG23O9OrgzhxyLYXQGNscWiknUGN7Y=; b=biSFOxeb8t+TEgnGFYEBluTyPLgSA4msUERcGSBkQ4md1saL0rNb7Rw/6MwNqVGGf7 9aWbqjUCqMwVdlmof+5iMCoLwZdNXgxD2EqSO8Yu9g23AnW0cFA7UD95me5hNlaVJ6Q/ 2fWFkME1gogs8UEfTLS/BzvfTTUZwu7acEzgC3WBK6XyOiBID2ZPcZcRidkYc/8kC/KN yrDiHzTgutB2XpwyRAsLNE1EFdcjgzuUjSeOLrjz1ANloUcErAhcu6IyMx6aT4xdpc5p M8E/aKE3JK4HFxfu0oPOCaf0sMO0ClWzmFl7csewzf2qK/0Nc2KzojJQyWpsHjVGnDEj WbHA== X-Gm-Message-State: APjAAAW46pdd0F/kW9LxN9ReQT+hCIK7e58QPvZL93Vd0lN1VJ4K2D1N ORUM7OLVL4Ao3Eno4X2mwq7lQRv+Wy+w3RqAJWg= X-Google-Smtp-Source: APXvYqynkudlopaz8YJqCsD00HtdRZPQMAltCUaVpn4bxmlBS5NT0UxyDKLVlpM6+6WW1tEBKj3S80a4JLf+i7IoCgU= X-Received: by 2002:a17:902:6b88:: with SMTP id p8mr11016388plk.251.1570199784583; Fri, 04 Oct 2019 07:36:24 -0700 (PDT) MIME-Version: 1.0 References: <87pnje8uh9.fsf@tcd.ie> In-Reply-To: <87pnje8uh9.fsf@tcd.ie> From: Stefan Kangas Date: Fri, 4 Oct 2019 16:36:10 +0200 Message-ID: Subject: Re: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer To: "Basil L. Contovounesios" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 35504 Cc: 35504@debbugs.gnu.org, Stefan Monnier , Rudi Schlatte X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Basil L. Contovounesios writes: > > -(defun package-menu-refresh () > > +(defun package-menu-revert (&optional arg noconfirm) > > If the arguments aren't used, they should be prefixed with underscores. Indeed, fixed. > > "In Package Menu, download the Emacs Lisp package archive. > > Fetch the contents of each archive specified in > > `package-archives', and then refresh the package menu. Signal a > > -user-error if there is already a refresh running asynchronously." > > +user-error if there is already a refresh running asynchronously. > > + > > +`package-menu-mode' sets =E2=80=98revert-buffer-function=E2=80=99 to t= his > > +function. The args ARG and NOCONFIRM, passed from > > +=E2=80=98revert-buffer=E2=80=99, are ignored." > > revert-buffer-function and revert-buffer are quoted with curly single > quotes instead of the usual grave+apostrophe. Well spotted, fixed. Thanks for the review. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 04 11:09:33 2019 Received: (at 35504) by debbugs.gnu.org; 4 Oct 2019 15:09:33 +0000 Received: from localhost ([127.0.0.1]:43343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGPD2-0006e0-I7 for submit@debbugs.gnu.org; Fri, 04 Oct 2019 11:09:33 -0400 Received: from mail-pg1-f172.google.com ([209.85.215.172]:33388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGPD0-0006dj-2G for 35504@debbugs.gnu.org; Fri, 04 Oct 2019 11:09:30 -0400 Received: by mail-pg1-f172.google.com with SMTP id q1so3946515pgb.0 for <35504@debbugs.gnu.org>; Fri, 04 Oct 2019 08:09:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wUqGnBfZ/ssTsMRyLivPLFOLK4DvckG03kFVukbGKx8=; b=X8bvHNVttvKucsp5xWRlm0PRmTRT/aK5l3+Gyr8P994FVblnWztHpNhqP533dIvPSm a9lVMXBXK1MK/cTU+zZpJsLuph0CiD7Q6UJhRKYsGGswo+9RIDXLz7urGKR+PWXDKEUL YfVyALwXTTpMqyausDncRSG/IR496ef4i5sDlQeEylxAPGy8Kg/Euweot4q1u9NZ3A6v 5gTvGTpf6PcpfY+ZOyBRB+sSD9zANw5tB9CpYW/w30NH6M6bnchpJKKt1NXlAANZr62m lO4FTSQxtbwxfvCyPZZox4eFqZ40fUkThMwOwJyyecDMHNMPcRw0dhEHOAb5cPGZNm3G cmfg== X-Gm-Message-State: APjAAAUO67U8f54ZSObzvDJ31XN7UtiVVYIl/bD6zWbnHO6VGuuOmNZ4 tMspt0EEcLAm+Xg0YBHBCZV3VitUgE8A+XKk5fw= X-Google-Smtp-Source: APXvYqwcn/jRXAHmwX7JKDfT1ynoBloDNInH8dzowlyDMOBkRLcDLoBhah5odWkJiNwo/pn8kB0OfSfVn1lPk/DjZBc= X-Received: by 2002:a63:1310:: with SMTP id i16mr14758466pgl.200.1570201764082; Fri, 04 Oct 2019 08:09:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stefan Kangas Date: Fri, 4 Oct 2019 17:09:09 +0200 Message-ID: Subject: Re: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer To: Stefan Monnier Content-Type: multipart/mixed; boundary="0000000000005fdf1005941716db" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 35504 Cc: "Basil L. Contovounesios" , 35504@debbugs.gnu.org, Rudi Schlatte X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000005fdf1005941716db Content-Type: text/plain; charset="UTF-8" Stefan Monnier writes: > > >> Fine by me. I wonder, tho: why not set revert-buffer-function and then > >> redefine `package-menu-refresh` as an obsolete alias for `revert-buffer`? > > Sure, I've tried to do that in the attached patch. WDYT? > [...] > > + (setq revert-buffer-function 'package-menu-revert) > [...] > > +(define-obsolete-function-alias 'package-menu-refresh 'package-menu-revert "27.1") > > Could we make package-menu-refresh to be an (obsolete) alias of > `revert-buffer` instead (and make package-menu-revert an internal > non-interactive function)? Absolutely, thanks for the suggestion. Fixed in the attached patch together with the things Basil pointed out. Please let me know what you think. Best regards, Stefan Kangas --0000000000005fdf1005941716db Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Make-g-refresh-package-data-in-package-menu.patch" Content-Disposition: attachment; filename="0001-Make-g-refresh-package-data-in-package-menu.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1c9j5iv0 RnJvbSBlNGU0NTA3Njg1ZThkZjA3ZjBkNjI0ZWI3NTRmZTk0Y2QyOGYyYTQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBGcmksIDI2IEp1bCAyMDE5IDEyOjQ5OjM1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g TWFrZSAnZycgcmVmcmVzaCBwYWNrYWdlIGRhdGEgaW4gcGFja2FnZSBtZW51CgoqIGxpc3AvZW1h Y3MtbGlzcC9wYWNrYWdlLmVsIChwYWNrYWdlLW1lbnUtLXJlZnJlc2gpOiBSZW5hbWUgZnJvbQon cGFja2FnZS1tZW51LXJlZnJlc2gnLCBtYWtlIGludGVybmFsIGFuZCBub24taW50ZXJhY3RpdmUu CihwYWNrYWdlLW1lbnUtbW9kZS1tYXAsIHBhY2thZ2UtbWVudS1tb2RlLW1lbnUsIHBhY2thZ2Ut bWVudS1tb2RlKQoobGlzdC1wYWNrYWdlcyk6IFVzZSB0aGUgYWJvdmUuICAoQnVnIzM1NTA0KQoo cGFja2FnZS1tZW51LXJlZnJlc2gpOiBSZWRlZmluZSBhcyBvYnNvbGV0ZSBmdWN0aW9uIGFsaWFz IGZvcgoncmV2ZXJ0LWJ1ZmZlcicuCiogZG9jL2VtYWNzL3BhY2thZ2UudGV4aSAoUGFja2FnZSBN ZW51KTogRG9jdW1lbnQgaXQuCiogZXRjL05FV1M6IEFubm91bmNlIGl0LgotLS0KIGRvYy9lbWFj cy9wYWNrYWdlLnRleGkgICAgIHwgMTcgKysrKysrKysrKysrKystLS0KIGV0Yy9ORVdTICAgICAg ICAgICAgICAgICAgIHwgIDkgKysrKysrKysrCiBsaXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbCB8 IDE3ICsrKysrKysrKysrLS0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyks IDkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2VtYWNzL3BhY2thZ2UudGV4aSBiL2Rv Yy9lbWFjcy9wYWNrYWdlLnRleGkKaW5kZXggMmMwOWNhODkwMi4uN2I2ZGNjMDQxZCAxMDA2NDQK LS0tIGEvZG9jL2VtYWNzL3BhY2thZ2UudGV4aQorKysgYi9kb2MvZW1hY3MvcGFja2FnZS50ZXhp CkBAIC04NSwxNiArODUsMTkgQEAgUGFja2FnZSBNZW51CiAKIEB0YWJsZSBAa2JkCiBAaXRlbSBo CitAZmluZGV4IHBhY2thZ2UtbWVudS1xdWljay1oZWxwCiBQcmludCBhIHNob3J0IG1lc3NhZ2Ug c3VtbWFyaXppbmcgaG93IHRvIHVzZSB0aGUgcGFja2FnZSBtZW51CiAoQGNvZGV7cGFja2FnZS1t ZW51LXF1aWNrLWhlbHB9KS4KIAogQGl0ZW0gPwogQGl0ZW14IEBrZXl7UkVUfQorQGZpbmRleCBw YWNrYWdlLW1lbnUtZGVzY3JpYmUtcGFja2FnZQogRGlzcGxheSBhIGhlbHAgYnVmZmVyIGZvciB0 aGUgcGFja2FnZSBvbiB0aGUgY3VycmVudCBsaW5lCiAoQGNvZGV7cGFja2FnZS1tZW51LWRlc2Ny aWJlLXBhY2thZ2V9KSwgc2ltaWxhciB0byB0aGUgaGVscCB3aW5kb3cKIGRpc3BsYXllZCBieSB0 aGUgQGtiZHtDLWggUH0gY29tbWFuZCAoQHB4cmVme1BhY2thZ2VzfSkuCiAKIEBpdGVtIGkKK0Bm aW5kZXggcGFja2FnZS1tZW51LW1hcmstaW5zdGFsbAogTWFyayB0aGUgcGFja2FnZSBvbiB0aGUg Y3VycmVudCBsaW5lIGZvciBpbnN0YWxsYXRpb24KIChAY29kZXtwYWNrYWdlLW1lbnUtbWFyay1p bnN0YWxsfSkuICBJZiB0aGUgcGFja2FnZSBzdGF0dXMgaXMKIEBzYW1we2F2YWlsYWJsZX0sIHRo aXMgYWRkcyBhbiBAc2FtcHtJfSBjaGFyYWN0ZXIgdG8gdGhlIHN0YXJ0IG9mIHRoZQpAQCAtMTAy LDYgKzEwNSw3IEBAIFBhY2thZ2UgTWVudQogcGFja2FnZS4KIAogQGl0ZW0gZAorQGZpbmRleCBw YWNrYWdlLW1lbnUtbWFyay1kZWxldGUKIE1hcmsgdGhlIHBhY2thZ2Ugb24gdGhlIGN1cnJlbnQg bGluZSBmb3IgZGVsZXRpb24KIChAY29kZXtwYWNrYWdlLW1lbnUtbWFyay1kZWxldGV9KS4gIElm IHRoZSBwYWNrYWdlIHN0YXR1cyBpcwogQHNhbXB7aW5zdGFsbGVkfSwgdGhpcyBhZGRzIGEgQHNh bXB7RH0gY2hhcmFjdGVyIHRvIHRoZSBzdGFydCBvZiB0aGUKQEAgLTExMCw2ICsxMTQsNyBAQCBQ YWNrYWdlIE1lbnUKIGVudGFpbHMuCiAKIEBpdGVtIH4KK0BmaW5kZXggcGFja2FnZS1tZW51LW1h cmstb2Jzb2xldGUtZm9yLWRlbGV0aW9uCiBNYXJrIGFsbCBvYnNvbGV0ZSBwYWNrYWdlcyBmb3Ig ZGVsZXRpb24KIChAY29kZXtwYWNrYWdlLW1lbnUtbWFyay1vYnNvbGV0ZS1mb3ItZGVsZXRpb259 KS4gIFRoaXMgbWFya3MgZm9yCiBkZWxldGlvbiBhbGwgdGhlIHBhY2thZ2VzIHdob3NlIHN0YXR1 cyBpcyBAc2FtcHtvYnNvbGV0ZX0uCkBAIC0xMjAsNiArMTI1LDcgQEAgUGFja2FnZSBNZW51CiBj dXJyZW50IGxpbmUgYnkgYW4gQGtiZHtpfSBvciBAa2Jke2R9IGNvbW1hbmQuCiAKIEBpdGVtIFUK K0BmaW5kZXggcGFja2FnZS1tZW51LW1hcmstdXBncmFkZXMKIE1hcmsgYWxsIHBhY2thZ2Ugd2l0 aCBhIG5ld2VyIGF2YWlsYWJsZSB2ZXJzaW9uIGZvciB1cGdyYWRpbmcKIChAY29kZXtwYWNrYWdl LW1lbnUtbWFyay11cGdyYWRlc30pLiAgVGhpcyBwbGFjZXMgYW4gaW5zdGFsbGF0aW9uIG1hcmsK IG9uIHRoZSBuZXcgYXZhaWxhYmxlIHZlcnNpb25zLCBhbmQgYSBkZWxldGlvbiBtYXJrIG9uIHRo ZSBvbGQKQEAgLTEyNywyNiArMTMzLDMxIEBAIFBhY2thZ2UgTWVudQogCiBAaXRlbSB4CiBAdmlu ZGV4IHBhY2thZ2UtbWVudS1hc3luYworQGZpbmRleCBwYWNrYWdlLW1lbnUtZXhlY3V0ZQogRG93 bmxvYWQgYW5kIGluc3RhbGwgYWxsIHBhY2thZ2VzIG1hcmtlZCB3aXRoIEBrYmR7aX0sIGFuZCB0 aGVpcgogZGVwZW5kZW5jaWVzOyBhbHNvLCBkZWxldGUgYWxsIHBhY2thZ2VzIG1hcmtlZCB3aXRo IEBrYmR7ZH0KIChAY29kZXtwYWNrYWdlLW1lbnUtZXhlY3V0ZX0pLiAgVGhpcyBhbHNvIHJlbW92 ZXMgdGhlIG1hcmtzLgogCitAaXRlbSBnCiBAaXRlbSByCi1SZWZyZXNoIHRoZSBwYWNrYWdlIGxp c3QgKEBjb2Rle3BhY2thZ2UtbWVudS1yZWZyZXNofSkuICBUaGlzIGZldGNoZXMKLXRoZSBsaXN0 IG9mIGF2YWlsYWJsZSBwYWNrYWdlcyBmcm9tIHRoZSBwYWNrYWdlIGFyY2hpdmUgYWdhaW4sIGFu ZAotcmVjb21wdXRlcyB0aGUgcGFja2FnZSBsaXN0LgorUmVmcmVzaCB0aGUgcGFja2FnZSBsaXN0 IChAY29kZXtyZXZlcnQtYnVmZmVyfSkuICBUaGlzIGZldGNoZXMgdGhlCitsaXN0IG9mIGF2YWls YWJsZSBwYWNrYWdlcyBmcm9tIHRoZSBwYWNrYWdlIGFyY2hpdmUgYWdhaW4sIGFuZAorcmVkaXNw bGF5cyB0aGUgcGFja2FnZSBsaXN0LgogCiBAaXRlbSBmCitAZmluZGV4IHBhY2thZ2UtbWVudS1m aWx0ZXIKIEZpbHRlciB0aGUgcGFja2FnZSBsaXN0IChAY29kZXtwYWNrYWdlLW1lbnUtZmlsdGVy fSkuICBUaGlzIHByb21wdHMKIGZvciBhIGtleXdvcmQgKGUuZy4sIEBzYW1we2dhbWVzfSksIHRo ZW4gc2hvd3Mgb25seSB0aGUgcGFja2FnZXMKIHRoYXQgcmVsYXRlIHRvIHRoYXQga2V5d29yZC4g IFRvIHJlc3RvcmUgdGhlIGZ1bGwgcGFja2FnZSBsaXN0LAogdHlwZSBAa2Jke3F9LgogCiBAaXRl bSBICitAZmluZGV4IHBhY2thZ2UtbWVudS1oaWRlLXBhY2thZ2UKIFBlcm1hbmVudGx5IGhpZGUg cGFja2FnZXMgdGhhdCBtYXRjaCBhIHJlZ2V4cAogKEBjb2Rle3BhY2thZ2UtbWVudS1oaWRlLXBh Y2thZ2V9KS4KIAogQGl0ZW0gKAorQGZpbmRleCBwYWNrYWdlLW1lbnUtdG9nZ2xlLWhpZGluZwog VG9nZ2xlIHZpc2liaWxpdHkgb2Ygb2xkIHZlcnNpb25zIG9mIHBhY2thZ2VzIGFuZCBhbHNvIG9m IHZlcnNpb25zCiBmcm9tIGxvd2VyLXByaW9yaXR5IGFyY2hpdmVzIChAY29kZXtwYWNrYWdlLW1l bnUtdG9nZ2xlLWhpZGluZ30pLgogQGVuZCB0YWJsZQpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9l dGMvTkVXUwppbmRleCBjOGNjNzUzN2IwLi45YmI3N2IwODYzIDEwMDY0NAotLS0gYS9ldGMvTkVX UworKysgYi9ldGMvTkVXUwpAQCAtMTAwMCw2ICsxMDAwLDE1IEBAIGVhcmx5IGluaXQgZmlsZS4K IC0tLQogKioqIFRoZSBwYWNrYWdlIGxpc3QgY2FuIG5vdyBiZSBzb3J0ZWQgYnkgdmVyc2lvbiBv ciBkZXNjcmlwdGlvbi4KIAorKysrCisqKiogJ3BhY2thZ2UtbWVudS1yZWZyZXNoJyBpcyBhbiBv YnNvbGV0ZSBhbGlhcyBmb3IgJ3JldmVydC1idWZmZXInLgorCisrKysKKyoqKiBJbiBQYWNrYWdl IE1lbnUsICdnJyBub3cgdXBkYXRlcyBwYWNrYWdlIGRhdGEgZnJvbSBhcmNoaXZlcy4KK1ByZXZp b3VzbHksICdnJyBpbnZva2VkICd0YWJ1bGF0ZWQtbGlzdC1yZXZlcnQnIHdoaWNoIGRpZCBub3Qg dXBkYXRlCit0aGUgY2FjaGVkIGFyY2hpdmUgZGF0YS4gIEl0IGlzIG5vdyBib3VuZCB0byAncmV2 ZXJ0LWJ1ZmZlcicsIHdoaWNoCit3aWxsIG5vdyB1cGRhdGUgdGhlIGRhdGEuCisKICoqIEluZm8K IAogKysrCmRpZmYgLS1naXQgYS9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbCBiL2xpc3AvZW1h Y3MtbGlzcC9wYWNrYWdlLmVsCmluZGV4IDE4OGYzOThhNTYuLjNlNjdjYTllZTUgMTAwNjQ0Ci0t LSBhL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9wYWNr YWdlLmVsCkBAIC0yNjkwLDcgKzI2OTAsNyBAQCBwYWNrYWdlLW1lbnUtbW9kZS1tYXAKICAgICAo ZGVmaW5lLWtleSBtYXAgImQiICdwYWNrYWdlLW1lbnUtbWFyay1kZWxldGUpCiAgICAgKGRlZmlu ZS1rZXkgbWFwICJpIiAncGFja2FnZS1tZW51LW1hcmstaW5zdGFsbCkKICAgICAoZGVmaW5lLWtl eSBtYXAgIlUiICdwYWNrYWdlLW1lbnUtbWFyay11cGdyYWRlcykKLSAgICAoZGVmaW5lLWtleSBt YXAgInIiICdwYWNrYWdlLW1lbnUtcmVmcmVzaCkKKyAgICAoZGVmaW5lLWtleSBtYXAgInIiICdy ZXZlcnQtYnVmZmVyKQogICAgIChkZWZpbmUta2V5IG1hcCAiZiIgJ3BhY2thZ2UtbWVudS1maWx0 ZXIpCiAgICAgKGRlZmluZS1rZXkgbWFwICJ+IiAncGFja2FnZS1tZW51LW1hcmstb2Jzb2xldGUt Zm9yLWRlbGV0aW9uKQogICAgIChkZWZpbmUta2V5IG1hcCAieCIgJ3BhY2thZ2UtbWVudS1leGVj dXRlKQpAQCAtMjcwNyw3ICsyNzA3LDcgQEAgcGFja2FnZS1tZW51LW1vZGUtbWVudQogICAgIFsi RGVzY3JpYmUgUGFja2FnZSIgcGFja2FnZS1tZW51LWRlc2NyaWJlLXBhY2thZ2UgOmhlbHAgIkRp c3BsYXkgaW5mb3JtYXRpb24gYWJvdXQgdGhpcyBwYWNrYWdlIl0KICAgICBbIkhlbHAiIHBhY2th Z2UtbWVudS1xdWljay1oZWxwIDpoZWxwICJTaG93IHNob3J0IGtleSBiaW5kaW5nIGhlbHAgZm9y IHBhY2thZ2UtbWVudS1tb2RlIl0KICAgICAiLS0iCi0gICAgWyJSZWZyZXNoIFBhY2thZ2UgTGlz dCIgcGFja2FnZS1tZW51LXJlZnJlc2gKKyAgICBbIlJlZnJlc2ggUGFja2FnZSBMaXN0IiByZXZl cnQtYnVmZmVyCiAgICAgIDpoZWxwICJSZWRvd25sb2FkIHRoZSBFTFBBIGFyY2hpdmUiCiAgICAg IDphY3RpdmUgKG5vdCBwYWNrYWdlLS1kb3dubG9hZHMtaW4tcHJvZ3Jlc3MpXQogICAgIFsiUmVk aXNwbGF5IGJ1ZmZlciIgcmV2ZXJ0LWJ1ZmZlciA6aGVscCAiVXBkYXRlIHRoZSBidWZmZXIgd2l0 aCBjdXJyZW50IGxpc3Qgb2YgcGFja2FnZXMiXQpAQCAtMjc1OCw2ICsyNzU4LDcgQEAgcGFja2Fn ZS1tZW51LW1vZGUKICAgKHNldHEgdGFidWxhdGVkLWxpc3Qtc29ydC1rZXkgKGNvbnMgIlN0YXR1 cyIgbmlsKSkKICAgKGFkZC1ob29rICd0YWJ1bGF0ZWQtbGlzdC1yZXZlcnQtaG9vayAjJ3BhY2th Z2UtbWVudS0tcmVmcmVzaCBuaWwgdCkKICAgKHRhYnVsYXRlZC1saXN0LWluaXQtaGVhZGVyKQor ICAoc2V0cSByZXZlcnQtYnVmZmVyLWZ1bmN0aW9uICdwYWNrYWdlLW1lbnUtLXJlZnJlc2gpCiAg IChzZXRmIGltZW51LXByZXYtaW5kZXgtcG9zaXRpb24tZnVuY3Rpb24KICAgICAgICAgIydwYWNr YWdlLS1pbWVudS1wcmV2LWluZGV4LXBvc2l0aW9uLWZ1bmN0aW9uKQogICAoc2V0ZiBpbWVudS1l eHRyYWN0LWluZGV4LW5hbWUtZnVuY3Rpb24KQEAgLTMxNTgsMTIgKzMxNTksMTUgQEAgcGFja2Fn ZS1tZW51LS1wcmludC1pbmZvLXNpbXBsZQogKGRlZnZhciBwYWNrYWdlLW1lbnUtLW9sZC1hcmNo aXZlLWNvbnRlbnRzIG5pbAogICAiYHBhY2thZ2UtYXJjaGl2ZS1jb250ZW50cycgYmVmb3JlIHRo ZSBsYXRlc3QgcmVmcmVzaC4iKQogCi0oZGVmdW4gcGFja2FnZS1tZW51LXJlZnJlc2ggKCkKKyhk ZWZ1biBwYWNrYWdlLW1lbnUtLXJlZnJlc2ggKCZvcHRpb25hbCBfYXJnIF9ub2NvbmZpcm0pCiAg ICJJbiBQYWNrYWdlIE1lbnUsIGRvd25sb2FkIHRoZSBFbWFjcyBMaXNwIHBhY2thZ2UgYXJjaGl2 ZS4KIEZldGNoIHRoZSBjb250ZW50cyBvZiBlYWNoIGFyY2hpdmUgc3BlY2lmaWVkIGluCiBgcGFj a2FnZS1hcmNoaXZlcycsIGFuZCB0aGVuIHJlZnJlc2ggdGhlIHBhY2thZ2UgbWVudS4gIFNpZ25h bCBhCi11c2VyLWVycm9yIGlmIHRoZXJlIGlzIGFscmVhZHkgYSByZWZyZXNoIHJ1bm5pbmcgYXN5 bmNocm9ub3VzbHkuIgotICAoaW50ZXJhY3RpdmUpCit1c2VyLWVycm9yIGlmIHRoZXJlIGlzIGFs cmVhZHkgYSByZWZyZXNoIHJ1bm5pbmcgYXN5bmNocm9ub3VzbHkuCisKK2BwYWNrYWdlLW1lbnUt bW9kZScgc2V0cyBgcmV2ZXJ0LWJ1ZmZlci1mdW5jdGlvbicgdG8gdGhpcworZnVuY3Rpb24uICBU aGUgYXJncyBBUkcgYW5kIE5PQ09ORklSTSwgcGFzc2VkIGZyb20KK2ByZXZlcnQtYnVmZmVyJywg YXJlIGlnbm9yZWQuIgogICAodW5sZXNzIChkZXJpdmVkLW1vZGUtcCAncGFja2FnZS1tZW51LW1v ZGUpCiAgICAgKHVzZXItZXJyb3IgIlRoZSBjdXJyZW50IGJ1ZmZlciBpcyBub3QgYSBQYWNrYWdl IE1lbnUiKSkKICAgKHdoZW4gKGFuZCBwYWNrYWdlLW1lbnUtYXN5bmMgcGFja2FnZS0tZG93bmxv YWRzLWluLXByb2dyZXNzKQpAQCAtMzE3MSw2ICszMTc1LDcgQEAgcGFja2FnZS1tZW51LXJlZnJl c2gKICAgKHNldHEgcGFja2FnZS1tZW51LS1vbGQtYXJjaGl2ZS1jb250ZW50cyBwYWNrYWdlLWFy Y2hpdmUtY29udGVudHMpCiAgIChzZXRxIHBhY2thZ2UtbWVudS0tbmV3LXBhY2thZ2UtbGlzdCBu aWwpCiAgIChwYWNrYWdlLXJlZnJlc2gtY29udGVudHMgcGFja2FnZS1tZW51LWFzeW5jKSkKKyhk ZWZpbmUtb2Jzb2xldGUtZnVuY3Rpb24tYWxpYXMgJ3BhY2thZ2UtbWVudS1yZWZyZXNoICdyZXZl cnQtYnVmZmVyICIyNy4xIikKIAogKGRlZnVuIHBhY2thZ2UtbWVudS1oaWRlLXBhY2thZ2UgKCkK ICAgIkhpZGUgYSBwYWNrYWdlIHVuZGVyIHBvaW50IGluIFBhY2thZ2UgTWVudS4KQEAgLTM2MzQs NyArMzYzOSw3IEBAIGxpc3QtcGFja2FnZXMKICAgICAgIChwYWNrYWdlLW1lbnUtbW9kZSkKIAog ICAgICAgOzsgRmV0Y2ggdGhlIHJlbW90ZSBsaXN0IG9mIHBhY2thZ2VzLgotICAgICAgKHVubGVz cyBuby1mZXRjaCAocGFja2FnZS1tZW51LXJlZnJlc2gpKQorICAgICAgKHVubGVzcyBuby1mZXRj aCAocGFja2FnZS1tZW51LS1yZWZyZXNoKSkKIAogICAgICAgOzsgSWYgd2UncmUgbm90IGFzeW5j LCB0aGlzIHdvdWxkIGJlIHJlZHVuZGFudC4KICAgICAgICh3aGVuIHBhY2thZ2UtbWVudS1hc3lu YwotLSAKMi4yMC4xCgo= --0000000000005fdf1005941716db-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 01 22:32:43 2019 Received: (at 35504) by debbugs.gnu.org; 2 Nov 2019 02:32:43 +0000 Received: from localhost ([127.0.0.1]:57901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQjDX-0000zM-2M for submit@debbugs.gnu.org; Fri, 01 Nov 2019 22:32:43 -0400 Received: from host.gofardesign.uk ([208.79.239.190]:60252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQjDU-0000zA-Kt for 35504@debbugs.gnu.org; Fri, 01 Nov 2019 22:32:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Yhxu97b5PR3jPBUxzzfjD/rOhchkU4/dgBBfj5HqufI=; b=eGa7H3hqJHWQ6VhOtupEGn/hCx 7xKHdiz0DTYIy4+Xa2SK42LyZ0hSGxIU3opqqbONQ2o9h2xQ56rI8RscYoshETDRDV5hmNa55jtwy Q9ADDChPbxujuk9wd0M/dC2Y+Vxx6pnOGa79ojlBQO5mPgEY1mShsF2FjHz9WF83U+os=; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:41858 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iQjDN-0005JU-M6; Fri, 01 Nov 2019 21:32:34 -0500 From: Stefan Kangas To: Stefan Monnier Subject: Re: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer In-Reply-To: (Stefan Kangas's message of "Fri, 4 Oct 2019 17:09:09 +0200") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Sat, 02 Nov 2019 03:32:31 +0100 Message-ID: <87lfszrosg.fsf@marxist.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35504 Cc: "Basil L. Contovounesios" , 35504@debbugs.gnu.org, Rudi Schlatte X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Stefan Kangas writes: > Stefan Monnier writes: >> >> >> Fine by me. I wonder, tho: why not set revert-buffer-function and then >> >> redefine `package-menu-refresh` as an obsolete alias for `revert-buffer`? >> > Sure, I've tried to do that in the attached patch. WDYT? >> [...] >> > + (setq revert-buffer-function 'package-menu-revert) >> [...] >> > +(define-obsolete-function-alias 'package-menu-refresh 'package-menu-revert "27.1") >> >> Could we make package-menu-refresh to be an (obsolete) alias of >> `revert-buffer` instead (and make package-menu-revert an internal >> non-interactive function)? > > Absolutely, thanks for the suggestion. Fixed in the attached patch > together with the things Basil pointed out. > > Please let me know what you think. I've attached an updated patch below. If there are no further comments, I intend to commit it in a couple of days. Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Make-g-refresh-package-data-in-package-menu.patch >From 71bda0bd328a901b2dc17e76f032efd0a10fcfec Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Fri, 26 Jul 2019 12:49:35 +0200 Subject: [PATCH] Make 'g' refresh package data in package menu * lisp/emacs-lisp/package.el (package-menu--refresh): Rename from 'package-menu-refresh', make internal and non-interactive. (package-menu-mode-map, package-menu-mode-menu, package-menu-mode) (list-packages): Use the above. (Bug#35504) (package-menu-refresh): Redefine as obsolete fuction alias for 'revert-buffer'. * doc/emacs/package.texi (Package Menu): Document it. * etc/NEWS: Announce it. --- doc/emacs/package.texi | 9 +++++---- etc/NEWS | 8 ++++++++ lisp/emacs-lisp/package.el | 17 +++++++++++------ 3 files changed, 24 insertions(+), 10 deletions(-) diff --git a/doc/emacs/package.texi b/doc/emacs/package.texi index 19efff7445..1c0f853427 100644 --- a/doc/emacs/package.texi +++ b/doc/emacs/package.texi @@ -149,12 +149,13 @@ Package Menu dependencies; also, delete all packages marked with @kbd{d} (@code{package-menu-execute}). This also removes the marks. +@item g @item r +@kindex g @r{(Package Menu)} @kindex r @r{(Package Menu)} -@findex package-menu-refresh -Refresh the package list (@code{package-menu-refresh}). This fetches -the list of available packages from the package archive again, and -recomputes the package list. +Refresh the package list (@code{revert-buffer}). This fetches the +list of available packages from the package archive again, and +redisplays the package list. @item / k @kindex / k @r{(Package Menu)} diff --git a/etc/NEWS b/etc/NEWS index e614197125..79410bbec3 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1131,6 +1131,14 @@ the 'package-menu-clear-filter' function, bound to '/ /' by default. --- *** The package list can now be sorted by version or description. ++++ +*** In Package Menu, 'g' now updates package data from archives. +Previously, 'g' invoked 'tabulated-list-revert' which did not update +the cached archive data. It is now bound to 'revert-buffer', which +will now update the data. + +'package-menu-refresh' is an obsolete alias for 'revert-buffer'. + ** Info +++ diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 8c8e86aead..3363b1bb52 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2690,7 +2690,7 @@ package-menu-mode-map (define-key map "d" 'package-menu-mark-delete) (define-key map "i" 'package-menu-mark-install) (define-key map "U" 'package-menu-mark-upgrades) - (define-key map "r" 'package-menu-refresh) + (define-key map "r" 'revert-buffer) (define-key map (kbd "/ k") 'package-menu-filter-by-keyword) (define-key map (kbd "/ n") 'package-menu-filter-by-name) (define-key map (kbd "/ /") 'package-menu-clear-filter) @@ -2709,7 +2709,7 @@ package-menu-mode-menu ["Describe Package" package-menu-describe-package :help "Display information about this package"] ["Help" package-menu-quick-help :help "Show short key binding help for package-menu-mode"] "--" - ["Refresh Package List" package-menu-refresh + ["Refresh Package List" revert-buffer :help "Redownload the ELPA archive" :active (not package--downloads-in-progress)] ["Redisplay buffer" revert-buffer :help "Update the buffer with current list of packages"] @@ -2764,6 +2764,7 @@ package-menu-mode (setq tabulated-list-sort-key (cons "Status" nil)) (add-hook 'tabulated-list-revert-hook #'package-menu--refresh nil t) (tabulated-list-init-header) + (setq revert-buffer-function 'package-menu--refresh) (setf imenu-prev-index-position-function #'package--imenu-prev-index-position-function) (setf imenu-extract-index-name-function @@ -3161,12 +3162,15 @@ package-menu--print-info-simple (defvar package-menu--old-archive-contents nil "`package-archive-contents' before the latest refresh.") -(defun package-menu-refresh () +(defun package-menu--refresh (&optional _arg _noconfirm) "In Package Menu, download the Emacs Lisp package archive. Fetch the contents of each archive specified in `package-archives', and then refresh the package menu. Signal a -user-error if there is already a refresh running asynchronously." - (interactive) +user-error if there is already a refresh running asynchronously. + +`package-menu-mode' sets `revert-buffer-function' to this +function. The args ARG and NOCONFIRM, passed from +`revert-buffer', are ignored." (unless (derived-mode-p 'package-menu-mode) (user-error "The current buffer is not a Package Menu")) (when (and package-menu-async package--downloads-in-progress) @@ -3174,6 +3178,7 @@ package-menu-refresh (setq package-menu--old-archive-contents package-archive-contents) (setq package-menu--new-package-list nil) (package-refresh-contents package-menu-async)) +(define-obsolete-function-alias 'package-menu-refresh 'revert-buffer "27.1") (defun package-menu-hide-package () "Hide a package under point in Package Menu. @@ -3637,7 +3642,7 @@ list-packages (package-menu-mode) ;; Fetch the remote list of packages. - (unless no-fetch (package-menu-refresh)) + (unless no-fetch (package-menu--refresh)) ;; If we're not async, this would be redundant. (when package-menu-async -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 19:00:58 2019 Received: (at 35504) by debbugs.gnu.org; 6 Nov 2019 00:00:59 +0000 Received: from localhost ([127.0.0.1]:39246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iS8ks-0007fj-H5 for submit@debbugs.gnu.org; Tue, 05 Nov 2019 19:00:58 -0500 Received: from host.gofardesign.uk ([208.79.239.190]:55360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iS8kq-0007YR-Vb; Tue, 05 Nov 2019 19:00:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=haE/H1Ttau0AwRDH+N4A2cjX2u5IBPz1nQPqbSsVrak=; b=ekOjIfh5MIoKTW/9qVZh56x1Bt TylANmyrNF+nZE6KZy4IdhKqbNTaYT3eW4wYhItIFD5H3d9mG1cOCbVlghhrMdoCB4YLq83mK+uuR ulP7IhyBNSAYTIR188LOyrHMqhYlMSCD4WOLU87XzznAbyFPZiP71w7D6phFBSiD2uHM=; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:60322 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iS8ki-0004dr-Id; Tue, 05 Nov 2019 18:00:49 -0600 From: Stefan Kangas To: Stefan Monnier Subject: Re: bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer In-Reply-To: <87lfszrosg.fsf@marxist.se> (Stefan Kangas's message of "Sat, 02 Nov 2019 03:32:31 +0100") References: <87lfszrosg.fsf@marxist.se> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Wed, 06 Nov 2019 01:00:46 +0100 Message-ID: <87sgn16fgx.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35504 Cc: "Basil L. Contovounesios" , 35504@debbugs.gnu.org, Rudi Schlatte X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 35504 27.1 thanks Stefan Kangas writes: > I've attached an updated patch below. If there are no further > comments, I intend to commit it in a couple of days. Now pushed to master as commit 0c293f1520. Closing. Best regards, Stefan Kangas From unknown Sat Jun 14 14:27:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Dec 2019 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator