From unknown Fri Aug 15 20:52:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35498: 26.2; doc string of `isearch-regexp-function' Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 01:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35498 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 35498@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1556588950806 (code B ref -1); Tue, 30 Apr 2019 01:50:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Apr 2019 01:49:10 +0000 Received: from localhost ([127.0.0.1]:40243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLHtN-0000Cv-R9 for submit@debbugs.gnu.org; Mon, 29 Apr 2019 21:49:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLHtL-0000Ci-VM for submit@debbugs.gnu.org; Mon, 29 Apr 2019 21:49:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:42389) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLHtG-0003y7-P0 for submit@debbugs.gnu.org; Mon, 29 Apr 2019 21:49:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLHtF-0003pN-Nv for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 21:49:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLHtE-0003wS-KX for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 21:49:01 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:53768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLHtE-0003vI-9t for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 21:49:00 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3U1mtMr055618 for ; Tue, 30 Apr 2019 01:48:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=eNZ9jAf7u1Y78tVEtwSPHOOAt+CpjsyMNUJIeBgrg7Y=; b=qwuBlCu/Rg7OE04oP6Onoyo5AOdxTnpwTkDgE1KUXZ3yMj56R3D6P2eZmzPOnJLr2xyd OTMN+EpuHvjPZ9uTY0ZRz72c6XPuA2LWPdThdGYe9WCNypeRndmvCRFLivadECsg2hKb i50A2zOxzSMq5io95Jo1FM0QHy36KPDHfr4vSWVlc47Yr7SXpsWF2TASjBOVc4vfVeqj 8ohp8vX4mqMqq2hakBNPTGf7JQYZ1RYF5ILx4lu+okgcWXXZy+19iynQm1hyqCm5KxKU n/Jj4Emf5wv9br/xTONPvTn8T+AQUg+26pe/PWT43A2DQxO3hC5XuexmnhyXcPt81rTy kQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2s5j5txbyk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 30 Apr 2019 01:48:55 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3U1mp06016811 for ; Tue, 30 Apr 2019 01:48:51 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2s4d4a8b7j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 30 Apr 2019 01:48:50 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x3U1mnGc006978 for ; Tue, 30 Apr 2019 01:48:49 GMT MIME-Version: 1.0 Message-ID: <95f9cdd4-4d43-458e-8354-dfc8972b14bf@default> Date: Mon, 29 Apr 2019 18:48:48 -0700 (PDT) From: Drew Adams X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4834.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9242 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=914 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904300010 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9242 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=930 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904300010 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.86 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The doc string should describe the possible values and their meanings/behaviors. Currently it describes only a function as value. Searching isearch.el it seems that this variable can be any of the values possible for `search-default-mode'. Please describe each of the values for `isearch-regexp-function'. Even when the value is a function the description could be better, saying that it must accept a string as its first arg and must return a string. That can be surmised from saying that it converts a plain search string to a regexp [search string], but it could be clearer. Also, "plain search string" and "regexp" are unclear here. The distinction is presumably (?) that the former contains no regexp special chars? Or does the return value need to be a _valid_ (complete) regexp, and does the function raise an error if that's not possible? In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32) of 2019-04-13 Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749 Windowing system distributor `Microsoft Corp.', version 10.0.17134 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' From unknown Fri Aug 15 20:52:26 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Drew Adams Subject: bug#35498: closed (Re: bug#35498: 26.2; doc string of `isearch-regexp-function') Message-ID: References: <831s1fopq8.fsf@gnu.org> <95f9cdd4-4d43-458e-8354-dfc8972b14bf@default> X-Gnu-PR-Message: they-closed 35498 X-Gnu-PR-Package: emacs Reply-To: 35498@debbugs.gnu.org Date: Fri, 03 May 2019 09:25:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1556875502-10532-1" This is a multi-part message in MIME format... ------------=_1556875502-10532-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #35498: 26.2; doc string of `isearch-regexp-function' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 35498@debbugs.gnu.org. --=20 35498: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35498 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1556875502-10532-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 35498-done) by debbugs.gnu.org; 3 May 2019 09:24:41 +0000 Received: from localhost ([127.0.0.1]:47725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMUQr-0002jK-9W for submit@debbugs.gnu.org; Fri, 03 May 2019 05:24:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMUQp-0002j7-Tn for 35498-done@debbugs.gnu.org; Fri, 03 May 2019 05:24:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMUQk-0008Ju-Fd; Fri, 03 May 2019 05:24:34 -0400 Received: from [176.228.60.248] (port=4907 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hMUQj-0006q3-TO; Fri, 03 May 2019 05:24:34 -0400 Date: Fri, 03 May 2019 12:24:15 +0300 Message-Id: <831s1fopq8.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-reply-to: <95f9cdd4-4d43-458e-8354-dfc8972b14bf@default> (message from Drew Adams on Mon, 29 Apr 2019 18:48:48 -0700 (PDT)) Subject: Re: bug#35498: 26.2; doc string of `isearch-regexp-function' References: <95f9cdd4-4d43-458e-8354-dfc8972b14bf@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35498-done Cc: 35498-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 29 Apr 2019 18:48:48 -0700 (PDT) > From: Drew Adams > > The doc string should describe the possible values and their > meanings/behaviors. Currently it describes only a function as value. I added the existing functions that could be used as values. Their descriptions are available by using the hyperlink, so no need to duplicate that here. The list is, of course, not exhaustive, as Lisp programs could define their own functions. > Searching isearch.el it seems that this variable can be any of the > values possible for `search-default-mode'. Please describe each of the > values for `isearch-regexp-function'. See above: not needed. > Even when the value is a function the description could be better, > saying that it must accept a string as its first arg and must return a > string. That can be surmised from saying that it converts a plain > search string to a regexp [search string], but it could be clearer. Added. > Also, "plain search string" and "regexp" are unclear here. The > distinction is presumably (?) that the former contains no regexp special > chars? Or does the return value need to be a _valid_ (complete) regexp, > and does the function raise an error if that's not possible? I didn't see any problem here, although I improved the wording to some extent. Thanks. ------------=_1556875502-10532-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Apr 2019 01:49:10 +0000 Received: from localhost ([127.0.0.1]:40243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLHtN-0000Cv-R9 for submit@debbugs.gnu.org; Mon, 29 Apr 2019 21:49:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLHtL-0000Ci-VM for submit@debbugs.gnu.org; Mon, 29 Apr 2019 21:49:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:42389) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLHtG-0003y7-P0 for submit@debbugs.gnu.org; Mon, 29 Apr 2019 21:49:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLHtF-0003pN-Nv for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 21:49:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLHtE-0003wS-KX for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 21:49:01 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:53768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLHtE-0003vI-9t for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 21:49:00 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3U1mtMr055618 for ; Tue, 30 Apr 2019 01:48:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=eNZ9jAf7u1Y78tVEtwSPHOOAt+CpjsyMNUJIeBgrg7Y=; b=qwuBlCu/Rg7OE04oP6Onoyo5AOdxTnpwTkDgE1KUXZ3yMj56R3D6P2eZmzPOnJLr2xyd OTMN+EpuHvjPZ9uTY0ZRz72c6XPuA2LWPdThdGYe9WCNypeRndmvCRFLivadECsg2hKb i50A2zOxzSMq5io95Jo1FM0QHy36KPDHfr4vSWVlc47Yr7SXpsWF2TASjBOVc4vfVeqj 8ohp8vX4mqMqq2hakBNPTGf7JQYZ1RYF5ILx4lu+okgcWXXZy+19iynQm1hyqCm5KxKU n/Jj4Emf5wv9br/xTONPvTn8T+AQUg+26pe/PWT43A2DQxO3hC5XuexmnhyXcPt81rTy kQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2s5j5txbyk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 30 Apr 2019 01:48:55 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3U1mp06016811 for ; Tue, 30 Apr 2019 01:48:51 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2s4d4a8b7j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 30 Apr 2019 01:48:50 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x3U1mnGc006978 for ; Tue, 30 Apr 2019 01:48:49 GMT MIME-Version: 1.0 Message-ID: <95f9cdd4-4d43-458e-8354-dfc8972b14bf@default> Date: Mon, 29 Apr 2019 18:48:48 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 26.2; doc string of `isearch-regexp-function' X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4834.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9242 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=914 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904300010 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9242 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=930 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904300010 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.86 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The doc string should describe the possible values and their meanings/behaviors. Currently it describes only a function as value. Searching isearch.el it seems that this variable can be any of the values possible for `search-default-mode'. Please describe each of the values for `isearch-regexp-function'. Even when the value is a function the description could be better, saying that it must accept a string as its first arg and must return a string. That can be surmised from saying that it converts a plain search string to a regexp [search string], but it could be clearer. Also, "plain search string" and "regexp" are unclear here. The distinction is presumably (?) that the former contains no regexp special chars? Or does the return value need to be a _valid_ (complete) regexp, and does the function raise an error if that's not possible? In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32) of 2019-04-13 Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749 Windowing system distributor `Microsoft Corp.', version 10.0.17134 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' ------------=_1556875502-10532-1-- From unknown Fri Aug 15 20:52:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35498: 26.2; doc string of `isearch-regexp-function' Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2019 14:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35498 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Drew Adams Cc: 35498-done@debbugs.gnu.org Received: via spool by 35498-done@debbugs.gnu.org id=D35498.15568948888965 (code D ref 35498); Fri, 03 May 2019 14:49:02 +0000 Received: (at 35498-done) by debbugs.gnu.org; 3 May 2019 14:48:08 +0000 Received: from localhost ([127.0.0.1]:49298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMZTs-0002KX-Fd for submit@debbugs.gnu.org; Fri, 03 May 2019 10:48:08 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:39568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMZTp-0002Jr-Tm for 35498-done@debbugs.gnu.org; Fri, 03 May 2019 10:48:06 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x43Ecw2f020246; Fri, 3 May 2019 14:47:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=jyEXzAvSxhh194wKfB5ZQ8zfygR2o2Qu9aTOFViOJd4=; b=CpO6fflWTS2bAVHqJCHfq36nam5VbIYVsyOq0O3onK8WyEdqzNTZ1DFs+ZcBfaq/kC2T 3kyAWpI4r4roSWEvmgrugoaLr7R1eXnTgBa1pzm3rZEWtxSfu/KYZhyngvxcONhdMxan l/QkYkDHkC/ehkIZIDHM20jqGP2aSC8zO4SpVObCab1aZzmxPPmrugYBagixy6PNiLFr DvYOSjh9lGfUnP4UtcrnF9Qe49MEQ+dCMTW9zEqw+ftyLGIyQ2q9irXt+AnM/iclvUwn OzNHijNLDx0NNuXhG2rCde/oApl/OWujBXmCyNcPcP3UcQqbGoZLRIbPVdxQz4mlPWhn FQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 2s6xhyq7jh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 03 May 2019 14:47:59 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x43ElhXS190854; Fri, 3 May 2019 14:47:59 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2s6xhhnrdu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 03 May 2019 14:47:58 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x43Elwcw031076; Fri, 3 May 2019 14:47:58 GMT MIME-Version: 1.0 Message-ID: Date: Fri, 3 May 2019 07:47:57 -0700 (PDT) From: Drew Adams References: <<95f9cdd4-4d43-458e-8354-dfc8972b14bf@default>> <<831s1fopq8.fsf@gnu.org>> In-Reply-To: <<831s1fopq8.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4834.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9245 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905030094 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9245 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905030093 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > The doc string should describe the possible values and their > > meanings/behaviors. Currently it describes only a function as value. >=20 > I added the existing functions that could be used as values. Their > descriptions are available by using the hyperlink, so no need to > duplicate that here. The list is, of course, not exhaustive, as Lisp > programs could define their own functions. It should instead, or in addition, specify what args it must accept and what kind of value it must return. Examples are only nice-to-have, not a replacement for a description/spec. > > Searching isearch.el it seems that this variable can be any of the > > values possible for `search-default-mode'. Please describe each of the > > values for `isearch-regexp-function'. >=20 > See above: not needed. The doc string should say that the value can be t, nil, or a function. It should say what the behavior is for each. Or, as I suggested, it can just say that the value can be anything acceptable for `search-default-mode'.=20 > > Even when the value is a function the description could be better, > > saying that it must accept a string as its first arg and must return a > > string. That can be surmised from saying that it converts a plain > > search string to a regexp [search string], but it could be clearer. >=20 > Added. OK, good. That cancels what I said first, above. I thought you were saying that it is sufficient to just give a list of existing such function values. From unknown Fri Aug 15 20:52:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35498: 26.2; doc string of `isearch-regexp-function' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2019 15:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35498 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 35498@debbugs.gnu.org Received: via spool by 35498-submit@debbugs.gnu.org id=B35498.155689601210690 (code B ref 35498); Fri, 03 May 2019 15:07:02 +0000 Received: (at 35498) by debbugs.gnu.org; 3 May 2019 15:06:52 +0000 Received: from localhost ([127.0.0.1]:49308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMZm0-0002mL-AJ for submit@debbugs.gnu.org; Fri, 03 May 2019 11:06:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMZly-0002m7-3X for 35498@debbugs.gnu.org; Fri, 03 May 2019 11:06:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMZls-00038q-Ev; Fri, 03 May 2019 11:06:44 -0400 Received: from [176.228.60.248] (port=2152 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hMZlq-0005v1-8n; Fri, 03 May 2019 11:06:44 -0400 Date: Fri, 03 May 2019 18:06:14 +0300 Message-Id: <83muk3mvbt.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Drew Adams on Fri, 3 May 2019 07:47:57 -0700 (PDT)) References: <<95f9cdd4-4d43-458e-8354-dfc8972b14bf@default>> <<831s1fopq8.fsf@gnu.org>> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 3 May 2019 07:47:57 -0700 (PDT) > From: Drew Adams > Cc: 35498-done@debbugs.gnu.org > > > > The doc string should describe the possible values and their > > > meanings/behaviors. Currently it describes only a function as value. > > > > I added the existing functions that could be used as values. Their > > descriptions are available by using the hyperlink, so no need to > > duplicate that here. The list is, of course, not exhaustive, as Lisp > > programs could define their own functions. > > It should instead, or in addition, specify what args it > must accept and what kind of value it must return. Did you look at the changes I installed? Because I actually did that. > > > Searching isearch.el it seems that this variable can be any of the > > > values possible for `search-default-mode'. Please describe each of the > > > values for `isearch-regexp-function'. > > > > See above: not needed. > > The doc string should say that the value can be t, nil, > or a function. Did you see the changes I install? > > > Even when the value is a function the description could be better, > > > saying that it must accept a string as its first arg and must return a > > > string. That can be surmised from saying that it converts a plain > > > search string to a regexp [search string], but it could be clearer. > > > > Added. > > OK, good. That cancels what I said first, above. So why did you send them anyway?