From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 29 05:36:48 2019 Received: (at submit) by debbugs.gnu.org; 29 Apr 2019 09:36:48 +0000 Received: from localhost ([127.0.0.1]:38419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL2iN-0003B3-Q1 for submit@debbugs.gnu.org; Mon, 29 Apr 2019 05:36:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL2iL-0003Ao-IK for submit@debbugs.gnu.org; Mon, 29 Apr 2019 05:36:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:41816) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hL2iG-0002PX-Bb for submit@debbugs.gnu.org; Mon, 29 Apr 2019 05:36:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL2iF-0005Wc-Cm for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 05:36:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE, T_MANY_HDRS_LCASE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hL2iE-0002On-KB for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 05:36:39 -0400 Received: from mx-all.isti.cnr.it ([194.119.192.3]:25453 helo=blade3.isti.cnr.it) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL2iE-0002OA-E0 for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 05:36:38 -0400 Received: from savesent-daemon.mx-all.isti.cnr.it by mx-all.isti.cnr.it (PMDF V6.7-x04 #1884) id <01R62Q2AW94WB4T0WQ@mx-all.isti.cnr.it> for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 11:36:33 +0200 (MEST) Received: from tucano.isti.cnr.it ([146.48.81.102]) by mx-all.isti.cnr.it (PMDF V6.7-x04 #1884) with ESMTPSA id <01R62Q28GN7IB13XQN@mx-all.isti.cnr.it> for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 11:36:30 +0200 (MEST) Received: from pot by tucano.isti.cnr.it with local (Exim 4.92) (envelope-from ) id 1hL2i6-0004g0-2M for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 11:36:30 +0200 Date: Mon, 29 Apr 2019 11:36:29 +0200 From: =?utf-8?Q?Francesco_Potort=C3=AC?= Subject: 26.1; insert-kbd-macro now creates unreadable list code To: bug-gnu-emacs@gnu.org Message-id: Organization: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8bit X-INSM-ip-source: 146.48.81.102 Auth Done X-fingerprint: 4B02 6187 5C03 D6B1 2E31 7666 09DF 2DC9 BE21 6115 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 194.119.192.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) The insert-kbd-macro function now creates code like this: (fset 'rmail-remove-me (lambda (&optional arg) "Keyboard macro." (interactive "p") (kmacro-exec-ring-item (quote ([21 114 80 108 101 101 97 97 115 97 115 ... rather than this as before: (fset 'approve "\C-[xundigestify\C-mdd\C-xqde\M-k\M-k\M-k\M-k\C-c\C-crApproved: ... This makes it impossible to understand at a glance what a given macro does by browsing the lisp code. I find this to be a regression. Can this be undone, or at least controlled by an option? From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 29 17:56:04 2019 Received: (at 35486) by debbugs.gnu.org; 29 Apr 2019 21:56:04 +0000 Received: from localhost ([127.0.0.1]:40012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLEFn-00034g-Mo for submit@debbugs.gnu.org; Mon, 29 Apr 2019 17:56:03 -0400 Received: from mail-qt1-f171.google.com ([209.85.160.171]:46546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLEFj-00034B-LD for 35486@debbugs.gnu.org; Mon, 29 Apr 2019 17:56:00 -0400 Received: by mail-qt1-f171.google.com with SMTP id i31so5108494qti.13 for <35486@debbugs.gnu.org>; Mon, 29 Apr 2019 14:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=NiMpClDbkp6blp+WDNFlLISMdGh+0pfJgDJ/3c27nAg=; b=F5BO4aug1XVQVlMAvf5zac8wY2GZwnjb02sHy0XNyQkr1Zj2UYlHpGUtvtUR4nb+7G 0GCy4yczJ/OyDRNKJO4RGqyBJbo0mf5y6ZRNIZ5rHEcQmGYW/3w34T2pDSttJ9S8UgNT O8xbVX8jlMbtKGV8+CwAQDias/m2ygOcA5kqOpUUW7S28eDikcm/jAj2JtrnYRWx3t3i yu61gF/8f212BZ8Qv28jporte4XSPn5UgaOSO7GSi81/LrjKY6SAvvG6IKdhPI+gZkAf vgE7o6MdNT2k9xTvULG69gIt0amL7yAgmAyABj8EDwHNg4pcNeYjwPbUppPeUANc/jAk a2JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=NiMpClDbkp6blp+WDNFlLISMdGh+0pfJgDJ/3c27nAg=; b=eLyhVVQTfWwEN0cwyJe5Z+Ds72gU4H7+OjoWnNDRKtWOGzakbOmfiGu8ZkiVt5GAov 2CPo9kY+nQockVVeYIHvR7qfAfvkWb7mRWtLT/ziCYKJeusPEmqkUoo/YSa0Bhi8YdvG dcHOJxaAqw3puS6NSrzitkY5zUIU6htTles5lsoI39ifYhM6h2s8dbVHpD/z04QcMWAl vb5Jvuo+7OOBDlPGQuh7bOra5+FU92afvlyclQoX3KpmEeZmPPeoHhtm4C3yMek7W0xW C07zn3/C5b6vSxaAEdiPAgFfHbNBcCLH+T7cZrzC0QA1uRDquh23MCgPZTzAxWJGLvE3 sWOA== X-Gm-Message-State: APjAAAXPX13qzl6ePKTwxlUtasT8maeA8OGvTSJTl/PujB4KrX7Ct2Aw hyanXvsswmfyklxZgCqO/KkRUSfg X-Google-Smtp-Source: APXvYqz/K4ocw9HHsIPp7Z/0rWRZs12MaCO0q9NbkMuTTAlLMKbTRKnsGU1AfZRnr0eNbXjf3PIPjg== X-Received: by 2002:ac8:1c10:: with SMTP id a16mr7800998qtk.116.1556574953807; Mon, 29 Apr 2019 14:55:53 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.googlemail.com with ESMTPSA id h10sm6569662qkk.69.2019.04.29.14.55.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Apr 2019 14:55:52 -0700 (PDT) From: npostavs@gmail.com To: Francesco =?iso-8859-1?Q?Potort=EC?= Subject: Re: bug#35486: 26.1; insert-kbd-macro now creates unreadable list code References: Date: Mon, 29 Apr 2019 17:55:42 -0400 In-Reply-To: ("Francesco \=\?iso-8859-1\?Q\?Potort\=EC\=22's\?\= message of "Mon, 29 Apr 2019 11:36:29 +0200") Message-ID: <858svsmq75.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35486 Cc: 35486@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Francesco Potort=EC writes: > The insert-kbd-macro function now creates code like this: > > (fset 'rmail-remove-me > (lambda (&optional arg) "Keyboard macro." (interactive "p") > (kmacro-exec-ring-item (quote ([21 114 80 108 101 101 97 97 115 97 > 115 ... > > rather than this as before: > > (fset 'approve > "\C-[xundigestify\C-mdd\C-xqde\M-k\M-k\M-k\M-k\C-c\C-crApproved: ... By "before", do you mean Emacs 21? It looks like the (lambda () (kmacro-exec-ring-item ...)) thing was added in [1: 18d1e6c], which was fairly long ago. [1: 18d1e6c]: 2004-09-09 20:48:12 +0000 (kmacro-bind-to-key): Associate dedicated macro counter and format with b= inding. https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D18d1e6c9fd4d8d44= 6329ceb48a83ddca373f72c0 > This makes it impossible to understand at a glance what a given macro > does by browsing the lisp code. I find this to be a regression. Can > this be undone, or at least controlled by an option? I think the kmacro-bind-to-key is important to preserve the way macro counters work, but it seems like we should be able to add some special casing to at least get something like this: (fset 'approve (lambda (&optional arg) "Keyboard macro." (interactive "p") (kmacro-exec-ring-item (quote ([?\M-x ?u ?n ?d ?i ?g ?e ?s ?t ?i ?f ?y= return ?d ?d ?\C-x ?q ?d ?e ?\M-k] 0 "%d")) arg))) From debbugs-submit-bounces@debbugs.gnu.org Sun May 05 13:50:43 2019 Received: (at 35486) by debbugs.gnu.org; 5 May 2019 17:50:43 +0000 Received: from localhost ([127.0.0.1]:54797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNLHe-0004eh-Uj for submit@debbugs.gnu.org; Sun, 05 May 2019 13:50:43 -0400 Received: from mail-it1-f180.google.com ([209.85.166.180]:52551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNLHc-0004eN-KJ; Sun, 05 May 2019 13:50:41 -0400 Received: by mail-it1-f180.google.com with SMTP id q65so15450704itg.2; Sun, 05 May 2019 10:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=l2rSVPBpr5VqHfF+9YJINFhS+G/9C4suTOPVvLsWEAc=; b=p9eQdmvIQxGQkV5SBgdcErj8rkKoSQdQLv+7YfvYLCfRxTdUab+VwuVKm3j8VIk98p 4Y36fpIhlcicum7etmrPySTBZI+YDFLj92tNiuM6z+xMPkaF6xhld3+m4QSPiRwRgRfG GjDSL+QmNW0CGzycTRkjfwzZTSpYnoGlBjNRhZMiErVIu6v0kCr1vy5Ws5YNoBahcGzw QixyhjblEhJVY0hTfl+AJaorQXCoq+o2bA69QAMODDV0GzerIcYiP9xtHeUTTLS7qJ6B rVufBkNSCBDAUBsj4T+ydLJM9nc2A3xrKN83o8Ra0jzMsQZQ+sYMrU1PEDENnSlbtVTn 41bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=l2rSVPBpr5VqHfF+9YJINFhS+G/9C4suTOPVvLsWEAc=; b=bSOJCfc+mJ3E5xXoGhq7wFYTOXW6hv3X8UZYQ7rt9JN+7Kjckrrqx/rLbn2Z+Xkq2V sxLTL+VI7zNxT77pDKdkZBweKTc3fqB0m+GeOch31QEKHkPAAvvJiubbqaMkKA+GSJrZ RrfbpPeTW33DKZYbQ5Fb7mqQk95v7NapE9vOVDcXoKDc4c3hNdQsotjhuxq1AvmmUDvC 9FrBYx8PE4eOhJfs0k4S2quEZOCfD97nhdEgl1QarrnBrcEdWhMwfbhypLsrOWwfwMap xcDQW/K39M6mYZ5DBLedTiV6KWImtFhR72oHLDYm+jYy4qPYJtjw6QBf2G4LOhj1oDv/ UunA== X-Gm-Message-State: APjAAAVPSAoR/kaYVzHLU2CfrT6sgHFAwS/rSbT7KVo9UGmPlbQ8JNpf +Rwq32bHfQfj6eLL3kLqdaJKI/vr X-Google-Smtp-Source: APXvYqxzUivKIOtEMl1S5LPp5Ifi3GD4Fn56HiPq/UdfCBUoDoZgBBfDP3Nl6NE1qePC2Fc86MQJKw== X-Received: by 2002:a24:9414:: with SMTP id j20mr14708354ite.91.1557078634753; Sun, 05 May 2019 10:50:34 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id h4sm2880655iol.25.2019.05.05.10.50.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 May 2019 10:50:33 -0700 (PDT) From: Noam Postavsky To: Francesco =?utf-8?Q?Potort=C3=AC?= Subject: Re: bug#35486: 26.1; insert-kbd-macro now creates unreadable list code In-Reply-To: <858svsmq75.fsf@gmail.com> (npostavs@gmail.com's message of "Mon, 29 Apr 2019 17:55:42 -0400") References: <858svsmq75.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Date: Sun, 05 May 2019 13:50:17 -0400 Message-ID: <87v9yolrja.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35486 Cc: 35486@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain severity 35486 minor tags 35486 + patch quit npostavs@gmail.com writes: > I think the kmacro-bind-to-key is important to preserve the way macro > counters work, but it seems like we should be able to add some special > casing to at least get something like this: > > (fset 'approve > (lambda (&optional arg) > "Keyboard macro." > (interactive "p") > (kmacro-exec-ring-item (quote ([?\M-x ?u ?n ?d ?i ?g ?e ?s ?t ?i ?f ?y return ?d ?d ?\C-x ?q ?d ?e ?\M-k] 0 "%d")) arg))) Following an existing FIXME, the following patch produces (fset 'approve (kmacro-lambda-form [?\M-x ?u ?n ?d ?i ?g ?e ?s ?t ?i ?f ?y return ?d ?d ?\C-x ?q ?d ?e ?\M-k] 0 "%d")) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Improve-printing-for-named-keyboard-macros-Bug-35486.patch Content-Description: patch >From fe7420c67f18195aa85853dbfc6afcdf65e9d5a0 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 5 May 2019 13:24:15 -0400 Subject: [PATCH] Improve printing for named keyboard macros (Bug#35486) * lisp/macros.el (macros--insert-vector-macro): New function, extracted from insert-kbd-macro. (insert-kbd-macro): Use it and kmacro-extract-lambda to produce nicer expressions for macros produced by kmacro-lambda-form. --- lisp/kmacro.el | 1 + lisp/macros.el | 34 +++++++++++++++++++++------------- 2 files changed, 22 insertions(+), 13 deletions(-) diff --git a/lisp/kmacro.el b/lisp/kmacro.el index fc34e16708..01dc058614 100644 --- a/lisp/kmacro.el +++ b/lisp/kmacro.el @@ -776,6 +776,7 @@ (defun kmacro-end-call-mouse (event) ;; letters and digits, provided that we inhibit the keymap while ;; executing the macro later on (but that's controversial...) +;;;###autoload (defun kmacro-lambda-form (mac &optional counter format) "Create lambda form for macro bound to symbol or key." (if counter diff --git a/lisp/macros.el b/lisp/macros.el index ba6a840d60..4b38506d8a 100644 --- a/lisp/macros.el +++ b/lisp/macros.el @@ -36,6 +36,16 @@ (require 'kmacro) ;;;###autoload (defalias 'name-last-kbd-macro #'kmacro-name-last-macro) +(defun macros--insert-vector-macro (definition) + "Print DEFINITION, a vector, into the current buffer." + (dotimes (i (length definition)) + (let ((char (aref definition i))) + (insert (if (zerop i) ?\[ ?\s)) + (if (characterp char) + (princ (prin1-char char) (current-buffer)) + (prin1 char (current-buffer))))) + (insert ?\])) + ;;;###autoload (defun insert-kbd-macro (macroname &optional keys) "Insert in buffer the definition of kbd macro MACRONAME, as Lisp code. @@ -111,19 +121,17 @@ (defun insert-kbd-macro (macroname &optional keys) (delete-region (point) (1+ (point))) (insert "\\M-\\C-?")))))) (if (vectorp definition) - (let ((len (length definition)) (i 0) char) - (while (< i len) - (insert (if (zerop i) ?\[ ?\s)) - (setq char (aref definition i) - i (1+ i)) - (if (not (numberp char)) - (prin1 char (current-buffer)) - (princ (prin1-char char) (current-buffer)))) - (insert ?\])) - ;; FIXME: For kmacros, we shouldn't write the (lambda ...) - ;; gunk but instead we should write something more abstract like - ;; (kmacro-create [] 0 "%d"). - (prin1 definition (current-buffer)))) + (macros--insert-vector-macro definition) + (pcase (kmacro-extract-lambda definition) + (`(,vecdef ,counter ,format) + (insert "(kmacro-lambda-form ") + (macros--insert-vector-macro vecdef) + (insert " ") + (prin1 counter (current-buffer)) + (insert " ") + (prin1 format (current-buffer)) + (insert ")")) + (_ (prin1 definition (current-buffer)))))) (insert ")\n") (if keys (let ((keys (or (where-is-internal (symbol-function macroname) -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 08:08:08 2019 Received: (at 35486) by debbugs.gnu.org; 12 May 2019 12:08:09 +0000 Received: from localhost ([127.0.0.1]:42053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPnGy-00030i-NQ for submit@debbugs.gnu.org; Sun, 12 May 2019 08:08:08 -0400 Received: from mail-it1-f181.google.com ([209.85.166.181]:53767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPnGu-0002zW-Vn; Sun, 12 May 2019 08:08:05 -0400 Received: by mail-it1-f181.google.com with SMTP id m141so14805357ita.3; Sun, 12 May 2019 05:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YXpJsNfixLW++FfF2ae8dTdE+7aiIVchqOlFHRKlUxc=; b=qDVNQu/+Th8zpGKEfDK3RTRGIDJuO9f+X6weDlhxgUkfgAmYpAUA6LA8uA3NJqzQkV qxVpgjTE39G1rLER1oYHfQV3+vlpj6PR/mt4ICAPVrEpXjCmFNbZTrH1mnAAOEiQmxW3 LhaRXFJLAuV68DDB8a/ird2dS7NoCljnQ5qYQafP70YrhlQNiG8GU53CzVxZF4SNCoKZ elO+WWteK663U7CnkrT/QikIsxkYMPFlffp3l8E7GKyh22BIc+82KUlf/SsCwFOJ4QSv EW3K5p+wH2wjP4ZWzrC/md3KP5bPYT+7TGGAOK5K9C8xrjSTAAEdLpM1VA3N/NXgw7R1 Q/PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=YXpJsNfixLW++FfF2ae8dTdE+7aiIVchqOlFHRKlUxc=; b=nhbImKZ5uoTIZhhUWxHC7xgp15ihzRZRF/aPRRbAaKtNW0ernIoBJ2GyPQfdr9Gcdj MM5To/rzNdC61JkjQ6mFWYs9WAU46sgig7JdL5VReh6t6Ahsr+QwNsO7F0Fsxf6tBWbh aBRXmc2J9xpK+peKY+4/YbfbwE/PsxRtGC3pnWhmz4yqiCpL3rJigmghFR1Sdi0z3IVK LhIz9PqhtW2TDEXnb9r36FSVVmpREYU0L8EtROCM66aO6Ol3QIpLQ79Kz381kKn6Enk/ T7Q2ooVOyp1JhwgT9ScuFhNcWz9+CmKYpHXPXe5S20RBNJV9rvZ/b4Fy98wnwb6TRQ+C 16NA== X-Gm-Message-State: APjAAAUVObvq1Jmb6YaWwxxfKmvwJ7sLeV2udz9papv1numCn02HuC5I QojCjCmSkpjL53yxr8uF3V15oIxl X-Google-Smtp-Source: APXvYqz+ZMke/gGUpGC9loMTRuhStQgMnyW6/17GaWGq3hsqiqgdHw9nXlqoXXSvAq2POIun4w2f0w== X-Received: by 2002:a24:920a:: with SMTP id l10mr13527706itd.98.1557662879350; Sun, 12 May 2019 05:07:59 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id x187sm3911438itg.10.2019.05.12.05.07.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 May 2019 05:07:58 -0700 (PDT) From: Noam Postavsky To: Francesco =?utf-8?Q?Potort=C3=AC?= Subject: Re: bug#35486: 26.1; insert-kbd-macro now creates unreadable list code References: <858svsmq75.fsf@gmail.com> <87v9yolrja.fsf@gmail.com> Date: Sun, 12 May 2019 08:07:57 -0400 In-Reply-To: <87v9yolrja.fsf@gmail.com> (Noam Postavsky's message of "Sun, 05 May 2019 13:50:17 -0400") Message-ID: <87d0knj2oy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35486 Cc: 35486@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35486 fixed close 35486 27.1 quit Noam Postavsky writes: > > Following an existing FIXME, the following patch produces > > (fset 'approve > (kmacro-lambda-form [?\M-x ?u ?n ?d ?i ?g ?e ?s ?t ?i ?f ?y return ?d ?d ?\C-x ?q ?d ?e ?\M-k] 0 "%d")) Pushed to master. 29531785a1 2019-05-12T08:05:01-04:00 "Improve printing for named keyboard macros (Bug#35486)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=29531785a17acf519070b73b488ad87ddd94aff7 From unknown Tue Jun 24 05:11:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 10 Jun 2019 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator