GNU bug report logs - #35481
25.2; table.el should use 'font-lock-face' instead of 'face'

Previous Next

Package: emacs;

Reported by: Sebastian Urban <mrsebastianurban <at> gmail.com>

Date: Sun, 28 Apr 2019 21:32:02 UTC

Severity: minor

Tags: confirmed, easy, fixed, patch

Found in version 25.2

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: Sebastian Urban <mrsebastianurban <at> gmail.com>, 35481 <at> debbugs.gnu.org
Subject: bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face'
Date: Thu, 05 Dec 2019 10:55:21 +0100

Noam Postavsky <npostavs <at> gmail.com> writes:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> The patch below does this, but I'm not sure it's right.  When we're
>> using font-lock-face instead of face, then things work as normal when
>> we're using global-font-lock-mode, but if that's off, then we won't get
>> any faces at all.
>>
>> Which would be bad.
>
> I missed this the first time around, but, why would that be bad?  If the
> user turns off font-lock-mode then not getting faces should be expected,
> no?

Font locking is about adding decorative highlights.  The background face
table.el adds is functional -- it says what cell is selected.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 5 years and 171 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.