From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 28 17:31:43 2019 Received: (at submit) by debbugs.gnu.org; 28 Apr 2019 21:31:43 +0000 Received: from localhost ([127.0.0.1]:37938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKrOh-0008Lu-7v for submit@debbugs.gnu.org; Sun, 28 Apr 2019 17:31:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKrOf-0008G9-50 for submit@debbugs.gnu.org; Sun, 28 Apr 2019 17:31:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:56587) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hKrOZ-0005sz-AJ for submit@debbugs.gnu.org; Sun, 28 Apr 2019 17:31:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKrOX-0005Cm-O4 for bug-gnu-emacs@gnu.org; Sun, 28 Apr 2019 17:31:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKrOW-0005sd-Aq for bug-gnu-emacs@gnu.org; Sun, 28 Apr 2019 17:31:33 -0400 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]:39274) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hKrOW-0005ru-15 for bug-gnu-emacs@gnu.org; Sun, 28 Apr 2019 17:31:32 -0400 Received: by mail-lf1-x143.google.com with SMTP id d12so6405408lfk.6 for ; Sun, 28 Apr 2019 14:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=GR8ALLWw5dTStB9+oNq25m1T+p6uzulEjwvO6KOw6SI=; b=ZKMiBdLgdP2lW2Vpm0MOA/tfADrAFsb1jbv9WDzGglUBfvV80UN7pHIS8KMWvxH4ge 35dMD2KjLmC/YWBXpH7G2koJZ17MUfjxAeEwGqc41+utHhFClowCJx8jOio4B9l+oYyB 7b86I2GnlyuIAXIZgZBCrZX4DIL1cy3+MWklpDnk4l5NuX9Uw8S/6kw5GQ4qCaRcaqPS YLV4tqe81S/gYA28TC5wzpS6enV+WNSIUdqBFjLOSgNiYU1wm8DkidSA86vQCffs4tbj JTFos2aFOM4mYfFMMWE5f9/TKacgLmCDACpEdURwiuThnH576cFG9crrK2+yn4cgr5Hl ohtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=GR8ALLWw5dTStB9+oNq25m1T+p6uzulEjwvO6KOw6SI=; b=Yjc/QOS5lSzpXv2B1pWn+zX71SOKkSsdLUMlG5nh0+LfKFzE3lRLRC32dK55qQ5xP1 EHkKb6eZZaVabMWlXrCTf192NAZBNx9lfaKiGetZhRrPkXMTkNWy/RrLdAADacVikk5H tRPkuNRAo4aI9OI7eDhFD1pgjuVPc+eVMmNE7SLJlwtqLgsOG/N/fsN0VG/yydE9vpjM +JwCkpDKhG1ayoIwubLKveQkWGH+5qyPE2kNVmR2DQ/pHIIhPMphNrGcPEnCELxQ6QKu fCLDm/yN79ymbCN3wTMnqYjRoATQRGXPL6EEKPyUy5fFic+FGaX+RQcV6PAZ7GOFQGG1 o/fA== X-Gm-Message-State: APjAAAVMamA6r4YE6514pJk4cJZ7rPtYHXDwdd7YT/qv2+M2LcLrq1N5 Rv7h97nHL1PtERGqfL2NqLEwJ1Ka X-Google-Smtp-Source: APXvYqyyKTB9f6h5nIP6wmQC7b1/eEYpiVzcL0KM9VdfPPfkmgu/7ca7A5bvDZGvTbkIQC34qmN3FQ== X-Received: by 2002:a19:5e56:: with SMTP id z22mr31810302lfi.81.1556487087681; Sun, 28 Apr 2019 14:31:27 -0700 (PDT) Received: from ?IPv6:2a00:f41:1cdd:4b24:c115:772:5ade:1d94? ([2a00:f41:1cdd:4b24:c115:772:5ade:1d94]) by smtp.gmail.com with ESMTPSA id t4sm945094ljd.22.2019.04.28.14.31.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Apr 2019 14:31:27 -0700 (PDT) From: Sebastian Urban Subject: 25.2; table.el should use 'font-lock-face' instead of 'face' To: Bug GNU Emacs Message-ID: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> Date: Sun, 28 Apr 2019 23:31:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::143 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is follow up (part two of solution) to this bug#35044: https://lists.gnu.org/archive/html/bug-gnu-emacs/2019-03/msg01011.html and then (two months split) https://lists.gnu.org/archive/html/bug-gnu-emacs/2019-04/msg00739.html or at debbugs https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35044 In short "table.el" uses text property 'face' (table-cell) which causes losing of cell highlight when user switches from modes like "Text" or "Fundamental" to modes that use "Font lock", like "Outline". Also when user switches back, 'face' is not applied immediately in every cell, but one by one, when cursor is moved from cell to cell. For both problems a solution seems to be an update to "table.el", which will change 'face' to 'font-lock-face'. If it helps, I found 4 places in code that probably need to be changed: - 'defface table-cell' at line 680, - 'defun table--put-cell-face-property' at line 5172, - 'defun table--remove-cell-properties' at line 5189, - 'defun table--update-cell-face' at line 5209. --- In GNU Emacs 25.2.1 (i686-w64-mingw32) of 2017-04-24 built on LAPHROAIG Windowing system distributor 'Microsoft Corp.', version 6.1.7601 Configured using: 'configure --host=i686-w64-mingw32 --without-dbus --without-compress-install 'CFLAGS=-static -O2 -g3'' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS Important settings: value of $LANG: PLK locale-coding-system: cp1250 Major mode: Fundamental Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Recent messages: Preparing diary... No diary entries for Niedziela, 28 KwiecieĊ„ 2019 Preparing diary...done For information about GNU Emacs and the GNU system, type C-h C-a. next-line: End of buffer Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec password-cache epg gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew holidays hol-loaddefs diary-lib diary-loaddefs cal-menu calendar cal-loaddefs finder-inf package epg-config seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote w32notify w32 multi-tty make-network-process emacs) Memory information: ((conses 8 114624 7479) (symbols 32 22205 0) (miscs 32 94 203) (strings 16 23812 4853) (string-bytes 1 741124) (vectors 8 15933) (vector-slots 4 485829 3692) (floats 8 712 215) (intervals 28 263 31) (buffers 520 21)) From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 28 18:05:05 2019 Received: (at 35481) by debbugs.gnu.org; 28 Apr 2019 22:05:05 +0000 Received: from localhost ([127.0.0.1]:37970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKruz-0001HK-LC for submit@debbugs.gnu.org; Sun, 28 Apr 2019 18:05:05 -0400 Received: from mail-qt1-f174.google.com ([209.85.160.174]:35802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKrux-0001Gg-UK; Sun, 28 Apr 2019 18:05:04 -0400 Received: by mail-qt1-f174.google.com with SMTP id e5so3036495qtq.2; Sun, 28 Apr 2019 15:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KxzK0O1Ysr+gQ5m0Uubd6Mr8gz/+3w2BoI8Ubp6nlD0=; b=kitfdq4wzEYu/hncpuq+7W2agf8OwwG70TipJD/5ummZU9zROF5gaiOWPjXTjfowIG 4edtHbAzoMbdduNRwPLY70Qoa6KDS4xGwcvaSU9pVBZQWKoBH1zYiE5onWcz1ry9fsZF qynfb6WS8ERCwwy54KzuqEJwAnXVBDtETKNU9AIM0GTNyi196r+9zCm3xmEILfaH8XfK GRnf0TAxfpVtaPHolaID5Gu/gHEswjd6dq7HJ4+aVJoxDcUqJbN3HL06x3NNZj/FeYuB a09HevZjY9uM4zk50jljo0OAbBz/reEkus/re+ik7IVKmxSb+A0wIUPKpyHzQEfT+VrI o0OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=KxzK0O1Ysr+gQ5m0Uubd6Mr8gz/+3w2BoI8Ubp6nlD0=; b=Vh1RMyipCHFaNgCfHGt8WfeYAz/CtAWDjYFjbv1wn5jkZezfAxxtGGaZ5aa0RMxl9x Pc9D1i3+BGqqYca9DCeUd5fNS+32cFu2iEBIJ0/p/TpXVOIjsWLWE8PthT8OE1XzENaN UktVoZMSwyOg9tTAFFSPaBWAUWNwLEGZbAlzah+ucQ9jR3giUmRI45riicIekLHOVqZT oqtpZaHPe4R4waXa1geuX5net4HoRdZAU6RVfB02CT14kuQKf5otxQssqx/AxORagT1j hWhylZZssN6A3HBdn2f86sXGHDS4Vj7s/RBXOui0EhTT6o+V3E0cdf1TCPwvBbuDRRrc Vo4A== X-Gm-Message-State: APjAAAV2Z96peiF7wdKAzksAvfxFATo6I2Gkdt/0X6w4hEwzchZ2/k6S W09dzY2wZdDb1iNAy1LFqa3n32jM X-Google-Smtp-Source: APXvYqwr9Mva6q2sEjVea9z0yXtyjJ/MnU0oA92g9kSg7cx/0YztsKd9y8LIBd0EaOUKbAwyUVH5Ug== X-Received: by 2002:ad4:444e:: with SMTP id l14mr15473614qvt.138.1556489098305; Sun, 28 Apr 2019 15:04:58 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id x21sm4914304qtm.65.2019.04.28.15.04.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Apr 2019 15:04:57 -0700 (PDT) From: Noam Postavsky To: Sebastian Urban Subject: Re: bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face' References: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> Date: Sun, 28 Apr 2019 18:04:56 -0400 In-Reply-To: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> (Sebastian Urban's message of "Sun, 28 Apr 2019 23:31:27 +0200") Message-ID: <871s1lpz07.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35481 Cc: 35481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 35481 minor tags 35481 + easy confirmed quit Sebastian Urban writes: > For both problems a solution seems to be an update to "table.el", which > will change 'face' to 'font-lock-face'. > > If it helps, I found 4 places in code that probably need to be changed: > - 'defface table-cell' at line 680, The defface can be left alone. It's only the use of the 'face' text property that can be a problem. > - 'defun table--put-cell-face-property' at line 5172, > - 'defun table--remove-cell-properties' at line 5189, > - 'defun table--update-cell-face' at line 5209. From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 03:16:34 2019 Received: (at 35481) by debbugs.gnu.org; 13 May 2019 07:16:34 +0000 Received: from localhost ([127.0.0.1]:43933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ5CL-00075q-Un for submit@debbugs.gnu.org; Mon, 13 May 2019 03:16:34 -0400 Received: from mail-lj1-f182.google.com ([209.85.208.182]:45468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ5CJ-00075Z-AY for 35481@debbugs.gnu.org; Mon, 13 May 2019 03:16:32 -0400 Received: by mail-lj1-f182.google.com with SMTP id r76so9896311lja.12 for <35481@debbugs.gnu.org>; Mon, 13 May 2019 00:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kLgY8W0sfd7WTpwNG4yvk0Wlxare7pQ7Nq1sQ5AutEE=; b=QYoyA23NiKqwoWpmcOma6SWfvdoUefmO+dtcA+/wEGWv2wZVkA76p0obo0cm8BQLOk Z1SkVKWXpZV4kjefakmoX8eym5rqY2F4d7AOjGfaeP+Vk6j1xt5qxdNQbWL0JIkVAoze LGuTPhXbLcsZvJy+gGkfIFsKk84FCQ1Y8YgKGZgfNbMxW+x4Jmw0Qi0RnrWcaIGfkkIU eCwxfR80iYV3hxPTCmKaKNhw5SWfFqr2Tu/cFt3rX5fUi8QFD8AxGxAERCUE6DLeZdGj Bi9qu+d5B7P5T3+KRjb5A/Iq8ISdlPP5VnJvfVKXPVZSgilP9H8tBN2Qx8s35zPqTgxI MiXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kLgY8W0sfd7WTpwNG4yvk0Wlxare7pQ7Nq1sQ5AutEE=; b=Sx/2dk3fnbKdfqmaKSFGzGDXhWKiHWvwAosAhXQdoSusPuCIw+gj2CoB7RShq0upDd D6KaCHwDDZD6yoi66t+PlC/KTwh/Sr0e2vEVCgkpjwyAeouThhcO080AazUPIJTLLCSm 4vhSpj8EOYycw1Tlu5B3C6nseOMKIz5qtFPRXNJpja2u06d6RfBUk0iizpXNJnEyOlkN r7GLOSYAXPMVCye8+Qv9/T+kzxt3v2QsTPU6lSYvddG+0pcSJbzJDAM48y+l0Mn3cbIU keYt6UP+OyBveW9s+Y4+tv/YpWGNXUnjPRNpnY8z/+Riw6a53hdWLjr9epabCTAAw0XY 9NOQ== X-Gm-Message-State: APjAAAUHyGwRa6qZDQrbRFWCXrXQfa9bSXTP/awDOV+nVScTHycZDzYP PimUJU8c0Gfr+OH7WBRzm7WO4QKl X-Google-Smtp-Source: APXvYqxsWSxug5XSm8KMlwqKFrTMKUYx7+bVQJfxDfvaCHXpGcDoiukfypTCbgW+K9MpjOnrO4ZZyg== X-Received: by 2002:a2e:8744:: with SMTP id q4mr885741ljj.172.1557731785206; Mon, 13 May 2019 00:16:25 -0700 (PDT) Received: from [89.161.9.216] (ip-89-161-9-216.tel.tkb.net.pl. [89.161.9.216]) by smtp.gmail.com with ESMTPSA id q26sm1500306lfd.54.2019.05.13.00.16.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 May 2019 00:16:24 -0700 (PDT) Subject: Re: bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face' To: Noam Postavsky References: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> <871s1lpz07.fsf@gmail.com> From: Sebastian Urban Message-ID: <3a528aa8-971b-01f2-2233-dbe70d959f2a@gmail.com> Date: Mon, 13 May 2019 09:16:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <871s1lpz07.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35481 Cc: 35481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is just a reminder, because "This bug report was last modified 13 days ago." From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 04 08:09:49 2019 Received: (at 35481) by debbugs.gnu.org; 4 Aug 2019 12:09:49 +0000 Received: from localhost ([127.0.0.1]:60729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huFKf-0004oZ-66 for submit@debbugs.gnu.org; Sun, 04 Aug 2019 08:09:49 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:39048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huFKe-0004oM-1Y for 35481@debbugs.gnu.org; Sun, 04 Aug 2019 08:09:48 -0400 Received: by mail-wr1-f44.google.com with SMTP id x4so28463304wrt.6 for <35481@debbugs.gnu.org>; Sun, 04 Aug 2019 05:09:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=C/jM6ddfAM+DsbdCWGHIS6HSDMB2PTdXeYb3gP6MXqQ=; b=NyizrJ6Dm6mQx1cKZ+dwmjfi3omSAtYktM4SU6kOWEQp65kvMsxxeiLG2+ANUhtE1d pRkH6fjD/TJ1uLwx5ng/eevzYtpfZqYs2Qvm3R3kdoswvmsJPptEWiUy9jFfIHieiJRA dSGLGJs75GvP4kmFM28vITNPqlAZIOwCxgl/WhUOKZe6LEcZrA5OLmvjMoXQ00qrzGOT D8PJEsRPVHM09rPBtVMROireCz5Z+uAGqgAgitj3ft9sKbiSExulc5ZLotKbHXfwu9ny rLRbB5xMtAoW/wVO1VPVbO52mXmglgfy2WEyrnSGbpi14mJhz0wgfpCY8ElhXoY+kieL mg7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C/jM6ddfAM+DsbdCWGHIS6HSDMB2PTdXeYb3gP6MXqQ=; b=Ez0KCYPtEsuvQ+GX7HT6p2sAj9BTYb9quHRZDFxogN29mdu8cfxjti2n8yFZKCyZvQ hGQWj5DM87OBigqGKs1VCYEylClGqXi+ByOKI5iJ9kzHvFOiythUyRkgHaXB1lCsZmQE MfskPUHtH3ib3mA+0X/AJ6REjVeVCaB2P0s9syfRGHW91+P7CbhtHFZVpD4r3GHEPpEf /nM2tNdgqPba7tILtwtgeT0iIfyqBBkbiJ/rzvCBz76B7rsywTQdpdXvlGxI+SO4KGUG PR3TKGsPNs7bx3YDAJfzWkOPdnFUSa2WcajFfujLdQzPWvmyc66z4GcirCmZm7dCuUTc fsQw== X-Gm-Message-State: APjAAAVH094XjtCtBV1LbvESbdch9+q/+IfbBnBdh1MPuQvyEHUn9WUq RXG3itcJdX4ar7VxeeIquvAO6RMF X-Google-Smtp-Source: APXvYqws5NZYntoXaBr4AtP+nN+ikM4RD4N1t8FD3eXUamEkX+kBTI0tK2B4AAO9Y0D/eU3BXbxUVw== X-Received: by 2002:adf:e4cc:: with SMTP id v12mr157220058wrm.22.1564920582253; Sun, 04 Aug 2019 05:09:42 -0700 (PDT) Received: from ?IPv6:2a00:f41:18a3:a2d2:b0b6:8a89:d289:fb62? ([2a00:f41:18a3:a2d2:b0b6:8a89:d289:fb62]) by smtp.gmail.com with ESMTPSA id l25sm62341845wme.13.2019.08.04.05.09.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Aug 2019 05:09:41 -0700 (PDT) From: Sebastian Urban Subject: Re: bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face' To: Noam Postavsky References: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> <871s1lpz07.fsf@gmail.com> Message-ID: <3bca68db-d16d-2d53-cf1e-ba62a5370c99@gmail.com> Date: Sun, 4 Aug 2019 14:09:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <871s1lpz07.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35481 Cc: 35481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is just a reminder, because "This bug report was last modified 80 days ago." From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 30 15:44:20 2019 Received: (at 35481) by debbugs.gnu.org; 30 Oct 2019 19:44:21 +0000 Received: from localhost ([127.0.0.1]:51511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPttE-0007nL-Lv for submit@debbugs.gnu.org; Wed, 30 Oct 2019 15:44:20 -0400 Received: from quimby.gnus.org ([80.91.231.51]:33554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPttC-0007n6-QI for 35481@debbugs.gnu.org; Wed, 30 Oct 2019 15:44:19 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPtt8-0002xE-R7; Wed, 30 Oct 2019 20:44:17 +0100 From: Lars Ingebrigtsen To: Sebastian Urban Subject: Re: 25.2; table.el should use 'font-lock-face' instead of 'face' References: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> Date: Wed, 30 Oct 2019 20:44:14 +0100 In-Reply-To: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> (Sebastian Urban's message of "Sun, 28 Apr 2019 23:31:27 +0200") Message-ID: <87d0eeow6p.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sebastian Urban writes: > In short "table.el" uses text property 'face' (table-cell) which causes > losing of cell highlight when user switches from modes like "Text" or > "Fundamental" to modes that use "Font lock", like "O [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35481 Cc: 35481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sebastian Urban writes: > In short "table.el" uses text property 'face' (table-cell) which causes > losing of cell highlight when user switches from modes like "Text" or > "Fundamental" to modes that use "Font lock", like "Outline". Also when > user switches back, 'face' is not applied immediately in every cell, but > one by one, when cursor is moved from cell to cell. > > For both problems a solution seems to be an update to "table.el", which > will change 'face' to 'font-lock-face'. > > If it helps, I found 4 places in code that probably need to be changed: > - 'defface table-cell' at line 680, > - 'defun table--put-cell-face-property' at line 5172, > - 'defun table--remove-cell-properties' at line 5189, > - 'defun table--update-cell-face' at line 5209. The patch below does this, but I'm not sure it's right. When we're using font-lock-face instead of face, then things work as normal when we're using global-font-lock-mode, but if that's off, then we won't get any faces at all. Which would be bad. I grepped around, but other modes don't seem to care about that. But I guess it's somewhat unusual for a minor mode to do stuff like this? I think putting both font-lock-face and face on the text would do the trick here, but is that the way to go? diff --git a/lisp/textmodes/table.el b/lisp/textmodes/table.el index 839df035d2..92aaa46ad6 100644 --- a/lisp/textmodes/table.el +++ b/lisp/textmodes/table.el @@ -5151,7 +5151,7 @@ table--put-cell-indicator-property (defun table--put-cell-face-property (beg end &optional object) "Put cell face property." - (put-text-property beg end 'face 'table-cell object)) + (put-text-property beg end 'font-lock-face 'table-cell object)) (defun table--put-cell-keymap-property (beg end &optional object) "Put cell keymap property." @@ -5178,7 +5178,7 @@ table--remove-cell-properties 'table-cell nil 'table-justify nil 'table-valign nil - 'face nil + 'font-lock-face nil 'rear-nonsticky nil 'cursor-sensor-functions nil 'keymap nil) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 30 15:44:33 2019 Received: (at control) by debbugs.gnu.org; 30 Oct 2019 19:44:33 +0000 Received: from localhost ([127.0.0.1]:51514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPttQ-0007nu-W3 for submit@debbugs.gnu.org; Wed, 30 Oct 2019 15:44:33 -0400 Received: from quimby.gnus.org ([80.91.231.51]:33568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPttN-0007nf-9Y for control@debbugs.gnu.org; Wed, 30 Oct 2019 15:44:29 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPttK-0002xq-KD for control@debbugs.gnu.org; Wed, 30 Oct 2019 20:44:28 +0100 Date: Wed, 30 Oct 2019 20:44:26 +0100 Message-Id: <87bltyow6d.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #35481 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 35481 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35481 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 04:07:18 2019 Received: (at 35481) by debbugs.gnu.org; 17 Nov 2019 09:07:18 +0000 Received: from localhost ([127.0.0.1]:40274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWGWc-0002OZ-5a for submit@debbugs.gnu.org; Sun, 17 Nov 2019 04:07:18 -0500 Received: from quimby.gnus.org ([95.216.78.240]:45030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWGWa-0002OJ-2P for 35481@debbugs.gnu.org; Sun, 17 Nov 2019 04:07:16 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWGWR-0005BY-25; Sun, 17 Nov 2019 10:07:09 +0100 From: Lars Ingebrigtsen To: Sebastian Urban Subject: Re: bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face' References: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> <87d0eeow6p.fsf@gnus.org> Date: Sun, 17 Nov 2019 10:07:06 +0100 In-Reply-To: <87d0eeow6p.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 30 Oct 2019 20:44:14 +0100") Message-ID: <877e3yan2d.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > I grepped around, but other modes don't seem to care about that. But I > guess it's somewhat unusual for a minor mode to do stuff like this? > > I think putting both font-lock-face and face on the t [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35481 Cc: 35481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > I grepped around, but other modes don't seem to care about that. But I > guess it's somewhat unusual for a minor mode to do stuff like this? > > I think putting both font-lock-face and face on the text would do the > trick here, but is that the way to go? There weren't any comments in two weeks, and this change does fix the problem (if inelegantly), so I've applied it. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 04:07:26 2019 Received: (at control) by debbugs.gnu.org; 17 Nov 2019 09:07:26 +0000 Received: from localhost ([127.0.0.1]:40277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWGWk-0002Ov-Ev for submit@debbugs.gnu.org; Sun, 17 Nov 2019 04:07:26 -0500 Received: from quimby.gnus.org ([95.216.78.240]:45044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWGWf-0002OS-NR for control@debbugs.gnu.org; Sun, 17 Nov 2019 04:07:24 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWGWY-0005Bf-4r for control@debbugs.gnu.org; Sun, 17 Nov 2019 10:07:16 +0100 Date: Sun, 17 Nov 2019 10:07:13 +0100 Message-Id: <875zjian26.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #35481 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 35481 fixed close 35481 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35481 fixed close 35481 27.1 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 28 18:27:38 2019 Received: (at 35481) by debbugs.gnu.org; 28 Nov 2019 23:27:38 +0000 Received: from localhost ([127.0.0.1]:59243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaTCD-0003CP-Rd for submit@debbugs.gnu.org; Thu, 28 Nov 2019 18:27:38 -0500 Received: from mail-qk1-f178.google.com ([209.85.222.178]:46453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaTCC-0003C9-Tr for 35481@debbugs.gnu.org; Thu, 28 Nov 2019 18:27:37 -0500 Received: by mail-qk1-f178.google.com with SMTP id f5so5674833qkm.13 for <35481@debbugs.gnu.org>; Thu, 28 Nov 2019 15:27:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jIoeH2x5FVf+keXSou7t5jTXxm6iPQ+oadvDMZ7Fe4k=; b=uaxJCxrqp73uqHL0qIu+DftksNA3nmnlysTuEMB1tQ7ZSiOTb2HxJZcW97KYRLvSTr Ah4RW/tbSFLcYf8OrkjJKmShEdHKq8B1qz6hUflb15lvVEKOGcmCM+B0GtvLOExHEx9O af4RU8YzhfiX+lrYjzXrAJMrb7Czxa2E7uDYwWzaVduGn73ptKelYnSRdGGKY5EHbQj6 mrGR5c61FiQ4DJSjYT+x1T78Q/E4A2116H8a1PHGFcP2Q/sXXtskTiwYE27YsijWJyB9 dDYDdpJGFZ77Elbx9nzaeslkf8R+cFCpYHerfNGUoQY/a3gZXSq/+7+oGPIgppODe8UK BNsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jIoeH2x5FVf+keXSou7t5jTXxm6iPQ+oadvDMZ7Fe4k=; b=heiP/XllQW0ObpW5HhM88EU3f6Vji5wyvAx3bttZvO77+PW267GK3+FBSKvvseS8kO 8FggiNpSSgqR27M1S9Gh+8SvcMuEJ1tU8fguNZWabO8Q/7o70hFSY4G/wDNDfXYxyuGr XKyZ5/fuB/+obdvlx6z3GruvjvdJ0nQeBFVI0+YzBjThI0MMlD8puhF/QL2b7lUk3Xu7 Zt9WfA8UiCi3r2iXnSJeFElfVjcsToxlzLsXB7+cg3MZdEDg/IOOEcCicgaX4NR6NENv xx+fpRH2Fw7JR5hPjeRuwvRzS/CUIE+yZNg2Wdhz8TvMA0gzZlUP5fwlYtNRpY8OhK8Q DiRQ== X-Gm-Message-State: APjAAAWNHGRyzynD6dR5Vd3BtryOcEHFy7Q5SKwL7YMifqbCqIQbkUki 40wudrDBphPS4jnivw31A+HYQjiE X-Google-Smtp-Source: APXvYqzDcAlhqyW5azTnN/35N1x1Rk07rBX3gWHkzR/mmjsSol7lOIfikjIaB/s+9rlsOytkrYWVgQ== X-Received: by 2002:a37:8504:: with SMTP id h4mr12904226qkd.276.1574983649414; Thu, 28 Nov 2019 15:27:29 -0800 (PST) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id o2sm9293055qkf.68.2019.11.28.15.27.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Nov 2019 15:27:29 -0800 (PST) From: Noam Postavsky To: Lars Ingebrigtsen Subject: Re: bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face' References: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> <87d0eeow6p.fsf@gnus.org> Date: Thu, 28 Nov 2019 18:27:28 -0500 In-Reply-To: <87d0eeow6p.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 30 Oct 2019 20:44:14 +0100") Message-ID: <87tv6nd1jz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35481 Cc: Sebastian Urban , 35481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > The patch below does this, but I'm not sure it's right. When we're > using font-lock-face instead of face, then things work as normal when > we're using global-font-lock-mode, but if that's off, then we won't get > any faces at all. > > Which would be bad. I missed this the first time around, but, why would that be bad? If the user turns off font-lock-mode then not getting faces should be expected, no? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 05 04:55:33 2019 Received: (at 35481) by debbugs.gnu.org; 5 Dec 2019 09:55:33 +0000 Received: from localhost ([127.0.0.1]:43019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icnrA-0000i2-2r for submit@debbugs.gnu.org; Thu, 05 Dec 2019 04:55:33 -0500 Received: from quimby.gnus.org ([95.216.78.240]:45886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icnr8-0000hj-EM for 35481@debbugs.gnu.org; Thu, 05 Dec 2019 04:55:30 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1icnqz-0004Im-Tp; Thu, 05 Dec 2019 10:55:24 +0100 From: Lars Ingebrigtsen To: Noam Postavsky Subject: Re: bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face' References: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> <87d0eeow6p.fsf@gnus.org> <87tv6nd1jz.fsf@gmail.com> Date: Thu, 05 Dec 2019 10:55:21 +0100 In-Reply-To: <87tv6nd1jz.fsf@gmail.com> (Noam Postavsky's message of "Thu, 28 Nov 2019 18:27:28 -0500") Message-ID: <87muc7rt9y.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Noam Postavsky writes: > Lars Ingebrigtsen writes: > >> The patch below does this, but I'm not sure it's right. When we're >> using font-lock-face instead of face, then things work as normal when >> we're u [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnus.org] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35481 Cc: Sebastian Urban , 35481@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > Lars Ingebrigtsen writes: > >> The patch below does this, but I'm not sure it's right. When we're >> using font-lock-face instead of face, then things work as normal when >> we're using global-font-lock-mode, but if that's off, then we won't get >> any faces at all. >> >> Which would be bad. > > I missed this the first time around, but, why would that be bad? If the > user turns off font-lock-mode then not getting faces should be expected, > no? Font locking is about adding decorative highlights. The background face table.el adds is functional -- it says what cell is selected. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Jun 21 05:20:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 02 Jan 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator