GNU bug report logs - #35470
[PATCH] services: slim: Honor the value of slim from slim-configuration.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Diego Nicola Barbato <dnbarbato <at> posteo.de>
Subject: bug#35470: closed (Re: [bug#35470] [PATCH] services: slim: Honor
 the value of slim from slim-configuration.)
Date: Mon, 29 Apr 2019 07:33:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#35470: [PATCH] services: slim: Honor the value of slim from slim-configuration.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 35470 <at> debbugs.gnu.org.

-- 
35470: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35470
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Diego Nicola Barbato <dnbarbato <at> posteo.de>
Cc: 35470-done <at> debbugs.gnu.org
Subject: Re: [bug#35470] [PATCH] services: slim: Honor the value of slim from
 slim-configuration.
Date: Mon, 29 Apr 2019 09:32:26 +0200

Hi,

Diego Nicola Barbato <dnbarbato <at> posteo.de> skribis:

>>From 85c4a2764baba987d1ddd4dd67f7d33f9e49e9ea Mon Sep 17 00:00:00 2001
> From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
> Date: Sat, 27 Apr 2019 19:45:47 +0200
> Subject: [PATCH] services: slim: Honor the value of slim from
>  slim-configuration.
>
> Previously setting the slim field in slim-configuration would have no effect.
>
> * gnu/services/xorg.scm (slim-shepherd-service): Remove unused let binding for
>   slim.  Use (slim-configuration-slim config) instead of the default slim.

Good catch.  Applied, thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: slim: Honor the value of slim from
 slim-configuration.
Date: Sun, 28 Apr 2019 14:14:21 +0200

[Message part 4 (text/plain, inline)]

Hi Guix,

I have noticed that setting the slim field in slim-configuration does
not have any effect.  This patch should fix that.

Regards,

Diego

[0001-services-slim-Honor-the-value-of-slim-from-slim-conf.patch (text/x-patch, inline)]

From 85c4a2764baba987d1ddd4dd67f7d33f9e49e9ea Mon Sep 17 00:00:00 2001
From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
Date: Sat, 27 Apr 2019 19:45:47 +0200
Subject: [PATCH] services: slim: Honor the value of slim from
 slim-configuration.

Previously setting the slim field in slim-configuration would have no effect.

* gnu/services/xorg.scm (slim-shepherd-service): Remove unused let binding for
  slim.  Use (slim-configuration-slim config) instead of the default slim.
---
 gnu/services/xorg.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
index d4e73c13b4..44dcec4ec9 100644
--- a/gnu/services/xorg.scm
+++ b/gnu/services/xorg.scm
@@ -502,7 +502,6 @@ desktop session from the system or user profile will be used."
   (define slim.cfg
     (let ((xinitrc (xinitrc #:fallback-session
                             (slim-configuration-auto-login-session config)))
-          (slim    (slim-configuration-slim config))
           (xauth   (slim-configuration-xauth config))
           (startx  (xorg-start-command (slim-configuration-xorg config)))
           (shepherd   (slim-configuration-shepherd config))
@@ -547,7 +546,9 @@ reboot_cmd " shepherd "/sbin/reboot\n"
               (false-if-exception (delete-file "/var/run/slim.lock"))
 
               (fork+exec-command
-               (list (string-append #$slim "/bin/slim") "-nodaemon")
+               (list (string-append #$(slim-configuration-slim config)
+                                    "/bin/slim")
+                     "-nodaemon")
                #:environment-variables
                (list (string-append "SLIM_CFGFILE=" #$slim.cfg)
                      #$@(if theme
-- 
2.21.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.