From unknown Tue Sep 09 22:00:07 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#35470] [PATCH] services: slim: Honor the value of slim from slim-configuration. Resent-From: Diego Nicola Barbato Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 28 Apr 2019 12:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35470 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 35470@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155645367721072 (code B ref -1); Sun, 28 Apr 2019 12:15:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Apr 2019 12:14:37 +0000 Received: from localhost ([127.0.0.1]:36870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKihZ-0005To-ED for submit@debbugs.gnu.org; Sun, 28 Apr 2019 08:14:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKihX-0005Tb-9B for submit@debbugs.gnu.org; Sun, 28 Apr 2019 08:14:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:37895) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hKihS-0000mZ-1M for submit@debbugs.gnu.org; Sun, 28 Apr 2019 08:14:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKihR-0006Qx-0t for guix-patches@gnu.org; Sun, 28 Apr 2019 08:14:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKihP-0000m5-Pu for guix-patches@gnu.org; Sun, 28 Apr 2019 08:14:29 -0400 Received: from mout02.posteo.de ([185.67.36.66]:40907) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hKihP-0000l9-72 for guix-patches@gnu.org; Sun, 28 Apr 2019 08:14:27 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 42D902400E5 for ; Sun, 28 Apr 2019 14:14:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1556453663; bh=WMw1rc/5i9j5nURAkig4ZuIPZlCATxjLEsaF+sLznbo=; h=From:To:Subject:Date:From; b=aUevRzvclGeaUc4fiky5D++A1sCWdhKqZ+u+xMyN2xKYCTsiMhlREjAf9YGK+dlbK 6xFTQd17p10ZbisWUmLit1OfXuAhYrmlGlF3U9nsf4PdexP3Xo14aK04CPu4RdcDUF baIcarqj37Oid2aV7QRO20C3GbEgZS13eEZ84fVINbAgnWzUpuG1DobJ/k7phdo/L5 lIawPF4/Qq7T4MYLIa2H8AL596O7AmEbk9Sa6E8ZgnbAEvpGtHVMz6OU13d+NCeCoG i7jEjrrZ7zQXJBk0slWWlD+1rZRcDTmoT3DWW5DkuvidEhIt1qr+MkIB8sdKmx5z9q QI4bCatqvHdNg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 44sRYB2lKdz9rxD for ; Sun, 28 Apr 2019 14:14:22 +0200 (CEST) From: Diego Nicola Barbato Date: Sun, 28 Apr 2019 14:14:21 +0200 Message-ID: <87ef5m9vj6.fsf@GlaDOS.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 185.67.36.66 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Hi Guix, I have noticed that setting the slim field in slim-configuration does not have any effect. This patch should fix that. Regards, Diego --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-services-slim-Honor-the-value-of-slim-from-slim-conf.patch >From 85c4a2764baba987d1ddd4dd67f7d33f9e49e9ea Mon Sep 17 00:00:00 2001 From: Diego Nicola Barbato Date: Sat, 27 Apr 2019 19:45:47 +0200 Subject: [PATCH] services: slim: Honor the value of slim from slim-configuration. Previously setting the slim field in slim-configuration would have no effect. * gnu/services/xorg.scm (slim-shepherd-service): Remove unused let binding for slim. Use (slim-configuration-slim config) instead of the default slim. --- gnu/services/xorg.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm index d4e73c13b4..44dcec4ec9 100644 --- a/gnu/services/xorg.scm +++ b/gnu/services/xorg.scm @@ -502,7 +502,6 @@ desktop session from the system or user profile will be used." (define slim.cfg (let ((xinitrc (xinitrc #:fallback-session (slim-configuration-auto-login-session config))) - (slim (slim-configuration-slim config)) (xauth (slim-configuration-xauth config)) (startx (xorg-start-command (slim-configuration-xorg config))) (shepherd (slim-configuration-shepherd config)) @@ -547,7 +546,9 @@ reboot_cmd " shepherd "/sbin/reboot\n" (false-if-exception (delete-file "/var/run/slim.lock")) (fork+exec-command - (list (string-append #$slim "/bin/slim") "-nodaemon") + (list (string-append #$(slim-configuration-slim config) + "/bin/slim") + "-nodaemon") #:environment-variables (list (string-append "SLIM_CFGFILE=" #$slim.cfg) #$@(if theme -- 2.21.0 --=-=-=-- From unknown Tue Sep 09 22:00:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Diego Nicola Barbato Subject: bug#35470: closed (Re: [bug#35470] [PATCH] services: slim: Honor the value of slim from slim-configuration.) Message-ID: References: <87imuxjmgl.fsf@gnu.org> <87ef5m9vj6.fsf@GlaDOS.home> X-Gnu-PR-Message: they-closed 35470 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 35470@debbugs.gnu.org Date: Mon, 29 Apr 2019 07:33:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1556523182-588-1" This is a multi-part message in MIME format... ------------=_1556523182-588-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #35470: [PATCH] services: slim: Honor the value of slim from slim-configura= tion. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 35470@debbugs.gnu.org. --=20 35470: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35470 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1556523182-588-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 35470-done) by debbugs.gnu.org; 29 Apr 2019 07:32:37 +0000 Received: from localhost ([127.0.0.1]:38309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL0mD-00008t-EP for submit@debbugs.gnu.org; Mon, 29 Apr 2019 03:32:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL0mA-00008d-9N for 35470-done@debbugs.gnu.org; Mon, 29 Apr 2019 03:32:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL0m4-0000uk-SU; Mon, 29 Apr 2019 03:32:28 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=48232 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hL0m4-0006wc-5f; Mon, 29 Apr 2019 03:32:28 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Diego Nicola Barbato Subject: Re: [bug#35470] [PATCH] services: slim: Honor the value of slim from slim-configuration. References: <87ef5m9vj6.fsf@GlaDOS.home> Date: Mon, 29 Apr 2019 09:32:26 +0200 In-Reply-To: <87ef5m9vj6.fsf@GlaDOS.home> (Diego Nicola Barbato's message of "Sun, 28 Apr 2019 14:14:21 +0200") Message-ID: <87imuxjmgl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35470-done Cc: 35470-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Diego Nicola Barbato skribis: >>>From 85c4a2764baba987d1ddd4dd67f7d33f9e49e9ea Mon Sep 17 00:00:00 2001 > From: Diego Nicola Barbato > Date: Sat, 27 Apr 2019 19:45:47 +0200 > Subject: [PATCH] services: slim: Honor the value of slim from > slim-configuration. > > Previously setting the slim field in slim-configuration would have no eff= ect. > > * gnu/services/xorg.scm (slim-shepherd-service): Remove unused let bindin= g for > slim. Use (slim-configuration-slim config) instead of the default slim. Good catch. Applied, thanks! Ludo=E2=80=99. ------------=_1556523182-588-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Apr 2019 12:14:37 +0000 Received: from localhost ([127.0.0.1]:36870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKihZ-0005To-ED for submit@debbugs.gnu.org; Sun, 28 Apr 2019 08:14:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKihX-0005Tb-9B for submit@debbugs.gnu.org; Sun, 28 Apr 2019 08:14:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:37895) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hKihS-0000mZ-1M for submit@debbugs.gnu.org; Sun, 28 Apr 2019 08:14:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKihR-0006Qx-0t for guix-patches@gnu.org; Sun, 28 Apr 2019 08:14:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKihP-0000m5-Pu for guix-patches@gnu.org; Sun, 28 Apr 2019 08:14:29 -0400 Received: from mout02.posteo.de ([185.67.36.66]:40907) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hKihP-0000l9-72 for guix-patches@gnu.org; Sun, 28 Apr 2019 08:14:27 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 42D902400E5 for ; Sun, 28 Apr 2019 14:14:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1556453663; bh=WMw1rc/5i9j5nURAkig4ZuIPZlCATxjLEsaF+sLznbo=; h=From:To:Subject:Date:From; b=aUevRzvclGeaUc4fiky5D++A1sCWdhKqZ+u+xMyN2xKYCTsiMhlREjAf9YGK+dlbK 6xFTQd17p10ZbisWUmLit1OfXuAhYrmlGlF3U9nsf4PdexP3Xo14aK04CPu4RdcDUF baIcarqj37Oid2aV7QRO20C3GbEgZS13eEZ84fVINbAgnWzUpuG1DobJ/k7phdo/L5 lIawPF4/Qq7T4MYLIa2H8AL596O7AmEbk9Sa6E8ZgnbAEvpGtHVMz6OU13d+NCeCoG i7jEjrrZ7zQXJBk0slWWlD+1rZRcDTmoT3DWW5DkuvidEhIt1qr+MkIB8sdKmx5z9q QI4bCatqvHdNg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 44sRYB2lKdz9rxD for ; Sun, 28 Apr 2019 14:14:22 +0200 (CEST) From: Diego Nicola Barbato To: guix-patches@gnu.org Subject: [PATCH] services: slim: Honor the value of slim from slim-configuration. Date: Sun, 28 Apr 2019 14:14:21 +0200 Message-ID: <87ef5m9vj6.fsf@GlaDOS.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 185.67.36.66 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Hi Guix, I have noticed that setting the slim field in slim-configuration does not have any effect. This patch should fix that. Regards, Diego --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-services-slim-Honor-the-value-of-slim-from-slim-conf.patch >From 85c4a2764baba987d1ddd4dd67f7d33f9e49e9ea Mon Sep 17 00:00:00 2001 From: Diego Nicola Barbato Date: Sat, 27 Apr 2019 19:45:47 +0200 Subject: [PATCH] services: slim: Honor the value of slim from slim-configuration. Previously setting the slim field in slim-configuration would have no effect. * gnu/services/xorg.scm (slim-shepherd-service): Remove unused let binding for slim. Use (slim-configuration-slim config) instead of the default slim. --- gnu/services/xorg.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm index d4e73c13b4..44dcec4ec9 100644 --- a/gnu/services/xorg.scm +++ b/gnu/services/xorg.scm @@ -502,7 +502,6 @@ desktop session from the system or user profile will be used." (define slim.cfg (let ((xinitrc (xinitrc #:fallback-session (slim-configuration-auto-login-session config))) - (slim (slim-configuration-slim config)) (xauth (slim-configuration-xauth config)) (startx (xorg-start-command (slim-configuration-xorg config))) (shepherd (slim-configuration-shepherd config)) @@ -547,7 +546,9 @@ reboot_cmd " shepherd "/sbin/reboot\n" (false-if-exception (delete-file "/var/run/slim.lock")) (fork+exec-command - (list (string-append #$slim "/bin/slim") "-nodaemon") + (list (string-append #$(slim-configuration-slim config) + "/bin/slim") + "-nodaemon") #:environment-variables (list (string-append "SLIM_CFGFILE=" #$slim.cfg) #$@(if theme -- 2.21.0 --=-=-=-- ------------=_1556523182-588-1--