GNU bug report logs - #35456
[PATCH 0/1] Add 'guix install', 'guix remove', and 'guix upgrade'

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Sat, 27 Apr 2019 16:39:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Subject: bug#35456: closed (Re: [bug#35456] [PATCH 1/1] guix package: Add
 'install', 'remove', and 'upgrade' aliases.)
Date: Mon, 29 Apr 2019 08:23:03 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#35456: [PATCH 0/1] Add 'guix install', 'guix remove', and 'guix upgrade'

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 35456 <at> debbugs.gnu.org.

-- 
35456: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35456
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Ricardo Wurmus <rekado <at> elephly.net>,
 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: 35456-done <at> debbugs.gnu.org
Subject: Re: [bug#35456] [PATCH 1/1] guix package: Add 'install', 'remove',
 and 'upgrade' aliases.
Date: Mon, 29 Apr 2019 10:22:42 +0200
Hello!

Ludovic Courtès <ludo <at> gnu.org> skribis:

> Ricardo Wurmus <rekado <at> elephly.net> skribis:

[...]

>> I have to admit that I never use “--bootstrap”.  You already removed
>> many advanced options of “guix package” from this alias.  Would it make
>> sense to also remove this one?
>
> It’s used only for tests in fact, where we don’t want to rebuild the
> world just to run profile hooks.  Perhaps we could simply remove it from
> the ‘--help’ output, WDYT?

I did that and removed it altogether from ‘guix upgrade’ since there are
no tests using it.

I also updated the Bash completion.

Jonathan Brielmaier <jonathan.brielmaier <at> web.de> skribis:

> If you are so confident, go ahead and make me happy by adding at least
> 'guix search' :)

Heheh thanks.  :-)

It also occurred to me that ‘guix search’ would be logical as well,
since that’s, again, one of the first commands one runs.  I’ll send a
patch for that and then I’ll stop here, I promise!

Ludo’.

[Message part 3 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH 0/1] Add 'guix install', 'guix remove', and 'guix upgrade'
Date: Sat, 27 Apr 2019 18:25:00 +0200
Hello Guix!

Here’s a change that’s both trivial and anecdotal by its size and
complexity, and super important after 7 years typing ‘guix package -i’
when every other tool out there has an ‘install’ sub-command.  :-)

The main question is how we are going to present it when we introduce
people to Guix.  In the manual I listed the aliases and changed
several instances of ‘guix package -i’ to ‘guix install’.  To me,
‘guix package’ remains unavoidable, but having ‘guix install’ in
particular is important to help newcomers get started quickly.

Technically, the aliases are not dumb: you cannot do, say,
‘guix install -r foo’ to remove a package.  There’s little code
duplication beyond ‘show-help’ and the license header.

Thoughts?  Rejection?  Happiness?  :-)

Thanks,
Ludo’.

Ludovic Courtès (1):
  guix package: Add 'install', 'remove', and 'upgrade' aliases.

 Makefile.am                   |  4 ++
 doc/guix.texi                 | 39 ++++++++++-----
 guix/scripts/install.scm      | 81 +++++++++++++++++++++++++++++++
 guix/scripts/package.scm      | 11 ++++-
 guix/scripts/remove.scm       | 78 ++++++++++++++++++++++++++++++
 guix/scripts/upgrade.scm      | 90 +++++++++++++++++++++++++++++++++++
 po/guix/POTFILES.in           |  3 ++
 tests/guix-package-aliases.sh | 58 ++++++++++++++++++++++
 8 files changed, 352 insertions(+), 12 deletions(-)
 create mode 100644 guix/scripts/install.scm
 create mode 100644 guix/scripts/remove.scm
 create mode 100644 guix/scripts/upgrade.scm
 create mode 100644 tests/guix-package-aliases.sh

-- 
2.21.0




This bug report was last modified 6 years and 19 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.