From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 27 12:11:25 2019 Received: (at submit) by debbugs.gnu.org; 27 Apr 2019 16:11:25 +0000 Received: from localhost ([127.0.0.1]:35818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKPvB-00073p-Ag for submit@debbugs.gnu.org; Sat, 27 Apr 2019 12:11:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKPv6-00073K-Kh for submit@debbugs.gnu.org; Sat, 27 Apr 2019 12:11:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:41207) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hKPv0-0006Sj-NZ for submit@debbugs.gnu.org; Sat, 27 Apr 2019 12:11:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKPuy-0003F5-Tp for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 12:11:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKPha-0002gs-Fu for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 11:57:24 -0400 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:44905) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hKPhY-0002Yu-RU for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 11:57:22 -0400 Received: by mail-lj1-x22d.google.com with SMTP id h16so5565043ljg.11 for ; Sat, 27 Apr 2019 08:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=xymZtn0cZRsHFFqMjkZJ5Jb1Wim3qn/jLKExJmPP/RE=; b=PuszW7O6DScjWdH2oNkSi+FOea+NPS84+2gElJMwnGsx27L/zD9DGOVoBE7foVkjY9 JaFnuptfdOtixChjtrag23XZ606B7Nqf539QCBPSzWwTp5HbcceApoe7714tdOm+KZwo qK5WfmvMKc8ltirNIC6s6FUESO+mCyELLc7rorwhFjjaM4QRTxOWuLDzbRDes+5+847e bC3hmIiH7kfXsKRixnxLuT7s5cuVGUdFKd8DYNWwVeN3l185OHse+4o90TY65yixbBsj /47lnHG58aavTG8uSGHwAMR8seu6vMo/u1SQQAq9qnrjPtviNDiTm0R4EWDgFqYc1wcF 7Ecg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=xymZtn0cZRsHFFqMjkZJ5Jb1Wim3qn/jLKExJmPP/RE=; b=t4pI2aA3WH/o2LtCsOQkwbPbEcDc9U89Pv5mWxArBRgGrPrUw/Mdo4iwGE/QI1rmZu f2E2Hpb7cZl3Jso3ipTBGUFId4CwVTO3yZAKEhJFvhSm34ouMiI7afR9bqU0WmVwa2cm dEOWNoJ/whdgCOq3jejcZXzOvd/9XxeBt8KkMkaST3PEhge8QQDwq4JxlszNRWIef38Y 8v6sSoSruGkVsMunji2xcQz65HhGjRZiS5Nq7Ek4BJ1Rnf+pFrG6vBLsM6+lO0CiCm7B rRAGmQoTU8LROR3bi04hCZsl+jBEspXuvjfhtExFYsfKCbA2fIvgIbAgNXGUSlhK8LHh bjsA== X-Gm-Message-State: APjAAAXVgg7+GZgf6R5NvNmYMTRvO2RzuMGkA2ocYYVTX7iG6CC3b0rV zKwo4Qn8rGgE61mZCAo9z+k3wKsDetymd1hAmyoQ3fbhb2M= X-Google-Smtp-Source: APXvYqxMUSTWCCKCedFAMueiWwl5YTqj00/5L8Lkz3x2RsAb23o+K/LQBN9bJuC8MxY6tzJESvcwL+4DDhJ05tB3RGs= X-Received: by 2002:a2e:5b5c:: with SMTP id p89mr27372083ljb.177.1556380637873; Sat, 27 Apr 2019 08:57:17 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Sat, 27 Apr 2019 12:57:05 -0300 Message-ID: Subject: 26.2.50; CC-Mode fontification fails inside macro To: bug-gnu-emacs Content-Type: multipart/alternative; boundary="0000000000000e4be40587851b0d" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::22d X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000000e4be40587851b0d Content-Type: text/plain; charset="UTF-8" Hello. Steps to reproduce: 1) emacs -Q 2) Open up a new .c file: C-x C-f test.c 3) Type this text: #define FOO \ /* Some comms. */ \ struct foobar my_foo; \ struct foobar my_bar; The first struct foobar after the comment is not fontified as the second one. That is, the second foobar has face font-lock-type-face, and my_bar has face font-lock-variable-name-face, but the first foobar and my_foo don't get those face values. I actually bumped into this issue while visiting the emacs source file src/editfns.c. In that file, search for "#define EXTRA_CONTEXT_FIELDS" and the problem should be evident. I can reproduce it with the latest Emacs 26, as well as with the latest master: Repository revision: 8dc00b2f1e6523c634df3e24379afbe712a32b27 Repository branch: master Best regards, Mauro. In GNU Emacs 26.2.50 (build 1, i686-pc-linux-gnu, GTK+ Version 3.18.9) of 2019-04-23 built on the-blackbeard Repository revision: 9ec18fbd560526ab19c6171aff15995d1307233e Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Ubuntu 16.04.6 LTS Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. (New file) Auto-saving...done Quit Making completion list... Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS LCMS2 Important settings: value of $LANG: en_US.utf8 value of $XMODIFIERS: locale-coding-system: utf-8-unix Major mode: C/*l Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cc-mode cc-fonts easymenu cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs cl-loaddefs cl-lib elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 8 115795 11061) (symbols 24 22635 1) (miscs 20 58 184) (strings 16 34126 1595) (string-bytes 1 1031562) (vectors 12 17262) (vector-slots 4 561150 8896) (floats 8 51 121) (intervals 28 306 68) (buffers 536 13) (heap 1024 38012 1009)) --0000000000000e4be40587851b0d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello.

Steps to reproduce:
1) e= macs -Q
2) Open up a new .c file:
C-x C-f test.c
3) Type this text= :
#define FOO=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 \
=C2=A0 /* Some c= omms.=C2=A0 */ =C2=A0=C2=A0=C2=A0 \
=C2=A0 struct foobar my_foo; \
= =C2=A0 struct foobar my_bar;

The first struct foobar after the comme= nt is not fontified as the second
one.=C2=A0 That is, the second foobar = has face font-lock-type-face, and
my_bar has face font-lock-variable-nam= e-face, but the first foobar and
my_foo don't get those face values.=

I actually bumped into this issue while visiting the emacs source f= ile
src/editfns.c.=C2=A0 In that file, search for "#define EXTRA_CO= NTEXT_FIELDS"
and the problem should be evident.

I can repro= duce it with the latest Emacs 26, as well as with the latest
master:
= Repository revision: 8dc00b2f1e6523c634df3e24379afbe712a32b27
Repository= branch: master

Best regards,
Mauro.


In GNU Emacs 26.2= .50 (build 1, i686-pc-linux-gnu, GTK+ Version 3.18.9)
=C2=A0of 2019-04-2= 3 built on the-blackbeard
Repository revision: 9ec18fbd560526ab19c6171af= f15995d1307233e
Windowing system distributor 'The X.Org Foundation&#= 39;, version 11.0.11906000
System Description:=C2=A0=C2=A0=C2=A0 Ubuntu = 16.04.6 LTS

Recent messages:
For information about GNU Emacs and = the GNU system, type C-h C-a.
(New file)
Auto-saving...done
QuitMaking completion list...

Configured features:
XPM JPEG TIFF GI= F PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB
NOTIFY ACL LIBSELIN= UX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS = GTK3 X11 XDBE XIM THREADS LCMS2

Important settings:
=C2=A0 value = of $LANG: en_US.utf8
=C2=A0 value of $XMODIFIERS:
=C2=A0 locale-codi= ng-system: utf-8-unix

Major mode: C/*l

Minor modes in effect:=
=C2=A0 tooltip-mode: t
=C2=A0 global-eldoc-mode: t
=C2=A0 electri= c-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 tool-bar-mode: t=C2=A0 menu-bar-mode: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 glob= al-font-lock-mode: t
=C2=A0 font-lock-mode: t
=C2=A0 blink-cursor-mod= e: t
=C2=A0 auto-composition-mode: t
=C2=A0 auto-encryption-mode: t=C2=A0 auto-compression-mode: t
=C2=A0 line-number-mode: t
=C2=A0 t= ransient-mark-mode: t
=C2=A0 abbrev-mode: t

Load-path shadows:None found.

Features:
(shadow sort mail-extr emacsbug message rm= c puny seq byte-opt gv
bytecomp byte-compile cconv dired dired-loaddefs = format-spec rfc822 mml
mml-sec password-cache epa derived epg epg-config= gnus-util rmail
rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse= rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-d= rums
mm-util mail-prsvr mail-utils cc-mode cc-fonts easymenu cc-guesscc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs
cl-loadde= fs cl-lib elec-pair time-date mule-util tooltip eldoc electric
uniquify = ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-= win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list re= place newcomment text-mode elisp-mode lisp-mode
prog-mode register page = menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font= -lock syntax facemenu font-core
term/tty-colors frame cl-generic cham ge= orgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean = japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european et= hiopic indian cyrillic
chinese composite charscript charprop case-table = epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloade= d nadvice loaddefs
button faces cus-face macroexp files text-properties = overlay sha1 md5
base64 format env code-pages mule custom widget hashtab= le-print-readable
backquote threads dbusbind inotify lcms2 dynamic-setti= ng
system-font-setting font-render-setting move-toolbar gtk x-toolkit x<= br>multi-tty make-network-process emacs)

Memory information:
((co= nses 8 115795 11061)
=C2=A0(symbols 24 22635 1)
=C2=A0(miscs 20 58 18= 4)
=C2=A0(strings 16 34126 1595)
=C2=A0(string-bytes 1 1031562)
= =C2=A0(vectors 12 17262)
=C2=A0(vector-slots 4 561150 8896)
=C2=A0(fl= oats 8 51 121)
=C2=A0(intervals 28 306 68)
=C2=A0(buffers 536 13)
= =C2=A0(heap 1024 38012 1009))

--0000000000000e4be40587851b0d-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 27 16:36:57 2019 Received: (at 35454) by debbugs.gnu.org; 27 Apr 2019 20:36:57 +0000 Received: from localhost ([127.0.0.1]:36098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKU48-0003Vh-Qc for submit@debbugs.gnu.org; Sat, 27 Apr 2019 16:36:57 -0400 Received: from colin.muc.de ([193.149.48.1]:28509 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hKU46-0003VT-6D for 35454@debbugs.gnu.org; Sat, 27 Apr 2019 16:36:54 -0400 Received: (qmail 57598 invoked by uid 3782); 27 Apr 2019 20:36:48 -0000 Received: from acm.muc.de (p4FE15039.dip0.t-ipconnect.de [79.225.80.57]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 27 Apr 2019 22:36:47 +0200 Received: (qmail 11159 invoked by uid 1000); 27 Apr 2019 20:36:46 -0000 Date: Sat, 27 Apr 2019 20:36:46 +0000 To: Mauro Aranda Subject: Re: bug#35454: 26.2.50; CC-Mode fontification fails inside macro Message-ID: <20190427203646.GA11087@ACM> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35454 Cc: 35454@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Mauro. On Sat, Apr 27, 2019 at 12:57:05 -0300, Mauro Aranda wrote: > Hello. > Steps to reproduce: > 1) emacs -Q > 2) Open up a new .c file: > C-x C-f test.c > 3) Type this text: > #define FOO \ > /* Some comms. */ \ > struct foobar my_foo; \ > struct foobar my_bar; > The first struct foobar after the comment is not fontified as the second > one. That is, the second foobar has face font-lock-type-face, and > my_bar has face font-lock-variable-name-face, but the first foobar and > my_foo don't get those face values. > I actually bumped into this issue while visiting the emacs source file > src/editfns.c. In that file, search for "#define EXTRA_CONTEXT_FIELDS" > and the problem should be evident. Thanks! I can reproduce this easily, and will look into it in the next day or two. Of interest is the fact that if FOO is given an empty argument list (i.e. one writes #define FOO() \ ... ), the bug doesn't happen. > I can reproduce it with the latest Emacs 26, as well as with the latest > master: > Repository revision: 8dc00b2f1e6523c634df3e24379afbe712a32b27 > Repository branch: master > Best regards, > Mauro. [ .... ] -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed May 01 17:02:38 2019 Received: (at 35454) by debbugs.gnu.org; 1 May 2019 21:02:38 +0000 Received: from localhost ([127.0.0.1]:45049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLwNB-00014i-Tj for submit@debbugs.gnu.org; Wed, 01 May 2019 17:02:38 -0400 Received: from colin.muc.de ([193.149.48.1]:48875 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hLwN8-00014V-BV for 35454@debbugs.gnu.org; Wed, 01 May 2019 17:02:35 -0400 Received: (qmail 26139 invoked by uid 3782); 1 May 2019 21:02:31 -0000 Received: from acm.muc.de (p4FE15FD7.dip0.t-ipconnect.de [79.225.95.215]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 01 May 2019 23:02:30 +0200 Received: (qmail 7161 invoked by uid 1000); 1 May 2019 21:02:30 -0000 Date: Wed, 1 May 2019 21:02:30 +0000 To: Mauro Aranda Subject: Re: bug#35454: 26.2.50; CC-Mode fontification fails inside macro Message-ID: <20190501210230.GA3999@ACM> References: <20190427203646.GA11087@ACM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190427203646.GA11087@ACM> User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35454 Cc: 35454@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello again, Mauro. On Sat, Apr 27, 2019 at 20:36:46 +0000, Alan Mackenzie wrote: > On Sat, Apr 27, 2019 at 12:57:05 -0300, Mauro Aranda wrote: > > Hello. > > Steps to reproduce: > > 1) emacs -Q > > 2) Open up a new .c file: > > C-x C-f test.c > > 3) Type this text: > > #define FOO \ > > /* Some comms. */ \ > > struct foobar my_foo; \ > > struct foobar my_bar; > > The first struct foobar after the comment is not fontified as the second > > one. That is, the second foobar has face font-lock-type-face, and > > my_bar has face font-lock-variable-name-face, but the first foobar and > > my_foo don't get those face values. > > I actually bumped into this issue while visiting the emacs source file > > src/editfns.c. In that file, search for "#define EXTRA_CONTEXT_FIELDS" > > and the problem should be evident. > Thanks! I can reproduce this easily, and will look into it in the next > day or two. Please try out the patch below. On my system, it corrects the fontification in both your test file and editfns.c. > Of interest is the fact that if FOO is given an empty argument list > (i.e. one writes > #define FOO() \ > ... > ), the bug doesn't happen. > > I can reproduce it with the latest Emacs 26, as well as with the latest > > master: > > Repository revision: 8dc00b2f1e6523c634df3e24379afbe712a32b27 > > Repository branch: master diff -r 9d58d1e3ab27 cc-engine.el --- a/cc-engine.el Sat Apr 27 17:07:23 2019 +0000 +++ b/cc-engine.el Wed May 01 20:46:40 2019 +0000 @@ -5668,7 +5668,10 @@ (setq cfd-re-match cfd-limit) nil) ((c-got-face-at - (if (setq cfd-re-match (match-end 1)) + (if (setq cfd-re-match + (or (match-end 1) + (and c-dposr-cpp-macro-depth + (match-end (1+ c-dposr-cpp-macro-depth))))) ;; Matched the end of a token preceding a decl spot. (progn (goto-char cfd-re-match) @@ -5679,15 +5682,19 @@ c-literal-faces) ;; Pseudo match inside a comment or string literal. Skip out ;; of comments and string literals. - (while (progn - (unless - (and (match-end 1) - (c-got-face-at (1- (point)) c-literal-faces) - (not (c-got-face-at (point) c-literal-faces))) - (goto-char (c-next-single-property-change - (point) 'face nil cfd-limit))) - (and (< (point) cfd-limit) - (c-got-face-at (point) c-literal-faces)))) + (while + (progn + (unless + (and + (or (match-end 1) + (and c-dposr-cpp-macro-depth + (match-end (1+ c-dposr-cpp-macro-depth)))) + (c-got-face-at (1- (point)) c-literal-faces) + (not (c-got-face-at (point) c-literal-faces))) + (goto-char (c-next-single-property-change + (point) 'face nil cfd-limit))) + (and (< (point) cfd-limit) + (c-got-face-at (point) c-literal-faces)))) t) ; Continue the loop over pseudo matches. ((and c-opt-identifier-concat-key (match-string 1) diff -r 9d58d1e3ab27 cc-langs.el --- a/cc-langs.el Sat Apr 27 17:07:23 2019 +0000 +++ b/cc-langs.el Wed May 01 20:46:40 2019 +0000 @@ -964,6 +964,14 @@ (c-lang-defvar c-opt-cpp-macro-define-id (c-lang-const c-opt-cpp-macro-define-id)) +(c-lang-defconst c-anchored-hash-define-no-parens + ;; Regexp matching everything up to the end of a cpp define which has no + ;; argument parentheses. Or nil in languages which don't have them. + t (if (c-lang-const c-opt-cpp-macro-define) + (concat (c-lang-const c-anchored-cpp-prefix) + (c-lang-const c-opt-cpp-macro-define) + "[ \t]+\\(\\sw\\|_\\)+\\([^(a-zA-Z0-9_]\\|$\\)"))) + (c-lang-defconst c-cpp-expr-directives "List of cpp directives (without the prefix) that are followed by an expression." @@ -1578,7 +1586,7 @@ t (concat (c-lang-const c-comment-start-regexp) "\\|" (if (memq 'gen-string-delim c-emacs-features) - "\"|" + "\"\\|\\s|" "\""))) (c-lang-defvar c-literal-start-regexp (c-lang-const c-literal-start-regexp)) @@ -3152,24 +3160,40 @@ ;; token that might precede such a construct, e.g. ';', '}' or '{'. ;; It's built from `c-decl-prefix-re'. ;; - ;; If the first submatch did not match, the match of the whole - ;; regexp is taken to be at the first token in the declaration. - ;; `c-decl-start-re' is not checked in this case. + ;; If the first submatch did not match, we have either a #define construct + ;; without parentheses or the match of the whole regexp is taken to be at + ;; the first token in the declaration. `c-decl-start-re' is not checked in + ;; these cases. ;; ;; Design note: The reason the same regexp is used to match both ;; tokens that precede declarations and start them is to avoid an ;; extra regexp search from the previous declaration spot in ;; `c-find-decl-spots'. Users of `c-find-decl-spots' also count on - ;; that it finds all declaration/cast/label starts in approximately + ;; it finding all declaration/cast/label starts in approximately ;; linear order, so we can't do the searches in two separate passes. - t (if (c-lang-const c-decl-start-kwds) - (concat (c-lang-const c-decl-prefix-re) - "\\|" - (c-make-keywords-re t (c-lang-const c-decl-start-kwds))) - (c-lang-const c-decl-prefix-re))) + t (cond + ((and (c-lang-const c-decl-start-kwds) + (c-lang-const c-anchored-hash-define-no-parens)) + (concat (c-lang-const c-decl-prefix-re) + "\\|" (c-lang-const c-anchored-hash-define-no-parens) + "\\|" (c-make-keywords-re t (c-lang-const c-decl-start-kwds)))) + ((c-lang-const c-decl-start-kwds) + (concat (c-lang-const c-decl-prefix-re) + "\\|" (c-make-keywords-re t (c-lang-const c-decl-start-kwds)))) + ((c-lang-const c-anchored-hash-define-no-parens) + (concat (c-lang-const c-decl-prefix-re) + "\\|" (c-lang-const c-anchored-hash-define-no-parens))) + (t (c-lang-const c-decl-prefix-re)))) (c-lang-defvar c-decl-prefix-or-start-re (c-lang-const c-decl-prefix-or-start-re)) +(c-lang-defconst c-dposr-cpp-macro-depth + ;; The match number of `c-anchored-hash-define-no-parens''s first match + ;; within `c-decl-prefix-or-start-re', or nil if there is no such component. + t (if (c-lang-const c-anchored-hash-define-no-parens) + (1+ (regexp-opt-depth (c-lang-const c-decl-prefix-re))))) +(c-lang-defvar c-dposr-cpp-macro-depth (c-lang-const c-dposr-cpp-macro-depth)) + (c-lang-defconst c-cast-parens ;; List containing the paren characters that can open a cast, or nil in ;; languages without casts. > > Best regards, > > Mauro. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed May 01 18:32:11 2019 Received: (at 35454) by debbugs.gnu.org; 1 May 2019 22:32:11 +0000 Received: from localhost ([127.0.0.1]:45142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLxlr-0003CP-1v for submit@debbugs.gnu.org; Wed, 01 May 2019 18:32:11 -0400 Received: from mail-lj1-f178.google.com ([209.85.208.178]:46009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLxln-0003Bs-5B for 35454@debbugs.gnu.org; Wed, 01 May 2019 18:32:09 -0400 Received: by mail-lj1-f178.google.com with SMTP id w12so371720ljh.12 for <35454@debbugs.gnu.org>; Wed, 01 May 2019 15:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rxBZILXaOOlFV0l+XJ1bZIYcftDy6Cofeu9NOfX5cfw=; b=nSVgxCKCkKwOPD2mnIXw5/9dTn/AJ4Ty4KZ+8M8FBY4ZUxv4iwyOjCkKN+Mag+Aqod TxBHcx5neXzHq4II6FpTjq8+gULUKJisIWSOBYPFo/TLkgUYQ97MGGNpn6gSBruy6I9I jc7bzKVP30qByidSrngHruy4ztFbv1WZcztp+LJqc0xeSJwZ5cF0UXOA289El8D+sQTj DeGkr0iERWPaFz/+ARHHfayaLevzCz+Flwexx760xY3OcB+RiUricXGEY87UHME+unPo ZdkBprlWQE6+DKO4Sv+nw9i74HY1+b3t2/S63j1abGeX9CDQ8DH5gv0RHtOshdJNeO4j GS4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rxBZILXaOOlFV0l+XJ1bZIYcftDy6Cofeu9NOfX5cfw=; b=gPvuyotTVppPfjqZwuRCvqVfgQhi1GNTk4u7anfpNVjIFTUZzu3R48qidMaYky+rvc A+ZnxaVs9rxvQ9P+9Gof2R5GEUsnXZ+qRCIjozr8yQhOU0HqzBdbUjUiEJxkTlmB5zsJ hN4GILjeD9RNRSyMeM0V0aig5hKuQ/gOiCF0Mrpo4Bfyd6fGdCBIadgCyHdWGk33Uc3b 3l9K1B7/y1mXVkMHP6UnzP+ArmkTChUZEaJFcEvNkrqAiYFii2kZXN72zLuk6V0ZSxmV 9btPPyaID4rR0JJQweLH/l+NefHr4eE1P1eMz3RWjQhd1m+rnGiRLSsUjlQDLSVfSD2+ op3Q== X-Gm-Message-State: APjAAAVh+0MjkmMThwc5STaDBGi4aOoHKJpEPh1NiVC+vUTLjqmVD6vr 911Zp2WEF3X/pQN1FFTRmBzNuMayE8oRBAXlxLo= X-Google-Smtp-Source: APXvYqxLvRDFTry2LJQkqtvEa99KAajqmaLZMT5LwULgby11WFMZugZ4UN2pAHjJaEpVnKjjHIj0SW0ZSJ86i0CVwZE= X-Received: by 2002:a2e:96d9:: with SMTP id d25mr46852ljj.78.1556749921016; Wed, 01 May 2019 15:32:01 -0700 (PDT) MIME-Version: 1.0 References: <20190427203646.GA11087@ACM> <20190501210230.GA3999@ACM> In-Reply-To: <20190501210230.GA3999@ACM> From: Mauro Aranda Date: Wed, 1 May 2019 19:31:48 -0300 Message-ID: Subject: Re: bug#35454: 26.2.50; CC-Mode fontification fails inside macro To: Alan Mackenzie Content-Type: multipart/alternative; boundary="0000000000000be2280587db16b3" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35454 Cc: 35454@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000be2280587db16b3 Content-Type: text/plain; charset="UTF-8" Alan Mackenzie writes: > Hello again, Mauro. Hello Alan. Thanks for looking into this bug! > Please try out the patch below. On my system, it corrects the > fontification in both your test file and editfns.c. I've applied the patch and tried the recipe I provided, and it works fine. However, when I visit editfns.c and search for EXTRA_CONTEXT_FIELDS, like I said in my report, I see the following problem with this variables: struct buffer *buffer_a; struct buffer *buffer_b; unsigned char *deletions; unsigned char *insertions; All but deletions have face font-lock-variable-name-face. I can't seem to come up with a simple recipe to reproduce the problem, so I refer you to that part of editfns.c. All the following steps, separately with emacs -Q (or you could kill the buffer if you want) 1) C-x C-f editfns.c C-s extra RET I observe deletions without its correspondent face and if I type: SPC DEL deletions gets font-lock-variable-name-face face. However, if I revert the buffer with M-x revert-buffer RET yes RET buffer_a, deletions and the first 'buffer' lose their faces. 2) C-x C-f editfns.c C-s deletions RET I see that deletions has the right face. But M-x revert-buffer makes it lose it (but *buffer_a keeps its face). 3) C-x C-f editfns.c C-s extra RET deletions without font-lock-variable-name-face. C-l C-l M-x revert-buffer deletions now has font-lock-variable-name-face. That is all the testing I could do, sorry for not being able to come up with a better recipe. Let me know if you see the same behavior, or what else I could try. Best regards, Mauro. --0000000000000be2280587db16b3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Alan Mackenzie <acm@muc.de> writes:

> Hello again, Mauro.

H= ello Alan.=C2=A0 Thanks for looking into this bug!

> Please try o= ut the patch below.=C2=A0 On my system, it corrects the
> fontificati= on in both your test file and editfns.c.

I've applied the patch = and tried the recipe I provided, and it works fine.

However, when I = visit editfns.c and search for EXTRA_CONTEXT_FIELDS,
like I said in my r= eport, I see the following problem with this variables:
struct buffer *buffer_a;
struct buffer *buffer_b;
unsigned char *d= eletions;
unsigned char *insertions;

All but deletions have face = font-lock-variable-name-face.

I can't seem to come up with a sim= ple recipe to reproduce the problem,
so I refer you to that part of edit= fns.c.

All the following steps, separately with emacs -Q (or you cou= ld kill the
buffer if you want)
1) C-x C-f editfns.c
C-s extra RET
I observe deletions without its c= orrespondent face and if I type:
SPC DEL
deletions gets font-lock-var= iable-name-face face.=C2=A0 However, if I
revert the buffer with M-x rev= ert-buffer RET yes RET buffer_a, deletions
and the first 'buffer'= ; lose their faces.

2) C-x C-f editfns.c
C-s deletions RET
I s= ee that deletions has the right face.=C2=A0 But
M-x revert-buffer
mak= es it lose it (but *buffer_a keeps its face).

3) C-x C-f editfns.cC-s extra RET
deletions without font-lock-variable-name-face.
C-l C= -l
M-x revert-buffer
deletions now has font-lock-variable-name-face.<= br>
That is all the testing I could do, sorry for not being able to come= up
with a better recipe.=C2=A0 Let me know if you see the same behavior= , or what
else I could try.

Best regards,
Mauro.
--0000000000000be2280587db16b3-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 02 04:57:21 2019 Received: (at 35454) by debbugs.gnu.org; 2 May 2019 08:57:21 +0000 Received: from localhost ([127.0.0.1]:45564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hM7Wr-0001FD-0y for submit@debbugs.gnu.org; Thu, 02 May 2019 04:57:21 -0400 Received: from colin.muc.de ([193.149.48.1]:56091 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hM7Wo-0001F2-EL for 35454@debbugs.gnu.org; Thu, 02 May 2019 04:57:19 -0400 Received: (qmail 54821 invoked by uid 3782); 2 May 2019 08:57:15 -0000 Received: from acm.muc.de (p4FE15E7B.dip0.t-ipconnect.de [79.225.94.123]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 02 May 2019 10:57:14 +0200 Received: (qmail 4536 invoked by uid 1000); 2 May 2019 08:57:14 -0000 Date: Thu, 2 May 2019 08:57:14 +0000 To: Mauro Aranda Subject: Re: bug#35454: 26.2.50; CC-Mode fontification fails inside macro Message-ID: <20190502085714.GA4277@ACM> References: <20190427203646.GA11087@ACM> <20190501210230.GA3999@ACM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35454 Cc: 35454@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Mauro. On Wed, May 01, 2019 at 19:31:48 -0300, Mauro Aranda wrote: > Alan Mackenzie writes: > Hello Alan. Thanks for looking into this bug! > > Please try out the patch below. On my system, it corrects the > > fontification in both your test file and editfns.c. > I've applied the patch and tried the recipe I provided, and it works fine. > However, when I visit editfns.c and search for EXTRA_CONTEXT_FIELDS, > like I said in my report, I see the following problem with this variables: > struct buffer *buffer_a; > struct buffer *buffer_b; > unsigned char *deletions; > unsigned char *insertions; > All but deletions have face font-lock-variable-name-face. > I can't seem to come up with a simple recipe to reproduce the problem, > so I refer you to that part of editfns.c. Thanks, I didn't notice these last night, but I can see them now. > All the following steps, separately with emacs -Q (or you could kill the > buffer if you want) > 1) C-x C-f editfns.c > C-s extra RET > I observe deletions without its correspondent face and if I type: > SPC DEL > deletions gets font-lock-variable-name-face face. However, if I > revert the buffer with M-x revert-buffer RET yes RET buffer_a, deletions > and the first 'buffer' lose their faces. The problem with "deletions" seems to be triggered by the 2-line comment in the macro not having a backslash escaping the \n. In nearly 30 years hacking C, I've never seen this before, and didn't even know it was valid syntax. However, this means at least four very commonly used functions (c-beginning-of-macro, c-end-of-macro, c-forward-sws, and c-backward-sws) are going to have to be amended to deal with it, and this is inevitably going to make CC Mode slower. :-( I can't see at the moment any pattern with the fontification on buffer_a. Sometimes just scrolling the buffer a few lines makes buffer_a lose its fontification. But if an empty pair of parentheses is put after EXTRA_CONTEXT_FIELDS, all these problems go away. So they seem related to what I half-fixed last night. > 2) C-x C-f editfns.c > C-s deletions RET > I see that deletions has the right face. But > M-x revert-buffer > makes it lose it (but *buffer_a keeps its face). > 3) C-x C-f editfns.c > C-s extra RET > deletions without font-lock-variable-name-face. > C-l C-l > M-x revert-buffer > deletions now has font-lock-variable-name-face. > That is all the testing I could do, sorry for not being able to come up > with a better recipe. Let me know if you see the same behavior, or what > else I could try. Well, that seems like quite a lot of testing to me. :-) Thanks for doing it and reporting back to me so quickly. I'll be working on the outstanding bugs here in the next few days. > Best regards, > Mauro. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu May 02 10:42:28 2019 Received: (at 35454) by debbugs.gnu.org; 2 May 2019 14:42:28 +0000 Received: from localhost ([127.0.0.1]:46698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMCuq-0003Cz-6O for submit@debbugs.gnu.org; Thu, 02 May 2019 10:42:28 -0400 Received: from colin.muc.de ([193.149.48.1]:60299 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hMCuo-0003Cr-VQ for 35454@debbugs.gnu.org; Thu, 02 May 2019 10:42:27 -0400 Received: (qmail 65177 invoked by uid 3782); 2 May 2019 14:42:25 -0000 Received: from acm.muc.de (p4FE15E7B.dip0.t-ipconnect.de [79.225.94.123]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 02 May 2019 16:42:23 +0200 Received: (qmail 7047 invoked by uid 1000); 2 May 2019 14:42:23 -0000 Date: Thu, 2 May 2019 14:42:23 +0000 To: Mauro Aranda Subject: Re: bug#35454: 26.2.50; CC-Mode fontification fails inside macro Message-ID: <20190502144223.GB4277@ACM> References: <20190427203646.GA11087@ACM> <20190501210230.GA3999@ACM> <20190502085714.GA4277@ACM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190502085714.GA4277@ACM> User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35454 Cc: 35454@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello again, Mauro. On Thu, May 02, 2019 at 08:57:14 +0000, Alan Mackenzie wrote: > On Wed, May 01, 2019 at 19:31:48 -0300, Mauro Aranda wrote: > > Alan Mackenzie writes: > > I've applied the patch and tried the recipe I provided, and it works fine. > > However, when I visit editfns.c and search for EXTRA_CONTEXT_FIELDS, > > like I said in my report, I see the following problem with this variables: > > struct buffer *buffer_a; > > struct buffer *buffer_b; > > unsigned char *deletions; > > unsigned char *insertions; > > All but deletions have face font-lock-variable-name-face. [ .... ] > The problem with "deletions" seems to be triggered by the 2-line comment > in the macro not having a backslash escaping the \n. In nearly 30 years > hacking C, I've never seen this before, and didn't even know it was > valid syntax. However, this means at least four very commonly used > functions (c-beginning-of-macro, c-end-of-macro, c-forward-sws, and > c-backward-sws) are going to have to be amended to deal with it, and > this is inevitably going to make CC Mode slower. :-( I've just committed a fix to multiline comments in macros not having escaped newlines. This seems to solve the problem with the variable "deletions". That should be half the battle won. As usual, please feel free to test it for me. In the end, it didn't make CC Mode more than around 0.5% slower. I haven't yet tried combining yesterday's patch with the fix I've just committed, but if we're lucky, the two together might solve the entire bug. [ .... ] > > Best regards, > > Mauro. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu May 02 17:03:18 2019 Received: (at 35454) by debbugs.gnu.org; 2 May 2019 21:03:18 +0000 Received: from localhost ([127.0.0.1]:47138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMIrO-0008U4-G0 for submit@debbugs.gnu.org; Thu, 02 May 2019 17:03:18 -0400 Received: from colin.muc.de ([193.149.48.1]:64845 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hMIrM-0008Tv-Ro for 35454@debbugs.gnu.org; Thu, 02 May 2019 17:03:17 -0400 Received: (qmail 737 invoked by uid 3782); 2 May 2019 21:03:13 -0000 Received: from acm.muc.de (p4FE15E7B.dip0.t-ipconnect.de [79.225.94.123]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 02 May 2019 23:03:12 +0200 Received: (qmail 9777 invoked by uid 1000); 2 May 2019 21:03:12 -0000 Date: Thu, 2 May 2019 21:03:12 +0000 To: Mauro Aranda Subject: Re: bug#35454: 26.2.50; CC-Mode fontification fails inside macro Message-ID: <20190502210312.GC4277@ACM> References: <20190427203646.GA11087@ACM> <20190501210230.GA3999@ACM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35454 Cc: 35454@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Mauro. On Wed, May 01, 2019 at 19:31:48 -0300, Mauro Aranda wrote: > Alan Mackenzie writes: > > Hello again, Mauro. > Hello Alan. Thanks for looking into this bug! > > Please try out the patch below. On my system, it corrects the > > fontification in both your test file and editfns.c. > I've applied the patch and tried the recipe I provided, and it works fine. > However, when I visit editfns.c and search for EXTRA_CONTEXT_FIELDS, > like I said in my report, I see the following problem with this variables: > struct buffer *buffer_a; > struct buffer *buffer_b; > unsigned char *deletions; > unsigned char *insertions; > All but deletions have face font-lock-variable-name-face. > I can't seem to come up with a simple recipe to reproduce the problem, > so I refer you to that part of editfns.c. > All the following steps, separately with emacs -Q (or you could kill the > buffer if you want) > 1) C-x C-f editfns.c > C-s extra RET > I observe deletions without its correspondent face and if I type: > SPC DEL > deletions gets font-lock-variable-name-face face. However, if I > revert the buffer with M-x revert-buffer RET yes RET buffer_a, deletions > and the first 'buffer' lose their faces. > 2) C-x C-f editfns.c > C-s deletions RET > I see that deletions has the right face. But > M-x revert-buffer > makes it lose it (but *buffer_a keeps its face). > 3) C-x C-f editfns.c > C-s extra RET > deletions without font-lock-variable-name-face. > C-l C-l > M-x revert-buffer > deletions now has font-lock-variable-name-face. > That is all the testing I could do, sorry for not being able to come up > with a better recipe. Let me know if you see the same behavior, or what > else I could try. I believe I have now fixed all these bugs, and indeed I've committed the fix to the master branch. Would you please be so good as to give this fix a "final" test, and if everything is OK, then I can close the bug. Thanks! > Best regards, > Mauro. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu May 02 17:44:25 2019 Received: (at 35454) by debbugs.gnu.org; 2 May 2019 21:44:25 +0000 Received: from localhost ([127.0.0.1]:47188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMJVA-00010B-Rx for submit@debbugs.gnu.org; Thu, 02 May 2019 17:44:25 -0400 Received: from mail-lj1-f169.google.com ([209.85.208.169]:37989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMJV8-0000zw-6s for 35454@debbugs.gnu.org; Thu, 02 May 2019 17:44:23 -0400 Received: by mail-lj1-f169.google.com with SMTP id e18so3594720lja.5 for <35454@debbugs.gnu.org>; Thu, 02 May 2019 14:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fVXbaHWzfPL7KCwMwBSFkF4tbxlEEO45HkUxoAT67q8=; b=Np/e8aM1Dh1EM3hcbUmpK1vZT5EKJATR5dHVPzXDCiQ0BjwJ3joFF640jlAAaRLwsn 6lE+BpA9h+BhERlIrivA5QDMqnuQcDJuF8xAgQ+uPeQb6G6TkmUbl0oeoJKYYTVWhFFI 1z1YtP7s27Ghsm0Wf03P2znD/q4FdTDERx10jJG8c5yVlfssu4hlePD3FfI7bF5t/b60 RaMFPl3zGU6Bx4jtenXtl4yzzSqFrbJS38sRq9OXudcUynH5N5e15FLsKH9fRn4E2jjM yja3hpZtNfclnjS3Pm+6Fl+MCwj86scNMwyvzgcz1z+qwxN53YUS+e4wWH3v0cngKWp3 IJHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fVXbaHWzfPL7KCwMwBSFkF4tbxlEEO45HkUxoAT67q8=; b=JvwrAk+M489L+wPyF04TRckkroXkITvoynaP3AglReU70M5Z93p/jodmdpYho932PJ 1ot88fPOL7SKY3f/lmJptdXxzuMHAzb8ZMl+VGTY66wHJt+VcvD1zp3e+klHZ/RIySIE qoqUrh7m39+PdlUoPgRccqHJbc5dGD4JfsuvgxdDA0355bYBLmTyH0fXeSzsQA6b9TRB AuHbqEDyWMq1LgVZ/vG0a4CIvSLk0MGMgKuR9wVvKtLG2tU+0p8LfxEoxQZdmcZJyAqa odyPY1qX2LJ5D+QC2f0GdC79DUBbxj0TK+yde6lXPr3MR6M8/ig0B/bY7LKDMc9lonua TGRA== X-Gm-Message-State: APjAAAXRlfoPem7CdrH6jfi9IwlkIi1HhTw+Jz85Sf0JjpWXNlA1d8Oh s9qNj34XCwxheTWKOKmWJQihb1GrRrX2enXfa7w= X-Google-Smtp-Source: APXvYqxHuMiWbTBEw+49uV5hjRMWa84omDLZrmEBN/cL3QBg0G6uEcHyb6Wn9EqicdaXLiCZYeIburKXi9L/E+dNUKo= X-Received: by 2002:a2e:1f02:: with SMTP id f2mr3169384ljf.86.1556833455700; Thu, 02 May 2019 14:44:15 -0700 (PDT) MIME-Version: 1.0 References: <20190427203646.GA11087@ACM> <20190501210230.GA3999@ACM> <20190502210312.GC4277@ACM> In-Reply-To: <20190502210312.GC4277@ACM> From: Mauro Aranda Date: Thu, 2 May 2019 18:44:02 -0300 Message-ID: Subject: Re: bug#35454: 26.2.50; CC-Mode fontification fails inside macro To: Alan Mackenzie Content-Type: multipart/alternative; boundary="0000000000001a01bd0587ee89ca" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35454 Cc: 35454@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000001a01bd0587ee89ca Content-Type: text/plain; charset="UTF-8" Alan Mackenzie writes: > Hello, Mauro. > I believe I have now fixed all these bugs, and indeed I've committed the > fix to the master branch. > > Would you please be so good as to give this fix a "final" test, and if > everything is OK, then I can close the bug. Hello Alan. I tried the fix, and it works great! All the problems I noticed are solved. Thank you. Best regards, Mauro. --0000000000001a01bd0587ee89ca Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Alan Mackenzie <acm@muc.de> writes:

> Hello, Mauro.
> I beli= eve I have now fixed all these bugs, and indeed I've committed the
&= gt; fix to the master branch.
>
> Would you please be so good a= s to give this fix a "final" test, and if
> everything is O= K, then I can close the bug.

Hello Alan.

I tried the fix, and= it works great!=C2=A0 All the problems I noticed are solved.

Thank = you.

Best regards,
Mauro.
--0000000000001a01bd0587ee89ca-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 03 03:41:24 2019 Received: (at 35454-done) by debbugs.gnu.org; 3 May 2019 07:41:24 +0000 Received: from localhost ([127.0.0.1]:47608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMSou-0000IF-67 for submit@debbugs.gnu.org; Fri, 03 May 2019 03:41:24 -0400 Received: from colin.muc.de ([193.149.48.1]:15771 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hMSor-0000I5-LY for 35454-done@debbugs.gnu.org; Fri, 03 May 2019 03:41:22 -0400 Received: (qmail 21097 invoked by uid 3782); 3 May 2019 07:41:19 -0000 Received: from acm.muc.de (p4FE15E6B.dip0.t-ipconnect.de [79.225.94.107]) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 03 May 2019 09:41:18 +0200 Received: (qmail 4252 invoked by uid 1000); 3 May 2019 07:41:18 -0000 Date: Fri, 3 May 2019 07:41:18 +0000 To: Mauro Aranda Subject: Re: bug#35454: 26.2.50; CC-Mode fontification fails inside macro Message-ID: <20190503074118.GA4036@ACM> References: <20190427203646.GA11087@ACM> <20190501210230.GA3999@ACM> <20190502210312.GC4277@ACM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35454-done Cc: 35454-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Mauro. On Thu, May 02, 2019 at 18:44:02 -0300, Mauro Aranda wrote: > Alan Mackenzie writes: > > I believe I have now fixed all these bugs, and indeed I've committed the > > fix to the master branch. > > Would you please be so good as to give this fix a "final" test, and if > > everything is OK, then I can close the bug. > Hello Alan. > I tried the fix, and it works great! All the problems I noticed are solved. > Thank you. That's great. I'm closing the bug. Thanks! > Best regards, > Mauro. -- Alan Mackenzie (Nuremberg, Germany). From unknown Tue Jun 17 22:20:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 31 May 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator