From unknown Sun Jun 22 00:58:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35445: 26.2; eww-follow-link breaks on the second invocation Resent-From: Xu Chunyang Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2019 07:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35445 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 35445@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155635143326545 (code B ref -1); Sat, 27 Apr 2019 07:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Apr 2019 07:50:33 +0000 Received: from localhost ([127.0.0.1]:34220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKI6S-0006u5-Ij for submit@debbugs.gnu.org; Sat, 27 Apr 2019 03:50:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKI6Q-0006tt-Fr for submit@debbugs.gnu.org; Sat, 27 Apr 2019 03:50:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:42145) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hKI6L-0000Sx-3X for submit@debbugs.gnu.org; Sat, 27 Apr 2019 03:50:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKI6J-0006Dk-U3 for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 03:50:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKHuv-0006Nk-Jk for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 03:38:38 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59305) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hKHuv-0006Jy-Ai for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 03:38:37 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 049E421EB2 for ; Sat, 27 Apr 2019 03:38:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sat, 27 Apr 2019 03:38:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xuchunyang.me; h=from:to:subject:date:message-id:mime-version:content-type; s= fm1; bh=0PZ7NkEOt7pguywjg+l6/KJTVYMuH4nfSuz2t6Zvv0w=; b=jCZwt0ul zHRmIgoykS/37yVCSjcZvBQTOFz7rrW57xMYZHF5ZSSdzzuXPXNKMXVvh4BBlv/K SvSh14OTw23B54yW0dBt9RSTajmLVSJ0Wk5RGaACMPK1N2oO8C3WE70VFo6vkGj7 ThrjhVhSamn/x0U9f6hVsrhG0BHXAYxbyecE/CXnHeySv7GUz+TUexUGG6A23usG aOYRBT+sYHgZOdAHm6560ctIhRgfAZ3dYCrN4V4hagwsRxaDOKB/9ZAQzqUbyniM x1lezXbzIlp4DqTHe+rPld7me4CWKuqhV2RBePRj9BZIApjWgljdAoQuoidZfBrL Zx4QQ7YNboLB+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=0PZ7NkEOt7pguywjg+l6/KJTVYMuH 4nfSuz2t6Zvv0w=; b=aq3RelfrgH+Xb8gWbG/AJeJ2Y3gyo7V7fjp3kUrokcDbp lPfiQAWuCweSHeyOLpPenoMoqB9UdY/AJ9hq8AC0iKmH3YLHEspC3MZDXjVRn9tG arEJZHF2p1kY7QcVuyoUegSsOQ/0w63IQEdUT3jZLMmjC/DLHm1TwQB2dwsGzB3x tMH1P2n6TAZDtsoJIF07b6qc3xO6xMog5l1tWjwZ7O9nbuyh3vBA2C/oSCtfFGtk n87aekCVsu45wUcIxwUCU5wEvlNY50CIdr0cAq4fhV+B6Dtd3Uq3+vAyjzSZHcpQ uqGxzURF384iRXX+hTSa6+UzTYSQkr3l9isW1S15A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrheejgdduvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkgggtsehttdertddttd dtnecuhfhrohhmpegiuhcuvehhuhhnhigrnhhguceomhgrihhlseiguhgthhhunhihrghn ghdrmhgvqeenucffohhmrghinhepphihthhhohhnrdhorhhgnecukfhppeduudejrdelfe drvddtjedrheeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghilhesgihutghhuhhn higrnhhgrdhmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from Chunyangs-MacBook-Air.local (unknown [117.93.207.58]) by mail.messagingengine.com (Postfix) with ESMTPA id 69E7B103C8 for ; Sat, 27 Apr 2019 03:38:33 -0400 (EDT) From: Xu Chunyang Date: Sat, 27 Apr 2019 15:38:30 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.27 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) I'm visiting https://docs.python.org/3/library/functions.html, I click the #abs link with RET (`eww-follow-link`), it works as expected, i.e., don't request the same page again but simply jump to #abs. However, when I click the same link again with RET, it will requests the page AGAIN, then jump to #abs. According to my observation, the eww-data's :url is missing after the first eww-follow-link invocation. eww-follow-link contains these two lines of code (eww-save-history) (eww-display-html 'utf-8 url dom nil (current-buffer)) the first line clears eww-data via (setq eww-data (list :title "")), but the second line forgets to (plist-put eww-data :url url). The following patch fixes the issue for me: diff -u --label /Users/xcy/src/emacs-mac/lisp/net/eww.el --label \#\ /Users/xcy/src/emacs-mac/lisp/net/eww.el /var/folders/7f/s191h4q97p90374yw15ssrs00000gn/T/buffer-content-hznRFC --- /Users/xcy/src/emacs-mac/lisp/net/eww.el +++ # @@ -1495,6 +1495,7 @@ (eww-same-page-p url (plist-get eww-data :url))) (let ((dom (plist-get eww-data :dom))) (eww-save-history) + (plist-put eww-data :url url) (eww-display-html 'utf-8 url dom nil (current-buffer)))) (t (eww-browse-url url external))))) Diff finished. Sat Apr 27 15:37:19 2019 From unknown Sun Jun 22 00:58:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35445: 26.2; eww-follow-link breaks on the second invocation Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 May 2019 20:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35445 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Xu Chunyang Cc: 35445@debbugs.gnu.org Received: via spool by 35445-submit@debbugs.gnu.org id=B35445.155769340013256 (code B ref 35445); Sun, 12 May 2019 20:37:02 +0000 Received: (at 35445) by debbugs.gnu.org; 12 May 2019 20:36:40 +0000 Received: from localhost ([127.0.0.1]:43444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPvD5-0003Rj-VL for submit@debbugs.gnu.org; Sun, 12 May 2019 16:36:40 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPvD3-0003RV-6a for 35445@debbugs.gnu.org; Sun, 12 May 2019 16:36:38 -0400 Received: from broadband14.b.subnet.rcn.com ([206.71.230.141] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hPvCx-0006ZI-8c; Sun, 12 May 2019 22:36:33 +0200 From: Lars Ingebrigtsen References: Date: Sun, 12 May 2019 16:36:29 -0400 In-Reply-To: (Xu Chunyang's message of "Sat, 27 Apr 2019 15:38:30 +0800") Message-ID: <878svbo1f6.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Xu Chunyang writes: > According to my observation, the eww-data's :url is missing after the > first eww-follow-link invocation. eww-follow-link contains these two lines of code > > (eww-save-history) > (eww-display-html [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Xu Chunyang writes: > According to my observation, the eww-data's :url is missing after the > first eww-follow-link invocation. eww-follow-link contains these two lines of code > > (eww-save-history) > (eww-display-html 'utf-8 url dom nil (current-buffer)) > > the first line clears eww-data via (setq eww-data (list :title "")), but > the second line forgets to (plist-put eww-data :url url). > > The following patch fixes the issue for me: Thanks; I've applied the patch to the Emacs trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 16:36:54 2019 Received: (at control) by debbugs.gnu.org; 12 May 2019 20:36:54 +0000 Received: from localhost ([127.0.0.1]:43447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPvDI-0003SI-9z for submit@debbugs.gnu.org; Sun, 12 May 2019 16:36:54 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPvDG-0003S6-Qx for control@debbugs.gnu.org; Sun, 12 May 2019 16:36:51 -0400 Received: from broadband14.b.subnet.rcn.com ([206.71.230.141] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hPvDD-0006aO-0N for control@debbugs.gnu.org; Sun, 12 May 2019 22:36:49 +0200 Date: Sun, 12 May 2019 16:36:45 -0400 Message-Id: <877eavo1eq.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #35445 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: fixed 35445 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) fixed 35445 27.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 16:37:04 2019 Received: (at control) by debbugs.gnu.org; 12 May 2019 20:37:04 +0000 Received: from localhost ([127.0.0.1]:43450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPvDT-0003Sv-Op for submit@debbugs.gnu.org; Sun, 12 May 2019 16:37:03 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPvDQ-0003Sc-IX for control@debbugs.gnu.org; Sun, 12 May 2019 16:37:00 -0400 Received: from broadband14.b.subnet.rcn.com ([206.71.230.141] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hPvDN-0006b8-Oe for control@debbugs.gnu.org; Sun, 12 May 2019 22:36:59 +0200 Date: Sun, 12 May 2019 16:36:56 -0400 Message-Id: <875zqfo1ef.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #35445 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 35445 fixed close 35445 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35445 fixed close 35445 27.1 quit