From unknown Sun Jun 22 08:03:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35421 <35421@debbugs.gnu.org> To: bug#35421 <35421@debbugs.gnu.org> Subject: Status: Also bind left image rotation key Reply-To: bug#35421 <35421@debbugs.gnu.org> Date: Sun, 22 Jun 2025 15:03:24 +0000 retitle 35421 Also bind left image rotation key reassign 35421 emacs submitter 35421 =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson severity 35421 wishlist tag 35421 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 19:37:01 2019 Received: (at submit) by debbugs.gnu.org; 24 Apr 2019 23:37:01 +0000 Received: from localhost ([127.0.0.1]:56807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJRRk-0006K9-OS for submit@debbugs.gnu.org; Wed, 24 Apr 2019 19:37:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJRRi-0006Ju-8u for submit@debbugs.gnu.org; Wed, 24 Apr 2019 19:36:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:37305) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJRRc-0004VN-Or for submit@debbugs.gnu.org; Wed, 24 Apr 2019 19:36:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJRRb-0004U4-Nl for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 19:36:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_50,FROM_EXCESS_BASE64, RCVD_IN_DNSWL_NONE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJRFA-0003Il-0K for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 19:24:00 -0400 Received: from eastern.maple.relay.mailchannels.net ([23.83.214.55]:59032) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJRF9-0003IK-Ju for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 19:23:59 -0400 X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 2764E2C1CE2 for ; Wed, 24 Apr 2019 23:23:56 +0000 (UTC) Received: from pdx1-sub0-mail-a54.g.dreamhost.com (100-96-2-149.trex.outbound.svc.cluster.local [100.96.2.149]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id AFA742C209E for ; Wed, 24 Apr 2019 23:23:55 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from pdx1-sub0-mail-a54.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Wed, 24 Apr 2019 23:23:56 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jidanni@jidanni.org X-MailChannels-Auth-Id: dreamhost X-Sponge-Industry: 6476a9b260d18496_1556148236004_3409293616 X-MC-Loop-Signature: 1556148236004:358721783 X-MC-Ingress-Time: 1556148236003 Received: from pdx1-sub0-mail-a54.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTP id 25DEF7FF5B for ; Wed, 24 Apr 2019 16:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=jidanni.org; bh=HeaQbpnExS9tSkXdku +P10UZonQ=; b=JKvxREFngYrFpI3LROke7QkNRDZK4NovC5bD2HayqH8WOHBJUN Kj3GjCRplUaU4LzEiH3ahPjkF9lCFgRQr/5TfvmwXkP8hODmYQj5lOiPVnk0wtbe pegIrBd9UrtvR9TXN40qw9eBU0Y/o9xcXFXCW7qazjwGmcZDYbRI2dW4k= Received: from jidanni.org (36-234-71-18.dynamic-ip.hinet.net [36.234.71.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTPSA id A98F57FF4F for ; Wed, 24 Apr 2019 16:23:53 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a54 From: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson To: bug-gnu-emacs@gnu.org Subject: Also bind left image rotation key Date: Thu, 25 Apr 2019 07:23:50 +0800 Message-ID: <874l6n7zsp.5.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrheefgddvtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgfgsehtkeertddttdejnecuhfhrohhmpejnnjjnucffrghnucflrggtohgsshhonhcuoehjihgurghnnhhisehjihgurghnnhhirdhorhhgqeenucfkphepfeeirddvfeegrdejuddrudeknecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehjihgurghnnhhirdhorhhgpdhinhgvthepfeeirddvfeegrdejuddrudekpdhrvghtuhhrnhdqphgrthhhpeeprehuthhfqdekreeureehiehmpfehnfhiheehsgevkeerpecuffgrnhculfgrtghosghsohhnuceojhhiuggrnhhnihesjhhiuggrnhhnihdrohhrgheqpdhmrghilhhfrhhomhepjhhiuggrnhhnihesjhhiuggrnhhnihdrohhrghdpnhhrtghpthhtohepsghughdqghhnuhdqvghmrggtshesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 23.83.214.55 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) When viewing an image we type C-h m Image[imagemagick] mode defined in =E2=80=98image-mode.el=E2=80=99: there is only one rotate command bound r image-rotate and it only rotates right. To rotate left one must hit it three times. Also if we could see the whole image before rotation, its bottom is now cut off after rotation. (landscape->portrait). From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 10:12:27 2019 Received: (at 35421) by debbugs.gnu.org; 9 Jul 2019 14:12:27 +0000 Received: from localhost ([127.0.0.1]:33584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkqr5-0004DH-Jf for submit@debbugs.gnu.org; Tue, 09 Jul 2019 10:12:27 -0400 Received: from caracal.birch.relay.mailchannels.net ([23.83.209.30]:63585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkqr3-0004Cv-BJ for 35421@debbugs.gnu.org; Tue, 09 Jul 2019 10:12:26 -0400 X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 15EF58C2DB4; Tue, 9 Jul 2019 14:12:24 +0000 (UTC) Received: from pdx1-sub0-mail-a18.g.dreamhost.com (100-96-83-205.trex.outbound.svc.cluster.local [100.96.83.205]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C245F8C2D51; Tue, 9 Jul 2019 14:12:23 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from pdx1-sub0-mail-a18.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Tue, 09 Jul 2019 14:12:24 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jidanni@jidanni.org X-MailChannels-Auth-Id: dreamhost X-Arch-Befitting: 5509d9dc73c90183_1562681543894_1485720388 X-MC-Loop-Signature: 1562681543893:1795871019 X-MC-Ingress-Time: 1562681543893 Received: from pdx1-sub0-mail-a18.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTP id 6C6E483752; Tue, 9 Jul 2019 07:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=jidanni.org; bh=9VcuCKZ0l5AM8guKkmrsJlT/VmU=; b=MwHOmyLbvjNNh SDbG6NWLmlS6csHRdiZ5JQ1XeSLapff8Ho5sjNKrp0+8ofJSBPUSvs8SK5O0g30w 5JoycsYwxdgrbSvsreBi9K56CvutG4wylMZjvzdS9AQrgZQyJSTJrL4NPDwe4K0S SWIxa2sa9HNohwKwc63UTZcZyNCiwE= Received: from jidanni.org (111-246-99-103.dynamic-ip.hinet.net [111.246.99.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTPSA id 0A33183758; Tue, 9 Jul 2019 07:12:20 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a18 From: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson To: Lars Ingebrigtsen Subject: Re: bug#35421: Also bind left image rotation key References: <874l6n7zsp.5.fsf@jidanni.org> <877e8ruwvy.fsf@mouse.gnus.org> Date: Tue, 09 Jul 2019 22:12:17 +0800 Message-ID: <87lfx7uwji.5.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrgedvgdejjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufhffkfggtgesthdtredttddtjeenucfhrhhomhepnjjnnjcuffgrnhculfgrtghosghsohhnuceojhhiuggrnhhnihesjhhiuggrnhhnihdrohhrgheqnecukfhppeduuddurddvgeeirdelledruddtfeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepjhhiuggrnhhnihdrohhrghdpihhnvghtpeduuddurddvgeeirdelledruddtfedprhgvthhurhhnqdhprghthheppeeruhhtfhdqkeerueerheeimhfphefnihehhegsveekreepucffrghnucflrggtohgsshhonhcuoehjihgurghnnhhisehjihgurghnnhhirdhorhhgqedpmhgrihhlfhhrohhmpehjihgurghnnhhisehjihgurghnnhhirdhorhhgpdhnrhgtphhtthhopeefheegvdduseguvggssghughhsrdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35421 Cc: 35421@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Can an adding an argument reverse the direction? From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 10:13:52 2019 Received: (at 35421) by debbugs.gnu.org; 9 Jul 2019 14:13:52 +0000 Received: from localhost ([127.0.0.1]:33588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkqsS-0004Id-0b for submit@debbugs.gnu.org; Tue, 09 Jul 2019 10:13:52 -0400 Received: from bonobo.elm.relay.mailchannels.net ([23.83.212.22]:64370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkqsQ-0004IJ-DD for 35421@debbugs.gnu.org; Tue, 09 Jul 2019 10:13:50 -0400 X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 2235E22EA0; Tue, 9 Jul 2019 14:13:49 +0000 (UTC) Received: from pdx1-sub0-mail-a18.g.dreamhost.com (100-96-8-155.trex.outbound.svc.cluster.local [100.96.8.155]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D0A6722A08; Tue, 9 Jul 2019 14:13:48 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from pdx1-sub0-mail-a18.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Tue, 09 Jul 2019 14:13:49 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jidanni@jidanni.org X-MailChannels-Auth-Id: dreamhost X-Zesty-Vacuous: 7c4ba35c729a2f0c_1562681628936_2565502588 X-MC-Loop-Signature: 1562681628936:2481009235 X-MC-Ingress-Time: 1562681628936 Received: from pdx1-sub0-mail-a18.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTP id E396D8375E; Tue, 9 Jul 2019 07:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=jidanni.org; bh=RlWdyTmFAZjj57m3a6QbTWDG4YA=; b=gsyvhNTsd16hr H3QWek7vh8sKnCNeY9cGN+9XnRmK+XnE1iMbk/PQJ7gIjBXm4t7lYkNWBc+NkZWk 9hF5Xkh4nglgu4A5/Cyc1CMUVmKb9K6EbRwtVbnT66uLjVoDum3kKPXj8QUnCl1K 8DUjpHWWYT/wDxggJtHjq7V2RnpVH8= Received: from jidanni.org (111-246-99-103.dynamic-ip.hinet.net [111.246.99.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTPSA id 5660783760; Tue, 9 Jul 2019 07:13:34 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a18 From: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson To: Lars Ingebrigtsen Subject: Re: bug#35421: Also bind left image rotation key References: <874l6n7zsp.5.fsf@jidanni.org> <877e8ruwvy.fsf@mouse.gnus.org> Date: Tue, 09 Jul 2019 22:13:30 +0800 Message-ID: <87h87vuwhh.5.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrgedvgdejjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufhffkfggtgesthdtredttddtjeenucfhrhhomhepnjjnnjcuffgrnhculfgrtghosghsohhnuceojhhiuggrnhhnihesjhhiuggrnhhnihdrohhrgheqnecukfhppeduuddurddvgeeirdelledruddtfeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepjhhiuggrnhhnihdrohhrghdpihhnvghtpeduuddurddvgeeirdelledruddtfedprhgvthhurhhnqdhprghthheppeeruhhtfhdqkeerueerheeimhfphefnihehhegsveekreepucffrghnucflrggtohgsshhonhcuoehjihgurghnnhhisehjihgurghnnhhirdhorhhgqedpmhgrihhlfhhrohhmpehjihgurghnnhhisehjihgurghnnhhirdhorhhgpdhnrhgtphhtthhopeefheegvdduseguvggssghughhsrdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgepud X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35421 Cc: 35421@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Or maybe [argument x 90 degrees]. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 10:21:38 2019 Received: (at 35421) by debbugs.gnu.org; 9 Jul 2019 14:21:38 +0000 Received: from localhost ([127.0.0.1]:33629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkqzy-0006jZ-A7 for submit@debbugs.gnu.org; Tue, 09 Jul 2019 10:21:38 -0400 Received: from quimby.gnus.org ([80.91.231.51]:46854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkqzt-0006iE-KO for 35421@debbugs.gnu.org; Tue, 09 Jul 2019 10:21:34 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkqji-0005vn-6k; Tue, 09 Jul 2019 16:04:52 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson Subject: Re: bug#35421: Also bind left image rotation key References: <874l6n7zsp.5.fsf@jidanni.org> Date: Tue, 09 Jul 2019 16:04:49 +0200 In-Reply-To: <874l6n7zsp.5.fsf@jidanni.org> (=?utf-8?B?IuepjeS4ueWwvA==?= Dan Jacobson"'s message of "Thu, 25 Apr 2019 07:23:50 +0800") Message-ID: <877e8ruwvy.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: 積丹尼 Dan Jacobson writes: > When viewing an image we type C-h m > > Image[imagemagick] mode defined in ‘image-mode.el’: > > there is only one rotate command bound > > r image-rotate > > and it only rotates right. To rotate [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35421 Cc: 35421@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson writes: > When viewing an image we type C-h m > > Image[imagemagick] mode defined in =E2=80=98image-mode.el=E2=80=99: > > there is only one rotate command bound > > r image-rotate > > and it only rotates right. To rotate left one must hit it three times. I don't think it's worth adding more keystrokes to the image map -- images can appear in any mode and it's better to keep the number of keystrokes limited. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 10:21:38 2019 Received: (at control) by debbugs.gnu.org; 9 Jul 2019 14:21:38 +0000 Received: from localhost ([127.0.0.1]:33627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkqzy-0006jQ-0M for submit@debbugs.gnu.org; Tue, 09 Jul 2019 10:21:38 -0400 Received: from quimby.gnus.org ([80.91.231.51]:46854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkqzt-0006iE-25 for control@debbugs.gnu.org; Tue, 09 Jul 2019 10:21:33 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkqjo-0005vu-3f for control@debbugs.gnu.org; Tue, 09 Jul 2019 16:04:58 +0200 Date: Tue, 09 Jul 2019 16:04:55 +0200 Message-Id: <875zobuwvs.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #35421 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 35421 wontfix close 35421 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35421 wontfix close 35421 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 10:54:45 2019 Received: (at 35421) by debbugs.gnu.org; 9 Jul 2019 14:54:45 +0000 Received: from localhost ([127.0.0.1]:33714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkrW0-0003RB-Ru for submit@debbugs.gnu.org; Tue, 09 Jul 2019 10:54:45 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:36944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkrVy-0003Qr-EI for 35421@debbugs.gnu.org; Tue, 09 Jul 2019 10:54:43 -0400 Received: by mail-wr1-f67.google.com with SMTP id n9so12240428wrr.4 for <35421@debbugs.gnu.org>; Tue, 09 Jul 2019 07:54:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=d5gCdlUMSCLXjHhryGgfvvx4UOoDbI/gIbj+EB9A3Ws=; b=j3P02jTHQRcObVZRoK9Hto3KTW+87f3pB2WpQui6BPLVlw3/WDf0zJ+HYlHvZoNt1C IM0d2+6YK9kZPMuk5MCG0XGVTZ50p5xnyFUA7XSGVnXPhSMlcMeJQqAV8gNuYC7BLTiT 5R4TWTeernDH2tvTUre/4D9X64N38VT5rX97A+ISNACRPnkSkiKwu0hmb3aG4wvd1e2s Fho6HmDL2wAxbZ/3hE2xj/lLgTZHIVijk+KksTIyxFkDmwXBtW1vWE3RnHPiBjp/44tu cyKyk9jwAFaA0/uvAA54+gwhVjGBspb4TEPfhfPDQSCOqwrZSVLAOpIfIC8swMnjFSaK dNIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=d5gCdlUMSCLXjHhryGgfvvx4UOoDbI/gIbj+EB9A3Ws=; b=OgHbUeMrhsh6nP90SuQoUb2Pkie/xGd1jika69sgV8X2JqEFrXLZJ2efP8FFiygRxs 8sImMiLRBICz3KlDU5l2HIHUsdI8T8hOoQ+6uObtH2ldFb/HXJeEjSGxslydKJFhcHgE T9MpxJhxYY7i0WCnxweCOHT3KNF79FPdguQQgDgWFud3li07y0/ve6+JFKSGUPHJPAvT 9a0VuWNEUwZKc9Sci1x5qkw9vVvUMXJrd8oEU/8YzkA8ZX5IiWmEgGbp4PJsIykxiXpK RXmbf2LY6BokPVMDVsP04enrrrV3bJO+1fhTGAWaruZ3wF2D2LzxxOnoL8fUWrVIKiqL x2bg== X-Gm-Message-State: APjAAAWEoRitprAt0w9B6bsuxUmXyFaA/mcqlpgZI3Q1fbxz53YS+Bnv TNaFHnfcq2rc4Wr/ST/3l7lSYw== X-Google-Smtp-Source: APXvYqw/6z6pj8E/fJ1tD26hTsjpIcQd8zZrgGnFHTCv2FhjjvRqLUnMeOxYjrbAPCIyyQzkJDlGyQ== X-Received: by 2002:adf:e28a:: with SMTP id v10mr26646621wri.178.1562684076550; Tue, 09 Jul 2019 07:54:36 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id m16sm19449775wrv.89.2019.07.09.07.54.35 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 09 Jul 2019 07:54:35 -0700 (PDT) From: "Basil L. Contovounesios" To: Lars Ingebrigtsen Subject: Re: bug#35421: Also bind left image rotation key References: <874l6n7zsp.5.fsf@jidanni.org> <877e8ruwvy.fsf@mouse.gnus.org> Date: Tue, 09 Jul 2019 15:54:34 +0100 In-Reply-To: <877e8ruwvy.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Tue, 09 Jul 2019 16:04:49 +0200") Message-ID: <877e8rcl79.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: reopen 35421 tags 35421 - wontfix quit Lars Ingebrigtsen writes: > 積丹尼 Dan Jacobson writes: > >> When viewing an image we type C-h m >> >> Image[imagemagick] mode defined in ‘image-mode.el’: >> >> there is only one rotate command bou [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: jidanni.org] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.67 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.67 listed in wl.mailspike.net] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.3 PDS_NO_HELO_DNS High profile HELO but no A record X-Debbugs-Envelope-To: 35421 Cc: 35421@debbugs.gnu.org, =?utf-8?B?56mN5Li55bC8?= Dan Jacobson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) reopen 35421 tags 35421 - wontfix quit Lars Ingebrigtsen writes: > =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson writes: > >> When viewing an image we type C-h m >> >> Image[imagemagick] mode defined in =E2=80=98image-mode.el=E2=80=99: >> >> there is only one rotate command bound >> >> r image-rotate >> >> and it only rotates right. To rotate left one must hit it three times. > > I don't think it's worth adding more keystrokes to the image map -- > images can appear in any mode and it's better to keep the number of > keystrokes limited. I had a patch prepared for giving image-rotate an optional prefix argument, but then I got distracted by some imagemagick vs native transformation issues, so I was waiting for the native support to stabilise a bit before returning to this in earnest. Should have something to show within a day or two. Thanks, --=20 Basil From unknown Sun Jun 22 08:03:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Tue, 09 Jul 2019 14:55:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 11:00:35 2019 Received: (at 35421) by debbugs.gnu.org; 9 Jul 2019 15:00:35 +0000 Received: from localhost ([127.0.0.1]:33720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkrbf-00046K-JB for submit@debbugs.gnu.org; Tue, 09 Jul 2019 11:00:35 -0400 Received: from egyptian.birch.relay.mailchannels.net ([23.83.209.56]:5502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkrbd-00043b-JV for 35421@debbugs.gnu.org; Tue, 09 Jul 2019 11:00:34 -0400 X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 33EB2341F2D; Tue, 9 Jul 2019 15:00:32 +0000 (UTC) Received: from pdx1-sub0-mail-a18.g.dreamhost.com (100-96-8-155.trex.outbound.svc.cluster.local [100.96.8.155]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id DC7BC3419E1; Tue, 9 Jul 2019 15:00:31 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from pdx1-sub0-mail-a18.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Tue, 09 Jul 2019 15:00:32 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jidanni@jidanni.org X-MailChannels-Auth-Id: dreamhost X-Macabre-Keen: 3d5ba56d1e33afd7_1562684432019_2745567856 X-MC-Loop-Signature: 1562684432018:2563213198 X-MC-Ingress-Time: 1562684432018 Received: from pdx1-sub0-mail-a18.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTP id 829FC8375D; Tue, 9 Jul 2019 08:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=jidanni.org; bh=mlwcgfjvjz6rzkjMHqskAB3QvQw=; b=CrGpHNlTC5Y3i uyEdAxCS30OHSCSVfqk1bFl7GdoJ0LUQnbImtfSGuZPVW3Plbn1ICSghDiTtyQqu xyMESx2uqw0mxtE/8IGKPovIjz4RXBjv716NGCaHDpSjbyYp2JNozbRS4/cGh3EN QsgOEv80ewBbuqzu50wjwv68JP7s/I= Received: from jidanni.org (111-246-99-103.dynamic-ip.hinet.net [111.246.99.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTPSA id CDABA8376D; Tue, 9 Jul 2019 08:00:25 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a18 From: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson To: "Basil L. Contovounesios" Subject: Re: bug#35421: Also bind left image rotation key References: <874l6n7zsp.5.fsf@jidanni.org> <877e8ruwvy.fsf@mouse.gnus.org> <877e8rcl79.fsf@tcd.ie> Date: Tue, 09 Jul 2019 23:00:21 +0800 Message-ID: <874l3vuube.5.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrgedvgdekjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufhffkfggtgesthdtredttddtjeenucfhrhhomhepnjjnnjcuffgrnhculfgrtghosghsohhnuceojhhiuggrnhhnihesjhhiuggrnhhnihdrohhrgheqnecukfhppeduuddurddvgeeirdelledruddtfeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepjhhiuggrnhhnihdrohhrghdpihhnvghtpeduuddurddvgeeirdelledruddtfedprhgvthhurhhnqdhprghthheppeeruhhtfhdqkeerueerheeimhfphefnihehhegsveekreepucffrghnucflrggtohgsshhonhcuoehjihgurghnnhhisehjihgurghnnhhirdhorhhgqedpmhgrihhlfhhrohhmpehjihgurghnnhhisehjihgurghnnhhirdhorhhgpdhnrhgtphhtthhopeefheegvdduseguvggssghughhsrdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35421 Cc: 35421@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) args 1,2,3= 90,180,270 or something like that. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 16 19:45:23 2019 Received: (at 35421) by debbugs.gnu.org; 16 Jul 2019 23:45:24 +0000 Received: from localhost ([127.0.0.1]:51324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnX8N-0003yJ-GO for submit@debbugs.gnu.org; Tue, 16 Jul 2019 19:45:23 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnX8L-0003y1-F7 for 35421@debbugs.gnu.org; Tue, 16 Jul 2019 19:45:22 -0400 Received: by mail-wr1-f67.google.com with SMTP id g17so22732739wrr.5 for <35421@debbugs.gnu.org>; Tue, 16 Jul 2019 16:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=guyi5cfREEpW8tvU8zVccg1TTNRwwBommYtW/pXeOTk=; b=a9Vicg2ol3D4SWBwvqKbXy/43sBShH31KUP0MLWicrxL7neLFRc0oy2zEMa4ADFE4e fhPqj2lQ4goTqI4VTSRpeG3NCYCAGb/Ad8uFCzhTeMmXKvFnSQYuQf5S0g9SrOPYDa9Y mqZk28pvFrE62FlguL8r6DhIIcbl8xl7CEDDNWLZp+NUv2emHutqP+VhybAUJgZ0wNv7 cpsZg1hwd3cpeBRg+kK0cbrntVpA/1Y4+doAEKYT9Fa5zYfxJdj6IeoJg8SdnU976FtB bAusMuL0EC3J0Glsr+7bNDFV5TO4zuPNZpOKxkwB5I1GR92jUVfLiXFha9KHdB14u3u6 wZxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=guyi5cfREEpW8tvU8zVccg1TTNRwwBommYtW/pXeOTk=; b=oLmlw06WegrgamMaYAE6c/p2qjK/lmAh63smtzt/6PAPohrCCyPks2f1GiTvDiAqpo 6lNDel1G63hBFTcavV1NpKL+iQV4ZSsT0Bye+GYho7mC+GxJJVq7zmWy7vrWenYk9g0j hdhipG/Si1jF77lbG/IL1vZIJ4IG0F+hm9NREpxz21N6wki5B2/KHSVaz5JDpuZv6b2p +H/ZRm1UcxoDVfZlrXCgkEFctCND1y4yoIMWQPcZYLae08RT2Twk92XDgS1fTNKDmutn ZDb6k4/mz1zuPi4qHtLOu2JWcJc+DNTwd0d8sSA8r7fsMWnjFLBGkD4gmXVPLvJvbZ/N kT3g== X-Gm-Message-State: APjAAAWHeBEpfmVkouPGWonmXBj5D5YRFaiz+mO1md9t+ced5xVmSi6E NeYVcEYEN6yQCJAFEK8RYHhAvA== X-Google-Smtp-Source: APXvYqwd6tErJ/Kn9rVpJPZpHXApQZiy0NKt6Rzk4K/h2ANY3ukQHtcoM4EPs8FIJdEwttmpCLijYQ== X-Received: by 2002:a5d:518d:: with SMTP id k13mr38179782wrv.40.1563320715521; Tue, 16 Jul 2019 16:45:15 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id r5sm23590357wmh.35.2019.07.16.16.45.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 16 Jul 2019 16:45:14 -0700 (PDT) From: "Basil L. Contovounesios" To: Lars Ingebrigtsen Subject: Re: bug#35421: Also bind left image rotation key References: <874l6n7zsp.5.fsf@jidanni.org> <877e8ruwvy.fsf@mouse.gnus.org> <877e8rcl79.fsf@tcd.ie> Date: Wed, 17 Jul 2019 00:45:08 +0100 In-Reply-To: <877e8rcl79.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 09 Jul 2019 15:54:34 +0100") Message-ID: <87sgr5y263.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35421 Cc: 35421@debbugs.gnu.org, =?utf-8?B?56mN5Li55bC8?= Dan Jacobson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 35421 + patch quit "Basil L. Contovounesios" writes: > I had a patch prepared for giving image-rotate an optional prefix > argument, but then I got distracted by some imagemagick vs native > transformation issues, so I was waiting for the native support to > stabilise a bit before returning to this in earnest. Should have > something to show within a day or two. With a slight delay due to a camping trip, here it is: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Allow-counter-clockwise-rotations-in-image-rotate.patch >From 38e676d04f12a69289d4095bb9f61247c4f08ae8 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Tue, 16 Jul 2019 22:51:27 +0100 Subject: [PATCH] Allow counter-clockwise rotations in image-rotate * lisp/image.el (image-rotate): Extend with an optional argument specifying the rotation in degrees (bug#35421). * doc/lispref/display.texi (Showing Images): * etc/NEWS: Document the change. * test/lisp/image-tests.el (image-rotate): New test. --- doc/lispref/display.texi | 3 ++- etc/NEWS | 5 +++++ lisp/image.el | 22 +++++++++++++--------- test/lisp/image-tests.el | 23 +++++++++++++++++++++++ 4 files changed, 43 insertions(+), 10 deletions(-) diff --git a/doc/lispref/display.texi b/doc/lispref/display.texi index a38569f726..4b10788862 100644 --- a/doc/lispref/display.texi +++ b/doc/lispref/display.texi @@ -5992,7 +5992,8 @@ Showing Images of @samp{4} means to decrease the size by 40%. The default is 20%. @item r -Rotate the image by 90 degrees (@code{image-rotate}). +Rotate the image by 90 degrees clockwise (@code{image-rotate}). +A prefix means to rotate by 90 degrees counter-clockwise instead. @item o Save the image to a file (@code{image-save}). diff --git a/etc/NEWS b/etc/NEWS index 76ea1df821..4cc30dfcbd 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -2237,6 +2237,11 @@ The image parameters 'image-transform-rotation', buffer-local, so each buffer could have its own values for these parameters. ++++ +*** The command 'image-rotate' now accepts a prefix argument. +With a prefix argument, 'image-rotate' now rotates the image at point +90 degrees counter-clockwise, instead of the default clockwise. + ** Modules *** The function 'load' now behaves correctly when loading modules. diff --git a/lisp/image.el b/lisp/image.el index b58b1dc954..c3e28655c3 100644 --- a/lisp/image.el +++ b/lisp/image.el @@ -1028,16 +1028,20 @@ image--current-scaling (display-width (car (image-size image t)))) (/ (float display-width) image-width))) -(defun image-rotate () - "Rotate the image under point by 90 degrees clockwise." - (interactive) +(defun image-rotate (&optional angle) + "Rotate the image under point by ANGLE degrees clockwise. +If nil, ANGLE defaults to 90. Interactively, rotate the image 90 +degrees clockwise with no prefix argument, and counter-clockwise +with a prefix argument. Note that most image types support +rotations by only multiples of 90 degrees." + (interactive (and current-prefix-arg '(-90))) (let ((image (image--get-imagemagick-and-warn))) - (plist-put (cdr image) :rotation - (float (mod (+ (or (plist-get (cdr image) :rotation) 0) 90) - ;; We don't want to exceed 360 degrees - ;; rotation, because it's not seen as valid - ;; in exif data. - 360))))) + (setf (image-property image :rotation) + (float (mod (+ (or (image-property image :rotation) 0) + (or angle 90)) + ;; We don't want to exceed 360 degrees rotation, + ;; because it's not seen as valid in Exif data. + 360))))) (defun image-save () "Save the image under point." diff --git a/test/lisp/image-tests.el b/test/lisp/image-tests.el index 5a5b8ea1f7..01c81e3022 100644 --- a/test/lisp/image-tests.el +++ b/test/lisp/image-tests.el @@ -21,6 +21,8 @@ (require 'ert) (require 'image) +(eval-when-compile + (require 'cl-lib)) (defconst image-tests--emacs-images-directory (expand-file-name "../etc/images" (getenv "EMACS_TEST_DIRECTORY")) @@ -53,4 +55,25 @@ image-type-from-file-header-test (expand-file-name "splash.svg" image-tests--emacs-images-directory))))) +(ert-deftest image-rotate () + "Test `image-rotate'." + (cl-letf* ((image (list 'image)) + ((symbol-function 'image--get-imagemagick-and-warn) + (lambda () image))) + (let ((current-prefix-arg '(4))) + (call-interactively #'image-rotate)) + (should (equal image '(image :rotation 270.0))) + (call-interactively #'image-rotate) + (should (equal image '(image :rotation 0.0))) + (image-rotate) + (should (equal image '(image :rotation 90.0))) + (image-rotate 0) + (should (equal image '(image :rotation 90.0))) + (image-rotate 1) + (should (equal image '(image :rotation 91.0))) + (image-rotate 1234.5) + (should (equal image '(image :rotation 245.5))) + (image-rotate -154.5) + (should (equal image '(image :rotation 91.0))))) + ;;; image-tests.el ends here -- 2.20.1 --=-=-= Content-Type: text/plain I think this is a good solution for several reasons: 1. It does not require a new key binding, and it does not overly complicate the calling convention of the current key binding. 2. It turns image-rotate into a general image-rotating subroutine, which users and library authors alike can reuse. 2.1. It does not limit rotations of imagemagick images to multiples of 90 degrees. and I don't see any drawbacks, so I would like to push this to master, subject to comments/objections. Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 16 19:53:08 2019 Received: (at 35421) by debbugs.gnu.org; 16 Jul 2019 23:53:08 +0000 Received: from localhost ([127.0.0.1]:51356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnXFs-0004BZ-7o for submit@debbugs.gnu.org; Tue, 16 Jul 2019 19:53:08 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:53645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnXFr-0004BM-6U for 35421@debbugs.gnu.org; Tue, 16 Jul 2019 19:53:07 -0400 Received: by mail-wm1-f68.google.com with SMTP id x15so20292863wmj.3 for <35421@debbugs.gnu.org>; Tue, 16 Jul 2019 16:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=OFbV8G63ETLS2H3ySjlxJxCWXmPBm8ABFCD0Zv57FSs=; b=NFjHo1eiPDDibLM87vmHzZiUk6/IyDHWWmBegnd2hP0cBauPvncxbwVm0NTl8+cfAC fG3DyTcPChDoOARlVR/9rljWHFrhcf6laiShSNiN/Gx63tEQXKFEQsDOqiR3cCZSlicb ksJ3eueUxVffvvW72puxHfgBxQUHVDjNUHQd2lwPzpAR6JfRo99ZMjDM9sFl+hOOWuUZ ouOpqlZDUTttVJsGO8h2/PFzFadx74Z7RI3Sb8MD07pmhq8/x8QIqrZPAZMLbqXvE7Jg Vzrsh38FJ28AZGSt502PTzhqTF6SjUjg1MiFGKSrjZJSKl0n+XDnYCeTSMm9STffx0df JkcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=OFbV8G63ETLS2H3ySjlxJxCWXmPBm8ABFCD0Zv57FSs=; b=bMRMub/HvMf4u4yqm2n4G+6lm/qRvX+kSWZPHU2vMd32I6je3hxKrfyFXIGQ/wlwvL uUZU/IrZ1CX9YXaQYiGEY+JniQ1xEhuk/mwfvrXJHuBTQx3AN5vAABbCNNSrhYjhgOju 4YL/5efwmx/KolCMKDoN/5uXrRSeaKBZWmtJ1O+wxabB9kMHiJW1QeJVa7RhwIDZn8tx hH3E1TPynuSYdBS/BAuOGnONNlhtj9akTJ/JPMQUnqLLUgifu6HnJAGLfRp6aHc9K/b4 FJ4sJOlvQHxxY6+Nb5THRWl+8SM6K6yAop74FuO6jJh5bPZqChL8fKpsyEh8fGzRVWaP LkVA== X-Gm-Message-State: APjAAAX39u0lJgfxKXFDNk2qceGPvqe3Oi8jwCvVZVRDxBljgWzAcxcU 6C3zYUFEowqY1mOplqSeh1b/aA== X-Google-Smtp-Source: APXvYqynQLIiAl9n5kFszZB1XTZzsaas9rabY8dgRBDcS/jwTkhzSw/Eo+MTFzsxX0nZNyatC6im3g== X-Received: by 2002:a1c:4054:: with SMTP id n81mr33086349wma.78.1563321181334; Tue, 16 Jul 2019 16:53:01 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id g8sm19973526wmf.17.2019.07.16.16.53.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 16 Jul 2019 16:53:00 -0700 (PDT) From: "Basil L. Contovounesios" To: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson Subject: Re: bug#35421: Also bind left image rotation key References: <874l6n7zsp.5.fsf@jidanni.org> <877e8ruwvy.fsf@mouse.gnus.org> <877e8rcl79.fsf@tcd.ie> <874l3vuube.5.fsf@jidanni.org> Date: Wed, 17 Jul 2019 00:52:59 +0100 In-Reply-To: <874l3vuube.5.fsf@jidanni.org> (=?utf-8?B?IuepjeS4ueWwvA==?= Dan Jacobson"'s message of "Tue, 09 Jul 2019 23:00:21 +0800") Message-ID: <875zo1y1t0.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35421 Cc: 35421@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson writes: > args > 1,2,3=3D > 90,180,270 > or something like that. Image viewers like gThumb provide buttons for rotations in steps of 90 degrees, and Emacs isn't even an image viewer, so there's no need to complicate and restrict (w.r.t. future changes) the command's calling convention like that. Instead, the proposed patch[1] makes the simplest possible change to support counter-clockwise rotations in one step, rather than three. In addition, it makes image-rotate accept arbitrary rotation angles when called from Lisp, so you can use it to easily write your own image-rotating command, with your preferred calling convention. [1]: https://debbugs.gnu.org/35421#31 --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 17 07:03:47 2019 Received: (at 35421) by debbugs.gnu.org; 17 Jul 2019 11:03:48 +0000 Received: from localhost ([127.0.0.1]:51623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnhit-0001gZ-L5 for submit@debbugs.gnu.org; Wed, 17 Jul 2019 07:03:47 -0400 Received: from quimby.gnus.org ([80.91.231.51]:46704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnhis-0001gS-AI for 35421@debbugs.gnu.org; Wed, 17 Jul 2019 07:03:47 -0400 Received: from [80.169.244.84] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hnhin-0002IE-DK; Wed, 17 Jul 2019 13:03:43 +0200 From: Lars Ingebrigtsen To: "Basil L. Contovounesios" Subject: Re: bug#35421: Also bind left image rotation key References: <874l6n7zsp.5.fsf@jidanni.org> <877e8ruwvy.fsf@mouse.gnus.org> <877e8rcl79.fsf@tcd.ie> <87sgr5y263.fsf@tcd.ie> Date: Wed, 17 Jul 2019 13:03:40 +0200 In-Reply-To: <87sgr5y263.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 17 Jul 2019 00:45:08 +0100") Message-ID: <875zo0apo3.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > I think this is a good solution for several reasons: > > 1. It does not require a new key binding, and it does not overly > complicate the calling convention of the current key binding. > > 2. It tu [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35421 Cc: 35421@debbugs.gnu.org, =?utf-8?B?56mN5Li55bC8?= Dan Jacobson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > I think this is a good solution for several reasons: > > 1. It does not require a new key binding, and it does not overly > complicate the calling convention of the current key binding. > > 2. It turns image-rotate into a general image-rotating subroutine, > which users and library authors alike can reuse. > > 2.1. It does not limit rotations of imagemagick images to multiples of > 90 degrees. > > and I don't see any drawbacks, so I would like to push this to master, > subject to comments/objections. Looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 18 21:15:24 2019 Received: (at 35421) by debbugs.gnu.org; 19 Jul 2019 01:15:24 +0000 Received: from localhost ([127.0.0.1]:54922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoHUa-0000mI-7m for submit@debbugs.gnu.org; Thu, 18 Jul 2019 21:15:24 -0400 Received: from buffalo.birch.relay.mailchannels.net ([23.83.209.24]:29570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoHUX-0000m9-S0 for 35421@debbugs.gnu.org; Thu, 18 Jul 2019 21:15:22 -0400 X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6AECF5E2317; Fri, 19 Jul 2019 01:15:20 +0000 (UTC) Received: from pdx1-sub0-mail-a43.g.dreamhost.com (100-96-38-48.trex.outbound.svc.cluster.local [100.96.38.48]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id EAC305E22E9; Fri, 19 Jul 2019 01:15:19 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from pdx1-sub0-mail-a43.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Fri, 19 Jul 2019 01:15:20 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jidanni@jidanni.org X-MailChannels-Auth-Id: dreamhost X-Arithmetic-Rock: 326c749e289ef50f_1563498920234_1685276248 X-MC-Loop-Signature: 1563498920234:3104249891 X-MC-Ingress-Time: 1563498920233 Received: from pdx1-sub0-mail-a43.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a43.g.dreamhost.com (Postfix) with ESMTP id 9898E830EA; Thu, 18 Jul 2019 18:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=jidanni.org; bh=9jX9ShNo/JLIWfahHHOMICBn8Uk=; b=pP5grlpe5I+Xd LjRZU1rODTO7kjkrfeuv0kf5g7ZafrjBHxOBhYAi4eXDBZU1pAIjCwg4RSkVuLad 1fcVfnXLd+4ZTxubkMOcd+vBK/Ca/+be6uNGJJLqXoAmqd3Z1EcMas/8ifr1RrfS aFcLJ2IKXzW9+252zp9czjn0TPpljQ= Received: from jidanni.org (110-28-104-43.adsl.fetnet.net [110.28.104.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by pdx1-sub0-mail-a43.g.dreamhost.com (Postfix) with ESMTPSA id 64FC8830E9; Thu, 18 Jul 2019 18:15:13 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a43 From: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson To: "Basil L. Contovounesios" Subject: Re: bug#35421: Also bind left image rotation key References: <874l6n7zsp.5.fsf@jidanni.org> <877e8ruwvy.fsf@mouse.gnus.org> <877e8rcl79.fsf@tcd.ie> <87sgr5y263.fsf@tcd.ie> Date: Fri, 19 Jul 2019 08:53:16 +0800 Message-ID: <87ftn2lu9v.7.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrieeigdeggecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufhffkfggtgesthdtredttddtjeenucfhrhhomhepnjjnnjcuffgrnhculfgrtghosghsohhnuceojhhiuggrnhhnihesjhhiuggrnhhnihdrohhrgheqnecukfhppeduuddtrddvkedruddtgedrgeefnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehjihgurghnnhhirdhorhhgpdhinhgvthepuddutddrvdekrddutdegrdegfedprhgvthhurhhnqdhprghthheppeeruhhtfhdqkeerueerheeimhfphefnihehhegsveekreepucffrghnucflrggtohgsshhonhcuoehjihgurghnnhhisehjihgurghnnhhirdhorhhgqedpmhgrihhlfhhrohhmpehjihgurghnnhhisehjihgurghnnhhirdhorhhgpdhnrhgtphhtthhopeefheegvdduseguvggssghughhsrdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35421 Cc: 35421@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) OK but add to Docstring/Info: To rotate (right) by 90, hit ... To rotate (right) by 180, hit ... To rotate (right) by 270, hit ... As these are the most common tasks. (I'm most curious as to the recommended sequences the users should hit, especially for 180. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 20 11:06:56 2019 Received: (at 35421) by debbugs.gnu.org; 20 Jul 2019 15:06:56 +0000 Received: from localhost ([127.0.0.1]:57760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoqwp-00060g-Kk for submit@debbugs.gnu.org; Sat, 20 Jul 2019 11:06:55 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:36393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hoqwm-00060L-TY for 35421@debbugs.gnu.org; Sat, 20 Jul 2019 11:06:54 -0400 Received: by mail-wr1-f65.google.com with SMTP id n4so35060435wrs.3 for <35421@debbugs.gnu.org>; Sat, 20 Jul 2019 08:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uW+1qLxIXirHARj5I2uJMAWk7YfU8lfYv5u1sTK/aVs=; b=jbe3dD26QPBSc/xnL72wnlbDKpUa34/YMy8PrRE29LlSN/Jnw3MTEeGzpWMzw/jmDS LSxqKTBMw72Mugf9Xz928X+zehcY8DAmaxc0xEAKSGLjzVWxaUsipP3yxAlmxWMLN+Ul ZbP8podd/sNdfOCYodfcX20pCkkkR0Vbc+5HoFL/+6IVTqLzvQMY0KDQRatWSKE4qFvW 0v91nVGKZhqGkQcZOkYiu1teHyazrjtr8AM286paAd8SAS28035HJNWf2Bp7QLRGafbc bQ4RT1YxRMVtsc7l52EKYoLPbVx0BSGrvDQWHsCNiz7n6j8CfitdOdmHyH/0QWxAhyz6 LT2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uW+1qLxIXirHARj5I2uJMAWk7YfU8lfYv5u1sTK/aVs=; b=LcEh2dB+GYeVr2B6lm5V2F7tmFdJ7tDwdFE7yFofEz2hVR+9usp/CDcDeuuLOkQngj 7oyYKU7qbbbET4f98CKki8gudnwe10mbZeiAYM0W6cTmeMpOKRWgTeZuPun/mlHAbgDg eTADNWAAZXH2EfRArU8MCROVzUQGxRGCAoB0UD5hfXmCLfAzUn4VaxtM9JAm8vRJzC9l Z0yKHa17R0cuMKywf8ie4kf/vOLeOPRAh9wjKwSjCz5LXtyYSnbYdZArK/1JfXg6h1FT Y0JSKbXXQYnFUBz/VpZExAH5GDm13e4nAXqBbeP/1r8jHABeme7QYGXC0elH+dv0qa4f TK2w== X-Gm-Message-State: APjAAAXl2E1ctH4M7JI4h1q9ly17Gj8LEvEH+X8tHoprscnr49aW/RPw ZVOKesEvUDVif/f0O7srkhoVww== X-Google-Smtp-Source: APXvYqxzs7ANd2Xp4ohBEPyXEqmyFihVinC660ALg7ntJnyph9pQDE4YcDcwukbBD8MuznIIYNzs7g== X-Received: by 2002:adf:f046:: with SMTP id t6mr66770035wro.307.1563635207088; Sat, 20 Jul 2019 08:06:47 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id a67sm32129517wmh.40.2019.07.20.08.06.45 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 20 Jul 2019 08:06:45 -0700 (PDT) From: "Basil L. Contovounesios" To: Lars Ingebrigtsen Subject: Re: bug#35421: Also bind left image rotation key References: <874l6n7zsp.5.fsf@jidanni.org> <877e8ruwvy.fsf@mouse.gnus.org> <877e8rcl79.fsf@tcd.ie> <87sgr5y263.fsf@tcd.ie> <875zo0apo3.fsf@mouse.gnus.org> Date: Sat, 20 Jul 2019 16:06:44 +0100 In-Reply-To: <875zo0apo3.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Wed, 17 Jul 2019 13:03:40 +0200") Message-ID: <874l3g68zf.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35421 Cc: 35421@debbugs.gnu.org, =?utf-8?B?56mN5Li55bC8?= Dan Jacobson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Looks good to me. Thanks, pushed to master: Allow counter-clockwise rotations in image-rotate b728620a75 2019-07-20 16:00:31 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b728620a756db78b8cb0a41afa72db6209102cdf -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 20 11:13:00 2019 Received: (at control) by debbugs.gnu.org; 20 Jul 2019 15:13:00 +0000 Received: from localhost ([127.0.0.1]:57770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hor2h-0006C8-R9 for submit@debbugs.gnu.org; Sat, 20 Jul 2019 11:13:00 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:52545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hor2g-0006Bj-HB for control@debbugs.gnu.org; Sat, 20 Jul 2019 11:12:59 -0400 Received: by mail-wm1-f66.google.com with SMTP id s3so31264477wms.2 for ; Sat, 20 Jul 2019 08:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=1yomSR8/BY5xdqwyR44IUvx9dnKiCrIP5815QgnJSBQ=; b=yNjShPyyX4/VAvRKltFam4aKIhajExAweeEko+FMH1eTgJy39MKRM7qEFV1z3T142d pSuEAAADJgIHANoUFS82agggoNkdExcPERatuU2UZNF5rMff/vBeDs+fY7BEcOxBS21/ jy3LWzQT4+chQ5zxrS4r9mfayPOC8yB0fD/pMMxq2V8is3rvrjBEVzpRl9ErAtpe+jei nIJIgPxIzIvawnh7zVMgWSWmJc5X2B1G/lflwX4PkXn6t1IzZNXLKyvuisXilaiiLfJO Fg4Hyb64YHx3SCOprwwZh8lBsC8119mTwdbPNPi9F1hP/WbMiY546sW9bouGhDsfjQon UKuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=1yomSR8/BY5xdqwyR44IUvx9dnKiCrIP5815QgnJSBQ=; b=rLLlVIcE6tkj9JkQCLI5LrJe4Q1ZgKhyIpIEtiSVABJWIDXKDfjbpePIgj9HLrQWFq QfXBUU1b3SmUYudZ+697M/sjJoXL9cLh2+JL1VbBS3NFyiCMUttg/R48fbLfGShAw4f1 LMGbbK5R9muKSRU1q3o+rb7C7kfyKY/WUiHphK9uqi1QQ5vYvje544r5/m/guAaTv9+D AXJ6uY2L4xAG0eTQCzpCyR5GR4BtHUNG68djSNMH3BxnynUVZelLeaI78rSxnA9jP19B 3EUJD7geC/H+EnWf7nJ6fGbkd8McPWVVNy0/DzSR/Jyaxt2+IEbF9na9FtjPz1Y8aCIj PkHQ== X-Gm-Message-State: APjAAAXq+w+kSRu331KYwb0AINPCbFIOMk+CoQ/A8IcsD+U1vlm2TlIJ BDT0YbaiRlhShtAlUc+bvJR0sA== X-Google-Smtp-Source: APXvYqwSmS3jJVGZrDZO4H0mOwQQEESpv/CM97VtfmryXqJbF2s1z22Cnj/ayaK0zZs8BuhDIz06Kw== X-Received: by 2002:a05:600c:10ce:: with SMTP id l14mr52490007wmd.118.1563635572616; Sat, 20 Jul 2019 08:12:52 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id y12sm12334964wru.30.2019.07.20.08.12.51 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 20 Jul 2019 08:12:51 -0700 (PDT) From: "Basil L. Contovounesios" To: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson Subject: Re: bug#35421: Also bind left image rotation key References: <874l6n7zsp.5.fsf@jidanni.org> <877e8ruwvy.fsf@mouse.gnus.org> <877e8rcl79.fsf@tcd.ie> <87sgr5y263.fsf@tcd.ie> <87ftn2lu9v.7.fsf@jidanni.org> Date: Sat, 20 Jul 2019 16:12:50 +0100 In-Reply-To: <87ftn2lu9v.7.fsf@jidanni.org> (=?utf-8?B?IuepjeS4ueWwvA==?= Dan Jacobson"'s message of "Fri, 19 Jul 2019 08:53:16 +0800") Message-ID: <87k1cc4u4t.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 35421-done@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35421 fixed close 35421 27.1 quit =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson writes: > OK but add to Docstring/Info: > To rotate (right) by 90, hit ... > To rotate (right) by 180, hit ... > To rotate (right) by 270, hit ... > As these are the most common tasks. That would be superfluous, as the documentation in the applied patch already explains how to rotate by multiples of 90 degrees interactively, and by an arbitrary angle from Lisp. So I'm closing this report as done. > (I'm most curious as to the recommended sequences the users should hit, > especially for 180. A rotation of 180 degrees is equivalent to two consecutive rotations of 90 degrees in either direction. In vanilla Emacs that corresponds to 'r r' or 'C-u r C-u r'. In custom Emacs it could be bound to any number of preferred keys. Thanks, --=20 Basil From unknown Sun Jun 22 08:03:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 18 Aug 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator