From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2019 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 35418@debbugs.gnu.org Cc: Michael Albinus X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155612971411274 (code B ref -1); Wed, 24 Apr 2019 18:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Apr 2019 18:15:14 +0000 Received: from localhost ([127.0.0.1]:56476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJMQM-0002vl-8t for submit@debbugs.gnu.org; Wed, 24 Apr 2019 14:15:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJMQI-0002vR-Sc for submit@debbugs.gnu.org; Wed, 24 Apr 2019 14:15:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:54519) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJMQD-0005GY-G3 for submit@debbugs.gnu.org; Wed, 24 Apr 2019 14:15:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJMQC-0000I8-8H for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 14:15:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJMQB-0005Ea-6E for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 14:15:04 -0400 Received: from mail171c50.megamailservers.eu ([91.136.10.181]:43848 helo=mail92c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJMQA-00054H-MJ for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 14:15:03 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556129688; bh=xSPxTb2h8gRW2JNuIR2Pe4XPhfOOzGScaT15CLECOn0=; h=From:Subject:Date:Cc:To:From; b=E2x8sWA+IjmnJD5GH96zhhUbvK7ymW5tFyXwPuo9LLm+KUw4YylAgncXzIEBNVoaV 5j60tulStgnGOTZfe2DgmQxDJfKaDFcR4efAw3WmJFKYRUZaFvPdZNSkQ/IHR9ziob oFoWQQXj3p2ykEK0+5bRwNkGXZ29WQ+7dNj/J+GA= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] ([188.150.171.71]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3OIEkmE016500; Wed, 24 Apr 2019 18:14:48 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_57AAFA11-7B25-4780-B710-1F8E608189CB" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Message-Id: Date: Wed, 24 Apr 2019 20:14:46 +0200 X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0214.5CC0A798.003B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=RrHr0huK c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=ONdRDGFD3O1zXpl4lkEA:9 a=D4b1L8H20t0ULcQ0:21 a=PXXmaejFQU7uZUuD:21 a=CjuIK1q_8ugA:10 a=UwLn2DouPOKXMJmAEYkA:9 a=B2y7HmGcmWMA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.10.181 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --Apple-Mail=_57AAFA11-7B25-4780-B710-1F8E608189CB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii It is a waste of power, on battery-powered devices in particular, to = poll files in auto-revert mode periodically when change notification is = used. The change is straightforward (attached patch); the main concern = is whether the notification system is reliable enough. In general, it probably is. There is a comment in w32notify.c about = SMB-mounted file systems from Samba servers; while Samba does support = notification nowadays, there are probably older systems still be = deficient in that regard. However, isn't this what = `auto-revert-notify-exclude-dir-regexp' is for? I'm not familiar with = the way Emacs is used on Windows, but would adding something like (rx bos (or "\\\\" "//") (one-or-more (not (any "/:\\"))) (any "/\\")) to `auto-revert-notify-exclude-dir-regexp' be a good start? Another note about what this patch does not do: global-auto-revert-mode = will still use polling. This could be added later on, if there is a good = place to hook into for buffer creation. --Apple-Mail=_57AAFA11-7B25-4780-B710-1F8E608189CB Content-Disposition: attachment; filename=0001-Don-t-poll-auto-revert-files-that-use-notification.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Don-t-poll-auto-revert-files-that-use-notification.patch" Content-Transfer-Encoding: quoted-printable =46rom=205074c65347736a716f335842206a1e2a2ad36a87=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Wed,=2024=20Apr=202019=2018:39:05=20+0200=0A= Subject:=20[PATCH]=20Don't=20poll=20auto-revert=20files=20that=20use=20= notification=0A=0AIt=20is=20a=20waste=20to=20periodically=20poll=20files=20= that=20use=20change=20notification=0Ain=20auto-revert=20mode;=20stop=20= doing=20that.=20=20If=20no=20files=20need=20polling,=0Aturn=20off=20the=20= periodic=20execution=20entirely=20to=20further=20avoid=20wasting=20= power.=0AUse=20a=20timer=20to=20inhibit=20immediate=20reversion=20for=20= some=20time=20after=20a=0Anotification.=0A=0AThis=20change=20does=20not=20= apply=20to=20files=20in=20global-auto-revert-mode,=20where=0Apolling=20= is=20still=20necessary.=0A=0A*=20lisp/autorevert.el=20= (auto-revert--polled-buffers):=20New.=0A= (auto-revert-remove-current-buffer,=20auto-revert-mode)=0A= (global-auto-revert-mode,=20auto-revert-set-timer)=0A= (auto-revert-notify-add-watch,=20auto-revert-buffers):=0AMaintain=20and=20= use=20auto-revert--polled-buffers.=0A(auto-revert-buffers-counter):=20= Remove.=0A(auto-revert-buffers-counter-lockedout):=20Remove.=0A= (auto-revert--lockout-interval):=20New.=0A(auto-revert--lockout-timer):=20= New.=0A(auto-revert-notify-handler):=20Maintain=20and=20use=20= auto-revert--polled-buffers.=0AHonour=20new=20lockout=20timer.=20=20= Start=20lockout=20timer=20if=20necessary.=0A(auto-revert--end-lockout):=20= New.=0A---=0A=20lisp/autorevert.el=20|=2084=20= +++++++++++++++++++++++++++++-----------------=0A=201=20file=20changed,=20= 53=20insertions(+),=2031=20deletions(-)=0A=0Adiff=20--git=20= a/lisp/autorevert.el=20b/lisp/autorevert.el=0Aindex=20= 1d20896c83..f7b33360ef=20100644=0A---=20a/lisp/autorevert.el=0A+++=20= b/lisp/autorevert.el=0A@@=20-319,6=20+319,11=20@@=20the=20list=20of=20= old=20buffers.")=0A=20(defvar=20auto-revert-tail-pos=200=0A=20=20=20= "Position=20of=20last=20known=20end=20of=20file.")=0A=20=0A+(defvar=20= auto-revert--polled-buffers=20()=0A+=20=20"List=20of=20buffers=20in=20= Auto-Revert=20Mode=20that=20must=20be=20polled.=0A+It=20contains=20the=20= buffers=20in=20`auto-revert-buffer-list'=20whose=0A= +`auto-revert-notify-watch-descriptor'=20is=20nil.")=0A+=0A=20(defun=20= auto-revert-find-file-function=20()=0A=20=20=20(setq-local=20= auto-revert-tail-pos=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (file-attribute-size=20(file-attributes=20buffer-file-name))))=0A@@=20= -346,8=20+351,12=20@@=20This=20has=20been=20reported=20by=20a=20file=20= notification=20event.")=0A=20(defun=20auto-revert-remove-current-buffer=20= (&optional=20buffer)=0A=20=20=20"Remove=20BUFFER=20from=20= `auto-revert-buffer-list'.=0A=20BUFFER=20defaults=20to=20= `current-buffer'."=0A+=20=20(unless=20buffer=0A+=20=20=20=20(setq=20= buffer=20(current-buffer)))=0A=20=20=20(setq=20auto-revert-buffer-list=0A= -=20=20=20=20=20=20=20=20(delq=20(or=20buffer=20(current-buffer))=20= auto-revert-buffer-list)))=0A+=20=20=20=20=20=20=20=20(delq=20buffer=20= auto-revert-buffer-list))=0A+=20=20(setq=20auto-revert--polled-buffers=0A= +=20=20=20=20=20=20=20=20(delq=20buffer=20auto-revert--polled-buffers)))=0A= =20=0A=20;;;###autoload=0A=20(define-minor-mode=20auto-revert-mode=0A@@=20= -367,6=20+376,7=20@@=20without=20being=20changed=20in=20the=20part=20= that=20is=20already=20in=20the=20buffer."=0A=20=20=20(if=20= auto-revert-mode=0A=20=20=20=20=20=20=20(when=20(not=20(memq=20= (current-buffer)=20auto-revert-buffer-list))=0A=20=20=20=20=20=20=20=20=20= (push=20(current-buffer)=20auto-revert-buffer-list)=0A+=20=20=20=20=20=20= =20=20(push=20(current-buffer)=20auto-revert--polled-buffers)=0A=20=20=20= =20=20=20=20=20=20(add-hook=0A=20=20=20=20=20=20=20=20=20=20= 'kill-buffer-hook=0A=20=20=20=20=20=20=20=20=20=20= #'auto-revert-remove-current-buffer=0A@@=20-479,7=20+489,8=20@@=20= specifies=20in=20the=20mode=20line."=0A=20=20=20=20=20=20=20= (auto-revert-buffers)=0A=20=20=20=20=20(dolist=20(buf=20(buffer-list))=0A= =20=20=20=20=20=20=20(with-current-buffer=20buf=0A-=09(when=20= auto-revert-notify-watch-descriptor=0A+=20=20=20=20=20=20=20=20(when=20= (and=20auto-revert-notify-watch-descriptor=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20(not=20(memq=20buf=20= auto-revert-buffer-list)))=0A=20=09=20=20= (auto-revert-notify-rm-watch))))))=0A=20=0A=20(defun=20= auto-revert-set-timer=20()=0A@@=20-492,7=20+503,7=20@@=20will=20use=20an=20= up-to-date=20value=20of=20`auto-revert-interval'"=0A=20=20=20(if=20= (timerp=20auto-revert-timer)=0A=20=20=20=20=20=20=20(cancel-timer=20= auto-revert-timer))=0A=20=20=20(setq=20auto-revert-timer=0A-=09(if=20(or=20= global-auto-revert-mode=20auto-revert-buffer-list)=0A+=09(if=20(or=20= global-auto-revert-mode=20auto-revert--polled-buffers)=0A=20=09=20=20=20=20= (run-with-timer=20auto-revert-interval=0A=20=09=09=09=20=20=20=20= auto-revert-interval=0A=20=09=09=09=20=20=20=20'auto-revert-buffers))))=0A= @@=20-551,6=20+562,8=20@@=20will=20use=20an=20up-to-date=20value=20of=20= `auto-revert-interval'"=0A=20=09=20=20=20=20=20=20=20(gethash=20= auto-revert-notify-watch-descriptor=0A=20=09=09=20=20=20=20=20=20=20=20= auto-revert--buffers-by-watch-descriptor))=0A=20=20=20=20=20=20=20=20=20=20= auto-revert--buffers-by-watch-descriptor)=0A+=20=20=20=20=20=20=20=20= (setq=20auto-revert--polled-buffers=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(delq=20(current-buffer)=20auto-revert--polled-buffers))=0A=20=20=20= =20=20=20=20=20=20(add-hook=20'kill-buffer-hook=20= #'auto-revert-notify-rm-watch=20nil=20t)))))=0A=20=0A=20;;=20If=20we=20= have=20file=20notifications,=20we=20want=20to=20update=20the=20= auto-revert=20buffers=0A@@=20-558,24=20+571,20=20@@=20will=20use=20an=20= up-to-date=20value=20of=20`auto-revert-interval'"=0A=20;;=20often,=20we=20= want=20to=20skip=20some=20revert=20operations=20so=20that=20we=20don't=20= spend=20all=20our=0A=20;;=20time=20reverting=20the=20buffer.=0A=20;;=0A= -;;=20We=20do=20this=20by=20reverting=20immediately=20in=20response=20to=20= the=20first=20in=20a=20flurry=20of=0A-;;=20notifications.=20We=20= suppress=20subsequent=20notifications=20until=20the=20next=20time=0A-;;=20= `auto-revert-buffers'=20is=20called=20(this=20happens=20on=20a=20timer=20= with=20a=20period=20set=20by=0A-;;=20`auto-revert-interval').=0A-(defvar=20= auto-revert-buffers-counter=201=0A-=20=20"Incremented=20each=20time=20= `auto-revert-buffers'=20is=20called")=0A-(defvar-local=20= auto-revert-buffers-counter-lockedout=200=0A-=20=20"Buffer-local=20value=20= to=20indicate=20whether=20we=20should=20immediately=0A-update=20the=20= buffer=20on=20a=20notification=20event=20or=20not.=20If=0A-=0A-=20=20(=3D=20= auto-revert-buffers-counter-lockedout=0A-=20=20=20=20=20= auto-revert-buffers-counter)=0A-=0A-then=20the=20updates=20are=20locked=20= out,=20and=20we=20wait=20until=20the=20next=20call=0A-of=20= `auto-revert-buffers'=20to=20revert=20the=20buffer.=20If=20no=20lockout=20= is=0A-present,=20then=20we=20revert=20immediately=20and=20set=20the=20= lockout,=20so=20that=0A-no=20more=20reverts=20are=20possible=20until=20= the=20next=20call=20of=0A-`auto-revert-buffers'")=0A+;;=20We=20do=20this=20= by=20reverting=20immediately=20in=20response=20to=20the=20first=20in=20a=0A= +;;=20flurry=20of=20notifications.=20Any=20notifications=20during=20the=20= following=0A+;;=20`auto-revert-lockout-interval'=20seconds=20are=20noted=20= but=20not=20acted=20upon=0A+;;=20until=20the=20end=20of=20that=20= interval.=0A+=0A+(defconst=20auto-revert--lockout-interval=202.5=0A+=20=20= "Duration,=20in=20seconds,=20of=20the=20Auto-Revert=20Mode=20= notification=20lockout.=0A+This=20is=20the=20quiescence=20after=20each=20= notification=20of=20a=20file=20being=0A+changed=20during=20which=20no=20= automatic=20reverting=20takes=20place,=20to=0A+prevent=20many=20updates=20= in=20rapid=20succession=20from=20overwhelming=20the=0A+system.")=0A+=0A= +(defvar-local=20auto-revert--lockout-timer=20nil=0A+=20=20"Timer=20= awaiting=20the=20end=20of=20the=20notification=20lockout=20interval,=20= or=20nil.")=0A=20=0A=20(defun=20auto-revert-notify-handler=20(event)=0A=20= =20=20"Handle=20an=20EVENT=20returned=20from=20file=20notification."=0A= @@=20-604,7=20+613,13=20@@=20no=20more=20reverts=20are=20possible=20= until=20the=20next=20call=20of=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(file-name-nondirectory=20= buffer-file-name)))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20;;=20A=20buffer=20w/o=20a=20file,=20like=20dired.=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(null=20= buffer-file-name))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (auto-revert-notify-rm-watch))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(auto-revert-notify-rm-watch)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(when=20(memq=20buffer=20auto-revert-buffer-list)=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(unless=20(memq=20buffer=20= auto-revert--polled-buffers)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(push=20buffer=20auto-revert--polled-buffers))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20Restart=20the=20= timer=20if=20it=20wasn't=20running.=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(unless=20auto-revert-timer=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(auto-revert-set-timer))))))=0A=20=0A= =20=20=20=20=20=20=20=20=20;;=20Loop=20over=20all=20buffers,=20in=20= order=20to=20find=20the=20intended=20one.=0A=20=20=20=20=20=20=20=20=20= (cl-dolist=20(buffer=20buffers)=0A@@=20-630,11=20+645,21=20@@=20no=20= more=20reverts=20are=20possible=20until=20the=20next=20call=20of=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(setq=20= auto-revert-notify-modified-p=20t)=0A=20=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20;;=20Revert=20the=20buffer=20now=20if=20we're=20not=20= locked=20out.=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20= (/=3D=20auto-revert-buffers-counter-lockedout=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffers-counter)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(unless=20auto-revert--lockout-timer=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(auto-revert-handler)=0A-=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(setq=20= auto-revert-buffers-counter-lockedout=0A-=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffers-counter))))))))))=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(setq=20auto-revert--lockout-timer=0A+=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(run-with-timer=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20auto-revert--lockout-interval=20nil=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20#'auto-revert--end-lockout=20= buffer)))))))))))=0A+=0A+(defun=20auto-revert--end-lockout=20(buffer)=0A= +=20=20"End=20the=20lockout=20period=20after=20a=20notification.=0A+If=20= the=20buffer=20needs=20to=20be=20reverted,=20do=20it=20now."=0A+=20=20= (when=20(buffer-live-p=20buffer)=0A+=20=20=20=20(with-current-buffer=20= buffer=0A+=20=20=20=20=20=20(setq=20auto-revert--lockout-timer=20nil)=0A= +=20=20=20=20=20=20(when=20auto-revert-notify-modified-p=0A+=20=20=20=20=20= =20=20=20(auto-revert-handler)))))=0A=20=0A=20(defun=20= auto-revert-active-p=20()=0A=20=20=20"Check=20if=20auto-revert=20is=20= active=20(in=20current=20buffer=20or=20globally)."=0A@@=20-755,13=20= +780,10=20@@=20This=20function=20is=20also=20responsible=20for=20= removing=20buffers=20no=20longer=20in=0A=20Auto-Revert=20Mode=20from=20= `auto-revert-buffer-list',=20and=20for=20canceling=0A=20the=20timer=20= when=20no=20buffers=20need=20to=20be=20checked."=0A=20=0A-=20=20(setq=20= auto-revert-buffers-counter=0A-=20=20=20=20=20=20=20=20(1+=20= auto-revert-buffers-counter))=0A-=0A=20=20=20(save-match-data=0A=20=20=20= =20=20(let=20((bufs=20(if=20global-auto-revert-mode=0A=20=09=09=20=20=20=20= (buffer-list)=0A-=09=09=20=20auto-revert-buffer-list))=0A+=09=09=20=20= auto-revert--polled-buffers))=0A=20=09=20=20remaining=20new)=0A=20=20=20=20= =20=20=20;;=20Buffers=20with=20remote=20contents=20shall=20be=20reverted=20= only=20if=20the=0A=20=20=20=20=20=20=20;;=20connection=20is=20= established=20already.=0A@@=20-811,7=20+833,7=20@@=20the=20timer=20when=20= no=20buffers=20need=20to=20be=20checked."=0A=20=20=20=20=20=20=20(setq=20= auto-revert-remaining-buffers=20bufs)=0A=20=20=20=20=20=20=20;;=20Check=20= if=20we=20should=20cancel=20the=20timer.=0A=20=20=20=20=20=20=20(when=20= (and=20(not=20global-auto-revert-mode)=0A-=09=09=20(null=20= auto-revert-buffer-list))=0A+=09=09=20(null=20= auto-revert--polled-buffers))=0A=20=20=20=20=20=20=20=20=20(if=20(timerp=20= auto-revert-timer)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= (cancel-timer=20auto-revert-timer))=0A=20=09(setq=20auto-revert-timer=20= nil)))))=0A--=20=0A2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_57AAFA11-7B25-4780-B710-1F8E608189CB-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2019 18:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: michael.albinus@gmx.de, 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155613231715273 (code B ref 35418); Wed, 24 Apr 2019 18:59:02 +0000 Received: (at 35418) by debbugs.gnu.org; 24 Apr 2019 18:58:37 +0000 Received: from localhost ([127.0.0.1]:56512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJN6L-0003yG-A3 for submit@debbugs.gnu.org; Wed, 24 Apr 2019 14:58:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJN6K-0003y4-FB for 35418@debbugs.gnu.org; Wed, 24 Apr 2019 14:58:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJN6E-0004NN-TI; Wed, 24 Apr 2019 14:58:30 -0400 Received: from [176.228.60.248] (port=3591 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hJN6B-00072i-52; Wed, 24 Apr 2019 14:58:29 -0400 Date: Wed, 24 Apr 2019 21:58:18 +0300 Message-Id: <83sgu71b91.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 24 Apr 2019 20:14:46 +0200) References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Wed, 24 Apr 2019 20:14:46 +0200 > Cc: Michael Albinus > > It is a waste of power, on battery-powered devices in particular, to poll files in auto-revert mode periodically when change notification is used. The change is straightforward (attached patch); the main concern is whether the notification system is reliable enough. The polling was added for a reason, and the reason was not reliability of the notifications. The reason is hinted upon in this comment: ;; If we have file notifications, we want to update the auto-revert buffers ;; immediately when a notification occurs. Since file updates can happen very ;; often, we want to skip some revert operations so that we don't spend all our ;; time reverting the buffer. ;; ;; We do this by reverting immediately in response to the first in a flurry of ;; notifications. We suppress subsequent notifications until the next time ;; `auto-revert-buffers' is called (this happens on a timer with a period set by ;; `auto-revert-interval'). If you look at bug reports and discussions around the time this comment was written, you will find the descriptions of the use cases that caused this design. AFAIR, the main problem was with inotify, not with w32notify. > In general, it probably is. There is a comment in w32notify.c about SMB-mounted file systems from Samba servers; while Samba does support notification nowadays, there are probably older systems still be deficient in that regard. However, isn't this what `auto-revert-notify-exclude-dir-regexp' is for? I'm not familiar with the way Emacs is used on Windows, but would adding something like > > (rx bos > (or "\\\\" "//") > (one-or-more (not (any "/:\\"))) > (any "/\\")) > > to `auto-revert-notify-exclude-dir-regexp' be a good start? If you imply that Samba drives can be identified by the syntax of the file name alone, then I don't think this is a valid assumption. A certain drive letter can be mapped to a Samba volume, and we can never know that by looking just at the file name. More generally, auto-revert-notify-exclude-dir-regexp is for any situation where a filesystem doesn't cause notifications. You will find caveats about such issues in the documentation of every notification system we support. Thanks. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2019 19:37:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155613459126957 (code B ref 35418); Wed, 24 Apr 2019 19:37:03 +0000 Received: (at 35418) by debbugs.gnu.org; 24 Apr 2019 19:36:31 +0000 Received: from localhost ([127.0.0.1]:56540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJNh0-00070i-Ru for submit@debbugs.gnu.org; Wed, 24 Apr 2019 15:36:31 -0400 Received: from mout.gmx.net ([212.227.17.22]:37361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJNgx-00070R-Bn for 35418@debbugs.gnu.org; Wed, 24 Apr 2019 15:36:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556134577; bh=seXLrxtzcgAxZMMGjYqx6hxw1GeXKaqVobDv49UoPnI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ToTt5BrnpNgu/JEk+ggKeImes+MQe3GeqoWI/eeRo3RCtu+RxphdrDkgTHVROPaVv c4C8kuvWWIJjOxo6Ul2qRaeEJboDIqDaC3Pdtq8wMZihjfEbx04n2JJHSoqiA6KaJY 6X9PHAS1YSHCAhvYbCEdc+pLWvri01qc73tszIpE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([213.220.159.187]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MRCOK-1h7L0v2ki4-00N7GK; Wed, 24 Apr 2019 21:36:17 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> Date: Wed, 24 Apr 2019 21:36:14 +0200 In-Reply-To: <83sgu71b91.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 24 Apr 2019 21:58:18 +0300") Message-ID: <87sgu79owh.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Yk2mPsBkutn0ppuBaw6nmjV8P6Ze+bAz18tH4dy9sxjUrX7I0XC NMB6rs458kMmO5vHC8pZMSgcr0W/aCpnIFC4ytcPqfhaHNC/T34JgyyJM+U8zrSpskqBcBg kUMnMoabY3niK3BSZrMkoUBidOaCr1UMLQAbJE1Wfc2BwIOefqoJY5/5oZ2guCAOSaM20AZ x4oJQ4/wDnD/aQ46rn6lQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:uUswr9wAAuY=:M8Fj0wnbwMAhAY20lhncfZ 3tL9uDvTHtcVYmek6yGPcIyb1+X5QUBEllCl3mj7Uu7MOFbfsh2mR+dkxXjAc9Fa9/uxdcXy6 yVWrEs8adHLbUdm4jeReE1KKXfYFHfGaxIW4uOsBO6Zg5Ts2/YWYgw0LvAPzMgNtQ2OYa5Ell c9F0X4NA1uPVxSMQ9VepilnYFir+FPoqcc/+qi5+zDiDO3vEktqQhUXJ9HgkQRi9HymnTQ2Ws q4EuhoqRdG0E8JU00GBWlBdJ1F0ijoIkjTQWJkwYno3I4mE882EIJeHM31A0x5/jCuZJmQu2V ZNUkJ20oRPeGoWHo8X0mV1+JjqN5KGspB+pvRyPSzD8T2QYONfZk8v0FPElk7zwE3TfDudogP rks18A7mFNhHCTo3SQUkmmVy6BUqw2AdZ6uQbIfKrLffy1ukpdwzhXNtdWh7RxUYDOcjLUwrv uDB58w4WlJZHh38kRSx3VHist5dPJ2rVMfS/eYW6B72rF/2YZ4MTOGAAOeBcA7o8dYkMIzvDS CDYL/4gyytsTkhqeFkjaz9Vq07EL/FmFjBK3ga29gJep03zAWkOjuObzzyr6PswAA0FIUFCwY PNmkblBRwFRNZswb0o2Xzny0k+li/H8M6BoRNTBcNlZzjW16hR8k7O6nQGeEW7hwzDm2WwPVP ao+GLfZeCId3gd0283oF0R9DrSA06Gw/ey1WZRtEcreMr1k/eLOmthO/GBzmyyiihhkOuEeEt 0u9qk5vaInZ2B+pACWrZdpTdr8em+57geatVzPwryW6Hcy1uTBHimkMubsJq3CaveSsNvumXg Ei/6B0Wro+GWuTWRnnGnpm0xa9/kz83fxsyQjmXkJAhaIqTJDQHHP36mHv3Weq/46Jec62pQT 1HsRxanQ5ydDxZ7VYutSLQ6gU5pNuFM8+T6UYTRmNvKRA1dvwReE09Ll/ooPF6bjfylvJ3jh2 uMpRBUk5wVw== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi, > If you look at bug reports and discussions around the time this > comment was written, you will find the descriptions of the use cases > that caused this design. AFAIR, the main problem was with inotify, > not with w32notify. Inotify didn't work on mounted directories. I don't know whether this has improved. Gfile is agnostic to file systems being mounted or not. If inotify (used internally) doesn't work, it uses polling. However, gfile has shown instability; that's why it isn't the first choice anymore. I don't remember the behavior of kqueue. >> However, isn't this what `auto-revert-notify-exclude-dir-regexp' is >> for? I'm not familiar with the way Emacs is used on Windows, but >> would adding something like >> >> (rx bos >> (or "\\\\" "//") >> (one-or-more (not (any "/:\\"))) >> (any "/\\")) >> >> to `auto-revert-notify-exclude-dir-regexp' be a good start? > > If you imply that Samba drives can be identified by the syntax of the > file name alone, then I don't think this is a valid assumption. A > certain drive letter can be mapped to a Samba volume, and we can never > know that by looking just at the file name. > > More generally, auto-revert-notify-exclude-dir-regexp is for any > situation where a filesystem doesn't cause notifications. You will > find caveats about such issues in the documentation of every > notification system we support. The default value of `auto-revert-notify-exclude-dir-regexp' tries to identify common mount points, like /mnt or /media and alike. But like Eli said already for Samba mounts, we cannot detect all of them by their name. What might be an alternative is to let the user decide. If we provide a user option `auto-revert-dont-poll', a user could set it to t, and would live with the consequences. If she tries to enable autorevert for a mounted directory, which is not covered by file notifications, she might be surprised. > Thanks. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2019 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155613596328949 (code B ref 35418); Wed, 24 Apr 2019 20:00:02 +0000 Received: (at 35418) by debbugs.gnu.org; 24 Apr 2019 19:59:23 +0000 Received: from localhost ([127.0.0.1]:56560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJO39-0007Wr-68 for submit@debbugs.gnu.org; Wed, 24 Apr 2019 15:59:23 -0400 Received: from mout.gmx.net ([212.227.17.21]:53351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJO37-0007Wc-Jk for 35418@debbugs.gnu.org; Wed, 24 Apr 2019 15:59:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556135952; bh=7bbLSif+ycXI9/WS9b8SzNiitcjhUstCuv6Di9G+7Zc=; h=X-UI-Sender-Class:From:Cc:Cc:Subject:References:Date:In-Reply-To; b=e8HbMW+JyJwDBKOlmyyr0zvJvXTaNZy2LO21RNT3QaVdJZgPIBZ1gsTH72VnRUPsh KbmPH9GK53suf86OYBBKIG7k6245dIhBYHC7Om/W5PRobJx1LnFm878q2R/TY+MwkH Yh5MfX998KRh5z+TEnbpQSjk1aBIl/nPMLxNzZPE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([213.220.159.187]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M8hZJ-1hO50T1JNx-004lJf; Wed, 24 Apr 2019 21:59:12 +0200 From: Michael Albinus References: Date: Wed, 24 Apr 2019 21:59:09 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Wed, 24 Apr 2019 20:14:46 +0200") Message-ID: <87imv3jhte.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:hsb1J0pCYh6urd0Sht3cOgOJzAF83IULfmjxW9PxL/QpSS5FgxQ HnlT5XboEDNTM8l7G2YE+/1VcbFU1UXuQCU1vEagNtQrX2he9/xN4+/J+7ipH+IzYDvOAAa Ujw0BzmflTwaWG8tQFtH2Y6EQ+varnJD/Dk/F9EGkqahvV1EvqQ5o2ojbngRp2B/ziavuUz /oyBEDXw2+H22HKZCVVJw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/qnYtXtd9cQ=:SSoNAnYF42H/CA1OU5txY0 w51GnEsE8Yu7fRjPkoG1AFtbZbghWSzbpEA48WROmN9HD/RMRWPgmonlnoXSAAHUd+rJ5S1mX vzXaBMjIVS46imhD9kkWo6CjSglOzwmuAAbxjaRpisFjUnXa9I/h6sZMJQBn6Y3wUX/9KoMr5 iSOs/IEMiVwBvnhaHDdDgzWXMQBS+eiPt6yPPtn6qPbAej3XEwlEPd60PQfZ2U94cSFeTrenS HKIe8w3hLwj+X8qIfMlnpxH1fHuJMBv25Bzz+Fg0+kUJ2j/H9N3ATD+JKnPCYM6tfjJkn8UGF 3YLMwH6mIB66kTSh6stv3iA0N58W4XrK9lRPpnFHGNtW6MvL8jIE5E/KVUXQo9Kcg3WDhAE/R 7pwzioOAL74CdYST+fWycXOUMKjN5ZBjLPRHPFPAS9g4CvhZcEuPw3RXWwHPxk0nn91h8tAb4 cIB03IuVQaYvsW+6I2UhB2nMY8RUjL3lNCIurxi94HLYZzfSVWgKsz1eMqZQ8tDz8P80wIkj0 hf+uebwi8YuKE26oEt8YcyNVwqGOJltqzOXOHSk8RQ1WPgHsVaN74j8MbA1r+stL4qbBO86N7 eHO7avAGvCEy5qk8LhgbkaBk4uaA/21fJJSy6fwpr1b/lkBT1MN+gxCgPdEUqUao3Qg/z+Efj 9+0Pj/dnY/cqRxYULAwiuHiN9LTTsoPm6FD0lzpMdSpOTUhlvwu45LKWRNx6hyV+6XxRp3tkA BUFMa+i4k8bGJJOtXxybTj+D6+szxgYHV3x1qrj6duV8qeeGxbxCX4/9B2+thKpVz5eqFp5jg XceniDbBRVel5lAiIXo7Ah337iwcj6oyspzek5w6NUmkAHjJwY1r6CH2w8zQqoK9bg2CpluUz 84AVxLojHJ4eyzOWpW2M82OsQ3UeHAcF8ZrS08wnOfYNv8gcfJJqxNOuurV610HtYnARZJpqe jZk6iozTpHw== X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= writes: > It is a waste of power, on battery-powered devices in particular, to > poll files in auto-revert mode periodically when change notification > is used. The change is straightforward (attached patch); [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.2 MISSING_HEADERS Missing To: header 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.21 listed in list.dnswl.org] 1.2 MALFORMED_FREEMAIL Bad headers on message from free email service X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Mattias Engdeg=C3=A5rd writes: > It is a waste of power, on battery-powered devices in particular, to > poll files in auto-revert mode periodically when change notification > is used. The change is straightforward (attached patch); the main > concern is whether the notification system is reliable enough. An alternative approach is discussed at : set auto-revert-interval to a very large value (like most-positive-fixnum). Sounds reasonable to me, if we adapt the documentation. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2019 09:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: michael.albinus@gmx.de, 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155618622716337 (code B ref 35418); Thu, 25 Apr 2019 09:58:02 +0000 Received: (at 35418) by debbugs.gnu.org; 25 Apr 2019 09:57:07 +0000 Received: from localhost ([127.0.0.1]:57488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJb7r-0004FR-Bb for submit@debbugs.gnu.org; Thu, 25 Apr 2019 05:57:07 -0400 Received: from mail76c50.megamailservers.eu ([91.136.10.86]:44396 helo=mail70c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJb7o-0004FG-FX for 35418@debbugs.gnu.org; Thu, 25 Apr 2019 05:57:06 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556186222; bh=jr6mFOfpCnHQ4JE8JJZ4EQXyEzK4R1DTnM612T8Jbjc=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=J63XfeaQLKPE5DD9phShEZ5ku7jMbkZvcxNmwIK/DPT/BNsJrfzIXD4vt0QDe7SIw UtKuGIyHkgy3AEE0zbOjKRUI+K9JtuJb2iZFb+Xxcnq5SzoR2d8y7ffzhhTdmI5yHj UYCNQfigl5+9ucDmisqZ7m6Qdf6h3oo00FDQdLE4= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] ([188.150.171.71]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3P9uxC2025975; Thu, 25 Apr 2019 09:57:01 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <83sgu71b91.fsf@gnu.org> Date: Thu, 25 Apr 2019 11:56:59 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> References: <83sgu71b91.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0215.5CC1846E.0026, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=XdenMrx5 c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=RZQY-mb0yVNJb3Z96m4A:9 a=GeH1N157bFKydk9D:21 a=h8emM1ep2tkE_pZm:21 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 24 apr. 2019 kl. 20.58 skrev Eli Zaretskii : >=20 > The polling was added for a reason, and the reason was not reliability > of the notifications. The reason is hinted upon in this comment: >=20 > ;; If we have file notifications, we want to update the auto-revert = buffers > ;; immediately when a notification occurs. Since file updates can = happen very > ;; often, we want to skip some revert operations so that we don't = spend all our > ;; time reverting the buffer. > ;; > ;; We do this by reverting immediately in response to the first in a = flurry of > ;; notifications. We suppress subsequent notifications until the next = time > ;; `auto-revert-buffers' is called (this happens on a timer with a = period set by > ;; `auto-revert-interval'). Thank you, interesting! In any case, that should not be a problem: the = patch takes care of it in a more principled way, by the means of a = timer. Currently, auto-revert is inhibited until next periodic poll, = which can be anything between 0 and 5 seconds away. The patch sets this = to a fixed value (2.5 s). > If you look at bug reports and discussions around the time this > comment was written, you will find the descriptions of the use cases > that caused this design. AFAIR, the main problem was with inotify, > not with w32notify. The inotify problems at the time seem to have stemmed from not using = unique notification descriptors. This was fixed some time ago = (158bb8555d etc, bug#26126). > If you imply that Samba drives can be identified by the syntax of the > file name alone, then I don't think this is a valid assumption. A > certain drive letter can be mapped to a Samba volume, and we can never > know that by looking just at the file name. Certainly, but the intent was to add something like the attempts to = identify network file systems on Unix machines: "^" (regexp-opt '("/afs/" "/media/" "/mnt" "/net/" "/tmp_mnt/")) If that regexp is acceptable as rough heuristics on Unix, surely = something like the regexp proposed, matching \\SOMETHING\, shouldn't be = out of the question on Windows? Full precision cannot be attained, as = you point out, but perhaps we can make life easier for the user. > More generally, auto-revert-notify-exclude-dir-regexp is for any > situation where a filesystem doesn't cause notifications. You will > find caveats about such issues in the documentation of every > notification system we support. Yes, that is my understanding as well. Are you arguing that the default = value of auto-revert-notify-exclude-dir-regexp should not be extended in = the proposed way, or that the variable is fundamentally incompatible = with the patch? From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2019 09:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155618631516478 (code B ref 35418); Thu, 25 Apr 2019 09:59:01 +0000 Received: (at 35418) by debbugs.gnu.org; 25 Apr 2019 09:58:35 +0000 Received: from localhost ([127.0.0.1]:57494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJb9G-0004Hh-Sn for submit@debbugs.gnu.org; Thu, 25 Apr 2019 05:58:35 -0400 Received: from mail79c50.megamailservers.eu ([91.136.10.89]:44980 helo=mail70c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJb9F-0004HY-8f for 35418@debbugs.gnu.org; Thu, 25 Apr 2019 05:58:33 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556186311; bh=p+BmseacV+Hc0loAiKVQWUsPSUpgYd1+97jHRzyzv3o=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=bn9e8dFKr8C2gV4PlAIrhE4Sli20izraZQhITfyOr2492eZkE7I07v1I1+EZIuHwg jVETYU5ZGcaUezaHXNSTjlrZXz4XQN1OS3FMo7xTCEhqD5CeSO+3toTi6V3ch5VYV+ kVsMl7bC0fZG5TSIRKPfkWIXo+j4D3BfMQeFDE6E= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] ([188.150.171.71]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3P9wUlf029149; Thu, 25 Apr 2019 09:58:31 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <87imv3jhte.fsf@gmx.de> Date: Thu, 25 Apr 2019 11:58:29 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <87imv3jhte.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0210.5CC184C7.008F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=XdenMrx5 c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=A5RuB-RWPg9Gixv2_6MA:9 a=CjuIK1q_8ugA:10 a=QqFNrm0a_HcA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 24 apr. 2019 kl. 21.59 skrev Michael Albinus : > > An alternative approach is discussed at : > set auto-revert-interval to a very large value (like most-positive-fixnum). Sorry, did you mean a different bug number? From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2019 10:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: michael.albinus@gmx.de, 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155618673317292 (code B ref 35418); Thu, 25 Apr 2019 10:06:02 +0000 Received: (at 35418) by debbugs.gnu.org; 25 Apr 2019 10:05:33 +0000 Received: from localhost ([127.0.0.1]:57531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJbG0-0004Uq-Pz for submit@debbugs.gnu.org; Thu, 25 Apr 2019 06:05:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJbFy-0004Ue-Ak for 35418@debbugs.gnu.org; Thu, 25 Apr 2019 06:05:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJbFq-0008KG-O5; Thu, 25 Apr 2019 06:05:23 -0400 Received: from [176.228.60.248] (port=3699 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hJbFm-0006vm-Id; Thu, 25 Apr 2019 06:05:20 -0400 Date: Thu, 25 Apr 2019 13:04:57 +0300 Message-Id: <83o94uz9h2.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Thu, 25 Apr 2019 11:56:59 +0200) References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Thu, 25 Apr 2019 11:56:59 +0200 > Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de > > > ;; If we have file notifications, we want to update the auto-revert buffers > > ;; immediately when a notification occurs. Since file updates can happen very > > ;; often, we want to skip some revert operations so that we don't spend all our > > ;; time reverting the buffer. > > ;; > > ;; We do this by reverting immediately in response to the first in a flurry of > > ;; notifications. We suppress subsequent notifications until the next time > > ;; `auto-revert-buffers' is called (this happens on a timer with a period set by > > ;; `auto-revert-interval'). > > Thank you, interesting! In any case, that should not be a problem: the patch takes care of it in a more principled way, by the means of a timer. Currently, auto-revert is inhibited until next periodic poll, which can be anything between 0 and 5 seconds away. The patch sets this to a fixed value (2.5 s). > > > If you look at bug reports and discussions around the time this > > comment was written, you will find the descriptions of the use cases > > that caused this design. AFAIR, the main problem was with inotify, > > not with w32notify. > > The inotify problems at the time seem to have stemmed from not using unique notification descriptors. This was fixed some time ago (158bb8555d etc, bug#26126). I'll let Michael decide on this. > "^" (regexp-opt '("/afs/" "/media/" "/mnt" "/net/" "/tmp_mnt/")) > > If that regexp is acceptable as rough heuristics on Unix, surely something like the regexp proposed, matching \\SOMETHING\, shouldn't be out of the question on Windows? Full precision cannot be attained, as you point out, but perhaps we can make life easier for the user. on Windows, SOMETHING is just the name of the machine which exports the drive, it can be anything. > Are you arguing that the default value of auto-revert-notify-exclude-dir-regexp should not be extended in the proposed way, or that the variable is fundamentally incompatible with the patch? I'm questioning the usefulness of extending the default value, yes. But I don't have strong views on that. Thanks. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2019 11:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155619029523148 (code B ref 35418); Thu, 25 Apr 2019 11:05:02 +0000 Received: (at 35418) by debbugs.gnu.org; 25 Apr 2019 11:04:55 +0000 Received: from localhost ([127.0.0.1]:57616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJcBT-00061I-4q for submit@debbugs.gnu.org; Thu, 25 Apr 2019 07:04:55 -0400 Received: from mout.gmx.net ([212.227.15.18]:42851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJcBR-000615-12 for 35418@debbugs.gnu.org; Thu, 25 Apr 2019 07:04:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556190284; bh=c0EhYV4tL7SIVEOSfdR+Tta5niKFHWrNHNgemepwoKg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=IGRrI6XZ/mG34TVdcG5G5L/OF+HeJXypg0jwpLyH7kYmMFMMPPrcG0kTqZnpTQ2Nj RR7AhDlRy+twz++jk4hDfJz00VFXf4YdstBFTNFgSc82FaQJJVbH/ByREbUvtgDrl6 mKMlbT+GGwEPIi94fHMR6TSHaZ7ZDFdkn6pCvpDs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.57.174]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MnakR-1gtw531ejd-00jXDp; Thu, 25 Apr 2019 13:04:44 +0200 From: Michael Albinus References: <87imv3jhte.fsf@gmx.de> Date: Thu, 25 Apr 2019 13:04:42 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Thu, 25 Apr 2019 11:58:29 +0200") Message-ID: <87y33y8hx1.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:0O4UrVftcgYOfhogP/Xd04VK/kJZ8/JnckU6Ur7Twg9EfJ5/IRS 7hQN38+o5MW4QR+EQyxHmlTgAoT76FLFvnLiZ3x2Il2RWyHd9GoMM8yfTC6qJVarmap5IQj OSfKnpjO+i08SRe4Mmz/3PP/eV5f+jdBHxPRwBGGeIuHuxZfR0kqeDi4x0sqgqsTo5TfUCt r8P25MvkeV+yJW9NQFiaA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:H4yRslqdL1g=:G+FLA7X3I3DsBz6Q+ZuqbH frbE0K33U71nRHGwixld4ipc6rOZULhVkHDMrFtw3D5gxqd7U+HEpnfTjZiFJxdwK8yIkOZbM fHPLsFm6jBXdnsDryOlPzq12DCs+e4nP9CVciJOXF3c2eHdkDk0uYKdbPmMZgMGJJOMhPKxqG XugVBmbYj3cBFzoDm24I4WcQDXsHB//3b5auscR5B1i8D2OUlRNHQrcAErNV6LHFj0qLPEj5m JDvjj1DOUaSg65yJJqgRnaVqP+4DaKOKeZVOEpkCvLdbe+A7I9TJXMoQhou64gkh7MHn+KLGE /jpoii3lGBHsofsSI0EaBV+iMYPBN25x3Pvns5zHjP3r3v0+ElqBSd2ljM7bT1kNJ4Buhaxz0 pBqwzu6EESmwBWNi2qAB956gLplD2alxI0aeWNlKuCys6rv9K4SD0LReFYHHTkJI+/0UbAYvr 0N7MgRRJRMJL360JLry/ZgWeaVxspW6328AIylJCySVKR3Sa4GcCjgwItrYX4qLUQZz+2P/C6 p8Hl9JH0TMzIyLtqO2CXlRF3hT3SnYBpv9S8BIS3KjqJxZAn8NDz/9E69aSEVsni72czcreh+ B/xHQ7GJlFSvOeAXxwdI365NPopmTnB9k7BOnvrcy3Fco/xNKb5rXSZosiQg1kHy0JkuawF6J HcMMUpjOE25sFW8r7LPv2tg+u/fwEo0JkWbA/aND5U6Y8xyqa/bnGtbDbKy1mzoxwF1A1S33e wTLZBJmXafmCFVUyjM4Y0sDB/uC35AmI0N6itCUxRciuASWlLkyM2xHN5RpFq9wPFih+Mhlkf gvxdnVMUTC5sG2fNBPErxa946YOCWN75TwNhxlIJ1rFErktuwj2fwvLik/K+8HUW1Rc1IyrfF Eo/+J2SFlTFlkDEAh5TD2sdbVHZK5YiEADJ0HSV/tM/90rjzcikkFYjfQ7mY6RZDXlwJ73RtP mXoSA/D+1aw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: >> An alternative approach is discussed at : >> set auto-revert-interval to a very large value (like most-positive-fixnu= m). > > Sorry, did you mean a different bug number? Oops, I meant . Cut'n'waste e= rror, while following Emacs Berlin meetup in parallel. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2019 15:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus , Eli Zaretskii Cc: 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155620575723449 (code B ref 35418); Thu, 25 Apr 2019 15:23:02 +0000 Received: (at 35418) by debbugs.gnu.org; 25 Apr 2019 15:22:37 +0000 Received: from localhost ([127.0.0.1]:59132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJgCo-000667-Ju for submit@debbugs.gnu.org; Thu, 25 Apr 2019 11:22:36 -0400 Received: from mail82c50.megamailservers.eu ([91.136.10.92]:49426 helo=mail18c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJgCj-00065u-LG for 35418@debbugs.gnu.org; Thu, 25 Apr 2019 11:22:31 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556205747; bh=YHdzw4sZ/dioa9fczRwP4gxxEzPCzLqghgvYDPVJRSo=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=gvbLXG1XxLyYLnfr9g+uilOLRNBNU4xrNFRqdOi9FtxX0ToDf0sqGKYu1wJDgKM0E v5ZbaALk+7oVv18OVC5I7DekmnKHR2kvXI9PQBlMhdtOcX2JCEe7hVlDDSJyDLmOJH nyaJ/vQWxGocprzfWMjsR/TIPrIxZQq0CaiwkG9c= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3PFMPJI000529; Thu, 25 Apr 2019 15:22:26 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <87y33y8hx1.fsf@gmx.de> Date: Thu, 25 Apr 2019 17:22:24 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <30583809-BD37-4B4B-90F4-3606376CFFFE@acm.org> References: <87imv3jhte.fsf@gmx.de> <87y33y8hx1.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0214.5CC1D0B3.0050, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=S7n3PrkP c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=Ye9q-bpsAAAA:8 a=vYhlkVNQsGsu2HkJKusA:9 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 25 apr. 2019 kl. 13.04 skrev Michael Albinus : >=20 > Oops, I meant . = Cut'n'waste error, while > following Emacs Berlin meetup in parallel. A most understandable error! Regarding the discussion you refer to, drastically raising = auto-revert-interval cannot be a practical solution in the general case, = nor was it likely proposed as such. Even with the patch, polling will be = used in many cases, including: filenotify failure (from running out of = file descriptors, for example); deleted file; and anything matching = auto-revert-notify-exclude-dir-regexp. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2019 18:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: michael.albinus@gmx.de, 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15562156686767 (code B ref 35418); Thu, 25 Apr 2019 18:08:02 +0000 Received: (at 35418) by debbugs.gnu.org; 25 Apr 2019 18:07:48 +0000 Received: from localhost ([127.0.0.1]:59288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJimh-0001l4-RE for submit@debbugs.gnu.org; Thu, 25 Apr 2019 14:07:48 -0400 Received: from mail151c50.megamailservers.eu ([91.136.10.161]:55556 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJime-0001ks-1V for 35418@debbugs.gnu.org; Thu, 25 Apr 2019 14:07:46 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556215661; bh=iQGlw9XkVwDUFQ3/OAwYuAqS4TmPq7Ki7rpddlFmbVk=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=lYTIWXs5TyqZ6xJjEPgKqcimBKkvPa1us6ZwSKrPi9srm8wfJmTGxsxiJRJEVG/ly Rl5i2GU/j5oSIaTmGoLcrp62xEOPSq08T5fCZQzkdzEKKoklq5cpV8iWqF6yk5WuT6 x9nVKUeQOLaKO2evzmvwnYBUYMqcOps73ag1D1y0= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3PI7d8r020112; Thu, 25 Apr 2019 18:07:41 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <83o94uz9h2.fsf@gnu.org> Date: Thu, 25 Apr 2019 20:07:38 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <885067B4-4575-4138-A4B4-961C28BBAFF1@acm.org> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0213.5CC1F76D.003C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=NJb7BXyg c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=9uTWOIZngPFdP2rHn14A:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 25 apr. 2019 kl. 12.04 skrev Eli Zaretskii : >=20 >> "^" (regexp-opt '("/afs/" "/media/" "/mnt" "/net/" "/tmp_mnt/")) >>=20 >> If that regexp is acceptable as rough heuristics on Unix, surely = something like the regexp proposed, matching \\SOMETHING\, shouldn't be = out of the question on Windows? Full precision cannot be attained, as = you point out, but perhaps we can make life easier for the user. >=20 > on Windows, SOMETHING is just the name of the machine which exports > the drive, it can be anything. Right, it's just a path to a file or directory on a mounted remote file = system. >> Are you arguing that the default value of = auto-revert-notify-exclude-dir-regexp should not be extended in the = proposed way, or that the variable is fundamentally incompatible with = the patch? >=20 > I'm questioning the usefulness of extending the default value, yes. > But I don't have strong views on that. Nor do I. It would avoid breaking auto-revert on some = non-auto-revert-capable remote file systems on Windows, at the cost of = increasing the auto-revert delay on some auto-revert-capable remote file = systems. The patch does not hinge on a change to the default value of that = variable. I forgot to mention that this patch should and will be accompanied by = appropriate NEWS and documentation updates, to be written. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Apr 2019 20:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15563116259511 (code B ref 35418); Fri, 26 Apr 2019 20:48:02 +0000 Received: (at 35418) by debbugs.gnu.org; 26 Apr 2019 20:47:05 +0000 Received: from localhost ([127.0.0.1]:33695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hK7kO-0002TL-Lp for submit@debbugs.gnu.org; Fri, 26 Apr 2019 16:47:04 -0400 Received: from mail222c50.megamailservers.eu ([91.136.10.232]:48994 helo=mail33c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hK7kL-0002Ss-H4 for 35418@debbugs.gnu.org; Fri, 26 Apr 2019 16:47:02 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556311619; bh=95IeSi07nU0Nzg6ZTepXWxewPltbVyG/etgkrC7amiA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=ZuJx7eXXxiBZkzqjVweqIlvjG53PlQcTiuceyeDj9ByxJJtE8CwWrf19Taq8qXZd5 1b9b/lFUPzD0q+60K9QaE5kCcqxS/c33cTNssVF71DMP/3Y2WEDnqHUa7TSz8t+C0N szF8HpFKkAFaO+YtF52xvWqXU7gbRVL2dicA+CV4= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3QKkuXk009303; Fri, 26 Apr 2019 20:46:58 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <87sgu79owh.fsf@gmx.de> Date: Fri, 26 Apr 2019 22:46:56 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <987B61DE-48D3-4618-8F0C-E53B794C6D71@acm.org> References: <83sgu71b91.fsf@gnu.org> <87sgu79owh.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0201.5CC36E43.0009, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Z4XC4kZA c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=MZEDwt6M1lC0RKFS8fIA:9 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 24 apr. 2019 kl. 21.36 skrev Michael Albinus : >=20 > Inotify didn't work on mounted directories. I don't know whether this > has improved. By 'work', do you mean receiving notification about changes made by the = same machine or another machine? As far as I know, the NFS protocol has = no means of propagating notifications, in contrast to SMB. > What might be an alternative is to let the user decide. If we provide = a > user option `auto-revert-dont-poll', a user could set it to t, and = would > live with the consequences. If she tries to enable autorevert for a > mounted directory, which is not covered by file notifications, she = might > be surprised. That is a possibility, although I'm generally not too fond of = user-adjustable behaviour of this sort. If I understand you right, you = propose that the default value should be 'always poll'? I would prefer the default to be 'avoid polling' -- I doubt that = malfunctions will be common or serious if they occur -- but I suppose it = is better than the status quo. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2019 09:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15563572682866 (code B ref 35418); Sat, 27 Apr 2019 09:28:01 +0000 Received: (at 35418) by debbugs.gnu.org; 27 Apr 2019 09:27:48 +0000 Received: from localhost ([127.0.0.1]:34317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKJcZ-0000k9-Ih for submit@debbugs.gnu.org; Sat, 27 Apr 2019 05:27:47 -0400 Received: from mout.gmx.net ([212.227.17.20]:52193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKJcV-0000jq-6H for 35418@debbugs.gnu.org; Sat, 27 Apr 2019 05:27:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556357252; bh=gQcXnJKAgtClj+/MJICdVC8TD1w82S7HooKKxn05A1c=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=UnTleEH11dnVo6jVGdCTXG424nkyahLE2oKIpQlPfUEmajVYsCG7txIbGiOxVu60f ten95OalVsm0/I8CNVhrp4ea8ABidkFsxk0n6DpcP8yADcmG4/hFz8tCTn65I14xfP ZNeQrK+7H9KYYbQTaQDM33PXPGITqhl7jMgPkNJ8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.57.174]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LnDof-1gr3oU3gjd-00hNYV; Sat, 27 Apr 2019 11:27:32 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> Date: Sat, 27 Apr 2019 11:27:30 +0200 In-Reply-To: <83o94uz9h2.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Apr 2019 13:04:57 +0300") Message-ID: <875zqzssql.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:rg2sQUCReaqa1hd1KR+9IedXPaCvO+9Ddw6Ojft3ANCaS++XDta pIpoJB/q6ukcEDt2s4hpUZy8HykvU7B+Ga3b5mnHtcwe7gm73dnqK1ZpmV/ua/T91cfczpV d87XXADAuz3eHustzqtMFyd8Iw1/L/eCt/fmxK1VHyNTpbTYlIe2WOlU/OtwvrUqos5Ynzv UcdXN1ub+/QG8QpRO9jUg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:nUmNYm9HdhM=:dpkkEnoIg0pdilcIGAHbfN x8DIsTSvxMpI7VtgTPFJsu9+jiciOF6sfVqT/MHNkobte8QJwqdt1NHZdnp/uBCy+tLJsHyq5 oztYxeU936c7z3Tg2/EJrhFK5kAgwSSihnr2nhqc17wojzUoSuX27z0rfkH3SZhW7AFDETzWs VvDMKMB2lWQpUoitAnxLVYH8C7YxsqXnDQJZ4xbGasRPvyBwLpp/x5YmWu17mQ8kWATU9L3sE hDiB9xITxYwHdZTbIBlQvg0JkcvnXsoSEDOFJP8gFxSipTZtAHJkCfl6GCQZhejco5D+j5/G5 sQgKhXvKudp9IiR5WkBpx+X3EfjedS9Gpj5d5jij42EAk7O1GGRgq/y1hO8dKBAh/kxT7C8wS eg3G8yKp+zSVn1hCNJCBrCZw/1vKqmxq/KHjIpnEbK1EgmS451z2bLoyx5Ct5EnYWt6QwMG9v /zSdz13cve3JmDG+NyTEKIZAAAuncWNhk6VX1n2s/oXGq8x0XOAymWlbtyZU48UrwaV/Z3FqP M9sJstN+RjaTq2WhA8wNdacqFwWpM/LpUWLGUgs16ZbCKA2EHVw2BH/wMt9Ju/mJDdkS6J40h dEQgCRcV2iNwvVlbGvrQdzzIvIsJSmD35aabXcn998p7E/IjtPHj/KYaDClmA8SSgatYsofLX RhN1XrVuS0y9fQFVByM5yOf/yUwhAxeAtqHVpPhoa7iTJd2gcMmVYJiqjKT317mXNhtEm7WNa iEJImyc71Ff5dcOfIZteTLrbjZJwUpUL2PjTndc/SU0uQXjKgOEEDqO3MYkFksC3QaZ6HSS10 QNXMBWwnK5ex6aKawyZzzTd6WRwpk30P4kC1S0+yRVreidJLmoZ5q2QXEawge5klVQA5yN9Ov M1OXoh692jqxvKHxIRqmU5sRbZdrnVvi0r6nc94JsSnyTNqQ8rtMhOCEP/DWB240GG3d0Pz6a uNikOqSDeIw== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi, >> > If you look at bug reports and discussions around the time this >> > comment was written, you will find the descriptions of the use cases >> > that caused this design. AFAIR, the main problem was with inotify, >> > not with w32notify. >> >> The inotify problems at the time seem to have stemmed from not using >> unique notification descriptors. This was fixed some time ago >> (158bb8555d etc, bug#26126). > > I'll let Michael decide on this. Well, in inotify you still get undesired notifications. Like this: =2D-8<---------------cut here---------------start------------->8--- (write-region "foo" nil "/tmp/foo") (add-name-to-file "/tmp/foo" "/tmp/bar" 'ok) (inotify-add-watch "/tmp/foo" t (lambda (event) (message "inotify %S" even= t))) =3D> (1 . 0) (inotify-add-watch "/tmp/bar" t (lambda (event) (message "inotify %S" even= t))) =3D> (1 . 1) (write-region "foo" nil "/tmp/foo") =3D> inotify ((1 . 0) (modify) "/tmp/foo" 0) inotify ((1 . 1) (modify) "/tmp/bar" 0) inotify ((1 . 0) (open) "/tmp/foo" 0) inotify ((1 . 1) (open) "/tmp/bar" 0) inotify ((1 . 0) (modify) "/tmp/foo" 0) inotify ((1 . 1) (modify) "/tmp/bar" 0) inotify ((1 . 0) (close-write) "/tmp/foo" 0) inotify ((1 . 1) (close-write) "/tmp/bar" 0) =2D-8<---------------cut here---------------end--------------->8--- However, in filenotify this is fixed: =2D-8<---------------cut here---------------start------------->8--- (file-notify-add-watch "/tmp/foo" '(change attribute-change) (lambda (event) (message "file-notify %S" event))) =3D> (2 . 0) (file-notify-add-watch "/tmp/bar" '(change attribute-change) (lambda (event) (message "file-notify %S" event))) =3D> (2 . 1) (write-region "foo" nil "/tmp/foo") =3D> file-notify ((2 . 0) changed "/tmp/foo") inotify ((1 . 0) (modify) "/tmp/foo" 0) inotify ((1 . 1) (modify) "/tmp/bar" 0) inotify ((1 . 0) (open) "/tmp/foo" 0) inotify ((1 . 1) (open) "/tmp/bar" 0) file-notify ((2 . 0) changed "/tmp/foo") inotify ((1 . 0) (modify) "/tmp/foo" 0) inotify ((1 . 1) (modify) "/tmp/bar" 0) inotify ((1 . 0) (close-write) "/tmp/foo" 0) inotify ((1 . 1) (close-write) "/tmp/bar" 0) =2D-8<---------------cut here---------------end--------------->8--- Unrelated events for "/tmp/bar" are filtered out in `file-notify-callback'. So yes, the inotify problems seem to be fixed. >> Are you arguing that the default value of >> auto-revert-notify-exclude-dir-regexp should not be extended in the >> proposed way, or that the variable is fundamentally incompatible >> with the patch? > > I'm questioning the usefulness of extending the default value, yes. > But I don't have strong views on that. We might extend this variable. *If* this regexp matches a file name, we know that we need polling. But it is clear, that we cannot catch all cases by just parsing file names. (Btw, we should use the value of `mounted-file-systems', introduced in Emacs 26.1, when initializing `auto-revert-notify-exclude-dir-regexp'.) One alternative approach could be to analyze the file system device number, as returned by `file-attributes'. By this, we could detect mounted file systems. But I don't believe that this information is always trustworty, given it isn't used anywhere. And at least for remote files it doesn't tell you anything. Furthermore, mounted file systems are not the only reason that file notification doesn't work, and we need to poll. > Thanks. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2019 09:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15563580504784 (code B ref 35418); Sat, 27 Apr 2019 09:41:01 +0000 Received: (at 35418) by debbugs.gnu.org; 27 Apr 2019 09:40:50 +0000 Received: from localhost ([127.0.0.1]:34466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKJpC-0001F6-9a for submit@debbugs.gnu.org; Sat, 27 Apr 2019 05:40:50 -0400 Received: from mout.gmx.net ([212.227.15.15]:41523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKJpA-0001Er-QX for 35418@debbugs.gnu.org; Sat, 27 Apr 2019 05:40:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556358039; bh=WyZ8QPEbA6l8X1DjCmGtvLLa9YgMmhZ80J6gHZICDnI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=CorawJJU+A2rE85byZyMzwnRVU7tKoF6U4RvwgIZNJwx6v+RZgWJpvEjfMwbCH8q9 jXjJzaTkytxZXHRq+jrJ5o23tYyZ0AHbS3B52rHRydwjUPwOYLCfGOTiTQtvJpvOyK RQL1JkZf0Ju+j73Lztnrj5B5ZddKinmS5OA9XRq4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.57.174]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MFKKh-1hZz1421gP-00FkXg; Sat, 27 Apr 2019 11:40:39 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <87sgu79owh.fsf@gmx.de> <987B61DE-48D3-4618-8F0C-E53B794C6D71@acm.org> Date: Sat, 27 Apr 2019 11:40:23 +0200 In-Reply-To: <987B61DE-48D3-4618-8F0C-E53B794C6D71@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Fri, 26 Apr 2019 22:46:56 +0200") Message-ID: <871s1nss54.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:FZdLFV0QtZkG2ZLf6OpJ9b5Vh0PXlafGwnY1VEQg+ht/JwnBNGI JP+k47MDoboOHpoTgccDFWBp+6+OT9FNJukt3G75lu//XZjFO9F8CSeH6r1ScYBRDAeGabo P7ogeBu8QwM0QCHy7drl0pfw3edJfY4bhdbWQYLTUAh7E4MgiJSsEGO0JjF0dk2QdjBV6O5 YK7pBwayxaCTRW3Hwcu+w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Adim8lkqLVM=:iMnBrhRkdS/DxP1nmPZHrw DttOvyMTrpsklrt+05Fy2xpYiHGVYBBC0z7V/hA0PXL0HLblHLQ9W8911hF5Zbd69YxCgFOV1 sIFAhEyLN3/rMez6za/5KD7RsdamvMmhf+tfUQNVQ6cngFJhPbgXdku19uiikRCVSpdu79jsn Hr3DtR9vv0uY0uhaYK2lanUJg5ojA6b8HIHP9Af6JQbSdOHu/0fkdDVrIreotw6JoHbU8HTV9 vn+x8DyMr58OEk4lOIn+79+pgeGB7L9tjyph5Hau/mu8QKMQNE05jVSuQCdPR4xOIGS/xyaqp j7FUEi/webRZ9ymDC3QFZi29fx772vyuYiYhvHRppdcLEdsMmyzUYRwWeytxzuFNjsLpvqod+ xnFkbLGf32KPUOm65fxUFJHnqJbKWiyD0KoCkx4mN1gQFsokvMEYpulzRx1oryEGJXfUqJidI mbFtMI6BOlZCPTSuKJ6BxH1vRV2173gieyuR0YVCewzudblypQbLVNfKzPF3dMPr06EeVwnWK l+YiMiC7g4ZsHEi6RkU55lpYZROXgpGAD86+eEgvPZR5XnUTUm84C/pvVowH7MYVFuyNg5Oxe 3b2bqtVj+ICjfqq2lQtaK4HWrBjhzUa5zEmpoY+YDnsg97C8aneQu5lhByjhN3We9zAmuMWOt vC7pEeFXV4hsyINtN58anFCE2SYeB2BINtgy+68nt8ZuzZjh40AITkc+JaB+m2V99PCPZi16f D8/8JBwynPD7KMD3d3W4YXSYMVcluvdrfd4bhDAK9B2KFu0nvctTLxiDF8Q96OZU6vXx+OiXl j26XhW9ZyosGAEetvd8+YLBD5GFq05z9QNWQYqo427WmunqOGuFadOpItmnTQW0HNvzlgSEh4 1OrqcsiqwLyqvcPbAo6QbzUGsyXGTkFG59eREIsVQUKxAt9QWqQx0fGiN7bpCpUQYqOPWByQs GRAPwlN/IXQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: >> Inotify didn't work on mounted directories. I don't know whether this >> has improved. > > By 'work', do you mean receiving notification about changes made by > the same machine or another machine? As far as I know, the NFS > protocol has no means of propagating notifications, in contrast to > SMB. It fires notifications for changes made by the same machine: --8<---------------cut here---------------start------------->8--- ;; "/net/ford/albinus" is a mounted directory. (write-region "foo" nil "/net/ford/albinus/tmp/foo") (inotify-add-watch "/net/ford/albinus/tmp/foo" t (lambda (event) (message "inotify %S" event))) =3D> (3 . 0) (write-region "foo" nil "/net/ford/albinus/tmp/foo") =3D> inotify ((3 . 0) (modify) "/net/ford/albinus/tmp/foo" 0) inotify ((3 . 0) (open) "/net/ford/albinus/tmp/foo" 0) inotify ((3 . 0) (modify) "/net/ford/albinus/tmp/foo" 0) inotify ((3 . 0) (close-write) "/net/ford/albinus/tmp/foo" 0) --8<---------------cut here---------------end--------------->8--- If I make a modification on the remote machine, nothing happens: --8<---------------cut here---------------start------------->8--- ;; Remote "/ssh:ford:/share/albinus" is the same as local "/net/ford/albinu= s". (write-region "foo" nil "/ssh:ford:/share/albinus/tmp/foo") --8<---------------cut here---------------end--------------->8--- >> What might be an alternative is to let the user decide. If we provide a >> user option `auto-revert-dont-poll', a user could set it to t, and would >> live with the consequences. If she tries to enable autorevert for a >> mounted directory, which is not covered by file notifications, she might >> be surprised. > > That is a possibility, although I'm generally not too fond of > user-adjustable behaviour of this sort. If I understand you right, you > propose that the default value should be 'always poll'? The policy in Emacs is to set the default value to be compatible with previous behavior. If time passes, and we see no drawback, the default value could be changed. Usually, the next major E,acs version . > I would prefer the default to be 'avoid polling' -- I doubt that > malfunctions will be common or serious if they occur -- but I suppose > it is better than the status quo. Yes. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2019 09:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: mattiase@acm.org, 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15563588746007 (code B ref 35418); Sat, 27 Apr 2019 09:55:02 +0000 Received: (at 35418) by debbugs.gnu.org; 27 Apr 2019 09:54:34 +0000 Received: from localhost ([127.0.0.1]:34490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKK2T-0001Yp-Rt for submit@debbugs.gnu.org; Sat, 27 Apr 2019 05:54:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKK2S-0001Yd-8u for 35418@debbugs.gnu.org; Sat, 27 Apr 2019 05:54:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKK2M-00068x-QT; Sat, 27 Apr 2019 05:54:26 -0400 Received: from [176.228.60.248] (port=2373 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hKK2M-00045l-6j; Sat, 27 Apr 2019 05:54:26 -0400 Date: Sat, 27 Apr 2019 12:54:12 +0300 Message-Id: <83zhobvkmz.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <875zqzssql.fsf@gmx.de> (message from Michael Albinus on Sat, 27 Apr 2019 11:27:30 +0200) References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: Mattias Engdeg�rd , > 35418@debbugs.gnu.org > Date: Sat, 27 Apr 2019 11:27:30 +0200 > > One alternative approach could be to analyze the file system device > number, as returned by `file-attributes'. By this, we could detect > mounted file systems. Only on Posix systems, right? From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2019 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: mattiase@acm.org, 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15563606368833 (code B ref 35418); Sat, 27 Apr 2019 10:24:02 +0000 Received: (at 35418) by debbugs.gnu.org; 27 Apr 2019 10:23:56 +0000 Received: from localhost ([127.0.0.1]:34546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKKUu-0002IP-7h for submit@debbugs.gnu.org; Sat, 27 Apr 2019 06:23:56 -0400 Received: from mout.gmx.net ([212.227.15.15]:47681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKKUs-0002I9-6X for 35418@debbugs.gnu.org; Sat, 27 Apr 2019 06:23:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556360624; bh=8Aavgl4veypTjwDX9jOLgjjWpJ/a0TW8veL++psDYzo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=GA1S5hlreE5sMFdUgniHWRxCn9K/Cf0MT48uwqN+7PaEZUDgjxnMbVw8gMqs1aDbh Eu9Sq8uls01vAyNh/NowpQYwzRqdqqq82+FZQB9LXDlRj/XCqy63blAgKIFmPPC90H YrYjzjKWuqNamnqol67e1pjUJfo14HCDI8CHQsFQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.57.174]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lm3H7-1glXhx0AxF-00Zg8s; Sat, 27 Apr 2019 12:23:44 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83zhobvkmz.fsf@gnu.org> Date: Sat, 27 Apr 2019 12:23:39 +0200 In-Reply-To: <83zhobvkmz.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Apr 2019 12:54:12 +0300") Message-ID: <87sgu3rbkk.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:7w6TtP0aT0FcCTYFgq16Je262O44qVdXTXfhWAQ5LdtCIc7DhDy DGVa2Q/MSEP3kKcTG9WL/JqOLuPIlSspiDoX+wHwxnj2rObDsTHPdiThKjvW4uEBsoy8WR/ 8HhGfUb2uQfb5JejJzdoSv7pQEqrmTzkABqvXYW+EQdzzPmUHkB9UXu/btzIKO/ICflj0bv bt5mkoweCEnTi8sWx59UA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:yguBf5ijvmQ=:sDBG6zIk/r3beyFbtA7Tyh UaE824kUc/BrfFvX655p2EX0A8575OtoRrT1dkXTCIzS2pyg1BgGUK1ne3Lb/vjAjxqa2xiYL BklpzeuLnJmD009qFFBVUjUtOEPCy6ZrGShMXuAnrqrP31MxY34f7uv3oT/32/c6uuJrbhoK0 SDXuIAs2py6tVRNUL9kIwcyDmWx90OaUuI3R8XY0dG53yIcKyFsjN611f7HtZjcVl2vCQmfoJ Ss0lg6wkxGp+elD0ljflHwmjDQtwwG9f5fuhWgKGlep0OdVR+ilhoJGSSYhC7B6D6UTfIx7H5 +aQUw+1+7NPNvbuAvRfxYfEaMwYo2Rxm5lLowMaP6ZabTkUtICdGEcxIL2QC3ikElUipGcmxw 5kez1A9dgGkk794QogsvoVgh9TQ+IJIKpVAfZquhDVAoA0Pk045xle+P9TKnduz2izT/O1A+d MqP7KkfmSRq3m4Zyn2Ni5IN2xIM33cpmQQGfuK+IWY5kZo3rdfv1VOnPMTN8OOV2ctVV3+7qU Za8TObkyfgQKlMcR/p9fNOnl9LtH6rc+NRutm0yow1gh8f4m/2h8Kq8lsI7XwmVBMeVCDD78Y xF8dAgs1ruzTEY9wiNTrZU0FaBaT1tw5z3N9kZoN9kr5q8hIvBtzDAqyaEJwO88dR15AGkdjH BXPy9U+5RZqFxvqfWBqm2xoMOD1a/OZ7i9w5Q3MiyQarxhAEpo1Ae+2PM5Nhx794pnPKNtEgG zq8pg4fyw1hek1Phni1s0jHnxnUn1sNwXlRqZos0Jcdpx3+B0o8A03DpxPB2Y9yx8m37gk3b+ Y68JbODrWkwqAANQV3XARE9Lijr4bqto2geXgvtvmeAA0FEB3Lrf/dGKNq5paPGHXvq68I4HT 4km7aFusQVK2m/Jp8rDKMhwTb+SHwAupZ9sFnaEfXbTQPYUhQ1nn/iM2fxU21xediTYbt+Vr+ jGulcfQAQHA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi Eli, >> One alternative approach could be to analyze the file system device >> number, as returned by `file-attributes'. By this, we could detect >> mounted file systems. > > Only on Posix systems, right? Don't know. I haven't used the device number ever myself. And in Tramp, I set it to a virtual value which is distinct from values used for local file systems, or from values from other remote connections, w/o any further checking. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2019 16:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155638198427977 (code B ref 35418); Sat, 27 Apr 2019 16:20:01 +0000 Received: (at 35418) by debbugs.gnu.org; 27 Apr 2019 16:19:44 +0000 Received: from localhost ([127.0.0.1]:35832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKQ3D-0007HB-P4 for submit@debbugs.gnu.org; Sat, 27 Apr 2019 12:19:44 -0400 Received: from mail156c50.megamailservers.eu ([91.136.10.166]:32782 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKQ3A-0007H0-Rl for 35418@debbugs.gnu.org; Sat, 27 Apr 2019 12:19:41 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556381978; bh=Xw1b1qpJPC2iIsONrhrPe6tQ14K3ncHuNRnQXj2KBWY=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=mhmrQq3PXaFIls3izW9IOsW5alwB8fYAS/Jw8K1FuvnQXm+uvKi4gyncv6YrgsDhR rbbgDozEICYiSZHB5YAZiPB2HLnG1q4Q4tfE+NWPb89+NUAu0AFTLk4UneMjZMJXwm WKXf+ML6lSubGvilX6fmNAo3r7tjDwve4nTWW6Yg= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3RGJaN1001772; Sat, 27 Apr 2019 16:19:38 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <875zqzssql.fsf@gmx.de> Date: Sat, 27 Apr 2019 18:19:36 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B020B.5CC4811A.0025, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=NqD/jfVJ c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=f289YO8E5LQ18tp_bgsA:9 a=7LxUVfY0szrN1Za1:21 a=wcZv7zFZoprkOq0x:21 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 27 apr. 2019 kl. 11.27 skrev Michael Albinus : >=20 > Well, in inotify you still get undesired notifications. Like this: >=20 > --8<---------------cut here---------------start------------->8--- > (write-region "foo" nil "/tmp/foo") > (add-name-to-file "/tmp/foo" "/tmp/bar" 'ok) >=20 > (inotify-add-watch "/tmp/foo" t (lambda (event) (message "inotify %S" = event))) > =3D> (1 . 0) > (inotify-add-watch "/tmp/bar" t (lambda (event) (message "inotify %S" = event))) > =3D> (1 . 1) > (write-region "foo" nil "/tmp/foo") > =3D> inotify ((1 . 0) (modify) "/tmp/foo" 0) > inotify ((1 . 1) (modify) "/tmp/bar" 0) Thanks for the example! I wouldn't call this undesired. Create a hard link to a file, ask for = notification on both links, and then modify the file. Then both = notifiers trigger, because someone has modified the file they were = watching. The kqueue back-end behaves similarly. > However, in filenotify this is fixed: >=20 > --8<---------------cut here---------------start------------->8--- > (file-notify-add-watch "/tmp/foo" '(change attribute-change) > (lambda (event) (message "file-notify %S" = event))) > =3D> (2 . 0) > (file-notify-add-watch "/tmp/bar" '(change attribute-change) > (lambda (event) (message "file-notify %S" = event))) > =3D> (2 . 1) > (write-region "foo" nil "/tmp/foo") > =3D> file-notify ((2 . 0) changed "/tmp/foo") > inotify ((1 . 0) (modify) "/tmp/foo" 0) > inotify ((1 . 1) (modify) "/tmp/bar" 0) Actually, it is (arguably) a bug. With two buffers referring to distinct = hard links for the same file, surely we want a change in that file to = trigger notification for both! (It's quite an exotic case, not the least = because Emacs normally recognises hard links as if they were the same = file name.) However, with the kqueue back-end, file-notify watches do trigger for = both, as expected. The reason is that file-notify does not call inotify-add-watch on = individual files, as in your example above, but on their containing = directory ("/tmp" in your example). When monitoring a directory with two = hard links to the same file, and the file is changed, inotify (sensibly) = only reports a change to one of the links (the one employed for the = change). Thus, the logic is in the Linux kernel, not in filenotify. For kqueue it is different: here, changes to files are not reported when = a watch is monitoring their directory, so filenotify.el sets kqueue = watches on each file instead. The same could be done with inotify (and = w32notify, if I read the code right), but watching directories has = certain advantages. > Unrelated events for "/tmp/bar" are filtered out in > `file-notify-callback'. So yes, the inotify problems seem to be fixed. Are you really sure that the inotify problems were really about changes = to files with multiple hard links? It sounds very unlikely, and as = showed above, the behaviour differs between back-ends. If I were to guess, the problem was rather that the inotify back-end = used to return the kernel-provided descriptor number, which is the same = for the same directory: when /dir/a and /dir/b (distinct files, not hard = links) both were watched, inotify would monitor /dir twice and give the = same descriptor for both, with the ensuing chaos. This was subsequently = fixed by making inotify return unique descriptors. > We might extend this variable. *If* this regexp matches a file name, = we > know that we need polling. But it is clear, that we cannot catch all > cases by just parsing file names. >=20 > (Btw, we should use the value of `mounted-file-systems', introduced in > Emacs 26.1, when initializing = `auto-revert-notify-exclude-dir-regexp'.) That variable contains "^//[^/]+/" on Windows, so we need to make up our = minds about it. > One alternative approach could be to analyze the file system device > number, as returned by `file-attributes'. By this, we could detect > mounted file systems. Sort of; the interpretation is tricky, and as Eli commented, quite = platform-specific. > But I don't believe that this information is always trustworty, given = it > isn't used anywhere. And at least for remote files it doesn't tell you > anything. Furthermore, mounted file systems are not the only reason = that > file notification doesn't work, and we need to poll. What other reasons are you thinking about? From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2019 16:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155638252528857 (code B ref 35418); Sat, 27 Apr 2019 16:29:01 +0000 Received: (at 35418) by debbugs.gnu.org; 27 Apr 2019 16:28:45 +0000 Received: from localhost ([127.0.0.1]:35850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKQBw-0007VN-Ks for submit@debbugs.gnu.org; Sat, 27 Apr 2019 12:28:44 -0400 Received: from mail80c50.megamailservers.eu ([91.136.10.90]:38768 helo=mail70c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKQBu-0007VC-7X for 35418@debbugs.gnu.org; Sat, 27 Apr 2019 12:28:43 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556382520; bh=w5qCvqVf330FQ7ZFWS1h7za1XEA33ER86jHm/2xgeKA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=NBNZRhLgliQHA5AwO9x4R7fQ05ZPI2yudo1uVVsbN25CHiljI1FEBBjzYLD8ABWEG POtDWSVaCwd1BCOYxACsLzl2IpFqK9PM/gHwSTsQRTSs2UFAR890/E7Gr7wllwoQ7u 7fp6LSwE+88tC7tdu3Vklap/BTmjecOJ/sSwHbnY= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3RGScom024639; Sat, 27 Apr 2019 16:28:39 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <871s1nss54.fsf@gmx.de> Date: Sat, 27 Apr 2019 18:28:38 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <9882A29F-6830-4C7B-918D-DADC4DA62972@acm.org> References: <83sgu71b91.fsf@gnu.org> <87sgu79owh.fsf@gmx.de> <987B61DE-48D3-4618-8F0C-E53B794C6D71@acm.org> <871s1nss54.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0211.5CC48338.002A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=XdenMrx5 c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=QOgP5k3nHiY4v3ZJHWgA:9 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 27 apr. 2019 kl. 11.40 skrev Michael Albinus : >=20 >> By 'work', do you mean receiving notification about changes made by >> the same machine or another machine? As far as I know, the NFS >> protocol has no means of propagating notifications, in contrast to >> SMB. >=20 > It fires notifications for changes made by the same machine: [...] > If I make a modification on the remote machine, nothing happens: Thank you for confirming that. The current state of remote notifications = on Linux seems to be: - could possibly be added to cifs in the future - no explicit support in NFS but could possibly use NFS v4.1 directory = delegations - either requires VFS-level support - no work in progress as far as I can tell > The policy in Emacs is to set the default value to be compatible with > previous behavior. If time passes, and we see no drawback, the default > value could be changed. Usually, the next major E,acs version . A most sensible policy, although reality isn't always black or white -- = sometimes, a useful change outweighs a minor incompatibility. Thanks again, I'll prepare a new patch with a defcustom. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2019 16:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155638399831589 (code B ref 35418); Sat, 27 Apr 2019 16:54:02 +0000 Received: (at 35418) by debbugs.gnu.org; 27 Apr 2019 16:53:18 +0000 Received: from localhost ([127.0.0.1]:35906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKQZh-0008DR-O9 for submit@debbugs.gnu.org; Sat, 27 Apr 2019 12:53:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKQZg-0008DD-1T for 35418@debbugs.gnu.org; Sat, 27 Apr 2019 12:53:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKQZa-0005Cw-MJ; Sat, 27 Apr 2019 12:53:10 -0400 Received: from [176.228.60.248] (port=4847 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hKQZZ-0007AZ-JN; Sat, 27 Apr 2019 12:53:10 -0400 Date: Sat, 27 Apr 2019 19:52:56 +0300 Message-Id: <83d0l7v193.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sat, 27 Apr 2019 18:19:36 +0200) References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Sat, 27 Apr 2019 18:19:36 +0200 > Cc: Eli Zaretskii , 35418@debbugs.gnu.org > > The reason is that file-notify does not call inotify-add-watch on individual files, as in your example above, but on their containing directory ("/tmp" in your example). When monitoring a directory with two hard links to the same file, and the file is changed, inotify (sensibly) only reports a change to one of the links (the one employed for the change). Thus, the logic is in the Linux kernel, not in filenotify. > > For kqueue it is different: here, changes to files are not reported when a watch is monitoring their directory, so filenotify.el sets kqueue watches on each file instead. The same could be done with inotify (and w32notify, if I read the code right), but watching directories has certain advantages. w32notify cannot watch a single file, because the Windows notification machinery is directory-oriented, and reports all changes in the directory. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Apr 2019 10:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 35418@debbugs.gnu.org, Michael Albinus Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15564469002432 (code B ref 35418); Sun, 28 Apr 2019 10:22:01 +0000 Received: (at 35418) by debbugs.gnu.org; 28 Apr 2019 10:21:40 +0000 Received: from localhost ([127.0.0.1]:36782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKgwG-0000d9-IF for submit@debbugs.gnu.org; Sun, 28 Apr 2019 06:21:40 -0400 Received: from mail238c50.megamailservers.eu ([91.136.10.248]:35806 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKgwC-0000cw-RP for 35418@debbugs.gnu.org; Sun, 28 Apr 2019 06:21:38 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556446895; bh=U0fXqzpuaZn3cPcXbnRyBPJ9J77WfuqgC9xEMfz54l0=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=IdhQpAf24k4wN/DUc+uO+mqVpN6QKKjE4A1q1wT9xh6vfAW6bcNdi0xPPWC1BAh+K 2XtQf/sU/p+nNxTig57jYrsSADg6bb8N4iyCRXq4uaijAfpPuIkOa6QnIVrxjxM+gZ /5Y8MaO6qoe0MA7V2pmeEjbHjza4rLeNwzwH2OaU= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3SALWSg010549; Sun, 28 Apr 2019 10:21:34 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_32376299-BAC3-4AE7-8999-FEEE64A7B2B4" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Date: Sun, 28 Apr 2019 12:21:32 +0200 In-Reply-To: <83d0l7v193.fsf@gnu.org> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0214.5CC57EAF.0016, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Y+fWTCWN c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=mDV3o1hIAAAA:8 a=gS5QxAW_RoBqbYhW_lYA:9 a=CjuIK1q_8ugA:10 a=0HWlrovhfOKs-LZF6vcA:9 a=B2y7HmGcmWMA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_32376299-BAC3-4AE7-8999-FEEE64A7B2B4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 27 apr. 2019 kl. 18.52 skrev Eli Zaretskii : >=20 > w32notify cannot watch a single file, because the Windows notification > machinery is directory-oriented, and reports all changes in the > directory. Right; thanks for the correction. Here is an updated patch. There is a new variable, = `auto-revert-always-poll', which is t by default. There is also a note in etc/NEWS. Does it merit a mention in the manual = as well? --Apple-Mail=_32376299-BAC3-4AE7-8999-FEEE64A7B2B4 Content-Disposition: attachment; filename=0001-Don-t-poll-auto-revert-files-that-use-notification.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Don-t-poll-auto-revert-files-that-use-notification.patch" Content-Transfer-Encoding: quoted-printable =46rom=2091e073992dfdf8ce557e5679a11fb5f1e733f87e=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Wed,=2024=20Apr=202019=2018:39:05=20+0200=0A= Subject:=20[PATCH]=20Don't=20poll=20auto-revert=20files=20that=20use=20= notification=0A=0AIt=20is=20a=20waste=20to=20periodically=20poll=20files=20= that=20use=20change=20notification=0Ain=20auto-revert=20mode;=20stop=20= doing=20that.=20=20If=20no=20files=20need=20polling,=0Aturn=20off=20the=20= periodic=20execution=20entirely=20to=20further=20avoid=20wasting=20= power.=0AUse=20a=20timer=20to=20inhibit=20immediate=20reversion=20for=20= some=20time=20after=20a=0Anotification.=0A=0AThis=20change=20does=20not=20= apply=20to=20files=20in=20global-auto-revert-mode,=20where=0Apolling=20= is=20still=20necessary.=20=20It=20is=20disabled=20by=20default,=20and=20= enabled=20by=0Asetting=20`auto-revert-always-poll'=20to=20nil.=0A=0A*=20= lisp/autorevert.el=20(auto-revert--polled-buffers):=20New.=0A= (auto-revert-remove-current-buffer,=20auto-revert-mode)=0A= (global-auto-revert-mode,=20auto-revert-set-timer)=0A= (auto-revert-notify-add-watch,=20auto-revert-buffers):=0AMaintain=20and=20= use=20auto-revert--polled-buffers.=0A(auto-revert-buffers-counter):=20= Remove.=0A(auto-revert-buffers-counter-lockedout):=20Remove.=0A= (auto-revert--lockout-interval):=20New.=0A(auto-revert--lockout-timer):=20= New.=0A(auto-revert-notify-handler):=20Maintain=20and=20use=20= auto-revert--polled-buffers.=0AHonour=20new=20lockout=20timer.=20=20= Start=20lockout=20timer=20if=20necessary.=0A(auto-revert--end-lockout):=20= New.=0A(auto-revert-always-poll):=20New.=0A(auto-revert--need-polling):=20= New.=0A*=20etc/NEWS=20(Changes=20in=20Specialized=20Modes=20and=20= Packages):=20Mention=20the=20change.=0A---=0A=20etc/NEWS=20=20=20=20=20=20= =20=20=20=20=20|=20=2010=20++++=0A=20lisp/autorevert.el=20|=20125=20= +++++++++++++++++++++++++++++++--------------=0A=202=20files=20changed,=20= 98=20insertions(+),=2037=20deletions(-)=0A=0Adiff=20--git=20a/etc/NEWS=20= b/etc/NEWS=0Aindex=20cf6f4fea3e..84a3184e8c=20100644=0A---=20a/etc/NEWS=0A= +++=20b/etc/NEWS=0A@@=20-1389,6=20+1389,16=20@@=20Packages=20deriving=20= from=20'js-mode'=20with=20'define-derived-mode'=20should=0A=20call=20= this=20function=20to=20add=20enabled=20syntax=20extensions=20to=20their=20= mode=0A=20name,=20too.=0A=20=0A+**=20Autorevert=0A+=0A+***=20New=20= variable=20'auto-revert-always-poll'=20for=20saving=20power.=0A+Set=20= this=20variable=20to=20nil=20to=20prevent=20buffers=20in=20auto-revert=20= mode=20from=0A+being=20polled=20for=20changes=20periodically.=20=20This=20= reduces=20the=20power=0A+consumption=20of=20an=20idle=20Emacs,=20but=20= may=20fail=20on=20some=20network=20file=0A+systems.=20=20Make=20sure=20= that=20'auto-revert-notify-exclude-dir-regexp'=0A+matches=20files=20= where=20notification=20is=20not=20supported.=0A+The=20default=20value=20= is=20t.=0A+=0A=20=0C=0A=20*=20New=20Modes=20and=20Packages=20in=20Emacs=20= 27.1=0A=20=0Adiff=20--git=20a/lisp/autorevert.el=20b/lisp/autorevert.el=0A= index=201d20896c83..ae9ca63577=20100644=0A---=20a/lisp/autorevert.el=0A= +++=20b/lisp/autorevert.el=0A@@=20-302,6=20+302,29=20@@=20You=20should=20= set=20this=20variable=20through=20Custom."=0A=20=20=20:type=20'regexp=0A=20= =20=20:version=20"24.4")=0A=20=0A+(defcustom=20auto-revert-always-poll=20= t=0A+=20=20"Non-nil=20to=20poll=20files=20even=20if=20notification=20is=20= available.=0A+=0A+Set=20this=20variable=20to=20nil=20to=20save=20power=20= by=20avoiding=20polling=20when=0A+possible.=20=20Files=20on=20= file-systems=20that=20do=20not=20support=20file=0A+notifications=20must=20= match=20`auto-revert-notify-exclude-dir-regexp'=0A+for=20Auto-Revert=20= to=20work=20properly=20in=20this=20case.=20=20This=20typically=0A= +includes=20network=20file=20systems=20on=20Unix-like=20machines,=20for=20= files=0A+that=20are=20modified=20from=20another=20computer.=0A+=0A+When=20= non-nil,=20buffers=20in=20Auto-Revert=20Mode=20will=20always=20be=20= polled=0A+for=20changes=20to=20their=20files=20on=20disk=20every=20= `auto-revert-interval'=0A+seconds.=0A+=0A+In=20Global=20Auto-Revert=20= Mode,=20polling=20is=20always=20done=20regardless=20of=0A+the=20value=20= of=20this=20variable."=0A+=20=20:group=20'auto-revert=0A+=20=20:type=20= 'boolean=0A+=20=20:set=20(lambda=20(variable=20value)=0A+=20=20=20=20=20=20= =20=20=20(set-default=20variable=20value)=0A+=20=20=20=20=20=20=20=20=20= (auto-revert-set-timer))=0A+=20=20:version=20"27.1")=0A+=0A=20;;=20= Internal=20variables:=0A=20=0A=20(defvar=20auto-revert-buffer-list=20()=0A= @@=20-319,6=20+342,11=20@@=20the=20list=20of=20old=20buffers.")=0A=20= (defvar=20auto-revert-tail-pos=200=0A=20=20=20"Position=20of=20last=20= known=20end=20of=20file.")=0A=20=0A+(defvar=20= auto-revert--polled-buffers=20()=0A+=20=20"List=20of=20buffers=20in=20= Auto-Revert=20Mode=20that=20must=20be=20polled.=0A+It=20contains=20the=20= buffers=20in=20`auto-revert-buffer-list'=20whose=0A= +`auto-revert-notify-watch-descriptor'=20is=20nil.")=0A+=0A=20(defun=20= auto-revert-find-file-function=20()=0A=20=20=20(setq-local=20= auto-revert-tail-pos=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (file-attribute-size=20(file-attributes=20buffer-file-name))))=0A@@=20= -346,8=20+374,12=20@@=20This=20has=20been=20reported=20by=20a=20file=20= notification=20event.")=0A=20(defun=20auto-revert-remove-current-buffer=20= (&optional=20buffer)=0A=20=20=20"Remove=20BUFFER=20from=20= `auto-revert-buffer-list'.=0A=20BUFFER=20defaults=20to=20= `current-buffer'."=0A+=20=20(unless=20buffer=0A+=20=20=20=20(setq=20= buffer=20(current-buffer)))=0A=20=20=20(setq=20auto-revert-buffer-list=0A= -=20=20=20=20=20=20=20=20(delq=20(or=20buffer=20(current-buffer))=20= auto-revert-buffer-list)))=0A+=20=20=20=20=20=20=20=20(delq=20buffer=20= auto-revert-buffer-list))=0A+=20=20(setq=20auto-revert--polled-buffers=0A= +=20=20=20=20=20=20=20=20(delq=20buffer=20auto-revert--polled-buffers)))=0A= =20=0A=20;;;###autoload=0A=20(define-minor-mode=20auto-revert-mode=0A@@=20= -367,6=20+399,7=20@@=20without=20being=20changed=20in=20the=20part=20= that=20is=20already=20in=20the=20buffer."=0A=20=20=20(if=20= auto-revert-mode=0A=20=20=20=20=20=20=20(when=20(not=20(memq=20= (current-buffer)=20auto-revert-buffer-list))=0A=20=20=20=20=20=20=20=20=20= (push=20(current-buffer)=20auto-revert-buffer-list)=0A+=20=20=20=20=20=20= =20=20(push=20(current-buffer)=20auto-revert--polled-buffers)=0A=20=20=20= =20=20=20=20=20=20(add-hook=0A=20=20=20=20=20=20=20=20=20=20= 'kill-buffer-hook=0A=20=20=20=20=20=20=20=20=20=20= #'auto-revert-remove-current-buffer=0A@@=20-479,9=20+512,17=20@@=20= specifies=20in=20the=20mode=20line."=0A=20=20=20=20=20=20=20= (auto-revert-buffers)=0A=20=20=20=20=20(dolist=20(buf=20(buffer-list))=0A= =20=20=20=20=20=20=20(with-current-buffer=20buf=0A-=09(when=20= auto-revert-notify-watch-descriptor=0A+=20=20=20=20=20=20=20=20(when=20= (and=20auto-revert-notify-watch-descriptor=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20(not=20(memq=20buf=20= auto-revert-buffer-list)))=0A=20=09=20=20= (auto-revert-notify-rm-watch))))))=0A=20=0A+(defun=20= auto-revert--need-polling=20()=0A+=20=20"Whether=20periodic=20polling=20= is=20required."=0A+=20=20(or=20global-auto-revert-mode=0A+=20=20=20=20=20= =20(if=20auto-revert-always-poll=0A+=20=20=20=20=20=20=20=20=20=20= auto-revert-buffer-list=0A+=20=20=20=20=20=20=20=20= auto-revert--polled-buffers)))=0A+=0A=20(defun=20auto-revert-set-timer=20= ()=0A=20=20=20"Restart=20or=20cancel=20the=20timer=20used=20by=20= Auto-Revert=20Mode.=0A=20If=20such=20a=20timer=20is=20active,=20cancel=20= it.=20=20Start=20a=20new=20timer=20if=0A@@=20-492,10=20+533,10=20@@=20= will=20use=20an=20up-to-date=20value=20of=20`auto-revert-interval'"=0A=20= =20=20(if=20(timerp=20auto-revert-timer)=0A=20=20=20=20=20=20=20= (cancel-timer=20auto-revert-timer))=0A=20=20=20(setq=20auto-revert-timer=0A= -=09(if=20(or=20global-auto-revert-mode=20auto-revert-buffer-list)=0A-=09= =20=20=20=20(run-with-timer=20auto-revert-interval=0A-=09=09=09=20=20=20=20= auto-revert-interval=0A-=09=09=09=20=20=20=20'auto-revert-buffers))))=0A= +=09(and=20(auto-revert--need-polling)=0A+=09=20=20=20=20=20= (run-with-timer=20auto-revert-interval=0A+=09=09=09=20=20=20=20=20= auto-revert-interval=0A+=09=09=09=20=20=20=20=20'auto-revert-buffers))))=0A= =20=0A=20(defun=20auto-revert-notify-rm-watch=20()=0A=20=20=20"Disable=20= file=20notification=20for=20current=20buffer's=20associated=20file."=0A= @@=20-551,6=20+592,8=20@@=20will=20use=20an=20up-to-date=20value=20of=20= `auto-revert-interval'"=0A=20=09=20=20=20=20=20=20=20(gethash=20= auto-revert-notify-watch-descriptor=0A=20=09=09=20=20=20=20=20=20=20=20= auto-revert--buffers-by-watch-descriptor))=0A=20=20=20=20=20=20=20=20=20=20= auto-revert--buffers-by-watch-descriptor)=0A+=20=20=20=20=20=20=20=20= (setq=20auto-revert--polled-buffers=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(delq=20(current-buffer)=20auto-revert--polled-buffers))=0A=20=20=20= =20=20=20=20=20=20(add-hook=20'kill-buffer-hook=20= #'auto-revert-notify-rm-watch=20nil=20t)))))=0A=20=0A=20;;=20If=20we=20= have=20file=20notifications,=20we=20want=20to=20update=20the=20= auto-revert=20buffers=0A@@=20-558,24=20+601,20=20@@=20will=20use=20an=20= up-to-date=20value=20of=20`auto-revert-interval'"=0A=20;;=20often,=20we=20= want=20to=20skip=20some=20revert=20operations=20so=20that=20we=20don't=20= spend=20all=20our=0A=20;;=20time=20reverting=20the=20buffer.=0A=20;;=0A= -;;=20We=20do=20this=20by=20reverting=20immediately=20in=20response=20to=20= the=20first=20in=20a=20flurry=20of=0A-;;=20notifications.=20We=20= suppress=20subsequent=20notifications=20until=20the=20next=20time=0A-;;=20= `auto-revert-buffers'=20is=20called=20(this=20happens=20on=20a=20timer=20= with=20a=20period=20set=20by=0A-;;=20`auto-revert-interval').=0A-(defvar=20= auto-revert-buffers-counter=201=0A-=20=20"Incremented=20each=20time=20= `auto-revert-buffers'=20is=20called")=0A-(defvar-local=20= auto-revert-buffers-counter-lockedout=200=0A-=20=20"Buffer-local=20value=20= to=20indicate=20whether=20we=20should=20immediately=0A-update=20the=20= buffer=20on=20a=20notification=20event=20or=20not.=20If=0A-=0A-=20=20(=3D=20= auto-revert-buffers-counter-lockedout=0A-=20=20=20=20=20= auto-revert-buffers-counter)=0A-=0A-then=20the=20updates=20are=20locked=20= out,=20and=20we=20wait=20until=20the=20next=20call=0A-of=20= `auto-revert-buffers'=20to=20revert=20the=20buffer.=20If=20no=20lockout=20= is=0A-present,=20then=20we=20revert=20immediately=20and=20set=20the=20= lockout,=20so=20that=0A-no=20more=20reverts=20are=20possible=20until=20= the=20next=20call=20of=0A-`auto-revert-buffers'")=0A+;;=20We=20do=20this=20= by=20reverting=20immediately=20in=20response=20to=20the=20first=20in=20a=0A= +;;=20flurry=20of=20notifications.=20Any=20notifications=20during=20the=20= following=0A+;;=20`auto-revert-lockout-interval'=20seconds=20are=20noted=20= but=20not=20acted=20upon=0A+;;=20until=20the=20end=20of=20that=20= interval.=0A+=0A+(defconst=20auto-revert--lockout-interval=202.5=0A+=20=20= "Duration,=20in=20seconds,=20of=20the=20Auto-Revert=20Mode=20= notification=20lockout.=0A+This=20is=20the=20quiescence=20after=20each=20= notification=20of=20a=20file=20being=0A+changed=20during=20which=20no=20= automatic=20reverting=20takes=20place,=20to=0A+prevent=20many=20updates=20= in=20rapid=20succession=20from=20overwhelming=20the=0A+system.")=0A+=0A= +(defvar-local=20auto-revert--lockout-timer=20nil=0A+=20=20"Timer=20= awaiting=20the=20end=20of=20the=20notification=20lockout=20interval,=20= or=20nil.")=0A=20=0A=20(defun=20auto-revert-notify-handler=20(event)=0A=20= =20=20"Handle=20an=20EVENT=20returned=20from=20file=20notification."=0A= @@=20-604,7=20+643,13=20@@=20no=20more=20reverts=20are=20possible=20= until=20the=20next=20call=20of=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(file-name-nondirectory=20= buffer-file-name)))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20;;=20A=20buffer=20w/o=20a=20file,=20like=20dired.=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(null=20= buffer-file-name))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (auto-revert-notify-rm-watch))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(auto-revert-notify-rm-watch)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(when=20(memq=20buffer=20auto-revert-buffer-list)=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(unless=20(memq=20buffer=20= auto-revert--polled-buffers)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(push=20buffer=20auto-revert--polled-buffers))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20Restart=20the=20= timer=20if=20it=20wasn't=20running.=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(unless=20auto-revert-timer=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(auto-revert-set-timer))))))=0A=20=0A= =20=20=20=20=20=20=20=20=20;;=20Loop=20over=20all=20buffers,=20in=20= order=20to=20find=20the=20intended=20one.=0A=20=20=20=20=20=20=20=20=20= (cl-dolist=20(buffer=20buffers)=0A@@=20-630,11=20+675,21=20@@=20no=20= more=20reverts=20are=20possible=20until=20the=20next=20call=20of=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(setq=20= auto-revert-notify-modified-p=20t)=0A=20=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20;;=20Revert=20the=20buffer=20now=20if=20we're=20not=20= locked=20out.=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20= (/=3D=20auto-revert-buffers-counter-lockedout=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffers-counter)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(unless=20auto-revert--lockout-timer=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(auto-revert-handler)=0A-=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(setq=20= auto-revert-buffers-counter-lockedout=0A-=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffers-counter))))))))))=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(setq=20auto-revert--lockout-timer=0A+=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(run-with-timer=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20auto-revert--lockout-interval=20nil=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20#'auto-revert--end-lockout=20= buffer)))))))))))=0A+=0A+(defun=20auto-revert--end-lockout=20(buffer)=0A= +=20=20"End=20the=20lockout=20period=20after=20a=20notification.=0A+If=20= the=20buffer=20needs=20to=20be=20reverted,=20do=20it=20now."=0A+=20=20= (when=20(buffer-live-p=20buffer)=0A+=20=20=20=20(with-current-buffer=20= buffer=0A+=20=20=20=20=20=20(setq=20auto-revert--lockout-timer=20nil)=0A= +=20=20=20=20=20=20(when=20auto-revert-notify-modified-p=0A+=20=20=20=20=20= =20=20=20(auto-revert-handler)))))=0A=20=0A=20(defun=20= auto-revert-active-p=20()=0A=20=20=20"Check=20if=20auto-revert=20is=20= active=20(in=20current=20buffer=20or=20globally)."=0A@@=20-755,13=20= +810,10=20@@=20This=20function=20is=20also=20responsible=20for=20= removing=20buffers=20no=20longer=20in=0A=20Auto-Revert=20Mode=20from=20= `auto-revert-buffer-list',=20and=20for=20canceling=0A=20the=20timer=20= when=20no=20buffers=20need=20to=20be=20checked."=0A=20=0A-=20=20(setq=20= auto-revert-buffers-counter=0A-=20=20=20=20=20=20=20=20(1+=20= auto-revert-buffers-counter))=0A-=0A=20=20=20(save-match-data=0A-=20=20=20= =20(let=20((bufs=20(if=20global-auto-revert-mode=0A-=09=09=20=20=20=20= (buffer-list)=0A-=09=09=20=20auto-revert-buffer-list))=0A+=20=20=20=20= (let=20((bufs=20(cond=20(global-auto-revert-mode=20(buffer-list))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (auto-revert-always-poll=20auto-revert-buffer-list)=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(t=20= auto-revert--polled-buffers)))=0A=20=09=20=20remaining=20new)=0A=20=20=20= =20=20=20=20;;=20Buffers=20with=20remote=20contents=20shall=20be=20= reverted=20only=20if=20the=0A=20=20=20=20=20=20=20;;=20connection=20is=20= established=20already.=0A@@=20-810,8=20+862,7=20@@=20the=20timer=20when=20= no=20buffers=20need=20to=20be=20checked."=0A=20=09(setq=20bufs=20(cdr=20= bufs)))=0A=20=20=20=20=20=20=20(setq=20auto-revert-remaining-buffers=20= bufs)=0A=20=20=20=20=20=20=20;;=20Check=20if=20we=20should=20cancel=20= the=20timer.=0A-=20=20=20=20=20=20(when=20(and=20(not=20= global-auto-revert-mode)=0A-=09=09=20(null=20auto-revert-buffer-list))=0A= +=20=20=20=20=20=20(unless=20(auto-revert--need-polling)=0A=20=20=20=20=20= =20=20=20=20(if=20(timerp=20auto-revert-timer)=0A=20=20=20=20=20=20=20=20= =20=20=20=20=20(cancel-timer=20auto-revert-timer))=0A=20=09(setq=20= auto-revert-timer=20nil)))))=0A--=20=0A2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_32376299-BAC3-4AE7-8999-FEEE64A7B2B4-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 07:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155652242831835 (code B ref 35418); Mon, 29 Apr 2019 07:21:02 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 07:20:28 +0000 Received: from localhost ([127.0.0.1]:38295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL0aR-0008HP-RX for submit@debbugs.gnu.org; Mon, 29 Apr 2019 03:20:28 -0400 Received: from mout.gmx.net ([212.227.15.19]:44885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL0aP-0008H8-0b for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 03:20:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556522415; bh=7KLwY7thJwI4MbTWXTxWgqIHT3kdmYBOnFMQ7qt015c=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=O2pmPrYfGIy0WoGcnnK71Oy3VKq7BCsD8z2zai6zJmygI5ZnJH7Q9PipnuyrgHzpC cKQ8i1B6/GvzOYWzL6g0Up7MIQHUmC4mCRExbg8CrGMc7WYM4Wh2Hnz3aQ641H0QiA AyAu5V6cS4xdEEDtHjgTjAyTVwLArrplgZwBUezg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([213.220.159.69]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MD9q8-1hZIJv09wC-00GZF9; Mon, 29 Apr 2019 09:20:15 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> Date: Mon, 29 Apr 2019 09:19:58 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Sat, 27 Apr 2019 18:19:36 +0200") Message-ID: <87bm0pqnvl.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:AQV3FfdiZRLtwgtIGylJmaFuffDTVEaCWRip9G+P99aJE8Eu2jI GGa6DyLNbVaPcjTXAteOqa6/LNekGR6Gp3frwMEfjK+f9ZHVYQyAQkMWNaIo84AIq3xi713 jt/3lLvILOaB0o8af8dr0R+WLToeCNmT0C3EbyJ+PRSL1qHN/I5oMZAdpd0Ompa+B71UpO8 9P27xzfEGiRfcf63qnFHg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:FdCkGt2vwWM=:veqU0HTXicyxJCTRPqCGCx RZcRFxRhWJ7V7f8FI2MZoQUeO2JYd2DtyYbEs84Ns/Oz+h/X4spQGX1fpH31GfzyQKqswEzeT 6fEMxm+tTRyTRRP2GrwS0xxT+5eOY9CQ5sWv9f/stoJaOcEvrJsqoo1n8FB8Dhb95whZMpTVy WYjMQ5Xj8FO0TJHtuq3/mhNKnRY8c+9BqOGMtYPg8JQJGO6K7+e1BCmvQkfuXoyTSeK+SZ6OJ UtbAhFoM2mF6QMJEs2IzKvfU8YnUyx3qvOas2LRYASVRifhXQpiwm0ospsN/10/EBDX98FD8l xpLdz3pMR0rc7XGY0c2g3VV8AhsE5AdUcu8jOLwnzv562hchlvcduTNqLb/E2bhOeiRRjkW4N QyOT4W0MwVtGKdFhm5YJ2sMbAL3AvkuouF4KuqX/bokwCBJwU/tsuiMOb8gmZqTFo1PkA+yxJ VfKakkBQ+UWaMNZNfySkP1ChdFgfwA9qnnLv8AyLAukO3ovU2dagADmNt+cM9/t2hEKukSZAj HIMJeKxv+GpjR0PCb8R9M9DDy1BM+IouKULjofQC07Y9PuCv/hrqGgkLYGQ+7tN/0RCaq1z9z VJ4sFSTyeeGhP1PmqkI+C/FBEMbrxxuCik8QxWVnFrXKoKJdyVFWZ/DmbMourtWW8TI77W9+X VJgfOHtjC1BoecwsJt3cfIe6Mvv9hMtDF4m0YViawE/97ou9MFvxi2MuuMl5J8+Pg2xX1i2JO NzCTkMbyTvRBDaOAO2ZPuazej6xxnV1AspKGMm6ryUDiZqoaZuaBXrbtPfWYorl9aoJEIhh67 4/lvkoS0ufmAMOI8wAxL0PobVCgd2x8XXwct3o4IGXlKcwTanLrDnqL4FpW02zoaIiPMRXwj0 EKfoWjXjasOGKSwBpR5eySu1jNFi2qN9/eWlIucAcCbPg9PAC1/JY0NY7AvYx3FI2RB2VjTyK HRZs0XJRVbw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: > Actually, it is (arguably) a bug. With two buffers referring to > distinct hard links for the same file, surely we want a change in that > file to trigger notification for both! (It's quite an exotic case, not > the least because Emacs normally recognises hard links as if they were > the same file name.) By design, in filenotify.el, we want see only events which are related to the file *name*. If you want to be notified for both buffers, you need to watch both file (names). (Well, re-reading the docstring and the manual for `file-notify-add-watch', this isn't said explicitly. Likely, we shall precise this.) > However, with the kqueue back-end, file-notify watches do trigger for > both, as expected. Hmm, this is inconsistent. Worth a buig report? > The reason is that file-notify does not call inotify-add-watch on > individual files, as in your example above, but on their containing > directory ("/tmp" in your example). When monitoring a directory with > two hard links to the same file, and the file is changed, inotify > (sensibly) only reports a change to one of the links (the one employed > for the change). Thus, the logic is in the Linux kernel, not in > filenotify. > > For kqueue it is different: here, changes to files are not reported > when a watch is monitoring their directory, so filenotify.el sets > kqueue watches on each file instead. The same could be done with > inotify (and w32notify, if I read the code right), but watching > directories has certain advantages. It was a design decision, that filenotify.el implements directory watching. Since kqueue does not support this, it must be emulated, somehow. >> One alternative approach could be to analyze the file system device >> number, as returned by `file-attributes'. By this, we could detect >> mounted file systems. > > Sort of; the interpretation is tricky, and as Eli commented, quite > platform-specific. I'm also not in favor of this approach, I just wanted to mention it. >> But I don't believe that this information is always trustworty, given it >> isn't used anywhere. And at least for remote files it doesn't tell you >> anything. Furthermore, mounted file systems are not the only reason that >> file notification doesn't work, and we need to poll. > > What other reasons are you thinking about? The reasons you have already quoted somewhere else: sometimes, file notification is not applicable; there are not enough descriptors left; a file might have been deleted; a file notification process has been killed silently; you name it ... Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 07:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15565244312526 (code B ref 35418); Mon, 29 Apr 2019 07:54:02 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 07:53:51 +0000 Received: from localhost ([127.0.0.1]:38342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL16k-0000eg-L7 for submit@debbugs.gnu.org; Mon, 29 Apr 2019 03:53:50 -0400 Received: from mout.gmx.net ([212.227.17.22]:57521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL16j-0000eR-88 for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 03:53:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556524418; bh=Iv3L6Ol4JBJcdISP53k/5vpjzW2g439OnreBbOxq3Ak=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=fmPT0kLv6PZWAivqg1rudkRv4Kqbk6dQYkaEO/pREJi21dqbMMdnyAUhFYwirg+7D 2B3uGdHt3pFYNq5doFdO8TjBdhfydVaceN/5Fa9xeVj/eQlVqckXzwTmlowq9itkSF h4Wn8UMPjMpIUSmo9D8xgxkfUvRActALwnDQvG4U= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([213.220.159.69]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MxUnp-1gb2883isj-00xqCv; Mon, 29 Apr 2019 09:53:38 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> Date: Mon, 29 Apr 2019 09:53:36 +0200 In-Reply-To: <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Sun, 28 Apr 2019 12:21:32 +0200") Message-ID: <877ebdqmbj.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:cGkLV2GfIK/xAHOcyINTDMkQ7Lym/oHnEC93+Y0etguK0YMqftG Jkg9jhEB8d5hmxYI6Rvh0QKnBZqMmiNDXLeJ6pFT4uicOeQjnpfD0W3hafzxh0h34IqyQyb 9uZM63gxQSvjwvfyzPz1YFuYgEW6+uGhjOa2fSfLT4H4skR4IawPQ/f4zu+b2errw9/jQOk WovuH44owTVnHUi1VmCFg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:sqvf+tTSyVw=:Yt17bB0T8O1ZSNAoqC9686 B95AVx/4yhvqA5y6voCY+EztllXv7iUG4lYX0Os7QHT43D/rP9GLyN9oZ6JzMx0IgmRNRT7h6 opzyEjIcWb1FEbvLIgQeha0Gn+gHcy/tKjBg/pLl2pjO14M8QobGQTTcLj0BbcIle8I56Sr/m 32/Uhxj34WF9B+evZ3ucCz2LmS8FIQWCFKeGCpV2jtV316/n0iGr8cRmv51QuYOkQOwWUkiEi a+kZ4IIIRdhDfrLzuauqHWhD6z7BYdRuvyGIQPeuCNQwcTSQedPt0vM2GNbNXeHt6zHAeDuR+ 4RL5Olzz6FKl5q7WnPKvBWIACpPg2ssT1R4fvZ1z7tAAftaWLgfg6RpEJC4IG34+ZWqj611zi 1wDgUUMhEALxIl4v4iPkCmQ6HA6t8zLOrLsSe4BEDwyfyoZeqYia/MLGYsdmIH6+puMZ/4YDF 2NcierP61X3EAbDTAsDlRhM+9fpcxecccoUD7kkSsq3NhqdiMz5A5hc+0fCoRIoQ+aT6exFbo 5oB03qdAdLYeStFDU7F3AHvgR4rHN97u9f4qlJMthgRoK2JT1aA33FjisZue8r27Q8VXle+L3 EtSRjdmxu3mvhZg54D89/9RQ679+O66APQylGFGrR3KfBLNDL7/d7kdq8OerDrb29RXe+6fS+ eh4j9asUKH5icqDgLmaPJhglm8tBGF3UskDhZbXiH2pfgP+LP/B5SvTFqpP0y7RxOEDw8k6Bl MIfT0PQEbX5YK/VvZvSQL2GPUrKTObZI8LDuBJRI8VAsEJbAXqgycXI9ysO4Jjweu63CTUwle WAcKgnZK7S/cYGNnSRN99tfzJ2n9qynvfiA67VDcVq5UHFpP132bTzVslE5EDq83OBRhdagtp RxllH4tklt+OeNyGZUKAIcDGg3DZRW5qkEt8uIPbot2eh/Za05ptsEkE5sFp6/6s2css0wDNe vdeGQBGX7ug== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, > Here is an updated patch. There is a new variable, > `auto-revert-always-poll', which is t by default. > There is also a note in etc/NEWS. Does it merit a mention in the manual a= s well? Yes, please. > +(defcustom auto-revert-always-poll t > + "Non-nil to poll files even if notification is available. > + > +Set this variable to nil to save power by avoiding polling when > +possible. Files on file-systems that do not support file > +notifications must match `auto-revert-notify-exclude-dir-regexp' > +for Auto-Revert to work properly in this case. This typically > +includes network file systems on Unix-like machines, for files > +that are modified from another computer. > + > +When non-nil, buffers in Auto-Revert Mode will always be polled > +for changes to their files on disk every `auto-revert-interval' > +seconds. > + > +In Global Auto-Revert Mode, polling is always done regardless of > +the value of this variable." I believe it shall be said, that this user option does not compete with `auto-revert-use-notify'. Rather, polling is used additionally to file notification. When `auto-revert-use-notify' is nil, the value of `auto-revert-always-poll' doesn't matter; there will always be polling. Saying this, the user option might need another name. What about `auto-revert-also-poll'? > +(defvar auto-revert--polled-buffers () > + "List of buffers in Auto-Revert Mode that must be polled. > +It contains the buffers in `auto-revert-buffer-list' whose > +`auto-revert-notify-watch-descriptor' is nil.") Is this variable needed? It is used only once in `auto-revert--need-polling', and it could be computed easily by (untested) (delq nil (mapcar (lambda (buf) (and (or auto-revert-always-poll (not auto-revert-notify-watch-descriptor)) buf)) auto-revert-buffer-list)) `auto-revert--need-polling' shall always return the buffer list, also for `global-auto-revert-mode'. Otherwise, the patch might work. Let's try it. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 11:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155653601921230 (code B ref 35418); Mon, 29 Apr 2019 11:07:01 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 11:06:59 +0000 Received: from localhost ([127.0.0.1]:38519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL47e-0005WL-P2 for submit@debbugs.gnu.org; Mon, 29 Apr 2019 07:06:59 -0400 Received: from mail83c50.megamailservers.eu ([91.136.10.93]:47434 helo=mail18c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL47b-0005W8-Gw for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 07:06:57 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556536013; bh=zmvOhTgtItiyywVFSzTJ8egmGKY0aT/WSsg5nchDyQ0=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=AtnxNO5sXhtlaWffNMJ6TRTrHhy9Ofv2FNFdFyHcIEJHcmvuEoVNdN16cGu7W9lhM X8KPh59BMiRQwcbS7HiT3oUuXfgebHCHf0brtGGW9XE2+fE0/4+wfIcAyY5mHDwWsq MhyGWTzg83PJweZEL1Y/OAp7132/HDRwRq/Sa9Yo= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3TB6pFr006946; Mon, 29 Apr 2019 11:06:52 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_63FF422E-39C5-4384-BCDA-EBD6A6EE7DB4" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Date: Mon, 29 Apr 2019 13:06:50 +0200 In-Reply-To: <877ebdqmbj.fsf@gmx.de> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0207.5CC6DACD.0038, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=S7n3PrkP c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IBGAhrbTSAdScrTBqPcA:9 a=d9utRVh_FFTiS5Pj:21 a=JBt6rzN59fMSCSbz:21 a=CjuIK1q_8ugA:10 a=09XKyqVNrCcG81hL1tgA:9 a=B2y7HmGcmWMA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_63FF422E-39C5-4384-BCDA-EBD6A6EE7DB4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 29 apr. 2019 kl. 09.53 skrev Michael Albinus : >=20 >> Here is an updated patch. There is a new variable, >> `auto-revert-always-poll', which is t by default. >> There is also a note in etc/NEWS. Does it merit a mention in the = manual as well? >=20 > Yes, please. There is now a paragraph added to the manual. By the way, the organisation of this part of the manual could be = improved -- don't you agree? There is a section called Reverting, which starts about `revert-buffer' = but then goes on to talk about the auto-revert, global-auto-revert and = auto-revert-tail modes and details about the mechanisms behind them: = polling, intervals, notification. Then there is a (sibling) section called Autorevert, which despite its = name only talks about auto-reverting non-file buffers. This can be reorganised in various ways. We could move all autorevert = text to a sibling node to Reverting, or to one or more child nodes. In = any case, such text shuffling should not be part of this patch. > I believe it shall be said, that this user option does not compete = with > `auto-revert-use-notify'. Rather, polling is used additionally to file > notification. When `auto-revert-use-notify' is nil, the value of > `auto-revert-always-poll' doesn't matter; there will always be = polling. Good point; the doc string has been clarified. > Saying this, the user option might need another name. What about > `auto-revert-also-poll'? Naming is always hard. I started with `auto-revert-avoid-polling' but = wanted to avoid a negative name. I tried `auto-revert-also-poll' but it somehow didn't feel right; not = all buffers use notification. It is nothing I feel strongly about, so if you do prefer that name I'll = change, but I've kept the original name in the patch for now. >> +(defvar auto-revert--polled-buffers () >> + "List of buffers in Auto-Revert Mode that must be polled. >> +It contains the buffers in `auto-revert-buffer-list' whose >> +`auto-revert-notify-watch-descriptor' is nil.") >=20 > Is this variable needed? It is used only once in > `auto-revert--need-polling', and it could be computed easily by It is also used in `auto-revert-buffers', but you are quite right that = it could be a function. I decided to maintain it as a derived state = because it felt silly to replace O(1) code with O(N), and the invariant = is clear enough (stated in its doc string). (Some of the places where = the variable is updated are O(N) but less frequently executed.) I can replace it with a function if you want, but the code didn't seem = to gain much from doing so. > `auto-revert--need-polling' shall always return the buffer list, also = for > `global-auto-revert-mode'. Sorry, it was meant as a predicate and is only used as such. Clarified by renaming it to `auto-revert--need-polling-p'. Thank you very much for your review! Updated patch attached. --Apple-Mail=_63FF422E-39C5-4384-BCDA-EBD6A6EE7DB4 Content-Disposition: attachment; filename=0001-Don-t-poll-auto-revert-files-that-use-notification.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Don-t-poll-auto-revert-files-that-use-notification.patch" Content-Transfer-Encoding: quoted-printable =46rom=2017a48cc4a106112830b1399fff2966bd16b8c23c=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Wed,=2024=20Apr=202019=2018:39:05=20+0200=0A= Subject:=20[PATCH]=20Don't=20poll=20auto-revert=20files=20that=20use=20= notification=0A=0AIt=20is=20a=20waste=20to=20periodically=20poll=20files=20= that=20use=20change=20notification=0Ain=20auto-revert=20mode;=20stop=20= doing=20that.=20=20If=20no=20files=20need=20polling,=0Aturn=20off=20the=20= periodic=20execution=20entirely=20to=20further=20avoid=20wasting=20= power.=0AUse=20a=20timer=20to=20inhibit=20immediate=20reversion=20for=20= some=20time=20after=20a=0Anotification.=0A=0AThis=20change=20does=20not=20= apply=20to=20files=20in=20global-auto-revert-mode,=20where=0Apolling=20= is=20still=20necessary.=20=20It=20is=20disabled=20by=20default,=20and=20= enabled=20by=0Asetting=20`auto-revert-always-poll'=20to=20nil.=0A=0A*=20= lisp/autorevert.el=0A(auto-revert--polled-buffers,=20= auto-revert--lockout-interval,=0Aauto-revert--lockout-timer,=20= auto-revert--end-lockout,=20auto-revert-always-poll,=0A= auto-revert--need-polling-p):=20New.=0A= (auto-revert-remove-current-buffer,=20auto-revert-mode,=0A= global-auto-revert-mode,=20auto-revert-set-timer,=0A= auto-revert-notify-add-watch,=20auto-revert-buffers,=0A= auto-revert-notify-handler):=20Maintain=20and=20use=20= auto-revert--polled-buffers.=0AHonour=20new=20lockout=20timer.=20=20= Start=20lockout=20timer=20if=20necessary.=0AMaintain=20and=20use=20= auto-revert--polled-buffers.=0A(auto-revert-buffers-counter,=20= auto-revert-buffers-counter-lockedout):=20Remove.=0A=0A*=20etc/NEWS=20= (Changes=20in=20Specialized=20Modes=20and=20Packages):=20Mention=20the=20= change.=0A=0A*=20doc/emacs/files.texi=20(Reverting):=20Add=20paragraph=20= describing=0Aauto-revert-always-poll.=0A---=0A=20doc/emacs/files.texi=20= |=20=2013=20+++++=0A=20etc/NEWS=20=20=20=20=20=20=20=20=20=20=20=20=20|=20= =2010=20++++=0A=20lisp/autorevert.el=20=20=20|=20125=20= ++++++++++++++++++++++++++++++-------------=0A=203=20files=20changed,=20= 111=20insertions(+),=2037=20deletions(-)=0A=0Adiff=20--git=20= a/doc/emacs/files.texi=20b/doc/emacs/files.texi=0Aindex=20= a57428230c..2dd48503b4=20100644=0A---=20a/doc/emacs/files.texi=0A+++=20= b/doc/emacs/files.texi=0A@@=20-988,6=20+988,19=20@@=20the=20polling=20= interval=20through=20the=20variable=20@code{auto-revert-interval}.=0A=20= supported,=20@code{auto-revert-use-notify}=20will=20be=20@code{nil}=20by=0A= =20default.=0A=20=0A+@vindex=20auto-revert-always-poll=0A+@vindex=20= auto-revert-notify-exclude-dir-regexp=0A+=20=20By=20default,=20= Auto-Revert=20mode=20will=20poll=20files=20for=20changes=0A+periodically=20= even=20when=20file=20notifications=20are=20used.=20=20Such=20polling=20= is=0A+usually=20unnecessary,=20and=20turning=20it=20off=20may=20save=20= power=20by=20relying=20on=0A+notifications=20only.=20=20To=20do=20so,=20= set=20the=20variable=0A+@code{auto-revert-always-poll}=20to=20= @code{nil}.=20=20However,=20notification=0A+is=20ineffective=20on=20= certain=20file=20systems;=20mainly=20network=20file=20system=20on=0A= +Unix-like=20machines,=20where=20files=20can=20be=20altered=20from=20= other=20machines.=0A+To=20force=20polling=20when=20= @code{auto-revert-always-poll}=20is=20@code{nil},=0A+set=20= @code{auto-revert-notify-exclude-dir-regexp}=20to=20match=20files=20that=0A= +should=20be=20excluded=20from=20using=20notification.=0A+=0A=20=20=20= One=20use=20of=20Auto-Revert=20mode=20is=20to=20``tail''=20a=20file=20= such=20as=20a=20system=0A=20log,=20so=20that=20changes=20made=20to=20= that=20file=20by=20other=20programs=20are=0A=20continuously=20displayed.=20= =20To=20do=20this,=20just=20move=20the=20point=20to=20the=20end=20of=0A= diff=20--git=20a/etc/NEWS=20b/etc/NEWS=0Aindex=209b32d720b6..cf997aa0c8=20= 100644=0A---=20a/etc/NEWS=0A+++=20b/etc/NEWS=0A@@=20-1389,6=20+1389,16=20= @@=20Packages=20deriving=20from=20'js-mode'=20with=20= 'define-derived-mode'=20should=0A=20call=20this=20function=20to=20add=20= enabled=20syntax=20extensions=20to=20their=20mode=0A=20name,=20too.=0A=20= =0A+**=20Autorevert=0A+=0A+***=20New=20variable=20= 'auto-revert-always-poll'=20for=20saving=20power.=0A+Set=20this=20= variable=20to=20nil=20to=20prevent=20buffers=20in=20auto-revert=20mode=20= from=0A+being=20polled=20for=20changes=20periodically.=20=20This=20= reduces=20the=20power=0A+consumption=20of=20an=20idle=20Emacs,=20but=20= may=20fail=20on=20some=20network=20file=0A+systems.=20=20Make=20sure=20= that=20'auto-revert-notify-exclude-dir-regexp'=0A+matches=20files=20= where=20notification=20is=20not=20supported.=0A+The=20default=20value=20= is=20t.=0A+=0A=20=0C=0A=20*=20New=20Modes=20and=20Packages=20in=20Emacs=20= 27.1=0A=20=0Adiff=20--git=20a/lisp/autorevert.el=20b/lisp/autorevert.el=0A= index=201d20896c83..b16b1b5833=20100644=0A---=20a/lisp/autorevert.el=0A= +++=20b/lisp/autorevert.el=0A@@=20-302,6=20+302,29=20@@=20You=20should=20= set=20this=20variable=20through=20Custom."=0A=20=20=20:type=20'regexp=0A=20= =20=20:version=20"24.4")=0A=20=0A+(defcustom=20auto-revert-always-poll=20= t=0A+=20=20"Non-nil=20to=20poll=20files=20in=20addition=20to=20the=20use=20= of=20notification.=0A+=0A+Set=20this=20variable=20to=20nil=20to=20save=20= power=20by=20avoiding=20polling=20when=0A+possible.=20=20Files=20on=20= file-systems=20that=20do=20not=20support=20change=0A+notifications=20= must=20match=20`auto-revert-notify-exclude-dir-regexp'=0A+for=20= Auto-Revert=20to=20work=20properly=20in=20this=20case.=20=20This=20= typically=0A+includes=20files=20on=20network=20file=20systems=20on=20= Unix-like=20machines,=0A+when=20those=20files=20are=20modified=20from=20= another=20computer.=0A+=0A+When=20non-nil,=20buffers=20in=20Auto-Revert=20= Mode=20will=20always=20be=20polled=0A+for=20changes=20to=20their=20files=20= on=20disk=20every=20`auto-revert-interval'=0A+seconds,=20in=20addition=20= to=20using=20notification=20for=20those=20files.=0A+=0A+In=20Global=20= Auto-Revert=20Mode,=20polling=20is=20always=20done=20regardless=20of=0A= +the=20value=20of=20this=20variable."=0A+=20=20:group=20'auto-revert=0A+=20= =20:type=20'boolean=0A+=20=20:set=20(lambda=20(variable=20value)=0A+=20=20= =20=20=20=20=20=20=20(set-default=20variable=20value)=0A+=20=20=20=20=20=20= =20=20=20(auto-revert-set-timer))=0A+=20=20:version=20"27.1")=0A+=0A=20= ;;=20Internal=20variables:=0A=20=0A=20(defvar=20auto-revert-buffer-list=20= ()=0A@@=20-319,6=20+342,11=20@@=20the=20list=20of=20old=20buffers.")=0A=20= (defvar=20auto-revert-tail-pos=200=0A=20=20=20"Position=20of=20last=20= known=20end=20of=20file.")=0A=20=0A+(defvar=20= auto-revert--polled-buffers=20()=0A+=20=20"List=20of=20buffers=20in=20= Auto-Revert=20Mode=20that=20must=20be=20polled.=0A+It=20contains=20the=20= buffers=20in=20`auto-revert-buffer-list'=20whose=0A= +`auto-revert-notify-watch-descriptor'=20is=20nil.")=0A+=0A=20(defun=20= auto-revert-find-file-function=20()=0A=20=20=20(setq-local=20= auto-revert-tail-pos=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (file-attribute-size=20(file-attributes=20buffer-file-name))))=0A@@=20= -346,8=20+374,12=20@@=20This=20has=20been=20reported=20by=20a=20file=20= notification=20event.")=0A=20(defun=20auto-revert-remove-current-buffer=20= (&optional=20buffer)=0A=20=20=20"Remove=20BUFFER=20from=20= `auto-revert-buffer-list'.=0A=20BUFFER=20defaults=20to=20= `current-buffer'."=0A+=20=20(unless=20buffer=0A+=20=20=20=20(setq=20= buffer=20(current-buffer)))=0A=20=20=20(setq=20auto-revert-buffer-list=0A= -=20=20=20=20=20=20=20=20(delq=20(or=20buffer=20(current-buffer))=20= auto-revert-buffer-list)))=0A+=20=20=20=20=20=20=20=20(delq=20buffer=20= auto-revert-buffer-list))=0A+=20=20(setq=20auto-revert--polled-buffers=0A= +=20=20=20=20=20=20=20=20(delq=20buffer=20auto-revert--polled-buffers)))=0A= =20=0A=20;;;###autoload=0A=20(define-minor-mode=20auto-revert-mode=0A@@=20= -367,6=20+399,7=20@@=20without=20being=20changed=20in=20the=20part=20= that=20is=20already=20in=20the=20buffer."=0A=20=20=20(if=20= auto-revert-mode=0A=20=20=20=20=20=20=20(when=20(not=20(memq=20= (current-buffer)=20auto-revert-buffer-list))=0A=20=20=20=20=20=20=20=20=20= (push=20(current-buffer)=20auto-revert-buffer-list)=0A+=20=20=20=20=20=20= =20=20(push=20(current-buffer)=20auto-revert--polled-buffers)=0A=20=20=20= =20=20=20=20=20=20(add-hook=0A=20=20=20=20=20=20=20=20=20=20= 'kill-buffer-hook=0A=20=20=20=20=20=20=20=20=20=20= #'auto-revert-remove-current-buffer=0A@@=20-479,9=20+512,17=20@@=20= specifies=20in=20the=20mode=20line."=0A=20=20=20=20=20=20=20= (auto-revert-buffers)=0A=20=20=20=20=20(dolist=20(buf=20(buffer-list))=0A= =20=20=20=20=20=20=20(with-current-buffer=20buf=0A-=09(when=20= auto-revert-notify-watch-descriptor=0A+=20=20=20=20=20=20=20=20(when=20= (and=20auto-revert-notify-watch-descriptor=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20(not=20(memq=20buf=20= auto-revert-buffer-list)))=0A=20=09=20=20= (auto-revert-notify-rm-watch))))))=0A=20=0A+(defun=20= auto-revert--need-polling-p=20()=0A+=20=20"Whether=20periodic=20polling=20= is=20required."=0A+=20=20(or=20global-auto-revert-mode=0A+=20=20=20=20=20= =20(if=20auto-revert-always-poll=0A+=20=20=20=20=20=20=20=20=20=20= auto-revert-buffer-list=0A+=20=20=20=20=20=20=20=20= auto-revert--polled-buffers)))=0A+=0A=20(defun=20auto-revert-set-timer=20= ()=0A=20=20=20"Restart=20or=20cancel=20the=20timer=20used=20by=20= Auto-Revert=20Mode.=0A=20If=20such=20a=20timer=20is=20active,=20cancel=20= it.=20=20Start=20a=20new=20timer=20if=0A@@=20-492,10=20+533,10=20@@=20= will=20use=20an=20up-to-date=20value=20of=20`auto-revert-interval'"=0A=20= =20=20(if=20(timerp=20auto-revert-timer)=0A=20=20=20=20=20=20=20= (cancel-timer=20auto-revert-timer))=0A=20=20=20(setq=20auto-revert-timer=0A= -=09(if=20(or=20global-auto-revert-mode=20auto-revert-buffer-list)=0A-=09= =20=20=20=20(run-with-timer=20auto-revert-interval=0A-=09=09=09=20=20=20=20= auto-revert-interval=0A-=09=09=09=20=20=20=20'auto-revert-buffers))))=0A= +=09(and=20(auto-revert--need-polling-p)=0A+=09=20=20=20=20=20= (run-with-timer=20auto-revert-interval=0A+=09=09=09=20=20=20=20=20= auto-revert-interval=0A+=09=09=09=20=20=20=20=20'auto-revert-buffers))))=0A= =20=0A=20(defun=20auto-revert-notify-rm-watch=20()=0A=20=20=20"Disable=20= file=20notification=20for=20current=20buffer's=20associated=20file."=0A= @@=20-551,6=20+592,8=20@@=20will=20use=20an=20up-to-date=20value=20of=20= `auto-revert-interval'"=0A=20=09=20=20=20=20=20=20=20(gethash=20= auto-revert-notify-watch-descriptor=0A=20=09=09=20=20=20=20=20=20=20=20= auto-revert--buffers-by-watch-descriptor))=0A=20=20=20=20=20=20=20=20=20=20= auto-revert--buffers-by-watch-descriptor)=0A+=20=20=20=20=20=20=20=20= (setq=20auto-revert--polled-buffers=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(delq=20(current-buffer)=20auto-revert--polled-buffers))=0A=20=20=20= =20=20=20=20=20=20(add-hook=20'kill-buffer-hook=20= #'auto-revert-notify-rm-watch=20nil=20t)))))=0A=20=0A=20;;=20If=20we=20= have=20file=20notifications,=20we=20want=20to=20update=20the=20= auto-revert=20buffers=0A@@=20-558,24=20+601,20=20@@=20will=20use=20an=20= up-to-date=20value=20of=20`auto-revert-interval'"=0A=20;;=20often,=20we=20= want=20to=20skip=20some=20revert=20operations=20so=20that=20we=20don't=20= spend=20all=20our=0A=20;;=20time=20reverting=20the=20buffer.=0A=20;;=0A= -;;=20We=20do=20this=20by=20reverting=20immediately=20in=20response=20to=20= the=20first=20in=20a=20flurry=20of=0A-;;=20notifications.=20We=20= suppress=20subsequent=20notifications=20until=20the=20next=20time=0A-;;=20= `auto-revert-buffers'=20is=20called=20(this=20happens=20on=20a=20timer=20= with=20a=20period=20set=20by=0A-;;=20`auto-revert-interval').=0A-(defvar=20= auto-revert-buffers-counter=201=0A-=20=20"Incremented=20each=20time=20= `auto-revert-buffers'=20is=20called")=0A-(defvar-local=20= auto-revert-buffers-counter-lockedout=200=0A-=20=20"Buffer-local=20value=20= to=20indicate=20whether=20we=20should=20immediately=0A-update=20the=20= buffer=20on=20a=20notification=20event=20or=20not.=20If=0A-=0A-=20=20(=3D=20= auto-revert-buffers-counter-lockedout=0A-=20=20=20=20=20= auto-revert-buffers-counter)=0A-=0A-then=20the=20updates=20are=20locked=20= out,=20and=20we=20wait=20until=20the=20next=20call=0A-of=20= `auto-revert-buffers'=20to=20revert=20the=20buffer.=20If=20no=20lockout=20= is=0A-present,=20then=20we=20revert=20immediately=20and=20set=20the=20= lockout,=20so=20that=0A-no=20more=20reverts=20are=20possible=20until=20= the=20next=20call=20of=0A-`auto-revert-buffers'")=0A+;;=20We=20do=20this=20= by=20reverting=20immediately=20in=20response=20to=20the=20first=20in=20a=0A= +;;=20flurry=20of=20notifications.=20Any=20notifications=20during=20the=20= following=0A+;;=20`auto-revert-lockout-interval'=20seconds=20are=20noted=20= but=20not=20acted=20upon=0A+;;=20until=20the=20end=20of=20that=20= interval.=0A+=0A+(defconst=20auto-revert--lockout-interval=202.5=0A+=20=20= "Duration,=20in=20seconds,=20of=20the=20Auto-Revert=20Mode=20= notification=20lockout.=0A+This=20is=20the=20quiescence=20after=20each=20= notification=20of=20a=20file=20being=0A+changed=20during=20which=20no=20= automatic=20reverting=20takes=20place,=20to=0A+prevent=20many=20updates=20= in=20rapid=20succession=20from=20overwhelming=20the=0A+system.")=0A+=0A= +(defvar-local=20auto-revert--lockout-timer=20nil=0A+=20=20"Timer=20= awaiting=20the=20end=20of=20the=20notification=20lockout=20interval,=20= or=20nil.")=0A=20=0A=20(defun=20auto-revert-notify-handler=20(event)=0A=20= =20=20"Handle=20an=20EVENT=20returned=20from=20file=20notification."=0A= @@=20-604,7=20+643,13=20@@=20no=20more=20reverts=20are=20possible=20= until=20the=20next=20call=20of=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(file-name-nondirectory=20= buffer-file-name)))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20;;=20A=20buffer=20w/o=20a=20file,=20like=20dired.=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(null=20= buffer-file-name))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (auto-revert-notify-rm-watch))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(auto-revert-notify-rm-watch)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(when=20(memq=20buffer=20auto-revert-buffer-list)=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(unless=20(memq=20buffer=20= auto-revert--polled-buffers)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(push=20buffer=20auto-revert--polled-buffers))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20Restart=20the=20= timer=20if=20it=20wasn't=20running.=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(unless=20auto-revert-timer=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(auto-revert-set-timer))))))=0A=20=0A= =20=20=20=20=20=20=20=20=20;;=20Loop=20over=20all=20buffers,=20in=20= order=20to=20find=20the=20intended=20one.=0A=20=20=20=20=20=20=20=20=20= (cl-dolist=20(buffer=20buffers)=0A@@=20-630,11=20+675,21=20@@=20no=20= more=20reverts=20are=20possible=20until=20the=20next=20call=20of=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(setq=20= auto-revert-notify-modified-p=20t)=0A=20=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20;;=20Revert=20the=20buffer=20now=20if=20we're=20not=20= locked=20out.=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20= (/=3D=20auto-revert-buffers-counter-lockedout=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffers-counter)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(unless=20auto-revert--lockout-timer=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(auto-revert-handler)=0A-=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(setq=20= auto-revert-buffers-counter-lockedout=0A-=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffers-counter))))))))))=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(setq=20auto-revert--lockout-timer=0A+=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(run-with-timer=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20auto-revert--lockout-interval=20nil=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20#'auto-revert--end-lockout=20= buffer)))))))))))=0A+=0A+(defun=20auto-revert--end-lockout=20(buffer)=0A= +=20=20"End=20the=20lockout=20period=20after=20a=20notification.=0A+If=20= the=20buffer=20needs=20to=20be=20reverted,=20do=20it=20now."=0A+=20=20= (when=20(buffer-live-p=20buffer)=0A+=20=20=20=20(with-current-buffer=20= buffer=0A+=20=20=20=20=20=20(setq=20auto-revert--lockout-timer=20nil)=0A= +=20=20=20=20=20=20(when=20auto-revert-notify-modified-p=0A+=20=20=20=20=20= =20=20=20(auto-revert-handler)))))=0A=20=0A=20(defun=20= auto-revert-active-p=20()=0A=20=20=20"Check=20if=20auto-revert=20is=20= active=20(in=20current=20buffer=20or=20globally)."=0A@@=20-755,13=20= +810,10=20@@=20This=20function=20is=20also=20responsible=20for=20= removing=20buffers=20no=20longer=20in=0A=20Auto-Revert=20Mode=20from=20= `auto-revert-buffer-list',=20and=20for=20canceling=0A=20the=20timer=20= when=20no=20buffers=20need=20to=20be=20checked."=0A=20=0A-=20=20(setq=20= auto-revert-buffers-counter=0A-=20=20=20=20=20=20=20=20(1+=20= auto-revert-buffers-counter))=0A-=0A=20=20=20(save-match-data=0A-=20=20=20= =20(let=20((bufs=20(if=20global-auto-revert-mode=0A-=09=09=20=20=20=20= (buffer-list)=0A-=09=09=20=20auto-revert-buffer-list))=0A+=20=20=20=20= (let=20((bufs=20(cond=20(global-auto-revert-mode=20(buffer-list))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (auto-revert-always-poll=20auto-revert-buffer-list)=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(t=20= auto-revert--polled-buffers)))=0A=20=09=20=20remaining=20new)=0A=20=20=20= =20=20=20=20;;=20Buffers=20with=20remote=20contents=20shall=20be=20= reverted=20only=20if=20the=0A=20=20=20=20=20=20=20;;=20connection=20is=20= established=20already.=0A@@=20-810,8=20+862,7=20@@=20the=20timer=20when=20= no=20buffers=20need=20to=20be=20checked."=0A=20=09(setq=20bufs=20(cdr=20= bufs)))=0A=20=20=20=20=20=20=20(setq=20auto-revert-remaining-buffers=20= bufs)=0A=20=20=20=20=20=20=20;;=20Check=20if=20we=20should=20cancel=20= the=20timer.=0A-=20=20=20=20=20=20(when=20(and=20(not=20= global-auto-revert-mode)=0A-=09=09=20(null=20auto-revert-buffer-list))=0A= +=20=20=20=20=20=20(unless=20(auto-revert--need-polling-p)=0A=20=20=20=20= =20=20=20=20=20(if=20(timerp=20auto-revert-timer)=0A=20=20=20=20=20=20=20= =20=20=20=20=20=20(cancel-timer=20auto-revert-timer))=0A=20=09(setq=20= auto-revert-timer=20nil)))))=0A--=20=0A2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_63FF422E-39C5-4384-BCDA-EBD6A6EE7DB4-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 11:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15565388951050 (code B ref 35418); Mon, 29 Apr 2019 11:55:01 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 11:54:55 +0000 Received: from localhost ([127.0.0.1]:38556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL4s2-0000Gs-O2 for submit@debbugs.gnu.org; Mon, 29 Apr 2019 07:54:55 -0400 Received: from mail158c50.megamailservers.eu ([91.136.10.168]:35404 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL4s0-0000Gj-8K for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 07:54:53 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556538890; bh=gD1tusVh40ZNP3JXWqPzITjHaN/obO76hTNAFyfOMKs=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Y8cShCsvhUB5i0pYzPQT4y4dBTo79LJwhwJYGCpQm/sQG102DsCNZFtwE9GcDJ9ld yNhyHPPFGqw+hwLdJZFm5nUUNGFOy+R0Bcx63RMnKRy3epJHOetVT+9eqK/cqcPSBs a4EvGp/G0ymyJPxzKW5gjzFAXGVA6T5efnmhJIuE= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3TBsm9O000348; Mon, 29 Apr 2019 11:54:50 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <87bm0pqnvl.fsf@gmx.de> Date: Mon, 29 Apr 2019 13:54:48 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <093C7A57-E3EA-446D-B283-07328850094A@acm.org> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <87bm0pqnvl.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0213.5CC6E60A.003B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=NqD/jfVJ c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=0RxXZDt1o24jnOP26QcA:9 a=hH4KKwJBM4O-6qDZ:21 a=RwYATyWX6-ytp6K0:21 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 29 apr. 2019 kl. 09.19 skrev Michael Albinus : >=20 > By design, in filenotify.el, we want see only events which are related > to the file *name*. If you want to be notified for both buffers, you > need to watch both file (names). Well yes, but you want a change to the file to be reported for both = buffers, even if they watch different names, right? Otherwise, it wouldn't make sense at all. If someone is watching a file, = surely it is because changes to the contents of that file are of = interest? Why would the name employed to carry out the changes matter? I'm quite sure there is a simple misunderstanding here; probably my = fault. And again, I don't think it matters much in practice since users = are unlikely to have buffers for different hard links to the same file. = Let's not waste too much time on this. >> However, with the kqueue back-end, file-notify watches do trigger for >> both, as expected. >=20 > Hmm, this is inconsistent. Worth a buig report? Not really, because (a) multiple hard links are rare, (b) even more rare = in Emacs, and (c) inotify isn't used that way by auto-revert (the = directory is watched, not the files). > It was a design decision, that filenotify.el implements directory > watching. Since kqueue does not support this, it must be emulated, = somehow. Well, auto-revert only uses filenotify.el for watching changes to files = (that is, the data corresponding to the names). How filenotify does that = isn't very important. I suppose watching directories when possible has = the advantages: + fewer (kernel-level) descriptors used if there are multiple files of = interest in the same directory + notification about re-created previously removed files with at least one disadvantage: - changes to files not of interest have to be considered and rejected, = spending more CPU and power. This can be non-trivial; consider looking = at a single non-changing file in a very busy directory with files being = added and removed all the time. For kqueue and w32notify (and FSEvent) there isn't much choice. >> What other reasons are you thinking about? >=20 > The reasons you have already quoted somewhere else: sometimes, file > notification is not applicable; there are not enough descriptors left; = a > file might have been deleted; a file notification process has been > killed silently; you name it ... Thank you. Most of those cases should not cause any trouble -- except = unreliable file notification processes, but since = `auto-revert-remote-files' defaults to nil, it didn't look like a = serious problem. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 12:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15565403143183 (code B ref 35418); Mon, 29 Apr 2019 12:19:01 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 12:18:34 +0000 Received: from localhost ([127.0.0.1]:38570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL5Ew-0000pH-1M for submit@debbugs.gnu.org; Mon, 29 Apr 2019 08:18:34 -0400 Received: from mout.gmx.net ([212.227.15.18]:51251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL5Eu-0000p4-Tj for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 08:18:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556540302; bh=4YrDRyHUJNODAdaA0WQdyefL0jsk95UR8t45uAs/TQY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=lJctczP7AtK+7rhLxnrradZCnZeYT9wYwByVmhO7m4hUnRHZtqOINch0x2dLvK1kv VJHSFcTGuGUkkwGYQAgOh5i3OPXDDwk3AmNwYjmOcCUf31n9Q9F+ZT1+SSig3i9uGD Ew0WxnyyRYQsXUchb29ERv3Tak+PD1BSMtbV7dDE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([213.220.159.69]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MqaxO-1gyviI28RM-00maWP; Mon, 29 Apr 2019 14:18:22 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> Date: Mon, 29 Apr 2019 14:18:20 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Mon, 29 Apr 2019 13:06:50 +0200") Message-ID: <87imuxxawj.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:W805P8V9yNodyHMFZAqVT2wc63IoE+9vcA0brfXh1hTXJ5oyRGG ffoiu8yWJ+o4sz+pEapV24+wGB2Q9KTMBu6DKcOajjtuq6DeuyM0CnXPENEEuOpjNMjkx8W QZhpLB4bNoEmxphRfMUboqbEkDCk1V6vn4VwN85O2090ncnuTqp8U+kUvAtbWKef/c8zLqc g/Vd0aZ6y9po4riuwjz4Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:1gxL7+nJn48=:IiCqHeFX6Waa12Nfukz4xU MzUQi5VEP1KL1F5zCrwGyT115T7g5HKFagOp9YYoo3IKizDMEOOHTWDaGFqcNoT4dqtCmRwre jv+isk3lpAYMbAhl7FxLSAj4F7wmRcIkzkyUDXmdkA+LxXDVvK3mxJDTyqnSyCcxEdSUUwtkM 7Gn8EJXQonc1V1oqh63xsnXrPqDBD6pCVYjA08CcFCDnYpjRQuCfx64lGpHBBVtxnt/B9howq jYkvp1yBQbbcat01Bg460qcpg9q0UJ7pYlzJTIdksdWPKsSnSXFpdcloLxroMJrcFj7/aV9kW TsNMPH7OB4DmIXCALIylxoJftWe4Yq0IVr97t55RRJTe0QwqrgSQlVl6FsjnCaqS6wIiLX87n M7NZFuz35w1XqpmcAvd1C+lER8+HLPMNpSyf2wX69jrQTscm8zpc3yWU+FDHZf6DwSDdF5TAE RqF8uwbSAePnRHBZ01HQSM/A70WVGwgkqqDF6yHHH6+LABkx9pEdnWJ9qRXmD6j0C5lxeOVvS N1NHwO5On2rCAVRxJkZbxTXLPWSfgfZK6egPdylNQ4nb+GCxN/A8GIZZNc33LCSy6nwkXfJEp 9ErON7njWsSvP+VyVAFcmMeaJBRAeaIHP1a8Lv9ArVoeuh6szIPDIALF6Eqdofmbf6ri6pi1k +sq6IIJEnnJrg+tciNIptWDDs/MrU9QZYymcG13KfDo83mdNtVtipTkJIg1LNIme8LtgIWykl cjiTnlpmAASEGKO51OqQ8D2/VxYdsghEYmm/jP1LqTmDVJ9DAJAlbDoXotoxK3SHnSzo0ULzg q9tXetbqkG+UAkpdCXGvTGc1T86L2unEWHYdZZDhofLZ5CwcFR7oOo+bjQDV6KxplDZ/p0raX PITo+vYvWcgJg84e5TZagZUX4F5HvySEX0ldtYuhAoEWnY+kRpWpL9LSSDd765cahEM1lt0uU XqIKQM074FA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: > 29 apr. 2019 kl. 09.53 skrev Michael Albinus : >>=20 >>> Here is an updated patch. There is a new variable, >>> `auto-revert-always-poll', which is t by default. >>> There is also a note in etc/NEWS. Does it merit a mention in the >>> manual as well? >>=20 >> Yes, please. > > There is now a paragraph added to the manual. > > By the way, the organisation of this part of the manual could be > improved -- don't you agree? I hardly disagree, this is always true :-) > There is a section called Reverting, which starts about > `revert-buffer' but then goes on to talk about the auto-revert, > global-auto-revert and auto-revert-tail modes and details about the > mechanisms behind them: polling, intervals, notification. > > Then there is a (sibling) section called Autorevert, which despite its > name only talks about auto-reverting non-file buffers. > > This can be reorganised in various ways. We could move all autorevert > text to a sibling node to Reverting, or to one or more child nodes. In > any case, such text shuffling should not be part of this patch. I would let it for you. >> Saying this, the user option might need another name. What about >> `auto-revert-also-poll'? > > Naming is always hard. I started with `auto-revert-avoid-polling' but > wanted to avoid a negative name. > I tried `auto-revert-also-poll' but it somehow didn't feel right; not > all buffers use notification. > It is nothing I feel strongly about, so if you do prefer that name > I'll change, but I've kept the original name in the patch for now. I have also hard times when choosing a proper name. Do what you believe is best suited, unless Eli comes with something better. (It is my experience over years, that he beats me always with better names.) >> Is this variable needed? It is used only once in >> `auto-revert--need-polling', and it could be computed easily by > > It is also used in `auto-revert-buffers', but you are quite right that > it could be a function. Yes, but the function as proposed would fit as well. > I decided to maintain it as a derived state > because it felt silly to replace O(1) code with O(N), and the > invariant is clear enough (stated in its doc string). (Some of the > places where the variable is updated are O(N) but less frequently > executed.) Yes, but is N large enough to experience the difference? > I can replace it with a function if you want, but the code didn't seem > to gain much from doing so. There are several places you need to modify the variable. This gave me the impression that one function would fit better, because if you need to touch (set) avariable at several places, there are good chances to miss it somewhere. I'm not saying you do in this case, it is just my style to keep things together (in one function, for example). >> `auto-revert--need-polling' shall always return the buffer list, also for >> `global-auto-revert-mode'. > > Sorry, it was meant as a predicate and is only used as such. > Clarified by renaming it to `auto-revert--need-polling-p'. My proposal was to use it NOT as a predicate, but as a function returning the buffer list. > Thank you very much for your review! Updated patch attached. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 12:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15565407913915 (code B ref 35418); Mon, 29 Apr 2019 12:27:01 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 12:26:31 +0000 Received: from localhost ([127.0.0.1]:38576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL5Md-000115-2C for submit@debbugs.gnu.org; Mon, 29 Apr 2019 08:26:31 -0400 Received: from mout.gmx.net ([212.227.17.20]:40197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL5Mb-00010r-Fo for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 08:26:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556540771; bh=jNe+zK5s2hcgj3kuXX8Sur9FnQX7KHYDquhHNqIcTbQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Ix/18CCOoRMgvJmUVn/fMiVkqDiXzBApB5z2bvCtk/q9+XsEiFY8z/t6D8s3I5mr5 6jHHUea4zMpGhyEUVEGA0OSbEQVWfhXRPwfb4UBvi0UNQ6htdgYS8zyL24l5qJonf9 h5b6lvTJxJWs/yEB/4WlbssW7XDmtIHde0Alu06A= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([213.220.159.69]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Le69A-1h01Hj2Dls-00pxxa; Mon, 29 Apr 2019 14:26:11 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <87bm0pqnvl.fsf@gmx.de> <093C7A57-E3EA-446D-B283-07328850094A@acm.org> Date: Mon, 29 Apr 2019 14:26:09 +0200 In-Reply-To: <093C7A57-E3EA-446D-B283-07328850094A@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Mon, 29 Apr 2019 13:54:48 +0200") Message-ID: <87ef5lxaji.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:913XtnQXPvU6YG23aNz+lSw/+DE+6AACLS5IRVqGxsEsMqX54s0 BK6lMlgRzvw57gVrEjkMpGrSIdIcBA2voIPIq4SsPBNZzoFNo5++NaGfBAr3IAN3buDXqgB J/zQhDqnazDjPDPcuWLEBHImBNURQa91Vcg9e8xZaUWvwluaWvMt50LS4ANE8NHOYlA3xxh OpRBfchAtEe2HB4DuF4iA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Opv+nc2AZfE=:kYvdGrBVL71K8yqqXAsm/L PAHIBViLiCAGNOd1Bmm054YzulfewVvxgqe1CH50CkLG/R6d4JGDUjdoJIRIiegSQHFdBGeZO 6eW34Oa11Qa0V0foeVjvo5XjkikbmNWfA/RShsw74C15+NlKP35IT0UDi5iRjwzuCm/lVBu57 tNJ6hbsSKuiXrk5070WrldktnhI4MFsvmKHTk0FSatFK5Cu4fJ+vwwDMF5bguMFP7At9AQV3C a1JcbAFdJq6fL+I7P7NmDpBdaGmDyXp99wb1z06AkKc0bIFRx6wWMzf/r/8r7ORTVJf1BnVhH dIE36+o3qrhvUnC2AZI9loXU4m5jIhKcZUe1py7rMMo1TEwaGfhvbIkILW3NMxuNelC/tGpEu sXXYPJVnrkdH4jaFAhiXPxVKz8i1u8hYjEpqq46Dk4P8azVxLL6zES+a6kyzxiIY2Fuix8EkU 0B9y0wR32Gw1K6rw8UyfIUyknahj3t+OEQaoSF59/10Uy1F79cLLCwI8UtHEE10fU57hMw0kW esEBJ/YEwakAdi7NUpjSIYym+0kcISHdHFIclHiy0nOexCv1I5Qdnle6QPprdfCh6xaqtJUh9 cgYAN5IP+rxov1J0Z4OTDhTT3xraOT/rjibfB1woGUXmj5tLl98T0qdHFeDgnt61Ifw2nITDd ARo8e+AvQtzGc393rkq++Hx5tgbguvQ9ReSmmLkptdSv29Ll9GqguCqMcWw49GHG0sjRfzL0Y b4m2dQNwjB6oz3B1eB7YdUNHQTgQqD3eEw6aBj6vKJN9fJWdLLAahSlhpZuUhoMRDsg2q4+eQ CGDrqfr+w8U4xOg+0LQB9ixGnSUey6Hg5PodpExesKVjtAkq2QZrarcJKvuDg8lbls4BciH5H VLI/KTBHXfzRRWDm7PIozBUYyeaFiNq6AbNwUNN7B2m6tYJf+gHz+1sdORP1TU3LgoV0pWfKV SolX4qg4ecg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: >> By design, in filenotify.el, we want see only events which are related >> to the file *name*. If you want to be notified for both buffers, you >> need to watch both file (names). > > Well yes, but you want a change to the file to be reported for both > buffers, even if they watch different names, right? You don't know first hand, which buffers contain the same file hard linked together. This can be determined only via the inode and device numbers; something we don't apply yet. How do you know otherwise, that "/tmp/foo" and "/tmp/bar" are the same, visited in different buffers? > Otherwise, it wouldn't make sense at all. If someone is watching a > file, surely it is because changes to the contents of that file are of > interest? Why would the name employed to carry out the changes matter? That's a desirable feature, I agree. But we haven't implemented it yet. Likely, we shall say so in the doc. > I'm quite sure there is a simple misunderstanding here; probably my > fault. And again, I don't think it matters much in practice since > users are unlikely to have buffers for different hard links to the > same file. Let's not waste too much time on this. Agreed. I won't change something in this respect, until there is a bug report / feature request. And as said, maybe you could add a sentence about in the manual. > Thank you. Most of those cases should not cause any trouble -- except > unreliable file notification processes, but since > `auto-revert-remote-files' defaults to nil, it didn't look like a > serious problem. As Tramp maintainer, I always set `auto-revert-remote-files' to t :-) So I care. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 16:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155655505028537 (code B ref 35418); Mon, 29 Apr 2019 16:25:01 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 16:24:10 +0000 Received: from localhost ([127.0.0.1]:39573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL94c-0007QC-7L for submit@debbugs.gnu.org; Mon, 29 Apr 2019 12:24:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL94b-0007Pu-3s for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 12:24:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL94V-0005nI-Mn; Mon, 29 Apr 2019 12:24:03 -0400 Received: from [176.228.60.248] (port=1820 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hL94U-0002aS-P2; Mon, 29 Apr 2019 12:24:03 -0400 Date: Mon, 29 Apr 2019 19:23:53 +0300 Message-Id: <834l6gu6ee.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Mon, 29 Apr 2019 13:06:50 +0200) References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Mon, 29 Apr 2019 13:06:50 +0200 > Cc: Eli Zaretskii , 35418@debbugs.gnu.org > > By the way, the organisation of this part of the manual could be improved -- don't you agree? Could be. > There is a section called Reverting, which starts about `revert-buffer' but then goes on to talk about the auto-revert, global-auto-revert and auto-revert-tail modes and details about the mechanisms behind them: polling, intervals, notification. > > Then there is a (sibling) section called Autorevert, which despite its name only talks about auto-reverting non-file buffers. You say "section" but the names you cite are node names, not section names. The latter are slightly more descriptive. > This can be reorganised in various ways. We could move all autorevert text to a sibling node to Reverting, or to one or more child nodes. In any case, such text shuffling should not be part of this patch. I think we should have sibling sections "Reverting" and "Autorevert", with the latter describing both types of auto-reverting. And "Reverting" should have a cross-reference to "Autorevert" for automatic reverting of file-visiting buffers. Would you like to submit a patch to that effect? > > Saying this, the user option might need another name. What about > > `auto-revert-also-poll'? > > Naming is always hard. I started with `auto-revert-avoid-polling' but wanted to avoid a negative name. > I tried `auto-revert-also-poll' but it somehow didn't feel right; not all buffers use notification. > It is nothing I feel strongly about, so if you do prefer that name I'll change, but I've kept the original name in the patch for now. I actually think auto-revert-dont-poll is better, even though it's negative. Thanks. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 16:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: mattiase@acm.org, 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155655512228724 (code B ref 35418); Mon, 29 Apr 2019 16:26:01 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 16:25:22 +0000 Received: from localhost ([127.0.0.1]:39582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL95l-0007TB-Ki for submit@debbugs.gnu.org; Mon, 29 Apr 2019 12:25:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL95k-0007Se-AR for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 12:25:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL95Z-0006Ay-Gu; Mon, 29 Apr 2019 12:25:10 -0400 Received: from [176.228.60.248] (port=1888 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hL95X-0002f6-QO; Mon, 29 Apr 2019 12:25:08 -0400 Date: Mon, 29 Apr 2019 19:24:59 +0300 Message-Id: <8336m0u6ck.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87imuxxawj.fsf@gmx.de> (message from Michael Albinus on Mon, 29 Apr 2019 14:18:20 +0200) References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <87imuxxawj.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: Eli Zaretskii , 35418@debbugs.gnu.org > Date: Mon, 29 Apr 2019 14:18:20 +0200 > > > Naming is always hard. I started with `auto-revert-avoid-polling' but > > wanted to avoid a negative name. > > I tried `auto-revert-also-poll' but it somehow didn't feel right; not > > all buffers use notification. > > It is nothing I feel strongly about, so if you do prefer that name > > I'll change, but I've kept the original name in the patch for now. > > I have also hard times when choosing a proper name. Do what you believe > is best suited, unless Eli comes with something better. (It is my > experience over years, that he beats me always with better names.) Really? I actually consider myself being bad with naming. Let's see if you like my suggestion this time. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 18:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155656255316175 (code B ref 35418); Mon, 29 Apr 2019 18:30:02 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 18:29:13 +0000 Received: from localhost ([127.0.0.1]:39684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLB1c-0004Co-Pk for submit@debbugs.gnu.org; Mon, 29 Apr 2019 14:29:13 -0400 Received: from mail232c50.megamailservers.eu ([91.136.10.242]:53204 helo=mail37c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLB1b-0004Ce-4r for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 14:29:12 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556562549; bh=S0GliIX+CAKhnH13nTr8m+jJEpY23gh4jxlqgXDDCPw=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=MK38lNpY7EUL1Vpt7xNWFlLinKvJytEpwPtePycr5lalx5doTZ00k///eubW0HS0v Vg/vwmE+3GhPwcHBB3B1SSoDAqQUsUlBQK4g3M0fPFPxGGYsXyDbn/eqoxa2+qvc+3 dN+cnI9E0pmM4/ZzwbR7Lmcj9OUqw3BBv+GjIdiM= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3TIT7GD014355; Mon, 29 Apr 2019 18:29:08 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_562E6D03-ACA9-4D83-8308-BCD7690D009F" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Date: Mon, 29 Apr 2019 20:29:07 +0200 In-Reply-To: <87imuxxawj.fsf@gmx.de> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <87imuxxawj.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B020A.5CC74275.003B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=QrpwI26d c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=f1abiShv9wPjO9RxvYYA:9 a=CjuIK1q_8ugA:10 a=q6jAsax-SiwqlBvZBbQA:9 a=B2y7HmGcmWMA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_562E6D03-ACA9-4D83-8308-BCD7690D009F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 29 apr. 2019 kl. 14.18 skrev Michael Albinus : >=20 >> I decided to maintain it as a derived state >> because it felt silly to replace O(1) code with O(N), and the >> invariant is clear enough (stated in its doc string). (Some of the >> places where the variable is updated are O(N) but less frequently >> executed.) >=20 > Yes, but is N large enough to experience the difference? These things are tricky to measure, but obviously inefficient code just = doesn't feel right to write. For example, generating a list just to see = if it is non-empty, when that could be determined in a more = straightforward way. > My proposal was to use it NOT as a predicate, but as a function > returning the buffer list. Very well; here is an incremental patch (to make the differences clear). = It's a compromise: the derived state is gone, but there are two = functions: one for the list of buffers that need to be polled, and one = for whether that list would be non-empty. By the way, the patch now uses functions from cl-lib, not just macros. = Is there any reason not to? --Apple-Mail=_562E6D03-ACA9-4D83-8308-BCD7690D009F Content-Disposition: attachment; filename=0001-Eliminate-the-auto-revert-polled-buffers-variable.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Eliminate-the-auto-revert-polled-buffers-variable.patch" Content-Transfer-Encoding: quoted-printable =46rom=20e3fe91d6b760b8325c352e6220997f569f7f2d44=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Mon,=2029=20Apr=202019=2020:21:32=20+0200=0A= Subject:=20[PATCH]=20Eliminate=20the=20auto-revert--polled-buffers=20= variable=0A=0AInstead=20of=20maintaining=20the=20= `auto-revert--polled-buffers'=20variable,=0Acalculate=20it=20when=20= needed.=20=20When=20only=20its=20emptiness=20is=20of=20interest,=0Ado=20= so=20in=20a=20more=20efficient=20way.=0A---=0A=20lisp/autorevert.el=20|=20= 46=20++++++++++++++++++++++------------------------=0A=201=20file=20= changed,=2022=20insertions(+),=2024=20deletions(-)=0A=0Adiff=20--git=20= a/lisp/autorevert.el=20b/lisp/autorevert.el=0Aindex=20= b16b1b5833..6387ef1e92=20100644=0A---=20a/lisp/autorevert.el=0A+++=20= b/lisp/autorevert.el=0A@@=20-107,7=20+107,7=20@@=0A=20=0A=20;;=20= Dependencies:=0A=20=0A-(eval-when-compile=20(require=20'cl-lib))=0A= +(require=20'cl-lib)=0A=20(require=20'timer)=0A=20(require=20= 'filenotify)=0A=20=0A@@=20-342,11=20+342,6=20@@=20the=20list=20of=20old=20= buffers.")=0A=20(defvar=20auto-revert-tail-pos=200=0A=20=20=20"Position=20= of=20last=20known=20end=20of=20file.")=0A=20=0A-(defvar=20= auto-revert--polled-buffers=20()=0A-=20=20"List=20of=20buffers=20in=20= Auto-Revert=20Mode=20that=20must=20be=20polled.=0A-It=20contains=20the=20= buffers=20in=20`auto-revert-buffer-list'=20whose=0A= -`auto-revert-notify-watch-descriptor'=20is=20nil.")=0A-=0A=20(defun=20= auto-revert-find-file-function=20()=0A=20=20=20(setq-local=20= auto-revert-tail-pos=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (file-attribute-size=20(file-attributes=20buffer-file-name))))=0A@@=20= -374,12=20+369,8=20@@=20This=20has=20been=20reported=20by=20a=20file=20= notification=20event.")=0A=20(defun=20auto-revert-remove-current-buffer=20= (&optional=20buffer)=0A=20=20=20"Remove=20BUFFER=20from=20= `auto-revert-buffer-list'.=0A=20BUFFER=20defaults=20to=20= `current-buffer'."=0A-=20=20(unless=20buffer=0A-=20=20=20=20(setq=20= buffer=20(current-buffer)))=0A=20=20=20(setq=20auto-revert-buffer-list=0A= -=20=20=20=20=20=20=20=20(delq=20buffer=20auto-revert-buffer-list))=0A-=20= =20(setq=20auto-revert--polled-buffers=0A-=20=20=20=20=20=20=20=20(delq=20= buffer=20auto-revert--polled-buffers)))=0A+=20=20=20=20=20=20=20=20(delq=20= (or=20buffer=20(current-buffer))=20auto-revert-buffer-list)))=0A=20=0A=20= ;;;###autoload=0A=20(define-minor-mode=20auto-revert-mode=0A@@=20-399,7=20= +390,6=20@@=20without=20being=20changed=20in=20the=20part=20that=20is=20= already=20in=20the=20buffer."=0A=20=20=20(if=20auto-revert-mode=0A=20=20=20= =20=20=20=20(when=20(not=20(memq=20(current-buffer)=20= auto-revert-buffer-list))=0A=20=20=20=20=20=20=20=20=20(push=20= (current-buffer)=20auto-revert-buffer-list)=0A-=20=20=20=20=20=20=20=20= (push=20(current-buffer)=20auto-revert--polled-buffers)=0A=20=20=20=20=20= =20=20=20=20(add-hook=0A=20=20=20=20=20=20=20=20=20=20'kill-buffer-hook=0A= =20=20=20=20=20=20=20=20=20=20#'auto-revert-remove-current-buffer=0A@@=20= -516,12=20+506,26=20@@=20specifies=20in=20the=20mode=20line."=0A=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(not=20(memq=20buf=20= auto-revert-buffer-list)))=0A=20=09=20=20= (auto-revert-notify-rm-watch))))))=0A=20=0A+(defun=20= auto-revert--polled-buffers=20()=0A+=20=20"List=20of=20buffers=20that=20= need=20to=20be=20polled."=0A+=20=20(cond=20(global-auto-revert-mode=20= (buffer-list))=0A+=20=20=20=20=20=20=20=20(auto-revert-always-poll=20= auto-revert-buffer-list)=0A+=20=20=20=20=20=20=20=20(t=20(mapcan=20= (lambda=20(buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(and=20(not=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buffer))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(list=20buffer)))=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffer-list))))=0A+=0A+;;=20Same=20as=20above=20in=20a=20= boolean=20context,=20but=20cheaper.=0A=20(defun=20= auto-revert--need-polling-p=20()=0A=20=20=20"Whether=20periodic=20= polling=20is=20required."=0A=20=20=20(or=20global-auto-revert-mode=0A=20=20= =20=20=20=20=20(if=20auto-revert-always-poll=0A=20=20=20=20=20=20=20=20=20= =20=20auto-revert-buffer-list=0A-=20=20=20=20=20=20=20=20= auto-revert--polled-buffers)))=0A+=20=20=20=20=20=20=20=20(not=20= (cl-every=20(lambda=20(buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=0A+=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buffer))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffer-list)))))=0A=20=0A=20(defun=20auto-revert-set-timer=20= ()=0A=20=20=20"Restart=20or=20cancel=20the=20timer=20used=20by=20= Auto-Revert=20Mode.=0A@@=20-592,8=20+596,6=20@@=20will=20use=20an=20= up-to-date=20value=20of=20`auto-revert-interval'"=0A=20=09=20=20=20=20=20= =20=20(gethash=20auto-revert-notify-watch-descriptor=0A=20=09=09=20=20=20= =20=20=20=20=20auto-revert--buffers-by-watch-descriptor))=0A=20=20=20=20=20= =20=20=20=20=20auto-revert--buffers-by-watch-descriptor)=0A-=20=20=20=20=20= =20=20=20(setq=20auto-revert--polled-buffers=0A-=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(delq=20(current-buffer)=20auto-revert--polled-buffers))=0A= =20=20=20=20=20=20=20=20=20(add-hook=20'kill-buffer-hook=20= #'auto-revert-notify-rm-watch=20nil=20t)))))=0A=20=0A=20;;=20If=20we=20= have=20file=20notifications,=20we=20want=20to=20update=20the=20= auto-revert=20buffers=0A@@=20-644,12=20+646,10=20@@=20system.")=0A=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20A=20buffer=20= w/o=20a=20file,=20like=20dired.=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(null=20buffer-file-name))=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(auto-revert-notify-rm-watch)=0A-=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(when=20(memq=20buffer=20= auto-revert-buffer-list)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(unless=20(memq=20buffer=20auto-revert--polled-buffers)=0A-=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(push=20buffer=20= auto-revert--polled-buffers))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20;;=20Restart=20the=20timer=20if=20it=20wasn't=20running.=0A-=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(unless=20= auto-revert-timer=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(auto-revert-set-timer))))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20;;=20Restart=20the=20timer=20if=20it=20wasn't=20running.=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20(and=20(memq=20= buffer=20auto-revert-buffer-list)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(not=20auto-revert-timer))=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (auto-revert-set-timer)))))=0A=20=0A=20=20=20=20=20=20=20=20=20;;=20Loop=20= over=20all=20buffers,=20in=20order=20to=20find=20the=20intended=20one.=0A= =20=20=20=20=20=20=20=20=20(cl-dolist=20(buffer=20buffers)=0A@@=20-811,9=20= +811,7=20@@=20Auto-Revert=20Mode=20from=20`auto-revert-buffer-list',=20= and=20for=20canceling=0A=20the=20timer=20when=20no=20buffers=20need=20to=20= be=20checked."=0A=20=0A=20=20=20(save-match-data=0A-=20=20=20=20(let=20= ((bufs=20(cond=20(global-auto-revert-mode=20(buffer-list))=0A-=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (auto-revert-always-poll=20auto-revert-buffer-list)=0A-=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(t=20= auto-revert--polled-buffers)))=0A+=20=20=20=20(let=20((bufs=20= (auto-revert--polled-buffers))=0A=20=09=20=20remaining=20new)=0A=20=20=20= =20=20=20=20;;=20Buffers=20with=20remote=20contents=20shall=20be=20= reverted=20only=20if=20the=0A=20=20=20=20=20=20=20;;=20connection=20is=20= established=20already.=0A--=20=0A2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_562E6D03-ACA9-4D83-8308-BCD7690D009F-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 18:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155656430319223 (code B ref 35418); Mon, 29 Apr 2019 18:59:01 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 18:58:23 +0000 Received: from localhost ([127.0.0.1]:39728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLBTr-0004zy-Ac for submit@debbugs.gnu.org; Mon, 29 Apr 2019 14:58:23 -0400 Received: from mail150c50.megamailservers.eu ([91.136.10.160]:50724 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLBTo-0004zo-S4 for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 14:58:21 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556564298; bh=FzwamXLr4D2JhYyOJLlr/rHbbv3MGOGaypVZlTLE5rs=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Fi5bQybIH9+iPUM+LT7lZDxnLv9gVPP9LbI06KPSvDQnyX9AHvWgdZ37wFOKHSt8e EnWtNUo2ZxS9xji/ojt+2U7SYZHpFtnS/MwSFnMeasAFXgFVKNCqe3BXpjutXIVWkV IO1F9jKWVBHV9T3nyzvRYCENomhO2qOiqqt9osuE= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3TIwHoF028585; Mon, 29 Apr 2019 18:58:18 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <87ef5lxaji.fsf@gmx.de> Date: Mon, 29 Apr 2019 20:58:15 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <87bm0pqnvl.fsf@gmx.de> <093C7A57-E3EA-446D-B283-07328850094A@acm.org> <87ef5lxaji.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0205.5CC7494A.0056, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=NJj7BXyg c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=Vms72sp_pyoweBUakfkA:9 a=5gBDcGZPBRQPXB4T:21 a=o_HqhZMtnRNHOa-9:21 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 29 apr. 2019 kl. 14.26 skrev Michael Albinus : >=20 > You don't know first hand, which buffers contain the same file hard > linked together. This can be determined only via the inode and device > numbers; something we don't apply yet. >=20 > How do you know otherwise, that "/tmp/foo" and "/tmp/bar" are the = same, > visited in different buffers? Thanks, I think I understand what you are concerned about now. It seems to work just as we expect it to (at least in kqueue and = inotify): A file has three hard links, /dir1/a, /dir1/b and /dir2/c. Then: - A watch set on /dir1/a will report changes made to the file via any of = the three links (kqueue, inotify). - A watch set on /dir1 will report changes made to the file via /dir1/a = and /dir1/b, but not /dir2/c (inotify). Since filenotify would use /dir1 to watch /dir1/a with inotify, but = /dir1/a with kqueue, the behaviour differs. We could work around the problem by setting watches on files directly = with inotify, but it's not worth the trouble or the other drawbacks (as = mentioned earlier) for such an uncommon case. > As Tramp maintainer, I always set `auto-revert-remote-files' to t :-) > So I care. Right, so I suppose a user like you would either: (a) not set `auto-revert-always-poll' to nil (b) trust remote file notification to work well enough, and if it fails, = it's not a disaster (no data lost) (c) add a pattern to `auto-revert-notify-exclude-dir-regexp' to disable = particularly unreliable notifications which sounds acceptable. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 19:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 35418@debbugs.gnu.org, Michael Albinus Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155656567921497 (code B ref 35418); Mon, 29 Apr 2019 19:22:02 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 19:21:19 +0000 Received: from localhost ([127.0.0.1]:39767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLBq3-0005af-2y for submit@debbugs.gnu.org; Mon, 29 Apr 2019 15:21:19 -0400 Received: from mail235c50.megamailservers.eu ([91.136.10.245]:43286 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLBq0-0005aP-4Y for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 15:21:17 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556565674; bh=p3hao59QkbD1MFqABtQz1hBhA0m5psWqZ4TPpK0D1lM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=gxMdSzZZ+ykWKUxbD09UIatcI25pbo3RlSneeUlTGzkRN/TMyA3tD8OlohlFtMvM7 JhJK7JNfz/pTdYPODhe4sYP/ZQPFyl2/tRdUW6XSzxQhXhRnPH7bks8ZFDKjEbICkb rhLhCQURS2kCg+Vt6St5ywRYZi/xJWugcesmEEL4= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3TJLC0u004051; Mon, 29 Apr 2019 19:21:14 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <834l6gu6ee.fsf@gnu.org> Date: Mon, 29 Apr 2019 21:21:12 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0210.5CC74EAA.004E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Bbz2LIl2 c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=3EcVNkd7z6PwEcaOn2kA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 29 apr. 2019 kl. 18.23 skrev Eli Zaretskii : >=20 >> There is a section called Reverting, which starts about = `revert-buffer' but then goes on to talk about the auto-revert, = global-auto-revert and auto-revert-tail modes and details about the = mechanisms behind them: polling, intervals, notification. >>=20 >> Then there is a (sibling) section called Autorevert, which despite = its name only talks about auto-reverting non-file buffers. >=20 > You say "section" but the names you cite are node names, not section > names. The latter are slightly more descriptive. Correct, thank you. (The node names attract the eyes since they are = highlighted as links.) >> This can be reorganised in various ways. We could move all autorevert = text to a sibling node to Reverting, or to one or more child nodes. In = any case, such text shuffling should not be part of this patch. >=20 > I think we should have sibling sections "Reverting" and "Autorevert", > with the latter describing both types of auto-reverting. And > "Reverting" should have a cross-reference to "Autorevert" for > automatic reverting of file-visiting buffers. >=20 > Would you like to submit a patch to that effect? I'll see what I can do, once we are done with this particular patch. >>> Saying this, the user option might need another name. What about >>> `auto-revert-also-poll'? >>=20 >> Naming is always hard. I started with `auto-revert-avoid-polling' but = wanted to avoid a negative name. >> I tried `auto-revert-also-poll' but it somehow didn't feel right; not = all buffers use notification. >> It is nothing I feel strongly about, so if you do prefer that name = I'll change, but I've kept the original name in the patch for now. >=20 > I actually think auto-revert-dont-poll is better, even though it's > negative. Then I'd prefer auto-revert-avoid-polling; 'don't poll' sounds = definitive but we may still have to poll from time to time. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 19:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155656781824812 (code B ref 35418); Mon, 29 Apr 2019 19:57:02 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 19:56:58 +0000 Received: from localhost ([127.0.0.1]:39801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLCOX-0006S8-Vq for submit@debbugs.gnu.org; Mon, 29 Apr 2019 15:56:58 -0400 Received: from mout.gmx.net ([212.227.17.20]:49761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLCOV-0006Rs-Ku for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 15:56:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556567805; bh=YmJJzV6PSBCprDd7EdGxEtikCD7Zkqph/iKmWoYifd0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=dB8mLb9rZN1StPg7vM66qfDno4eH3lrhP37CyHJBTy3SpzmQujjdhF3KnCV1bvRe9 +AkHEtxO8qyMqkRnsKxTVgHgfSr4pvK7vej148NnYVXK0i+mbJVi8w+AtKX8pQJElG 9WAi4x4x4SoK/0ISBLl4hyUHMjvgRyTFAB75FCZc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([213.220.159.69]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LyS5K-1gg1v90UdC-015pOy; Mon, 29 Apr 2019 21:56:45 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> Date: Mon, 29 Apr 2019 21:56:42 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Mon, 29 Apr 2019 21:21:12 +0200") Message-ID: <87k1fczith.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:wXM6q0mkYcBfOFb4Nqsc1WYfUCQK0qlTZ89zATUcHj97pPYxWZV Ng6bRMSbvXXUgRHyVB+R6KM7ZXCdSE8yxrkG3MPv0F+vgOE0CXroAku4ccClKkr4gDreIG2 UY4y1wQna5uxdWibAPpZXaM0nO6paA2G8SvNfjgVkTQIG7EXYFKcom3ZXlChSDq88sgeJ3L CqKOPIfT5zyaIcW463EVA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:HVuxEVX8AB0=:dxi9PmVnxsI4g7M3n+UXs7 wtfyQuytdD+7imBEPe9GQkXiwcEGCESd/6JwCWUAT77bzcwfRl+d8d0HvBSVI+jpTS6KY0dO8 x2/1tiqbLH1sO5BwIiCJQoVTwS6/g3rOUKGQNbNJEkp/YGjwtE8rSL35wu1s0L2rxDYIMO6pA UUEqhZj7G0HgyFZ58DX+vCSQOpwb18s6BwZqoH8X8rP9HVXHgKbZgp8n6wLONl5iXeip/s5Wl GEcYN5+Nrh+IYlImScKklYzwm4A7iofOGeQxQGGQtGQW9HZhF6Tj0yjW2hX6e9e8aznKO/PjK pYtRGAA4f8x2TIKwxeNZWh10zkpmhaulNscXhnVCtaRVYmVgPzgda4oVKnJd8QVJ4Kr+PgRtN J0wx4ZMtHuR/soJpQlRah603uSyNT6TjNkggsx5MFsfaJ1DbHpzn6Ou28kFh9lmDUlU0OxDlr 7cxAcYyJkToOoWyCHhaPh/kYYzMMIXpMoDkct7zKog6nA84lS2edQYyuPi/4BsGgFcwIX1ChX dO2VuuWTYGlYfZRbxov1Kw00VquAquz3NxDwvSY9HYQwgaZzk+SmTKweS3ZS49l6V7HsWuVAA mElYkqLzq7AQVj5eVDYc8dE07qOg72WReTUpNWhXNTKx/INiZCwek0u5Qlr6TyFIxXqITP69F It1elQkuIUQ5EBw89fPltRxE/xqDQDGBAmuge2ucdh+qDKkNZDF8z8feQp6U0bFizukPluqE0 ELNnqOr/iLLCHyYVq/a6vHzV3+jbbB7kX3fp4t+YcOrIu3tszoQsx61AwYr9lYn4RZ6s/v+0K dyWUlnVa/Ppjlm//QExIM5vL/nn2OmxppwLpVwnfFOI8KJmnqJ3AavJFvF1vKqOKJWMO271Pq hNZMcyuoOon8TU/54Y9KV7dJrmuD84vXToCRS/8LZivERhTroKmrRo5CyOWUKfbgPPuCeInhS REf/8FVmGFg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, =20 >> I actually think auto-revert-dont-poll is better, even though it's >> negative. > > Then I'd prefer auto-revert-avoid-polling; 'don't poll' sounds > definitive but we may still have to poll from time to time. Sounds good to my ears. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 20:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155656826125652 (code B ref 35418); Mon, 29 Apr 2019 20:05:02 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 20:04:21 +0000 Received: from localhost ([127.0.0.1]:39829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLCVg-0006fg-Ls for submit@debbugs.gnu.org; Mon, 29 Apr 2019 16:04:20 -0400 Received: from mout.gmx.net ([212.227.15.18]:40551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLCVf-0006fT-Jx for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 16:04:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556568251; bh=mmG43eGLYixKMeODNrqOF1GntSuDXcheyDfrGYH1dsE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=jwaf7IYYjeIqVn/IfW3v4VZ8FA4DIrgFrZ70JTB/AzvDHmc6l6vTyWTgn0Qrh0yk3 kCsvi0YRXPtpyY+KTuLO9NXCq2+4TQKSiTpI8aMhiQTmXPw0A/DfRlamy0pWDbixAR e7xZovNd86mnm23qvheudmPbuxU+iXcobl7bq5jw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([213.220.159.69]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lqi70-1gpyUC44F0-00eKgy; Mon, 29 Apr 2019 22:04:11 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <87bm0pqnvl.fsf@gmx.de> <093C7A57-E3EA-446D-B283-07328850094A@acm.org> <87ef5lxaji.fsf@gmx.de> Date: Mon, 29 Apr 2019 22:04:06 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Mon, 29 Apr 2019 20:58:15 +0200") Message-ID: <87ftq0zih5.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:bbNVkVHs4ZLm2qqyFSS4jEZaCw7tntj2P3KZnaCxMI8ckn5/kp8 yH03VDOvMAReNHaEnZs8jYqOVhvrqmWadB+tH8Ev8CyIbAcpKOCvdGGjZpdNVblLRva3yt+ rcXcs/PCe5GuK/QxFGgd/rmhN/+scNvcdvHKgizA0kBAX2bc0FLSxfMJ/Rpl5HlYoNe4ZLT UydlQNtHE4rjwfdZHaZ/A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:AMC+Ogc2lhM=:ZBgm8FQZidToak+TsBSqnU d+IyOYLaUhe56h83vT5H0QVn5y0cjkbvzPRpMAEOUqSmYO95Kvylu4tgpmYx+4hyVFQX/6pyz 19sgGk6ZmGmplyeKW/QJ5/6ZxU/v8iuvzWrPImuygtXelS1idEbkPd2jkU4IT6Lql99nydMLX KHjbYgmwEMlGet0kJqsY2kPretPys7kq86O0FaYI9rovP+pXUiPYYDpehDUNUrLaiWjmA+zCq qfpfz1P6RuOGM/vN+9nNHk4dastCMrjjt5k4yFNlVW1rqxE34EbWLWjczn3TH0razswyJZme1 qeTDTNbfh6ghCL/Ku2t1P3MOBFbSGJZanCtCvd/KmkPv+xo6CMcCNu0iXS/FeuAZJ6CDoCjzW 7He0ob09rdurLHTHdlVfgph/ypM5SJadR+tHKtJRqixRjKP6rIV6pJjnma4bXeEJM72OvGlod VvKuD3neDtZBBTwRpSIOzY0oD11GOE08RA3Dera5Vf2EZrTFcTmGW1BtNIdqhmz46wKyJoCg8 zAPIOGOecD8tjaY6nI13R4JN+rLtmpxP0NfVym+SpvEVQ2Q1B8NHlVHmqhkqDKF7rJ4kPyCo+ IvtgctxAJdSPsfPrP/v54Kbscfdcc3YEpBAhzbDPLaVJm/rZ8vGMQ/gVWpOb5I3nyWwiD8Vt3 MMnFeKGYsUTiAYonvBbKehS2qsfanV+79DREZ5CwEqhvDaPSnACbmk0az5bI+/jk8EvfFOd23 pNAM3lBODs68mL1YRy+hvhb6QHUdRL5NKxRJ/vKEMKUpkEqKIbhIrSeEtZ8ac6I6WtD+GQJJT 0gzb4hO5rYh1wfTWa+EnJRkjt9UxZJT2d9MA0tf3JSg5KOyVxOvLpoKZ8B7q05nmF/Lmd6pEa cAtqkinJVM6IB6FwLYc0nH8tUwmbb5npO/5fNdz3uB03esmv1AS6tpDqQT+owYAORt8j75W20 O67FbttH7DQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: > We could work around the problem by setting watches on files directly > with inotify, but it's not worth the trouble or the other drawbacks > (as mentioned earlier) for such an uncommon case. If you go back in history (for years), you will find in the archives that we have tried different policies. None of them is perfect, so unless we see serious problems, I propose to keep the things as they are. >> As Tramp maintainer, I always set `auto-revert-remote-files' to t :-) >> So I care. > > Right, so I suppose a user like you would either: > > (a) not set `auto-revert-always-poll' to nil > (b) trust remote file notification to work well enough, and if it > fails, it's not a disaster (no data lost) > (c) add a pattern to `auto-revert-notify-exclude-dir-regexp' to > disable particularly unreliable notifications > > which sounds acceptable. Don't know what other people do, but I'll take (a). Since I have written remote file notifications myself, likely I'm the one who has the least trust for (b) :-) (c) could help, yes. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 20:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15565690582505 (code B ref 35418); Mon, 29 Apr 2019 20:18:02 +0000 Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 20:17:38 +0000 Received: from localhost ([127.0.0.1]:39868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLCiX-0000eL-T8 for submit@debbugs.gnu.org; Mon, 29 Apr 2019 16:17:38 -0400 Received: from mout.gmx.net ([212.227.17.21]:45145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLCiW-0000Yx-2m for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 16:17:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556569044; bh=VbmpX/k3V+AAG/mKYLnp/NGxHEGbg9v+RAEVcP6faaU=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=GC+orUCkI96qjGpz1rH6r2SSEii9eMc+ej3fuohD41MUpZt8LECn4GwAfWfVmwDuN 3aNqMQrJYcBS/pgX9d8VUJyZVWU8dwQ8/LUNa65aHmJ9YnzTKM1XYCgYHnNXlD155b KFui1TY0UDUcmv2UmQii8gge25C2lpjoK2tjubMQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([213.220.159.69]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MWRVb-1hI7El0qJH-00XssA; Mon, 29 Apr 2019 22:17:24 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <87imuxxawj.fsf@gmx.de> Date: Mon, 29 Apr 2019 22:17:23 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Mon, 29 Apr 2019 20:29:07 +0200") Message-ID: <87a7g8zhv0.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:XwLEBdvkvk0Vgmi+Eo4/l80C/fLLK+xjiEHICEw6lnxnG2xoZPx cIq28e+2zQAMtmr+3n9ILW0XR/Mb5C7RT57A3n0ADlVIDtBMhiUZlD7aReUOVT6xAgKjK5e d3D/bHvwfbsHmq2Np36m7filjiTA+X75sqT45LPSVVmijvA0vEF6Nat/nOvdDJvmwfOrVEV olqRd4XrtH5ycTrJ098mg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:CjDH4N1JSTA=:EvKgmLWWVg4UHTl1vvIscn Q5nHd55BO7LaRatk6avDvO6G1g7xMghvklQLlNLX07dS86ZBHHAt4nSMoDzBs/DPXV0i8VVmj 7C5rjBt5WTscR5CXdLMHlKrr8beHSPZ3bcK/qMsYpZGjP6wrOULuz1FpEXbPyFY2UmdGhhSYi aMPB65aqlA/NLmwAyll7J51QVcin5/QNqUxNBZa3tW9RivNTIaE1uPd1yGldLeQqqGHFIu+bq TvfoC20XGsG4/JxrZJKCRhC6iV8s7mStJ/9O/rTlNgF3T8KGOGNg1dRoWfG+F7dZEbS9xLUpJ XKwc+3N//v5yZlXhNj61EbFIHcqjjdeaO3FSoi7Uht6bwXueV0M2ZSAccCuPUjJk3gbj1W8kA jIshjCIgasuwZPDB20J9yAPG6bFJE8IBr0FxbLbl6nltfXlJTLKbHen+qA8L7qD49WTowTiUI 1GhNLs6/PBDFQFoTYBIQX25Fmt2/RJ0E8BI30l9Qn9hzl1BXGQDCGaQAkE1N9wgb+ZkYCbwqn hebcrU3TqiQ0Ia++9diagNGfZZlAiNEFdgyy3+AVP652Nx5Zk2E4Kvx9ElcEulK2bQNlZPOEO lh+qxmRuAYM0M73hW/VZ669EjCd/uzlncXbnKVvSlzMabSLsv8mgmx6yEVDemiE8aJ4Hyi/wq EhSIZhP4npKxtR1o67dqrsi/QoL6JyyjU2JS5Paezvg3oXROHXePxyEj+LmdmGODGex4RKY/E 0n8YWnZt59u3tnybe7xcxCS59+o1VhQt76zF5SHgybct+DM1/bwzrPTMcYykyYIzMmFalmtDN wOHjhhdEX4zD70eokTtyy2O2etphmjAhXlAWnjjOi4iCTgeUM0R+wC51p+ZGFgk+79eve/Qq9 Jk9YScWZ7Sj1CoCm/dzP8obLILmRgl7+8G1dYgVBmyWRwkOjtCjD+TbfcEsMmfqFe0muwKvgd Ez8sRA1dlgA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, > Very well; here is an incremental patch (to make the differences > clear). It's a compromise: the derived state is gone, but there are > two functions: one for the list of buffers that need to be polled, and > one for whether that list would be non-empty. Thanks, this goes to the right direction. > By the way, the patch now uses functions from cl-lib, not just > macros. Is there any reason not to? No problem. >From my POV you could push it (with the final decision for the name from Eli). If there are problems, people will react soon - that's my experience with autorevert changes. But we have autorevert-tests.el, so at least the important cases are covered. I'm wondering if there are some tests which need to be added. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification References: In-Reply-To: Resent-From: Zhang Haijun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 01:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "35418@debbugs.gnu.org" <35418@debbugs.gnu.org> Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155658621729272 (code B ref 35418); Tue, 30 Apr 2019 01:04:01 +0000 Received: (at 35418) by debbugs.gnu.org; 30 Apr 2019 01:03:37 +0000 Received: from localhost ([127.0.0.1]:40217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLHBJ-0007c4-4Y for submit@debbugs.gnu.org; Mon, 29 Apr 2019 21:03:37 -0400 Received: from mail-oln040092254108.outbound.protection.outlook.com ([40.92.254.108]:51671 helo=APC01-PU1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLHBG-0007bk-1t for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 21:03:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=edskVXVrl5HCOb5W39xhzaBy84qFKXnoVNPzPT5/rLo=; b=HNHHjsUt6YHIQdTfgL+fSUlWq0v0X2ENOxPmkg/SkPuzWlFh5lP5jSsomajy3BRLH+yu3+jaK3a1ec5/9SR1LlYDWeZtrY0UUVArBMy7mZ9ojlXSR8ss4oi9jD7FZzVOGV+qjXNRLvgARGUSnxGwsAAhrjrPsyQ/qZCGV0Y/xqZ2ibf47Fh4R22dA2SlydKJtNgA6edcs74JKaxGS4uAg0+MtvHbsjsJKcYTIjYXdL3S+e74VCjCLo5dR1OzJfvnJKUmTwbvd6prfi5rL5f2wZR3d5nXFWS9fQR1HiP8Z1tVz3QmyZp1FrWIAd4jwtzSQOLdh9T8nvUeX/7q7WsWUQ== Received: from HK2APC01FT020.eop-APC01.prod.protection.outlook.com (10.152.248.60) by HK2APC01HT048.eop-APC01.prod.protection.outlook.com (10.152.249.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.13; Tue, 30 Apr 2019 01:03:22 +0000 Received: from PS1PR06MB2759.apcprd06.prod.outlook.com (10.152.248.54) by HK2APC01FT020.mail.protection.outlook.com (10.152.248.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.13 via Frontend Transport; Tue, 30 Apr 2019 01:03:21 +0000 Received: from PS1PR06MB2759.apcprd06.prod.outlook.com ([fe80::3c3b:be45:a6af:3d86]) by PS1PR06MB2759.apcprd06.prod.outlook.com ([fe80::3c3b:be45:a6af:3d86%4]) with mapi id 15.20.1835.018; Tue, 30 Apr 2019 01:03:21 +0000 From: Zhang Haijun Thread-Topic: bug#35418: [PATCH] Don't poll auto-revert files that use notification Thread-Index: AQHU/vCBHkd3xAerUE++lxqH2WqSdA== Date: Tue, 30 Apr 2019 01:03:21 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0PR01CA0016.apcprd01.prod.exchangelabs.com (2603:1096:203:92::28) To PS1PR06MB2759.apcprd06.prod.outlook.com (2603:1096:803:46::13) x-incomingtopheadermarker: OriginalChecksum:AFDF3091916E99F9308DD0B5BA755075F74212D3D04F1190C28C52BDC1646695; UpperCasedChecksum:8590F6BF8AC2E69F0C175A976E3C6530031902E99C1CD717F00CD2D64ACEB1B4; SizeAsReceived:7311; Count:47 x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: Apple Mail (2.3445.9.1) x-tmn: [pKat1mtuTURVUH7OM6Suq6q+/XdLqcxf] x-microsoft-original-message-id: x-ms-publictraffictype: Email x-incomingheadercount: 47 x-eopattributedmessage: 0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(5050001)(7020095)(20181119110)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045); SRVR:HK2APC01HT048; x-ms-traffictypediagnostic: HK2APC01HT048: x-microsoft-antispam-message-info: cwfAef2/EzAdWuDDugGFPtiUTfT4SfLCyOEF3FO97DP+raqz56XLjugdGLMTxifXDC/JlgQjhbxhm3zkhS5liGjNYD6LU9w3LCUA7LitSwBRwoTjeSzprCXeBfk7LPFR2E5wKrRDqdCPzNwXCtLZzmsROILhWUfX7bbSk9adWnxuqZqol3vPxJ9Vpt1h8tx7 Content-Type: text/plain; charset="gb2312" Content-ID: <81EF05EDD889C44F89FDDD48EBA8F7C4@apcprd06.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 4ff44755-eaa8-4406-0003-08d6cd07a3ab X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2019 01:03:21.5923 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT048 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) PiBJdCB3YXMgYSBkZXNpZ24gZGVjaXNpb24sIHRoYXQgZmlsZW5vdGlmeS5lbCBpbXBsZW1lbnRz IGRpcmVjdG9yeSB3YXRjaGluZy4gU2luY2Uga3F1ZXVlIGRvZXMgbm90IHN1cHBvcnQgdGhpcywg aXQgbXVzdCBiZSBlbXVsYXRlZCwgc29tZWhvdy4gDQo+IA0KDQpJdCBzZWVtcyB0aGF0IGl0IGlz IG5vdCB0cnVlIGZvciBrcXVldWUgb24gbWFjT1MgMTAuMTMuNi4NCg0KU2V2ZXJhbCB3ZWVrcyBh Z28sIEkgbWV0IGEgcHJvYmxlbSB3aXRoIGVtYWNzIGF1dG8tcmV2ZXJ0LiBTb21lIGZpbGVzIGlu IGEgZGlyZWN0b3J5IGNhbqGvdCBiZSBhdXRvIHJldmVydGVkLiAgVGhpcyBkaXJlY3Rvcnkgd2Fz IGEgc29mdCBsaW5rIHRvIGFub3RoZXIgZGlyZWN0b3J5LiBJIGRpZCBzb21lIGRlYnVnIGFuZCAg Zm91bmQgdGhhdCBubyBldmVudCB3b3VsZCBiZSByZWNlaXZlZCBpZiB5b3UgdXNlIGZpbGUgd2F0 Y2hpbmcgZm9yIHRoZSBmaWxlcyBpbiBhIHNvZnQgbGluayBkaXJlY3RvcnkuIEFuZCB1c2UgZGly ZWN0b3J5IHdhdGNoaW5nIGZvciB0aGVzZSBmaWxlcyB3b3JrZWQgd2VsbC4gU28gSSBtb2RpZmll ZCBmaWxlbm90aWZ5LmVsIGxpa2UgdGhpczoNCg0KZGlmZiAtLWdpdCBhL2xpc3AvZmlsZW5vdGlm eS5lbCBiL2xpc3AvZmlsZW5vdGlmeS5lbA0KaW5kZXggMTAxZGRiNmJlMC4uYTRhMDM1OTMyOCAx MDA2NDQNCi0tLSBhL2xpc3AvZmlsZW5vdGlmeS5lbA0KKysrIGIvbGlzcC9maWxlbm90aWZ5LmVs DQpAQCAtMzYzLDcgKzM2Myw3IEBAIGZpbGUtbm90aWZ5LWFkZC13YXRjaA0KICAgICAgIChzZXRx IGRlc2MgKGZ1bmNhbGwNCiAgICAgICAgICAgICAgICAgICA7OyBrcXVldWUgZG9lcyBub3QgcmVw b3J0IGZpbGUgY2hhbmdlcyBpbiBkaXJlY3RvcnkNCiAgICAgICAgICAgICAgICAgICA7OyBtb25p dG9yLiAgU28gd2UgbXVzdCB3YXRjaCB0aGUgZmlsZSBpdHNlbGYuDQotICAgICAgICAgICAgICAg ICAgZnVuYyAoaWYgKGVxIGZpbGUtbm90aWZ5LS1saWJyYXJ5ICdrcXVldWUpIGZpbGUgZGlyKQ0K KyAgICAgICAgICAgICAgICAgIGZ1bmMgKGlmIChlcSBmaWxlLW5vdGlmeS0tbGlicmFyeSAna3F1 ZXVlMTEpIGZpbGUgZGlyKQ0KICAgICAgICAgICAgICAgICAgIGwtZmxhZ3MgJ2ZpbGUtbm90aWZ5 LWNhbGxiYWNrKSkpDQoNCiAgICAgOzsgTW9kaWZ5IGBmaWxlLW5vdGlmeS1kZXNjcmlwdG9yc6Gv Lg0KDQpJdCB3b3JrcyB3ZWxsIHNpbmNlIHRoZW4uDQoNCkkgZG9uoa90IGtub3duIGZyb20gd2hl biB0aGUgYmVoYXZpb3Igb2Yga3F1ZXVlIGNoYW5nZWQuIFRoZXJlIG1heWJlIG5lZWQgYSB1c2Vy IG9wdGlvbiB0byBjb250cm9sIHdoZXRoZXIgdG8gdXNlIGZpbGUgd2F0Y2hpbmcgb3IgZGlyZWN0 b3J5IHdhdGNoaW5nIGZvciBrcXVldWUuDQoNCg== From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 03:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: mattiase@acm.org, 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155659667421598 (code B ref 35418); Tue, 30 Apr 2019 03:58:01 +0000 Received: (at 35418) by debbugs.gnu.org; 30 Apr 2019 03:57:54 +0000 Received: from localhost ([127.0.0.1]:40389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLJty-0005cI-Ar for submit@debbugs.gnu.org; Mon, 29 Apr 2019 23:57:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLJtw-0005c5-Iq for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 23:57:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLJtr-0008SE-7G; Mon, 29 Apr 2019 23:57:47 -0400 Received: from [176.228.60.248] (port=1141 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hLJtp-0000Gy-J7; Mon, 29 Apr 2019 23:57:46 -0400 Date: Tue, 30 Apr 2019 06:57:38 +0300 Message-Id: <83v9ywrvpp.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87a7g8zhv0.fsf@gmx.de> (message from Michael Albinus on Mon, 29 Apr 2019 22:17:23 +0200) References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <87imuxxawj.fsf@gmx.de> <87a7g8zhv0.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: Eli Zaretskii , 35418@debbugs.gnu.org > Date: Mon, 29 Apr 2019 22:17:23 +0200 > > >From my POV you could push it (with the final decision for the name from > Eli). I'm okay with the name. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 07:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Zhang Haijun Cc: "35418@debbugs.gnu.org" <35418@debbugs.gnu.org> Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155660802610112 (code B ref 35418); Tue, 30 Apr 2019 07:08:01 +0000 Received: (at 35418) by debbugs.gnu.org; 30 Apr 2019 07:07:06 +0000 Received: from localhost ([127.0.0.1]:40536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLMr4-0002d1-1r for submit@debbugs.gnu.org; Tue, 30 Apr 2019 03:07:06 -0400 Received: from mout.gmx.net ([212.227.15.15]:58501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLMr2-0002cU-EW for 35418@debbugs.gnu.org; Tue, 30 Apr 2019 03:07:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556608015; bh=waQjiLQGNYVPVmQZnyLPcv6s+9TQ8eW92PzNrI//XkE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=LAaKYF36QUe0plSLMWmL7zXlmCVU23P333LFVSDFXUo2vabWzyJumZEARY6Po4zGF 7ky2fKePLLdCK0EKEXPY2GG8oT24AWwKMA4ohhx0DSXA+amCbisT7XjC6mpJnrRz+3 Fj+v8YnEeGWRPvAo4hSBKRkZg7Ukc4zI/u9Elo7w= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.52.91]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MSv6D-1hB5TO2Wvd-00RoYt; Tue, 30 Apr 2019 09:06:55 +0200 From: Michael Albinus References: Date: Tue, 30 Apr 2019 09:06:54 +0200 In-Reply-To: (Zhang Haijun's message of "Tue, 30 Apr 2019 01:03:21 +0000") Message-ID: <87tvegt1ip.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:UsRyBVVd5BNzhVrISKSUPkRq8obTPd1BNpQStVDi4RXXPktp03M PESH7r9pc0ZmiWqKjdoJx1xxoSdNcJKMovigifxm+LxD278GqUvqRSmtwNL50rXRqVc6q7y etbL4F/JPYt0ZpbbkHy74nr5OKe3zXR4IQg1l4zHdgn0l/Tv9+Blpiy7VOG1JumEYdAvUNA +MRTAnNgrg9wWYAaqCwuw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Gv5s6bMDu+8=:WHOo98mpZaRyERFJ/SrkJy Tr24Kqq1fpFNVc2xy13fDL8Q1+TV4Ob1nQaJ88+tBlPTM5gM30+jeEX42uOjDB1wa8xFsRb2p zrwZ9QtZ0zN5JxA84+K6960YN8A8qXmlQzNg/qGXC0Ms50pZN7f8qJguWBygpdSCEMyt3XY/Y T3P7p0BaiGA9rFaUyhH1dWEba/RQGfJCrc2uaQKkDZuxteaQlvHG81IBP5YsWOKIUueooCyae 5XmDaz+oEr8FQDn28o4eioE9ZVsH6Ig/oJJeEXm+m+yOc9KvGI5VTxFDX9ws3gsKQ+bPwYcfr nhDuks3tfq9OraAmN68nC2MYiH2LPq8IdMMKdmRiCBNV3j928bGe8No7vPiEttL8OA7XH8IWE RBRa8bRitVGQb2J7pkNFn+JRS+w8LZc+fFYtD21uUyzYPU+ECB+CsYHReNvEKb12mzvo8h7oU c4wYpUobd+ixeZkd7ldQMKrX+Qwzmik2LEJvy72VL/jGiz592q59uOMb8dJqYr1fx9twlA0TQ Z5fJJPtvtZZDWDIny8qvMxu3WyS/HsTqpZcVMvxyzPP6g9LtHLMzWpE+wbomrA1xxn6hK77TW H8o16gwkY+bhuunHOim04PTTSbLPEJhFp30q5sGegN9NbFQumicDwFs20dJJgFv5BMOIr34fD 5ZtIjTb5N9rlr9rEosBjWWNg9cjZYnOgY3KcnOXZLLVadWRtgc0h5fPPIsQluT32R/v8fi7ae ZHLZgVsP3kgxIe/lkgPpHf2OOHoGgnAK4YdOs4ocz5RwqwRV/bHEKjb+QAzIBpvXW27VNvOe5 lQPC3dbgOVgTpn2wy2I0OBmr421/dkjrz4veVuin9rEg/SbHmQvAsxdZW6schyWr9+OLjUqrR XBE5f5czfVaw0bOLEpJE/06afpzIss5+HQea25LN3YqHPU79w+rfhS1FFg2wXKyViZrKmCHRk JxMvpelTXqw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Zhang Haijun writes: Hi, > diff --git a/lisp/filenotify.el b/lisp/filenotify.el > index 101ddb6be0..a4a0359328 100644 > --- a/lisp/filenotify.el > +++ b/lisp/filenotify.el > @@ -363,7 +363,7 @@ file-notify-add-watch > (setq desc (funcall > ;; kqueue does not report file changes in directory > ;; monitor. So we must watch the file itself. > - func (if (eq file-notify--library 'kqueue) file dir) > + func (if (eq file-notify--library 'kqueue11) file dir) > l-flags 'file-notify-callback))) > > ;; Modify `file-notify-descriptors=E2=80=99. I don't understand the patch. Symbol kqueue11 does not exist, so do you mean + func dir And have you applied the tests in filenotify-tests.el? Do all of them pass? Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 11:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 35418@debbugs.gnu.org, Michael Albinus Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155662452413565 (code B ref 35418); Tue, 30 Apr 2019 11:43:01 +0000 Received: (at 35418) by debbugs.gnu.org; 30 Apr 2019 11:42:04 +0000 Received: from localhost ([127.0.0.1]:40740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLR9A-0003Wj-8J for submit@debbugs.gnu.org; Tue, 30 Apr 2019 07:42:04 -0400 Received: from mail172c50.megamailservers.eu ([91.136.10.182]:39818 helo=mail33c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLR97-0003WG-3m for 35418@debbugs.gnu.org; Tue, 30 Apr 2019 07:42:02 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556624518; bh=xXr+lrKc9reNgw9MrOLyMrbAFDac6rVIUVqHYEHr6vA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=mn8eAxIGjSfdSPfAhX1p1Oktxx8DHOceIiOVnaQ1VotRIuerKjqzC9rNb7Y+T+xn8 yw8LdTHp6ff3NHxXKRFz74+UIIpjZVBcCBd4D5xakWhzOzNGfnHEUBUCrVrKdrLkEk SsYFee6t6eioZN80cauCrrdwEan+l4taQw7H0koo= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3UBft7S001734; Tue, 30 Apr 2019 11:41:57 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <83v9ywrvpp.fsf@gnu.org> Date: Tue, 30 Apr 2019 13:41:55 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <87imuxxawj.fsf@gmx.de> <87a7g8zhv0.fsf@gmx.de> <83v9ywrvpp.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0201.5CC83486.0097, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=PtG9kTE3 c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=yqmMMDXTV7ZdbuIZzWsA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 30 apr. 2019 kl. 05.57 skrev Eli Zaretskii : > >> From: Michael Albinus >> Cc: Eli Zaretskii , 35418@debbugs.gnu.org >> Date: Mon, 29 Apr 2019 22:17:23 +0200 >> >>> From my POV you could push it (with the final decision for the name from >> Eli). > > I'm okay with the name. Thank you, pushed (c61bbb4c8e). What remains to be done: - reorganise the manual as discussed before - see what it would take to make the change work in global-auto-revert-mode and of course fix any lingering concerns that may turn up. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 13:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155662918324458 (code B ref 35418); Tue, 30 Apr 2019 13:00:02 +0000 Received: (at 35418) by debbugs.gnu.org; 30 Apr 2019 12:59:43 +0000 Received: from localhost ([127.0.0.1]:40831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLSMJ-0006MQ-1p for submit@debbugs.gnu.org; Tue, 30 Apr 2019 08:59:43 -0400 Received: from mout.gmx.net ([212.227.17.21]:53391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLSMH-0006MB-8s for 35418@debbugs.gnu.org; Tue, 30 Apr 2019 08:59:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556629171; bh=mtl1WuajEs7RK7qy7bliT8xfdKkTrRT/pGN0QlHG3NQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=NeNY2u/JcvF1OnxOeLpD8qLHc2DnNp7h8vA2EUVQnnh7b/uBtLP+fLmbS38aTiFOf m2Hq9rkv2KNel3A9ACaRYC6E2z3I4CKxcnhSAoQ4ewrM494CpXc1tTlWI0p3cLOQBy 1+Bij3Sy2AiowzQCr92kKzKC+wUxpRbtOUY5Blvw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.52.91]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MeCpb-1goJb347hX-00bKOp; Tue, 30 Apr 2019 14:59:31 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <87imuxxawj.fsf@gmx.de> <87a7g8zhv0.fsf@gmx.de> <83v9ywrvpp.fsf@gnu.org> Date: Tue, 30 Apr 2019 14:59:29 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Tue, 30 Apr 2019 13:41:55 +0200") Message-ID: <87k1fbtzri.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:V88nM2aknz1YTudX8i0ryaeB4q8WBB7ymeq0vOD7Nw1vZddrm+5 +ck3NxgUHhFbxnjOL2PKxVNr5Tdsvh76MFQF6rkYO6/bguBK96mXVIKM65ESRYChKox2PMD bXkPZYfsfGqM3uKcREFhCBi1Rt37JdmGOSMym2ISpm9IsOa2YmxSCDOZV1gg3QNu4QnMBJ3 khnj0GnuOrmEK4H2BOwYQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:NY/5QIsqBwI=:90zbw1QiRcAY0YmDz69ua5 u/GcgRUpNIkNgK3mAKq+9JKor9arNEyFGlW2a/18N07aiRbyjNlEPvy71hED5nKbAJ6fexjya H97vZKiq9/EXnnUm+ELMQ42toKWfaYSuN2NBwK2kMQ4Jq15RfI6McyGE+5hJj9TYeQl+cek8I SiJrjgIpoq/5imBvjXKyqBo6seub2nkFzubZ53CEcZiIrVOhmBX4ZHQMnIJUbxYu4cEUtvaot woos5lhvhyNVX7mtYfwUhgEr1ESqHk/e+ruZuXX4+5M/O62CWQk9oV7JRgzy5xPEiNpsrHMjK i0giXTEtphbqy/KYycg8vX1ErhAfijPXPrRXmWVU3SYZnD78iQK4tLPnRlSVVG+fcQX6NusVD d/jL8i7E/kWDJccR1Q2YUCGo4vSWjgjUsAe3k8NCABSCUQJLsJXatMQzNlcRI7A6mmn4BXcGa tOrRIUmtBN4dgFZilML8S1T9o3n5aIa3PvT0BnncV+lxIlLiTYua8ieIDLQVZX3TjKialqTQw b/53B4jAgklMBDCPYVKaZwyZB6UnWR9qcw5G+EmZwbqxKd7MSjhKDlTSy3YlgENxDTaYRboQy s8lCHbSqGaPrd4CA5h+RUEehbhbfOWkK9v4KMWmUz3ErA38H6TmvSXW6jPWhEbNmakc9fmkIi yGSr5ZeUsne/pw81UuAOF9SerpLG8HznJWv9cBgpHW39noHqZnaoYZxAwe2zsglDm9JaEzb4R wjx4bMPqgdaeE2Tl5FBW3jXT7ASwHhiqkjzjh81/fZibktE/xwg4XHszdU555tXc5VTgVcaRh f6iYjN+o3vUOD24oTSuxHn72HoRKvmYSbHnco/iKOs7ALENMsBNL2xylMDJgTdor9IuZuOOgW 5Y22UYF6aC29fbf4QWCOl8sdmrPQbeNjJivA+hEpWNjrzK+Buu0pimOKNcF1Uq2X51CSIvaPS b9JpqFOManA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, > Thank you, pushed (c61bbb4c8e). What remains to be done: Thanks! > and of course fix any lingering concerns that may turn up. Let's start with this one: Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 13:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155663259931147 (code B ref 35418); Tue, 30 Apr 2019 13:57:01 +0000 Received: (at 35418) by debbugs.gnu.org; 30 Apr 2019 13:56:39 +0000 Received: from localhost ([127.0.0.1]:42036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLTFP-00086I-G9 for submit@debbugs.gnu.org; Tue, 30 Apr 2019 09:56:39 -0400 Received: from mail174c50.megamailservers.eu ([91.136.10.184]:39640 helo=mail36c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLTFN-00086B-Fe for 35418@debbugs.gnu.org; Tue, 30 Apr 2019 09:56:38 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556632595; bh=ctIzaScuOeXS/bg4fMK/SvyOdAqrZ3WiD5yCiD7c3UI=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=N60lGvZfEHoy2qljHQq07f/7OHd6vf7rqcLEbnmfzulUkOqyfDRMj3gjql8lqjXUl lef5rUFS6aHlJwJ3u44aIH7g4zxwQoZmIEfmF5InWdatBizq/WKOj4MtrWMVtA0wWY czS754ER0OSFGpB6twb9vsI2nIjpnRqvvhSL4Xq0= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail36c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3UDuXbq002622; Tue, 30 Apr 2019 13:56:35 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <87k1fbtzri.fsf@gmx.de> Date: Tue, 30 Apr 2019 15:56:33 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <8FE65D7E-0080-4B12-9261-BC4426D5CC33@acm.org> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <87imuxxawj.fsf@gmx.de> <87a7g8zhv0.fsf@gmx.de> <83v9ywrvpp.fsf@gnu.org> <87k1fbtzri.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0210.5CC85413.003B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=XqTUx2N9 c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=Aoz2q4TMCEyGCAAGWFsA:9 a=CjuIK1q_8ugA:10 a=QqFNrm0a_HcA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 30 apr. 2019 kl. 14.59 skrev Michael Albinus : >=20 > Let's start with this one: = Oh dear. Now fixed in the correct way, I hope. Thank you! From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 14:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.1556633982742 (code B ref 35418); Tue, 30 Apr 2019 14:20:02 +0000 Received: (at 35418) by debbugs.gnu.org; 30 Apr 2019 14:19:42 +0000 Received: from localhost ([127.0.0.1]:42050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLTbi-0000Bu-GT for submit@debbugs.gnu.org; Tue, 30 Apr 2019 10:19:42 -0400 Received: from mout.gmx.net ([212.227.17.22]:37197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLTbg-0000Bg-8o for 35418@debbugs.gnu.org; Tue, 30 Apr 2019 10:19:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556633970; bh=2RHNtQinjBFiX2BRzf5X9ogS2+JmLBd3zcNlcw/D7F8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=CSKMkjLs92GqDTNnAa2sNPm90D6i6QyMqSvpNGETTM8WYqZZhDALEh0io9AjfL7Ar MgbEVJDSCujqDoMSWTx6xrFE8qeivrxuE6etiSL8S1+yRxm0chGrxCyxvy/41RFmC2 uljJCGsrKeleHIJt2T+hcom1WlPmTa0QlhPjT6e4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.52.91]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mr9Bu-1h1Hzo2Tkk-00oJO0; Tue, 30 Apr 2019 16:19:30 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <87imuxxawj.fsf@gmx.de> <87a7g8zhv0.fsf@gmx.de> <83v9ywrvpp.fsf@gnu.org> <87k1fbtzri.fsf@gmx.de> <8FE65D7E-0080-4B12-9261-BC4426D5CC33@acm.org> Date: Tue, 30 Apr 2019 16:19:28 +0200 In-Reply-To: <8FE65D7E-0080-4B12-9261-BC4426D5CC33@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Tue, 30 Apr 2019 15:56:33 +0200") Message-ID: <87ftpztw27.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:W/vJ9VaW7UBh9l9fhrO3Lkhgdg92jxOHfWL/I0ZqJYjp67blqoK wDd19p5YKAnqMTezI529lPeD6gGSQTHhXX2CX8C4Bm1ggGi/NVkovkHoeiwm67gu6TKjjjK VniuKskzJ9sICsz8VW83woy1zSmvCWbeCNJ/2ozQhXTpRClbRjUI9m5Bu2BrqMDyFQAXvvi LDY9G5ttbSlkew9WJMFHg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:JF72AdAo/wk=:vePRvQegyAd5kwkh5Vh2H4 AimRMumhUSCUxQe6x1U4hV7EYuftE9Zg/m/72DH4jZKf/n8P3f2kgaUnlo50V5deO6EkQpNU9 dui4CqJj7WRMJ1Qqyk6ML/xkkc48mIbmOJ6iG/vF0veNiuLbPiF6aR6Lbiv0x1MlmJr3BZrwf 76eAgDHt3oBVH1PKu1pAskhVU26gdYvqff+17l0TELr4zEnMXRLeKXB+ZYmkXgSsq/TPONQCe 4LwP86YL4qKc2JOJkGAxiMVhKmrS+8Bszpdr9XYzzb5SgVjJYz36lDMRs7moVxthqZRYSfpdD bpTiKFzjRDkKrQZAJLrNWxZ+Qt2UvUaecfRsg7h+MOt8y/bd7fVhv/UIsxwFTDEcIrugHlfON WjExUzAzJ8KKvha3Gvp9wFAtUM4c8DQorWMIm+ryI+ECzI2F65FVCMd3SABbc99tKt+U6xVIK j6CL9sd5Rsksifv6Lu0bzsZ3y4FqoV7lWFx2cu56+uGB9A138vHNfFoNqcxqOFgFkIx9kqjwc VUMRFep+cFxLeRt/pv40mZbBKGgn0zceZwfDxt1UdbeMiVUTboCH6f0tIe1jtUKPKAlRoXKqA MKyDc7e1MLbGiKrcwEyUzn3ArYutWeGbzRuIbKxL8v/BKE+NokjilW2Dy+VqpoPvVggbvf0UC c0I6WJadEUghAWgoEYaQRTV9LgVRQ9Hi+5YU0dlZ0pwNL8UgmgVMA/YsPWK25v2mA/wZyV9ya zLhYHcV8usAkWZTOwnKi0wSlXPkQljKMRXX+pwoPoqgnq/JXBGLKRiVnrjcegEBaxxOFtJqtY ls957L6JVaMv2d0oD3PVEm72rZaSy9SzKppSmCK4AJH6kfBbP2CW5oItdkXl5VAlqvKgUPJe4 PycnGsBSMFMgCIA7x6wouL0u7AKrd0Af+P9Ag7sHjJHSR8KgNAE13pLrKddvG9d2RYPkllDYB ldxUg0KBIRg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: > 30 apr. 2019 kl. 14.59 skrev Michael Albinus : >>=20 >> Let's start with this one: > > Oh dear. Now fixed in the correct way, I hope. Thank you! Yes, looks better. You can always run a dedicated test like this: --8<---------------cut here---------------start------------->8--- $ make -C test autorevert-tests --8<---------------cut here---------------end--------------->8--- See also test/README. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 15:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15566372855905 (code B ref 35418); Tue, 30 Apr 2019 15:15:02 +0000 Received: (at 35418) by debbugs.gnu.org; 30 Apr 2019 15:14:45 +0000 Received: from localhost ([127.0.0.1]:42109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLUSz-0001XB-HU for submit@debbugs.gnu.org; Tue, 30 Apr 2019 11:14:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLUSw-0001Ww-Bl for 35418@debbugs.gnu.org; Tue, 30 Apr 2019 11:14:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLUSr-00026e-35; Tue, 30 Apr 2019 11:14:37 -0400 Received: from [176.228.60.248] (port=3531 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hLUSq-0005ZH-En; Tue, 30 Apr 2019 11:14:36 -0400 Date: Tue, 30 Apr 2019 18:14:29 +0300 Message-Id: <83o94nsey2.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Mon, 29 Apr 2019 20:58:15 +0200) References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <87bm0pqnvl.fsf@gmx.de> <093C7A57-E3EA-446D-B283-07328850094A@acm.org> <87ef5lxaji.fsf@gmx.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Mon, 29 Apr 2019 20:58:15 +0200 > Cc: Eli Zaretskii , 35418@debbugs.gnu.org > > A file has three hard links, /dir1/a, /dir1/b and /dir2/c. Then: > > - A watch set on /dir1/a will report changes made to the file via any of the three links (kqueue, inotify). > - A watch set on /dir1 will report changes made to the file via /dir1/a and /dir1/b, but not /dir2/c (inotify). Just FTR, w32notify reports changes made through any of the 3 links when it watches dir1. This is consistent with MS documentation, which says that changing the file's data are reflected to all the hard links immediately. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 21:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155665855616781 (code B ref 35418); Tue, 30 Apr 2019 21:10:02 +0000 Received: (at 35418) by debbugs.gnu.org; 30 Apr 2019 21:09:16 +0000 Received: from localhost ([127.0.0.1]:42565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLa03-0004Ma-DO for submit@debbugs.gnu.org; Tue, 30 Apr 2019 17:09:15 -0400 Received: from mail221c50.megamailservers.eu ([91.136.10.231]:56448 helo=mail33c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLa00-0004MQ-MX for 35418@debbugs.gnu.org; Tue, 30 Apr 2019 17:09:14 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556658551; bh=yGYR3pxohDuvk8YC+lyXqYItErJC4b6VX2Eg4XJa6FQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Vn7yYJcKUjCbG5ZKMKxICU8MO1zjs1W0DqDpktkl5W9E6eGmkomjAkVnbljqUp019 rcNHUWYKw3ep3V4aGLn89L2Mxf1q+WE/NGOODpzwUwQScUGZZ9zZU9051NMcf5rcDa qSeeoyQhyRTnpwf4h1HhwlUcEgJQlbkVOv1LECk8= Feedback-ID: mattiase@acm.or Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3UL99wB008818; Tue, 30 Apr 2019 21:09:10 +0000 Message-ID: From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Date: Tue, 30 Apr 2019 23:09:08 +0200 In-Reply-To: <834l6gu6ee.fsf@gnu.org> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> Content-Type: multipart/mixed; boundary="=-chhUltRmZ1kEyS8PuRd6" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 X-CTCH-RefID: str=0001.0A0B0214.5CC8B976.004C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=PtG9kTE3 c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=O3sS7fXoHnWsh4GXVx8A:9 a=QEXdDO2ut3YA:10 a=N54-gffFAAAA:8 a=05VGI6y5R-z8mz6QroMA:9 a=XWl5Umid67ljq1f5:21 a=FR6tSgbnUPh3Qjsh:21 a=B2y7HmGcmWMA:10 a=6l0D2HzqY3Epnrm8mE3f:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-chhUltRmZ1kEyS8PuRd6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit mån 2019-04-29 klockan 19:23 +0300 skrev Eli Zaretskii: > > > I think we should have sibling sections "Reverting" and "Autorevert", > with the latter describing both types of auto-reverting. And > "Reverting" should have a cross-reference to "AutorevertAuto-" for > automatic reverting of file-visiting buffers. Here is a patch that does roughly that. I'm not entirely happy with the old 'Auto-reverting non-buffer files' section, whose node name was just 'Autorevert'. I would have preferred it as a subsection to the new auto-revert section, along with its existing two subsections, but since its place isn't the same in the on-line and printed manuals, that seemed technically tricky without duplicating a lot of text. --=-chhUltRmZ1kEyS8PuRd6 Content-Disposition: attachment; filename="0001-Reorganise-auto-revert-nodes-in-the-manual.patch" Content-Type: text/x-patch; name="0001-Reorganise-auto-revert-nodes-in-the-manual.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBkNmVkOGVkMzk2YThhNjk4YWQ2M2E4YTRmMzQ2MGVjZGY5ODJjNTA3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWF0dGlhcz0yMEVuZ2RlZz1DMz1BNXJkPz0g PG1hdHRpYXNlQGFjbS5vcmc+CkRhdGU6IFR1ZSwgMzAgQXByIDIwMTkgMjI6MzU6NTYgKzAyMDAK U3ViamVjdDogW1BBVENIXSBSZW9yZ2FuaXNlIChhdXRvLSlyZXZlcnQgbm9kZXMgaW4gdGhlIG1h bnVhbAoKVGhlIGFtb3VudCBvZiBpbmZvcm1hdGlvbiBvbiBhdXRvLXJldmVydCBoYXMgZ3Jvd24g dG8gZGVzZXJ2ZSBhCnNlY3Rpb24gb2YgaXRzIG93biAoYnVnIzM1NDE4KS4KCiogZG9jL2VtYWNz L2ZpbGVzLnRleGk6CiogZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50ZXhpOgoqIGRvYy9lbWFjcy9i dWZmZXJzLnRleGk6CiogZG9jL2VtYWNzL2VtYWNzLnRleGk6ClJlbmFtZSBub2RlICdBdXRvcmV2 ZXJ0JyB0byAnTm9uLWZpbGUgYnVmZmVycycuCkFkZCBub2RlICdBdXRvLXJldmVydCcgYW5kIG1v dmUgZ2VuZXJhbCBpbmZvcm1hdGlvbiBvbiB0aGF0IHRvcGljIHRoZXJlLgpTaHVmZmxlIHRleHQg aW4gdGhhdCBub2RlIGludG8gYSByb3VnaCBsZWFzdC10by1tb3N0IHNwZWNpZmljIG9yZGVyLgot LS0KIGRvYy9lbWFjcy9hcmV2ZXJ0LXh0cmEudGV4aSB8ICAyICstCiBkb2MvZW1hY3MvYnVmZmVy cy50ZXhpICAgICAgfCAgNCArLS0KIGRvYy9lbWFjcy9lbWFjcy50ZXhpICAgICAgICB8ICAzICst CiBkb2MvZW1hY3MvZmlsZXMudGV4aSAgICAgICAgfCA2MSArKysrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLS0tCiA0IGZpbGVzIGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKyksIDI4IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9lbWFjcy9hcmV2ZXJ0LXh0cmEudGV4aSBiL2Rv Yy9lbWFjcy9hcmV2ZXJ0LXh0cmEudGV4aQppbmRleCBjZDdjMWZmODk1Li44NTc1ZTFlZmRkIDEw MDY0NAotLS0gYS9kb2MvZW1hY3MvYXJldmVydC14dHJhLnRleGkKKysrIGIvZG9jL2VtYWNzL2Fy ZXZlcnQteHRyYS50ZXhpCkBAIC00LDcgKzQsNyBAQAogQGMKIEBjIFRoaXMgZmlsZSBpcyBpbmNs dWRlZCBlaXRoZXIgaW4gZW1hY3MteHRyYS50ZXhpICh3aGVuIHByb2R1Y2luZyB0aGUKIEBjIHBy aW50ZWQgdmVyc2lvbikgb3IgaW4gdGhlIG1haW4gRW1hY3MgbWFudWFsIChmb3IgdGhlIG9uLWxp bmUgdmVyc2lvbikuCi1Abm9kZSBBdXRvcmV2ZXJ0CitAbm9kZSBOb24tZmlsZSBidWZmZXJzCiBA c2VjdGlvbiBBdXRvIFJldmVydGluZyBOb24tRmlsZSBCdWZmZXJzCiAKIEdsb2JhbCBBdXRvIFJl dmVydCBNb2RlIG5vcm1hbGx5IG9ubHkgcmV2ZXJ0cyBmaWxlIGJ1ZmZlcnMuICBUaGVyZSBhcmUK ZGlmZiAtLWdpdCBhL2RvYy9lbWFjcy9idWZmZXJzLnRleGkgYi9kb2MvZW1hY3MvYnVmZmVycy50 ZXhpCmluZGV4IDI3ZmNiNzM2OWEuLjY2YjIxMzU0YzggMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9i dWZmZXJzLnRleGkKKysrIGIvZG9jL2VtYWNzL2J1ZmZlcnMudGV4aQpAQCAtNTY4LDEwICs1Njgs MTAgQEAgU2V2ZXJhbCBCdWZmZXJzCiBBdXRvIFJldmVydCBtb2RlIGFwcGxpZXMgdG8gdGhlIEBm aWxleypCdWZmZXIgTGlzdCp9IGJ1ZmZlciBvbmx5IGlmCiBAY29kZXtnbG9iYWwtYXV0by1yZXZl cnQtbm9uLWZpbGUtYnVmZmVyc30gaXMgbm9uLUBjb2Rle25pbH0uCiBAaWZ0ZXgKLUBpbmZvcmVm e0F1dG9yZXZlcnQsLCBlbWFjcy14dHJhfSwgZm9yIGRldGFpbHMuCitAaW5mb3JlZntOb24tZmls ZSBidWZmZXJzLCwgZW1hY3MteHRyYX0sIGZvciBkZXRhaWxzLgogQGVuZCBpZnRleAogQGlmbm90 dGV4Ci1AeHJlZntBdXRvcmV2ZXJ0LCBnbG9iYWwtYXV0by1yZXZlcnQtbm9uLWZpbGUtYnVmZmVy c30sIGZvciBkZXRhaWxzLgorQHhyZWZ7Tm9uLWZpbGUgYnVmZmVycywgZ2xvYmFsLWF1dG8tcmV2 ZXJ0LW5vbi1maWxlLWJ1ZmZlcnN9LCBmb3IgZGV0YWlscy4KIEBlbmQgaWZub3R0ZXgKIAogQG5v ZGUgSW5kaXJlY3QgQnVmZmVycwpkaWZmIC0tZ2l0IGEvZG9jL2VtYWNzL2VtYWNzLnRleGkgYi9k b2MvZW1hY3MvZW1hY3MudGV4aQppbmRleCA1OGVjMzczMDI5Li43NWIxMjk0MGVhIDEwMDY0NAot LS0gYS9kb2MvZW1hY3MvZW1hY3MudGV4aQorKysgYi9kb2MvZW1hY3MvZW1hY3MudGV4aQpAQCAt NDQzLDggKzQ0Myw5IEBAIFRvcAogKiBWaXNpdGluZzo6ICAgICAgICAgICAgVmlzaXRpbmcgYSBm aWxlIHByZXBhcmVzIEVtYWNzIHRvIGVkaXQgdGhlIGZpbGUuCiAqIFNhdmluZzo6ICAgICAgICAg ICAgICBTYXZpbmcgbWFrZXMgeW91ciBjaGFuZ2VzIHBlcm1hbmVudC4KICogUmV2ZXJ0aW5nOjog ICAgICAgICAgIFJldmVydGluZyBjYW5jZWxzIGFsbCB0aGUgY2hhbmdlcyBub3Qgc2F2ZWQuCisq IEF1dG8tcmV2ZXJ0OjogICAgICAgICBLZWVwaW5nIGJ1ZmZlcnMgYXV0b21hdGljYWxseSB1cC10 by1kYXRlLgogQGlmbm90dGV4Ci0qIEF1dG9yZXZlcnQ6OiAgICAgICAgICBBdXRvIFJldmVydGlu ZyBub24tZmlsZSBidWZmZXJzLgorKiBOb24tZmlsZSBidWZmZXJzOjogICAgQXV0byBSZXZlcnRp bmcgbm9uLWZpbGUgYnVmZmVycy4KIEBlbmQgaWZub3R0ZXgKICogQXV0byBTYXZlOjogICAgICAg ICAgIEF1dG8gU2F2ZSBwZXJpb2RpY2FsbHkgcHJvdGVjdHMgYWdhaW5zdCBsb3NzIG9mIGRhdGEu CiAqIEZpbGUgQWxpYXNlczo6ICAgICAgICBIYW5kbGluZyBtdWx0aXBsZSBuYW1lcyBmb3Igb25l IGZpbGUuCmRpZmYgLS1naXQgYS9kb2MvZW1hY3MvZmlsZXMudGV4aSBiL2RvYy9lbWFjcy9maWxl cy50ZXhpCmluZGV4IDk5MGI4ZjE2NzkuLjkzYjJlNzllNzAgMTAwNjQ0Ci0tLSBhL2RvYy9lbWFj cy9maWxlcy50ZXhpCisrKyBiL2RvYy9lbWFjcy9maWxlcy50ZXhpCkBAIC0yNSw4ICsyNSw5IEBA IEZpbGVzCiAqIFZpc2l0aW5nOjogICAgICAgICAgICBWaXNpdGluZyBhIGZpbGUgcHJlcGFyZXMg RW1hY3MgdG8gZWRpdCB0aGUgZmlsZS4KICogU2F2aW5nOjogICAgICAgICAgICAgIFNhdmluZyBt YWtlcyB5b3VyIGNoYW5nZXMgcGVybWFuZW50LgogKiBSZXZlcnRpbmc6OiAgICAgICAgICAgUmV2 ZXJ0aW5nIGNhbmNlbHMgYWxsIHRoZSBjaGFuZ2VzIG5vdCBzYXZlZC4KKyogQXV0by1yZXZlcnQ6 OiAgICAgICAgIEtlZXBpbmcgYnVmZmVycyBhdXRvbWF0aWNhbGx5IHVwLXRvLWRhdGUuCiBAaWZu b3R0ZXgKLSogQXV0b3JldmVydDo6ICAgICAgICAgIEF1dG8gUmV2ZXJ0aW5nIG5vbi1maWxlIGJ1 ZmZlcnMuCisqIE5vbi1maWxlIGJ1ZmZlcnM6OiAgICBBdXRvIFJldmVydGluZyBub24tZmlsZSBi dWZmZXJzLgogQGVuZCBpZm5vdHRleAogKiBBdXRvIFNhdmU6OiAgICAgICAgICAgQXV0byBTYXZl IHBlcmlvZGljYWxseSBwcm90ZWN0cyBhZ2FpbnN0IGxvc3Mgb2YgZGF0YS4KICogRmlsZSBBbGlh c2VzOjogICAgICAgIEhhbmRsaW5nIG11bHRpcGxlIG5hbWVzIGZvciBvbmUgZmlsZS4KQEAgLTk1 NSw2ICs5NTYsMTEgQEAgUmV2ZXJ0aW5nCiBpcyBub3QgbW9kaWZpZWQuICAoSWYgeW91IGhhdmUg ZWRpdGVkIHRoZSB0ZXh0LCBpdCB3b3VsZCBiZSB3cm9uZyB0bwogZGlzY2FyZCB5b3VyIGNoYW5n ZXMuKQogCisgIFlvdSBjYW4gYWxzbyB0ZWxsIEVtYWNzIHRvIHJldmVydCBidWZmZXJzIGF1dG9t YXRpY2FsbHkgd2hlbiB0aGVpcgordmlzaXRlZCBmaWxlcyBjaGFuZ2Ugb24gZGlzazsgQHB4cmVm e0F1dG8tcmV2ZXJ0fS4KKworQG5vZGUgQXV0by1yZXZlcnQKK0BzZWN0aW9uIEF1dG8tcmV2ZXJ0 OiBLZWVwaW5nIGJ1ZmZlcnMgYXV0b21hdGljYWxseSB1cC10by1kYXRlCiBAY2luZGV4IEdsb2Jh bCBBdXRvIFJldmVydCBtb2RlCiBAY2luZGV4IG1vZGUsIEdsb2JhbCBBdXRvIFJldmVydAogQGNp bmRleCBBdXRvIFJldmVydCBtb2RlCkBAIC05NjIsMjEgKzk2OCwzOCBAQCBSZXZlcnRpbmcKIEBm aW5kZXggZ2xvYmFsLWF1dG8tcmV2ZXJ0LW1vZGUKIEBmaW5kZXggYXV0by1yZXZlcnQtbW9kZQog QGZpbmRleCBhdXRvLXJldmVydC10YWlsLW1vZGUKLUB2aW5kZXggYXV0by1yZXZlcnQtaW50ZXJ2 YWwKLUB2aW5kZXggYXV0by1yZXZlcnQtcmVtb3RlLWZpbGVzCisKKyAgQSBidWZmZXIgY2FuIGdl dCBvdXQgb2Ygc3luYyB3aXRoIHJlc3BlY3QgdG8gaXRzIHZpc2l0ZWQgZmlsZSBvbgorZGlzayBp ZiB0aGF0IGZpbGUgaXMgY2hhbmdlZCBieSBhbm90aGVyIHByb2dyYW0uICBUbyBrZWVwIGl0IHVw IHRvCitkYXRlLCB5b3UgY2FuIGVuYWJsZSBBdXRvLXJldmVydCBtb2RlIGJ5IHR5cGluZyBAa2Jk e00teCBhdXRvLXJldmVydC1tb2RlfS4KK1RoaXMgYXV0b21hdGljYWxseSByZXZlcnRzIHRoZSBi dWZmZXIgd2hlbiBpdHMgdmlzaXRlZCBmaWxlIGNoYW5nZXMgb24KK2Rpc2suICBUbyBkbyB0aGUg c2FtZSBmb3IgYWxsIGZpbGUgYnVmZmVycywgdHlwZQorQGtiZHtNLXggZ2xvYmFsLWF1dG8tcmV2 ZXJ0LW1vZGV9IHRvIGVuYWJsZSBHbG9iYWwgQXV0by1SZXZlcnQgbW9kZS4KKworICBBdXRvLXJl dmVydCB3aWxsIG5vdCByZXZlcnQgYSBidWZmZXIgaWYgaXQgaGFzIHVuc2F2ZWQgY2hhbmdlcywg b3IgaWYKK2l0cyBmaWxlIG9uIGRpc2sgaXMgZGVsZXRlZCBvciByZW5hbWVkLgorCisgIE9uZSB1 c2Ugb2YgQXV0by1SZXZlcnQgbW9kZSBpcyB0byBgYHRhaWwnJyBhIGZpbGUgc3VjaCBhcyBhIHN5 c3RlbQorbG9nLCBzbyB0aGF0IGNoYW5nZXMgbWFkZSB0byB0aGF0IGZpbGUgYnkgb3RoZXIgcHJv Z3JhbXMgYXJlCitjb250aW51b3VzbHkgZGlzcGxheWVkLiAgVG8gZG8gdGhpcywganVzdCBtb3Zl IHRoZSBwb2ludCB0byB0aGUgZW5kIG9mCit0aGUgYnVmZmVyLCBhbmQgaXQgd2lsbCBzdGF5IHRo ZXJlIGFzIHRoZSBmaWxlIGNvbnRlbnRzIGNoYW5nZS4KK0hvd2V2ZXIsIGlmIHlvdSBhcmUgc3Vy ZSB0aGF0IHRoZSBmaWxlIHdpbGwgb25seSBjaGFuZ2UgYnkgZ3Jvd2luZyBhdAordGhlIGVuZCwg dXNlIEF1dG8tUmV2ZXJ0IFRhaWwgbW9kZSBpbnN0ZWFkCisoQGNvZGV7YXV0by1yZXZlcnQtdGFp bC1tb2RlfSkuICBJdCBpcyBtb3JlIGVmZmljaWVudCBmb3IgdGhpcy4KK0F1dG8tUmV2ZXJ0IFRh aWwgbW9kZSBhbHNvIHdvcmtzIGZvciByZW1vdGUgZmlsZXMuCisKIEB2aW5kZXggYXV0by1yZXZl cnQtdmVyYm9zZQotICBZb3UgY2FuIGFsc28gdGVsbCBFbWFjcyB0byByZXZlcnQgYnVmZmVycyBw ZXJpb2RpY2FsbHkuICBUbyBkbyB0aGlzCi1mb3IgYSBzcGVjaWZpYyBidWZmZXIsIGVuYWJsZSB0 aGUgbWlub3IgbW9kZSBBdXRvLVJldmVydCBtb2RlIGJ5Ci10eXBpbmcgQGtiZHtNLXggYXV0by1y ZXZlcnQtbW9kZX0uICBUaGlzIGF1dG9tYXRpY2FsbHkgcmV2ZXJ0cyB0aGUKLWN1cnJlbnQgYnVm ZmVyIHdoZW4gaXRzIHZpc2l0ZWQgZmlsZSBjaGFuZ2VzIG9uIGRpc2suICBUbyBkbyB0aGUgc2Ft ZQotZm9yIGFsbCBmaWxlIGJ1ZmZlcnMsIHR5cGUgQGtiZHtNLXggZ2xvYmFsLWF1dG8tcmV2ZXJ0 LW1vZGV9IHRvIGVuYWJsZQotR2xvYmFsIEF1dG8tUmV2ZXJ0IG1vZGUuICBUaGVzZSBtaW5vciBt b2RlcyBkbyBub3QgY2hlY2sgb3IgcmV2ZXJ0Ci1yZW1vdGUgZmlsZXMsIGJlY2F1c2UgdGhhdCBp cyB1c3VhbGx5IHRvbyBzbG93LiAgVGhpcyBiZWhhdmlvciBjYW4gYmUKLWNoYW5nZWQgYnkgc2V0 dGluZyB0aGUgdmFyaWFibGUgQGNvZGV7YXV0by1yZXZlcnQtcmVtb3RlLWZpbGVzfSB0bwotbm9u LUBjb2Rle25pbH0uCisgIFdoZW4gYSBidWZmZXIgaXMgYXV0by1yZXZlcnRlZCwgYSBtZXNzYWdl IGlzIGdlbmVyYXRlZC4gIFRoaXMgY2FuIGJlCitzdXBwcmVzc2VkIGJ5IHNldHRpbmcgQGNvZGV7 YXV0by1yZXZlcnQtdmVyYm9zZX0gdG8gQGNvZGV7bmlsfS4KKworQHZpbmRleCBhdXRvLXJldmVy dC1yZW1vdGUtZmlsZXMKKyAgVGhlc2UgbWlub3IgbW9kZXMgZG8gbm90IGNoZWNrIG9yIHJldmVy dCByZW1vdGUgZmlsZXMsIGJlY2F1c2UgdGhhdCBpcwordXN1YWxseSB0b28gc2xvdy4gIFRoaXMg YmVoYXZpb3IgY2FuIGJlIGNoYW5nZWQgYnkgc2V0dGluZyB0aGUKK3ZhcmlhYmxlIEBjb2Rle2F1 dG8tcmV2ZXJ0LXJlbW90ZS1maWxlc30gdG8gbm9uLUBjb2Rle25pbH0uCiAKIEBjaW5kZXggZmls ZSBub3RpZmljYXRpb25zCiBAdmluZGV4IGF1dG8tcmV2ZXJ0LXVzZS1ub3RpZnkKK0B2aW5kZXgg YXV0by1yZXZlcnQtaW50ZXJ2YWwKICAgQnkgZGVmYXVsdCwgQXV0by1SZXZlcnQgbW9kZSB3b3Jr cyB1c2luZyBAZGZue2ZpbGUgbm90aWZpY2F0aW9uc30sCiB3aGVyZWJ5IGNoYW5nZXMgaW4gdGhl IGZpbGVzeXN0ZW0gYXJlIHJlcG9ydGVkIHRvIEVtYWNzIGJ5IHRoZSBPUy4KIFlvdSBjYW4gZGlz YWJsZSB1c2Ugb2YgZmlsZSBub3RpZmljYXRpb25zIGJ5IGN1c3RvbWl6aW5nIHRoZSB2YXJpYWJs ZQpAQCAtMTAwMiwyNCArMTAyNSwxNCBAQCBSZXZlcnRpbmcKIEBjb2Rle2F1dG8tcmV2ZXJ0LW5v dGlmeS1leGNsdWRlLWRpci1yZWdleHB9IHRvIG1hdGNoIGZpbGVzIHRoYXQKIHNob3VsZCBiZSBl eGNsdWRlZCBmcm9tIHVzaW5nIG5vdGlmaWNhdGlvbi4KIAotICBPbmUgdXNlIG9mIEF1dG8tUmV2 ZXJ0IG1vZGUgaXMgdG8gYGB0YWlsJycgYSBmaWxlIHN1Y2ggYXMgYSBzeXN0ZW0KLWxvZywgc28g dGhhdCBjaGFuZ2VzIG1hZGUgdG8gdGhhdCBmaWxlIGJ5IG90aGVyIHByb2dyYW1zIGFyZQotY29u dGludW91c2x5IGRpc3BsYXllZC4gIFRvIGRvIHRoaXMsIGp1c3QgbW92ZSB0aGUgcG9pbnQgdG8g dGhlIGVuZCBvZgotdGhlIGJ1ZmZlciwgYW5kIGl0IHdpbGwgc3RheSB0aGVyZSBhcyB0aGUgZmls ZSBjb250ZW50cyBjaGFuZ2UuCi1Ib3dldmVyLCBpZiB5b3UgYXJlIHN1cmUgdGhhdCB0aGUgZmls ZSB3aWxsIG9ubHkgY2hhbmdlIGJ5IGdyb3dpbmcgYXQKLXRoZSBlbmQsIHVzZSBBdXRvLVJldmVy dCBUYWlsIG1vZGUgaW5zdGVhZAotKEBjb2Rle2F1dG8tcmV2ZXJ0LXRhaWwtbW9kZX0pLiAgSXQg aXMgbW9yZSBlZmZpY2llbnQgZm9yIHRoaXMuCi1BdXRvLVJldmVydCBUYWlsIG1vZGUgd29ya3Mg YWxzbyBmb3IgcmVtb3RlIGZpbGVzLgotCi0gIFdoZW4gYSBidWZmZXIgaXMgYXV0by1yZXZlcnRl ZCwgYSBtZXNzYWdlIGlzIGdlbmVyYXRlZC4gIFRoaXMgY2FuIGJlCi1zdXBwcmVzc2VkIGJ5IHNl dHRpbmcgQGNvZGV7YXV0by1yZXZlcnQtdmVyYm9zZX0gdG8gQGNvZGV7bmlsfS4KLQogICBJbiBE aXJlZCBidWZmZXJzIChAcHhyZWZ7RGlyZWR9KSwgQXV0by1SZXZlcnQgbW9kZSByZWZyZXNoZXMg dGhlCiBidWZmZXIgd2hlbiBhIGZpbGUgaXMgY3JlYXRlZCBvciBkZWxldGVkIGluIHRoZSBidWZm ZXIncyBkaXJlY3RvcnkuCiAKICAgQHhyZWZ7VkMgVW5kb30sIGZvciBjb21tYW5kcyB0byByZXZl cnQgdG8gZWFybGllciB2ZXJzaW9ucyBvZiBmaWxlcwogdW5kZXIgdmVyc2lvbiBjb250cm9sLiAg QHhyZWZ7VkMgTW9kZSBMaW5lfSwgZm9yIEF1dG8gUmV2ZXJ0CiBwZWN1bGlhcml0aWVzIHdoZW4g dmlzaXRpbmcgZmlsZXMgdW5kZXIgdmVyc2lvbiBjb250cm9sLgorQHhyZWZ7Tm9uLWZpbGUgYnVm ZmVyc30gZm9yIGF1dG8tcmV2ZXJ0aW5nIGJ1ZmZlcnMgdGhhdCBkbyBub3QgdmlzaXQKK2ZpbGVz LgogCiBAaWZub3R0ZXgKIEBpbmNsdWRlIGFyZXZlcnQteHRyYS50ZXhpCi0tIAoyLjIwLjEKCg== --=-chhUltRmZ1kEyS8PuRd6-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Zhang Haijun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 May 2019 02:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: "35418@debbugs.gnu.org" <35418@debbugs.gnu.org> Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155667706320614 (code B ref 35418); Wed, 01 May 2019 02:18:02 +0000 Received: (at 35418) by debbugs.gnu.org; 1 May 2019 02:17:43 +0000 Received: from localhost ([127.0.0.1]:42962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLeoY-0005MQ-Jn for submit@debbugs.gnu.org; Tue, 30 Apr 2019 22:17:42 -0400 Received: from mail-oln040092255089.outbound.protection.outlook.com ([40.92.255.89]:22860 helo=APC01-HK2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLeoW-0005M9-9S for 35418@debbugs.gnu.org; Tue, 30 Apr 2019 22:17:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OZJSx24kR8rYs7E9OYGc+VrjxA+dr5aEXWcgeBhQu5E=; b=pyZWjKcaG9jtREJMhRq3HH6YsJbubtmoh4XvN8TOIT1DCZQViZqJsy1E04tn4YDQENCpzjsd9bTAPN0Ko2BA8/yeeJIm4WDSJRIDn5TPdlA+ZBDFz2zwe1BTCLyJJIuHH+9ggvFzhzgqMpTYIkhpXJe4ISBmYkyedS3ez3CRRS3k4BRJ8GEyE3RUmSGZKNqPBWmxcRlX+35UHr84SJsHUMoVatBnsesla3wG8VlCVltZGomOzxYDmjTQwL59erBMaC6GDDf//1EB4E+1VUG6p5GDlsut7DRKWlcnpd8VL3PXXU0qRrw77H1VlqFL4daqsjlt0k7PWSAwTHqh+7COpw== Received: from SG2APC01FT060.eop-APC01.prod.protection.outlook.com (10.152.250.60) by SG2APC01HT018.eop-APC01.prod.protection.outlook.com (10.152.250.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1835.13; Wed, 1 May 2019 02:17:32 +0000 Received: from PS1PR06MB2759.apcprd06.prod.outlook.com (10.152.250.55) by SG2APC01FT060.mail.protection.outlook.com (10.152.251.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1835.13 via Frontend Transport; Wed, 1 May 2019 02:17:32 +0000 Received: from PS1PR06MB2759.apcprd06.prod.outlook.com ([fe80::3c3b:be45:a6af:3d86]) by PS1PR06MB2759.apcprd06.prod.outlook.com ([fe80::3c3b:be45:a6af:3d86%4]) with mapi id 15.20.1835.018; Wed, 1 May 2019 02:17:32 +0000 From: Zhang Haijun Thread-Topic: bug#35418: [PATCH] Don't poll auto-revert files that use notification Thread-Index: AQHU/vCBHkd3xAerUE++lxqH2WqSdKZUSLp7gAFA1IA= Date: Wed, 1 May 2019 02:17:32 +0000 Message-ID: References: <87tvegt1ip.fsf@gmx.de> In-Reply-To: <87tvegt1ip.fsf@gmx.de> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR06CA0010.apcprd06.prod.outlook.com (2603:1096:202:2e::22) To PS1PR06MB2759.apcprd06.prod.outlook.com (2603:1096:803:46::13) x-incomingtopheadermarker: OriginalChecksum:DC9F72C2233DF3F7ECCEB47EB43FAA29981A8609CDAB8BD1F5C924B96BD04FED; UpperCasedChecksum:A673EAA6879DB6E518FA00E1FEDB9119C105EA215F53270D06B7BCBF29F63967; SizeAsReceived:7571; Count:50 x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: Apple Mail (2.3445.9.1) x-tmn: [CE38MrbZ1395pVSOxv/QwJ/j91hEqGTh] x-microsoft-original-message-id: <108C51D4-B575-45D5-A75C-9A63D5294672@outlook.com> x-ms-publictraffictype: Email x-incomingheadercount: 50 x-eopattributedmessage: 0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(5050001)(7020095)(20181119110)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045); SRVR:SG2APC01HT018; x-ms-traffictypediagnostic: SG2APC01HT018: x-microsoft-antispam-message-info: 9C3gdDNv1FhJppY85XiEIU0wcsW8DNwJF1IS0p9SyDtk1IQf4aeC7c1FRkjERMDIocNKLVEyZHwuf+Cww3PEwjzVw7mIL3wfoKFlkFeFfnv7Nokt/q8kBMmSpth8JycKTZjCyZRIzJ7Drryk8BKJ8y6tD6xj0mX9VBTPDtoe5sfPMGebEqEbLa4fwDCsTNrx Content-Type: text/plain; charset="gb2312" Content-ID: <87CA9CD189722A43915A2F31D5584AF7@apcprd06.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 154125c4-80db-4184-43cc-08d6cddb2ac8 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2019 02:17:32.1074 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2APC01HT018 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) DQo+IEkgZG9uJ3QgdW5kZXJzdGFuZCB0aGUgcGF0Y2guIFN5bWJvbCBrcXVldWUxMSBkb2VzIG5v dCBleGlzdCwgc28gZG8geW91IG1lYW4NCj4gDQo+ICsgICAgICAgICAgICAgICAgICBmdW5jIGRp cg0KWWVzLg0KDQo+IA0KPiBBbmQgaGF2ZSB5b3UgYXBwbGllZCB0aGUgdGVzdHMgaW4gZmlsZW5v dGlmeS10ZXN0cy5lbD8gRG8gYWxsIG9mIHRoZW0gcGFzcz8NCj4gDQo+IEJlc3QgcmVnYXJkcywg TWljaGFlbC4NCg0KJCBtYWtlIC1DIHRlc3QgYXV0b3JldmVydC10ZXN0cw0KIEVMQyAgICAgIGxp c3AvYXV0b3JldmVydC10ZXN0cy5lbGMNCiBHRU4gICAgICBsaXNwL2F1dG9yZXZlcnQtdGVzdHMu bG9nDQpSdW5uaW5nIDUgdGVzdHMgKDIwMTktMDUtMDEgMTA6MDY6MzgrMDgwMCkNClJldmVydGlu ZyBidWZmZXIgYGF1dG8tcmV2ZXJ0LXRlc3RxZTRxZWQnLg0KICBwYXNzZWQgIDEvNSAgYXV0by1y ZXZlcnQtdGVzdDAwLWF1dG8tcmV2ZXJ0LW1vZGUNCihTaGVsbCBjb21tYW5kIHN1Y2NlZWRlZCB3 aXRoIG5vIG91dHB1dCkNClRlc3QgYXV0by1yZXZlcnQtdGVzdDAxLWF1dG8tcmV2ZXJ0LXNldmVy YWwtZmlsZXMgYmFja3RyYWNlOg0KIHNpZ25hbChlcnQtdGVzdC1mYWlsZWQgKCgoc2hvdWxkIChz dHJpbmctbWF0Y2ggImFub3RoZXIgdGV4dCIgKGJ1ZmZlDQogZXJ0LWZhaWwoKChzaG91bGQgKHN0 cmluZy1tYXRjaCAiYW5vdGhlciB0ZXh0IiAoYnVmZmVyLXN0cmluZykpKSA6Zm8NCiAoaWYgKHVu d2luZC1wcm90ZWN0IChzZXRxIHZhbHVlLTQwIChhcHBseSBmbi0zOCBhcmdzLTM5KSkgKHNldHEg Zm9ybQ0KIChsZXQgKGZvcm0tZGVzY3JpcHRpb24tNDIpIChpZiAodW53aW5kLXByb3RlY3QgKHNl dHEgdmFsdWUtNDAgKGFwcGx5DQogKGxldCAoKHZhbHVlLTQwIChxdW90ZSBlcnQtZm9ybS1ldmFs dWF0aW9uLWFib3J0ZWQtNDEpKSkgKGxldCAoZm9ybS0NCiAobGV0KiAoKGZuLTM4IChmdW5jdGlv biBzdHJpbmctbWF0Y2gpKSAoYXJncy0zOSAoY29uZGl0aW9uLWNhc2UgZXJyDQogKHNhdmUtY3Vy cmVudC1idWZmZXIgKHNldC1idWZmZXIgYnVmKSAoYXV0by1yZXZlcnQtLXdhaXQtZm9yLXJldmVy dA0KICh3aGlsZSAtLWRvbGlzdC10YWlsLS0gKHNldHEgYnVmIChjYXIgLS1kb2xpc3QtdGFpbC0t KSkgKHNhdmUtY3VycmVuDQogKGxldCAoKC0tZG9saXN0LXRhaWwtLSAobGlzdCBidWYxIGJ1ZjIp KSBidWYpICh3aGlsZSAtLWRvbGlzdC10YWlsLS0NCiAocHJvZ24gKHdyaXRlLXJlZ2lvbiAiYW55 IHRleHQiIG5pbCB0bXBmaWxlMSBuaWwgKHF1b3RlIG5vLW1lc3NhZ2UpKQ0KICh1bndpbmQtcHJv dGVjdCAocHJvZ24gKHdyaXRlLXJlZ2lvbiAiYW55IHRleHQiIG5pbCB0bXBmaWxlMSBuaWwgKHF1 DQogKGxldCogKChhdXRvLXJldmVydC0tbWVzc2FnZXMgIiIpIChnMzAgKGZ1bmN0aW9uIChsYW1i ZGEgKG1zZykgKHNldHENCiAodW53aW5kLXByb3RlY3QgKGxldCogKChhdXRvLXJldmVydC0tbWVz c2FnZXMgIiIpIChnMzAgKGZ1bmN0aW9uIChsYQ0KIChsZXQqICgoY3AgKGV4ZWN1dGFibGUtZmlu ZCAiY3AiKSkgKHRtcGRpcjEgKG1ha2UtdGVtcC1maWxlICJhdXRvLXJlDQogKGxhbWJkYSBuaWwg KGxldCogKChmbi0yMyAoZnVuY3Rpb24gZXhlY3V0YWJsZS1maW5kKSkgKGFyZ3MtMjQgKGNvbmQN CiBlcnQtLXJ1bi10ZXN0LWludGVybmFsKCNzKGVydC0tdGVzdC1leGVjdXRpb24taW5mbyA6dGVz dCAjcyhlcnQtdGVzdA0KIGVydC1ydW4tdGVzdCgjcyhlcnQtdGVzdCA6bmFtZSBhdXRvLXJldmVy dC10ZXN0MDEtYXV0by1yZXZlcnQtc2V2ZXJhDQogZXJ0LXJ1bi1vci1yZXJ1bi10ZXN0KCNzKGVy dC0tc3RhdHMgOnNlbGVjdG9yIChub3QgKHRhZyA6dW5zdGFibGUpKQ0KIGVydC1ydW4tdGVzdHMo KG5vdCAodGFnIDp1bnN0YWJsZSkpICNmKGNvbXBpbGVkLWZ1bmN0aW9uIChldmVudC10eXBlDQog ZXJ0LXJ1bi10ZXN0cy1iYXRjaCgobm90ICh0YWcgOnVuc3RhYmxlKSkpDQogZXJ0LXJ1bi10ZXN0 cy1iYXRjaC1hbmQtZXhpdCgobm90ICh0YWcgOnVuc3RhYmxlKSkpDQogZXZhbCgoZXJ0LXJ1bi10 ZXN0cy1iYXRjaC1hbmQtZXhpdCAocXVvdGUgKG5vdCAodGFnIDp1bnN0YWJsZSkpKSkpDQogY29t bWFuZC1saW5lLTEoKCItTCIgIjouIiAiLWwiICJlcnQiICItbCIgImxpc3AvYXV0b3JldmVydC10 ZXN0cy5lbCINCiBjb21tYW5kLWxpbmUoKQ0KIG5vcm1hbC10b3AtbGV2ZWwoKQ0KVGVzdCBhdXRv LXJldmVydC10ZXN0MDEtYXV0by1yZXZlcnQtc2V2ZXJhbC1maWxlcyBjb25kaXRpb246DQogICAo ZXJ0LXRlc3QtZmFpbGVkDQogICAgKChzaG91bGQNCiAgICAgIChzdHJpbmctbWF0Y2ggImFub3Ro ZXIgdGV4dCINCiAgICAgICAgICAgICAgICAgICAgKGJ1ZmZlci1zdHJpbmcpKSkNCiAgICAgOmZv cm0NCiAgICAgKHN0cmluZy1tYXRjaCAiYW5vdGhlciB0ZXh0IiAiYW55IHRleHQiKQ0KICAgICA6 dmFsdWUgbmlsKSkNCiAgRkFJTEVEICAyLzUgIGF1dG8tcmV2ZXJ0LXRlc3QwMS1hdXRvLXJldmVy dC1zZXZlcmFsLWZpbGVzDQpSZXZlcnRpbmcgYnVmZmVyIGBhdXRvLXJldmVydC10ZXN0NDl2Umx5 Jy4NClJldmVydGluZyBidWZmZXIgYGF1dG8tcmV2ZXJ0LXRlc3Q0OXZSbHknLg0KUmV2ZXJ0aW5n IGJ1ZmZlciBgYXV0by1yZXZlcnQtdGVzdDQ5dlJseScuDQogIHBhc3NlZCAgMy81ICBhdXRvLXJl dmVydC10ZXN0MDItYXV0by1yZXZlcnQtZGVsZXRlZC1maWxlDQpSZXZlcnRpbmcgYnVmZmVyIGBh dXRvLXJldmVydC10ZXN0dlZJeUVZJy4NCiAgcGFzc2VkICA0LzUgIGF1dG8tcmV2ZXJ0LXRlc3Qw My1hdXRvLXJldmVydC10YWlsLW1vZGUNCmxzIGRvZXMgbm90IHN1cHBvcnQgLS1kaXJlZDsgc2Vl IGBkaXJlZC11c2UtbHMtZGlyZWQnIGZvciBtb3JlIGRldGFpbHMuDQpSZXZlcnRpbmcgYnVmZmVy IGBUJy4NClJldmVydGluZyBidWZmZXIgYFQnLg0KICBwYXNzZWQgIDUvNSAgYXV0by1yZXZlcnQt dGVzdDA0LWF1dG8tcmV2ZXJ0LW1vZGUtZGlyZWQNCg0KUmFuIDUgdGVzdHMsIDQgcmVzdWx0cyBh cyBleHBlY3RlZCwgMSB1bmV4cGVjdGVkICgyMDE5LTA1LTAxIDEwOjA3OjIzKzA4MDApDQoNCjEg dW5leHBlY3RlZCByZXN1bHRzOg0KICBGQUlMRUQgIGF1dG8tcmV2ZXJ0LXRlc3QwMS1hdXRvLXJl dmVydC1zZXZlcmFsLWZpbGVzDQoNCm1ha2VbMV06ICoqKiBbbGlzcC9hdXRvcmV2ZXJ0LXRlc3Rz LmxvZ10gRXJyb3IgMQ0KbWFrZTogKioqIFtsaXNwL2F1dG9yZXZlcnQtdGVzdHNdIEVycm9yIDIN Cg0K From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Zhang Haijun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 May 2019 03:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: "35418@debbugs.gnu.org" <35418@debbugs.gnu.org> Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155667959824248 (code B ref 35418); Wed, 01 May 2019 03:00:02 +0000 Received: (at 35418) by debbugs.gnu.org; 1 May 2019 02:59:58 +0000 Received: from localhost ([127.0.0.1]:43007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLfTS-0006J2-CB for submit@debbugs.gnu.org; Tue, 30 Apr 2019 22:59:58 -0400 Received: from mail-oln040092253061.outbound.protection.outlook.com ([40.92.253.61]:34944 helo=APC01-SG2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLfTQ-0006In-Cv for 35418@debbugs.gnu.org; Tue, 30 Apr 2019 22:59:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6DajxGKWW7Tc0WFCUpelaX3canaAHhb2Qe+fT3WlL3A=; b=m46cI5MCZykLxBWkajyQCw+3biz9KuG3DKjFv4sJECvWwzy0IXriJgD3uuKA6KO+guCsu70g3riP4EM653aI+WxEAKoXaxrbVIdKxJ2nBBDKo+oBLQXUkOme93LEdLuHfNNW3g5kl2VT2QQa0e0WKICnEMdAZtMCsyhx2TGNjxVXx4LcZXV2/VVTpBSVZ3Yk3JtRxVuen3ydBkwCEnAhLtYaLxZhUOHQ8+vp52VtT1SjkNSFv3b8ELJ5xWhmBE4899E1j0are0XaL57ONcOXBmjgbl8LKnX0Gh01gePYTzJT1x0EUim3O3VWfl2zCwWabmFwxxjrerhHOS4Rm+HFMw== Received: from HK2APC01FT045.eop-APC01.prod.protection.outlook.com (10.152.248.52) by HK2APC01HT019.eop-APC01.prod.protection.outlook.com (10.152.249.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.13; Wed, 1 May 2019 02:59:48 +0000 Received: from PS1PR06MB2759.apcprd06.prod.outlook.com (10.152.248.60) by HK2APC01FT045.mail.protection.outlook.com (10.152.249.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.13 via Frontend Transport; Wed, 1 May 2019 02:59:48 +0000 Received: from PS1PR06MB2759.apcprd06.prod.outlook.com ([fe80::3c3b:be45:a6af:3d86]) by PS1PR06MB2759.apcprd06.prod.outlook.com ([fe80::3c3b:be45:a6af:3d86%4]) with mapi id 15.20.1835.018; Wed, 1 May 2019 02:59:47 +0000 From: Zhang Haijun Thread-Topic: bug#35418: [PATCH] Don't poll auto-revert files that use notification Thread-Index: AQHU/vCBHkd3xAerUE++lxqH2WqSdKZUSLp7gAFA1ICAAAxsAA== Date: Wed, 1 May 2019 02:59:47 +0000 Message-ID: References: <87tvegt1ip.fsf@gmx.de> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0PR03CA0110.apcprd03.prod.outlook.com (2603:1096:203:b0::26) To PS1PR06MB2759.apcprd06.prod.outlook.com (2603:1096:803:46::13) x-incomingtopheadermarker: OriginalChecksum:576A073975349E34246D7F58DBA5E9393DE13C6859956A798254710AF9A80878; UpperCasedChecksum:A7691015778D5F36F888DD41E04AB1865C4BB48EADBE0A4B819415A4764E82A8; SizeAsReceived:7722; Count:50 x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: Apple Mail (2.3445.9.1) x-tmn: [Qzn417mSvrxiZ187HGw9plRQDpCFpC6S] x-microsoft-original-message-id: x-ms-publictraffictype: Email x-incomingheadercount: 50 x-eopattributedmessage: 0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(5050001)(7020095)(20181119110)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045); SRVR:HK2APC01HT019; x-ms-traffictypediagnostic: HK2APC01HT019: x-microsoft-antispam-message-info: hLZwHjIEXoKLxPSGf7iVYPg0AOMm3Lgk8Wzh6cJxzTro43ofdxWLyIrKpBm++XW5g3IuLtyO+enkEwbJK0DGWHjA5URPcU6YBpXjH1vKNUjd0sC4iqqTSkRA/7H/80xoEJibO4L5pyYs+m90/Ty7juIlxsmzDFmD4BmIV7BhgTMUNBldS1kTnb2hEHM5kO0B Content-Type: text/plain; charset="gb2312" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 65d6dd88-08cc-4a52-b6c9-08d6cde11239 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2019 02:59:47.8443 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT019 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) SSBoYXZlbqGvdCBydW4gdGhlIHRlc3QgYmVmb3JlLiBJdCBzZWVtcyB0aGF0IGRpcmVjdG9yeSB3 YXRjaGluZyBkb2VzbqGvdCB3b3JrIGZvciBmaWxlIGNvbnRlbnQgb25seSBjaGFuZ2UuIEJ1dCBp dCB3b3JrcyBmb3IgbWFueSBjb21tb24gdXNlIGNhc2VzIHdoaWxlIGZpbGUgd2F0Y2hpbmcgZG9l c26hr3Qgd29yay4NCg0KMS4gVXNlIHZpbSB0byBtb2RpZnkgdGhlIGZpbGUgYW5kIHNhdmUuIEl0 IHNlZW1zIHRoYXQgdmltIHdpbGwgd3JpdGUgdG8gYSB0ZW1wIGZpbGUsIHRoZW4gcmVtb3ZlIHRo ZSBvcmlnaW5hbCBmaWxlIGFuZCB0aGVuIHJlbmFtZSB0aGUgdGVtcCBmaWxlIHRvIG9yaWdpbmFs IGZpbGUgbmFtZS4NCjIuIFVzZSBnaXQgdG8gc3dpdGNoIGJyYW5jaC4NCjMuIEZvciBmaWxlcyBp biBhIHNvZnQgbGluayBkaXJlY3RvcnkuDQoNClNvIGRpcmVjdG9yeSB3YXRjaGluZyBpcyBtdWNo IG1vcmUgdXNlZnVsbCBmb3IgbWUgdGhhbiBmaWxlIHdhdGNoaW5nIGluIGV2ZXJ5ZGF5IHVzZS4g DQoNCg0KDQo+INTaIDIwMTnE6jXUwjHI1aOsyc/O5zEwOjE1o6zVxbqjvv0gPGNjc21pbGUyMDA4 QG91dGxvb2suY29tPiDQtLXAo7oNCj4gDQo+IA0KPj4gSSBkb24ndCB1bmRlcnN0YW5kIHRoZSBw YXRjaC4gU3ltYm9sIGtxdWV1ZTExIGRvZXMgbm90IGV4aXN0LCBzbyBkbyB5b3UgbWVhbg0KPj4g DQo+PiArICAgICAgICAgICAgICAgICAgZnVuYyBkaXINCj4gWWVzLg0KPiANCj4+IA0KPj4gQW5k IGhhdmUgeW91IGFwcGxpZWQgdGhlIHRlc3RzIGluIGZpbGVub3RpZnktdGVzdHMuZWw/IERvIGFs bCBvZiB0aGVtIHBhc3M/DQo+PiANCj4+IEJlc3QgcmVnYXJkcywgTWljaGFlbC4NCj4gDQo+ICQg bWFrZSAtQyB0ZXN0IGF1dG9yZXZlcnQtdGVzdHMNCj4gRUxDICAgICAgbGlzcC9hdXRvcmV2ZXJ0 LXRlc3RzLmVsYw0KPiBHRU4gICAgICBsaXNwL2F1dG9yZXZlcnQtdGVzdHMubG9nDQo+IFJ1bm5p bmcgNSB0ZXN0cyAoMjAxOS0wNS0wMSAxMDowNjozOCswODAwKQ0KPiBSZXZlcnRpbmcgYnVmZmVy IGBhdXRvLXJldmVydC10ZXN0cWU0cWVkJy4NCj4gIHBhc3NlZCAgMS81ICBhdXRvLXJldmVydC10 ZXN0MDAtYXV0by1yZXZlcnQtbW9kZQ0KPiAoU2hlbGwgY29tbWFuZCBzdWNjZWVkZWQgd2l0aCBu byBvdXRwdXQpDQo+IFRlc3QgYXV0by1yZXZlcnQtdGVzdDAxLWF1dG8tcmV2ZXJ0LXNldmVyYWwt ZmlsZXMgYmFja3RyYWNlOg0KPiBzaWduYWwoZXJ0LXRlc3QtZmFpbGVkICgoKHNob3VsZCAoc3Ry aW5nLW1hdGNoICJhbm90aGVyIHRleHQiIChidWZmZQ0KPiBlcnQtZmFpbCgoKHNob3VsZCAoc3Ry aW5nLW1hdGNoICJhbm90aGVyIHRleHQiIChidWZmZXItc3RyaW5nKSkpIDpmbw0KPiAoaWYgKHVu d2luZC1wcm90ZWN0IChzZXRxIHZhbHVlLTQwIChhcHBseSBmbi0zOCBhcmdzLTM5KSkgKHNldHEg Zm9ybQ0KPiAobGV0IChmb3JtLWRlc2NyaXB0aW9uLTQyKSAoaWYgKHVud2luZC1wcm90ZWN0IChz ZXRxIHZhbHVlLTQwIChhcHBseQ0KPiAobGV0ICgodmFsdWUtNDAgKHF1b3RlIGVydC1mb3JtLWV2 YWx1YXRpb24tYWJvcnRlZC00MSkpKSAobGV0IChmb3JtLQ0KPiAobGV0KiAoKGZuLTM4IChmdW5j dGlvbiBzdHJpbmctbWF0Y2gpKSAoYXJncy0zOSAoY29uZGl0aW9uLWNhc2UgZXJyDQo+IChzYXZl LWN1cnJlbnQtYnVmZmVyIChzZXQtYnVmZmVyIGJ1ZikgKGF1dG8tcmV2ZXJ0LS13YWl0LWZvci1y ZXZlcnQNCj4gKHdoaWxlIC0tZG9saXN0LXRhaWwtLSAoc2V0cSBidWYgKGNhciAtLWRvbGlzdC10 YWlsLS0pKSAoc2F2ZS1jdXJyZW4NCj4gKGxldCAoKC0tZG9saXN0LXRhaWwtLSAobGlzdCBidWYx IGJ1ZjIpKSBidWYpICh3aGlsZSAtLWRvbGlzdC10YWlsLS0NCj4gKHByb2duICh3cml0ZS1yZWdp b24gImFueSB0ZXh0IiBuaWwgdG1wZmlsZTEgbmlsIChxdW90ZSBuby1tZXNzYWdlKSkNCj4gKHVu d2luZC1wcm90ZWN0IChwcm9nbiAod3JpdGUtcmVnaW9uICJhbnkgdGV4dCIgbmlsIHRtcGZpbGUx IG5pbCAocXUNCj4gKGxldCogKChhdXRvLXJldmVydC0tbWVzc2FnZXMgIiIpIChnMzAgKGZ1bmN0 aW9uIChsYW1iZGEgKG1zZykgKHNldHENCj4gKHVud2luZC1wcm90ZWN0IChsZXQqICgoYXV0by1y ZXZlcnQtLW1lc3NhZ2VzICIiKSAoZzMwIChmdW5jdGlvbiAobGENCj4gKGxldCogKChjcCAoZXhl Y3V0YWJsZS1maW5kICJjcCIpKSAodG1wZGlyMSAobWFrZS10ZW1wLWZpbGUgImF1dG8tcmUNCj4g KGxhbWJkYSBuaWwgKGxldCogKChmbi0yMyAoZnVuY3Rpb24gZXhlY3V0YWJsZS1maW5kKSkgKGFy Z3MtMjQgKGNvbmQNCj4gZXJ0LS1ydW4tdGVzdC1pbnRlcm5hbCgjcyhlcnQtLXRlc3QtZXhlY3V0 aW9uLWluZm8gOnRlc3QgI3MoZXJ0LXRlc3QNCj4gZXJ0LXJ1bi10ZXN0KCNzKGVydC10ZXN0IDpu YW1lIGF1dG8tcmV2ZXJ0LXRlc3QwMS1hdXRvLXJldmVydC1zZXZlcmENCj4gZXJ0LXJ1bi1vci1y ZXJ1bi10ZXN0KCNzKGVydC0tc3RhdHMgOnNlbGVjdG9yIChub3QgKHRhZyA6dW5zdGFibGUpKQ0K PiBlcnQtcnVuLXRlc3RzKChub3QgKHRhZyA6dW5zdGFibGUpKSAjZihjb21waWxlZC1mdW5jdGlv biAoZXZlbnQtdHlwZQ0KPiBlcnQtcnVuLXRlc3RzLWJhdGNoKChub3QgKHRhZyA6dW5zdGFibGUp KSkNCj4gZXJ0LXJ1bi10ZXN0cy1iYXRjaC1hbmQtZXhpdCgobm90ICh0YWcgOnVuc3RhYmxlKSkp DQo+IGV2YWwoKGVydC1ydW4tdGVzdHMtYmF0Y2gtYW5kLWV4aXQgKHF1b3RlIChub3QgKHRhZyA6 dW5zdGFibGUpKSkpKQ0KPiBjb21tYW5kLWxpbmUtMSgoIi1MIiAiOi4iICItbCIgImVydCIgIi1s IiAibGlzcC9hdXRvcmV2ZXJ0LXRlc3RzLmVsIg0KPiBjb21tYW5kLWxpbmUoKQ0KPiBub3JtYWwt dG9wLWxldmVsKCkNCj4gVGVzdCBhdXRvLXJldmVydC10ZXN0MDEtYXV0by1yZXZlcnQtc2V2ZXJh bC1maWxlcyBjb25kaXRpb246DQo+ICAgKGVydC10ZXN0LWZhaWxlZA0KPiAgICAoKHNob3VsZA0K PiAgICAgIChzdHJpbmctbWF0Y2ggImFub3RoZXIgdGV4dCINCj4gICAgICAgICAgICAgICAgICAg IChidWZmZXItc3RyaW5nKSkpDQo+ICAgICA6Zm9ybQ0KPiAgICAgKHN0cmluZy1tYXRjaCAiYW5v dGhlciB0ZXh0IiAiYW55IHRleHQiKQ0KPiAgICAgOnZhbHVlIG5pbCkpDQo+ICBGQUlMRUQgIDIv NSAgYXV0by1yZXZlcnQtdGVzdDAxLWF1dG8tcmV2ZXJ0LXNldmVyYWwtZmlsZXMNCj4gUmV2ZXJ0 aW5nIGJ1ZmZlciBgYXV0by1yZXZlcnQtdGVzdDQ5dlJseScuDQo+IFJldmVydGluZyBidWZmZXIg YGF1dG8tcmV2ZXJ0LXRlc3Q0OXZSbHknLg0KPiBSZXZlcnRpbmcgYnVmZmVyIGBhdXRvLXJldmVy dC10ZXN0NDl2Umx5Jy4NCj4gIHBhc3NlZCAgMy81ICBhdXRvLXJldmVydC10ZXN0MDItYXV0by1y ZXZlcnQtZGVsZXRlZC1maWxlDQo+IFJldmVydGluZyBidWZmZXIgYGF1dG8tcmV2ZXJ0LXRlc3R2 Vkl5RVknLg0KPiAgcGFzc2VkICA0LzUgIGF1dG8tcmV2ZXJ0LXRlc3QwMy1hdXRvLXJldmVydC10 YWlsLW1vZGUNCj4gbHMgZG9lcyBub3Qgc3VwcG9ydCAtLWRpcmVkOyBzZWUgYGRpcmVkLXVzZS1s cy1kaXJlZCcgZm9yIG1vcmUgZGV0YWlscy4NCj4gUmV2ZXJ0aW5nIGJ1ZmZlciBgVCcuDQo+IFJl dmVydGluZyBidWZmZXIgYFQnLg0KPiAgcGFzc2VkICA1LzUgIGF1dG8tcmV2ZXJ0LXRlc3QwNC1h dXRvLXJldmVydC1tb2RlLWRpcmVkDQo+IA0KPiBSYW4gNSB0ZXN0cywgNCByZXN1bHRzIGFzIGV4 cGVjdGVkLCAxIHVuZXhwZWN0ZWQgKDIwMTktMDUtMDEgMTA6MDc6MjMrMDgwMCkNCj4gDQo+IDEg dW5leHBlY3RlZCByZXN1bHRzOg0KPiAgRkFJTEVEICBhdXRvLXJldmVydC10ZXN0MDEtYXV0by1y ZXZlcnQtc2V2ZXJhbC1maWxlcw0KPiANCj4gbWFrZVsxXTogKioqIFtsaXNwL2F1dG9yZXZlcnQt dGVzdHMubG9nXSBFcnJvciAxDQo+IG1ha2U6ICoqKiBbbGlzcC9hdXRvcmV2ZXJ0LXRlc3RzXSBF cnJvciAyDQo+IA0KDQo= From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Zhang Haijun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 May 2019 03:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: "35418@debbugs.gnu.org" <35418@debbugs.gnu.org> Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155668023525352 (code B ref 35418); Wed, 01 May 2019 03:11:02 +0000 Received: (at 35418) by debbugs.gnu.org; 1 May 2019 03:10:35 +0000 Received: from localhost ([127.0.0.1]:43030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLfdj-0006ap-6s for submit@debbugs.gnu.org; Tue, 30 Apr 2019 23:10:35 -0400 Received: from mail-oln040092254031.outbound.protection.outlook.com ([40.92.254.31]:22976 helo=APC01-PU1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLfdg-0006aa-BH for 35418@debbugs.gnu.org; Tue, 30 Apr 2019 23:10:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+lah9roQTN+lkMCkEohRs2CkZXKELmHlwsDU5nmaA9k=; b=LT5nMn4UdYUebjkdp8gPIhecBSz2Zcg1B9aoLw3uhPZZ8kOkdORpYUjp6+WCCC8UxZkxHYfJ+8f3qzmQnuISQoxEyXdPuP6OkBuTI7ST8VNJEGMhkvxYDm78d41D+u7yv/M4Xg9adha6QiyutElS9V7kK3P47Qg28OJSjpW66UhIbU4N4eMO64W6WRC2Ba1iOi8JBjnTqKM+2dmwuQo2+/4TQUQg5+iNxru/77Y0ULNZW6ugoMfTSgUlE14jXfbE6H1M+kVWMWqlNT4Z29sDWtV3VebjkwP5yQuBrAnmjaK7LSCQs4wFti6OWr6GLUJywSGjBF0zSUXdeLPeEXwiow== Received: from SG2APC01FT062.eop-APC01.prod.protection.outlook.com (10.152.250.54) by SG2APC01HT223.eop-APC01.prod.protection.outlook.com (10.152.251.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1835.13; Wed, 1 May 2019 03:10:20 +0000 Received: from PS1PR06MB2759.apcprd06.prod.outlook.com (10.152.250.55) by SG2APC01FT062.mail.protection.outlook.com (10.152.251.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.13 via Frontend Transport; Wed, 1 May 2019 03:10:20 +0000 Received: from PS1PR06MB2759.apcprd06.prod.outlook.com ([fe80::3c3b:be45:a6af:3d86]) by PS1PR06MB2759.apcprd06.prod.outlook.com ([fe80::3c3b:be45:a6af:3d86%4]) with mapi id 15.20.1835.018; Wed, 1 May 2019 03:10:20 +0000 From: Zhang Haijun Thread-Topic: bug#35418: [PATCH] Don't poll auto-revert files that use notification Thread-Index: AQHU/vCBHkd3xAerUE++lxqH2WqSdKZUSLp7gAFA1ICAAAxsAIAAAuwA Date: Wed, 1 May 2019 03:10:20 +0000 Message-ID: References: <87tvegt1ip.fsf@gmx.de> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0PR01CA0028.apcprd01.prod.exchangelabs.com (2603:1096:203:3e::16) To PS1PR06MB2759.apcprd06.prod.outlook.com (2603:1096:803:46::13) x-incomingtopheadermarker: OriginalChecksum:89908B3B9E27747F34973B8C00B1919E09FA4B14F780430714083EF9E381E234; UpperCasedChecksum:97D7178182ECE71553BED0A4CF070F031CFA5982A601C4D2056D55D43D2B7967; SizeAsReceived:7839; Count:50 x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: Apple Mail (2.3445.9.1) x-tmn: [H0FOJWmg2yKlF3gzBADGc4Q5VHfYZ5x/] x-microsoft-original-message-id: <4959CC85-F30F-4139-849A-22B1E7E7867C@outlook.com> x-ms-publictraffictype: Email x-incomingheadercount: 50 x-eopattributedmessage: 0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(5050001)(7020095)(20181119110)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045); SRVR:SG2APC01HT223; x-ms-traffictypediagnostic: SG2APC01HT223: x-microsoft-antispam-message-info: kJAbWhZsn81vbNFsLdK0lZ0oa7yc7P3ICMlLu7PylYTUv8McBsxETXW96EZn3zJT3YZsE1OIWOdAm/jQ1uJBGvDsaxpuwdINK5Hw5Hf6RJeBRdOiHWXRFJr7G46rTQULvh2LTquXMLiP2faKV+HRlYvT/BIch1BC2yu7WN9Vu3mnqCY1n94ynCksQLBGgIwo Content-Type: text/plain; charset="gb2312" Content-ID: <797956E4854BAF49B4701C4B8045E6C4@apcprd06.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 6c956bbe-654a-4414-0964-08d6cde28b5d X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2019 03:10:20.5748 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2APC01HT223 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) SWYgYm90aCBmaWxlIHdhdGNoaW5nIGFuZCBkaXJlY3Rvcnkgd2F0Y2hpbmcgYXJlIHVzZWQgZm9y IG9uZSBmaWxlLCBpdCB3aWxsIHdvcmtzIGZvciBhbGwgdXNlIGNhc2VzLg0KDQo+INTaIDIwMTnE 6jXUwjHI1aOsyc/O5zEwOjU5o6zVxbqjvv0gPGNjc21pbGUyMDA4QG91dGxvb2suY29tPiDQtLXA o7oNCj4gDQo+IEkgaGF2ZW6hr3QgcnVuIHRoZSB0ZXN0IGJlZm9yZS4gSXQgc2VlbXMgdGhhdCBk aXJlY3Rvcnkgd2F0Y2hpbmcgZG9lc26hr3Qgd29yayBmb3IgZmlsZSBjb250ZW50IG9ubHkgY2hh bmdlLiBCdXQgaXQgd29ya3MgZm9yIG1hbnkgY29tbW9uIHVzZSBjYXNlcyB3aGlsZSBmaWxlIHdh dGNoaW5nIGRvZXNuoa90IHdvcmsuDQo+IA0KPiAxLiBVc2UgdmltIHRvIG1vZGlmeSB0aGUgZmls ZSBhbmQgc2F2ZS4gSXQgc2VlbXMgdGhhdCB2aW0gd2lsbCB3cml0ZSB0byBhIHRlbXAgZmlsZSwg dGhlbiByZW1vdmUgdGhlIG9yaWdpbmFsIGZpbGUgYW5kIHRoZW4gcmVuYW1lIHRoZSB0ZW1wIGZp bGUgdG8gb3JpZ2luYWwgZmlsZSBuYW1lLg0KPiAyLiBVc2UgZ2l0IHRvIHN3aXRjaCBicmFuY2gu DQo+IDMuIEZvciBmaWxlcyBpbiBhIHNvZnQgbGluayBkaXJlY3RvcnkuDQo+IA0KPiBTbyBkaXJl Y3Rvcnkgd2F0Y2hpbmcgaXMgbXVjaCBtb3JlIHVzZWZ1bGwgZm9yIG1lIHRoYW4gZmlsZSB3YXRj aGluZyBpbiBldmVyeWRheSB1c2UuIA0KPiANCj4gDQo+IA0KPj4g1NogMjAxOcTqNdTCMcjVo6zJ z87nMTA6MTWjrNXFuqO+/SA8Y2NzbWlsZTIwMDhAb3V0bG9vay5jb20+INC0tcCjug0KPj4gDQo+ PiANCj4+PiBJIGRvbid0IHVuZGVyc3RhbmQgdGhlIHBhdGNoLiBTeW1ib2wga3F1ZXVlMTEgZG9l cyBub3QgZXhpc3QsIHNvIGRvIHlvdSBtZWFuDQo+Pj4gDQo+Pj4gKyAgICAgICAgICAgICAgICAg IGZ1bmMgZGlyDQo+PiBZZXMuDQo+PiANCj4+PiANCj4+PiBBbmQgaGF2ZSB5b3UgYXBwbGllZCB0 aGUgdGVzdHMgaW4gZmlsZW5vdGlmeS10ZXN0cy5lbD8gRG8gYWxsIG9mIHRoZW0gcGFzcz8NCj4+ PiANCj4+PiBCZXN0IHJlZ2FyZHMsIE1pY2hhZWwuDQo+PiANCj4+ICQgbWFrZSAtQyB0ZXN0IGF1 dG9yZXZlcnQtdGVzdHMNCj4+IEVMQyAgICAgIGxpc3AvYXV0b3JldmVydC10ZXN0cy5lbGMNCj4+ IEdFTiAgICAgIGxpc3AvYXV0b3JldmVydC10ZXN0cy5sb2cNCj4+IFJ1bm5pbmcgNSB0ZXN0cyAo MjAxOS0wNS0wMSAxMDowNjozOCswODAwKQ0KPj4gUmV2ZXJ0aW5nIGJ1ZmZlciBgYXV0by1yZXZl cnQtdGVzdHFlNHFlZCcuDQo+PiBwYXNzZWQgIDEvNSAgYXV0by1yZXZlcnQtdGVzdDAwLWF1dG8t cmV2ZXJ0LW1vZGUNCj4+IChTaGVsbCBjb21tYW5kIHN1Y2NlZWRlZCB3aXRoIG5vIG91dHB1dCkN Cj4+IFRlc3QgYXV0by1yZXZlcnQtdGVzdDAxLWF1dG8tcmV2ZXJ0LXNldmVyYWwtZmlsZXMgYmFj a3RyYWNlOg0KPj4gc2lnbmFsKGVydC10ZXN0LWZhaWxlZCAoKChzaG91bGQgKHN0cmluZy1tYXRj aCAiYW5vdGhlciB0ZXh0IiAoYnVmZmUNCj4+IGVydC1mYWlsKCgoc2hvdWxkIChzdHJpbmctbWF0 Y2ggImFub3RoZXIgdGV4dCIgKGJ1ZmZlci1zdHJpbmcpKSkgOmZvDQo+PiAoaWYgKHVud2luZC1w cm90ZWN0IChzZXRxIHZhbHVlLTQwIChhcHBseSBmbi0zOCBhcmdzLTM5KSkgKHNldHEgZm9ybQ0K Pj4gKGxldCAoZm9ybS1kZXNjcmlwdGlvbi00MikgKGlmICh1bndpbmQtcHJvdGVjdCAoc2V0cSB2 YWx1ZS00MCAoYXBwbHkNCj4+IChsZXQgKCh2YWx1ZS00MCAocXVvdGUgZXJ0LWZvcm0tZXZhbHVh dGlvbi1hYm9ydGVkLTQxKSkpIChsZXQgKGZvcm0tDQo+PiAobGV0KiAoKGZuLTM4IChmdW5jdGlv biBzdHJpbmctbWF0Y2gpKSAoYXJncy0zOSAoY29uZGl0aW9uLWNhc2UgZXJyDQo+PiAoc2F2ZS1j dXJyZW50LWJ1ZmZlciAoc2V0LWJ1ZmZlciBidWYpIChhdXRvLXJldmVydC0td2FpdC1mb3ItcmV2 ZXJ0DQo+PiAod2hpbGUgLS1kb2xpc3QtdGFpbC0tIChzZXRxIGJ1ZiAoY2FyIC0tZG9saXN0LXRh aWwtLSkpIChzYXZlLWN1cnJlbg0KPj4gKGxldCAoKC0tZG9saXN0LXRhaWwtLSAobGlzdCBidWYx IGJ1ZjIpKSBidWYpICh3aGlsZSAtLWRvbGlzdC10YWlsLS0NCj4+IChwcm9nbiAod3JpdGUtcmVn aW9uICJhbnkgdGV4dCIgbmlsIHRtcGZpbGUxIG5pbCAocXVvdGUgbm8tbWVzc2FnZSkpDQo+PiAo dW53aW5kLXByb3RlY3QgKHByb2duICh3cml0ZS1yZWdpb24gImFueSB0ZXh0IiBuaWwgdG1wZmls ZTEgbmlsIChxdQ0KPj4gKGxldCogKChhdXRvLXJldmVydC0tbWVzc2FnZXMgIiIpIChnMzAgKGZ1 bmN0aW9uIChsYW1iZGEgKG1zZykgKHNldHENCj4+ICh1bndpbmQtcHJvdGVjdCAobGV0KiAoKGF1 dG8tcmV2ZXJ0LS1tZXNzYWdlcyAiIikgKGczMCAoZnVuY3Rpb24gKGxhDQo+PiAobGV0KiAoKGNw IChleGVjdXRhYmxlLWZpbmQgImNwIikpICh0bXBkaXIxIChtYWtlLXRlbXAtZmlsZSAiYXV0by1y ZQ0KPj4gKGxhbWJkYSBuaWwgKGxldCogKChmbi0yMyAoZnVuY3Rpb24gZXhlY3V0YWJsZS1maW5k KSkgKGFyZ3MtMjQgKGNvbmQNCj4+IGVydC0tcnVuLXRlc3QtaW50ZXJuYWwoI3MoZXJ0LS10ZXN0 LWV4ZWN1dGlvbi1pbmZvIDp0ZXN0ICNzKGVydC10ZXN0DQo+PiBlcnQtcnVuLXRlc3QoI3MoZXJ0 LXRlc3QgOm5hbWUgYXV0by1yZXZlcnQtdGVzdDAxLWF1dG8tcmV2ZXJ0LXNldmVyYQ0KPj4gZXJ0 LXJ1bi1vci1yZXJ1bi10ZXN0KCNzKGVydC0tc3RhdHMgOnNlbGVjdG9yIChub3QgKHRhZyA6dW5z dGFibGUpKQ0KPj4gZXJ0LXJ1bi10ZXN0cygobm90ICh0YWcgOnVuc3RhYmxlKSkgI2YoY29tcGls ZWQtZnVuY3Rpb24gKGV2ZW50LXR5cGUNCj4+IGVydC1ydW4tdGVzdHMtYmF0Y2goKG5vdCAodGFn IDp1bnN0YWJsZSkpKQ0KPj4gZXJ0LXJ1bi10ZXN0cy1iYXRjaC1hbmQtZXhpdCgobm90ICh0YWcg OnVuc3RhYmxlKSkpDQo+PiBldmFsKChlcnQtcnVuLXRlc3RzLWJhdGNoLWFuZC1leGl0IChxdW90 ZSAobm90ICh0YWcgOnVuc3RhYmxlKSkpKSkNCj4+IGNvbW1hbmQtbGluZS0xKCgiLUwiICI6LiIg Ii1sIiAiZXJ0IiAiLWwiICJsaXNwL2F1dG9yZXZlcnQtdGVzdHMuZWwiDQo+PiBjb21tYW5kLWxp bmUoKQ0KPj4gbm9ybWFsLXRvcC1sZXZlbCgpDQo+PiBUZXN0IGF1dG8tcmV2ZXJ0LXRlc3QwMS1h dXRvLXJldmVydC1zZXZlcmFsLWZpbGVzIGNvbmRpdGlvbjoNCj4+ICAoZXJ0LXRlc3QtZmFpbGVk DQo+PiAgICgoc2hvdWxkDQo+PiAgICAgKHN0cmluZy1tYXRjaCAiYW5vdGhlciB0ZXh0Ig0KPj4g ICAgICAgICAgICAgICAgICAgKGJ1ZmZlci1zdHJpbmcpKSkNCj4+ICAgIDpmb3JtDQo+PiAgICAo c3RyaW5nLW1hdGNoICJhbm90aGVyIHRleHQiICJhbnkgdGV4dCIpDQo+PiAgICA6dmFsdWUgbmls KSkNCj4+IEZBSUxFRCAgMi81ICBhdXRvLXJldmVydC10ZXN0MDEtYXV0by1yZXZlcnQtc2V2ZXJh bC1maWxlcw0KPj4gUmV2ZXJ0aW5nIGJ1ZmZlciBgYXV0by1yZXZlcnQtdGVzdDQ5dlJseScuDQo+ PiBSZXZlcnRpbmcgYnVmZmVyIGBhdXRvLXJldmVydC10ZXN0NDl2Umx5Jy4NCj4+IFJldmVydGlu ZyBidWZmZXIgYGF1dG8tcmV2ZXJ0LXRlc3Q0OXZSbHknLg0KPj4gcGFzc2VkICAzLzUgIGF1dG8t cmV2ZXJ0LXRlc3QwMi1hdXRvLXJldmVydC1kZWxldGVkLWZpbGUNCj4+IFJldmVydGluZyBidWZm ZXIgYGF1dG8tcmV2ZXJ0LXRlc3R2Vkl5RVknLg0KPj4gcGFzc2VkICA0LzUgIGF1dG8tcmV2ZXJ0 LXRlc3QwMy1hdXRvLXJldmVydC10YWlsLW1vZGUNCj4+IGxzIGRvZXMgbm90IHN1cHBvcnQgLS1k aXJlZDsgc2VlIGBkaXJlZC11c2UtbHMtZGlyZWQnIGZvciBtb3JlIGRldGFpbHMuDQo+PiBSZXZl cnRpbmcgYnVmZmVyIGBUJy4NCj4+IFJldmVydGluZyBidWZmZXIgYFQnLg0KPj4gcGFzc2VkICA1 LzUgIGF1dG8tcmV2ZXJ0LXRlc3QwNC1hdXRvLXJldmVydC1tb2RlLWRpcmVkDQo+PiANCj4+IFJh biA1IHRlc3RzLCA0IHJlc3VsdHMgYXMgZXhwZWN0ZWQsIDEgdW5leHBlY3RlZCAoMjAxOS0wNS0w MSAxMDowNzoyMyswODAwKQ0KPj4gDQo+PiAxIHVuZXhwZWN0ZWQgcmVzdWx0czoNCj4+IEZBSUxF RCAgYXV0by1yZXZlcnQtdGVzdDAxLWF1dG8tcmV2ZXJ0LXNldmVyYWwtZmlsZXMNCj4+IA0KPj4g bWFrZVsxXTogKioqIFtsaXNwL2F1dG9yZXZlcnQtdGVzdHMubG9nXSBFcnJvciAxDQo+PiBtYWtl OiAqKiogW2xpc3AvYXV0b3JldmVydC10ZXN0c10gRXJyb3IgMg0KPj4gDQo+IA0KDQo= From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 May 2019 17:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155673275010633 (code B ref 35418); Wed, 01 May 2019 17:46:02 +0000 Received: (at 35418) by debbugs.gnu.org; 1 May 2019 17:45:50 +0000 Received: from localhost ([127.0.0.1]:44839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLtIk-0002lQ-7m for submit@debbugs.gnu.org; Wed, 01 May 2019 13:45:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLtIi-0002lE-0z for 35418@debbugs.gnu.org; Wed, 01 May 2019 13:45:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLtIc-0003Vg-JU; Wed, 01 May 2019 13:45:42 -0400 Received: from [176.228.60.248] (port=1972 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hLtIY-0004WF-1e; Wed, 01 May 2019 13:45:42 -0400 Date: Wed, 01 May 2019 20:45:21 +0300 Message-Id: <834l6eqdam.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Tue, 30 Apr 2019 23:09:08 +0200) References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Cc: michael.albinus@gmx.de, 35418@debbugs.gnu.org > Date: Tue, 30 Apr 2019 23:09:08 +0200 > > Here is a patch that does roughly that. I'm not entirely happy with the > old 'Auto-reverting non-buffer files' section, whose node name was just > 'Autorevert'. I would have preferred it as a subsection to the new > auto-revert section, along with its existing two subsections, but since > its place isn't the same in the on-line and printed manuals, that > seemed technically tricky without duplicating a lot of text. Didn't yet review the patch, but I don't understand the difficulty with moving 'Auto-reverting non-buffer files' into Auto-revert. Can you explain what gets in the way? From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 May 2019 19:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155673970621323 (code B ref 35418); Wed, 01 May 2019 19:42:02 +0000 Received: (at 35418) by debbugs.gnu.org; 1 May 2019 19:41:46 +0000 Received: from localhost ([127.0.0.1]:44967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLv6v-0005Xr-V4 for submit@debbugs.gnu.org; Wed, 01 May 2019 15:41:46 -0400 Received: from mail85c50.megamailservers.eu ([91.136.10.95]:36682 helo=mail18c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLv6s-0005Xg-VA for 35418@debbugs.gnu.org; Wed, 01 May 2019 15:41:44 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556739701; bh=2O4Fyv2rPV1yHjHIJ3rRwioB1K0Wu9vdjS8kNtGyrmo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=ote7ZPyCXXVT4anrP50FrQL1amMW5mPio781LipRUOmYy+aG+Jcb/UAt6FVUl9JZY 18j1stP19MqWOJgXoW+hUBYrcHKBzfFooXBbqNJg7Pli+8OjjowN4bH5pHR+jCEgv1 oRSPznalZys/cMwH0dRKQW6VEmDPD0rqCjsYMaGE= Feedback-ID: mattiase@acm.or Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x41JfdEk025462; Wed, 1 May 2019 19:41:40 +0000 Message-ID: <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Date: Wed, 01 May 2019 21:41:38 +0200 In-Reply-To: <834l6eqdam.fsf@gnu.org> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> Content-Type: multipart/mixed; boundary="=-7YSQNPnVKx7RjTbkayMQ" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 X-CTCH-RefID: str=0001.0A0B020D.5CC9F675.0006, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=W4oWqyek c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=uGlCoH4LM_bGQZCwcMsA:9 a=QEXdDO2ut3YA:10 a=N54-gffFAAAA:8 a=05VGI6y5R-z8mz6QroMA:9 a=noFUfWHkRFwl99Cn:21 a=nKzoe16jjEAGLIDu:21 a=B2y7HmGcmWMA:10 a=6l0D2HzqY3Epnrm8mE3f:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-7YSQNPnVKx7RjTbkayMQ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit ons 2019-05-01 klockan 20:45 +0300 skrev Eli Zaretskii: > > Didn't yet review the patch, but I don't understand the difficulty > with moving 'Auto-reverting non-buffer files' into Auto-revert. Can > you explain what gets in the way? After applying the patch, the on-line manual would have the nodes * Reverting (about reverting) * Auto-revert (about auto-revert) * Non-file buffers (about auto-reverting non-file buffers) ** Auto-reverting the buffer menu ** Auto-reverting Dired but I'd rather have * Reverting (about reverting) * Auto-revert (about auto-revert, including non-buffer files) ** Auto-reverting the buffer menu ** Auto-reverting Dired except that in the printed manual, the non-buffer part is a section of its own. The attached patch hacks around it by removing @node and @section from arevert-xtra.texi; perhaps it can be stomached. --=-7YSQNPnVKx7RjTbkayMQ Content-Disposition: attachment; filename="0001-Reorganise-auto-revert-nodes-in-the-manual.patch" Content-Type: text/x-patch; name="0001-Reorganise-auto-revert-nodes-in-the-manual.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAyMWM0NDUxZjQ2MzcwMGUyYTZmN2EyNTZiMjE0ZWVkODlhOWUzZDNkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWF0dGlhcz0yMEVuZ2RlZz1DMz1BNXJkPz0g PG1hdHRpYXNlQGFjbS5vcmc+CkRhdGU6IFR1ZSwgMzAgQXByIDIwMTkgMjI6MzU6NTYgKzAyMDAK U3ViamVjdDogW1BBVENIXSBSZW9yZ2FuaXNlIChhdXRvLSlyZXZlcnQgbm9kZXMgaW4gdGhlIG1h bnVhbAoKVGhlIGFtb3VudCBvZiBpbmZvcm1hdGlvbiBvbiBhdXRvLXJldmVydCBoYXMgZ3Jvd24g dG8gZGVzZXJ2ZSBhCnNlY3Rpb24gb2YgaXRzIG93biAoYnVnIzM1NDE4KS4KCiogZG9jL2VtYWNz L2ZpbGVzLnRleGk6CiogZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50ZXhpOgoqIGRvYy9lbWFjcy9i dWZmZXJzLnRleGk6CiogZG9jL2VtYWNzL2VtYWNzLnRleGk6CiogZG9jL2VtYWNzL2VtYWNzLXh0 cmEudGV4aToKQWRkIG5vZGUgJ0F1dG8tcmV2ZXJ0JyBhbmQgbW92ZSBnZW5lcmFsIGluZm9ybWF0 aW9uIG9uIHRoYXQgdG9waWMgdGhlcmUuClNvcnQgcGFyYWdyYXBocyBpbiB0aGF0IG5vZGUgaW4g YSByb3VnaCBsZWFzdC10by1tb3N0IHNwZWNpZmljIG9yZGVyLgpJbmNsdWRlIHRoZSBvbGQgJ0F1 dG9yZXZlcnQnIG5vZGUgaW50byB0aGF0IG5vZGUgd2hlbiBidWlsZGluZyB0aGUKb24tbGluZSBt YW51YWwuCi0tLQogZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50ZXhpIHwgIDMgKy0KIGRvYy9lbWFj cy9idWZmZXJzLnRleGkgICAgICB8ICA0ICstLQogZG9jL2VtYWNzL2VtYWNzLXh0cmEudGV4aSAg IHwgIDIgKysKIGRvYy9lbWFjcy9lbWFjcy50ZXhpICAgICAgICB8ICA0ICstLQogZG9jL2VtYWNz L2ZpbGVzLnRleGkgICAgICAgIHwgNjAgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0t LS0tLQogNSBmaWxlcyBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCAzMyBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9kb2MvZW1hY3MvYXJldmVydC14dHJhLnRleGkgYi9kb2MvZW1hY3MvYXJl dmVydC14dHJhLnRleGkKaW5kZXggY2Q3YzFmZjg5NS4uOGNjNWIwNTNiNSAxMDA2NDQKLS0tIGEv ZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50ZXhpCisrKyBiL2RvYy9lbWFjcy9hcmV2ZXJ0LXh0cmEu dGV4aQpAQCAtNCw4ICs0LDcgQEAKIEBjCiBAYyBUaGlzIGZpbGUgaXMgaW5jbHVkZWQgZWl0aGVy IGluIGVtYWNzLXh0cmEudGV4aSAod2hlbiBwcm9kdWNpbmcgdGhlCiBAYyBwcmludGVkIHZlcnNp b24pIG9yIGluIHRoZSBtYWluIEVtYWNzIG1hbnVhbCAoZm9yIHRoZSBvbi1saW5lIHZlcnNpb24p LgotQG5vZGUgQXV0b3JldmVydAotQHNlY3Rpb24gQXV0byBSZXZlcnRpbmcgTm9uLUZpbGUgQnVm ZmVycworQGMgVGhlIGluY2x1ZGluZyBmaWxlIG11c3QgcHJvdmlkZSBpdHMgb3duIEBub2RlIGFu ZCBAc2VjdGlvbiBsaW5lcy4KIAogR2xvYmFsIEF1dG8gUmV2ZXJ0IE1vZGUgbm9ybWFsbHkgb25s eSByZXZlcnRzIGZpbGUgYnVmZmVycy4gIFRoZXJlIGFyZQogdHdvIHdheXMgdG8gYXV0by1yZXZl cnQgY2VydGFpbiBub24tZmlsZSBidWZmZXJzOiBieSBlbmFibGluZyBBdXRvCmRpZmYgLS1naXQg YS9kb2MvZW1hY3MvYnVmZmVycy50ZXhpIGIvZG9jL2VtYWNzL2J1ZmZlcnMudGV4aQppbmRleCAy N2ZjYjczNjlhLi4xNGEwYTAxY2E4IDEwMDY0NAotLS0gYS9kb2MvZW1hY3MvYnVmZmVycy50ZXhp CisrKyBiL2RvYy9lbWFjcy9idWZmZXJzLnRleGkKQEAgLTU2OCwxMCArNTY4LDEwIEBAIFNldmVy YWwgQnVmZmVycwogQXV0byBSZXZlcnQgbW9kZSBhcHBsaWVzIHRvIHRoZSBAZmlsZXsqQnVmZmVy IExpc3QqfSBidWZmZXIgb25seSBpZgogQGNvZGV7Z2xvYmFsLWF1dG8tcmV2ZXJ0LW5vbi1maWxl LWJ1ZmZlcnN9IGlzIG5vbi1AY29kZXtuaWx9LgogQGlmdGV4Ci1AaW5mb3JlZntBdXRvcmV2ZXJ0 LCwgZW1hY3MteHRyYX0sIGZvciBkZXRhaWxzLgorQGluZm9yZWZ7QXV0byBSZXZlcnRpbmcgdGhl IEJ1ZmZlciBNZW51LCwgZW1hY3MteHRyYX0sIGZvciBkZXRhaWxzLgogQGVuZCBpZnRleAogQGlm bm90dGV4Ci1AeHJlZntBdXRvcmV2ZXJ0LCBnbG9iYWwtYXV0by1yZXZlcnQtbm9uLWZpbGUtYnVm ZmVyc30sIGZvciBkZXRhaWxzLgorQHhyZWZ7QXV0byBSZXZlcnRpbmcgdGhlIEJ1ZmZlciBNZW51 LCBnbG9iYWwtYXV0by1yZXZlcnQtbm9uLWZpbGUtYnVmZmVyc30sIGZvciBkZXRhaWxzLgogQGVu ZCBpZm5vdHRleAogCiBAbm9kZSBJbmRpcmVjdCBCdWZmZXJzCmRpZmYgLS1naXQgYS9kb2MvZW1h Y3MvZW1hY3MteHRyYS50ZXhpIGIvZG9jL2VtYWNzL2VtYWNzLXh0cmEudGV4aQppbmRleCBkY2Q4 ZmFlMWI2Li5iNjNmMjIyNjIxIDEwMDY0NAotLS0gYS9kb2MvZW1hY3MvZW1hY3MteHRyYS50ZXhp CisrKyBiL2RvYy9lbWFjcy9lbWFjcy14dHJhLnRleGkKQEAgLTExMSw2ICsxMTEsOCBAQCBJbnRy b2R1Y3Rpb24KIEByYWlzZXNlY3Rpb25zCiBAaW5jbHVkZSBwaWN0dXJlLXh0cmEudGV4aQogCitA bm9kZSBOb24tZmlsZSBidWZmZXJzCitAc2VjdGlvbiBBdXRvIFJldmVydGluZyBOb24tRmlsZSBC dWZmZXJzCiBAaW5jbHVkZSBhcmV2ZXJ0LXh0cmEudGV4aQogCiBAaW5jbHVkZSBkaXJlZC14dHJh LnRleGkKZGlmZiAtLWdpdCBhL2RvYy9lbWFjcy9lbWFjcy50ZXhpIGIvZG9jL2VtYWNzL2VtYWNz LnRleGkKaW5kZXggNThlYzM3MzAyOS4uMGZjMzRkZDYzZCAxMDA2NDQKLS0tIGEvZG9jL2VtYWNz L2VtYWNzLnRleGkKKysrIGIvZG9jL2VtYWNzL2VtYWNzLnRleGkKQEAgLTQ0Myw5ICs0NDMsNyBA QCBUb3AKICogVmlzaXRpbmc6OiAgICAgICAgICAgIFZpc2l0aW5nIGEgZmlsZSBwcmVwYXJlcyBF bWFjcyB0byBlZGl0IHRoZSBmaWxlLgogKiBTYXZpbmc6OiAgICAgICAgICAgICAgU2F2aW5nIG1h a2VzIHlvdXIgY2hhbmdlcyBwZXJtYW5lbnQuCiAqIFJldmVydGluZzo6ICAgICAgICAgICBSZXZl cnRpbmcgY2FuY2VscyBhbGwgdGhlIGNoYW5nZXMgbm90IHNhdmVkLgotQGlmbm90dGV4Ci0qIEF1 dG9yZXZlcnQ6OiAgICAgICAgICBBdXRvIFJldmVydGluZyBub24tZmlsZSBidWZmZXJzLgotQGVu ZCBpZm5vdHRleAorKiBBdXRvLXJldmVydDo6ICAgICAgICAgS2VlcGluZyBidWZmZXJzIGF1dG9t YXRpY2FsbHkgdXAtdG8tZGF0ZS4KICogQXV0byBTYXZlOjogICAgICAgICAgIEF1dG8gU2F2ZSBw ZXJpb2RpY2FsbHkgcHJvdGVjdHMgYWdhaW5zdCBsb3NzIG9mIGRhdGEuCiAqIEZpbGUgQWxpYXNl czo6ICAgICAgICBIYW5kbGluZyBtdWx0aXBsZSBuYW1lcyBmb3Igb25lIGZpbGUuCiAqIERpcmVj dG9yaWVzOjogICAgICAgICBDcmVhdGluZywgZGVsZXRpbmcsIGFuZCBsaXN0aW5nIGZpbGUgZGly ZWN0b3JpZXMuCmRpZmYgLS1naXQgYS9kb2MvZW1hY3MvZmlsZXMudGV4aSBiL2RvYy9lbWFjcy9m aWxlcy50ZXhpCmluZGV4IDk5MGI4ZjE2NzkuLjEwNGNiMjRlODIgMTAwNjQ0Ci0tLSBhL2RvYy9l bWFjcy9maWxlcy50ZXhpCisrKyBiL2RvYy9lbWFjcy9maWxlcy50ZXhpCkBAIC0yNSw5ICsyNSw3 IEBAIEZpbGVzCiAqIFZpc2l0aW5nOjogICAgICAgICAgICBWaXNpdGluZyBhIGZpbGUgcHJlcGFy ZXMgRW1hY3MgdG8gZWRpdCB0aGUgZmlsZS4KICogU2F2aW5nOjogICAgICAgICAgICAgIFNhdmlu ZyBtYWtlcyB5b3VyIGNoYW5nZXMgcGVybWFuZW50LgogKiBSZXZlcnRpbmc6OiAgICAgICAgICAg UmV2ZXJ0aW5nIGNhbmNlbHMgYWxsIHRoZSBjaGFuZ2VzIG5vdCBzYXZlZC4KLUBpZm5vdHRleAot KiBBdXRvcmV2ZXJ0OjogICAgICAgICAgQXV0byBSZXZlcnRpbmcgbm9uLWZpbGUgYnVmZmVycy4K LUBlbmQgaWZub3R0ZXgKKyogQXV0by1yZXZlcnQ6OiAgICAgICAgIEtlZXBpbmcgYnVmZmVycyBh dXRvbWF0aWNhbGx5IHVwLXRvLWRhdGUuCiAqIEF1dG8gU2F2ZTo6ICAgICAgICAgICBBdXRvIFNh dmUgcGVyaW9kaWNhbGx5IHByb3RlY3RzIGFnYWluc3QgbG9zcyBvZiBkYXRhLgogKiBGaWxlIEFs aWFzZXM6OiAgICAgICAgSGFuZGxpbmcgbXVsdGlwbGUgbmFtZXMgZm9yIG9uZSBmaWxlLgogKiBE aXJlY3Rvcmllczo6ICAgICAgICAgQ3JlYXRpbmcsIGRlbGV0aW5nLCBhbmQgbGlzdGluZyBmaWxl IGRpcmVjdG9yaWVzLgpAQCAtOTU1LDYgKzk1MywxMSBAQCBSZXZlcnRpbmcKIGlzIG5vdCBtb2Rp ZmllZC4gIChJZiB5b3UgaGF2ZSBlZGl0ZWQgdGhlIHRleHQsIGl0IHdvdWxkIGJlIHdyb25nIHRv CiBkaXNjYXJkIHlvdXIgY2hhbmdlcy4pCiAKKyAgWW91IGNhbiBhbHNvIHRlbGwgRW1hY3MgdG8g cmV2ZXJ0IGJ1ZmZlcnMgYXV0b21hdGljYWxseSB3aGVuIHRoZWlyCit2aXNpdGVkIGZpbGVzIGNo YW5nZSBvbiBkaXNrOyBAcHhyZWZ7QXV0by1yZXZlcnR9LgorCitAbm9kZSBBdXRvLXJldmVydAor QHNlY3Rpb24gQXV0by1yZXZlcnQ6IEtlZXBpbmcgYnVmZmVycyBhdXRvbWF0aWNhbGx5IHVwLXRv LWRhdGUKIEBjaW5kZXggR2xvYmFsIEF1dG8gUmV2ZXJ0IG1vZGUKIEBjaW5kZXggbW9kZSwgR2xv YmFsIEF1dG8gUmV2ZXJ0CiBAY2luZGV4IEF1dG8gUmV2ZXJ0IG1vZGUKQEAgLTk2MiwyMSArOTY1 LDM4IEBAIFJldmVydGluZwogQGZpbmRleCBnbG9iYWwtYXV0by1yZXZlcnQtbW9kZQogQGZpbmRl eCBhdXRvLXJldmVydC1tb2RlCiBAZmluZGV4IGF1dG8tcmV2ZXJ0LXRhaWwtbW9kZQotQHZpbmRl eCBhdXRvLXJldmVydC1pbnRlcnZhbAotQHZpbmRleCBhdXRvLXJldmVydC1yZW1vdGUtZmlsZXMK KworICBBIGJ1ZmZlciBjYW4gZ2V0IG91dCBvZiBzeW5jIHdpdGggcmVzcGVjdCB0byBpdHMgdmlz aXRlZCBmaWxlIG9uCitkaXNrIGlmIHRoYXQgZmlsZSBpcyBjaGFuZ2VkIGJ5IGFub3RoZXIgcHJv Z3JhbS4gIFRvIGtlZXAgaXQgdXAgdG8KK2RhdGUsIHlvdSBjYW4gZW5hYmxlIEF1dG8tcmV2ZXJ0 IG1vZGUgYnkgdHlwaW5nIEBrYmR7TS14IGF1dG8tcmV2ZXJ0LW1vZGV9LgorVGhpcyBhdXRvbWF0 aWNhbGx5IHJldmVydHMgdGhlIGJ1ZmZlciB3aGVuIGl0cyB2aXNpdGVkIGZpbGUgY2hhbmdlcyBv bgorZGlzay4gIFRvIGRvIHRoZSBzYW1lIGZvciBhbGwgZmlsZSBidWZmZXJzLCB0eXBlCitAa2Jk e00teCBnbG9iYWwtYXV0by1yZXZlcnQtbW9kZX0gdG8gZW5hYmxlIEdsb2JhbCBBdXRvLVJldmVy dCBtb2RlLgorCisgIEF1dG8tcmV2ZXJ0IHdpbGwgbm90IHJldmVydCBhIGJ1ZmZlciBpZiBpdCBo YXMgdW5zYXZlZCBjaGFuZ2VzLCBvciBpZgoraXRzIGZpbGUgb24gZGlzayBpcyBkZWxldGVkIG9y IHJlbmFtZWQuCisKKyAgT25lIHVzZSBvZiBBdXRvLVJldmVydCBtb2RlIGlzIHRvIGBgdGFpbCcn IGEgZmlsZSBzdWNoIGFzIGEgc3lzdGVtCitsb2csIHNvIHRoYXQgY2hhbmdlcyBtYWRlIHRvIHRo YXQgZmlsZSBieSBvdGhlciBwcm9ncmFtcyBhcmUKK2NvbnRpbnVvdXNseSBkaXNwbGF5ZWQuICBU byBkbyB0aGlzLCBqdXN0IG1vdmUgdGhlIHBvaW50IHRvIHRoZSBlbmQgb2YKK3RoZSBidWZmZXIs IGFuZCBpdCB3aWxsIHN0YXkgdGhlcmUgYXMgdGhlIGZpbGUgY29udGVudHMgY2hhbmdlLgorSG93 ZXZlciwgaWYgeW91IGFyZSBzdXJlIHRoYXQgdGhlIGZpbGUgd2lsbCBvbmx5IGNoYW5nZSBieSBn cm93aW5nIGF0Cit0aGUgZW5kLCB1c2UgQXV0by1SZXZlcnQgVGFpbCBtb2RlIGluc3RlYWQKKyhA Y29kZXthdXRvLXJldmVydC10YWlsLW1vZGV9KS4gIEl0IGlzIG1vcmUgZWZmaWNpZW50IGZvciB0 aGlzLgorQXV0by1SZXZlcnQgVGFpbCBtb2RlIGFsc28gd29ya3MgZm9yIHJlbW90ZSBmaWxlcy4K KwogQHZpbmRleCBhdXRvLXJldmVydC12ZXJib3NlCi0gIFlvdSBjYW4gYWxzbyB0ZWxsIEVtYWNz IHRvIHJldmVydCBidWZmZXJzIHBlcmlvZGljYWxseS4gIFRvIGRvIHRoaXMKLWZvciBhIHNwZWNp ZmljIGJ1ZmZlciwgZW5hYmxlIHRoZSBtaW5vciBtb2RlIEF1dG8tUmV2ZXJ0IG1vZGUgYnkKLXR5 cGluZyBAa2Jke00teCBhdXRvLXJldmVydC1tb2RlfS4gIFRoaXMgYXV0b21hdGljYWxseSByZXZl cnRzIHRoZQotY3VycmVudCBidWZmZXIgd2hlbiBpdHMgdmlzaXRlZCBmaWxlIGNoYW5nZXMgb24g ZGlzay4gIFRvIGRvIHRoZSBzYW1lCi1mb3IgYWxsIGZpbGUgYnVmZmVycywgdHlwZSBAa2Jke00t eCBnbG9iYWwtYXV0by1yZXZlcnQtbW9kZX0gdG8gZW5hYmxlCi1HbG9iYWwgQXV0by1SZXZlcnQg bW9kZS4gIFRoZXNlIG1pbm9yIG1vZGVzIGRvIG5vdCBjaGVjayBvciByZXZlcnQKLXJlbW90ZSBm aWxlcywgYmVjYXVzZSB0aGF0IGlzIHVzdWFsbHkgdG9vIHNsb3cuICBUaGlzIGJlaGF2aW9yIGNh biBiZQotY2hhbmdlZCBieSBzZXR0aW5nIHRoZSB2YXJpYWJsZSBAY29kZXthdXRvLXJldmVydC1y ZW1vdGUtZmlsZXN9IHRvCi1ub24tQGNvZGV7bmlsfS4KKyAgV2hlbiBhIGJ1ZmZlciBpcyBhdXRv LXJldmVydGVkLCBhIG1lc3NhZ2UgaXMgZ2VuZXJhdGVkLiAgVGhpcyBjYW4gYmUKK3N1cHByZXNz ZWQgYnkgc2V0dGluZyBAY29kZXthdXRvLXJldmVydC12ZXJib3NlfSB0byBAY29kZXtuaWx9Lgor CitAdmluZGV4IGF1dG8tcmV2ZXJ0LXJlbW90ZS1maWxlcworICBUaGVzZSBtaW5vciBtb2RlcyBk byBub3QgY2hlY2sgb3IgcmV2ZXJ0IHJlbW90ZSBmaWxlcywgYmVjYXVzZSB0aGF0IGlzCit1c3Vh bGx5IHRvbyBzbG93LiAgVGhpcyBiZWhhdmlvciBjYW4gYmUgY2hhbmdlZCBieSBzZXR0aW5nIHRo ZQordmFyaWFibGUgQGNvZGV7YXV0by1yZXZlcnQtcmVtb3RlLWZpbGVzfSB0byBub24tQGNvZGV7 bmlsfS4KIAogQGNpbmRleCBmaWxlIG5vdGlmaWNhdGlvbnMKIEB2aW5kZXggYXV0by1yZXZlcnQt dXNlLW5vdGlmeQorQHZpbmRleCBhdXRvLXJldmVydC1pbnRlcnZhbAogICBCeSBkZWZhdWx0LCBB dXRvLVJldmVydCBtb2RlIHdvcmtzIHVzaW5nIEBkZm57ZmlsZSBub3RpZmljYXRpb25zfSwKIHdo ZXJlYnkgY2hhbmdlcyBpbiB0aGUgZmlsZXN5c3RlbSBhcmUgcmVwb3J0ZWQgdG8gRW1hY3MgYnkg dGhlIE9TLgogWW91IGNhbiBkaXNhYmxlIHVzZSBvZiBmaWxlIG5vdGlmaWNhdGlvbnMgYnkgY3Vz dG9taXppbmcgdGhlIHZhcmlhYmxlCkBAIC0xMDAyLDE4ICsxMDIyLDYgQEAgUmV2ZXJ0aW5nCiBA Y29kZXthdXRvLXJldmVydC1ub3RpZnktZXhjbHVkZS1kaXItcmVnZXhwfSB0byBtYXRjaCBmaWxl cyB0aGF0CiBzaG91bGQgYmUgZXhjbHVkZWQgZnJvbSB1c2luZyBub3RpZmljYXRpb24uCiAKLSAg T25lIHVzZSBvZiBBdXRvLVJldmVydCBtb2RlIGlzIHRvIGBgdGFpbCcnIGEgZmlsZSBzdWNoIGFz IGEgc3lzdGVtCi1sb2csIHNvIHRoYXQgY2hhbmdlcyBtYWRlIHRvIHRoYXQgZmlsZSBieSBvdGhl ciBwcm9ncmFtcyBhcmUKLWNvbnRpbnVvdXNseSBkaXNwbGF5ZWQuICBUbyBkbyB0aGlzLCBqdXN0 IG1vdmUgdGhlIHBvaW50IHRvIHRoZSBlbmQgb2YKLXRoZSBidWZmZXIsIGFuZCBpdCB3aWxsIHN0 YXkgdGhlcmUgYXMgdGhlIGZpbGUgY29udGVudHMgY2hhbmdlLgotSG93ZXZlciwgaWYgeW91IGFy ZSBzdXJlIHRoYXQgdGhlIGZpbGUgd2lsbCBvbmx5IGNoYW5nZSBieSBncm93aW5nIGF0Ci10aGUg ZW5kLCB1c2UgQXV0by1SZXZlcnQgVGFpbCBtb2RlIGluc3RlYWQKLShAY29kZXthdXRvLXJldmVy dC10YWlsLW1vZGV9KS4gIEl0IGlzIG1vcmUgZWZmaWNpZW50IGZvciB0aGlzLgotQXV0by1SZXZl cnQgVGFpbCBtb2RlIHdvcmtzIGFsc28gZm9yIHJlbW90ZSBmaWxlcy4KLQotICBXaGVuIGEgYnVm ZmVyIGlzIGF1dG8tcmV2ZXJ0ZWQsIGEgbWVzc2FnZSBpcyBnZW5lcmF0ZWQuICBUaGlzIGNhbiBi ZQotc3VwcHJlc3NlZCBieSBzZXR0aW5nIEBjb2Rle2F1dG8tcmV2ZXJ0LXZlcmJvc2V9IHRvIEBj b2Rle25pbH0uCi0KICAgSW4gRGlyZWQgYnVmZmVycyAoQHB4cmVme0RpcmVkfSksIEF1dG8tUmV2 ZXJ0IG1vZGUgcmVmcmVzaGVzIHRoZQogYnVmZmVyIHdoZW4gYSBmaWxlIGlzIGNyZWF0ZWQgb3Ig ZGVsZXRlZCBpbiB0aGUgYnVmZmVyJ3MgZGlyZWN0b3J5LgogCi0tIAoyLjIwLjEKCg== --=-7YSQNPnVKx7RjTbkayMQ-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2019 12:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155679951431233 (code B ref 35418); Thu, 02 May 2019 12:19:01 +0000 Received: (at 35418) by debbugs.gnu.org; 2 May 2019 12:18:34 +0000 Received: from localhost ([127.0.0.1]:45749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMAfa-00087h-HX for submit@debbugs.gnu.org; Thu, 02 May 2019 08:18:34 -0400 Received: from mout.gmx.net ([212.227.15.15]:57419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMAfZ-00087U-8G for 35418@debbugs.gnu.org; Thu, 02 May 2019 08:18:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556799503; bh=QKIaK3mmE0AWNN443m154UCuyFi4z9OGppsVSIuqlOo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=LQK0ZFYY/eyw1J+en/a8jnS2Ap6xc8hpyfTZWWUc/JGi/7z3Umztx8RyEXYbzXuI+ gzIeaD7ueC+U6n5hYneo5bTxVUa33HDGJpoqS4k7I7B6JgvLEAG2wi1KqcMpkeQhrx m+aaiXY5ORMvKRYPRrMHMvMH7amwHu0Of2udZLMQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.60.150]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MUILK-1hCilg3ETy-00Qzzm; Thu, 02 May 2019 14:18:22 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> Date: Thu, 02 May 2019 14:18:20 +0200 In-Reply-To: <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Wed, 01 May 2019 21:41:38 +0200") Message-ID: <87woj9nj77.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:xTMS7SObXplZniqAs5YSy/0ZfjjkY7txiRoM+nknjq+s7kyAybU G84lxRWhDHdYz2VKRjb/yg6eQROplqBaSOP5Q8evCjBfWh96vs6y6wY5g1CCNLa9KKBxvHl XPzFtBw7NmDOrWNPMqqQpMryIcC+pbasSD/YURU66ajG+15M9OJUyUe8J61wQVev44fFegz QNzL8/eLECD7xdhHaVoYQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:BjYBibdYVDs=:97tUF2Iv2kqs21qVU86R1b UeHSWqVdJJbZTN8lU8eTBuLq1ISoN/Rx+XJZRXtQRbQ5wkVCGK7SI57cgqI8R09fW2HU88tHN pRuElvNlgkGzrkRqE8q4N7YajV1Z7rBgKP3kA95mvNNOm7f5ZfmgPoQKrpo+CvK3RWyQ3NKMm MYr/x5/I7EjjpfLwvw5GJlXu6Lg7QjF50FzpsTwsoyNEQuBAU8hpQ+9dkQVFPRXsiupR0ZQGx xIzMW5ahCEi57RBLOkldsbmIsVUmunv88rhbJvPrZSP++DS5w/7p25bRGez7qmLRHGWvg3gLj CASoNvnyHB9L6IAztq9Br3y1t1gtHFdkiI51e3Zzs4yahjCWFKC2pXvofIMh2Q+DU5WCP4m84 E5uTEatndSvCFAz7sbmgj2uZy/ShTxhehvw4Ffx6FULGd9gvS33JNPsniClL4ICGbCxeYRidO uVSr7dIMz+btJGQrPg1llo/msXF197H9lEFm0hC3LVohJmk6Co8GHhHRg9PIJllx8olGFqBiC aAbbxfubg1JGZSnNvpT1CCfEiJhR4D/LPnU+Ch+XLM2vdvAUrRf6JPJp88xVHHo8uS/CQxE56 XWZPw28V7Z5LrEWdujKwRdK35H4Dk0Wi0sqdH7vvitu3uchGVHtLIT3oxiCZAEhtjzE0HX6l/ DEpHubvGTviX2HZuToQmbHixFQJX66IT8zzOXvuAtYIOZJBau1ucRWi0xdYdAOCJ+ybrfOTZF /mdiiSkHrZZvO4aORNDxEOkSJ2FQycR600YQ+DUXpaNgyUiEzZ3M6fkOME6G3DddNws4l53xs Gmm9L5M3XpcqwhueAcHGb4fniWB2gjOk/uVe66wNchSaO9/JrYGlP+lpQ/GQFMe87w8jVVZkG UQGxDx+NexUKs+P+6jxG3Cnqt4j4wRacb3iBhmQ5R4uzAntjGilrR2OfBxZ9rMgpTsX4ax749 e6hhJYJEaGg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, In general it looks OK. Just some few comments: > --- a/doc/emacs/emacs.texi > +++ b/doc/emacs/emacs.texi > @@ -443,9 +443,7 @@ Top > * Visiting:: Visiting a file prepares Emacs to edit the file. > * Saving:: Saving makes your changes permanent. > * Reverting:: Reverting cancels all the changes not saved. > -@ifnottex > -* Autorevert:: Auto Reverting non-file buffers. > -@end ifnottex > +* Auto-revert:: Keeping buffers automatically up-to-date. > * Auto Save:: Auto Save periodically protects against loss of = data. Please call the node "Auto Revert", like the following "Auto Save". > +date, you can enable Auto-revert mode by typing @kbd{M-x auto-revert-mod= e}. This shall be "Auto Revert mode" (or "Auto Revert Mode", don't know). > +the end, use Auto-Revert Tail mode instead dito, "Auto Revert Tail mode". I know that it was called already like this. But it looks more consistent to me, when changing it. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2019 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Zhang Haijun Cc: "35418@debbugs.gnu.org" <35418@debbugs.gnu.org> Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155679990631835 (code B ref 35418); Thu, 02 May 2019 12:26:02 +0000 Received: (at 35418) by debbugs.gnu.org; 2 May 2019 12:25:06 +0000 Received: from localhost ([127.0.0.1]:45762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMAlu-0008HP-9Y for submit@debbugs.gnu.org; Thu, 02 May 2019 08:25:06 -0400 Received: from mout.gmx.net ([212.227.17.22]:45471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMAls-0008Gl-6Q for 35418@debbugs.gnu.org; Thu, 02 May 2019 08:25:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556799896; bh=zXc+MLxpdfMXt3BBtu+ypudwyvxvz7GNh+YWMhJlJPE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=fpvVWZYGEMMJQ4eaiJsQcvINo+EEBYO/z+h1JY2PuMg+kjWvcR8H3KsEDZzolYojY b/3Qx5v3dqguBfF1aYihhG6rNh8PF7nxc96Hn+sRp7sP9t+4prcPFbl9Oz+ibvOXIB GGo97P3fys48Faxe6/0e9uhFgWyamBqaXoM/Yz74= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.60.150]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LhSfM-1h01Em2oWu-00mard; Thu, 02 May 2019 14:24:56 +0200 From: Michael Albinus References: <87tvegt1ip.fsf@gmx.de> Date: Thu, 02 May 2019 14:24:55 +0200 In-Reply-To: (Zhang Haijun's message of "Wed, 1 May 2019 02:17:32 +0000") Message-ID: <87sgtxniw8.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:C/d/3J/NglRNQui0+JYodO5fuwbDjBditKroFgjXPRubzwJNdfz x86tC+1FD0UXi9ZP7+FLgOyIIo6/Ln9XaB46R4nLRPIBy0yq6sYXNOgI/v/RKW8xXq9vFPz GS1O5lBvRgfo3bIcp277TZMf0qfPFiJUfB/uN7s8qax5xx3lF/Wi8Hn/vJ2ZCpt/CDmTAoC xxzsH2q1DFo9sKmSzFwNg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:9mMeVprCd8M=:55tfQ9zvuwV9TbhkIpZOV+ mgClcla7U3zxy1+M9YmnLY3UVO5inZ2fH90BG4y6Cxr4BYF9Ic81Geo0RJcOoJejrnoCVJtJ/ rOBaCXncXRsnE5tZCWg0jXNxPTUP5gOMFY0TIoj0rHZSnkMEwlgBqEend2wzJC6TFV3mFZzE0 OV5M9A0C88x2zzAteSF8nRDrM20os2hVNDxdIdUzjkVxFfFaNZRdD1k+rk972Y24MF64JSZVe BDfsSj0ISPCmYIlefE8PGum5C4h9FKFcnDvQCziG+eBG2rnF5ZDfnNyi9iUc4xMgFhiMFvMrf IRQnTp1qmkmrSWJSNPG3c+m9OrTzdFPltbU6ZZspQBAGvJdtEwYxZ7zgM/fxCIvkwxSe8NUh4 iY491NUl4sHYvahUmucyDo8jURgusmKbZDs8d9ixRbLBib5YHquWsQP9je4fA36TBBby69Hen YKpvrDMvl68ww8aN4vs+rQF7AbOJ+Svd401Ir8LdnqJlD9+GGNmIBZVHlVFTRGkliZ2Kse/5U yeyx4KMkYx7VoKIv16cCjNR0UY+U6U45tFdJruTPnLz7AHxhTf0uQ5QCnS9rn2OqiySlXvTv5 9mO3o7ETLGF6iGi2R5Go+/Uo/mOl6VoQMw5MXrp7W2Y1HDeGJFcPVvmWOzjSOZD4jip5o64ZP rL+8lZ2kwlYkUW07YX98hWhPoVRzdxe7b/LwTOH7LuEyZaA341NHeucb8bbXLImWwBv21pr/+ +PhAF35V/nsfgyXfaH240YQIqJGUDrhQP4RL0rIfuI58dA1BU8JyvYPJmrTREE5jn2ehArM27 q/U2nQFaAfotjRD9KLMwowF9p92N1zKG9HM4sTKEZ1pJ1QNFrBYr6+VkWtrlYYM0zNd00omn4 TdMO2Z/A+nuwBw3ftW5Bw6PER4ozHiZy9xFyE/2bfN9yNr+4KEeHHlrdNXuypqWHMBlrzUzqF bjLxZyuWxsw== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Zhang Haijun writes: >> I don't understand the patch. Symbol kqueue11 does not exist, so do you= mean >> >> + func dir > Yes. > >> >> And have you applied the tests in filenotify-tests.el? Do all of them p= ass? >> >> Best regards, Michael. > > $ make -C test autorevert-tests > ELC lisp/autorevert-tests.elc > GEN lisp/autorevert-tests.log > Running 5 tests (2019-05-01 10:06:38+0800) > Reverting buffer `auto-revert-testqe4qed'. > passed 1/5 auto-revert-test00-auto-revert-mode > (Shell command succeeded with no output) > Test auto-revert-test01-auto-revert-several-files backtrace: > signal(ert-test-failed (((should (string-match "another text" (buffe So this shows you cannot change filenotify.el as proposed. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2019 12:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Zhang Haijun Cc: "35418@debbugs.gnu.org" <35418@debbugs.gnu.org> Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155680011032119 (code B ref 35418); Thu, 02 May 2019 12:29:02 +0000 Received: (at 35418) by debbugs.gnu.org; 2 May 2019 12:28:30 +0000 Received: from localhost ([127.0.0.1]:45768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMApB-0008Lz-Sf for submit@debbugs.gnu.org; Thu, 02 May 2019 08:28:30 -0400 Received: from mout.gmx.net ([212.227.17.21]:38983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMAp9-0008Ll-Eb for 35418@debbugs.gnu.org; Thu, 02 May 2019 08:28:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556800100; bh=ZK/BtLCmVKU+CZHbQp1eFlrXK0pbFd7Yq7hdkDjLbwM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=PNPgi9dRBMzFKy/qveROcjDxM1gJ2f1NvkXZUEQyoB6/XvXCtulqujoj3qkudap7x ho1qcrjikJFwUENom7OFHO63va8iwYWHaN/uKCad9fivw7e0zHpZLmqS9jTZi7y17t hR9pQJJXsyNkRrZ6CtP8wfQWZ+HOqTqhgOk5s/Ls= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.60.150]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N17UQ-1gbC013DJq-012X2r; Thu, 02 May 2019 14:28:19 +0200 From: Michael Albinus References: <87tvegt1ip.fsf@gmx.de> Date: Thu, 02 May 2019 14:28:18 +0200 In-Reply-To: (Zhang Haijun's message of "Wed, 1 May 2019 02:59:47 +0000") Message-ID: <87o94lniql.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:QJPVLFEXHq+iNJAx3L92qXfMTuqz3erkT0PxHteZgyRX8y5R/QZ Osq9dIDxawyzd8Vtv0sqn9+GdqW87RePlMO87hPI7riuTq5PvR4ySp8BCQiJ27gnYxDIJzS XIxDwijowwqF6BCQu0nU7hXz6TKZJxWG1RctdTebg6in+ariIoqL4GaII8woop/fqWSgbJX 2NEY+WKByLKL2kugSGLqw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:EvWwq4BYb1k=:UPJpNu4Dr+bOkfZsmRvjpd +YtPeRQ5Y5IdESdSwIyfA4ZvsfajAE38Q5LAeeQryosQjQjeKw3XBzMDhu+IyttDMljs/jKYe ipM9upY3c1027oMG572tNgV3E8ICkI7+13KelOZHFe78xCHcZWnyiITSfLiBys9IvOJXf5Byx ANDiLPKTJyNryVcs4OFLNKiFgEYApe290FVLHKIIpAdl0cZcGDyvGGAvCUJgVpR5QKLqp+s32 syFHlVpxJFHcD3fq5huPHxY+y9g41/NvqTxCp2euT9k80PoEDxSl1B8eWVl0OIljYZ/nCTFst t0lGDTe2H6Swm0YcFgEQEUflm5PQnaEgWJJ1ktWIGz6uYjeb24ILTfgNhx1rAYjLww5lvI/xj 42gaLjgbNpoMpuw2k/WNImeaC4gwnLeG8JKr3OOnN3Sl7cgtoHQpaVHNdvN5a20tXC3SZVo+I o97Cs2woyaE2SmZsDzVQqBU0R1NoMGyflKdHpKUPthXhUaelOBo8gHlA1QTXeV1PbjqDHhqeq agf7U9ItpZkAv/+nBs9QGWTaIfagBbaEpJ5fpfMjtle0pvzAmISQ1TkQjNZx5q0hhV3HUNL9B XiD0t6UPkisRPnllsQP/4h+cBCcq+L0059d128tPCd3CZaKP0qFrsltowfkcVw4RsuxVcrfy0 pi1FyF9+SRWSYkMYja1X9CoGeoELMo4T3FSXTyva9IBwAsI7JjwAdcqjAJSGDPqAAOni0KiWW gPWBSPloPvSIxzmF16Yj/0+V910OstN+SK6rnq1tfCN7YrnjUcx07HDtP5DAJbNfBsDBL+Uot PSZRyoq+FaKnf/9h3joHmORFjwxC7pEJavesEhW6sYPvvMva1aJB/qsed9N/lL3gcAxrQtfbO JYciT6hxGCrJjKu2zMvoi6ismZQOGgf+Ljo0slmHK8C/3aymIEb9ts7cfwIQJtTUzBKrLqvH6 SvTeFPpPBvw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Zhang Haijun writes: > I haven=E2=80=99t run the test before. autorevert-tests run successfuly on my FreeBSD 10.2 system, with unmodified Emacs sources from master. > It seems that directory watching > doesn=E2=80=99t work for file content only change. But it works for many > common use cases while file watching doesn=E2=80=99t work. We apply directory watching wherever possible. kqueue has its restrictions here. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2019 12:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Zhang Haijun Cc: "35418@debbugs.gnu.org" <35418@debbugs.gnu.org> Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155680022232378 (code B ref 35418); Thu, 02 May 2019 12:31:01 +0000 Received: (at 35418) by debbugs.gnu.org; 2 May 2019 12:30:22 +0000 Received: from localhost ([127.0.0.1]:45772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMAr0-0008QA-9g for submit@debbugs.gnu.org; Thu, 02 May 2019 08:30:22 -0400 Received: from mout.gmx.net ([212.227.17.21]:35079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMAqx-0008Pw-My for 35418@debbugs.gnu.org; Thu, 02 May 2019 08:30:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556800211; bh=0cQuAbFqEBs+cDDSMabca5oTWAHtVBleedIWRtwa/xY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=YSpxTVmE+fLcSFkurxl178gcorTxU/Y0yzp48bsBqquHU213fJpqGq49zHwvRIQ/v 3/SkQM+w9yIc8747aku+WT8Etia2eCEU4BzUgaUkH+r2W90VzLkV43+eiFbKP7dQht 0O8dr0h/Gq8pXhjVtNFS5mx5WE+6V6dv3lh4aV38= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.60.150]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N3bSt-1gdewy293L-010bFB; Thu, 02 May 2019 14:30:11 +0200 From: Michael Albinus References: <87tvegt1ip.fsf@gmx.de> Date: Thu, 02 May 2019 14:30:10 +0200 In-Reply-To: (Zhang Haijun's message of "Wed, 1 May 2019 03:10:20 +0000") Message-ID: <87k1f9ninh.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:TRu3axz1ErtHtlqigVzlnT8HRRR4+MQOKbmf8XNSoG/P3HyrxFT o/0W2e6Q1KuKN2X91C5e8Qnzj9eHvobwU8fmZDV26WvhIt4PmHWRhFYpUNWd/ZopsI9THYO C5Yi9jc1O5Wwiwwr6nkTmvxDDctT3Mp3D3GgTJ7dLl1rHBKvB+y3PSW9Aivk+EvKsjdjRUC tVUa8Dc+Cao4Vmz8EnTHg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:lAv/Z5IQVro=:4GEeZDHHijLrZ3MY5G4D17 0oWD7QxaY+lhPDVjDqYAOIT8tgCNOiuyhPZlo+8/JYD3PSeVkEp9q5J0/89Gxj1V1VgrMOEny 7OqUBUzrn7yuKWDgUTGmI72ktUb4xxMmAKCPaOf9+auJe5BzNTdIsjiZg9ZxPUNmJjmWwVLmw PcQitNa2TOiyYNBt0w4/HgTZAoWZ0WsTdUOz+lIyhi195JWvS0QzYthhylJ4RpajAMb0RcxKO o1lcEISkS+3uy7E1+ZKsSANXiKCiRgywyb5+6ZixNr2ZbVgqedMAdLqMrqNc8CvxwE/cmPFYc QiTW7Gj+IQG4GSV8oAYggrCQIzkTOLBFhxqawTUVmg1Bw83aDvlyuejMQSXv9ISRhAg130/03 2ThNiPsZ4Rfh8kiaZ1vUBqIITT7ulw04V8SVIPkJjVh0m1bAk8Qq8i93WqDSb8M8MaT38TJaN yyDPrMMQGXVbFHVnQ1dhQRtArqLCc6WpXURkUPsTn5n9puWqkbc6fLSrmYmhF72U7ORLtfVYj Edyf7vMfOCZXWrZ6LFSr6eiGAgROv8IGo7MEGmyc+916nkwSx9WtR9kWtsDPlcax9ZSQiP07D 4bjs2/OSpgMXQrkMCJ9UmRCX/nSUt8WHCw+0f7ZNvCKtcQchTxpEeOqgYTo24yhuFRVXNYzkl SrsrFYP3H9X6F8PHf35FPE0yN0wY7HV687Z+I53h85AP4YQ/ECeEn5UlRsTj6gJzvS/3+FuiS ptH8x2VylTHN0xQkx/YtREYLqmCdlin4vV4DnFPQXHF8K6C7mLl7Au/DogHIE4wjHMBofkBwU HsLehFsWXzsmebQg7CRmGjoWGBfMimEH4Ks+UUYOgU4bg5KRiFec9byb+z9DwDja/iWRgNe22 DHafGkxFrfWcjVqkQZzS1qNtFIhQc21H/6ZnWF89WdSlpzzosVmThlHo4F7vD8qvOqCc27t4r 17SD0Hp6FjA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Zhang Haijun writes: > If both file watching and directory watching are used for one file, it > will works for all use cases. This doesn't fit into filenotify.el. Which watch descriptor do you expect from `file-notify-add-watch'? Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2019 12:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15568016091902 (code B ref 35418); Thu, 02 May 2019 12:54:01 +0000 Received: (at 35418) by debbugs.gnu.org; 2 May 2019 12:53:29 +0000 Received: from localhost ([127.0.0.1]:45792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMBDM-0000Ub-9I for submit@debbugs.gnu.org; Thu, 02 May 2019 08:53:28 -0400 Received: from mail178c50.megamailservers.eu ([91.136.10.188]:49718 helo=mail70c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMBDJ-0000UR-NW for 35418@debbugs.gnu.org; Thu, 02 May 2019 08:53:27 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556801602; bh=UTWkx8eIxuqx8aId53NHJ6nHPjX8vFrHz0imZ5L5y6g=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=YUGlSpII5ySsduWlLs5geiyirrEyM5ZGe5cRwAwRlV9/5itinpg8CELSIzoVaoxjd pPoJXj3qoggzrsT2gXFjpqp9zwvjVBPERd7hGYfkez2jlVPhzMHIF/Wb05MuXKRvkJ XKfFO5OZBFtyEA2pxq8ewKwE75GNwgFOB+WwWZbg= Feedback-ID: mattiase@acm.or Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x42CrKav012951; Thu, 2 May 2019 12:53:22 +0000 Message-ID: From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Date: Thu, 02 May 2019 14:53:20 +0200 In-Reply-To: <87woj9nj77.fsf@gmx.de> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> Content-Type: multipart/mixed; boundary="=-WSm7MIa3z4TkYXASFDgY" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 X-CTCH-RefID: str=0001.0A0B0209.5CCAE842.0075, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=K68M4ReI c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=N54-gffFAAAA:8 a=RbBSJA93d3LBXLfFLN8A:9 a=QEXdDO2ut3YA:10 a=5BDTXNcLyv-6_XvxyWcA:9 a=-c1PCwqnbgamA6sB:21 a=fvHcvrkOutp4PlBc:21 a=B2y7HmGcmWMA:10 a=6l0D2HzqY3Epnrm8mE3f:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-WSm7MIa3z4TkYXASFDgY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit tor 2019-05-02 klockan 14:18 +0200 skrev Michael Albinus: > Mattias Engdegård writes: > > Please call the node "Auto Revert", like the following "Auto Save". Done. > > +date, you can enable Auto-revert mode by typing @kbd{M-x auto- > > revert-mode}. > > This shall be "Auto Revert mode" (or "Auto Revert Mode", don't know). Done (I went with the former). > > +the end, use Auto-Revert Tail mode instead > > dito, "Auto Revert Tail mode". Done. > I know that it was called already like this. But it looks more > consistent to me, when changing it. Of course. New patch attached. --=-WSm7MIa3z4TkYXASFDgY Content-Disposition: attachment; filename="0001-Reorganise-auto-revert-nodes-in-the-manual.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Reorganise-auto-revert-nodes-in-the-manual.patch"; charset="UTF-8" RnJvbSBhZDI3ZTg1N2JiN2E2MjNlMTM3NDA3YzQ1YjY1NzQ0YjNmYzM1Y2E1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWF0dGlhcz0yMEVuZ2RlZz1DMz1BNXJkPz0g PG1hdHRpYXNlQGFjbS5vcmc+CkRhdGU6IFR1ZSwgMzAgQXByIDIwMTkgMjI6MzU6NTYgKzAyMDAK U3ViamVjdDogW1BBVENIXSBSZW9yZ2FuaXNlIChhdXRvLSlyZXZlcnQgbm9kZXMgaW4gdGhlIG1h bnVhbAoKVGhlIGFtb3VudCBvZiBpbmZvcm1hdGlvbiBvbiBhdXRvLXJldmVydCBoYXMgZ3Jvd24g dG8gZGVzZXJ2ZSBhCnNlY3Rpb24gb2YgaXRzIG93biAoYnVnIzM1NDE4KS4KCiogZG9jL2VtYWNz L2ZpbGVzLnRleGk6CiogZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50ZXhpOgoqIGRvYy9lbWFjcy9i dWZmZXJzLnRleGk6CiogZG9jL2VtYWNzL2VtYWNzLnRleGk6CiogZG9jL2VtYWNzL2VtYWNzLXh0 cmEudGV4aToKQWRkIG5vZGUgJ0F1dG8tcmV2ZXJ0JyBhbmQgbW92ZSBnZW5lcmFsIGluZm9ybWF0 aW9uIG9uIHRoYXQgdG9waWMgdGhlcmUuClNvcnQgcGFyYWdyYXBocyBpbiB0aGF0IG5vZGUgaW4g YSByb3VnaCBsZWFzdC10by1tb3N0IHNwZWNpZmljIG9yZGVyLgpJbmNsdWRlIHRoZSBvbGQgJ0F1 dG9yZXZlcnQnIG5vZGUgaW50byB0aGF0IG5vZGUgd2hlbiBidWlsZGluZyB0aGUKb24tbGluZSBt YW51YWwuCi0tLQogZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50ZXhpIHwgIDMgKy0KIGRvYy9lbWFj cy9idWZmZXJzLnRleGkgICAgICB8ICA0ICstLQogZG9jL2VtYWNzL2VtYWNzLXh0cmEudGV4aSAg IHwgIDQgKystCiBkb2MvZW1hY3MvZW1hY3MudGV4aSAgICAgICAgfCAgNCArLS0KIGRvYy9lbWFj cy9maWxlcy50ZXhpICAgICAgICB8IDY3ICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0t LS0tLS0KIDUgZmlsZXMgY2hhbmdlZCwgNDUgaW5zZXJ0aW9ucygrKSwgMzcgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50ZXhpIGIvZG9jL2VtYWNzL2Fy ZXZlcnQteHRyYS50ZXhpCmluZGV4IGNkN2MxZmY4OTUuLjhjYzViMDUzYjUgMTAwNjQ0Ci0tLSBh L2RvYy9lbWFjcy9hcmV2ZXJ0LXh0cmEudGV4aQorKysgYi9kb2MvZW1hY3MvYXJldmVydC14dHJh LnRleGkKQEAgLTQsOCArNCw3IEBACiBAYwogQGMgVGhpcyBmaWxlIGlzIGluY2x1ZGVkIGVpdGhl ciBpbiBlbWFjcy14dHJhLnRleGkgKHdoZW4gcHJvZHVjaW5nIHRoZQogQGMgcHJpbnRlZCB2ZXJz aW9uKSBvciBpbiB0aGUgbWFpbiBFbWFjcyBtYW51YWwgKGZvciB0aGUgb24tbGluZSB2ZXJzaW9u KS4KLUBub2RlIEF1dG9yZXZlcnQKLUBzZWN0aW9uIEF1dG8gUmV2ZXJ0aW5nIE5vbi1GaWxlIEJ1 ZmZlcnMKK0BjIFRoZSBpbmNsdWRpbmcgZmlsZSBtdXN0IHByb3ZpZGUgaXRzIG93biBAbm9kZSBh bmQgQHNlY3Rpb24gbGluZXMuCiAKIEdsb2JhbCBBdXRvIFJldmVydCBNb2RlIG5vcm1hbGx5IG9u bHkgcmV2ZXJ0cyBmaWxlIGJ1ZmZlcnMuICBUaGVyZSBhcmUKIHR3byB3YXlzIHRvIGF1dG8tcmV2 ZXJ0IGNlcnRhaW4gbm9uLWZpbGUgYnVmZmVyczogYnkgZW5hYmxpbmcgQXV0bwpkaWZmIC0tZ2l0 IGEvZG9jL2VtYWNzL2J1ZmZlcnMudGV4aSBiL2RvYy9lbWFjcy9idWZmZXJzLnRleGkKaW5kZXgg MjdmY2I3MzY5YS4uMTRhMGEwMWNhOCAxMDA2NDQKLS0tIGEvZG9jL2VtYWNzL2J1ZmZlcnMudGV4 aQorKysgYi9kb2MvZW1hY3MvYnVmZmVycy50ZXhpCkBAIC01NjgsMTAgKzU2OCwxMCBAQCBTZXZl cmFsIEJ1ZmZlcnMKIEF1dG8gUmV2ZXJ0IG1vZGUgYXBwbGllcyB0byB0aGUgQGZpbGV7KkJ1ZmZl ciBMaXN0Kn0gYnVmZmVyIG9ubHkgaWYKIEBjb2Rle2dsb2JhbC1hdXRvLXJldmVydC1ub24tZmls ZS1idWZmZXJzfSBpcyBub24tQGNvZGV7bmlsfS4KIEBpZnRleAotQGluZm9yZWZ7QXV0b3JldmVy dCwsIGVtYWNzLXh0cmF9LCBmb3IgZGV0YWlscy4KK0BpbmZvcmVme0F1dG8gUmV2ZXJ0aW5nIHRo ZSBCdWZmZXIgTWVudSwsIGVtYWNzLXh0cmF9LCBmb3IgZGV0YWlscy4KIEBlbmQgaWZ0ZXgKIEBp Zm5vdHRleAotQHhyZWZ7QXV0b3JldmVydCwgZ2xvYmFsLWF1dG8tcmV2ZXJ0LW5vbi1maWxlLWJ1 ZmZlcnN9LCBmb3IgZGV0YWlscy4KK0B4cmVme0F1dG8gUmV2ZXJ0aW5nIHRoZSBCdWZmZXIgTWVu dSwgZ2xvYmFsLWF1dG8tcmV2ZXJ0LW5vbi1maWxlLWJ1ZmZlcnN9LCBmb3IgZGV0YWlscy4KIEBl bmQgaWZub3R0ZXgKIAogQG5vZGUgSW5kaXJlY3QgQnVmZmVycwpkaWZmIC0tZ2l0IGEvZG9jL2Vt YWNzL2VtYWNzLXh0cmEudGV4aSBiL2RvYy9lbWFjcy9lbWFjcy14dHJhLnRleGkKaW5kZXggZGNk OGZhZTFiNi4uODRiYmRiODRkMCAxMDA2NDQKLS0tIGEvZG9jL2VtYWNzL2VtYWNzLXh0cmEudGV4 aQorKysgYi9kb2MvZW1hY3MvZW1hY3MteHRyYS50ZXhpCkBAIC01OSw3ICs1OSw3IEBAIFRvcAog KiBQaWN0dXJlIE1vZGU6OiAgICAgICAgRWRpdGluZyBwaWN0dXJlcyBtYWRlIHVwIG9mIGNoYXJh Y3RlcnMgdXNpbmcKICAgICAgICAgICAgICAgICAgICAgICAgICB0aGUgcXVhcnRlci1wbGFuZSBz Y3JlZW4gbW9kZWwuCiAKLSogQXV0b3JldmVydDo6ICAgICAgICAgIEF1dG8gUmV2ZXJ0aW5nIG5v bi1maWxlIGJ1ZmZlcnMuCisqIE5vbi1GaWxlIEJ1ZmZlcnM6OiAgICBBdXRvIFJldmVydGluZyBu b24tZmlsZSBidWZmZXJzLgogKiBTdWJkaXIgU3dpdGNoZXM6OiAgICAgU3ViZGlyZWN0b3J5IHN3 aXRjaGVzIGluIERpcmVkLgogKiBBZHZhbmNlZCBDYWxlbmRhci9EaWFyeSBVc2FnZTo6IEFkdmFu Y2VkIENhbGVuZGFyL0RpYXJ5IGN1c3RvbWl6YXRpb24uCiAqIEVtZXJnZTo6ICAgICAgICAgICAg ICBBIGNvbnZlbmllbnQgd2F5IG9mIG1lcmdpbmcgdHdvIHZlcnNpb25zIG9mIGEgcHJvZ3JhbS4K QEAgLTExMSw2ICsxMTEsOCBAQCBJbnRyb2R1Y3Rpb24KIEByYWlzZXNlY3Rpb25zCiBAaW5jbHVk ZSBwaWN0dXJlLXh0cmEudGV4aQogCitAbm9kZSBOb24tRmlsZSBCdWZmZXJzCitAc2VjdGlvbiBB dXRvIFJldmVydGluZyBOb24tRmlsZSBCdWZmZXJzCiBAaW5jbHVkZSBhcmV2ZXJ0LXh0cmEudGV4 aQogCiBAaW5jbHVkZSBkaXJlZC14dHJhLnRleGkKZGlmZiAtLWdpdCBhL2RvYy9lbWFjcy9lbWFj cy50ZXhpIGIvZG9jL2VtYWNzL2VtYWNzLnRleGkKaW5kZXggNThlYzM3MzAyOS4uYTM0Y2VmMjIx ZSAxMDA2NDQKLS0tIGEvZG9jL2VtYWNzL2VtYWNzLnRleGkKKysrIGIvZG9jL2VtYWNzL2VtYWNz LnRleGkKQEAgLTQ0Myw5ICs0NDMsNyBAQCBUb3AKICogVmlzaXRpbmc6OiAgICAgICAgICAgIFZp c2l0aW5nIGEgZmlsZSBwcmVwYXJlcyBFbWFjcyB0byBlZGl0IHRoZSBmaWxlLgogKiBTYXZpbmc6 OiAgICAgICAgICAgICAgU2F2aW5nIG1ha2VzIHlvdXIgY2hhbmdlcyBwZXJtYW5lbnQuCiAqIFJl dmVydGluZzo6ICAgICAgICAgICBSZXZlcnRpbmcgY2FuY2VscyBhbGwgdGhlIGNoYW5nZXMgbm90 IHNhdmVkLgotQGlmbm90dGV4Ci0qIEF1dG9yZXZlcnQ6OiAgICAgICAgICBBdXRvIFJldmVydGlu ZyBub24tZmlsZSBidWZmZXJzLgotQGVuZCBpZm5vdHRleAorKiBBdXRvIFJldmVydDo6ICAgICAg ICAgS2VlcGluZyBidWZmZXJzIGF1dG9tYXRpY2FsbHkgdXAtdG8tZGF0ZS4KICogQXV0byBTYXZl OjogICAgICAgICAgIEF1dG8gU2F2ZSBwZXJpb2RpY2FsbHkgcHJvdGVjdHMgYWdhaW5zdCBsb3Nz IG9mIGRhdGEuCiAqIEZpbGUgQWxpYXNlczo6ICAgICAgICBIYW5kbGluZyBtdWx0aXBsZSBuYW1l cyBmb3Igb25lIGZpbGUuCiAqIERpcmVjdG9yaWVzOjogICAgICAgICBDcmVhdGluZywgZGVsZXRp bmcsIGFuZCBsaXN0aW5nIGZpbGUgZGlyZWN0b3JpZXMuCmRpZmYgLS1naXQgYS9kb2MvZW1hY3Mv ZmlsZXMudGV4aSBiL2RvYy9lbWFjcy9maWxlcy50ZXhpCmluZGV4IDk5MGI4ZjE2NzkuLjc2YmU0 YzExMmYgMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9maWxlcy50ZXhpCisrKyBiL2RvYy9lbWFjcy9m aWxlcy50ZXhpCkBAIC0yNSw5ICsyNSw3IEBAIEZpbGVzCiAqIFZpc2l0aW5nOjogICAgICAgICAg ICBWaXNpdGluZyBhIGZpbGUgcHJlcGFyZXMgRW1hY3MgdG8gZWRpdCB0aGUgZmlsZS4KICogU2F2 aW5nOjogICAgICAgICAgICAgIFNhdmluZyBtYWtlcyB5b3VyIGNoYW5nZXMgcGVybWFuZW50Lgog KiBSZXZlcnRpbmc6OiAgICAgICAgICAgUmV2ZXJ0aW5nIGNhbmNlbHMgYWxsIHRoZSBjaGFuZ2Vz IG5vdCBzYXZlZC4KLUBpZm5vdHRleAotKiBBdXRvcmV2ZXJ0OjogICAgICAgICAgQXV0byBSZXZl cnRpbmcgbm9uLWZpbGUgYnVmZmVycy4KLUBlbmQgaWZub3R0ZXgKKyogQXV0byBSZXZlcnQ6OiAg ICAgICAgIEtlZXBpbmcgYnVmZmVycyBhdXRvbWF0aWNhbGx5IHVwLXRvLWRhdGUuCiAqIEF1dG8g U2F2ZTo6ICAgICAgICAgICBBdXRvIFNhdmUgcGVyaW9kaWNhbGx5IHByb3RlY3RzIGFnYWluc3Qg bG9zcyBvZiBkYXRhLgogKiBGaWxlIEFsaWFzZXM6OiAgICAgICAgSGFuZGxpbmcgbXVsdGlwbGUg bmFtZXMgZm9yIG9uZSBmaWxlLgogKiBEaXJlY3Rvcmllczo6ICAgICAgICAgQ3JlYXRpbmcsIGRl bGV0aW5nLCBhbmQgbGlzdGluZyBmaWxlIGRpcmVjdG9yaWVzLgpAQCAtOTU1LDYgKzk1MywxMSBA QCBSZXZlcnRpbmcKIGlzIG5vdCBtb2RpZmllZC4gIChJZiB5b3UgaGF2ZSBlZGl0ZWQgdGhlIHRl eHQsIGl0IHdvdWxkIGJlIHdyb25nIHRvCiBkaXNjYXJkIHlvdXIgY2hhbmdlcy4pCiAKKyAgWW91 IGNhbiBhbHNvIHRlbGwgRW1hY3MgdG8gcmV2ZXJ0IGJ1ZmZlcnMgYXV0b21hdGljYWxseSB3aGVu IHRoZWlyCit2aXNpdGVkIGZpbGVzIGNoYW5nZSBvbiBkaXNrOyBAcHhyZWZ7QXV0byBSZXZlcnR9 LgorCitAbm9kZSBBdXRvIFJldmVydAorQHNlY3Rpb24gQXV0byBSZXZlcnQ6IEtlZXBpbmcgYnVm ZmVycyBhdXRvbWF0aWNhbGx5IHVwLXRvLWRhdGUKIEBjaW5kZXggR2xvYmFsIEF1dG8gUmV2ZXJ0 IG1vZGUKIEBjaW5kZXggbW9kZSwgR2xvYmFsIEF1dG8gUmV2ZXJ0CiBAY2luZGV4IEF1dG8gUmV2 ZXJ0IG1vZGUKQEAgLTk2MiwyMiArOTY1LDM5IEBAIFJldmVydGluZwogQGZpbmRleCBnbG9iYWwt YXV0by1yZXZlcnQtbW9kZQogQGZpbmRleCBhdXRvLXJldmVydC1tb2RlCiBAZmluZGV4IGF1dG8t cmV2ZXJ0LXRhaWwtbW9kZQotQHZpbmRleCBhdXRvLXJldmVydC1pbnRlcnZhbAotQHZpbmRleCBh dXRvLXJldmVydC1yZW1vdGUtZmlsZXMKKworICBBIGJ1ZmZlciBjYW4gZ2V0IG91dCBvZiBzeW5j IHdpdGggcmVzcGVjdCB0byBpdHMgdmlzaXRlZCBmaWxlIG9uCitkaXNrIGlmIHRoYXQgZmlsZSBp cyBjaGFuZ2VkIGJ5IGFub3RoZXIgcHJvZ3JhbS4gIFRvIGtlZXAgaXQgdXAgdG8KK2RhdGUsIHlv dSBjYW4gZW5hYmxlIEF1dG8gUmV2ZXJ0IG1vZGUgYnkgdHlwaW5nIEBrYmR7TS14IGF1dG8tcmV2 ZXJ0LW1vZGV9LgorVGhpcyBhdXRvbWF0aWNhbGx5IHJldmVydHMgdGhlIGJ1ZmZlciB3aGVuIGl0 cyB2aXNpdGVkIGZpbGUgY2hhbmdlcyBvbgorZGlzay4gIFRvIGRvIHRoZSBzYW1lIGZvciBhbGwg ZmlsZSBidWZmZXJzLCB0eXBlCitAa2Jke00teCBnbG9iYWwtYXV0by1yZXZlcnQtbW9kZX0gdG8g ZW5hYmxlIEdsb2JhbCBBdXRvIFJldmVydCBtb2RlLgorCisgIEF1dG8gUmV2ZXJ0IHdpbGwgbm90 IHJldmVydCBhIGJ1ZmZlciBpZiBpdCBoYXMgdW5zYXZlZCBjaGFuZ2VzLCBvciBpZgoraXRzIGZp bGUgb24gZGlzayBpcyBkZWxldGVkIG9yIHJlbmFtZWQuCisKKyAgT25lIHVzZSBvZiBBdXRvIFJl dmVydCBtb2RlIGlzIHRvIGBgdGFpbCcnIGEgZmlsZSBzdWNoIGFzIGEgc3lzdGVtCitsb2csIHNv IHRoYXQgY2hhbmdlcyBtYWRlIHRvIHRoYXQgZmlsZSBieSBvdGhlciBwcm9ncmFtcyBhcmUKK2Nv bnRpbnVvdXNseSBkaXNwbGF5ZWQuICBUbyBkbyB0aGlzLCBqdXN0IG1vdmUgdGhlIHBvaW50IHRv IHRoZSBlbmQgb2YKK3RoZSBidWZmZXIsIGFuZCBpdCB3aWxsIHN0YXkgdGhlcmUgYXMgdGhlIGZp bGUgY29udGVudHMgY2hhbmdlLgorSG93ZXZlciwgaWYgeW91IGFyZSBzdXJlIHRoYXQgdGhlIGZp bGUgd2lsbCBvbmx5IGNoYW5nZSBieSBncm93aW5nIGF0Cit0aGUgZW5kLCB1c2UgQXV0byBSZXZl cnQgVGFpbCBtb2RlIGluc3RlYWQKKyhAY29kZXthdXRvLXJldmVydC10YWlsLW1vZGV9KS4gIEl0 IGlzIG1vcmUgZWZmaWNpZW50IGZvciB0aGlzLgorQXV0byBSZXZlcnQgVGFpbCBtb2RlIGFsc28g d29ya3MgZm9yIHJlbW90ZSBmaWxlcy4KKwogQHZpbmRleCBhdXRvLXJldmVydC12ZXJib3NlCi0g IFlvdSBjYW4gYWxzbyB0ZWxsIEVtYWNzIHRvIHJldmVydCBidWZmZXJzIHBlcmlvZGljYWxseS4g IFRvIGRvIHRoaXMKLWZvciBhIHNwZWNpZmljIGJ1ZmZlciwgZW5hYmxlIHRoZSBtaW5vciBtb2Rl IEF1dG8tUmV2ZXJ0IG1vZGUgYnkKLXR5cGluZyBAa2Jke00teCBhdXRvLXJldmVydC1tb2RlfS4g IFRoaXMgYXV0b21hdGljYWxseSByZXZlcnRzIHRoZQotY3VycmVudCBidWZmZXIgd2hlbiBpdHMg dmlzaXRlZCBmaWxlIGNoYW5nZXMgb24gZGlzay4gIFRvIGRvIHRoZSBzYW1lCi1mb3IgYWxsIGZp bGUgYnVmZmVycywgdHlwZSBAa2Jke00teCBnbG9iYWwtYXV0by1yZXZlcnQtbW9kZX0gdG8gZW5h YmxlCi1HbG9iYWwgQXV0by1SZXZlcnQgbW9kZS4gIFRoZXNlIG1pbm9yIG1vZGVzIGRvIG5vdCBj aGVjayBvciByZXZlcnQKLXJlbW90ZSBmaWxlcywgYmVjYXVzZSB0aGF0IGlzIHVzdWFsbHkgdG9v IHNsb3cuICBUaGlzIGJlaGF2aW9yIGNhbiBiZQotY2hhbmdlZCBieSBzZXR0aW5nIHRoZSB2YXJp YWJsZSBAY29kZXthdXRvLXJldmVydC1yZW1vdGUtZmlsZXN9IHRvCi1ub24tQGNvZGV7bmlsfS4K KyAgV2hlbiBhIGJ1ZmZlciBpcyBhdXRvLXJldmVydGVkLCBhIG1lc3NhZ2UgaXMgZ2VuZXJhdGVk LiAgVGhpcyBjYW4gYmUKK3N1cHByZXNzZWQgYnkgc2V0dGluZyBAY29kZXthdXRvLXJldmVydC12 ZXJib3NlfSB0byBAY29kZXtuaWx9LgorCitAdmluZGV4IGF1dG8tcmV2ZXJ0LXJlbW90ZS1maWxl cworICBUaGVzZSBtaW5vciBtb2RlcyBkbyBub3QgY2hlY2sgb3IgcmV2ZXJ0IHJlbW90ZSBmaWxl cywgYmVjYXVzZSB0aGF0IGlzCit1c3VhbGx5IHRvbyBzbG93LiAgVGhpcyBiZWhhdmlvciBjYW4g YmUgY2hhbmdlZCBieSBzZXR0aW5nIHRoZQordmFyaWFibGUgQGNvZGV7YXV0by1yZXZlcnQtcmVt b3RlLWZpbGVzfSB0byBub24tQGNvZGV7bmlsfS4KIAogQGNpbmRleCBmaWxlIG5vdGlmaWNhdGlv bnMKIEB2aW5kZXggYXV0by1yZXZlcnQtdXNlLW5vdGlmeQotICBCeSBkZWZhdWx0LCBBdXRvLVJl dmVydCBtb2RlIHdvcmtzIHVzaW5nIEBkZm57ZmlsZSBub3RpZmljYXRpb25zfSwKK0B2aW5kZXgg YXV0by1yZXZlcnQtaW50ZXJ2YWwKKyAgQnkgZGVmYXVsdCwgQXV0byBSZXZlcnQgbW9kZSB3b3Jr cyB1c2luZyBAZGZue2ZpbGUgbm90aWZpY2F0aW9uc30sCiB3aGVyZWJ5IGNoYW5nZXMgaW4gdGhl IGZpbGVzeXN0ZW0gYXJlIHJlcG9ydGVkIHRvIEVtYWNzIGJ5IHRoZSBPUy4KIFlvdSBjYW4gZGlz YWJsZSB1c2Ugb2YgZmlsZSBub3RpZmljYXRpb25zIGJ5IGN1c3RvbWl6aW5nIHRoZSB2YXJpYWJs ZQogQGNvZGV7YXV0by1yZXZlcnQtdXNlLW5vdGlmeX0gdG8gYSBAY29kZXtuaWx9IHZhbHVlLCB0 aGVuIEVtYWNzIHdpbGwKQEAgLTk5MCw3ICsxMDEwLDcgQEAgUmV2ZXJ0aW5nCiAKIEB2aW5kZXgg YXV0by1yZXZlcnQtYXZvaWQtcG9sbGluZwogQHZpbmRleCBhdXRvLXJldmVydC1ub3RpZnktZXhj bHVkZS1kaXItcmVnZXhwCi0gIEJ5IGRlZmF1bHQsIEF1dG8tUmV2ZXJ0IG1vZGUgd2lsbCBwb2xs IGZpbGVzIGZvciBjaGFuZ2VzCisgIEJ5IGRlZmF1bHQsIEF1dG8gUmV2ZXJ0IG1vZGUgd2lsbCBw b2xsIGZpbGVzIGZvciBjaGFuZ2VzCiBwZXJpb2RpY2FsbHkgZXZlbiB3aGVuIGZpbGUgbm90aWZp Y2F0aW9ucyBhcmUgdXNlZC4gIFN1Y2ggcG9sbGluZyBpcwogdXN1YWxseSB1bm5lY2Vzc2FyeSwg YW5kIHR1cm5pbmcgaXQgb2ZmIG1heSBzYXZlIHBvd2VyIGJ5IHJlbHlpbmcgb24KIG5vdGlmaWNh dGlvbnMgb25seS4gIFRvIGRvIHNvLCBzZXQgdGhlIHZhcmlhYmxlCkBAIC0xMDAyLDE5ICsxMDIy LDcgQEAgUmV2ZXJ0aW5nCiBAY29kZXthdXRvLXJldmVydC1ub3RpZnktZXhjbHVkZS1kaXItcmVn ZXhwfSB0byBtYXRjaCBmaWxlcyB0aGF0CiBzaG91bGQgYmUgZXhjbHVkZWQgZnJvbSB1c2luZyBu b3RpZmljYXRpb24uCiAKLSAgT25lIHVzZSBvZiBBdXRvLVJldmVydCBtb2RlIGlzIHRvIGBgdGFp bCcnIGEgZmlsZSBzdWNoIGFzIGEgc3lzdGVtCi1sb2csIHNvIHRoYXQgY2hhbmdlcyBtYWRlIHRv IHRoYXQgZmlsZSBieSBvdGhlciBwcm9ncmFtcyBhcmUKLWNvbnRpbnVvdXNseSBkaXNwbGF5ZWQu ICBUbyBkbyB0aGlzLCBqdXN0IG1vdmUgdGhlIHBvaW50IHRvIHRoZSBlbmQgb2YKLXRoZSBidWZm ZXIsIGFuZCBpdCB3aWxsIHN0YXkgdGhlcmUgYXMgdGhlIGZpbGUgY29udGVudHMgY2hhbmdlLgot SG93ZXZlciwgaWYgeW91IGFyZSBzdXJlIHRoYXQgdGhlIGZpbGUgd2lsbCBvbmx5IGNoYW5nZSBi eSBncm93aW5nIGF0Ci10aGUgZW5kLCB1c2UgQXV0by1SZXZlcnQgVGFpbCBtb2RlIGluc3RlYWQK LShAY29kZXthdXRvLXJldmVydC10YWlsLW1vZGV9KS4gIEl0IGlzIG1vcmUgZWZmaWNpZW50IGZv ciB0aGlzLgotQXV0by1SZXZlcnQgVGFpbCBtb2RlIHdvcmtzIGFsc28gZm9yIHJlbW90ZSBmaWxl cy4KLQotICBXaGVuIGEgYnVmZmVyIGlzIGF1dG8tcmV2ZXJ0ZWQsIGEgbWVzc2FnZSBpcyBnZW5l cmF0ZWQuICBUaGlzIGNhbiBiZQotc3VwcHJlc3NlZCBieSBzZXR0aW5nIEBjb2Rle2F1dG8tcmV2 ZXJ0LXZlcmJvc2V9IHRvIEBjb2Rle25pbH0uCi0KLSAgSW4gRGlyZWQgYnVmZmVycyAoQHB4cmVm e0RpcmVkfSksIEF1dG8tUmV2ZXJ0IG1vZGUgcmVmcmVzaGVzIHRoZQorICBJbiBEaXJlZCBidWZm ZXJzIChAcHhyZWZ7RGlyZWR9KSwgQXV0byBSZXZlcnQgbW9kZSByZWZyZXNoZXMgdGhlCiBidWZm ZXIgd2hlbiBhIGZpbGUgaXMgY3JlYXRlZCBvciBkZWxldGVkIGluIHRoZSBidWZmZXIncyBkaXJl Y3RvcnkuCiAKICAgQHhyZWZ7VkMgVW5kb30sIGZvciBjb21tYW5kcyB0byByZXZlcnQgdG8gZWFy bGllciB2ZXJzaW9ucyBvZiBmaWxlcwpAQCAtMTAyMiw2ICsxMDMwLDcgQEAgUmV2ZXJ0aW5nCiBw ZWN1bGlhcml0aWVzIHdoZW4gdmlzaXRpbmcgZmlsZXMgdW5kZXIgdmVyc2lvbiBjb250cm9sLgog CiBAaWZub3R0ZXgKK0BjIFRoZSBub2RlIHRleHQgY29udGludWVzIGhlcmUuCiBAaW5jbHVkZSBh cmV2ZXJ0LXh0cmEudGV4aQogQGVuZCBpZm5vdHRleAogCi0tIAoyLjIwLjEKCg== --=-WSm7MIa3z4TkYXASFDgY-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2019 13:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15568021522795 (code B ref 35418); Thu, 02 May 2019 13:03:02 +0000 Received: (at 35418) by debbugs.gnu.org; 2 May 2019 13:02:32 +0000 Received: from localhost ([127.0.0.1]:45809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMBM8-0000j1-0Z for submit@debbugs.gnu.org; Thu, 02 May 2019 09:02:32 -0400 Received: from mout.gmx.net ([212.227.15.15]:55083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMBM5-0000im-Dg for 35418@debbugs.gnu.org; Thu, 02 May 2019 09:02:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556802136; bh=EtASohZLO2tkA1/9QB/9jffezjMHImjZJ0aMU3sEvuA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Zm+9fL1vt4K9mA1hhRd6C3K5zWxTUdo24b3lf02sCcBfhyEQbd/tmctEO45ktbbbB CH/KTRmuGwZNAkxCIqrweJcfwmWGVQh4JJ26Xthdhz7yksH7CvF47nD7vUGooYdpLs e7fl+IhxFs9ie6vvHavfZgP1hPZwhMKPetygtgOo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.60.150]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mg6e4-1gpbkc0TLK-00hceF; Thu, 02 May 2019 15:02:16 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> Date: Thu, 02 May 2019 15:02:13 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Thu, 02 May 2019 14:53:20 +0200") Message-ID: <87d0l1nh62.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:5U+JhHMJOEdRdSSrnVoVSlgAVdhUtB5f42K/RDXUF4Aczkb/20C jyRNcpqr8EiRhcfEXQEqn22xwb/5q37ssjAWJ7UTG7+zDmtUGXroFyY/oGsn81/i8CtKjj2 5ijT2/Ir/Ezpw3BCeJYuYfzYMbyQMEWZmx5tCb/JfWb+Je3h/1aEnYVfo3yiytKbu+8DPka E4p3xTEHZ83Pu0NsAWXhg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:QVwOj4Ul6OI=:PEHX9l9Kp29WVmfa1grLD8 ooozT8SgxeHVgK52m3pBQBc6622p/NCglauZ5me6So+GOlMoPFT5wCy6fjUK3KDQ03aY8IipU t9vEHWQukp0MMAMUhpSJU0133XEUXFmBVFG2QS3iR5yjTOMtxB4LdLtdtzhVNHg33NlwZ2lfj oypZnGwvMe//iWB+Gn0mpd3akM+3mCzdQV77ZtSy43Z2Rm8VTJnNnyLVsc0mqkyDE46jxZEtR WOnKxYZr6UtOzbydPVEuEKgc8kWY8Yf+lZUVfpxQO6SHz2uMeL9auf88YYWVJUGAU5St5QqlD VPIZlniEFuUv3iqKZ4ycA7Y3J0c/28xhtGJ0vzVEKTjpBNvZAyLW2CK7wIB/g2FP0pzU+kFQE Nsa4H5iNBtwLwuYkPWWg4uWw8OcnVY3unuUesmjmvAyQt+4+R/ZynNbbNbDSK70vxSTMJj99v u70W+tgeUCqkX9Z5VRKxeioAfF4YcHfG2+NOvJ87ieV5S7IRY2GdN9HK6pGahNazVAwgqXrkY sn41WQssR95LJZ45c7500FanwKlnr3NfDe3YSGkIZValPOWNOCh6ZMhws3CKYlXs5JToSke2l Jm0W1eIZP8E3l7HWRwcsRa3iFwANkzthJhbEIsA2IO4jx5tpeYcOWAfxx295G0eScNsR0FSzN eEbXUaMYCZQL1AeeuSGNQGp7iRkaV9utqMYWkYRttn/GZiO7BbxNAZnDihyd+7sGIvb8avY85 UiEAd8rsoMnRVTzoDYP9azEVwAeS2KHBA7zhav+0AaQWh7uHURdoN+x3KULhSOsVfpWzxCmi4 FF7CH0dMHZznpMoh1zMJGT/0BOXK04AZPFb2WpiH/6IjotHUvxozOn75r8iOQODFOFpKrPqrP 1UZFWN+uJzBWUcJSdShW3jOJd4pbz4yxwvDRJyJGMTQhEHbw+/K7ixYBedf+0BuKRtOJbqhkQ 6D4Z7uULKUQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, > Of course. New patch attached. Thanks, LGTM. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Zhang Haijun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2019 13:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: "35418@debbugs.gnu.org" <35418@debbugs.gnu.org> Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15568035064779 (code B ref 35418); Thu, 02 May 2019 13:26:02 +0000 Received: (at 35418) by debbugs.gnu.org; 2 May 2019 13:25:06 +0000 Received: from localhost ([127.0.0.1]:45819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMBhy-0001F1-2h for submit@debbugs.gnu.org; Thu, 02 May 2019 09:25:06 -0400 Received: from mail-oln040092253038.outbound.protection.outlook.com ([40.92.253.38]:15680 helo=APC01-SG2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMBht-0001EV-Uy for 35418@debbugs.gnu.org; Thu, 02 May 2019 09:25:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jkr4KnJ/X0GiJMAZc/4dB3yf0MRfgmEW3BSRqnTkErc=; b=k2Gk0rFWyIbsO2FleutDIEvzMMqKFaqoQOrf4uJiMn7LYhEhc5FDbPbQ0KcH+ZFsvhALrdAmS6RvU8b8rCCgbzmY0xpc5zBCTm6E5BARi6WAvLY1PH6EMGtd9Qt50A6zOh8Ink/2oI2L0qxPGaCfnZxYSFGO1cQ2qZWTYt8h8U+LEC7ivnlNM80sT+vUGjRb2CkI9WvpTG12eTQnTK/VN0AdVrw4zBG9DJQdz3qFPsWRXQXkzF8b+Mx7fXDfygH/ukmWugSFG38z5JaN8j6wKT2hjYD5UhJwniEffqtbUKJSoerZ6qqop2GGxYQdpF4c7c+h78F3E1cn2ujcrN65Qg== Received: from SG2APC01FT009.eop-APC01.prod.protection.outlook.com (10.152.250.58) by SG2APC01HT105.eop-APC01.prod.protection.outlook.com (10.152.251.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1835.13; Thu, 2 May 2019 13:24:53 +0000 Received: from PS1PR06MB2759.apcprd06.prod.outlook.com (10.152.250.55) by SG2APC01FT009.mail.protection.outlook.com (10.152.250.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.13 via Frontend Transport; Thu, 2 May 2019 13:24:53 +0000 Received: from PS1PR06MB2759.apcprd06.prod.outlook.com ([fe80::3c3b:be45:a6af:3d86]) by PS1PR06MB2759.apcprd06.prod.outlook.com ([fe80::3c3b:be45:a6af:3d86%4]) with mapi id 15.20.1835.018; Thu, 2 May 2019 13:24:53 +0000 From: Zhang Haijun Thread-Topic: bug#35418: [PATCH] Don't poll auto-revert files that use notification Thread-Index: AQHU/vCBHkd3xAerUE++lxqH2WqSdKZUSLp7gAFA1ICAAAxsAIAAAuwAgAIuztyAAA9AgA== Date: Thu, 2 May 2019 13:24:53 +0000 Message-ID: References: <87tvegt1ip.fsf@gmx.de> <87k1f9ninh.fsf@gmx.de> In-Reply-To: <87k1f9ninh.fsf@gmx.de> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:203:17::16) To PS1PR06MB2759.apcprd06.prod.outlook.com (2603:1096:803:46::13) x-incomingtopheadermarker: OriginalChecksum:89119EB5103CB6DB1B2C378C9E4D4C2960B921142E311EC0C780304C416EBC09; UpperCasedChecksum:22C28FF83E2FCDD6390B8C85076BB0A18663B656886E4D23885F4E16492E71A1; SizeAsReceived:7855; Count:50 x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: Apple Mail (2.3445.9.1) x-tmn: [ZY60r6+t3PKtDXXlhe0znA98+4T5E6Fu] x-microsoft-original-message-id: <64EA030C-A069-4736-BB25-5DBFDE3ECEF5@outlook.com> x-ms-publictraffictype: Email x-incomingheadercount: 50 x-eopattributedmessage: 0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(5050001)(7020095)(20181119110)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045); SRVR:SG2APC01HT105; x-ms-traffictypediagnostic: SG2APC01HT105: x-microsoft-antispam-message-info: mnGCseMHrjRNK3LvT0yUUakMkb0aH7eNTW76l1fa9gUxOtqai7M2+KsgXOhIUKI0mY1/lh78+n8FPxNsE8pybvCYWL6BD7OUA2XKvHH7Az4gAieV6yw6kkPmcko3IPc7euFmNu/GuGQvXw3vmMUZ8lFmm5Wdbe/1AXuSCOHi4JDe8SCHyek4EI6Uqq4vAnGl Content-Type: text/plain; charset="gb2312" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: ffbdd042-7ded-4c86-d0bd-08d6cf018fc1 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2019 13:24:53.5416 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2APC01HT105 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) SXQgc2VlbXMgdGhhdCBmaWxlIHdhdGNoaW5nIG9mIGtxdWV1ZSBpcyB1c2VsZXNzIGZvciBtZS4g VGhlIGRpcmVjdG9yeSB3YXRjaGluZyBzYXRpc2ZpZXMgYWxtb3N0IGFsbCBvZiBteSBuZWVkcy4g U28gSSB3aWxsIGNvbnRpbnVlIHRvIHVzZSBteSBtb2RpZmllZCB2ZXJzaW9uLg0KDQo+INTaIDIw MTnE6jXUwjLI1aOsz8LO5zg6MzCjrE1pY2hhZWwgQWxiaW51cyA8bWljaGFlbC5hbGJpbnVzQGdt eC5kZT4g0LS1wKO6DQo+IA0KPiBaaGFuZyBIYWlqdW4gPGNjc21pbGUyMDA4QG91dGxvb2suY29t PiB3cml0ZXM6DQo+IA0KPj4gSWYgYm90aCBmaWxlIHdhdGNoaW5nIGFuZCBkaXJlY3Rvcnkgd2F0 Y2hpbmcgYXJlIHVzZWQgZm9yIG9uZSBmaWxlLCBpdA0KPj4gd2lsbCB3b3JrcyBmb3IgYWxsIHVz ZSBjYXNlcy4NCj4gDQo+IFRoaXMgZG9lc24ndCBmaXQgaW50byBmaWxlbm90aWZ5LmVsLiBXaGlj aCB3YXRjaCBkZXNjcmlwdG9yIGRvIHlvdQ0KPiBleHBlY3QgZnJvbSBgZmlsZS1ub3RpZnktYWRk LXdhdGNoJz8NCj4gDQo+IEJlc3QgcmVnYXJkcywgTWljaGFlbC4NCg0K From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2019 12:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155688542317676 (code B ref 35418); Fri, 03 May 2019 12:11:02 +0000 Received: (at 35418) by debbugs.gnu.org; 3 May 2019 12:10:23 +0000 Received: from localhost ([127.0.0.1]:47935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMX1D-0004b1-0f for submit@debbugs.gnu.org; Fri, 03 May 2019 08:10:23 -0400 Received: from mail152c50.megamailservers.eu ([91.136.10.162]:56834 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMX1A-0004ar-Fp for 35418@debbugs.gnu.org; Fri, 03 May 2019 08:10:22 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556884854; bh=p6jk1W/bx6gkiV2HKLE5R5qXD5ogJw808IHgUdWcOSY=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=oz6i1aZ4OWGA2YRl1ZruzhJJuVcG3ioJ3rlqyhBF9As5euwdYDQfhe/HA4ptcrTQI eZ+06ihl8lVc7+9rHM/qt9X+x8D9JvI95okZqLfUdzj+tDm8WCUdicpGLczyBrooVg 0v2DsXCatIiSk5Tcq+llW2c7qVBXvORiKxjldI/E= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x43C0WsZ019829; Fri, 3 May 2019 12:00:54 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <87d0l1nh62.fsf@gmx.de> Date: Fri, 3 May 2019 14:00:32 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <87d0l1nh62.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0213.5CCC2D76.0083, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=NJj7BXyg c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=qxGVZfdET64R1moflzsA:9 a=CjuIK1q_8ugA:10 a=aMj-4VGTj6kA:10 a=QqFNrm0a_HcA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 2 maj 2019 kl. 15.02 skrev Michael Albinus : > > Thanks, LGTM. Thank you. I'll give Eli a chance to comment before committing. (I'm in no hurry; take your time.) From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2019 13:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155689113026750 (code B ref 35418); Fri, 03 May 2019 13:46:01 +0000 Received: (at 35418) by debbugs.gnu.org; 3 May 2019 13:45:30 +0000 Received: from localhost ([127.0.0.1]:48113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMYVG-0006xO-Do for submit@debbugs.gnu.org; Fri, 03 May 2019 09:45:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMYVF-0006xC-1K for 35418@debbugs.gnu.org; Fri, 03 May 2019 09:45:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMYV8-0002zu-M9; Fri, 03 May 2019 09:45:23 -0400 Received: from [176.228.60.248] (port=4987 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hMYV7-0003hD-S4; Fri, 03 May 2019 09:45:22 -0400 Date: Fri, 03 May 2019 16:44:52 +0300 Message-Id: <83r29fmz3f.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Thu, 02 May 2019 14:53:20 +0200) References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Cc: Eli Zaretskii , 35418@debbugs.gnu.org > Date: Thu, 02 May 2019 14:53:20 +0200 > > * doc/emacs/files.texi: > * doc/emacs/arevert-xtra.texi: > * doc/emacs/buffers.texi: > * doc/emacs/emacs.texi: > * doc/emacs/emacs-xtra.texi: > Add node 'Auto-revert' and move general information on that topic there. > Sort paragraphs in that node in a rough least-to-most specific order. > Include the old 'Autorevert' node into that node when building the > on-line manual. It is better to cite the node names in the log, unless doing that is completely impractical. > diff --git a/doc/emacs/arevert-xtra.texi b/doc/emacs/arevert-xtra.texi > index cd7c1ff895..8cc5b053b5 100644 > --- a/doc/emacs/arevert-xtra.texi > +++ b/doc/emacs/arevert-xtra.texi > @@ -4,8 +4,7 @@ > @c > @c This file is included either in emacs-xtra.texi (when producing the > @c printed version) or in the main Emacs manual (for the on-line version). > -@node Autorevert > -@section Auto Reverting Non-File Buffers > +@c The including file must provide its own @node and @section lines. So maybe we shouldn't remove the @node here? How about making it a subsection of "Auto Revert" instead? > +@vindex auto-revert-remote-files > + These minor modes do not check or revert remote files, because that is Which "these minor modes"? Such wording is only appropriate when it closely follows a list of modes, which is not the case here. I think it's better to enumerate the modes explicitly here. > +usually too slow. This behavior can be changed by setting the > +variable @code{auto-revert-remote-files} to non-@code{nil}. > > @cindex file notifications > @vindex auto-revert-use-notify > - By default, Auto-Revert mode works using @dfn{file notifications}, > +@vindex auto-revert-interval > + By default, Auto Revert mode works using @dfn{file notifications}, > whereby changes in the filesystem are reported to Emacs by the OS. > You can disable use of file notifications by customizing the variable > @code{auto-revert-use-notify} to a @code{nil} value, then Emacs will > @@ -990,7 +1010,7 @@ Reverting > > @vindex auto-revert-avoid-polling > @vindex auto-revert-notify-exclude-dir-regexp > - By default, Auto-Revert mode will poll files for changes > + By default, Auto Revert mode will poll files for changes > periodically even when file notifications are used. Such polling is > usually unnecessary, and turning it off may save power by relying on ^^^^^^^^^^^^^^^^^^^ I would say "unnecessary in many cases". "usually" begs the question why by default we do poll. Bonus points for adding some hint about what rare situations do need such polling, as I think this description sounds like a small riddle without that, and doesn't allow people to make an educated decision regarding whether they do or don't want the polling turned off. Thanks. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2019 14:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15568948808922 (code B ref 35418); Fri, 03 May 2019 14:48:01 +0000 Received: (at 35418) by debbugs.gnu.org; 3 May 2019 14:48:00 +0000 Received: from localhost ([127.0.0.1]:49293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMZTj-0002Jo-O8 for submit@debbugs.gnu.org; Fri, 03 May 2019 10:48:00 -0400 Received: from mail177c50.megamailservers.eu ([91.136.10.187]:56086 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMZTf-0002Jc-EF for 35418@debbugs.gnu.org; Fri, 03 May 2019 10:47:57 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556894873; bh=lgkRAFnBYkfng8wGY4AhYdDkjfrCJhiH0aSAp7XG3Vs=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=lRgnD5c2Cvt/kno0ssZSY+nPubEj0NCDueSq5EajRUE9X3FusZrCidCfgDd17rhGw 8E6rUIiGjzf7BiOqrFG0zNND+J0yFuo2Ulrm9JgBOAxHdSrNKaJGY6P4BR7ToA75gh vStI/VtTFV+WT7gk4UQy973wZzBbtn4yb+ExYsSE= Feedback-ID: mattiase@acm.or Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x43ElpU6018831; Fri, 3 May 2019 14:47:53 +0000 Message-ID: <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Date: Fri, 03 May 2019 16:47:51 +0200 In-Reply-To: <83r29fmz3f.fsf@gnu.org> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> Content-Type: multipart/mixed; boundary="=-B71lVHy6XHvNIvm5igiH" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 X-CTCH-RefID: str=0001.0A0B0205.5CCC5499.0040, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=K6UM4ReI c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=7sI8tD3eCF6wwqLbBHcA:9 a=QEXdDO2ut3YA:10 a=N54-gffFAAAA:8 a=5BDTXNcLyv-6_XvxyWcA:9 a=7MBy-bkBHSRumS2N:21 a=BP7rEuqvbgCVvhNl:21 a=B2y7HmGcmWMA:10 a=6l0D2HzqY3Epnrm8mE3f:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-B71lVHy6XHvNIvm5igiH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit fre 2019-05-03 klockan 16:44 +0300 skrev Eli Zaretskii: > > > It is better to cite the node names in the log, unless doing that is > completely impractical. Done. I found it a bit impractical in this case, but did so anyway. > > -@node Autorevert > > -@section Auto Reverting Non-File Buffers > > +@c The including file must provide its own @node and @section > > lines. > > So maybe we shouldn't remove the @node here? How about making it a > subsection of "Auto Revert" instead? The text in arevert-xtra has two subsections already. Then we would have three subsections, where the first acts as a sort of prelude to the two others. That might work for the on-line manual, but how would it fit into emacs-xtra? What would the section be then? > > +@vindex auto-revert-remote-files > > + These minor modes do not check or revert remote files, because > > that is > > Which "these minor modes"? Such wording is only appropriate when it > closely follows a list of modes, which is not the case here. I think > it's better to enumerate the modes explicitly here. Replaced with 'The Auto Revert modes'; this should be readily understood. > > periodically even when file notifications are used. Such polling > > is > > usually unnecessary, and turning it off may save power by relying > > on > ^^^^^^^^^^^^^^^^^^^ > I would say "unnecessary in many cases". "usually" begs the question > why by default we do poll. Bonus points for adding some hint about > what rare situations do need such polling, as I think this > description > sounds like a small riddle without that, and doesn't allow people to > make an educated decision regarding whether they do or don't want the > polling turned off. Done, but the hint you are asking for does come right after: [...] However, notification is ineffective on certain file systems; mainly network file system on Unix-like machines, where files can be altered from other machines. which is the most important case that I'm aware of. (According to Michael, Tramp notifications can be unreliable sometimes, but they have to be enabled actively.) Thanks for the review! Revised patch attached. --=-B71lVHy6XHvNIvm5igiH Content-Disposition: attachment; filename="0001-Reorganise-auto-revert-nodes-in-the-manual.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Reorganise-auto-revert-nodes-in-the-manual.patch"; charset="UTF-8" RnJvbSAzYjlmYzFkMjg4Y2I3MTY4ZGIzZjEzNTJmNmUyNjEyNjZkYmU0MzQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWF0dGlhcz0yMEVuZ2RlZz1DMz1BNXJkPz0g PG1hdHRpYXNlQGFjbS5vcmc+CkRhdGU6IFR1ZSwgMzAgQXByIDIwMTkgMjI6MzU6NTYgKzAyMDAK U3ViamVjdDogW1BBVENIXSBSZW9yZ2FuaXNlIChhdXRvLSlyZXZlcnQgbm9kZXMgaW4gdGhlIG1h bnVhbAoKVGhlIGFtb3VudCBvZiBpbmZvcm1hdGlvbiBvbiBhdXRvLXJldmVydCBoYXMgZ3Jvd24g dG8gZGVzZXJ2ZSBhCnNlY3Rpb24gb2YgaXRzIG93biAoYnVnIzM1NDE4KS4KCiogZG9jL2VtYWNz L2ZpbGVzLnRleGkKKEZpbGVzKTogQWRqdXN0IG1lbnUuCihSZXZlcnRpbmcsIEF1dG8gUmV2ZXJ0 KToKQWRkIG5vZGUgYEF1dG8gUmV2ZXJ0JyBhbmQgbW92ZSBnZW5lcmFsIGluZm9ybWF0aW9uIG9u IHRoYXQgdG9waWMgdGhlcmUKZnJvbSBgUmV2ZXJ0aW5nJy4KU29ydCBwYXJhZ3JhcGhzIGluIGBB dXRvIFJldmVydCcgaW4gYSByb3VnaCBsZWFzdC10by1tb3N0IHNwZWNpZmljIG9yZGVyLgpJbmNs dWRlIHRoZSBvbGQgYEF1dG9yZXZlcnQnIHRleHQgYW5kIHN1YnNlY3Rpb25zIGludG8gdGhhdCBu b2RlIHdoZW4KYnVpbGRpbmcgdGhlIG9uLWxpbmUgbWFudWFsLgooQXV0b3JldmVydCk6IFJlbW92 ZS4KKiBkb2MvZW1hY3MvYXJldmVydC14dHJhLnRleGkgKEF1dG9yZXZlcnQpOiBSZW1vdmUgbm9k ZSBhbmQgc2VjdGlvbiBsaW5lcy4KKiBkb2MvZW1hY3MvYnVmZmVycy50ZXhpIChTZXZlcmFsIEJ1 ZmZlcnMpOiBBZGp1c3QgcmVmZXJlbmNlcy4KKiBkb2MvZW1hY3MvZW1hY3MudGV4aSAoVG9wKTog QWRqdXN0IG1lbnUuCiogZG9jL2VtYWNzL2VtYWNzLXh0cmEudGV4aToKKFRvcCk6IEFkanVzdCBt ZW51LgooTm9uLUZpbGUgQnVmZmVycyk6IEFkZCBub2RlIGFuZCBzZWN0aW9uIGxpbmVzLgotLS0K IGRvYy9lbWFjcy9hcmV2ZXJ0LXh0cmEudGV4aSB8ICAzICstCiBkb2MvZW1hY3MvYnVmZmVycy50 ZXhpICAgICAgfCAgNCArLS0KIGRvYy9lbWFjcy9lbWFjcy14dHJhLnRleGkgICB8ICA0ICsrLQog ZG9jL2VtYWNzL2VtYWNzLnRleGkgICAgICAgIHwgIDQgKy0tCiBkb2MvZW1hY3MvZmlsZXMudGV4 aSAgICAgICAgfCA3MSArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCiA1IGZp bGVzIGNoYW5nZWQsIDQ3IGluc2VydGlvbnMoKyksIDM5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL2RvYy9lbWFjcy9hcmV2ZXJ0LXh0cmEudGV4aSBiL2RvYy9lbWFjcy9hcmV2ZXJ0LXh0cmEu dGV4aQppbmRleCBjZDdjMWZmODk1Li44Y2M1YjA1M2I1IDEwMDY0NAotLS0gYS9kb2MvZW1hY3Mv YXJldmVydC14dHJhLnRleGkKKysrIGIvZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50ZXhpCkBAIC00 LDggKzQsNyBAQAogQGMKIEBjIFRoaXMgZmlsZSBpcyBpbmNsdWRlZCBlaXRoZXIgaW4gZW1hY3Mt eHRyYS50ZXhpICh3aGVuIHByb2R1Y2luZyB0aGUKIEBjIHByaW50ZWQgdmVyc2lvbikgb3IgaW4g dGhlIG1haW4gRW1hY3MgbWFudWFsIChmb3IgdGhlIG9uLWxpbmUgdmVyc2lvbikuCi1Abm9kZSBB dXRvcmV2ZXJ0Ci1Ac2VjdGlvbiBBdXRvIFJldmVydGluZyBOb24tRmlsZSBCdWZmZXJzCitAYyBU aGUgaW5jbHVkaW5nIGZpbGUgbXVzdCBwcm92aWRlIGl0cyBvd24gQG5vZGUgYW5kIEBzZWN0aW9u IGxpbmVzLgogCiBHbG9iYWwgQXV0byBSZXZlcnQgTW9kZSBub3JtYWxseSBvbmx5IHJldmVydHMg ZmlsZSBidWZmZXJzLiAgVGhlcmUgYXJlCiB0d28gd2F5cyB0byBhdXRvLXJldmVydCBjZXJ0YWlu IG5vbi1maWxlIGJ1ZmZlcnM6IGJ5IGVuYWJsaW5nIEF1dG8KZGlmZiAtLWdpdCBhL2RvYy9lbWFj cy9idWZmZXJzLnRleGkgYi9kb2MvZW1hY3MvYnVmZmVycy50ZXhpCmluZGV4IDI3ZmNiNzM2OWEu LjE0YTBhMDFjYTggMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9idWZmZXJzLnRleGkKKysrIGIvZG9j L2VtYWNzL2J1ZmZlcnMudGV4aQpAQCAtNTY4LDEwICs1NjgsMTAgQEAgU2V2ZXJhbCBCdWZmZXJz CiBBdXRvIFJldmVydCBtb2RlIGFwcGxpZXMgdG8gdGhlIEBmaWxleypCdWZmZXIgTGlzdCp9IGJ1 ZmZlciBvbmx5IGlmCiBAY29kZXtnbG9iYWwtYXV0by1yZXZlcnQtbm9uLWZpbGUtYnVmZmVyc30g aXMgbm9uLUBjb2Rle25pbH0uCiBAaWZ0ZXgKLUBpbmZvcmVme0F1dG9yZXZlcnQsLCBlbWFjcy14 dHJhfSwgZm9yIGRldGFpbHMuCitAaW5mb3JlZntBdXRvIFJldmVydGluZyB0aGUgQnVmZmVyIE1l bnUsLCBlbWFjcy14dHJhfSwgZm9yIGRldGFpbHMuCiBAZW5kIGlmdGV4CiBAaWZub3R0ZXgKLUB4 cmVme0F1dG9yZXZlcnQsIGdsb2JhbC1hdXRvLXJldmVydC1ub24tZmlsZS1idWZmZXJzfSwgZm9y IGRldGFpbHMuCitAeHJlZntBdXRvIFJldmVydGluZyB0aGUgQnVmZmVyIE1lbnUsIGdsb2JhbC1h dXRvLXJldmVydC1ub24tZmlsZS1idWZmZXJzfSwgZm9yIGRldGFpbHMuCiBAZW5kIGlmbm90dGV4 CiAKIEBub2RlIEluZGlyZWN0IEJ1ZmZlcnMKZGlmZiAtLWdpdCBhL2RvYy9lbWFjcy9lbWFjcy14 dHJhLnRleGkgYi9kb2MvZW1hY3MvZW1hY3MteHRyYS50ZXhpCmluZGV4IGRjZDhmYWUxYjYuLjg0 YmJkYjg0ZDAgMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9lbWFjcy14dHJhLnRleGkKKysrIGIvZG9j L2VtYWNzL2VtYWNzLXh0cmEudGV4aQpAQCAtNTksNyArNTksNyBAQCBUb3AKICogUGljdHVyZSBN b2RlOjogICAgICAgIEVkaXRpbmcgcGljdHVyZXMgbWFkZSB1cCBvZiBjaGFyYWN0ZXJzIHVzaW5n CiAgICAgICAgICAgICAgICAgICAgICAgICAgdGhlIHF1YXJ0ZXItcGxhbmUgc2NyZWVuIG1vZGVs LgogCi0qIEF1dG9yZXZlcnQ6OiAgICAgICAgICBBdXRvIFJldmVydGluZyBub24tZmlsZSBidWZm ZXJzLgorKiBOb24tRmlsZSBCdWZmZXJzOjogICAgQXV0byBSZXZlcnRpbmcgbm9uLWZpbGUgYnVm ZmVycy4KICogU3ViZGlyIFN3aXRjaGVzOjogICAgIFN1YmRpcmVjdG9yeSBzd2l0Y2hlcyBpbiBE aXJlZC4KICogQWR2YW5jZWQgQ2FsZW5kYXIvRGlhcnkgVXNhZ2U6OiBBZHZhbmNlZCBDYWxlbmRh ci9EaWFyeSBjdXN0b21pemF0aW9uLgogKiBFbWVyZ2U6OiAgICAgICAgICAgICAgQSBjb252ZW5p ZW50IHdheSBvZiBtZXJnaW5nIHR3byB2ZXJzaW9ucyBvZiBhIHByb2dyYW0uCkBAIC0xMTEsNiAr MTExLDggQEAgSW50cm9kdWN0aW9uCiBAcmFpc2VzZWN0aW9ucwogQGluY2x1ZGUgcGljdHVyZS14 dHJhLnRleGkKIAorQG5vZGUgTm9uLUZpbGUgQnVmZmVycworQHNlY3Rpb24gQXV0byBSZXZlcnRp bmcgTm9uLUZpbGUgQnVmZmVycwogQGluY2x1ZGUgYXJldmVydC14dHJhLnRleGkKIAogQGluY2x1 ZGUgZGlyZWQteHRyYS50ZXhpCmRpZmYgLS1naXQgYS9kb2MvZW1hY3MvZW1hY3MudGV4aSBiL2Rv Yy9lbWFjcy9lbWFjcy50ZXhpCmluZGV4IDU4ZWMzNzMwMjkuLmEzNGNlZjIyMWUgMTAwNjQ0Ci0t LSBhL2RvYy9lbWFjcy9lbWFjcy50ZXhpCisrKyBiL2RvYy9lbWFjcy9lbWFjcy50ZXhpCkBAIC00 NDMsOSArNDQzLDcgQEAgVG9wCiAqIFZpc2l0aW5nOjogICAgICAgICAgICBWaXNpdGluZyBhIGZp bGUgcHJlcGFyZXMgRW1hY3MgdG8gZWRpdCB0aGUgZmlsZS4KICogU2F2aW5nOjogICAgICAgICAg ICAgIFNhdmluZyBtYWtlcyB5b3VyIGNoYW5nZXMgcGVybWFuZW50LgogKiBSZXZlcnRpbmc6OiAg ICAgICAgICAgUmV2ZXJ0aW5nIGNhbmNlbHMgYWxsIHRoZSBjaGFuZ2VzIG5vdCBzYXZlZC4KLUBp Zm5vdHRleAotKiBBdXRvcmV2ZXJ0OjogICAgICAgICAgQXV0byBSZXZlcnRpbmcgbm9uLWZpbGUg YnVmZmVycy4KLUBlbmQgaWZub3R0ZXgKKyogQXV0byBSZXZlcnQ6OiAgICAgICAgIEtlZXBpbmcg YnVmZmVycyBhdXRvbWF0aWNhbGx5IHVwLXRvLWRhdGUuCiAqIEF1dG8gU2F2ZTo6ICAgICAgICAg ICBBdXRvIFNhdmUgcGVyaW9kaWNhbGx5IHByb3RlY3RzIGFnYWluc3QgbG9zcyBvZiBkYXRhLgog KiBGaWxlIEFsaWFzZXM6OiAgICAgICAgSGFuZGxpbmcgbXVsdGlwbGUgbmFtZXMgZm9yIG9uZSBm aWxlLgogKiBEaXJlY3Rvcmllczo6ICAgICAgICAgQ3JlYXRpbmcsIGRlbGV0aW5nLCBhbmQgbGlz dGluZyBmaWxlIGRpcmVjdG9yaWVzLgpkaWZmIC0tZ2l0IGEvZG9jL2VtYWNzL2ZpbGVzLnRleGkg Yi9kb2MvZW1hY3MvZmlsZXMudGV4aQppbmRleCA5OTBiOGYxNjc5Li43ZjVlMTZhODQ1IDEwMDY0 NAotLS0gYS9kb2MvZW1hY3MvZmlsZXMudGV4aQorKysgYi9kb2MvZW1hY3MvZmlsZXMudGV4aQpA QCAtMjUsOSArMjUsNyBAQCBGaWxlcwogKiBWaXNpdGluZzo6ICAgICAgICAgICAgVmlzaXRpbmcg YSBmaWxlIHByZXBhcmVzIEVtYWNzIHRvIGVkaXQgdGhlIGZpbGUuCiAqIFNhdmluZzo6ICAgICAg ICAgICAgICBTYXZpbmcgbWFrZXMgeW91ciBjaGFuZ2VzIHBlcm1hbmVudC4KICogUmV2ZXJ0aW5n OjogICAgICAgICAgIFJldmVydGluZyBjYW5jZWxzIGFsbCB0aGUgY2hhbmdlcyBub3Qgc2F2ZWQu Ci1AaWZub3R0ZXgKLSogQXV0b3JldmVydDo6ICAgICAgICAgIEF1dG8gUmV2ZXJ0aW5nIG5vbi1m aWxlIGJ1ZmZlcnMuCi1AZW5kIGlmbm90dGV4CisqIEF1dG8gUmV2ZXJ0OjogICAgICAgICBLZWVw aW5nIGJ1ZmZlcnMgYXV0b21hdGljYWxseSB1cC10by1kYXRlLgogKiBBdXRvIFNhdmU6OiAgICAg ICAgICAgQXV0byBTYXZlIHBlcmlvZGljYWxseSBwcm90ZWN0cyBhZ2FpbnN0IGxvc3Mgb2YgZGF0 YS4KICogRmlsZSBBbGlhc2VzOjogICAgICAgIEhhbmRsaW5nIG11bHRpcGxlIG5hbWVzIGZvciBv bmUgZmlsZS4KICogRGlyZWN0b3JpZXM6OiAgICAgICAgIENyZWF0aW5nLCBkZWxldGluZywgYW5k IGxpc3RpbmcgZmlsZSBkaXJlY3Rvcmllcy4KQEAgLTk1NSw2ICs5NTMsMTEgQEAgUmV2ZXJ0aW5n CiBpcyBub3QgbW9kaWZpZWQuICAoSWYgeW91IGhhdmUgZWRpdGVkIHRoZSB0ZXh0LCBpdCB3b3Vs ZCBiZSB3cm9uZyB0bwogZGlzY2FyZCB5b3VyIGNoYW5nZXMuKQogCisgIFlvdSBjYW4gYWxzbyB0 ZWxsIEVtYWNzIHRvIHJldmVydCBidWZmZXJzIGF1dG9tYXRpY2FsbHkgd2hlbiB0aGVpcgordmlz aXRlZCBmaWxlcyBjaGFuZ2Ugb24gZGlzazsgQHB4cmVme0F1dG8gUmV2ZXJ0fS4KKworQG5vZGUg QXV0byBSZXZlcnQKK0BzZWN0aW9uIEF1dG8gUmV2ZXJ0OiBLZWVwaW5nIGJ1ZmZlcnMgYXV0b21h dGljYWxseSB1cC10by1kYXRlCiBAY2luZGV4IEdsb2JhbCBBdXRvIFJldmVydCBtb2RlCiBAY2lu ZGV4IG1vZGUsIEdsb2JhbCBBdXRvIFJldmVydAogQGNpbmRleCBBdXRvIFJldmVydCBtb2RlCkBA IC05NjIsMjIgKzk2NSwzOSBAQCBSZXZlcnRpbmcKIEBmaW5kZXggZ2xvYmFsLWF1dG8tcmV2ZXJ0 LW1vZGUKIEBmaW5kZXggYXV0by1yZXZlcnQtbW9kZQogQGZpbmRleCBhdXRvLXJldmVydC10YWls LW1vZGUKLUB2aW5kZXggYXV0by1yZXZlcnQtaW50ZXJ2YWwKLUB2aW5kZXggYXV0by1yZXZlcnQt cmVtb3RlLWZpbGVzCisKKyAgQSBidWZmZXIgY2FuIGdldCBvdXQgb2Ygc3luYyB3aXRoIHJlc3Bl Y3QgdG8gaXRzIHZpc2l0ZWQgZmlsZSBvbgorZGlzayBpZiB0aGF0IGZpbGUgaXMgY2hhbmdlZCBi eSBhbm90aGVyIHByb2dyYW0uICBUbyBrZWVwIGl0IHVwIHRvCitkYXRlLCB5b3UgY2FuIGVuYWJs ZSBBdXRvIFJldmVydCBtb2RlIGJ5IHR5cGluZyBAa2Jke00teCBhdXRvLXJldmVydC1tb2RlfS4K K1RoaXMgYXV0b21hdGljYWxseSByZXZlcnRzIHRoZSBidWZmZXIgd2hlbiBpdHMgdmlzaXRlZCBm aWxlIGNoYW5nZXMgb24KK2Rpc2suICBUbyBkbyB0aGUgc2FtZSBmb3IgYWxsIGZpbGUgYnVmZmVy cywgdHlwZQorQGtiZHtNLXggZ2xvYmFsLWF1dG8tcmV2ZXJ0LW1vZGV9IHRvIGVuYWJsZSBHbG9i YWwgQXV0byBSZXZlcnQgbW9kZS4KKworICBBdXRvIFJldmVydCB3aWxsIG5vdCByZXZlcnQgYSBi dWZmZXIgaWYgaXQgaGFzIHVuc2F2ZWQgY2hhbmdlcywgb3IgaWYKK2l0cyBmaWxlIG9uIGRpc2sg aXMgZGVsZXRlZCBvciByZW5hbWVkLgorCisgIE9uZSB1c2Ugb2YgQXV0byBSZXZlcnQgbW9kZSBp cyB0byBgYHRhaWwnJyBhIGZpbGUgc3VjaCBhcyBhIHN5c3RlbQorbG9nLCBzbyB0aGF0IGNoYW5n ZXMgbWFkZSB0byB0aGF0IGZpbGUgYnkgb3RoZXIgcHJvZ3JhbXMgYXJlCitjb250aW51b3VzbHkg ZGlzcGxheWVkLiAgVG8gZG8gdGhpcywganVzdCBtb3ZlIHRoZSBwb2ludCB0byB0aGUgZW5kIG9m Cit0aGUgYnVmZmVyLCBhbmQgaXQgd2lsbCBzdGF5IHRoZXJlIGFzIHRoZSBmaWxlIGNvbnRlbnRz IGNoYW5nZS4KK0hvd2V2ZXIsIGlmIHlvdSBhcmUgc3VyZSB0aGF0IHRoZSBmaWxlIHdpbGwgb25s eSBjaGFuZ2UgYnkgZ3Jvd2luZyBhdAordGhlIGVuZCwgdXNlIEF1dG8gUmV2ZXJ0IFRhaWwgbW9k ZSBpbnN0ZWFkCisoQGNvZGV7YXV0by1yZXZlcnQtdGFpbC1tb2RlfSkuICBJdCBpcyBtb3JlIGVm ZmljaWVudCBmb3IgdGhpcy4KK0F1dG8gUmV2ZXJ0IFRhaWwgbW9kZSBhbHNvIHdvcmtzIGZvciBy ZW1vdGUgZmlsZXMuCisKIEB2aW5kZXggYXV0by1yZXZlcnQtdmVyYm9zZQotICBZb3UgY2FuIGFs c28gdGVsbCBFbWFjcyB0byByZXZlcnQgYnVmZmVycyBwZXJpb2RpY2FsbHkuICBUbyBkbyB0aGlz Ci1mb3IgYSBzcGVjaWZpYyBidWZmZXIsIGVuYWJsZSB0aGUgbWlub3IgbW9kZSBBdXRvLVJldmVy dCBtb2RlIGJ5Ci10eXBpbmcgQGtiZHtNLXggYXV0by1yZXZlcnQtbW9kZX0uICBUaGlzIGF1dG9t YXRpY2FsbHkgcmV2ZXJ0cyB0aGUKLWN1cnJlbnQgYnVmZmVyIHdoZW4gaXRzIHZpc2l0ZWQgZmls ZSBjaGFuZ2VzIG9uIGRpc2suICBUbyBkbyB0aGUgc2FtZQotZm9yIGFsbCBmaWxlIGJ1ZmZlcnMs IHR5cGUgQGtiZHtNLXggZ2xvYmFsLWF1dG8tcmV2ZXJ0LW1vZGV9IHRvIGVuYWJsZQotR2xvYmFs IEF1dG8tUmV2ZXJ0IG1vZGUuICBUaGVzZSBtaW5vciBtb2RlcyBkbyBub3QgY2hlY2sgb3IgcmV2 ZXJ0Ci1yZW1vdGUgZmlsZXMsIGJlY2F1c2UgdGhhdCBpcyB1c3VhbGx5IHRvbyBzbG93LiAgVGhp cyBiZWhhdmlvciBjYW4gYmUKLWNoYW5nZWQgYnkgc2V0dGluZyB0aGUgdmFyaWFibGUgQGNvZGV7 YXV0by1yZXZlcnQtcmVtb3RlLWZpbGVzfSB0bwotbm9uLUBjb2Rle25pbH0uCisgIFdoZW4gYSBi dWZmZXIgaXMgYXV0by1yZXZlcnRlZCwgYSBtZXNzYWdlIGlzIGdlbmVyYXRlZC4gIFRoaXMgY2Fu IGJlCitzdXBwcmVzc2VkIGJ5IHNldHRpbmcgQGNvZGV7YXV0by1yZXZlcnQtdmVyYm9zZX0gdG8g QGNvZGV7bmlsfS4KKworQHZpbmRleCBhdXRvLXJldmVydC1yZW1vdGUtZmlsZXMKKyAgVGhlIEF1 dG8gUmV2ZXJ0IG1vZGVzIGRvIG5vdCBjaGVjayBvciByZXZlcnQgcmVtb3RlIGZpbGVzLCBiZWNh dXNlCit0aGF0IGlzIHVzdWFsbHkgdG9vIHNsb3cuICBUaGlzIGJlaGF2aW9yIGNhbiBiZSBjaGFu Z2VkIGJ5IHNldHRpbmcgdGhlCit2YXJpYWJsZSBAY29kZXthdXRvLXJldmVydC1yZW1vdGUtZmls ZXN9IHRvIG5vbi1AY29kZXtuaWx9LgogCiBAY2luZGV4IGZpbGUgbm90aWZpY2F0aW9ucwogQHZp bmRleCBhdXRvLXJldmVydC11c2Utbm90aWZ5Ci0gIEJ5IGRlZmF1bHQsIEF1dG8tUmV2ZXJ0IG1v ZGUgd29ya3MgdXNpbmcgQGRmbntmaWxlIG5vdGlmaWNhdGlvbnN9LAorQHZpbmRleCBhdXRvLXJl dmVydC1pbnRlcnZhbAorICBCeSBkZWZhdWx0LCBBdXRvIFJldmVydCBtb2RlIHdvcmtzIHVzaW5n IEBkZm57ZmlsZSBub3RpZmljYXRpb25zfSwKIHdoZXJlYnkgY2hhbmdlcyBpbiB0aGUgZmlsZXN5 c3RlbSBhcmUgcmVwb3J0ZWQgdG8gRW1hY3MgYnkgdGhlIE9TLgogWW91IGNhbiBkaXNhYmxlIHVz ZSBvZiBmaWxlIG5vdGlmaWNhdGlvbnMgYnkgY3VzdG9taXppbmcgdGhlIHZhcmlhYmxlCiBAY29k ZXthdXRvLXJldmVydC11c2Utbm90aWZ5fSB0byBhIEBjb2Rle25pbH0gdmFsdWUsIHRoZW4gRW1h Y3Mgd2lsbApAQCAtOTkwLDEwICsxMDEwLDEwIEBAIFJldmVydGluZwogCiBAdmluZGV4IGF1dG8t cmV2ZXJ0LWF2b2lkLXBvbGxpbmcKIEB2aW5kZXggYXV0by1yZXZlcnQtbm90aWZ5LWV4Y2x1ZGUt ZGlyLXJlZ2V4cAotICBCeSBkZWZhdWx0LCBBdXRvLVJldmVydCBtb2RlIHdpbGwgcG9sbCBmaWxl cyBmb3IgY2hhbmdlcworICBCeSBkZWZhdWx0LCBBdXRvIFJldmVydCBtb2RlIHdpbGwgcG9sbCBm aWxlcyBmb3IgY2hhbmdlcwogcGVyaW9kaWNhbGx5IGV2ZW4gd2hlbiBmaWxlIG5vdGlmaWNhdGlv bnMgYXJlIHVzZWQuICBTdWNoIHBvbGxpbmcgaXMKLXVzdWFsbHkgdW5uZWNlc3NhcnksIGFuZCB0 dXJuaW5nIGl0IG9mZiBtYXkgc2F2ZSBwb3dlciBieSByZWx5aW5nIG9uCi1ub3RpZmljYXRpb25z IG9ubHkuICBUbyBkbyBzbywgc2V0IHRoZSB2YXJpYWJsZQordW5uZWNlc3NhcnkgaW4gbWFueSBj YXNlcywgYW5kIHR1cm5pbmcgaXQgb2ZmIG1heSBzYXZlIHBvd2VyIGJ5CityZWx5aW5nIG9uIG5v dGlmaWNhdGlvbnMgb25seS4gIFRvIGRvIHNvLCBzZXQgdGhlIHZhcmlhYmxlCiBAY29kZXthdXRv LXJldmVydC1hdm9pZC1wb2xsaW5nfSB0byBub24tQGNvZGV7bmlsfS4gIEhvd2V2ZXIsCiBub3Rp ZmljYXRpb24gaXMgaW5lZmZlY3RpdmUgb24gY2VydGFpbiBmaWxlIHN5c3RlbXM7IG1haW5seSBu ZXR3b3JrCiBmaWxlIHN5c3RlbSBvbiBVbml4LWxpa2UgbWFjaGluZXMsIHdoZXJlIGZpbGVzIGNh biBiZSBhbHRlcmVkIGZyb20KQEAgLTEwMDIsMTkgKzEwMjIsNyBAQCBSZXZlcnRpbmcKIEBjb2Rl e2F1dG8tcmV2ZXJ0LW5vdGlmeS1leGNsdWRlLWRpci1yZWdleHB9IHRvIG1hdGNoIGZpbGVzIHRo YXQKIHNob3VsZCBiZSBleGNsdWRlZCBmcm9tIHVzaW5nIG5vdGlmaWNhdGlvbi4KIAotICBPbmUg dXNlIG9mIEF1dG8tUmV2ZXJ0IG1vZGUgaXMgdG8gYGB0YWlsJycgYSBmaWxlIHN1Y2ggYXMgYSBz eXN0ZW0KLWxvZywgc28gdGhhdCBjaGFuZ2VzIG1hZGUgdG8gdGhhdCBmaWxlIGJ5IG90aGVyIHBy b2dyYW1zIGFyZQotY29udGludW91c2x5IGRpc3BsYXllZC4gIFRvIGRvIHRoaXMsIGp1c3QgbW92 ZSB0aGUgcG9pbnQgdG8gdGhlIGVuZCBvZgotdGhlIGJ1ZmZlciwgYW5kIGl0IHdpbGwgc3RheSB0 aGVyZSBhcyB0aGUgZmlsZSBjb250ZW50cyBjaGFuZ2UuCi1Ib3dldmVyLCBpZiB5b3UgYXJlIHN1 cmUgdGhhdCB0aGUgZmlsZSB3aWxsIG9ubHkgY2hhbmdlIGJ5IGdyb3dpbmcgYXQKLXRoZSBlbmQs IHVzZSBBdXRvLVJldmVydCBUYWlsIG1vZGUgaW5zdGVhZAotKEBjb2Rle2F1dG8tcmV2ZXJ0LXRh aWwtbW9kZX0pLiAgSXQgaXMgbW9yZSBlZmZpY2llbnQgZm9yIHRoaXMuCi1BdXRvLVJldmVydCBU YWlsIG1vZGUgd29ya3MgYWxzbyBmb3IgcmVtb3RlIGZpbGVzLgotCi0gIFdoZW4gYSBidWZmZXIg aXMgYXV0by1yZXZlcnRlZCwgYSBtZXNzYWdlIGlzIGdlbmVyYXRlZC4gIFRoaXMgY2FuIGJlCi1z dXBwcmVzc2VkIGJ5IHNldHRpbmcgQGNvZGV7YXV0by1yZXZlcnQtdmVyYm9zZX0gdG8gQGNvZGV7 bmlsfS4KLQotICBJbiBEaXJlZCBidWZmZXJzIChAcHhyZWZ7RGlyZWR9KSwgQXV0by1SZXZlcnQg bW9kZSByZWZyZXNoZXMgdGhlCisgIEluIERpcmVkIGJ1ZmZlcnMgKEBweHJlZntEaXJlZH0pLCBB dXRvIFJldmVydCBtb2RlIHJlZnJlc2hlcyB0aGUKIGJ1ZmZlciB3aGVuIGEgZmlsZSBpcyBjcmVh dGVkIG9yIGRlbGV0ZWQgaW4gdGhlIGJ1ZmZlcidzIGRpcmVjdG9yeS4KIAogICBAeHJlZntWQyBV bmRvfSwgZm9yIGNvbW1hbmRzIHRvIHJldmVydCB0byBlYXJsaWVyIHZlcnNpb25zIG9mIGZpbGVz CkBAIC0xMDIyLDYgKzEwMzAsNyBAQCBSZXZlcnRpbmcKIHBlY3VsaWFyaXRpZXMgd2hlbiB2aXNp dGluZyBmaWxlcyB1bmRlciB2ZXJzaW9uIGNvbnRyb2wuCiAKIEBpZm5vdHRleAorQGMgVGhlIG5v ZGUgdGV4dCBjb250aW51ZXMgaGVyZS4KIEBpbmNsdWRlIGFyZXZlcnQteHRyYS50ZXhpCiBAZW5k IGlmbm90dGV4CiAKLS0gCjIuMjAuMQoK --=-B71lVHy6XHvNIvm5igiH-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 09:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15569606944134 (code B ref 35418); Sat, 04 May 2019 09:05:02 +0000 Received: (at 35418) by debbugs.gnu.org; 4 May 2019 09:04:54 +0000 Received: from localhost ([127.0.0.1]:50359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMqbF-00014b-QH for submit@debbugs.gnu.org; Sat, 04 May 2019 05:04:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMqbB-00014M-Pv for 35418@debbugs.gnu.org; Sat, 04 May 2019 05:04:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMqb6-0004c2-8e; Sat, 04 May 2019 05:04:44 -0400 Received: from [176.228.60.248] (port=1180 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hMqb5-0000vj-Lc; Sat, 04 May 2019 05:04:44 -0400 Date: Sat, 04 May 2019 12:04:28 +0300 Message-Id: <831s1emvz7.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Fri, 03 May 2019 16:47:51 +0200) References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Cc: michael.albinus@gmx.de, 35418@debbugs.gnu.org > Date: Fri, 03 May 2019 16:47:51 +0200 > > > It is better to cite the node names in the log, unless doing that is > > completely impractical. > > Done. I found it a bit impractical in this case, but did so anyway. Thanks, but why did you start the description of the change on a new line? Here: > * doc/emacs/files.texi > (Files): Adjust menu. > (Reverting, Auto Revert): > Add node `Auto Revert' and move general information on that topic there > from `Reverting'. > Sort paragraphs in `Auto Revert' in a rough least-to-most specific order. > Include the old `Autorevert' text and subsections into that node when > building the on-line manual. > (Autorevert): Remove. This should be formatted like this (indented 2 spaces for clarity): * doc/emacs/files.texi (Files): Adjust menu. (Reverting, Auto Revert): Add node `Auto Revert' and move general information on that topic there from `Reverting'. Sort paragraphs in `Auto Revert' in a rough least-to-most specific order. Include the old `Autorevert' text and subsections into that node when building the on-line manual. (Autorevert): Remove. IOW, only when you describe changes to another node you should start on a new line. The above is the formatting produced by "C-x 4 a" and its ilk. > > > -@node Autorevert > > > -@section Auto Reverting Non-File Buffers > > > +@c The including file must provide its own @node and @section > > > lines. > > > > So maybe we shouldn't remove the @node here? How about making it a > > subsection of "Auto Revert" instead? > > The text in arevert-xtra has two subsections already. Then we would > have three subsections, where the first acts as a sort of prelude to > the two others. That might work for the on-line manual, but how would > it fit into emacs-xtra? What would the section be then? No, I meant make "Autorevert" (under its new name) a subsection of "Auto Revert", and the 2 subsections of "Autorevert" sub-subsections. Or did I misunderstand the problem you were describing? > > > periodically even when file notifications are used. Such polling > > > is > > > usually unnecessary, and turning it off may save power by relying > > > on > > ^^^^^^^^^^^^^^^^^^^ > > I would say "unnecessary in many cases". "usually" begs the question > > why by default we do poll. Bonus points for adding some hint about > > what rare situations do need such polling, as I think this > > description > > sounds like a small riddle without that, and doesn't allow people to > > make an educated decision regarding whether they do or don't want the > > polling turned off. > > Done, but the hint you are asking for does come right after: > > [...] However, > notification is ineffective on certain file systems; mainly network > file system on Unix-like machines, where files can be altered from > other machines. Yes, but that hint doesn't mention the polling. I think it's important to tell that polling is needed in these rare cases. Thanks. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 11:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155696888716662 (code B ref 35418); Sat, 04 May 2019 11:22:02 +0000 Received: (at 35418) by debbugs.gnu.org; 4 May 2019 11:21:27 +0000 Received: from localhost ([127.0.0.1]:50456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMsjP-0004Ke-1B for submit@debbugs.gnu.org; Sat, 04 May 2019 07:21:27 -0400 Received: from mail85c50.megamailservers.eu ([91.136.10.95]:47424 helo=mail18c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMsjL-0004KT-Vc for 35418@debbugs.gnu.org; Sat, 04 May 2019 07:21:25 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556968881; bh=WzEAPDefixb6kPTbuJbyIrD2L+yGbIARjyO/XKWAxSA=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=BrDcXqupvQ0R3eiklIW8zipyvhOF5phWpNHeoL4Bore4iYjjJFI0e30KOOKeiiPV7 51w0NBAUaNQWqx6gA9rW1KLjxAviZh0ipP1WyRmIVYwvE3b3Uls3mQ4INpFMZXee4L KBNjtD6goiodTePWM56l8lqwiSBmStxnTQKym7Uo= Feedback-ID: mattiase@acm.or Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x44BLKVX010219; Sat, 4 May 2019 11:21:21 +0000 Message-ID: <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Date: Sat, 04 May 2019 13:21:19 +0200 In-Reply-To: <831s1emvz7.fsf@gnu.org> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> Content-Type: multipart/mixed; boundary="=-rrD2ikn2e81wcl0D1j3F" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 X-CTCH-RefID: str=0001.0A0B0207.5CCD75B1.0047, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=W4oWqyek c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=wXJLnjB-we-nPwKeh_IA:9 a=QEXdDO2ut3YA:10 a=N54-gffFAAAA:8 a=aq8NLC-jydVQ8E0-rTsA:9 a=9OaxS5Md8fU-2vKe:21 a=PIXDmC4pcpJjlasN:21 a=B2y7HmGcmWMA:10 a=6l0D2HzqY3Epnrm8mE3f:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-rrD2ikn2e81wcl0D1j3F Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit lör 2019-05-04 klockan 12:04 +0300 skrev Eli Zaretskii: > > IOW, only when you describe changes to another node you should start > on a new line. The above is the formatting produced by "C-x 4 a" and > its ilk. Reformatted. > No, I meant make "Autorevert" (under its new name) a subsection of > "Auto Revert", and the 2 subsections of "Autorevert" sub-subsections. > Or did I misunderstand the problem you were describing? Done. It seems that a subsection can be directly under a top node without a section as intermediate step; I didn't know that. > Yes, but that hint doesn't mention the polling. I think it's > important to tell that polling is needed in these rare cases. Text added. Thanks again; revised patch attached. > --=-rrD2ikn2e81wcl0D1j3F Content-Disposition: attachment; filename="0001-Reorganise-auto-revert-nodes-in-the-manual.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Reorganise-auto-revert-nodes-in-the-manual.patch"; charset="UTF-8" RnJvbSBlYTdjMDg3ZGYxNGYzMDI1NDNjZTllMjcxMWNjOGNiZGUwOWRiYzMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWF0dGlhcz0yMEVuZ2RlZz1DMz1BNXJkPz0g PG1hdHRpYXNlQGFjbS5vcmc+CkRhdGU6IFR1ZSwgMzAgQXByIDIwMTkgMjI6MzU6NTYgKzAyMDAK U3ViamVjdDogW1BBVENIXSBSZW9yZ2FuaXNlIChhdXRvLSlyZXZlcnQgbm9kZXMgaW4gdGhlIG1h bnVhbAoKUHV0IGFsbCBpbmZvcm1hdGlvbiBhYm91dCBhdXRvLXJldmVydCBpbnRvIGEgc2VjdGlv biBvZiBpdHMgb3duLCBhbmQKb3JnYW5pc2UgdGhlIHRleHQgaW4gYSBtb3JlIGxvZ2ljYWwgd2F5 LiAgUHJldmlvdXNseSBpdCB3YXMgbWFpbmx5CmRlc2NyaWJlZCBpbiB0aGUgc2VjdGlvbiBhYm91 dCByZXZlcnRpbmcgKGJ1ZyMzNTQxOCkuCgoqIGRvYy9lbWFjcy9maWxlcy50ZXhpIChGaWxlcyk6 IEFkanVzdCBtZW51LgooUmV2ZXJ0aW5nLCBBdXRvIFJldmVydCwgQXV0b3JldmVydCk6IEFkZCBu b2RlIGBBdXRvIFJldmVydCcgYW5kIG1vdmUKdGV4dCBvbiB0aGF0IHRvcGljIGZyb20gYFJldmVy dGluZycsIHJlYXJyYW5nZWQuICBUdXJuIHRoZSBvbGQKYEF1dG9yZXZlcnQnIG5vZGUgaW50byBh IHN1YnNlY3Rpb24gdW5kZXIgYEF1dG8gUmV2ZXJ0Jy4KKiBkb2MvZW1hY3MvYXJldmVydC14dHJh LnRleGkgKEF1dG9yZXZlcnQpOiBSZW5hbWUgYW5kIHR1cm4gaW50bwpzdWJzdWJzZWN0aW9uLgoq IGRvYy9lbWFjcy9idWZmZXJzLnRleGkgKFNldmVyYWwgQnVmZmVycyk6IEFkanVzdCByZWZlcmVu Y2VzLgoqIGRvYy9lbWFjcy9lbWFjcy50ZXhpIChUb3ApOiBBZGp1c3QgbWVudS4KKiBkb2MvZW1h Y3MvZW1hY3MteHRyYS50ZXhpIChUb3ApOiBBZGp1c3QgbWVudS4KKE5vbi1GaWxlIEJ1ZmZlcnMp OiBBZGQgbm9kZSBhbmQgc2VjdGlvbiBsaW5lcy4KLS0tCiBkb2MvZW1hY3MvYXJldmVydC14dHJh LnRleGkgfCAgOSArKystLQogZG9jL2VtYWNzL2J1ZmZlcnMudGV4aSAgICAgIHwgIDQgKy0KIGRv Yy9lbWFjcy9lbWFjcy14dHJhLnRleGkgICB8ICAyICstCiBkb2MvZW1hY3MvZW1hY3MudGV4aSAg ICAgICAgfCAgNCArLQogZG9jL2VtYWNzL2ZpbGVzLnRleGkgICAgICAgIHwgNzUgKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQogNSBmaWxlcyBjaGFuZ2VkLCA1MSBpbnNlcnRp b25zKCspLCA0MyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2MvZW1hY3MvYXJldmVydC14 dHJhLnRleGkgYi9kb2MvZW1hY3MvYXJldmVydC14dHJhLnRleGkKaW5kZXggY2Q3YzFmZjg5NS4u OWUwMWExMGFjZSAxMDA2NDQKLS0tIGEvZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50ZXhpCisrKyBi L2RvYy9lbWFjcy9hcmV2ZXJ0LXh0cmEudGV4aQpAQCAtNCw4ICs0LDkgQEAKIEBjCiBAYyBUaGlz IGZpbGUgaXMgaW5jbHVkZWQgZWl0aGVyIGluIGVtYWNzLXh0cmEudGV4aSAod2hlbiBwcm9kdWNp bmcgdGhlCiBAYyBwcmludGVkIHZlcnNpb24pIG9yIGluIHRoZSBtYWluIEVtYWNzIG1hbnVhbCAo Zm9yIHRoZSBvbi1saW5lIHZlcnNpb24pLgotQG5vZGUgQXV0b3JldmVydAotQHNlY3Rpb24gQXV0 byBSZXZlcnRpbmcgTm9uLUZpbGUgQnVmZmVycworCitAbm9kZSBOb24tRmlsZSBCdWZmZXJzCitA c3Vic2VjdGlvbiBBdXRvIFJldmVydGluZyBOb24tRmlsZSBCdWZmZXJzCiAKIEdsb2JhbCBBdXRv IFJldmVydCBNb2RlIG5vcm1hbGx5IG9ubHkgcmV2ZXJ0cyBmaWxlIGJ1ZmZlcnMuICBUaGVyZSBh cmUKIHR3byB3YXlzIHRvIGF1dG8tcmV2ZXJ0IGNlcnRhaW4gbm9uLWZpbGUgYnVmZmVyczogYnkg ZW5hYmxpbmcgQXV0bwpAQCAtNDMsNyArNDQsNyBAQCBBdXRvcmV2ZXJ0CiBAZW5kIG1lbnUKIAog QG5vZGUgQXV0byBSZXZlcnRpbmcgdGhlIEJ1ZmZlciBNZW51Ci1Ac3Vic2VjdGlvbiBBdXRvIFJl dmVydGluZyB0aGUgQnVmZmVyIE1lbnUKK0BzdWJzdWJzZWN0aW9uIEF1dG8gUmV2ZXJ0aW5nIHRo ZSBCdWZmZXIgTWVudQogCiBJZiBhdXRvLXJldmVydGluZyBvZiBub24tZmlsZSBidWZmZXJzIGlz IGVuYWJsZWQsIHRoZSBCdWZmZXIgTWVudQogQGlmdGV4CkBAIC02NSw3ICs2Niw3IEBAIEF1dG8g UmV2ZXJ0aW5nIHRoZSBCdWZmZXIgTWVudQogYXV0b21hdGljYWxseSBlcmFzaW5nIHRoZSBtYXJr cy4KIAogQG5vZGUgQXV0byBSZXZlcnRpbmcgRGlyZWQKLUBzdWJzZWN0aW9uIEF1dG8gUmV2ZXJ0 aW5nIERpcmVkIGJ1ZmZlcnMKK0BzdWJzdWJzZWN0aW9uIEF1dG8gUmV2ZXJ0aW5nIERpcmVkIGJ1 ZmZlcnMKIAogRGlyZWQgYnVmZmVycyBvbmx5IGF1dG8tcmV2ZXJ0IHdoZW4gdGhlIGZpbGUgbGlz dCBvZiB0aGUgYnVmZmVyJ3MgbWFpbgogZGlyZWN0b3J5IGNoYW5nZXMgKGUuZy4sIHdoZW4gYSBu ZXcgZmlsZSBpcyBhZGRlZCBvciBkZWxldGVkKS4gIFRoZXkKZGlmZiAtLWdpdCBhL2RvYy9lbWFj cy9idWZmZXJzLnRleGkgYi9kb2MvZW1hY3MvYnVmZmVycy50ZXhpCmluZGV4IDI3ZmNiNzM2OWEu LjE0YTBhMDFjYTggMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9idWZmZXJzLnRleGkKKysrIGIvZG9j L2VtYWNzL2J1ZmZlcnMudGV4aQpAQCAtNTY4LDEwICs1NjgsMTAgQEAgU2V2ZXJhbCBCdWZmZXJz CiBBdXRvIFJldmVydCBtb2RlIGFwcGxpZXMgdG8gdGhlIEBmaWxleypCdWZmZXIgTGlzdCp9IGJ1 ZmZlciBvbmx5IGlmCiBAY29kZXtnbG9iYWwtYXV0by1yZXZlcnQtbm9uLWZpbGUtYnVmZmVyc30g aXMgbm9uLUBjb2Rle25pbH0uCiBAaWZ0ZXgKLUBpbmZvcmVme0F1dG9yZXZlcnQsLCBlbWFjcy14 dHJhfSwgZm9yIGRldGFpbHMuCitAaW5mb3JlZntBdXRvIFJldmVydGluZyB0aGUgQnVmZmVyIE1l bnUsLCBlbWFjcy14dHJhfSwgZm9yIGRldGFpbHMuCiBAZW5kIGlmdGV4CiBAaWZub3R0ZXgKLUB4 cmVme0F1dG9yZXZlcnQsIGdsb2JhbC1hdXRvLXJldmVydC1ub24tZmlsZS1idWZmZXJzfSwgZm9y IGRldGFpbHMuCitAeHJlZntBdXRvIFJldmVydGluZyB0aGUgQnVmZmVyIE1lbnUsIGdsb2JhbC1h dXRvLXJldmVydC1ub24tZmlsZS1idWZmZXJzfSwgZm9yIGRldGFpbHMuCiBAZW5kIGlmbm90dGV4 CiAKIEBub2RlIEluZGlyZWN0IEJ1ZmZlcnMKZGlmZiAtLWdpdCBhL2RvYy9lbWFjcy9lbWFjcy14 dHJhLnRleGkgYi9kb2MvZW1hY3MvZW1hY3MteHRyYS50ZXhpCmluZGV4IGRjZDhmYWUxYjYuLmU5 MjMxYjRlM2EgMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9lbWFjcy14dHJhLnRleGkKKysrIGIvZG9j L2VtYWNzL2VtYWNzLXh0cmEudGV4aQpAQCAtNTksNyArNTksNyBAQCBUb3AKICogUGljdHVyZSBN b2RlOjogICAgICAgIEVkaXRpbmcgcGljdHVyZXMgbWFkZSB1cCBvZiBjaGFyYWN0ZXJzIHVzaW5n CiAgICAgICAgICAgICAgICAgICAgICAgICAgdGhlIHF1YXJ0ZXItcGxhbmUgc2NyZWVuIG1vZGVs LgogCi0qIEF1dG9yZXZlcnQ6OiAgICAgICAgICBBdXRvIFJldmVydGluZyBub24tZmlsZSBidWZm ZXJzLgorKiBOb24tRmlsZSBCdWZmZXJzOjogICAgQXV0byBSZXZlcnRpbmcgbm9uLWZpbGUgYnVm ZmVycy4KICogU3ViZGlyIFN3aXRjaGVzOjogICAgIFN1YmRpcmVjdG9yeSBzd2l0Y2hlcyBpbiBE aXJlZC4KICogQWR2YW5jZWQgQ2FsZW5kYXIvRGlhcnkgVXNhZ2U6OiBBZHZhbmNlZCBDYWxlbmRh ci9EaWFyeSBjdXN0b21pemF0aW9uLgogKiBFbWVyZ2U6OiAgICAgICAgICAgICAgQSBjb252ZW5p ZW50IHdheSBvZiBtZXJnaW5nIHR3byB2ZXJzaW9ucyBvZiBhIHByb2dyYW0uCmRpZmYgLS1naXQg YS9kb2MvZW1hY3MvZW1hY3MudGV4aSBiL2RvYy9lbWFjcy9lbWFjcy50ZXhpCmluZGV4IDU4ZWMz NzMwMjkuLmEzNGNlZjIyMWUgMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9lbWFjcy50ZXhpCisrKyBi L2RvYy9lbWFjcy9lbWFjcy50ZXhpCkBAIC00NDMsOSArNDQzLDcgQEAgVG9wCiAqIFZpc2l0aW5n OjogICAgICAgICAgICBWaXNpdGluZyBhIGZpbGUgcHJlcGFyZXMgRW1hY3MgdG8gZWRpdCB0aGUg ZmlsZS4KICogU2F2aW5nOjogICAgICAgICAgICAgIFNhdmluZyBtYWtlcyB5b3VyIGNoYW5nZXMg cGVybWFuZW50LgogKiBSZXZlcnRpbmc6OiAgICAgICAgICAgUmV2ZXJ0aW5nIGNhbmNlbHMgYWxs IHRoZSBjaGFuZ2VzIG5vdCBzYXZlZC4KLUBpZm5vdHRleAotKiBBdXRvcmV2ZXJ0OjogICAgICAg ICAgQXV0byBSZXZlcnRpbmcgbm9uLWZpbGUgYnVmZmVycy4KLUBlbmQgaWZub3R0ZXgKKyogQXV0 byBSZXZlcnQ6OiAgICAgICAgIEtlZXBpbmcgYnVmZmVycyBhdXRvbWF0aWNhbGx5IHVwLXRvLWRh dGUuCiAqIEF1dG8gU2F2ZTo6ICAgICAgICAgICBBdXRvIFNhdmUgcGVyaW9kaWNhbGx5IHByb3Rl Y3RzIGFnYWluc3QgbG9zcyBvZiBkYXRhLgogKiBGaWxlIEFsaWFzZXM6OiAgICAgICAgSGFuZGxp bmcgbXVsdGlwbGUgbmFtZXMgZm9yIG9uZSBmaWxlLgogKiBEaXJlY3Rvcmllczo6ICAgICAgICAg Q3JlYXRpbmcsIGRlbGV0aW5nLCBhbmQgbGlzdGluZyBmaWxlIGRpcmVjdG9yaWVzLgpkaWZmIC0t Z2l0IGEvZG9jL2VtYWNzL2ZpbGVzLnRleGkgYi9kb2MvZW1hY3MvZmlsZXMudGV4aQppbmRleCA5 OTBiOGYxNjc5Li5jNTFkMDc2ZmEyIDEwMDY0NAotLS0gYS9kb2MvZW1hY3MvZmlsZXMudGV4aQor KysgYi9kb2MvZW1hY3MvZmlsZXMudGV4aQpAQCAtMjUsOSArMjUsNyBAQCBGaWxlcwogKiBWaXNp dGluZzo6ICAgICAgICAgICAgVmlzaXRpbmcgYSBmaWxlIHByZXBhcmVzIEVtYWNzIHRvIGVkaXQg dGhlIGZpbGUuCiAqIFNhdmluZzo6ICAgICAgICAgICAgICBTYXZpbmcgbWFrZXMgeW91ciBjaGFu Z2VzIHBlcm1hbmVudC4KICogUmV2ZXJ0aW5nOjogICAgICAgICAgIFJldmVydGluZyBjYW5jZWxz IGFsbCB0aGUgY2hhbmdlcyBub3Qgc2F2ZWQuCi1AaWZub3R0ZXgKLSogQXV0b3JldmVydDo6ICAg ICAgICAgIEF1dG8gUmV2ZXJ0aW5nIG5vbi1maWxlIGJ1ZmZlcnMuCi1AZW5kIGlmbm90dGV4Cisq IEF1dG8gUmV2ZXJ0OjogICAgICAgICBLZWVwaW5nIGJ1ZmZlcnMgYXV0b21hdGljYWxseSB1cC10 by1kYXRlLgogKiBBdXRvIFNhdmU6OiAgICAgICAgICAgQXV0byBTYXZlIHBlcmlvZGljYWxseSBw cm90ZWN0cyBhZ2FpbnN0IGxvc3Mgb2YgZGF0YS4KICogRmlsZSBBbGlhc2VzOjogICAgICAgIEhh bmRsaW5nIG11bHRpcGxlIG5hbWVzIGZvciBvbmUgZmlsZS4KICogRGlyZWN0b3JpZXM6OiAgICAg ICAgIENyZWF0aW5nLCBkZWxldGluZywgYW5kIGxpc3RpbmcgZmlsZSBkaXJlY3Rvcmllcy4KQEAg LTk1NSw2ICs5NTMsMTEgQEAgUmV2ZXJ0aW5nCiBpcyBub3QgbW9kaWZpZWQuICAoSWYgeW91IGhh dmUgZWRpdGVkIHRoZSB0ZXh0LCBpdCB3b3VsZCBiZSB3cm9uZyB0bwogZGlzY2FyZCB5b3VyIGNo YW5nZXMuKQogCisgIFlvdSBjYW4gYWxzbyB0ZWxsIEVtYWNzIHRvIHJldmVydCBidWZmZXJzIGF1 dG9tYXRpY2FsbHkgd2hlbiB0aGVpcgordmlzaXRlZCBmaWxlcyBjaGFuZ2Ugb24gZGlzazsgQHB4 cmVme0F1dG8gUmV2ZXJ0fS4KKworQG5vZGUgQXV0byBSZXZlcnQKK0BzZWN0aW9uIEF1dG8gUmV2 ZXJ0OiBLZWVwaW5nIGJ1ZmZlcnMgYXV0b21hdGljYWxseSB1cC10by1kYXRlCiBAY2luZGV4IEds b2JhbCBBdXRvIFJldmVydCBtb2RlCiBAY2luZGV4IG1vZGUsIEdsb2JhbCBBdXRvIFJldmVydAog QGNpbmRleCBBdXRvIFJldmVydCBtb2RlCkBAIC05NjIsMjIgKzk2NSwzOSBAQCBSZXZlcnRpbmcK IEBmaW5kZXggZ2xvYmFsLWF1dG8tcmV2ZXJ0LW1vZGUKIEBmaW5kZXggYXV0by1yZXZlcnQtbW9k ZQogQGZpbmRleCBhdXRvLXJldmVydC10YWlsLW1vZGUKLUB2aW5kZXggYXV0by1yZXZlcnQtaW50 ZXJ2YWwKLUB2aW5kZXggYXV0by1yZXZlcnQtcmVtb3RlLWZpbGVzCisKKyAgQSBidWZmZXIgY2Fu IGdldCBvdXQgb2Ygc3luYyB3aXRoIHJlc3BlY3QgdG8gaXRzIHZpc2l0ZWQgZmlsZSBvbgorZGlz ayBpZiB0aGF0IGZpbGUgaXMgY2hhbmdlZCBieSBhbm90aGVyIHByb2dyYW0uICBUbyBrZWVwIGl0 IHVwIHRvCitkYXRlLCB5b3UgY2FuIGVuYWJsZSBBdXRvIFJldmVydCBtb2RlIGJ5IHR5cGluZyBA a2Jke00teCBhdXRvLXJldmVydC1tb2RlfS4KK1RoaXMgYXV0b21hdGljYWxseSByZXZlcnRzIHRo ZSBidWZmZXIgd2hlbiBpdHMgdmlzaXRlZCBmaWxlIGNoYW5nZXMgb24KK2Rpc2suICBUbyBkbyB0 aGUgc2FtZSBmb3IgYWxsIGZpbGUgYnVmZmVycywgdHlwZQorQGtiZHtNLXggZ2xvYmFsLWF1dG8t cmV2ZXJ0LW1vZGV9IHRvIGVuYWJsZSBHbG9iYWwgQXV0byBSZXZlcnQgbW9kZS4KKworICBBdXRv IFJldmVydCB3aWxsIG5vdCByZXZlcnQgYSBidWZmZXIgaWYgaXQgaGFzIHVuc2F2ZWQgY2hhbmdl cywgb3IgaWYKK2l0cyBmaWxlIG9uIGRpc2sgaXMgZGVsZXRlZCBvciByZW5hbWVkLgorCisgIE9u ZSB1c2Ugb2YgQXV0byBSZXZlcnQgbW9kZSBpcyB0byBgYHRhaWwnJyBhIGZpbGUgc3VjaCBhcyBh IHN5c3RlbQorbG9nLCBzbyB0aGF0IGNoYW5nZXMgbWFkZSB0byB0aGF0IGZpbGUgYnkgb3RoZXIg cHJvZ3JhbXMgYXJlCitjb250aW51b3VzbHkgZGlzcGxheWVkLiAgVG8gZG8gdGhpcywganVzdCBt b3ZlIHRoZSBwb2ludCB0byB0aGUgZW5kIG9mCit0aGUgYnVmZmVyLCBhbmQgaXQgd2lsbCBzdGF5 IHRoZXJlIGFzIHRoZSBmaWxlIGNvbnRlbnRzIGNoYW5nZS4KK0hvd2V2ZXIsIGlmIHlvdSBhcmUg c3VyZSB0aGF0IHRoZSBmaWxlIHdpbGwgb25seSBjaGFuZ2UgYnkgZ3Jvd2luZyBhdAordGhlIGVu ZCwgdXNlIEF1dG8gUmV2ZXJ0IFRhaWwgbW9kZSBpbnN0ZWFkCisoQGNvZGV7YXV0by1yZXZlcnQt dGFpbC1tb2RlfSkuICBJdCBpcyBtb3JlIGVmZmljaWVudCBmb3IgdGhpcy4KK0F1dG8gUmV2ZXJ0 IFRhaWwgbW9kZSBhbHNvIHdvcmtzIGZvciByZW1vdGUgZmlsZXMuCisKIEB2aW5kZXggYXV0by1y ZXZlcnQtdmVyYm9zZQotICBZb3UgY2FuIGFsc28gdGVsbCBFbWFjcyB0byByZXZlcnQgYnVmZmVy cyBwZXJpb2RpY2FsbHkuICBUbyBkbyB0aGlzCi1mb3IgYSBzcGVjaWZpYyBidWZmZXIsIGVuYWJs ZSB0aGUgbWlub3IgbW9kZSBBdXRvLVJldmVydCBtb2RlIGJ5Ci10eXBpbmcgQGtiZHtNLXggYXV0 by1yZXZlcnQtbW9kZX0uICBUaGlzIGF1dG9tYXRpY2FsbHkgcmV2ZXJ0cyB0aGUKLWN1cnJlbnQg YnVmZmVyIHdoZW4gaXRzIHZpc2l0ZWQgZmlsZSBjaGFuZ2VzIG9uIGRpc2suICBUbyBkbyB0aGUg c2FtZQotZm9yIGFsbCBmaWxlIGJ1ZmZlcnMsIHR5cGUgQGtiZHtNLXggZ2xvYmFsLWF1dG8tcmV2 ZXJ0LW1vZGV9IHRvIGVuYWJsZQotR2xvYmFsIEF1dG8tUmV2ZXJ0IG1vZGUuICBUaGVzZSBtaW5v ciBtb2RlcyBkbyBub3QgY2hlY2sgb3IgcmV2ZXJ0Ci1yZW1vdGUgZmlsZXMsIGJlY2F1c2UgdGhh dCBpcyB1c3VhbGx5IHRvbyBzbG93LiAgVGhpcyBiZWhhdmlvciBjYW4gYmUKLWNoYW5nZWQgYnkg c2V0dGluZyB0aGUgdmFyaWFibGUgQGNvZGV7YXV0by1yZXZlcnQtcmVtb3RlLWZpbGVzfSB0bwot bm9uLUBjb2Rle25pbH0uCisgIFdoZW4gYSBidWZmZXIgaXMgYXV0by1yZXZlcnRlZCwgYSBtZXNz YWdlIGlzIGdlbmVyYXRlZC4gIFRoaXMgY2FuIGJlCitzdXBwcmVzc2VkIGJ5IHNldHRpbmcgQGNv ZGV7YXV0by1yZXZlcnQtdmVyYm9zZX0gdG8gQGNvZGV7bmlsfS4KKworQHZpbmRleCBhdXRvLXJl dmVydC1yZW1vdGUtZmlsZXMKKyAgVGhlIEF1dG8gUmV2ZXJ0IG1vZGVzIGRvIG5vdCBjaGVjayBv ciByZXZlcnQgcmVtb3RlIGZpbGVzLCBiZWNhdXNlCit0aGF0IGlzIHVzdWFsbHkgdG9vIHNsb3cu ICBUaGlzIGJlaGF2aW9yIGNhbiBiZSBjaGFuZ2VkIGJ5IHNldHRpbmcgdGhlCit2YXJpYWJsZSBA Y29kZXthdXRvLXJldmVydC1yZW1vdGUtZmlsZXN9IHRvIG5vbi1AY29kZXtuaWx9LgogCiBAY2lu ZGV4IGZpbGUgbm90aWZpY2F0aW9ucwogQHZpbmRleCBhdXRvLXJldmVydC11c2Utbm90aWZ5Ci0g IEJ5IGRlZmF1bHQsIEF1dG8tUmV2ZXJ0IG1vZGUgd29ya3MgdXNpbmcgQGRmbntmaWxlIG5vdGlm aWNhdGlvbnN9LAorQHZpbmRleCBhdXRvLXJldmVydC1pbnRlcnZhbAorICBCeSBkZWZhdWx0LCBB dXRvIFJldmVydCBtb2RlIHdvcmtzIHVzaW5nIEBkZm57ZmlsZSBub3RpZmljYXRpb25zfSwKIHdo ZXJlYnkgY2hhbmdlcyBpbiB0aGUgZmlsZXN5c3RlbSBhcmUgcmVwb3J0ZWQgdG8gRW1hY3MgYnkg dGhlIE9TLgogWW91IGNhbiBkaXNhYmxlIHVzZSBvZiBmaWxlIG5vdGlmaWNhdGlvbnMgYnkgY3Vz dG9taXppbmcgdGhlIHZhcmlhYmxlCiBAY29kZXthdXRvLXJldmVydC11c2Utbm90aWZ5fSB0byBh IEBjb2Rle25pbH0gdmFsdWUsIHRoZW4gRW1hY3Mgd2lsbApAQCAtOTkwLDMxICsxMDEwLDIwIEBA IFJldmVydGluZwogCiBAdmluZGV4IGF1dG8tcmV2ZXJ0LWF2b2lkLXBvbGxpbmcKIEB2aW5kZXgg YXV0by1yZXZlcnQtbm90aWZ5LWV4Y2x1ZGUtZGlyLXJlZ2V4cAotICBCeSBkZWZhdWx0LCBBdXRv LVJldmVydCBtb2RlIHdpbGwgcG9sbCBmaWxlcyBmb3IgY2hhbmdlcwotcGVyaW9kaWNhbGx5IGV2 ZW4gd2hlbiBmaWxlIG5vdGlmaWNhdGlvbnMgYXJlIHVzZWQuICBTdWNoIHBvbGxpbmcgaXMKLXVz dWFsbHkgdW5uZWNlc3NhcnksIGFuZCB0dXJuaW5nIGl0IG9mZiBtYXkgc2F2ZSBwb3dlciBieSBy ZWx5aW5nIG9uCi1ub3RpZmljYXRpb25zIG9ubHkuICBUbyBkbyBzbywgc2V0IHRoZSB2YXJpYWJs ZQorICBCeSBkZWZhdWx0LCBBdXRvIFJldmVydCBtb2RlIHdpbGwgcG9sbCBmaWxlcyBmb3IgY2hh bmdlcworcGVyaW9kaWNhbGx5IGV2ZW4gd2hlbiBmaWxlIG5vdGlmaWNhdGlvbnMgYXJlIHVzZWQu ICBQb2xsaW5nIGlzCit1bm5lY2Vzc2FyeSBpbiBtYW55IGNhc2VzLCBhbmQgdHVybmluZyBpdCBv ZmYgbWF5IHNhdmUgcG93ZXIgYnkKK3JlbHlpbmcgb24gbm90aWZpY2F0aW9ucyBvbmx5LiAgVG8g ZG8gc28sIHNldCB0aGUgdmFyaWFibGUKIEBjb2Rle2F1dG8tcmV2ZXJ0LWF2b2lkLXBvbGxpbmd9 IHRvIG5vbi1AY29kZXtuaWx9LiAgSG93ZXZlciwKIG5vdGlmaWNhdGlvbiBpcyBpbmVmZmVjdGl2 ZSBvbiBjZXJ0YWluIGZpbGUgc3lzdGVtczsgbWFpbmx5IG5ldHdvcmsKIGZpbGUgc3lzdGVtIG9u IFVuaXgtbGlrZSBtYWNoaW5lcywgd2hlcmUgZmlsZXMgY2FuIGJlIGFsdGVyZWQgZnJvbQotb3Ro ZXIgbWFjaGluZXMuICBUbyBmb3JjZSBwb2xsaW5nIHdoZW4KK290aGVyIG1hY2hpbmVzLiAgRm9y IHN1Y2ggZmlsZSBzeXN0ZW1zLCBwb2xsaW5nIG1heSBiZSBuZWNlc3NhcnkuCitUbyBmb3JjZSBw b2xsaW5nIHdoZW4KIEBjb2Rle2F1dG8tcmV2ZXJ0LWF2b2lkLXBvbGxpbmd9IGlzIG5vbi1AY29k ZXtuaWx9LCBzZXQKIEBjb2Rle2F1dG8tcmV2ZXJ0LW5vdGlmeS1leGNsdWRlLWRpci1yZWdleHB9 IHRvIG1hdGNoIGZpbGVzIHRoYXQKIHNob3VsZCBiZSBleGNsdWRlZCBmcm9tIHVzaW5nIG5vdGlm aWNhdGlvbi4KIAotICBPbmUgdXNlIG9mIEF1dG8tUmV2ZXJ0IG1vZGUgaXMgdG8gYGB0YWlsJycg YSBmaWxlIHN1Y2ggYXMgYSBzeXN0ZW0KLWxvZywgc28gdGhhdCBjaGFuZ2VzIG1hZGUgdG8gdGhh dCBmaWxlIGJ5IG90aGVyIHByb2dyYW1zIGFyZQotY29udGludW91c2x5IGRpc3BsYXllZC4gIFRv IGRvIHRoaXMsIGp1c3QgbW92ZSB0aGUgcG9pbnQgdG8gdGhlIGVuZCBvZgotdGhlIGJ1ZmZlciwg YW5kIGl0IHdpbGwgc3RheSB0aGVyZSBhcyB0aGUgZmlsZSBjb250ZW50cyBjaGFuZ2UuCi1Ib3dl dmVyLCBpZiB5b3UgYXJlIHN1cmUgdGhhdCB0aGUgZmlsZSB3aWxsIG9ubHkgY2hhbmdlIGJ5IGdy b3dpbmcgYXQKLXRoZSBlbmQsIHVzZSBBdXRvLVJldmVydCBUYWlsIG1vZGUgaW5zdGVhZAotKEBj b2Rle2F1dG8tcmV2ZXJ0LXRhaWwtbW9kZX0pLiAgSXQgaXMgbW9yZSBlZmZpY2llbnQgZm9yIHRo aXMuCi1BdXRvLVJldmVydCBUYWlsIG1vZGUgd29ya3MgYWxzbyBmb3IgcmVtb3RlIGZpbGVzLgot Ci0gIFdoZW4gYSBidWZmZXIgaXMgYXV0by1yZXZlcnRlZCwgYSBtZXNzYWdlIGlzIGdlbmVyYXRl ZC4gIFRoaXMgY2FuIGJlCi1zdXBwcmVzc2VkIGJ5IHNldHRpbmcgQGNvZGV7YXV0by1yZXZlcnQt dmVyYm9zZX0gdG8gQGNvZGV7bmlsfS4KLQotICBJbiBEaXJlZCBidWZmZXJzIChAcHhyZWZ7RGly ZWR9KSwgQXV0by1SZXZlcnQgbW9kZSByZWZyZXNoZXMgdGhlCisgIEluIERpcmVkIGJ1ZmZlcnMg KEBweHJlZntEaXJlZH0pLCBBdXRvIFJldmVydCBtb2RlIHJlZnJlc2hlcyB0aGUKIGJ1ZmZlciB3 aGVuIGEgZmlsZSBpcyBjcmVhdGVkIG9yIGRlbGV0ZWQgaW4gdGhlIGJ1ZmZlcidzIGRpcmVjdG9y eS4KIAogICBAeHJlZntWQyBVbmRvfSwgZm9yIGNvbW1hbmRzIHRvIHJldmVydCB0byBlYXJsaWVy IHZlcnNpb25zIG9mIGZpbGVzCi0tIAoyLjIwLjEKCg== --=-rrD2ikn2e81wcl0D1j3F-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155697729222228 (code B ref 35418); Sat, 04 May 2019 13:42:01 +0000 Received: (at 35418) by debbugs.gnu.org; 4 May 2019 13:41:32 +0000 Received: from localhost ([127.0.0.1]:50601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMuux-0005mR-SQ for submit@debbugs.gnu.org; Sat, 04 May 2019 09:41:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMuuw-0005mE-Lx for 35418@debbugs.gnu.org; Sat, 04 May 2019 09:41:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMuur-0000kj-Aw; Sat, 04 May 2019 09:41:25 -0400 Received: from [176.228.60.248] (port=2752 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hMuuq-0001Ru-Q1; Sat, 04 May 2019 09:41:25 -0400 Date: Sat, 04 May 2019 16:41:09 +0300 Message-Id: <83o94il4lm.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sat, 04 May 2019 13:21:19 +0200) References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Cc: michael.albinus@gmx.de, 35418@debbugs.gnu.org > Date: Sat, 04 May 2019 13:21:19 +0200 > > Thanks again; revised patch attached. LGTM, thanks. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 16:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15569888029509 (code B ref 35418); Sat, 04 May 2019 16:54:01 +0000 Received: (at 35418) by debbugs.gnu.org; 4 May 2019 16:53:22 +0000 Received: from localhost ([127.0.0.1]:52109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMxuc-0002TI-4v for submit@debbugs.gnu.org; Sat, 04 May 2019 12:53:22 -0400 Received: from mout.gmx.net ([212.227.17.20]:50923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMxuZ-0002T1-IN for 35418@debbugs.gnu.org; Sat, 04 May 2019 12:53:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556988789; bh=Hb114H5I6hAWjJXBT+CZo9i+PGidRyDifdC3OYaWJAo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=RtW3bRY7d+3787RUyh0txlIvfMxAoEKNrxnhYh8aCKaqyyJUsUK1BTq/MGOKYQfWp NA9u5FES5oZvEIP4B7603oMBeLutEEGAzsB9djhmNC0XuF6hNrXlUai2xMntte4osO QFM2BW1I45joz7+cAofp1Nfn013vPb+E36BnxhFo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.57.229]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MLR1f-1h5ZLj3EH5-00IQPA; Sat, 04 May 2019 18:53:08 +0200 From: Michael Albinus References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> Date: Sat, 04 May 2019 18:53:07 +0200 In-Reply-To: <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Sat, 04 May 2019 13:21:19 +0200") Message-ID: <87y33mgo0c.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:8HKyolNFtfdlLpE1cWV3LpiVtoFRPU2Zq8Sfp9NAr5yLXqGqi4e TiXfgQalUQE278Z7XIab1cEfrJpSVrcGN+G8Xmg6AEtolvJTD1QXSi2+huAOdzgdDAkDX+I 1bXEhejcrCxL+nYNNfh0Kvda6h707tKRkFz7KPCJgNTemRUS8bRgXlVvCu7b4hvObjBtnnG Rh+DM37Ku3SlRZWCUNTyQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:0yXWFs3mYCI=:iRnJexLcuRMsk9slbIlnjp h1Q/1lIc46saJ2Ia1SkJtfWmSpq/g6L/RL7gmu02LY7U9+w7ZbmWHDNDi3kDqIa/sviT2/AVO 3e/LWRIsRyf3CPv8rWaIkOHzoV3cYPqY9eZcSzrV47uS+KQpRz07a3EE2+QLfajmeRny+wPqB LIFYC7gdfHl1Dce5TSNNQDffk5dyq8CVSRU/kf6Yh1QQ41BMP+Kd4+lkFwkFLpGRzF+qVc9iy 6ozwDnW/sWx2jMF4y7Kc+/UBJ4YrDpW0fTDG+av4XcHFibZdg0RJEBGwJsJHRsaoYJGAnfKmm vQyy+YVQd6nXqmos8aap+3aa1V/AkKBTbSxgTYorZAXh3M+0GZn+XF+0zclqUx1zj6MhJGIpy k/6FVB/9Lz9Bwh8W4Cs6DX4vp28o0G8TknC9MkjICL50JFGqiRmhvKOIRbybtgGbYhvpG0m9P TSUQFGBha7LPzBJu4CFCq1eYxvUnv8/IFFSwgTrF08UURNiCcQdInyOt2U0ZJM8TXug9/35mg +l1k2tZsTqaoidOSlNtDS/uQNa2l0YZ6XQlMf4wtqUg/X1xIvuELpLyXwshjGXMfDlsDdGynE MxaonDf247FPfv58KekMbFywnvW/b1gW3BYkXm4DcID8Q0GZPga1/E02tB1uVQMUQAL2AXXY/ kYGLPssPGuTF1OaRgBFu5OXnET38/eSX1vL9YSg25Z2Qgw5k4lMVUmc/ZgCozQpYPDymsVTEy Wmx8ihnEgZRYYSP2ZlkZlsZ58a5EGvs7YGLuQSfUTw/n4b8aT+or05Z5EOxU5Ma1nBngGBJN8 Os/dhB0b8HSp+xmishZ/a9MWJ/ec1tJpHlNv0Mpx/0AkOwBGM8aSMbf0zo27lVSlI5ArC2L8v 6h78htx/SCbeokxzJRqEAcp+vmhCZvks93l1LZYoUBvBLGyN5Y0IHbyMF7ek0eUnvM9wFcUE1 39hU+5Iuwng== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, > + By default, Auto Revert mode will poll files for changes > +periodically even when file notifications are used. Polling is > +unnecessary in many cases, and turning it off may save power by > +relying on notifications only. To do so, set the variable > @code{auto-revert-avoid-polling} to non-@code{nil}. However, > notification is ineffective on certain file systems; mainly network > file system on Unix-like machines, where files can be altered from > +other machines. For such file systems, polling may be necessary. Maybe we could also add the other major reason why polling is necessary: file notification is not supported for all types of remote file systems (Tramp). Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: mattiase@acm.org, 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155698973311018 (code B ref 35418); Sat, 04 May 2019 17:09:01 +0000 Received: (at 35418) by debbugs.gnu.org; 4 May 2019 17:08:53 +0000 Received: from localhost ([127.0.0.1]:52129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMy9d-0002re-BG for submit@debbugs.gnu.org; Sat, 04 May 2019 13:08:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMy9c-0002rQ-57 for 35418@debbugs.gnu.org; Sat, 04 May 2019 13:08:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMy9W-0004ki-NF; Sat, 04 May 2019 13:08:46 -0400 Received: from [176.228.60.248] (port=3885 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hMy9W-0005jO-1D; Sat, 04 May 2019 13:08:46 -0400 Date: Sat, 04 May 2019 20:08:38 +0300 Message-Id: <83bm0ikuzt.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87y33mgo0c.fsf@gmx.de> (message from Michael Albinus on Sat, 04 May 2019 18:53:07 +0200) References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: Eli Zaretskii , 35418@debbugs.gnu.org > Date: Sat, 04 May 2019 18:53:07 +0200 > > Maybe we could also add the other major reason why polling is necessary: > file notification is not supported for all types of remote file systems > (Tramp). Yes, I think all the reasons should be mentioned, so that users who disable polling know what they are/will be losing, and could make educated decisions. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 18:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155699582729793 (code B ref 35418); Sat, 04 May 2019 18:51:02 +0000 Received: (at 35418) by debbugs.gnu.org; 4 May 2019 18:50:27 +0000 Received: from localhost ([127.0.0.1]:52282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMzju-0007kR-Si for submit@debbugs.gnu.org; Sat, 04 May 2019 14:50:27 -0400 Received: from mail158c50.megamailservers.eu ([91.136.10.168]:45504 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMzjr-0007kH-Lz for 35418@debbugs.gnu.org; Sat, 04 May 2019 14:50:24 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556995821; bh=P/5zOgU+XquOoVXZInIOF236pFQjSzYKVNLyo1QSu5s=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=bz0cezdSs6IlUameu39BUgUZGyL4K4fWpPWi/RQfYu7b4aiAOT3zLeuqZQrwGR3Vb nfzBVtMEe+9JnS9Qi1HK2gZJjAsN4f/4Ky2oXd24cDdD8hWru75Ij+n0d21Jqk2VDn KJX8j+UxtK6mPzqQ2RslbRRHJeQmxg3GWYJPe88c= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x44IoJB2021853; Sat, 4 May 2019 18:50:21 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <87y33mgo0c.fsf@gmx.de> Date: Sat, 4 May 2019 20:50:18 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B020D.5CCDDEED.004F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=K6UM4ReI c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=D2YamafkVjz66ngqovYA:9 a=RUZkA62QJcOUmZAQ:21 a=B_mYlXagJ_3FJVcU:21 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 4 maj 2019 kl. 18.53 skrev Michael Albinus : >=20 > Maybe we could also add the other major reason why polling is = necessary: > file notification is not supported for all types of remote file = systems > (Tramp). Is the problem that notification over Tramp may fail to activate or = suddenly fail functioning, in both cases without any indication of error = to file-notify? If so, we should take care of this in code instead. Assuming the above, = I suggest that file-notify consider all notification from file name = handlers to be unreliable, and provide an interface to auto-revert, = which will then keep polling those files. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 19:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15569990232976 (code B ref 35418); Sat, 04 May 2019 19:44:02 +0000 Received: (at 35418) by debbugs.gnu.org; 4 May 2019 19:43:43 +0000 Received: from localhost ([127.0.0.1]:52352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN0ZT-0000lw-By for submit@debbugs.gnu.org; Sat, 04 May 2019 15:43:43 -0400 Received: from mout.gmx.net ([212.227.17.20]:52245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN0ZR-0000lf-ES for 35418@debbugs.gnu.org; Sat, 04 May 2019 15:43:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556999011; bh=vNYwCvRRxshfgrqyfUhNfX77MmWo0hT65LuOE4So8eE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ANKbUsCtkHhIiWH+2cusXmB4lIBQyElq9ZPqKtJne2y6/goHn651KxYOHaq16YT+c +c4BLJNohqk+bsfJc9UffJa0P9cQjNCTNGy8SbO/7qdrsi8NJMVHhfx/WlrYEywf85 GHP63Sui7IpZ82xLzqRmGE3xr4YXNJqCBMUgQCkE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.57.229]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MhD2Y-1gsddJ2CpO-00eNRe; Sat, 04 May 2019 21:43:31 +0200 From: Michael Albinus References: <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> Date: Sat, 04 May 2019 21:43:28 +0200 In-Reply-To: <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Sat, 4 May 2019 20:50:18 +0200") Message-ID: <87tveagg4f.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:IzQPE3bcRVz+iEI7HtMtR5q8jTjwZZhQqa90DhldPGy5RiocOT8 MXmUYtAUE2TSlICQ8wejACnZVeQeU/cF+PjfKIWiUT9FR7SJP6wrr9HDn5A5iDcjOg4RIJZ +hnmy0PCAV3HFsmupCwjB245p8w4w5H/FF5GmK5KnHS/6woEg/hQO1nzsB3yJI6Br6Rxvih YOcHb3nyZ6zZPmMMxfCUg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:FDtQPjx0s2A=:XYRLtJnbUrmC64aWN60FoE wVjD1f0AojXLN0gwZq4vs6wl690qTc/CAxpOOWu2Qw0YqBXzCpO7J8I/h6Y9DXqkg8h8mz/0L 5Q/brOoJTMnvBDK4VbOHNXCqWCdci5/xh2leTWRw3DGFmpP2YNoH6nCCg+iKwrxr98Y/fn78H aFeMtnt3wQiQejxRvuQiDto/x6ujSd6Qgh0hzrqpq2W4lzddZp/ti1uac97xBltVEaM92kXDi KKJrv+qLzrePdKwMFU/2Itwlr9iyZl9kzQFVwLKNk82klvjrqG+ZwqbzQF4MCX+Vf8P+aPJnq v0bfKBYDcD8gEk/VXSCMlKSs/8DHzoCeReFIR6scrAsVVENSW1b9VtNHjVgzl5GgaTBa4iY4O beoGWKnikcu35z2oxfoO1IsksGYm7Cc1cuNV3YkFhavK7tqPk3p+N8JOfKhJ6Kkk0p7On5SIr Uf+xgylImjl3n2//DZJPkM6OeNzjfuOc86cFG4Wxd1wnSaR3FtyEVDSk/8iSuriO3+qonZL0v yyyql9uD9OJCq8oakleEECOdbI2TIpWrUOV+N1VMZTP0I0lRAW9enZD2oVHcCPVZEcU60r+nX M63KajOdVlngJmvwzbSfAf5zwiY1UE5VgSJJDEt66tyjHmNeRyvaznEIWgNiG1gwHjCrs/Gyk NlubQLp+tp1LEvblzHDZhg3uTjovD9rX2V+KOVRXgi6SmgORz/EuUVC4wsg+Sp6zX1xRTPimd S4FxDQh0llZUSh1PDlP6+xx5PBnt2457UZ7Wz/Owye2W7mi9rO71UHRU/LfepOIToJgoaQH+L AzUR8ifOEqlisAzbdpYq9NZ9E2vY8IcN5pkbMJgd3pv9mwWRNrphHd2pOv81iKN5feqqv/nip 5L9Prebft4i7MwhsCEgAjyzMR42+7QMjYuZX0UxXC19D/ywsTYMZ8lFD9czVEkwLaiQFGR/Iu qsPTl4ZxzFw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, >> Maybe we could also add the other major reason why polling is necessary: >> file notification is not supported for all types of remote file systems >> (Tramp). > > Is the problem that notification over Tramp may fail to activate or > suddenly fail functioning, in both cases without any indication of > error to file-notify? Yes we have both cases. But file-notify is told about. The first case is that file notification cannot be activated. Several Tramp methods do not support this, and they return nil for the respective file-notify-add-watch call, as specified. auto-revert understands this, and knows that the respective file must be handled by polling. The second case is, that file notification for a remote file ceases to work. Since Tramp implements file notification as asynchronous processes, this could happen if the respective process is killed on the remote side, or if the connection between the local Emacs and the remote host is broken temporarily. The respective process shall own a sentinel, which sends a "stopped" event in this case. I've just checked the code; this is not implemented. Will do. > If so, we should take care of this in code instead. Assuming the > above, I suggest that file-notify consider all notification from file > name handlers to be unreliable, and provide an interface to > auto-revert, which will then keep polling those files. We have this interface already. For file-notify-add-watch it works already as expected. For broken notifications, the interface is the "stopped" event, which must (will be) implemented in Tramp. Btw, I believe all this file notification vs polling behavior is not covered yet in autorevert-tests.el. Would you like to add respective test cases for local and remote files? Some days ago I've added tests for remote files; you could use this mechanism as well. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 20:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155700187816915 (code B ref 35418); Sat, 04 May 2019 20:32:01 +0000 Received: (at 35418) by debbugs.gnu.org; 4 May 2019 20:31:18 +0000 Received: from localhost ([127.0.0.1]:52401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN1JV-0004Ok-QB for submit@debbugs.gnu.org; Sat, 04 May 2019 16:31:18 -0400 Received: from mout.gmx.net ([212.227.17.20]:41071) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN1JT-0004OV-Sz for 35418@debbugs.gnu.org; Sat, 04 May 2019 16:31:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557001865; bh=fTg1Akc4ivOc68vgHNLfbr0UW4XF4KZeAMHizVVZYNc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=fTMhqr+OGtwo1aBRbMeZ5TCEbk/xb6NIuopyM6b9oE7FkTNPNa6lTSRk/93IxU3b4 Z2PCAEfd3A7fp+RyF1xHSlpg/d8FddMoXZCP7zapvE2NcoBVs2Yq3odCDu1bafBLHE SzgNQqlp2reEOu3Wy7GZbPfwIPheaufORCfZivmU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.57.229]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LpKY5-1gqglp466f-00fCMR; Sat, 04 May 2019 22:31:05 +0200 From: Michael Albinus References: <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> Date: Sat, 04 May 2019 22:31:01 +0200 In-Reply-To: <87tveagg4f.fsf@gmx.de> (Michael Albinus's message of "Sat, 04 May 2019 21:43:28 +0200") Message-ID: <87pnoygdx6.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:kXXtxU2TecsK4ngvM0UFxTaoKY1WQdpMkSFdCLljTOJHezbZF7S cbkeFE1eBAV0ioH23iJ8YiFkm0YHkvExE+7KLWfgd7QsXe876G8FN48MUXyvpt8w976HGrm ZQ8B5MPzMuOo4ezLrBCRFnZg3mNPFHikcL37GZKuMhKV3iR+UvxhAiCJi6dxnbitv42oVcl +jcISoVsaQX6lZ827kRAg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:nsk6d9cJuNo=:v1n2tT+58lNBMsWn+7vPuh BVTaGdrdRRAAuEytSVetBZF3DN3otRjDL2pG7zjzkCvy+UH1nuf4wh0XNDOUV1r5UA6R/lHJx Qa78PJPfB0QENi4baS8FCdUo/fZBDbE/2ZlWvV9KLUw6b7toxFPS1rxO4gQjWTpkJGrhO0cFd EFUH5HYeBB9/K4hWXKQ5kmTu6A0ENn7fVaB0DO7HVyBWRwylDZjcPki00vwIIYaWQcLXsu0w5 33CpoNEgOyK1+wYqP/DfLgwSrMNa52F4T+U6DotAS53pECecQ6IEG8l0r9QoZXSI9ialkZCax nzG5bYHy75fxlWGIAGJ9fDkY83lRKzFvZc0Bt+xElIm3zpuJmBHeW5gGiNiuWWYTsBt9/Tprb t4XSiFl2odZW2abFv8Xaz0lv/dz0nhKDTv+LsQsU7lURwh0E7Q1XIBWfeR6EsG7fZJZVWMNZg INA67d+XztYmVhv0lYOha6XO0HPlcV7wyvcytG9bchUY4v2ZJNx280t/qywiQpwOwnuUdOAqf hO0nizhgk7gMcQ5tUvAfX6tAxW0d/BA8z7IO2gM+OcABlmrQWFqtxlzmoe26bYpHggY4UHVEq V1Yq34ZjPzg6hEB7GMh0F9ywRK1L4v3l+j8YdkUH/uWALhwedQIQ9Bmn2JCgC58qAtYTMifFA HDD5c+EEOLYGowtKuOcIEmikrmGhb62m4354mBAf2YjlOg7j+/KrY2HTcbG5L4PeBmPLzfaIq NhUJnNzGSbX9EAA0B9Vxg57E16FxwfOpwJYRvfWL8d2l24iSG9WzOsaHlqx70Gyy0iXsaQ+BZ +TsBIQfUrjLk7K3ZovP9qLax+vkVMB+fYwQSswJPI96u1S7ps1K5EyveVCm5hQry9EhUUFef8 gFDIXXkuERnDwz7thNzL+qOYC7YBqJJcEcAbV0xZQyR5qb3d+uIwIK3gs3DAys0tqM/mJijs+ 8Qb6DpUSqug== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Albinus writes: Hi Mattias, > The second case is, that file notification for a remote file ceases to > work. Since Tramp implements file notification as asynchronous > processes, this could happen if the respective process is killed on the > remote side, or if the connection between the local Emacs and the remote > host is broken temporarily. The respective process shall own a sentinel, > which sends a "stopped" event in this case. I've just checked the code; > this is not implemented. Will do. Implemented, pushed to master. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 20:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155700278518456 (code B ref 35418); Sat, 04 May 2019 20:47:02 +0000 Received: (at 35418) by debbugs.gnu.org; 4 May 2019 20:46:25 +0000 Received: from localhost ([127.0.0.1]:52419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN1Y9-0004nb-2W for submit@debbugs.gnu.org; Sat, 04 May 2019 16:46:25 -0400 Received: from mail79c50.megamailservers.eu ([91.136.10.89]:46870 helo=mail70c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN1Y4-0004nP-27 for 35418@debbugs.gnu.org; Sat, 04 May 2019 16:46:21 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557002778; bh=eGos5RrXKF3XJkC7yHBTSP9mzpD6cJDUXdynmxGk558=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=qxlwzT9AXhOXrDLohJo8c2ql43Vxc+u5bK2mg47OyDhgKN1sZ5uvthfjPNfONoa79 nkoPJtnyzFDrJiDsN5LH8Mkne6S3g6FO3FS4EAVE+p/FzJBOJhXFTTO54TuqWsOs9i SkGK4zDJbYubtoBCvlomkg2FwO7UUxoPTJksdtjk= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x44KkGHC027034; Sat, 4 May 2019 20:46:17 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <87pnoygdx6.fsf@gmx.de> Date: Sat, 4 May 2019 22:46:15 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> References: <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0212.5CCDFA1A.0017, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=K68M4ReI c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=BIPJLwLJrqw7iCCNM1cA:9 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 4 maj 2019 kl. 22.31 skrev Michael Albinus : >=20 >> The second case is, that file notification for a remote file ceases = to >> work. Since Tramp implements file notification as asynchronous >> processes, this could happen if the respective process is killed on = the >> remote side, or if the connection between the local Emacs and the = remote >> host is broken temporarily. The respective process shall own a = sentinel, >> which sends a "stopped" event in this case. I've just checked the = code; >> this is not implemented. Will do. >=20 > Implemented, pushed to master. Nice, thank you! Does this mean that we can trust Tramp sufficiently in = this respect? That is, notifiers will either fail to be created, fail = with a 'stopped' event, or work. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 May 2019 08:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15570445492811 (code B ref 35418); Sun, 05 May 2019 08:23:01 +0000 Received: (at 35418) by debbugs.gnu.org; 5 May 2019 08:22:29 +0000 Received: from localhost ([127.0.0.1]:52939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNCPl-0000jH-9o for submit@debbugs.gnu.org; Sun, 05 May 2019 04:22:29 -0400 Received: from mout.gmx.net ([212.227.15.15]:49003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNCPi-0000j1-RG for 35418@debbugs.gnu.org; Sun, 05 May 2019 04:22:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557044536; bh=G6BjgxduF4unWGNwC21lbpaqXKURxIeoDOHlwq41d+c=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=l1I66J4XZpZBnnM4c/rFiJ/BVg6JWtuWAdN1NfR/7SXMQ1r29NJXhjGL18Q9mJT06 SFl+Pd6vyk5C+XvWUJleRQppL/regznVm9zfFKKuxqCvLQg3YXcOkygWZ96Lx9sfog 2MDZOHf5i5UagNr2HH54qaaHyoi2anzD0AXCpBAg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.57.229]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Me8di-1h6BvF44lC-00PsvH; Sun, 05 May 2019 10:22:16 +0200 From: Michael Albinus References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> Date: Sun, 05 May 2019 10:22:13 +0200 In-Reply-To: <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Sat, 4 May 2019 22:46:15 +0200") Message-ID: <87lfzlgvka.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:VMWqCXJ0mR1NtW8hxMiksPoOykiRcyKv+WDUiBc6ihI01pvxKyr VK9T2CltddkYG3B6muhrsrdhqQhc6aF59LZiP16++BrB8gMgMlwxViXVItFtgrETdzOjpuh JM2TDcmvTqmcuqw18Oe32O+ebWgBWerSF+ni4QUrjV7Agd6rsyauouuxZ8PoCSsVPSCpK9Z Eyc7oAZxS6dZQk/VPOFQg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:vEzPmoYIYg4=:uwIf5795XQDGycFWHdVHTt KaUjS0Nn0+Bk8Bu4OB2vXzTkE8HhyuCVNiL7FgQXKKyw+Nhos3xY91nmyPuGKJBdUmjpkfHDt LjEQka7HMqUiE9VnkPbhuCGIr+XkCj05VDQH222uNTlXOlhdsnazzY/CtQXqVT4Hi/fSpdg0e gbqDzlrz4FiGb1uZE4/yRRZEld4klA/6V4RJHMiHjnHozh2vJwj9Uoyu1763p37zjnwQRASyX n6HRxXDYy3gL4YnyMsv9Fx435Q2TF1+h3L0qA8nfuPmjaFxr15pHOfECRWacVmFQfhgHuEyvU Zxe4Md//H2PKb3VsJr1fYkVcaxpjf2NxYgCss7zdapyh0Yz4bUeAO021y3C0IV1Urag05BOyA NXex+W+ZuT1KWFdQskEwAzDRT+w1WO5Sdb1/9f12UFQ43gF3kyLUK3FqJwNPmEOU79oHHwHu5 gkMtBDG8joPkN6O0GKJdGEaBrU0uXkgLBftrWzG+FwpWQktlaE6IEJYr2R7MQJsP8W1327dPB hD2NMhI8+nftWvmNrersu5SoxHHaJ480R7UKqXQun8WY93GmvLbL7OKtIlD1BA4mjndotAHR2 HftvZBJk47fY7W9EfGJicPy3m4SgVnm/xxfgcoG5pFKXJF9gEdq2Lwcbu+XSOmPE7CaTSOOb0 67RQnmNb+s4iWWTVTq/IIsNe0kdfUcQYbOA43JAacQ2sJeCgiEiVwNEkv7tZZJW3frsloBoK6 VI459HrP3rkK3EtUBMGcaKftoQW6VbmrDWMPsOIxQBjpMtSEIiOp9EjYzhhq1yH5jHGUW0MMq UqNsQgIo/Wqnr87XPKJbKZOIJUzp0zxP+hdmPUMceykZqOGRUg1wAyXAfjesaeUgzGWIINhxg /ayCw9U8FYLN6uqXlA9akIu2xWVPPvxUS99kTYG1lyXnwdmw6X+nV3rvnrqXk6d6My5Gzur9w aotCgf7jP8Q== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, > Nice, thank you! Does this mean that we can trust Tramp sufficiently > in this respect? That is, notifiers will either fail to be created, > fail with a 'stopped' event, or work. Yes, I think so. Until the next bug report :-) Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 May 2019 09:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155705030412388 (code B ref 35418); Sun, 05 May 2019 09:59:01 +0000 Received: (at 35418) by debbugs.gnu.org; 5 May 2019 09:58:24 +0000 Received: from localhost ([127.0.0.1]:52989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNDua-0003Dk-FC for submit@debbugs.gnu.org; Sun, 05 May 2019 05:58:24 -0400 Received: from mail156c50.megamailservers.eu ([91.136.10.166]:53108 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNDuX-0003DX-I8 for 35418@debbugs.gnu.org; Sun, 05 May 2019 05:58:23 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557050299; bh=oS8UUfUqDhmg7zQubmfNX3GnyCY/bt8P8rTsNdbu8io=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=GbT+Qu9OXgcdCEk/Fmv/huOCdbhAu3Iy1GwG2Glrx6N5iBOVeNKQh21wkc96RMCrS WcKnjcfCqfjnmeb56ITz/gk3iXL5xgA8vZLN5PMosp2r00I+E23Y81NAOMyjaCJ2// pecrYyOlSzMVhcl/Qsx9GtXFnmoeLFmelYPo8VLY= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x459wGAX027004; Sun, 5 May 2019 09:58:18 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <87lfzlgvka.fsf@gmx.de> Date: Sun, 5 May 2019 11:58:16 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0208.5CCEB3BB.0009, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=K6UM4ReI c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=XbhXUdGdYMD1UBjVmVsA:9 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 5 maj 2019 kl. 10.22 skrev Michael Albinus : >=20 >> Nice, thank you! Does this mean that we can trust Tramp sufficiently >> in this respect? That is, notifiers will either fail to be created, >> fail with a 'stopped' event, or work. >=20 > Yes, I think so. Until the next bug report :-) Good. I've pushed the manual update. What remains is avoiding polling in global-auto-revert-mode. I'll send a = patch soon. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 08:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155730446128268 (code B ref 35418); Wed, 08 May 2019 08:35:01 +0000 Received: (at 35418) by debbugs.gnu.org; 8 May 2019 08:34:21 +0000 Received: from localhost ([127.0.0.1]:60294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOI1t-0007Ls-Ak for submit@debbugs.gnu.org; Wed, 08 May 2019 04:34:21 -0400 Received: from mail230c50.megamailservers.eu ([91.136.10.240]:35096 helo=mail37c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOI1q-0007Lh-CJ for 35418@debbugs.gnu.org; Wed, 08 May 2019 04:34:19 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557304456; bh=zz+HIDiCTCnrWnFe2D/vIzaKVyLFYJUpJ/fBvU8TLKw=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=GU93R1UUVtYuKZXGoiXfwSAtPwT5YUCJaW+UdGqjGs5ChgI9QE4Os9IA9v0D5UNaq /9UEGED3KzY4ApiP2Rl9Nz6BU+LlSF5X5odXJPqzEsMCNqy8RWbWm9Q3he09stn3oR qEpjDtJxcWYqgoJLOOLgBINqNHW1gM/STcMiobRI= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x488YE7m015086; Wed, 8 May 2019 08:34:15 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_3B40BEB5-A187-44B9-8147-0B2C064C716B" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Date: Wed, 8 May 2019 10:34:13 +0200 In-Reply-To: <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B020B.5CD29488.0029, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=ItQwjo3g c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=0Cmo_GCdd-s-yunitmsA:9 a=CjuIK1q_8ugA:10 a=ausD_beliIWWzayK3jAA:9 a=B2y7HmGcmWMA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_3B40BEB5-A187-44B9-8147-0B2C064C716B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Here is a detail that needs to be taken care of: we should not use = notification on non-file buffers, since that is generally useless = (consider the Buffer List buffer) and, with `auto-revert-avoid-polling', = prevents these buffers from being polled and thus updated at all. Patch attached. There is a hack for Dired buffers, since watching their = directories happens to be just what we want. It would be nice to = generalise this condition somehow, but meanwhile this will have to do, = unless you can come up with something better. A patch for global-auto-revert-mode will come shortly. --Apple-Mail=_3B40BEB5-A187-44B9-8147-0B2C064C716B Content-Disposition: attachment; filename=0001-Don-t-use-file-notification-on-non-file-buffers.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Don-t-use-file-notification-on-non-file-buffers.patch" Content-Transfer-Encoding: quoted-printable =46rom=2023f8e60c110a372530a839948d7b17598517d928=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Wed,=208=20May=202019=2000:02:59=20+0200=0A= Subject:=20[PATCH]=20Don't=20use=20file=20notification=20on=20non-file=20= buffers=0A=0AMost=20non-file=20buffers=20aren't=20served=20by=20file=20= notification=20in=0Aauto-revert=20mode;=20typically,=20they=20need=20to=20= be=20polled,=20like=20the=20Buffer=20List.=0AWith=20= `auto-revert-avoid-polling',=20setting=20a=20useless=20notification=20= means=0Athat=20such=20buffers=20may=20never=20be=20updated=20at=20all=20= (bug#35418).=0A=0AAn=20exception=20is=20made=20for=20Dired,=20as=20that=20= mode=20works=20well=20with=0Anotification=20on=20the=20directory.=0A=0A*=20= lisp/autorevert.el=20(auto-revert-buffers):=0AModify=20condition=20for=20= using=20notification.=0A---=0A=20lisp/autorevert.el=20|=208=20+++++++-=0A= =201=20file=20changed,=207=20insertions(+),=201=20deletion(-)=0A=0Adiff=20= --git=20a/lisp/autorevert.el=20b/lisp/autorevert.el=0Aindex=20= 7cd5e7ee8b..5a62b5f6b9=20100644=0A---=20a/lisp/autorevert.el=0A+++=20= b/lisp/autorevert.el=0A@@=20-858,8=20+858,14=20@@=20the=20timer=20when=20= no=20buffers=20need=20to=20be=20checked."=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(auto-revert-remove-current-buffer))=0A=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(when=20(auto-revert-active-p)=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20Enable=20file=20= notification.=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20= Don't=20bother=20creating=20a=20notifier=20for=20non-file=20buffers=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20if=20there=20is=20a=20= custom=20`revert-buffer-function'.=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20;;=20An=20exception=20is=20made=20for=20Dired,=20since=20= that=20mode=20works=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= ;;=20well=20with=20notifiers.=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(when=20(and=20auto-revert-use-notify=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(not=20= auto-revert-notify-watch-descriptor))=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(not=20= auto-revert-notify-watch-descriptor)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(or=20buffer-file-name=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(eq=20major-mode=20'dired-mode)))=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(auto-revert-notify-add-watch))=0A= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (auto-revert-handler)))))=0A=20=09(setq=20bufs=20(cdr=20bufs)))=0A--=20=0A= 2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_3B40BEB5-A187-44B9-8147-0B2C064C716B-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 08:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155730527829500 (code B ref 35418); Wed, 08 May 2019 08:48:01 +0000 Received: (at 35418) by debbugs.gnu.org; 8 May 2019 08:47:58 +0000 Received: from localhost ([127.0.0.1]:60315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOIF3-0007fj-UW for submit@debbugs.gnu.org; Wed, 08 May 2019 04:47:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOIF2-0007fX-GO for 35418@debbugs.gnu.org; Wed, 08 May 2019 04:47:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOIEx-0006Vp-4H; Wed, 08 May 2019 04:47:51 -0400 Received: from [176.228.60.248] (port=4867 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hOIEw-0006K9-L3; Wed, 08 May 2019 04:47:50 -0400 Date: Wed, 08 May 2019 11:47:39 +0300 Message-Id: <837eb1ib84.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 8 May 2019 10:34:13 +0200) References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Wed, 8 May 2019 10:34:13 +0200 > Cc: Eli Zaretskii , 35418@debbugs.gnu.org > > + ;; Don't bother creating a notifier for non-file buffers > + ;; if there is a custom `revert-buffer-function'. > + ;; An exception is made for Dired, since that mode works > + ;; well with notifiers. > (when (and auto-revert-use-notify > - (not auto-revert-notify-watch-descriptor)) > + (not auto-revert-notify-watch-descriptor) > + (or buffer-file-name > + (eq major-mode 'dired-mode))) Is Dired the only exception from the rule? Or is there a more general indication that a non-file buffer may want to be automatically reverted? E.g., what about Info buffers? revert-buffer does work there. Thanks. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 10:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 35418@debbugs.gnu.org, Michael Albinus Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15573107195618 (code B ref 35418); Wed, 08 May 2019 10:19:02 +0000 Received: (at 35418) by debbugs.gnu.org; 8 May 2019 10:18:39 +0000 Received: from localhost ([127.0.0.1]:60371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOJeo-0001SY-Sg for submit@debbugs.gnu.org; Wed, 08 May 2019 06:18:39 -0400 Received: from mail234c50.megamailservers.eu ([91.136.10.244]:60278 helo=mail37c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOJel-0001SM-KP for 35418@debbugs.gnu.org; Wed, 08 May 2019 06:18:36 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557310713; bh=rFhUH+Y1LFJ3oKgT1wpAmzZTOj1HhanCkXAP/vmpevY=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=O6MxdKkgk/iMvaJiSLlj8sq+QAaa6TzZwr7lXPIw81ewEvIesZsiM8FGrbqBQxiBo GbAsXRrPfuBTPVYY/kEx5r+Ug5mvVjZF/T5s3y/eyGhEfRnIwh67Go5daSODCoVlyb rWS++a8PMYm+ty3h8fb4qUmmbelzuWVRN2yGs2wc= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x48AIVTW029156; Wed, 8 May 2019 10:18:33 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <837eb1ib84.fsf@gnu.org> Date: Wed, 8 May 2019 12:18:30 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B020A.5CD2ACF9.006F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=ItQwjo3g c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=CbWuavJNO5NV1q2gfWoA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 8 maj 2019 kl. 10.47 skrev Eli Zaretskii : > Is Dired the only exception from the rule? Or is there a more general > indication that a non-file buffer may want to be automatically > reverted? E.g., what about Info buffers? revert-buffer does work > there. It's not about whether revert-buffer works, but whether notification on = default-directory is a reliable replacement for polling. Info actually isn't a good example, since it doesn't even work with = polling: it has no special `buffer-stale-function', and therefore isn't = able to tell when the buffer is out of date. Furthermore, notification = on a directory may not indicate changes to any of the files in it and = thus wouldn't be reliable anyway. With the patch, auto-revert on non-file buffers will work where at all = possible; it just won't use notification for buffers other than Dired. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 10:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15573110176123 (code B ref 35418); Wed, 08 May 2019 10:24:01 +0000 Received: (at 35418) by debbugs.gnu.org; 8 May 2019 10:23:37 +0000 Received: from localhost ([127.0.0.1]:60381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOJjd-0001ah-It for submit@debbugs.gnu.org; Wed, 08 May 2019 06:23:37 -0400 Received: from mail85c50.megamailservers.eu ([91.136.10.95]:43972 helo=mail18c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOJjc-0001aZ-Ay for 35418@debbugs.gnu.org; Wed, 08 May 2019 06:23:36 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557311014; bh=C1a/L+ghiGj043cafzvK8Gh63x9AF2DBt+5HN8pZfro=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=hvxMS7nf1YMZ+KbaF7Dst9W3Fu4gYc8Hhw3AM/kC4yN1TAP9Mgzt1Dp6hTuirSSdw 6xzKgLaYpFbHIuDejWn3JxCy3zLH+9k7cQ8BUmWZFF4ziAD7g8ksnwB2OI5wW57510 vw5f+JRsPKR81jHMcoV1NwSJX62OZeBQl8Iwpe3s= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x48ANWkf020558; Wed, 8 May 2019 10:23:34 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <7913A909-03B7-4EA5-9B13-9D7BCFB208D5@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_6345E5AA-7F89-4B62-9DF5-D5C44ED75E6B" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Date: Wed, 8 May 2019 12:23:32 +0200 In-Reply-To: <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0206.5CD2AE26.0077, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=ZIj5Z0zb c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=1RWE5UDZYfP0fGiczcgA:9 a=CjuIK1q_8ugA:10 a=l-PpjXnNMwTQP0CxdbAA:9 a=B2y7HmGcmWMA:10 a=tclcd6dtLQvEqt9_mmAA:9 a=Z5ABNNGmrOfJ6cZ5bIyy:22 a=bWyr8ysk75zN3GCy5bjg:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_6345E5AA-7F89-4B62-9DF5-D5C44ED75E6B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Actually, the comment added in the last patch was inaccurate and = referred to a previous attempt. Revised patch attached (the actual condition is unchanged). --Apple-Mail=_6345E5AA-7F89-4B62-9DF5-D5C44ED75E6B Content-Disposition: attachment; filename=0001-Don-t-use-file-notification-on-non-file-buffers.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Don-t-use-file-notification-on-non-file-buffers.patch" Content-Transfer-Encoding: quoted-printable =46rom=2052935159130964f7a4979840985c923a8d84a9ac=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Wed,=208=20May=202019=2000:02:59=20+0200=0A= Subject:=20[PATCH]=20Don't=20use=20file=20notification=20on=20non-file=20= buffers=0A=0AMost=20non-file=20buffers=20aren't=20served=20by=20file=20= notification=20in=0Aauto-revert=20mode;=20typically,=20they=20need=20to=20= be=20polled,=20like=20the=20Buffer=20List.=0AWith=20= `auto-revert-avoid-polling',=20setting=20a=20useless=20notification=20= means=0Athat=20such=20buffers=20may=20never=20be=20updated=20at=20all=20= (bug#35418).=0A=0AAn=20exception=20is=20made=20for=20Dired,=20as=20that=20= mode=20works=20well=20with=0Anotification=20on=20the=20directory.=0A=0A*=20= lisp/autorevert.el=20(auto-revert-buffers):=0AModify=20condition=20for=20= using=20notification.=0A---=0A=20lisp/autorevert.el=20|=206=20+++++-=0A=20= 1=20file=20changed,=205=20insertions(+),=201=20deletion(-)=0A=0Adiff=20= --git=20a/lisp/autorevert.el=20b/lisp/autorevert.el=0Aindex=20= 7cd5e7ee8b..37cf997c4e=20100644=0A---=20a/lisp/autorevert.el=0A+++=20= b/lisp/autorevert.el=0A@@=20-858,8=20+858,12=20@@=20the=20timer=20when=20= no=20buffers=20need=20to=20be=20checked."=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(auto-revert-remove-current-buffer))=0A=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(when=20(auto-revert-active-p)=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20Enable=20file=20= notification.=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20= Don't=20bother=20creating=20a=20notifier=20for=20non-file=20buffers=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20except=20for=20Dired,=20= since=20that=20mode=20works=20well=20with=20notifiers.=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(when=20(and=20auto-revert-use-notify=0A= -=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(not=20auto-revert-notify-watch-descriptor))=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(not=20= auto-revert-notify-watch-descriptor)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(or=20buffer-file-name=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(eq=20major-mode=20'dired-mode)))=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(auto-revert-notify-add-watch))=0A= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (auto-revert-handler)))))=0A=20=09(setq=20bufs=20(cdr=20bufs)))=0A--=20=0A= 2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_6345E5AA-7F89-4B62-9DF5-D5C44ED75E6B Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_6345E5AA-7F89-4B62-9DF5-D5C44ED75E6B-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 11:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15573131489996 (code B ref 35418); Wed, 08 May 2019 11:00:02 +0000 Received: (at 35418) by debbugs.gnu.org; 8 May 2019 10:59:08 +0000 Received: from localhost ([127.0.0.1]:60433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOKI0-0002bA-Fy for submit@debbugs.gnu.org; Wed, 08 May 2019 06:59:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOKHy-0002ak-Sy for 35418@debbugs.gnu.org; Wed, 08 May 2019 06:59:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOKHt-0001zs-67; Wed, 08 May 2019 06:59:01 -0400 Received: from [176.228.60.248] (port=4950 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hOKHs-0002Bv-0v; Wed, 08 May 2019 06:59:00 -0400 Date: Wed, 08 May 2019 13:58:46 +0300 Message-Id: <835zqli55l.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 8 May 2019 12:18:30 +0200) References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Wed, 8 May 2019 12:18:30 +0200 > Cc: Michael Albinus , 35418@debbugs.gnu.org > > With the patch, auto-revert on non-file buffers will work where at all possible; it just won't use notification for buffers other than Dired. I asked whether Dired is the only exception, or is there some more general sign that a buffer could use notifications. I'm still not sure what the answer is to that question. I don't have any doubt that Dired will work with notifications, but is the only way to have exceptions is by naming their major modes explicitly? IOW, I wonder whether your proposed patch could be made more general in some way. Thanks. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 11:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 35418@debbugs.gnu.org, Michael Albinus Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155731614030999 (code B ref 35418); Wed, 08 May 2019 11:49:01 +0000 Received: (at 35418) by debbugs.gnu.org; 8 May 2019 11:49:00 +0000 Received: from localhost ([127.0.0.1]:60493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOL4F-00083v-U7 for submit@debbugs.gnu.org; Wed, 08 May 2019 07:49:00 -0400 Received: from mail82c50.megamailservers.eu ([91.136.10.92]:60834 helo=mail18c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOL4D-00083i-I3 for 35418@debbugs.gnu.org; Wed, 08 May 2019 07:48:58 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557316134; bh=jQqBGuPRyOMhYLjPlZLQ+pGXknma0ObhwkTZgBm6myA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=s8un8Y+gnQ9YDeDUjch7oKv1ZHQCKuY5dfpQi0I6DB7bZmzFyujV+600c17ACsBCZ Fl+ha8iWqcA7lxVO8K4TPoI7Km6+dzedG9RfvTkBKxBy9uvELtDSaerUBM/wPFY1C6 LxQjOhXUAqclayFH0DLBC3ybEYCKPJywyTd/nvlo= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x48BmqNA009765; Wed, 8 May 2019 11:48:54 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <835zqli55l.fsf@gnu.org> Date: Wed, 8 May 2019 13:48:51 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0206.5CD2C226.0097, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=ZIj5Z0zb c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=wJQ6xCftTWwP08vqMlEA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 8 maj 2019 kl. 12.58 skrev Eli Zaretskii : > IOW, I wonder whether your proposed patch could be made more general > in some way. So do I, but since I could not come up with one, this ad-hoc solution = appeared as a placeholder. The code can be improved later on, but the patch is a strict improvement = on the code in master. An example of a generalisation: We could add a buffer-specific variable = that tells autorevert that yes, this buffer can rely on directory = notifications despite not having a buffer-file-name. All modes to which = this applies would need to set that variable. I don't think there is a passive condition, and furthermore, because of = the nature of directory notifications, any mode that qualifies is likely = to be some kind of variation on Dired: a buffer whose contents is = determined by the set of files in its default-directory, but not their = data. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 12:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15573189403218 (code B ref 35418); Wed, 08 May 2019 12:36:01 +0000 Received: (at 35418) by debbugs.gnu.org; 8 May 2019 12:35:40 +0000 Received: from localhost ([127.0.0.1]:60561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOLnQ-0000pq-AF for submit@debbugs.gnu.org; Wed, 08 May 2019 08:35:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOLnO-0000pe-Rh for 35418@debbugs.gnu.org; Wed, 08 May 2019 08:35:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOLnJ-00036g-Hv; Wed, 08 May 2019 08:35:33 -0400 Received: from [176.228.60.248] (port=3045 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hOLnH-0005tp-Oo; Wed, 08 May 2019 08:35:32 -0400 Date: Wed, 08 May 2019 15:35:14 +0300 Message-Id: <831s19i0ot.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 8 May 2019 13:48:51 +0200) References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Wed, 8 May 2019 13:48:51 +0200 > Cc: Michael Albinus , 35418@debbugs.gnu.org > > the patch is a strict improvement on the code in master. I have no doubt it is. > An example of a generalisation: We could add a buffer-specific variable that tells autorevert that yes, this buffer can rely on directory notifications despite not having a buffer-file-name. All modes to which this applies would need to set that variable. > > I don't think there is a passive condition, and furthermore, because of the nature of directory notifications, any mode that qualifies is likely to be some kind of variation on Dired: a buffer whose contents is determined by the set of files in its default-directory, but not their data. OK, so how about adding such a variable as part of this improvement? Or maybe it's better to have a special property on the mode's symbol? From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 12:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 35418@debbugs.gnu.org, Michael Albinus Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15573203355263 (code B ref 35418); Wed, 08 May 2019 12:59:02 +0000 Received: (at 35418) by debbugs.gnu.org; 8 May 2019 12:58:55 +0000 Received: from localhost ([127.0.0.1]:60589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOM9u-0001Mo-Ta for submit@debbugs.gnu.org; Wed, 08 May 2019 08:58:55 -0400 Received: from mail72c50.megamailservers.eu ([91.136.10.82]:60580 helo=mail92c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOM9r-0001Me-KB for 35418@debbugs.gnu.org; Wed, 08 May 2019 08:58:53 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557320329; bh=SI6Utm6B7d10vGSpWvcdXoobIF5VefL5c7xnddtCICA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=YEa5krxAG5HrOOAxYmXxE2o2rdx92OD8G0mXDVdmLBIcT+7J1pVcoLFpcsz6MPle8 Si2LabsDZv5gy0mFCW5pkDldrjImtf4HTwu+DvZprv46cz8OBnrwHgqY9BqCaUF0qd fqIkvXFbq3QonjRThT0jRunu1y1hQseSc+sBUZX8= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x48CwlU0027785; Wed, 8 May 2019 12:58:49 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <831s19i0ot.fsf@gnu.org> Date: Wed, 8 May 2019 14:58:47 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <2A4E0221-878F-4591-9C97-56B7BB8508D3@acm.org> References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> <831s19i0ot.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0211.5CD2D289.006D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=KrZjJ1eN c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=-lakZ57C5JG3unEQM1QA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 8 maj 2019 kl. 14.35 skrev Eli Zaretskii : >=20 >> An example of a generalisation: We could add a buffer-specific = variable that tells autorevert that yes, this buffer can rely on = directory notifications despite not having a buffer-file-name. All modes = to which this applies would need to set that variable. >>=20 >> I don't think there is a passive condition, and furthermore, because = of the nature of directory notifications, any mode that qualifies is = likely to be some kind of variation on Dired: a buffer whose contents is = determined by the set of files in its default-directory, but not their = data. >=20 > OK, so how about adding such a variable as part of this improvement? If it's all the same to you, I'd like to keep it separate. This patch = fixes a bug: some buffers, like Buffer Menu, are not updated = automatically at all when `auto-revert-avoid-polling' is set. What you are talking about is making some dired-like buffers update 2.5 = s faster on average, if they set the right variable. > Or maybe it's better to have a special property on the mode's symbol? Maybe a variable goes better with `revert-buffer-function' and = `buffer-stale-function' already in use by autorevert for related = purposes, although I'm eager to hear what Michael has to say (about this = and everything else). From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 13:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155732097114400 (code B ref 35418); Wed, 08 May 2019 13:10:01 +0000 Received: (at 35418) by debbugs.gnu.org; 8 May 2019 13:09:31 +0000 Received: from localhost ([127.0.0.1]:60602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOMKB-0003kC-6M for submit@debbugs.gnu.org; Wed, 08 May 2019 09:09:31 -0400 Received: from mout.gmx.net ([212.227.17.21]:32939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOMK9-0003jy-TT for 35418@debbugs.gnu.org; Wed, 08 May 2019 09:09:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557320960; bh=b+Ry7zpvoyOyIGbmrNmoJS7EIaKG4oP5yM639nW/yJo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=UsU/UB1OBl2nQAqwimblHoXsFcITcknPsa82K/cR4B6P0tJp0iV6cZID/6Q8vfEWz y3W1usJCIMGOEXZK8Temv+8wpiDQsvG4HI4aXJMSFtAbJFFihAMn+Ct4QlrshbIwPd EFj8/1M9k0yU+fEm/tH5aNsclrgog4UERYTNLtwk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([178.20.95.22]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LzbXq-1gbE5i1Xxi-014jrY; Wed, 08 May 2019 15:09:20 +0200 From: Michael Albinus References: <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> <831s19i0ot.fsf@gnu.org> <2A4E0221-878F-4591-9C97-56B7BB8508D3@acm.org> Date: Wed, 08 May 2019 15:09:16 +0200 In-Reply-To: <2A4E0221-878F-4591-9C97-56B7BB8508D3@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Wed, 8 May 2019 14:58:47 +0200") Message-ID: <87o94d5c03.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:oFCHs2fnZ2A7KgV4qSP5QX5/Xr9XMxGx1CDO8XMpiNwmHYBN5nz UHAp2w/eGDchqj3JfqZMPViX2B/Qnc83X0nT4lUFViNRNe274+ixdnOjnqK38fiHynPuONV j37r+oBVaxUP/N1dNipo8veCigqpIwD0rKt5KtlMxQHQCEae43tkq4NjKjltuWjvHrWe3oc tl3PVnQsIqWNeBa8JKtVw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:dHeCMnp64wk=:dzDuejcaFQym+btnmSnSx5 dBH7UDt23bbiITYV+3VaHY4gqdbLRaWw08c5RJCrquGXn8qw++rO5Yp/+8xqmNdQdvipAf2Bw 9sViQskFj8btfbPdXEilp+5i6W1M5Mv2/SxcYdq0pAfOZPrGWzGWg+9hWZtQv1p08EvZmVcCL xXjVtYW3rZHpUgsOtbL+qdo/8JMTvsOWu5vk8SgkAnP09EVJ4p+ez05U5VOhCWWUI3I26r2yE 0I6c/SnG9bWPkh+1irZ0F6pkl/1CtNpz93sw7BR2xZgp4ihzFaifTFrg6hDwgCkjrI56ClnAX 7UOnI/JQhMU4plZ5A2DnhuyYvAwmZwuYZNkluD6awc4KQM1lHz5D5UUd/Mh9E4IDsOy3b7j1K 1S8sf6ALXiiZHueeLeNU7OXGu2/LBXRoX2OM1CkzWt68UtIFkMJo/XluCigGFVmaZJytQ80Bo ALQIcZOs80fvmU73cQut5Xfp41VvX/A8MrUlpdrNpOnao+spx6Ygwok6WsYWXDOahAloyWY3D R5TII5u5DTNkDlaeNq5NGpmVVGjD6feLrpazBOjNuN0t+m259a1+2hI6X813ATUNYFkqVdRIh vm/9D018FJt9NNrNhm/nuKoQhwhqFkjFfJBexI2VleoWbxxWFCwBuHtjnheFHQQmW3/xT2aSU mbsgw1m1qCCx+zk2fQvwE2/gH8K8H7grXjzpOas9YhD4yciZdMvndKFI+djzg7qO/B/bQ8JVW 9fmVNBWqqU7mwx+r8FDfJkBrcQBnNhI42e0J4yo00sUfqdw3jNKcWiVmDlQQTpK3P5rqyv49w DlVirSgCTUM6jIClYgxChHBhPB8h/CyCrJz1hNJWzM6rNZRMgyIAzAWgE5ATvnbNVk7GfBlb3 nbnCBiI9jEYiokQQcIslTYJI1rY382NDnzGjy9rVEnm2c9dlDAktA5yy7bKe3C2RD/RhcLRM1 4ZOBnNjUkCg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: > I'm eager to hear what Michael has to say (about > this and everything else). I'm very busy @work just now; will react when possible. Latest on weekend, hopefully earlier. Sorry. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155732214416837 (code B ref 35418); Wed, 08 May 2019 13:30:02 +0000 Received: (at 35418) by debbugs.gnu.org; 8 May 2019 13:29:04 +0000 Received: from localhost ([127.0.0.1]:60633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOMd6-0004NV-8G for submit@debbugs.gnu.org; Wed, 08 May 2019 09:29:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOMd4-0004N7-QJ for 35418@debbugs.gnu.org; Wed, 08 May 2019 09:29:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOMcz-00087J-D1; Wed, 08 May 2019 09:28:57 -0400 Received: from [176.228.60.248] (port=2384 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hOMcv-0003wC-Nb; Wed, 08 May 2019 09:28:55 -0400 Date: Wed, 08 May 2019 16:28:41 +0300 Message-Id: <83woj1gjna.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <2A4E0221-878F-4591-9C97-56B7BB8508D3@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 8 May 2019 14:58:47 +0200) References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> <831s19i0ot.fsf@gnu.org> <2A4E0221-878F-4591-9C97-56B7BB8508D3@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Wed, 8 May 2019 14:58:47 +0200 > Cc: Michael Albinus , 35418@debbugs.gnu.org > > > OK, so how about adding such a variable as part of this improvement? > > If it's all the same to you, I'd like to keep it separate. I don't understand why: the change as it is looks a bit unclean to me, whereas the effort to make it cleaner and more future-proof is not a substantial one. But if you insist, I won't argue. > What you are talking about is making some dired-like buffers update 2.5 s faster on average, if they set the right variable. > > > Or maybe it's better to have a special property on the mode's symbol? > > Maybe a variable goes better with `revert-buffer-function' and `buffer-stale-function' already in use by autorevert for related purposes Maybe. Those variables are used to name a function, whereas here we are talking about a variable that will serve just as a flag. So I think this is different, though I don't have strong feelings. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 14:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 35418@debbugs.gnu.org, Michael Albinus Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155732482422882 (code B ref 35418); Wed, 08 May 2019 14:14:01 +0000 Received: (at 35418) by debbugs.gnu.org; 8 May 2019 14:13:44 +0000 Received: from localhost ([127.0.0.1]:33684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hONKK-0005x0-CM for submit@debbugs.gnu.org; Wed, 08 May 2019 10:13:44 -0400 Received: from mail78c50.megamailservers.eu ([91.136.10.88]:41166 helo=mail70c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hONKH-0005wq-E8 for 35418@debbugs.gnu.org; Wed, 08 May 2019 10:13:42 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557324819; bh=3/GkSC/EPxde/ZcXOCmX2tRMY8CsxADYtZgjFwhwA6c=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=Fi69cYUjsyftCXwvCLD02VDT24LQihLT6EZemr+UHnTIT1kJuOdkt2elIbeHHr80X oRAlwaHWSuVPUReX2VMze7YgrIfk1fqXjkwTYp4ZFGcgwRwHH4vRGlYZ85pQFn5lm6 +2CU40fOgH3+UNhDFG8vjY9eopAFO7ZwZueN+Bc8= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x48EDbuQ026990; Wed, 8 May 2019 14:13:39 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <1149CD1A-B094-4179-ACBF-612FD8E402F1@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_8BAE67DE-1DED-443D-9E16-7D949471420A" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Date: Wed, 8 May 2019 16:13:37 +0200 In-Reply-To: <83woj1gjna.fsf@gnu.org> References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> <831s19i0ot.fsf@gnu.org> <2A4E0221-878F-4591-9C97-56B7BB8508D3@acm.org> <83woj1gjna.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0202.5CD2E413.006A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=epTxMLhX c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=mDV3o1hIAAAA:8 a=AOgGGgTOfrf9p0zdByIA:9 a=CjuIK1q_8ugA:10 a=ausD_beliIWWzayK3jAA:9 a=B2y7HmGcmWMA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_8BAE67DE-1DED-443D-9E16-7D949471420A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 8 maj 2019 kl. 15.28 skrev Eli Zaretskii : >>=20 >>> OK, so how about adding such a variable as part of this improvement? >>=20 >> If it's all the same to you, I'd like to keep it separate. >=20 > I don't understand why: the change as it is looks a bit unclean to me, > whereas the effort to make it cleaner and more future-proof is not a > substantial one. How about dropping the Dired special case for the time being? Then the = immediate bug is fixed, and all we need to worry about is the 2.5 second = delay to Dired auto-revert updates, which we can fix separately in a = manner of our choosing. Simplified patch attached. --Apple-Mail=_8BAE67DE-1DED-443D-9E16-7D949471420A Content-Disposition: attachment; filename=0001-Don-t-use-file-notification-on-non-file-buffers.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Don-t-use-file-notification-on-non-file-buffers.patch" Content-Transfer-Encoding: quoted-printable =46rom=200ac97e913ffb3096934c64715f12921af5fce64a=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Wed,=208=20May=202019=2000:02:59=20+0200=0A= Subject:=20[PATCH]=20Don't=20use=20file=20notification=20on=20non-file=20= buffers=0A=0AMost=20non-file=20buffers=20aren't=20served=20by=20file=20= notification=20in=0Aauto-revert=20mode;=20typically,=20they=20need=20to=20= be=20polled,=20like=20the=20Buffer=20List.=0AWith=20= `auto-revert-avoid-polling',=20setting=20a=20useless=20notification=20= means=0Athat=20such=20buffers=20may=20never=20be=20updated=20at=20all=20= (bug#35418).=0A=0A*=20lisp/autorevert.el=20(auto-revert-buffers):=0A= Modify=20condition=20for=20using=20notification.=0A---=0A=20= lisp/autorevert.el=20|=203=20++-=0A=201=20file=20changed,=202=20= insertions(+),=201=20deletion(-)=0A=0Adiff=20--git=20= a/lisp/autorevert.el=20b/lisp/autorevert.el=0Aindex=20= 7cd5e7ee8b..fbaffbf0d6=20100644=0A---=20a/lisp/autorevert.el=0A+++=20= b/lisp/autorevert.el=0A@@=20-859,7=20+859,8=20@@=20the=20timer=20when=20= no=20buffers=20need=20to=20be=20checked."=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(when=20(auto-revert-active-p)=0A=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20;;=20Enable=20file=20notification.=0A=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(when=20(and=20= auto-revert-use-notify=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(not=20= auto-revert-notify-watch-descriptor))=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(not=20= auto-revert-notify-watch-descriptor)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20buffer-file-name)=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (auto-revert-notify-add-watch))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(auto-revert-handler)))))=0A=20=09(setq=20bufs=20(cdr=20= bufs)))=0A--=20=0A2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_8BAE67DE-1DED-443D-9E16-7D949471420A-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 17:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155733632127790 (code B ref 35418); Wed, 08 May 2019 17:26:01 +0000 Received: (at 35418) by debbugs.gnu.org; 8 May 2019 17:25:21 +0000 Received: from localhost ([127.0.0.1]:33937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOQJk-0007E9-Sq for submit@debbugs.gnu.org; Wed, 08 May 2019 13:25:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOQJi-0007Dt-PY for 35418@debbugs.gnu.org; Wed, 08 May 2019 13:25:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54985) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOQJd-0006kf-9w; Wed, 08 May 2019 13:25:13 -0400 Received: from [176.228.60.248] (port=4928 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hOQJb-0007dr-MS; Wed, 08 May 2019 13:25:12 -0400 Date: Wed, 08 May 2019 20:24:59 +0300 Message-Id: <83r298hn9w.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <1149CD1A-B094-4179-ACBF-612FD8E402F1@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 8 May 2019 16:13:37 +0200) References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> <831s19i0ot.fsf@gnu.org> <2A4E0221-878F-4591-9C97-56B7BB8508D3@acm.org> <83woj1gjna.fsf@gnu.org> <1149CD1A-B094-4179-ACBF-612FD8E402F1@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Wed, 8 May 2019 16:13:37 +0200 > Cc: Michael Albinus , 35418@debbugs.gnu.org > > >> If it's all the same to you, I'd like to keep it separate. > > > > I don't understand why: the change as it is looks a bit unclean to me, > > whereas the effort to make it cleaner and more future-proof is not a > > substantial one. > > How about dropping the Dired special case for the time being? That's too drastic, IMO. Feel free to push the original patch. Thanks. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 18:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15573394601066 (code B ref 35418); Wed, 08 May 2019 18:18:01 +0000 Received: (at 35418) by debbugs.gnu.org; 8 May 2019 18:17:40 +0000 Received: from localhost ([127.0.0.1]:33972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOR8N-0000H8-PF for submit@debbugs.gnu.org; Wed, 08 May 2019 14:17:40 -0400 Received: from mout.gmx.net ([212.227.15.15]:41613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOR8L-0000Gt-GO for 35418@debbugs.gnu.org; Wed, 08 May 2019 14:17:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557339447; bh=NKFOC7LLfVI+mJxR+K8EvljfLYSsp24ha9IbjO28kO0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=h+whW1w0UfY8ceFRPV7x2aLGILoxim1lXu4UMdblyjD0TMZqBdBJea/00L7MUx/pT 7/MqN5eJL5N0dyS5sAid5JQRcaIg9Aez7IewzqgOS3gtVl9r0t+2Uq65Wfzlrcemaq CwAmlmEZmomMVP3l0vroOm83F1kdNhhfoSU1AxcI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([178.20.95.22]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MegbQ-1h4gHv1cqm-00OCyM; Wed, 08 May 2019 20:17:27 +0200 From: Michael Albinus References: <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> <831s19i0ot.fsf@gnu.org> <2A4E0221-878F-4591-9C97-56B7BB8508D3@acm.org> <83woj1gjna.fsf@gnu.org> <1149CD1A-B094-4179-ACBF-612FD8E402F1@acm.org> <83r298hn9w.fsf@gnu.org> Date: Wed, 08 May 2019 20:17:25 +0200 In-Reply-To: <83r298hn9w.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 08 May 2019 20:24:59 +0300") Message-ID: <87o94c3j62.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:A74J+jUTAl314Q0Rv8gTzF24m80zwwrkrkmB7u6wghis5YbuWUz 8gOiC2PyPP3MbyzzvCZszphDb5wpi12qwQQlQAwu8VbtokRZmwMU/WVubfImz2e8/c6c1lk ubgSvyRrDMxUjqJ7x6xRq/jLp/jxb60htq5NIyDN9fQv2ElrQgJkp0Rs6CzsR65bRvwsYxV Hmb9UYBsOs76OgEzllXUQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:RAgykBZz1QI=:s8jVcAHwoxSUN89ysvaNOV kURP56zix1CYqwjiuWBaxEg7QQz5tWau20e1p2x2jko41sy8YucXIi1h2F17qpOBDGZjwrR79 nBWTsCLjBu2TZt4CHg2zVIf14jSnDvSW7Sbp9Hq3vU1VJjjwvzMxAAUFa6WiHIq6Lhp7W8ulo DhhjGpTlqX5LzQJK/VSTHZ47IhPTioV/IXWeoP4JSnR3vweIxjukkICzOmjFYI2Yynb18zjK5 qm+TArfa+EKlk/6jQ9chln3nUHvtuptzIxscMCPA0/X0Qt41cuoWMVyIT8XKm5+3H7IyGja94 pJ3Y7BIheG3VHH5QmLgPGqY9pKGCQ2brbJB+7mR3jiB175UBg51K6Z7fazWgRwCL8wxROAK3T y9T5rhYaS7C2K966RLMbyohetDxQFPxIeVWvdQMDGaN0tAkUWW988Z5su/vIShqOcZQKGodp+ V4Tr71+cZzErSGy57S+hqflPRppK3mpyiZLj5GYIf1FQiyJ7MskYdpJtZy+iazGgB4VMidwy9 I1cAAUtcVXVvk6iCTM5aCIydZNegKiKg5KXNDcSLIpFKehKXXPXXlEJfPnH7usyqidmRv5BGS z4osvVGrS4MV3GnGpig1QP67F592R/MmjtSpS51GQN1lXwM7vTxPZgloXVymx0YHLN/Efs5op X2n+OygjPMWogJ7k3H3de6nS/EgbqbSr0aUFgsEGScDLBP1rR716w/vh8tShpuERahxpt6QB4 lUF9dBfRKDLW4VV2QHkXF/2asdpT8lnmsU8O+xq2ylbehYoAmHdlGFoWYDcoj5FC9zGlkmAtt 8Ug/KCaUVymtY3DexwwqqXznC5JC+CnFWnGnr4aRQuUbO/mAJacqFr43JvljebwvVpKgtOQcV FLPMhYBse0OUDhf1A/t/nAuYMJWAyc2zpuv9qFv3+LU9frxYkPEjVxYmDnVVgXbu2nNnffIfm hr48lRnIyig== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> How about dropping the Dired special case for the time being? > > That's too drastic, IMO. Feel free to push the original patch. I agree with Eli, we would loose too much. A directory might not change for hours, polling for this every 5 seconds is expensive. Think about a remote directory, for example. > Thanks. Best regards, Michael. PS: I hope to find tomorrow the time to review the patch. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 May 2019 10:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155739602514066 (code B ref 35418); Thu, 09 May 2019 10:01:02 +0000 Received: (at 35418) by debbugs.gnu.org; 9 May 2019 10:00:25 +0000 Received: from localhost ([127.0.0.1]:34652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOfqj-0003en-1W for submit@debbugs.gnu.org; Thu, 09 May 2019 06:00:25 -0400 Received: from mail78c50.megamailservers.eu ([91.136.10.88]:41298 helo=mail70c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOfqg-0003ec-C1 for 35418@debbugs.gnu.org; Thu, 09 May 2019 06:00:23 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557396019; bh=rv1bweUjhm8fsHP+eIsaiN5N/4bXEVBtSlD3DNmET98=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=iw2RPChUry1QHog7iREDqB+qT8oYiPfdlx/qXNPeO000jH6VpeYOt0KVaf1e+z07Z TKE7OyGN0tZi02SB09DRAkNFjxSwrgftzAgMbRQGfL02nqB+ub6ZeKqUU5OuExe4qd s9rRBq7KEP8BLOiFdgaZvMLSsLtfQt2eDLRDEcdk= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x49A0Hox004118; Thu, 9 May 2019 10:00:18 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_C8D1A0E2-CA8E-4BC2-B65B-DF4746B6C787" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Date: Thu, 9 May 2019 12:00:17 +0200 In-Reply-To: <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B020E.5CD3FA33.0084, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=epTxMLhX c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=N54-gffFAAAA:8 a=XTr9_afi4EgPRjP0SjAA:9 a=QEXdDO2ut3YA:10 a=a8Dl6OEfzWyGJgKP8dQA:9 a=B2y7HmGcmWMA:10 a=6l0D2HzqY3Epnrm8mE3f:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_C8D1A0E2-CA8E-4BC2-B65B-DF4746B6C787 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 5 maj 2019 kl. 11.58 skrev Mattias Engdeg=C3=A5rd : >=20 > What remains is avoiding polling in global-auto-revert-mode. I'll send = a patch soon. Here is that patch. I understand that some people are queasy about using advice in code like = this, and am open to suggestions about alternatives. What the code needs is a reasonable (not necessarily bullet-proof) way = to detect new file buffers and changes to buffer-file-name of those = buffers. Monitoring `find-file-noselect' and `set-visited-file-name' = turned out to be good enough. For the former, it might be possible to get away with = `after-change-major-mode-hook' instead (already used for non-file = buffers). --Apple-Mail=_C8D1A0E2-CA8E-4BC2-B65B-DF4746B6C787 Content-Disposition: attachment; filename=0001-Avoid-polling-in-global-auto-revert-mode.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Avoid-polling-in-global-auto-revert-mode.patch" Content-Transfer-Encoding: quoted-printable =46rom=2034302c20db88917a9a5bea90a70d315b44f1647d=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Thu,=209=20May=202019=2009:40:46=20+0200=0A= Subject:=20[PATCH]=20Avoid=20polling=20in=20global-auto-revert-mode=0A=0A= Make=20`auto-revert-avoid-polling'=20have=20effect=20in=20= global-auto-revert-mode.=0ABuffers=20actually=20handled=20by=20that=20= mode=20are=20marked=20with=20a=20non-nil=20value=0Aof=20= `global-auto-revert--tracked-buffer'.=20=20When=20= global-auto-revert-mode=0Ais=20entered,=20eligible=20buffers=20are=20= marked=20in=20that=20way,=20and=20hooks=20are=20set=0Aup=20to=20mark=20= new=20buffers=20and=20take=20care=20of=20buffers=20whose=20file=20names=0A= change.=20=20This=20way=20the=20existing=20poll-avoidance=20logic=20can=20= be=20used,=20since=0Athe=20entire=20set=20of=20buffers=20in=20= auto-revert=20is=20known.=0A(Bug#35418).=0A=0A*=20lisp/autorevert.el=20= (auto-revert-avoid-polling):=20Amend=20doc=20string.=0A= (global-auto-revert--tracked-buffer):=20New=20buffer-local=20variable.=0A= (global-auto-revert-mode):=20Mark=20existing=20buffers=20and=20set=20up=20= hooks=20when=0Amode=20is=20entered;=20do=20the=20opposite=20when=20= exited.=0A(auto-revert--global-add-buffer)=0A= (auto-revert--find-file-noselect-advice)=0A= (auto-revert--set-visited-file-name-advice)=0A= (auto-revert--after-change-major-mode):=20New=20functions.=0A= (auto-revert--polled-buffers,=20auto-revert--need-polling-p)=0A= (auto-revert-notify-handler)=0A(auto-revert-active-p):=20Modify=20logic=20= to=20cover=20global-auto-revert-mode.=0A*=20etc/NEWS=20(Changes=20in=20= Specialized=20Modes=20and=20Packages):=20Update=20entry.=0A---=0A=20= etc/NEWS=20=20=20=20=20=20=20=20=20=20=20|=20=20=203=20+-=0A=20= lisp/autorevert.el=20|=20133=20= ++++++++++++++++++++++++++++++++++++---------=0A=202=20files=20changed,=20= 108=20insertions(+),=2028=20deletions(-)=0A=0Adiff=20--git=20a/etc/NEWS=20= b/etc/NEWS=0Aindex=209e3559d27e..56c7163f7f=20100644=0A---=20a/etc/NEWS=0A= +++=20b/etc/NEWS=0A@@=20-1396,8=20+1396,7=20@@=20When=20set=20to=20a=20= non-nil=20value,=20buffers=20in=20Auto-Revert=20mode=20are=20no=20longer=0A= =20polled=20for=20changes=20periodically.=20=20This=20reduces=20the=20= power=20consumption=0A=20of=20an=20idle=20Emacs,=20but=20may=20fail=20on=20= some=20network=20file=20systems;=20set=0A=20= 'auto-revert-notify-exclude-dir-regexp'=20to=20match=20files=20where=0A= -notification=20is=20not=20supported.=20=20The=20new=20variable=20= currently=20has=20no=0A-effect=20in=20'global-auto-revert-mode'.=20=20= The=20default=20value=20is=20nil.=0A+notification=20is=20not=20= supported.=20=20The=20default=20value=20is=20nil.=0A=20=0A=20=0C=0A=20*=20= New=20Modes=20and=20Packages=20in=20Emacs=2027.1=0Adiff=20--git=20= a/lisp/autorevert.el=20b/lisp/autorevert.el=0Aindex=20= fbaffbf0d6..402301c448=20100644=0A---=20a/lisp/autorevert.el=0A+++=20= b/lisp/autorevert.el=0A@@=20-312,10=20+312,7=20@@=20when=20those=20files=20= are=20modified=20from=20another=20computer.=0A=20=0A=20When=20nil,=20= buffers=20in=20Auto-Revert=20Mode=20will=20always=20be=20polled=20for=0A=20= changes=20to=20their=20files=20on=20disk=20every=20= `auto-revert-interval'=0A-seconds,=20in=20addition=20to=20using=20= notification=20for=20those=20files.=0A-=0A-In=20Global=20Auto-Revert=20= Mode,=20polling=20is=20always=20done=20regardless=20of=0A-the=20value=20= of=20this=20variable."=0A+seconds,=20in=20addition=20to=20using=20= notification=20for=20those=20files."=0A=20=20=20:group=20'auto-revert=0A=20= =20=20:type=20'boolean=0A=20=20=20:set=20(lambda=20(variable=20value)=0A= @@=20-335,6=20+332,9=20@@=20buffers=20to=20this=20list.=0A=20The=20timer=20= function=20`auto-revert-buffers'=20is=20responsible=20for=20purging=0A=20= the=20list=20of=20old=20buffers.")=0A=20=0A+(defvar-local=20= global-auto-revert--tracked-buffer=20nil=0A+=20=20"Non-nil=20if=20buffer=20= is=20handled=20by=20Global=20Auto-Revert=20mode.")=0A+=0A=20(defvar=20= auto-revert-remaining-buffers=20()=0A=20=20=20"Buffers=20not=20checked=20= when=20user=20input=20stopped=20execution.")=0A=20=0A@@=20-501,34=20= +501,118=20@@=20specifies=20in=20the=20mode=20line."=0A=20=20=20:global=20= t=20:group=20'auto-revert=20:lighter=20global-auto-revert-mode-text=0A=20= =20=20(auto-revert-set-timer)=0A=20=20=20(if=20global-auto-revert-mode=0A= -=20=20=20=20=20=20(auto-revert-buffers)=0A+=20=20=20=20=20=20;;=20Turn=20= global-auto-revert-mode=20ON.=0A+=20=20=20=20=20=20(progn=0A+=20=20=20=20= =20=20=20=20(mapc=20#'auto-revert--global-add-buffer=20(buffer-list))=0A= +=20=20=20=20=20=20=20=20;;=20Make=20sure=20future=20buffers=20are=20= added=20as=20well.=0A+=20=20=20=20=20=20=20=20(advice-add=20= 'find-file-noselect=20:filter-return=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20#'auto-revert--find-file-noselect-advice)=0A+=20= =20=20=20=20=20=20=20(advice-add=20'set-visited-file-name=20:after=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= #'auto-revert--set-visited-file-name-advice)=0A+=20=20=20=20=20=20=20=20= ;;=20To=20track=20non-file=20buffers,=20we=20need=20to=20listen=20in=20= to=20buffer=0A+=20=20=20=20=20=20=20=20;;=20creation=20in=20general.=20=20= Listening=20to=20major-mode=20changes=20is=0A+=20=20=20=20=20=20=20=20;;=20= suitable,=20since=20we=20then=20know=20whether=20it's=20a=20mode=20that=20= is=20tracked.=0A+=20=20=20=20=20=20=20=20(when=20= global-auto-revert-non-file-buffers=0A+=20=20=20=20=20=20=20=20=20=20= (add-hook=20'after-change-major-mode-hook=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20#'auto-revert--after-change-major-mode))=0A= +=20=20=20=20=20=20=20=20(auto-revert-buffers))=0A+=20=20=20=20;;=20Turn=20= global-auto-revert-mode=20OFF.=0A+=20=20=20=20(remove-hook=20= 'after-change-major-mode-hook=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20#'auto-revert--after-change-major-mode)=0A+=20=20=20=20= (advice-remove=20'set-visited-file-name=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20#'auto-revert--set-visited-file-name-advice)=0A= +=20=20=20=20(advice-remove=20'find-file-noselect=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20= #'auto-revert--find-file-noselect-advice)=0A=20=20=20=20=20(dolist=20= (buf=20(buffer-list))=0A=20=20=20=20=20=20=20(with-current-buffer=20buf=0A= -=20=20=20=20=20=20=20=20(when=20(and=20= auto-revert-notify-watch-descriptor=0A-=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(not=20(memq=20buf=20auto-revert-buffer-list)))=0A-=09= =20=20(auto-revert-notify-rm-watch))))))=0A+=20=20=20=20=20=20=20=20= (when=20global-auto-revert--tracked-buffer=0A+=20=20=20=20=20=20=20=20=20= =20(setq=20global-auto-revert--tracked-buffer=20nil)=0A+=20=20=20=20=20=20= =20=20=20=20(when=20(and=20auto-revert-notify-watch-descriptor=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(not=20(or=20= auto-revert-mode=20auto-revert-tail-mode)))=0A+=09=20=20=20=20= (auto-revert-notify-rm-watch)))))))=0A+=0A+(defun=20= auto-revert--global-add-buffer=20(buffer)=0A+=20=20"Set=20BUFFER=20to=20= be=20tracked=20by=20Global=20Auto-Revert=20if=20appropriate."=0A+=20=20= (with-current-buffer=20buffer=0A+=20=20=20=20(when=20(and=20(not=20= global-auto-revert--tracked-buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(or=20buffer-file-name=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20;;=20Any=20non-file=20buffer=20must=20have=20a=20= custom=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20= `buffer-stale-function'=20to=20be=20tracked,=20since=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20;;=20we=20wouldn't=20know=20when=20= to=20revert=20it=20otherwise.=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(and=20global-auto-revert-non-file-buffers=0A+=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(not=20(eq=20= buffer-stale-function=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= #'buffer-stale--default-function))))=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(not=20(memq=20'major-mode=20= global-auto-revert-ignore-modes))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(not=20global-auto-revert-ignore-buffer))=0A+=20=20=20=20=20=20= (setq=20global-auto-revert--tracked-buffer=20t))))=0A+=0A+(defun=20= auto-revert--find-file-noselect-advice=20(buffer)=0A+=20=20"Adopt=20= BUFFER=20for=20Global=20Auto-Revert=20if=20appropriate.=0A+Called=20with=20= the=20return=20value=20of=20`find-file-noselect'."=0A+=20=20= (auto-revert--global-add-buffer=20buffer)=0A+=20=20= (auto-revert-set-timer)=0A+=20=20buffer)=0A+=0A+(defun=20= auto-revert--set-visited-file-name-advice=20(&rest=20_)=0A+=20=20"Adopt=20= the=20current=20buffer=20for=20Global=20Auto-Revert=20if=20appropriate.=0A= +Called=20after=20`set-visited-file-name'."=0A+=20=20;;=20In=20case=20= the=20file=20name=20was=20changed,=20remove=20any=20existing=20notifier=0A= +=20=20;;=20first=20so=20that=20we=20don't=20track=20the=20wrong=20file.=0A= +=20=20(when=20auto-revert-notify-watch-descriptor=0A+=20=20=20=20= (auto-revert-notify-rm-watch))=0A+=20=20(auto-revert--global-add-buffer=20= (current-buffer))=0A+=20=20(auto-revert-set-timer))=0A+=0A+(defun=20= auto-revert--after-change-major-mode=20()=0A+=20=20"Adopt=20the=20= current=20buffer=20for=20Global=20Auto-Revert=20if=20appropriate.=0A= +Called=20after=20the=20current=20buffer=20got=20a=20new=20major=20= mode."=0A+=20=20(auto-revert--global-add-buffer=20(current-buffer))=0A+=20= =20(auto-revert-set-timer))=0A=20=0A=20(defun=20= auto-revert--polled-buffers=20()=0A=20=20=20"List=20of=20buffers=20that=20= need=20to=20be=20polled."=0A-=20=20(cond=20(global-auto-revert-mode=20= (buffer-list))=0A+=20=20(cond=20(global-auto-revert-mode=0A+=20=20=20=20=20= =20=20=20=20(mapcan=20(lambda=20(buffer)=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(and=20(not=20(and=20= auto-revert-avoid-polling=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= buffer)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(or=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'global-auto-revert--tracked-buffer=20buffer)=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (buffer-local-value=20'auto-revert-mode=20buffer)=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (buffer-local-value=20'auto-revert-tail-mode=20buffer))=0A+=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(list=20= buffer)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (buffer-list)))=0A=20=20=20=20=20=20=20=20=20(auto-revert-avoid-polling=0A= =20=20=20=20=20=20=20=20=20=20(mapcan=20(lambda=20(buffer)=0A-=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(and=20(not=20= (buffer-local-value=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buffer))=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(list=20buffer)))=0A= -=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffer-list))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(and=20(not=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buffer))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(list=20buffer)))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20auto-revert-buffer-list))=0A= =20=20=20=20=20=20=20=20=20(t=20auto-revert-buffer-list)))=0A=20=0A=20;;=20= Same=20as=20above=20in=20a=20boolean=20context,=20but=20cheaper.=0A=20= (defun=20auto-revert--need-polling-p=20()=0A=20=20=20"Whether=20periodic=20= polling=20is=20required."=0A-=20=20(or=20global-auto-revert-mode=0A-=20=20= =20=20=20=20(if=20auto-revert-avoid-polling=0A-=20=20=20=20=20=20=20=20=20= =20(not=20(cl-every=20(lambda=20(buffer)=0A-=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=0A= -=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20'auto-revert-notify-watch-descriptor=20buffer))=0A-=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffer-list))=0A-=20=20=20=20=20=20=20=20= auto-revert-buffer-list)))=0A+=20=20(cond=20(global-auto-revert-mode=0A+=20= =20=20=20=20=20=20=20=20(or=20(not=20auto-revert-avoid-polling)=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20(cl-some=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(lambda=20(buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(and=20(not=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buffer))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(or=20(buffer-local-value=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'global-auto-revert--tracked-buffer=20buffer)=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=20= 'auto-revert-mode=20buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-tail-mode=20buffer))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(buffer-list))))=0A+=20=20=20=20=20=20=20=20= (auto-revert-avoid-polling=0A+=20=20=20=20=20=20=20=20=20(not=20= (cl-every=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(lambda=20= (buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20'auto-revert-notify-watch-descriptor=20buffer))=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20auto-revert-buffer-list)))=0A+=20=20=20=20=20=20=20= =20(t=20auto-revert-buffer-list)))=0A=20=0A=20(defun=20= auto-revert-set-timer=20()=0A=20=20=20"Restart=20or=20cancel=20the=20= timer=20used=20by=20Auto-Revert=20Mode.=0A@@=20-652,9=20+736,8=20@@=20= system.")=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(null=20buffer-file-name))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(auto-revert-notify-rm-watch)=0A=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20;;=20Restart=20the=20timer=20if=20it=20wasn't=20= running.=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20(and=20= (memq=20buffer=20auto-revert-buffer-list)=0A-=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(not=20= auto-revert-timer))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(auto-revert-set-timer)))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(unless=20auto-revert-timer)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(auto-revert-set-timer))))=0A=20=0A=20=20=20=20=20=20= =20=20=20;;=20Loop=20over=20all=20buffers,=20in=20order=20to=20find=20= the=20intended=20one.=0A=20=20=20=20=20=20=20=20=20(cl-dolist=20(buffer=20= buffers)=0A@@=20-700,9=20+783,7=20@@=20If=20the=20buffer=20needs=20to=20= be=20reverted,=20do=20it=20now."=0A=20=20=20"Check=20if=20auto-revert=20= is=20active=20(in=20current=20buffer=20or=20globally)."=0A=20=20=20(or=20= auto-revert-mode=0A=20=20=20=20=20=20=20auto-revert-tail-mode=0A-=20=20=20= =20=20=20(and=20global-auto-revert-mode=0A-=20=20=20=20=20=20=20=20=20=20= =20(not=20global-auto-revert-ignore-buffer)=0A-=20=20=20=20=20=20=20=20=20= =20=20(not=20(memq=20major-mode=20global-auto-revert-ignore-modes)))))=0A= +=20=20=20=20=20=20global-auto-revert--tracked-buffer))=0A=20=0A=20= (defun=20auto-revert-handler=20()=0A=20=20=20"Revert=20current=20buffer,=20= if=20appropriate.=0A--=20=0A2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_C8D1A0E2-CA8E-4BC2-B65B-DF4746B6C787-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 May 2019 10:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 35418@debbugs.gnu.org, michael.albinus@gmx.de Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155739894627084 (code B ref 35418); Thu, 09 May 2019 10:50:02 +0000 Received: (at 35418) by debbugs.gnu.org; 9 May 2019 10:49:06 +0000 Received: from localhost ([127.0.0.1]:34731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOgbq-00072h-Ee for submit@debbugs.gnu.org; Thu, 09 May 2019 06:49:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOgbp-000725-1w for 35418@debbugs.gnu.org; Thu, 09 May 2019 06:49:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOgbj-0005E1-Nm; Thu, 09 May 2019 06:48:59 -0400 Received: from [176.228.60.248] (port=2636 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hOgbi-0000My-In; Thu, 09 May 2019 06:48:59 -0400 Date: Thu, 09 May 2019 13:48:44 +0300 Message-Id: <83a7fvhpir.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Thu, 9 May 2019 12:00:17 +0200) References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Thu, 9 May 2019 12:00:17 +0200 > Cc: Eli Zaretskii , 35418@debbugs.gnu.org > > What the code needs is a reasonable (not necessarily bullet-proof) way to detect new file buffers and changes to buffer-file-name of those buffers. Did you consider utilizing buffer-list-update-hook? From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 May 2019 11:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 35418@debbugs.gnu.org, Michael Albinus Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155740054229743 (code B ref 35418); Thu, 09 May 2019 11:16:02 +0000 Received: (at 35418) by debbugs.gnu.org; 9 May 2019 11:15:42 +0000 Received: from localhost ([127.0.0.1]:34779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOh1Z-0007jf-Lb for submit@debbugs.gnu.org; Thu, 09 May 2019 07:15:41 -0400 Received: from mail72c50.megamailservers.eu ([91.136.10.82]:59826 helo=mail92c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOh1X-0007jT-C3 for 35418@debbugs.gnu.org; Thu, 09 May 2019 07:15:40 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557400537; bh=VDuFBYXP4s2xelUzZDEDpo6W2Ml3yt9AceiPWUhVSr4=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=rsPry/XjeXtVRvmbYX2oXIaAw9/ee5n6JCa7SEIP2gFcVzhK6eV4RQSGMKIxBKiEv ul3Q8ib65dpLpyTPyVMh1BAueFsNlYmVraQsJTXd+d4izRtbZaCHZrmteMeEeNp6Ln MEF18bpyI+tEgBunsdj/uPLhFwVxbdiT/MMS3etI= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x49BFH23001050; Thu, 9 May 2019 11:15:36 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <83a7fvhpir.fsf@gnu.org> Date: Thu, 9 May 2019 13:15:17 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <1F94B767-5E20-4CC4-87C8-F4D677F773F2@acm.org> References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> <83a7fvhpir.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0208.5CD40BD9.0044, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=KrZjJ1eN c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=d-FEvDggZHxh19Gs87UA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 9 maj 2019 kl. 12.48 skrev Eli Zaretskii : >=20 > Did you consider utilizing buffer-list-update-hook? It triggers far too often, including changes in the list order, creation = and removal of temporary buffers, and so on. Furthermore it does not say = what changed; a diff would have to be computed each time. Finally, = neither the major mode nor buffer-file-name has been set at that point. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 May 2019 11:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155740262316671 (code B ref 35418); Thu, 09 May 2019 11:51:02 +0000 Received: (at 35418) by debbugs.gnu.org; 9 May 2019 11:50:23 +0000 Received: from localhost ([127.0.0.1]:34841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOhZ7-0004Kn-UG for submit@debbugs.gnu.org; Thu, 09 May 2019 07:50:23 -0400 Received: from mout.gmx.net ([212.227.17.20]:36237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOhZ5-0004Ka-4R for 35418@debbugs.gnu.org; Thu, 09 May 2019 07:50:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557402608; bh=6qZZRFk3yxAuqJgyNa6YG+eaEVVHtaJj0D3Oaz92j6E=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=OUnYW57Ye58/5Z2bxxBZ23ZOX01tAq7Z6YOHPGnTMR5xPsL89iBUCBmDK2BH4lPus JxmrcL+liJ9evJpS8qJCrDjeqXuNzQzYSVjjmlMG6p7z/bP2ucMmE6etPtwJ+tIvX0 9hv7xaCP7sJlgxdCyvX64FAFyR5VYf/BxbZyOHiQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([178.20.95.22]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Mc9U3-1h6thH2YNz-00JakS; Thu, 09 May 2019 13:50:08 +0200 From: Michael Albinus References: <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> Date: Thu, 09 May 2019 13:50:06 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Wed, 8 May 2019 13:48:51 +0200") Message-ID: <877eazx2xd.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:h1ZqD5xranxO7qGQxtaC6V/tWbC7id/8OLTH2dFqARCq64q7bnl auA2+JcbK/FAaz7hIURM9PIwu5r0pYjdVRMNBOuetkkHcBB2oA30m7Y3z0ivaNCx4laWqNC UqUyTpNbcwvYVI77tYXomOGnNpy3mTubM34kLjbuFZaaa5O9MoYjn11n2x42ws96cARBRs8 bkR6CXmc4AIMZi+KBVHQQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:rOiKvzuT5A4=:HPQZgq5QUuHaTpJLdyx5gR MkeXiIYvAlOwwelRqM+24F7g8j5kHRX06eshi6zAYWlq27hFFMl6IMsOO5s6Ho9ISCGxsASiu bRiEtSjcIIv5ITP+55V1na4a4UewblATABnE7VcoiXMBZyzgb/v2DwhCcAL1Vdc+e345kZxYj VHdAei8uucNbqX5A9aalUD4qm8kDmmKh/KdNKVc2sGGlZdDJ7XrxaFAzi/U1+CMr1vWHg2knE Y0BfV/802JomhYTZbm0TLp2DbObUZt3yfkzf/uXgjHPo3l0aEHibuZNt0ORIspWdv/CcqGfp5 qPsYSHmY3S/cGLpcNPggX+4nd/NWkhsuwxPwEVFuN8Ad/fu2EXJEtgywxXoFIyNSCz+Ya88Sa dKw52WqK7PgP+0gucRKm68wBjGXchdSlpDxIkSHa/b/pajGN+yHmbwz2YnZPxAKDcKLtYl6dG BLGsbfnSzu/NB/Y5a8JP5UTrzQUu9Ripo0mAveSQ8pkFG5Ztl3qd3Ibt1cILBGO0EOEo3Koih Nz+Y5URxMpk3rMPFw7cncF2CvOFCucJx8D9OTsitNXm0leM/PliVOLL9Jn9wzMSwiGRY1ha9i lYueIZdp5m6S7+jC3DZz4kDqwpeffEfbRmx1EB/iz+Uo4yZNlg0nQxkoh08MJKzoaI+cPIA0q sulNZvA11H5huiWQaHtsEQTMdxbrfdktoXnaGYKdTdVKDPv5sGKsRNf7pQ0CvRGMWNJkP227B 6Rtf6JmCNtGwD67VcxlVCPfm1ho85mogSOGcWp0lltexgTj97kkzxBlwBBJH+k6XPytE0nGj0 0ZlUidOyv2hdLkjByIzuhopNDmwMA5kbRwOaGe2VckkDgZgK3tb5F2vdpzA/U/NMB/g2BXuUG u+5u8SCz9bpaSLWOXNTn0OAoqNnPAqs4//9sAemEhdaQX2WDbzrIouOcAhD7F6j3oD7ONnZQ+ 1/5U60QLoAg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi, > An example of a generalisation: We could add a buffer-specific > variable that tells autorevert that yes, this buffer can rely on > directory notifications despite not having a buffer-file-name. All > modes to which this applies would need to set that variable. I sympathize with this proposal. There shall be an indication that a buffer could be auto-reverted by file notifications. This indication is either a non-nil buffer-file-name, or a non-nil buffer-local variable (let's call it buffer-auto-revert-by-file-notification-aware; I'm open to any better name). Non-file buffers which could be auto-reverted are those which provide a buffer-stale-function. A short scan in vanilla Emacs shows Buffer-menu-mode and dired-mode, which set buffer-stale-function. Buffer-menu-mode does not use files, so it doesn't profit from file notifications. One could write another kind of notification which fires when buffers are created or deleted, but that's another story. And I doubt it will be more useful than the current auto-reverting for buffer lists. So indeed, dired is left for vanilla Emacs. It shall set buffer-auto-revert-by-file-notification-aware when a buffer is setup to dired-mode. Other packages in the wild could do similar settings, think about vc-dir or magit, which use their own machinery. Potentially, any mode which uses (an own implementation of) revert-buffer, would be a candidate for this kind of auto-revert. Thinking about, I'm even not confident that a static value of this indication is sufficient. In dired, it might be set to t when the dired buffer is setup. But what if the dired buffer contains subdirectories? Is it still possible to indicate this by file notifications over default-directory? Don't know, maybe not, and the variable has to be set to nil ... Long story short: we shall start with dired, which sets a buffer-local variable as indication, and we shall edocument this in the Elisp manual. Let's see where we go. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 May 2019 09:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155748178710859 (code B ref 35418); Fri, 10 May 2019 09:50:01 +0000 Received: (at 35418) by debbugs.gnu.org; 10 May 2019 09:49:47 +0000 Received: from localhost ([127.0.0.1]:37178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP29y-0002oz-Qi for submit@debbugs.gnu.org; Fri, 10 May 2019 05:49:47 -0400 Received: from mout.gmx.net ([212.227.15.19]:41673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP29u-0002ob-7w for 35418@debbugs.gnu.org; Fri, 10 May 2019 05:49:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557481772; bh=TYRDg/FLh+WOqMo/5ybaWSVbAkAuMUKKbkXMCL+Y7nI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=LSrhpZDyUcElOrCZu7IKVcD1SK/iD2vyhDmkSlM47JqxjZ9+Tk3K/+kKrmq0/VHJQ cgusHN4r1UiZ2S7AI8oh1gO0oNf2OvUOZVN6wDrihETSFm8QrFgWKR8WXW5MN5oseX cvdI8WZg0rY33AJckS8pl1AGvo9vg282LT4GOeH4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.91.238.102]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M5QF5-1hNf6v39vh-001RDZ; Fri, 10 May 2019 11:49:32 +0200 From: Michael Albinus References: <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> Date: Fri, 10 May 2019 11:49:30 +0200 In-Reply-To: <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Thu, 9 May 2019 12:00:17 +0200") Message-ID: <87muju1vx1.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:w/mOLo6e7cwtLCvV5zFHNzrN50Pdhtz21HGj9YxUp05EMpn1wlN ybNmOrou8ecSD6+aastSzlgMP8FOn3oiZplvYPrNlJCRhz7rAhkO2Tz0SuTI49oCx1ywX93 rrk8dlbwEWiB2exXVFnvSSEdbo6CVcKYPRKUUk7SQrPFNUZ1shK5mU7xV6p0rjwOvfMxF8y 4+yWnXvwSuCsNOfZi+T3w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:96mBjl9IEbw=:fc2uFs9axokXTUORKyYjyE ZxtuAwJ2y8mmQ1V8u+0czaqsoyTrluFJamJV16ufFSg7AN1oyultNZ4BnNuOKuIIRLDIOVsLO 46SusoMO+66i4tFSowwmCMh99cjrNqu8QIj/3d+DIyIoaOw7hvJfxA2qai6qr/UQyFwM8FSNb ISBpT6z2rU40fo8GoQwZmj/mHSi0l3SCcS/HqI5UCevC9JAsq9UQvw2rCYUMiPhvbufNQueNz uy2FYpvy9WIw+7QPRFqzVprC+k6IIP0/UXeubztjPIZ/wjNLNiGnrk7jZrzd0B6TTEZNh39xC I4aRHqP1Cgg2EDsOgMN4BkYCg1TbniuQEVYxuZJcd3i+55jwylwC7CL1/aLNa9145ulFX8u0u xWqxH8KocrWJppax1dknGJtYJD4i/SdfmuEnE6qmHEl0FXzyDO8IgM7yJidTSh76Ud3EzMTiL fr33tIpyPbCxUxtPJ5Pk9+naLpnotKsI1m37lBufSu0QhqMg9sUKmpN81r3/Z8XpF7upBiBJ9 uaC4T1Q/Xuzcxk8eHrhlhuf7BK4ywnBt5rnD7Is9w3WQLoxpdvqzAhEwaKB817o1kJSfKQm7a dOCrCW0yX/8P79I7VHklkKTppn1kbOHjJ36wiUtiK1rpYuvlknTL2xN8yc81lBshxghY76OGX 8wjnEFCfS4+RnRUJJ6UQRzJiI5Gt4sj6lrVFYEhHKuPkoohP7Itcp0uQUx9epoc5UqHT+0UN+ vYLT4OT47zPOego5JAlxpj+5jtZTRCXs6MlPUBD5DDE5jMIoel/nRGeJscGQICKKGpeFfFcG3 Wzdwg0ue7eMYGX+8IO7TWpbxcFlqxFdg97Nkg6awdEhH/ohQxOMmDJX/S3C6Ryl2T+rZVXz05 ylos3G3AEWWwXQjb+HCW3UNKwTOJHW5kuSOFMhSOu+MsxaN1ygk+MCuuVyf3blJapAtZNYo/V 5z1OERh0N8Q== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, > I understand that some people are queasy about using advice in code > like this, and am open to suggestions about alternatives. It's not just being qeasy. It is a design rule, that advising functions do not belong to core Emacs. > What the code needs is a reasonable (not necessarily bullet-proof) way > to detect new file buffers and changes to buffer-file-name of those > buffers. Monitoring `find-file-noselect' and `set-visited-file-name' > turned out to be good enough. > For the former, it might be possible to get away with > `after-change-major-mode-hook' instead (already used for non-file > buffers). There is `find-file-hook'. If we need to hook into `set-visited-file-name', we shall create a new hook `after-set-visited-file-name', and run it there. > +(defvar-local global-auto-revert--tracked-buffer nil > + "Non-nil if buffer is handled by Global Auto-Revert mode.") > + Somehow, I'm not so comfortable with that name. Could we take `auto-revert-global-mode'? It is similar to `auto-revert-mode' and `auto-revert-tail-mode', with the disadvantage that there does not exist such a mode. Alternatively, we could create a local variable `global-autorevert-mode' in buffers which are tracked, and check always for that local value where it matters. > +(defun auto-revert--find-file-noselect-advice (buffer) > + "Adopt BUFFER for Global Auto-Revert if appropriate. > +Called with the return value of `find-file-noselect'." > + (auto-revert--global-add-buffer buffer) > + (auto-revert-set-timer) > + buffer) > + > +(defun auto-revert--after-change-major-mode () > + "Adopt the current buffer for Global Auto-Revert if appropriate. > +Called after the current buffer got a new major mode." > + (auto-revert--global-add-buffer (current-buffer)) > + (auto-revert-set-timer)) These are almost identical. Make argument buffer optional, and it is just one function. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 May 2019 12:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155749124225529 (code B ref 35418); Fri, 10 May 2019 12:28:01 +0000 Received: (at 35418) by debbugs.gnu.org; 10 May 2019 12:27:22 +0000 Received: from localhost ([127.0.0.1]:37393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP4cT-0006dh-N7 for submit@debbugs.gnu.org; Fri, 10 May 2019 08:27:21 -0400 Received: from mail223c50.megamailservers.eu ([91.136.10.233]:33910 helo=mail33c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP4cQ-0006dX-QS for 35418@debbugs.gnu.org; Fri, 10 May 2019 08:27:20 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557491236; bh=aJF+0ozd4HTSsWOW7EcpwmNhbE6xtWkGj8bdqceCOek=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=dnCLrU6CF1CagX2/cynrL/7fSgA04hQtmPLdJ0+Tds67rjzPT8oSrN3t//4eDwCZP 5wtu+n7IBcgQK3FAQxo6Ph29lq2Kk8+FGToPnS1z0a9m5RDbzRdAenOXHM5u5+aySu gxXBxqfh9tL5ja1LD9ZSks6udkpV/Vnc1/4Klrjk= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x4ACRE2Y019508; Fri, 10 May 2019 12:27:16 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <87muju1vx1.fsf@gmx.de> Date: Fri, 10 May 2019 14:27:14 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <25E4EBE0-0E65-45B7-B56F-9C67A2862DFA@acm.org> References: <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> <87muju1vx1.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0203.5CD56E24.0034, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=JcySU3CV c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=jIGDxYg4-gf8K34JcEMA:9 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 10 maj 2019 kl. 11.49 skrev Michael Albinus : > There is `find-file-hook'. If we need to hook into > `set-visited-file-name', we shall create a new hook > `after-set-visited-file-name', and run it there. Thank you, it looks like `find-file-hook' will do. It's = `set-visited-file-name' that lacks a hook. We could add one, = `after-visited-file-name-change-hook' say, and run it at the end of that = function. It would come in handy for fixing the write-file bug, too. That would suffice for this particular need, but we may contemplate some = variations for general utility, such as passing the old value of = buffer-file-name to the hook. It also wouldn't catch direct = modifications of buffer-file-name, but that mostly happens in special = buffers that we don't want to autorevert anyway (?). Perhaps we should exclude all buffers whose name start with a space from = any kind of auto-revert, just in case. >> +(defvar-local global-auto-revert--tracked-buffer nil >> + "Non-nil if buffer is handled by Global Auto-Revert mode.") >> + >=20 > Somehow, I'm not so comfortable with that name. Could we take > `auto-revert-global-mode'? It is similar to `auto-revert-mode' and > `auto-revert-tail-mode', with the disadvantage that there does not = exist > such a mode. Agreed, and I never liked that variable name much myself. What about = `auto-revert--global-mode'? (More names in autorevert.el should have = double dashes, but I suppose it was written before that convention came = along.) > Alternatively, we could create a local variable = `global-autorevert-mode' > in buffers which are tracked, and check always for that local value > where it matters. Possibly, but that sounds slightly more error-prone. >> +(defun auto-revert--find-file-noselect-advice (buffer) [..] >> +(defun auto-revert--after-change-major-mode () >=20 > These are almost identical. Make argument buffer optional, and it is > just one function. Good point, but the advice functions will probably be replaced anyway = per your request; let's see what it looks like when that is done. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 May 2019 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155749221826987 (code B ref 35418); Fri, 10 May 2019 12:44:02 +0000 Received: (at 35418) by debbugs.gnu.org; 10 May 2019 12:43:38 +0000 Received: from localhost ([127.0.0.1]:37405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP4sE-00071C-JQ for submit@debbugs.gnu.org; Fri, 10 May 2019 08:43:38 -0400 Received: from mout.gmx.net ([212.227.15.19]:34061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP4sC-00070y-UF for 35418@debbugs.gnu.org; Fri, 10 May 2019 08:43:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557492205; bh=3hG3EantjWcZHqhSKSjwJjmGKBPSch69HTvjthiV6CQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=PuhvjGhaB4Dq1qMM6FGjGbnjlIDvWogoYb2GmG72vyLsYJRTHbI058vxpqKwOY7lw k3Ep4Jj+EJBZ2cy3J69nEap25SqQ5JyVYIB+3XNDmxS3KNyvuF83rC1jSc0SSbLldt KexCH1mmPY6rVB/05M3ufCREuOsrNaHwLKq/Whts= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.91.238.102]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N33Ed-1ghwzg1iwv-013Og6; Fri, 10 May 2019 14:43:25 +0200 From: Michael Albinus References: <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> <87muju1vx1.fsf@gmx.de> <25E4EBE0-0E65-45B7-B56F-9C67A2862DFA@acm.org> Date: Fri, 10 May 2019 14:43:23 +0200 In-Reply-To: <25E4EBE0-0E65-45B7-B56F-9C67A2862DFA@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Fri, 10 May 2019 14:27:14 +0200") Message-ID: <87a7fu1nv8.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:MS5xF5Dsrw99x46eXsB5AQXgHojMCA/ac4Ppn9ihCYVhGESU4Yh 5jwYQ3W7pdzbTEG5g7tnqoLz6wlo89D+FxU2nfWN7uMgC3/0oFmd8QmZeGY8XPcB/GiXSt9 phPUlIfEGwBY6h+e8MY/f/iCfQac5rmjRHdaRtyFmyEXeQcksNggkIhKcT62dSfmedt31n0 mfNCWo8D9yRevW5ZTWSWQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:XHSpVtU4vC4=:oyoX331jUoeTXvyfpfnm8d eRYhwiqYOes0EuSXnbb8RG5z9wSH+zNr/SpiFZA0qwL3cYAcSMIJ0IkqtWMkgLKD1skMO0AFM gVx39K+qdKozmxx+EQg7mexXNOInMRfev4GHl4W7t2HFmj3gGrXSe6Iza3URxEA2j66lMBD5P 0flxtEaVvCUElS+Zh6v/qUkAIlvMnxRtEaJU+QvRTc0Vui5WN25/14f35O2NrEJPLwWkQNnN0 4sgZBHeYyAAsdHTR76SHhlknoIO1qwon3M/mYklfuE/m5BXqgeIoSqx23KAbsUzNsjwodYD08 HZMJncQ/UDPcEKiDVbYgBZehHQigCwiZoX8n7oqxV5f8inXTK8BYjJgZwFYSkVfD31cDT/6of 5eUo7rpOWV3clCO1sVr4LBOvZi9mvQHoC4gy611d54WOGB7x3SFJLchfijJBjIpXhQEvgwEZi Vwhe7XFqfHMgwH4RUYoX/avQNEmtIXs8K2OQ0iiEoLG7CW0bm9iQEMInQ1Ya+8gxtQCta9+Qw /HywGKObZYUet72JlJVrFKu7tNN/Q98s69ymHk9GGwOiUQEpcHBHoNhM8Xa9XZRfyLArK5DQ+ DAHazcc3ZdABvQFhBuYF0/gn61Me/qLhvnYKD1qwk2BEOA2Z/kw9YIBjsIy2zhLLhKfWwcGM7 fMqZwh+IqNXO7/HUw5U0mTLvHKVabGTZAv6ZPLOia13EJqz8xom65RGaUxF4bVlkj4bbibCsT xuR5U/64mZ6A/7staGZ3AjVBm2hTYAGTZzMGrjJkM91ZL5GQYAaLcDaFSIvg5x4xyMghOdiu+ oLui+LxNEeiMXdDkI36x9FpFf7x6y60VUMSmcL+SufIE/jF/TLEGzMlOr30Od7kok3nPBgPs3 bsG9u+y0GyckB5wxeLayZKXqtuHInN9IPnm77fXeIx1fLVfSNkPZQGdPirY9TCoNkCSKLHdbj LAhrLdJ+R0A== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: > That would suffice for this particular need, but we may contemplate > some variations for general utility, such as passing the old value of > buffer-file-name to the hook. It also wouldn't catch direct > modifications of buffer-file-name, but that mostly happens in special > buffers that we don't want to autorevert anyway (?). So we must document in the Elisp manual, that buffers, which want to participate in global-auto-revert-mode after a renaming, shall change the name via set-visited-file-name. > Perhaps we should exclude all buffers whose name start with a space > from any kind of auto-revert, just in case. Agreed. Those buffers are special (internal) anyway, it's already tricky to show them. Nobody needs auto-revert for invisible buffers :-) > Agreed, and I never liked that variable name much myself. What about > `auto-revert--global-mode'? (More names in autorevert.el should have > double dashes, but I suppose it was written before that convention > came along.) D'accord. >>> +(defun auto-revert--find-file-noselect-advice (buffer) > [..] >>> +(defun auto-revert--after-change-major-mode () >>=20 >> These are almost identical. Make argument buffer optional, and it is >> just one function. > > Good point, but the advice functions will probably be replaced anyway > per your request; let's see what it looks like when that is done. But they will convert to hook functions then ... Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 May 2019 15:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155750174811274 (code B ref 35418); Fri, 10 May 2019 15:23:02 +0000 Received: (at 35418) by debbugs.gnu.org; 10 May 2019 15:22:28 +0000 Received: from localhost ([127.0.0.1]:38794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP7Lw-0002vm-8e for submit@debbugs.gnu.org; Fri, 10 May 2019 11:22:28 -0400 Received: from mail150c50.megamailservers.eu ([91.136.10.160]:51324 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP7Lt-0002vc-D8 for 35418@debbugs.gnu.org; Fri, 10 May 2019 11:22:26 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557501743; bh=WaHU+KptL82/WXsweOSTsnY/KLblwmfkIg/Bo50cvU4=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=PBlahRBV8zhwoPQQJfHHOqKUQ93ZukKreJiMU0zca9Emp4rvEraWuOroA2aa/kw/d 8KRViiyh4Q/jgDV6ARW4oGTWwnYZbdv1WW4diuGcJDakxVRHLvx5kTCGXGrld/zxgR +Q2A/+bKQwhuHS9Cqxze+OlfPd6pPbEZ5TjlftHk= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x4AFML5W018644; Fri, 10 May 2019 15:22:22 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <877eazx2xd.fsf@gmx.de> Date: Fri, 10 May 2019 17:22:20 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> <877eazx2xd.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B020C.5CD5972F.0020, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=VLnzYeHX c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=EzgQuEQDeJhK2AgZHfwA:9 a=CDCg5Fwocg5l2FYt:21 a=ilD1vX9gK0kLtdcO:21 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 9 maj 2019 kl. 13.50 skrev Michael Albinus : > Thinking about, I'm even not confident that a static value of this > indication is sufficient. In dired, it might be set to t when the = dired > buffer is setup. But what if the dired buffer contains subdirectories? > Is it still possible to indicate this by file notifications over > default-directory? Don't know, maybe not, and the variable has to be = set > to nil ... There is a third possibility: a buffer requires polling, but could make = use of notification. The distinction is only important when = `auto-revert-avoid-polling' is set. For example, we could have, say, = `buffer-auto-revert-by-notification' take the values nil, notify-only = and notify-and-poll. This permits immediate updates for some changes = while still not keeping stale information indefinitely. On the other hand, maybe that sort of mode-specific complexity is better = left to the modes themselves? From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 May 2019 08:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155765092632328 (code B ref 35418); Sun, 12 May 2019 08:49:02 +0000 Received: (at 35418) by debbugs.gnu.org; 12 May 2019 08:48:46 +0000 Received: from localhost ([127.0.0.1]:41761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPkA2-0008PK-FX for submit@debbugs.gnu.org; Sun, 12 May 2019 04:48:46 -0400 Received: from mout.gmx.net ([212.227.15.19]:38461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPkA0-0008P3-3D for 35418@debbugs.gnu.org; Sun, 12 May 2019 04:48:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557650914; bh=0EAhkI0P3tB78KcA1bOTJWi5k9sf7fRopOJIydXEPP8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ITQHW8xmZdfC0u5jUnsT3SV883OXSGXYLFbNhpBWluU8XN6X4tGukGYNWyycNA09m cMBXXaRHVZc3u/PlEEmrwk+Dxt+I6516PUYjkeEpkMfs3uQGhIRYxOnIrZXyacHi8k iZnku7G1C39t2lFs+6pEHn92aeMFVDxypg9IJnyA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.91.238.102]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MId0S-1hRw1C1j1U-002HDF; Sun, 12 May 2019 10:48:34 +0200 From: Michael Albinus References: <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> <877eazx2xd.fsf@gmx.de> Date: Sun, 12 May 2019 10:48:32 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Fri, 10 May 2019 17:22:20 +0200") Message-ID: <878svcjbxb.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:2lTzC07Vk1ZHRSuerxZoImrTEE8N0dYnfZZNcarCJ0JoCnkZ+dT TVJqMUTGaQlDTFp2jYWMHt4O1lDAoMV5G+YGYk6NGp0Q5EFt7JX60C05+MUP4Y1Uxgg0cci vexbj7dW6zcFkm9/rPh0fxsmy5ai2hh/mqr6z5ihtd+EFQ/9fMuLWb59/EU8bJwBUWJJvgC wJtjNqkhyMKxBZqWsuQTA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/ExTVQ5lYgQ=:XUWHalyIErkiWIO3mPr00L g+8z6x1iMLAuumc4/mjwiU8ouItfEu0Q7ORPewlMK5MTkd7PtAFJJ9C5ggwEm7xOaaPgNXG3D SkGu5Yzo7dcnMRSMbXU3EBDQHP7c1gsiaj1WAQ6xQeejqRuAF2QAUnHEJu5cdIGYjBS13jGUQ bf/6jswoVyu307XuNAI7wOFclH2EWDfZzgKadCQgkBxA4BBb8ee74U8wfa/kHZGM9+Go/qeHR IQLWosbO2yxC2PuFmC7i/Cc8ofu+PMY4rpe+KKTHCtGcJ9P2uAryDkDVeMAqkjkNbQuuKwZPK UbveUA8ndiNgLfQNQ/C2BFQLY6my5VgK6MPr2SM0w27Q/QyPJPbMhvKwdrSUrtaV0XgtHeyhV UNN7WthQy2uxUkZXSN92oNnHlxs4Gtx6zTJkkFpEZFdNPoEkPEsOv1NgegyAmH2iLkICxN5sX gh//pw5fc4Fn1b85duAIIf/v0s7moaVTpnAsK44omfXmaeLEic1CbStZYrOFS5eFWSUEJHEof QexBF2VHC/dXywF08u/GNVSdgjCXwKsjcJX5uHG3CqNVxhHAlh5kiL/g6vEQmLPdA90Dl66e4 E+o7HaXHbjGNNVdiTTjiU8SvDdVnjPvy/sQW5vuZup/5kgeTn0EdJlqgfcHE6dDp4mHvlxhvz GC4rpFg8WZ5wpWHrIb3CrzsvIE+tptl4SxXjhxDqgCs/66/XVTx9gUXXsAuvomdkkb8npFGqe 7zGYlpzhXKKqZnBgQm7zJpczcJ5+fHKQo/EN7hZW8szmlZnjsz6UTSqDTnJK8wW2Oe1DJfytS 0P3Zcnd15A4djmrZYBiw2l5u6UW7jRuD+7B0/DeH0W5Ysq35bOXikZhIAP3n729bNcmykVHH9 6A8/3v/QiPfz5WafgcXPzru9FxJU3MDB+aEIxqBi+0knBVg9K1PBGo0tM8OmsTkJlmHJAl+vi Kc4l5umid3Q== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, >> Thinking about, I'm even not confident that a static value of this >> indication is sufficient. In dired, it might be set to t when the dired >> buffer is setup. But what if the dired buffer contains subdirectories? >> Is it still possible to indicate this by file notifications over >> default-directory? Don't know, maybe not, and the variable has to be set >> to nil ... > > There is a third possibility: a buffer requires polling, but could > make use of notification. The distinction is only important when > `auto-revert-avoid-polling' is set. For example, we could have, say, > `buffer-auto-revert-by-notification' take the values nil, notify-only > and notify-and-poll. This permits immediate updates for some changes > while still not keeping stale information indefinitely. I haven't seen this requirement yet for any mode. Let's postpone this, until there is a real request for this kind of distinction. Furthermore, we shouldn't expect a deep knowledge from major mode writers about the internals of auto-revert. People might have a hard time to understand the difference between notify-only and notify-and-poll. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 May 2019 19:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15576905808544 (code B ref 35418); Sun, 12 May 2019 19:50:02 +0000 Received: (at 35418) by debbugs.gnu.org; 12 May 2019 19:49:40 +0000 Received: from localhost ([127.0.0.1]:43386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPuTc-0002Dk-3c for submit@debbugs.gnu.org; Sun, 12 May 2019 15:49:40 -0400 Received: from mail233c50.megamailservers.eu ([91.136.10.243]:33328 helo=mail37c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPuTZ-0002Da-2x for 35418@debbugs.gnu.org; Sun, 12 May 2019 15:49:38 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557690575; bh=Ox0KsSPl+gRwNHH3rVLBldaARmxPiRrqKRsu8vPjgrc=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=TjTerMujmv3OW/E9x2J2jDZOjVGm8MaK0pKojNSEzyBbkRlEUizvnO1FJXYXcP/KM xZu4gOoNlZZBcJCaswCP8w9DVOb25B4msem7bP/39ANXzzRd+ynjwtNogaraJ6RhR8 bSrNph9xtnVG/5/ke7FzD5lqpItbWCCKzftgYxL0= Feedback-ID: mattiase@acm.or Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x4CJnXQt023974; Sun, 12 May 2019 19:49:35 +0000 Message-ID: From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Date: Sun, 12 May 2019 21:49:33 +0200 In-Reply-To: <878svcjbxb.fsf@gmx.de> References: <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> <877eazx2xd.fsf@gmx.de> <878svcjbxb.fsf@gmx.de> Content-Type: multipart/mixed; boundary="=-WUM65K2FweaOh+iEN88V" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 X-CTCH-RefID: str=0001.0A0B0207.5CD878CF.0025, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=ItQwjo3g c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=AeUcWHcRN_QXrfWhrcQA:9 a=QEXdDO2ut3YA:10 a=N54-gffFAAAA:8 a=R2M-SNEywa8nnAsh55UA:9 a=kQ2ky3TMMz_0fWhS:21 a=1XFvvSfLSLKKX_x6:21 a=B2y7HmGcmWMA:10 a=6l0D2HzqY3Epnrm8mE3f:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-WUM65K2FweaOh+iEN88V Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit sön 2019-05-12 klockan 10:48 +0200 skrev Michael Albinus: > > I haven't seen this requirement yet for any mode. Let's postpone > this, > until there is a real request for this kind of distinction. Very well. Here is an updated patch, with a new buffer-local variable controlling whether non-file buffers can rely on notification in autorevert. --=-WUM65K2FweaOh+iEN88V Content-Disposition: attachment; filename="0001-Don-t-use-file-notification-on-non-file-buffers.patch" Content-Type: text/x-patch; name="0001-Don-t-use-file-notification-on-non-file-buffers.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAzMjQwZDQ5NTBlZWNjZjZlMzJiOWQ3MWQwZmE4YmJiOWRmY2JiYjg5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWF0dGlhcz0yMEVuZ2RlZz1DMz1BNXJkPz0g PG1hdHRpYXNlQGFjbS5vcmc+CkRhdGU6IFdlZCwgOCBNYXkgMjAxOSAwMDowMjo1OSArMDIwMApT dWJqZWN0OiBbUEFUQ0hdIERvbid0IHVzZSBmaWxlIG5vdGlmaWNhdGlvbiBvbiBub24tZmlsZSBi dWZmZXJzCgpNb3N0IG5vbi1maWxlIGJ1ZmZlcnMgYXJlbid0IHNlcnZlZCBieSBmaWxlIG5vdGlm aWNhdGlvbiBpbgphdXRvLXJldmVydCBtb2RlOyB0eXBpY2FsbHksIHRoZXkgbmVlZCB0byBiZSBw b2xsZWQsIGxpa2UgdGhlIEJ1ZmZlciBMaXN0LgpXaXRoIGBhdXRvLXJldmVydC1hdm9pZC1wb2xs aW5nJywgc2V0dGluZyBhIHVzZWxlc3Mgbm90aWZpY2F0aW9uIG1lYW5zCnRoYXQgc3VjaCBidWZm ZXJzIG1heSBuZXZlciBiZSB1cGRhdGVkIGF0IGFsbCAoYnVnIzM1NDE4KS4KCk5vbi1maWxlIGJ1 ZmZlcnMgY2FuIGV4cGxpY2l0bHkgZGVjbGFyZSB0aGF0IG5vdGlmaWNhdGlvbiBvbiB0aGVpcgpk ZWZhdWx0LWRpcmVjdG9yeSBpcyBzdWZmaWNpZW50IHRvIGtub3cgd2hlbiB1cGRhdGVzIGFyZSBy ZXF1aXJlZApieSBzZXR0aW5nIHRoZSBuZXcgdmFyaWFibGUgYGJ1ZmZlci1hdXRvLXJldmVydC1i eS1ub3RpZmljYXRpb24nIHRvCmEgbm9uLW5pbCB2YWx1ZS4KCiogbGlzcC9hdXRvcmV2ZXJ0LmVs IChhdXRvLXJldmVydC1idWZmZXJzKToKTW9kaWZ5IGNvbmRpdGlvbiBmb3IgdXNpbmcgbm90aWZp Y2F0aW9uLgoqIGxpc3AvZmlsZXMuZWwgKGJ1ZmZlci1hdXRvLXJldmVydC1ieS1ub3RpZmljYXRp b24pOiBOZXcgdmFyaWFibGUuCiogbGlzcC9kaXJlZC5lbCAoZGlyZWQtbW9kZSk6IFNldCBidWZm ZXItYXV0by1yZXZlcnQtYnktbm90aWZpY2F0aW9uLgoqIGRvYy9lbWFjcy9hcmV2ZXJ0LXh0cmEu dGV4aSAoTm9uLUZpbGUgQnVmZmVycyk6IERvY3VtZW50IG5ldyB2YXJpYWJsZS4KKiBldGMvTkVX UyAoQ2hhbmdlcyBpbiBTcGVjaWFsaXplZCBNb2RlcyBhbmQgUGFja2FnZXMpOiBEZXNjcmliZSBu ZXcgdmFyaWFibGUuCi0tLQogZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50ZXhpIHwgIDggKysrKysr KysKIGV0Yy9ORVdTICAgICAgICAgICAgICAgICAgICB8ICA4ICsrKysrKysrCiBsaXNwL2F1dG9y ZXZlcnQuZWwgICAgICAgICAgfCAgNiArKysrKy0KIGxpc3AvZGlyZWQuZWwgICAgICAgICAgICAg ICB8ICAxICsKIGxpc3AvZmlsZXMuZWwgICAgICAgICAgICAgICB8IDEwICsrKysrKysrKysKIDUg ZmlsZXMgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdp dCBhL2RvYy9lbWFjcy9hcmV2ZXJ0LXh0cmEudGV4aSBiL2RvYy9lbWFjcy9hcmV2ZXJ0LXh0cmEu dGV4aQppbmRleCA5ZTAxYTEwYWNlLi40YTJjOGM4OTQyIDEwMDY0NAotLS0gYS9kb2MvZW1hY3Mv YXJldmVydC14dHJhLnRleGkKKysrIGIvZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50ZXhpCkBAIC0z NSw2ICszNSwxNCBAQCBOb24tRmlsZSBCdWZmZXJzCiBtZXNzYWdlcyB3aGlsZSByZXZlcnRpbmcs IGV2ZW4gd2hlbiBAY29kZXthdXRvLXJldmVydC12ZXJib3NlfSBpcwogbm9uLUBjb2Rle25pbH0u CiAKK0B2aW5kZXggYnVmZmVyLWF1dG8tcmV2ZXJ0LWJ5LW5vdGlmaWNhdGlvbgorU29tZSBub24t ZmlsZSBidWZmZXJzIGNhbiBiZSB1cGRhdGVkIHJlbGlhYmx5IGJ5IGZpbGUgbm90aWZpY2F0aW9u IG9uCit0aGVpciBkZWZhdWx0IGRpcmVjdG9yeS4gIFRoaXMgY2FuIGJlIGluZGljYXRlZCBieSBz ZXR0aW5nCitAY29kZXtidWZmZXItYXV0by1yZXZlcnQtYnktbm90aWZpY2F0aW9ufSB0byBhIG5v bi1AY29kZXtuaWx9IHZhbHVlIGluCit0aGF0IGJ1ZmZlciwgYWxsb3dpbmcgQXV0byBSZXZlcnQg dG8gYXZvaWQgcGVyaW9kaWMgcG9sbGluZy4gIFN1Y2gKK25vdGlmaWNhdGlvbiBkb2VzIG5vdCBp bmNsdWRlIGNoYW5nZXMgdG8gZmlsZXMgaW4gdGhhdCBkaXJlY3RvcnksIG9ubHkKK3RvIHRoZSBk aXJlY3RvcnkgaXRzZWxmLgorCiBUaGUgZGV0YWlscyBkZXBlbmQgb24gdGhlIHBhcnRpY3VsYXIg dHlwZXMgb2YgYnVmZmVycyBhbmQgYXJlCiBleHBsYWluZWQgaW4gdGhlIGNvcnJlc3BvbmRpbmcg c2VjdGlvbnMuCiAKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggZDEwYTU1 MzI0NC4uNjY5YWRmZWEyYSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAg LTE0MjIsNiArMTQyMiwxNCBAQCBvZiBhbiBpZGxlIEVtYWNzLCBidXQgbWF5IGZhaWwgb24gc29t ZSBuZXR3b3JrIGZpbGUgc3lzdGVtczsgc2V0CiBub3RpZmljYXRpb24gaXMgbm90IHN1cHBvcnRl ZC4gIFRoZSBuZXcgdmFyaWFibGUgY3VycmVudGx5IGhhcyBubwogZWZmZWN0IGluICdnbG9iYWwt YXV0by1yZXZlcnQtbW9kZScuICBUaGUgZGVmYXVsdCB2YWx1ZSBpcyBuaWwuCiAKKyoqKiBOZXcg dmFyaWFibGUgJ2J1ZmZlci1hdXRvLXJldmVydC1ieS1ub3RpZmljYXRpb24nCitOb24tZmlsZSBi dWZmZXJzIGNhbiBleHBsaWNpdGx5IGRlY2xhcmUgdGhhdCBub3RpZmljYXRpb24gb24gdGhlaXIK K2RlZmF1bHQtZGlyZWN0b3J5IGlzIHN1ZmZpY2llbnQgdG8ga25vdyB3aGVuIHVwZGF0ZXMgYXJl IHJlcXVpcmVkIGJ5CitzZXR0aW5nIHRoZSBuZXcgdmFyaWFibGUgYGJ1ZmZlci1hdXRvLXJldmVy dC1ieS1ub3RpZmljYXRpb24nIHRvIGEKK25vbi1uaWwgdmFsdWUgaW4gdGhhdCBidWZmZXIuICBB dXRvIFJldmVydCBtb2RlIGNhbiB1c2UgdGhpcworaW5mb3JtYXRpb24gdG8gYXZvaWQgcG9sbGlu ZyB0aGUgYnVmZmVyIHBlcmlvZGljYWxseSB3aGVuCisnYXV0by1yZXZlcnQtYXZvaWQtcG9sbGlu ZycgaXMgbm9uLW5pbC4KKwogDAogKiBOZXcgTW9kZXMgYW5kIFBhY2thZ2VzIGluIEVtYWNzIDI3 LjEKIApkaWZmIC0tZ2l0IGEvbGlzcC9hdXRvcmV2ZXJ0LmVsIGIvbGlzcC9hdXRvcmV2ZXJ0LmVs CmluZGV4IDdjZDVlN2VlOGIuLjE5N2EyYmYxNTcgMTAwNjQ0Ci0tLSBhL2xpc3AvYXV0b3JldmVy dC5lbAorKysgYi9saXNwL2F1dG9yZXZlcnQuZWwKQEAgLTg1OCw4ICs4NTgsMTIgQEAgYXV0by1y ZXZlcnQtYnVmZmVycwogICAgICAgICAgICAgICAgICAgKGF1dG8tcmV2ZXJ0LXJlbW92ZS1jdXJy ZW50LWJ1ZmZlcikpCiAgICAgICAgICAgICAgICh3aGVuIChhdXRvLXJldmVydC1hY3RpdmUtcCkK ICAgICAgICAgICAgICAgICA7OyBFbmFibGUgZmlsZSBub3RpZmljYXRpb24uCisgICAgICAgICAg ICAgICAgOzsgRG9uJ3QgYm90aGVyIGNyZWF0aW5nIGEgbm90aWZpZXIgZm9yIG5vbi1maWxlIGJ1 ZmZlcnMKKyAgICAgICAgICAgICAgICA7OyB1bmxlc3MgaXQgZXhwbGljaXRseSBpbmRpY2F0ZXMg dGhhdCB0aGlzIHdvcmtzLgogICAgICAgICAgICAgICAgICh3aGVuIChhbmQgYXV0by1yZXZlcnQt dXNlLW5vdGlmeQotICAgICAgICAgICAgICAgICAgICAgICAgICAgKG5vdCBhdXRvLXJldmVydC1u b3RpZnktd2F0Y2gtZGVzY3JpcHRvcikpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAobm90 IGF1dG8tcmV2ZXJ0LW5vdGlmeS13YXRjaC1kZXNjcmlwdG9yKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgKG9yIGJ1ZmZlci1maWxlLW5hbWUKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBidWZmZXItYXV0by1yZXZlcnQtYnktbm90aWZpY2F0aW9uKSkKICAgICAgICAgICAgICAg ICAgIChhdXRvLXJldmVydC1ub3RpZnktYWRkLXdhdGNoKSkKICAgICAgICAgICAgICAgICAoYXV0 by1yZXZlcnQtaGFuZGxlcikpKSkpCiAJKHNldHEgYnVmcyAoY2RyIGJ1ZnMpKSkKZGlmZiAtLWdp dCBhL2xpc3AvZGlyZWQuZWwgYi9saXNwL2RpcmVkLmVsCmluZGV4IDM4NTEyNjUxNGIuLmVhMTk0 M2RlMWQgMTAwNjQ0Ci0tLSBhL2xpc3AvZGlyZWQuZWwKKysrIGIvbGlzcC9kaXJlZC5lbApAQCAt MjE0OCw2ICsyMTQ4LDcgQEAgZGlyZWQtbW9kZQogICAgIChzZXRxIGJ1ZmZlci1pbnZpc2liaWxp dHktc3BlYyAobGlzdCB0KSkpCiAgIChzZXRxLWxvY2FsIHJldmVydC1idWZmZXItZnVuY3Rpb24g IydkaXJlZC1yZXZlcnQpCiAgIChzZXRxLWxvY2FsIGJ1ZmZlci1zdGFsZS1mdW5jdGlvbiAjJ2Rp cmVkLWJ1ZmZlci1zdGFsZS1wKQorICAoc2V0cS1sb2NhbCBidWZmZXItYXV0by1yZXZlcnQtYnkt bm90aWZpY2F0aW9uIHQpCiAgIChzZXRxLWxvY2FsIHBhZ2UtZGVsaW1pdGVyICJcblxuIikKICAg KHNldHEtbG9jYWwgZGlyZWQtZGlyZWN0b3J5IChvciBkaXJuYW1lIGRlZmF1bHQtZGlyZWN0b3J5 KSkKICAgOzsgbGlzdC1idWZmZXJzIHVzZXMgdGhpcyB0byBkaXNwbGF5IHRoZSBkaXIgYmVpbmcg ZWRpdGVkIGluIHRoaXMgYnVmZmVyLgpkaWZmIC0tZ2l0IGEvbGlzcC9maWxlcy5lbCBiL2xpc3Av ZmlsZXMuZWwKaW5kZXggODQ3N2MyMjdiYy4uYmVjYjVhYWI2ZiAxMDA2NDQKLS0tIGEvbGlzcC9m aWxlcy5lbAorKysgYi9saXNwL2ZpbGVzLmVsCkBAIC01ODQzLDYgKzU4NDMsMTYgQEAgYnVmZmVy LXN0YWxlLWZ1bmN0aW9uCiBGb3IgbW9yZSBpbmZvcm1hdGlvbiBvbiBob3cgdGhpcyB2YXJpYWJs ZSBpcyB1c2VkIGJ5IEF1dG8gUmV2ZXJ0IG1vZGUsCiBzZWUgSW5mbyBub2RlIGAoZW1hY3MpU3Vw cG9ydGluZyBhZGRpdGlvbmFsIGJ1ZmZlcnMnLiIpCiAKKyhkZWZ2YXItbG9jYWwgYnVmZmVyLWF1 dG8tcmV2ZXJ0LWJ5LW5vdGlmaWNhdGlvbiBuaWwKKyAgIldoZXRoZXIgYSBidWZmZXIgY2FuIHJl bHkgb24gbm90aWZpY2F0aW9uIGluIEF1dG8tUmV2ZXJ0IG1vZGUuCitJZiBub24tbmlsLCBtb25p dG9yaW5nIGNoYW5nZXMgdG8gdGhlIGRpcmVjdG9yeSBvZiB0aGUgY3VycmVudAorYnVmZmVyIGlz IHN1ZmZpY2llbnQgZm9yIGtub3dpbmcgd2hlbiB0aGF0IGJ1ZmZlciBuZWVkcyB0byBiZQordXBk YXRlZCBpbiBBdXRvIFJldmVydCBNb2RlLiAgU3VjaCBub3RpZmljYXRpb24gZG9lcyBub3QgaW5j bHVkZQorY2hhbmdlcyB0byBmaWxlcyBpbiB0aGF0IGRpcmVjdG9yeSwgb25seSB0byB0aGUgZGly ZWN0b3J5IGl0c2VsZi4KKworVGhpcyB2YXJpYWJsZSBvbmx5IGFwcGxpZXMgdG8gYnVmZmVycyB3 aGVyZSBgYnVmZmVyLWZpbGUtbmFtZScgaXMKK25pbDsgb3RoZXIgYnVmZmVycyBhcmUgdHJhY2tl ZCBieSB0aGVpciBmaWxlcy4iKQorCiAoZGVmdmFyIGJlZm9yZS1yZXZlcnQtaG9vayBuaWwKICAg Ik5vcm1hbCBob29rIGZvciBgcmV2ZXJ0LWJ1ZmZlcicgdG8gcnVuIGJlZm9yZSByZXZlcnRpbmcu CiBUaGUgZnVuY3Rpb24gYHJldmVydC1idWZmZXItLWRlZmF1bHQnIHJ1bnMgdGhpcy4KLS0gCjIu MjAuMQoK --=-WUM65K2FweaOh+iEN88V-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 May 2019 11:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155774730824007 (code B ref 35418); Mon, 13 May 2019 11:36:02 +0000 Received: (at 35418) by debbugs.gnu.org; 13 May 2019 11:35:08 +0000 Received: from localhost ([127.0.0.1]:44323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ9EZ-0006F8-H1 for submit@debbugs.gnu.org; Mon, 13 May 2019 07:35:08 -0400 Received: from mail172c50.megamailservers.eu ([91.136.10.182]:43146 helo=mail33c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ9EW-0006Ev-2F for 35418@debbugs.gnu.org; Mon, 13 May 2019 07:35:05 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557747301; bh=xd01G4Axy4Be9h3Udwpu0koRVypF+NMLtRcG57SZOfQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=X6RVWJ3tE27w9R7l0OkvvCwrgWmTbYu6gwpnNBG1L1S4fnrrSZOWVOqQnOiuG076A G7UzbM+xHyB0Lmwu/ZVzVOypZcz03uEHrUahZIyiaHpQY396AEFQp+ug5eKkQqACKI Lp6MK/hJ0Ui4k4mYU941n07biPK65XQ1+srUnjKY= Feedback-ID: mattiase@acm.or Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x4DBYxFl023219; Mon, 13 May 2019 11:35:01 +0000 Message-ID: From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Date: Mon, 13 May 2019 13:34:59 +0200 In-Reply-To: <87a7fu1nv8.fsf@gmx.de> References: <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> <87muju1vx1.fsf@gmx.de> <25E4EBE0-0E65-45B7-B56F-9C67A2862DFA@acm.org> <87a7fu1nv8.fsf@gmx.de> Content-Type: multipart/mixed; boundary="=-T7U6s0S2T0wBcZWONeYx" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 X-CTCH-RefID: str=0001.0A0B0214.5CD95665.0091, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=QN9GuDDL c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=N54-gffFAAAA:8 a=7VFau2qFCTVv8GlCP5YA:9 a=QEXdDO2ut3YA:10 a=z6dYpQrSir3Hf6Dhp34A:9 a=GWTlUy6PsLpu0fSZ:21 a=SOQyQLoOrRqkqdpK:21 a=B2y7HmGcmWMA:10 a=6l0D2HzqY3Epnrm8mE3f:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-T7U6s0S2T0wBcZWONeYx Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit fre 2019-05-10 klockan 14:43 +0200 skrev Michael Albinus: > Mattias Engdegård writes: > > So we must document in the Elisp manual, that buffers, which want to > participate in global-auto-revert-mode after a renaming, shall change > the name via set-visited-file-name. Are you sure about that? It sounds quite technical. But if you think it is necessary, I'll add it. > > > Perhaps we should exclude all buffers whose name start with a space > > from any kind of auto-revert, just in case. > > Agreed. Those buffers are special (internal) anyway, it's already > tricky > to show them. Nobody needs auto-revert for invisible buffers :-) The revised patch now excludes such non-file buffers. I wonder if buffers with file names should be excluded as well. They trivially occur when visiting a file whose name starts with a space. The new patch also has the tracking variable renamed to `auto-revert--global-mode' and added a new hook, `after-set-visited-file-name'; the advice calls are gone. --=-T7U6s0S2T0wBcZWONeYx Content-Disposition: attachment; filename="0001-Avoid-polling-in-global-auto-revert-mode.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Avoid-polling-in-global-auto-revert-mode.patch"; charset="UTF-8" RnJvbSA3ZGFiZjYxYTQ3YTIwZjQ1ZWNiN2UyNGU5OGZjZjczNWY2YWIxYmQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWF0dGlhcz0yMEVuZ2RlZz1DMz1BNXJkPz0g PG1hdHRpYXNlQGFjbS5vcmc+CkRhdGU6IFRodSwgOSBNYXkgMjAxOSAwOTo0MDo0NiArMDIwMApT dWJqZWN0OiBbUEFUQ0hdIEF2b2lkIHBvbGxpbmcgaW4gZ2xvYmFsLWF1dG8tcmV2ZXJ0LW1vZGUK Ck1ha2UgYGF1dG8tcmV2ZXJ0LWF2b2lkLXBvbGxpbmcnIGhhdmUgZWZmZWN0IGluIGdsb2JhbC1h dXRvLXJldmVydC1tb2RlLgpCdWZmZXJzIGFjdHVhbGx5IGhhbmRsZWQgYnkgdGhhdCBtb2RlIGFy ZSBtYXJrZWQgd2l0aCBhIG5vbi1uaWwgdmFsdWUKb2YgYGF1dG8tcmV2ZXJ0LS1nbG9iYWwtbW9k ZScuICBXaGVuIGdsb2JhbC1hdXRvLXJldmVydC1tb2RlIGlzCmVudGVyZWQsIGVsaWdpYmxlIGJ1 ZmZlcnMgYXJlIG1hcmtlZCBpbiB0aGF0IHdheSwgYW5kIGhvb2tzIGFyZSBzZXQgdXAKdG8gbWFy ayBuZXcgYnVmZmVycyBhbmQgdGFrZSBjYXJlIG9mIGJ1ZmZlcnMgd2hvc2UgZmlsZSBuYW1lcyBj aGFuZ2UuClRoaXMgd2F5IHRoZSBleGlzdGluZyBwb2xsLWF2b2lkYW5jZSBsb2dpYyBjYW4gYmUg dXNlZCwgc2luY2UgdGhlCmVudGlyZSBzZXQgb2YgYnVmZmVycyBpbiBhdXRvLXJldmVydCBpcyBr bm93bi4KCkEgbmV3IGhvb2ssIGBhZnRlci1zZXQtdmlzaXRlZC1maWxlLW5hbWUtaG9vaycsIHdh cyBhZGRlZCB0byBoYW5kbGUKdGhlIGNhc2Ugd2hlbiB0aGUgZmlsZSBuYW1lIG9mIGEgdHJhY2tl ZCBidWZmZXIgY2hhbmdlcy4KCihCdWcjMzU0MTgpLgoKKiBsaXNwL2F1dG9yZXZlcnQuZWwgKGF1 dG8tcmV2ZXJ0LWF2b2lkLXBvbGxpbmcpOiBBbWVuZCBkb2Mgc3RyaW5nLgooYXV0by1yZXZlcnQt LWdsb2JhbC1tb2RlKTogTmV3IGJ1ZmZlci1sb2NhbCB2YXJpYWJsZS4KKGdsb2JhbC1hdXRvLXJl dmVydC1tb2RlKTogTWFyayBleGlzdGluZyBidWZmZXJzIGFuZCBzZXQgdXAgaG9va3Mgd2hlbgpt b2RlIGlzIGVudGVyZWQ7IGRvIHRoZSBvcHBvc2l0ZSB3aGVuIGV4aXRlZC4KKGF1dG8tcmV2ZXJ0 LS1nbG9iYWwtYWRkLWN1cnJlbnQtYnVmZmVyKQooYXV0by1yZXZlcnQtLWdsb2JhbC1hZG9wdC1j dXJyZW50LWJ1ZmZlcikKKGF1dG8tcmV2ZXJ0LS1zZXQtdmlzaXRlZC1maWxlLW5hbWUtYWR2aWNl KTogTmV3IGZ1bmN0aW9ucy4KKGF1dG8tcmV2ZXJ0LS1wb2xsZWQtYnVmZmVycywgYXV0by1yZXZl cnQtLW5lZWQtcG9sbGluZy1wKQooYXV0by1yZXZlcnQtbm90aWZ5LWhhbmRsZXIpCihhdXRvLXJl dmVydC1hY3RpdmUtcCk6IE1vZGlmeSBsb2dpYyB0byBjb3ZlciBnbG9iYWwtYXV0by1yZXZlcnQt bW9kZS4KKiBsaXNwL2ZpbGVzLmVsIChhZnRlci1zZXQtdmlzaXRlZC1maWxlLW5hbWUtaG9vayk6 IE5ldyBob29rLgooc2V0LXZpc2l0ZWQtZmlsZS1uYW1lLWhvb2spOiBDYWxsIG5ldyBob29rLgoq IGRvYy9saXNwcmVmL2hvb2tzLnRleGkgKFN0YW5kYXJkIEhvb2tzKToKTWVudGlvbiBuZXcgaG9v ayAoaW4gYSBjb21tZW50LCBzaW5jZSBpdCdzIHVuY2xlYXIgd2hldGhlciBpdCBzaG91bGQKYWN0 dWFsbHkgYmUgZG9jdW1lbnRlZCBoZXJlKQoqIGV0Yy9ORVdTIChDaGFuZ2VzIGluIFNwZWNpYWxp emVkIE1vZGVzIGFuZCBQYWNrYWdlcyk6IFVwZGF0ZSBlbnRyeS4KLS0tCiBkb2MvbGlzcHJlZi9o b29rcy50ZXhpIHwgICAxICsKIGV0Yy9ORVdTICAgICAgICAgICAgICAgfCAgIDMgKy0KIGxpc3Av YXV0b3JldmVydC5lbCAgICAgfCAxMjIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0KIGxpc3AvZmlsZXMuZWwgICAgICAgICAgfCAgIDYgKy0KIDQgZmlsZXMgY2hhbmdl ZCwgMTAzIGluc2VydGlvbnMoKyksIDI5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9s aXNwcmVmL2hvb2tzLnRleGkgYi9kb2MvbGlzcHJlZi9ob29rcy50ZXhpCmluZGV4IDcxOTkyNDY0 ZTAuLmY3NzVhYTRkNGIgMTAwNjQ0Ci0tLSBhL2RvYy9saXNwcmVmL2hvb2tzLnRleGkKKysrIGIv ZG9jL2xpc3ByZWYvaG9va3MudGV4aQpAQCAtMjUxLDYgKzI1MSw3IEBAIFN0YW5kYXJkIEhvb2tz CiAKIExpc3A6CiBhZnRlci1sb2FkLWZ1bmN0aW9ucworYWZ0ZXItc2V0LXZpc2l0ZWQtZmlsZS1u YW1lLWhvb2sKIGF1dG8tY29kaW5nLWZ1bmN0aW9ucwogY2hvb3NlLWNvbXBsZXRpb24tc3RyaW5n LWZ1bmN0aW9ucwogY29tcGxldGluZy1yZWFkLWZ1bmN0aW9uCmRpZmYgLS1naXQgYS9ldGMvTkVX UyBiL2V0Yy9ORVdTCmluZGV4IDQzYWQ4YmUxY2MuLjY0MWZjOGUxMTYgMTAwNjQ0Ci0tLSBhL2V0 Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0xNDI1LDggKzE0MjUsNyBAQCBXaGVuIHNldCB0byBh IG5vbi1uaWwgdmFsdWUsIGJ1ZmZlcnMgaW4gQXV0byBSZXZlcnQgbW9kZSBhcmUgbm8gbG9uZ2Vy CiBwb2xsZWQgZm9yIGNoYW5nZXMgcGVyaW9kaWNhbGx5LiAgVGhpcyByZWR1Y2VzIHRoZSBwb3dl ciBjb25zdW1wdGlvbgogb2YgYW4gaWRsZSBFbWFjcywgYnV0IG1heSBmYWlsIG9uIHNvbWUgbmV0 d29yayBmaWxlIHN5c3RlbXM7IHNldAogJ2F1dG8tcmV2ZXJ0LW5vdGlmeS1leGNsdWRlLWRpci1y ZWdleHAnIHRvIG1hdGNoIGZpbGVzIHdoZXJlCi1ub3RpZmljYXRpb24gaXMgbm90IHN1cHBvcnRl ZC4gIFRoZSBuZXcgdmFyaWFibGUgY3VycmVudGx5IGhhcyBubwotZWZmZWN0IGluICdnbG9iYWwt YXV0by1yZXZlcnQtbW9kZScuICBUaGUgZGVmYXVsdCB2YWx1ZSBpcyBuaWwuCitub3RpZmljYXRp b24gaXMgbm90IHN1cHBvcnRlZC4gIFRoZSBkZWZhdWx0IHZhbHVlIGlzIG5pbC4KIAogDAogKiBO ZXcgTW9kZXMgYW5kIFBhY2thZ2VzIGluIEVtYWNzIDI3LjEKZGlmZiAtLWdpdCBhL2xpc3AvYXV0 b3JldmVydC5lbCBiL2xpc3AvYXV0b3JldmVydC5lbAppbmRleCA3Y2Q1ZTdlZThiLi4xYmYyOWYw NGY0IDEwMDY0NAotLS0gYS9saXNwL2F1dG9yZXZlcnQuZWwKKysrIGIvbGlzcC9hdXRvcmV2ZXJ0 LmVsCkBAIC0zMTIsMTAgKzMxMiw3IEBAIGF1dG8tcmV2ZXJ0LWF2b2lkLXBvbGxpbmcKIAogV2hl biBuaWwsIGJ1ZmZlcnMgaW4gQXV0by1SZXZlcnQgTW9kZSB3aWxsIGFsd2F5cyBiZSBwb2xsZWQg Zm9yCiBjaGFuZ2VzIHRvIHRoZWlyIGZpbGVzIG9uIGRpc2sgZXZlcnkgYGF1dG8tcmV2ZXJ0LWlu dGVydmFsJwotc2Vjb25kcywgaW4gYWRkaXRpb24gdG8gdXNpbmcgbm90aWZpY2F0aW9uIGZvciB0 aG9zZSBmaWxlcy4KLQotSW4gR2xvYmFsIEF1dG8tUmV2ZXJ0IE1vZGUsIHBvbGxpbmcgaXMgYWx3 YXlzIGRvbmUgcmVnYXJkbGVzcyBvZgotdGhlIHZhbHVlIG9mIHRoaXMgdmFyaWFibGUuIgorc2Vj b25kcywgaW4gYWRkaXRpb24gdG8gdXNpbmcgbm90aWZpY2F0aW9uIGZvciB0aG9zZSBmaWxlcy4i CiAgIDpncm91cCAnYXV0by1yZXZlcnQKICAgOnR5cGUgJ2Jvb2xlYW4KICAgOnNldCAobGFtYmRh ICh2YXJpYWJsZSB2YWx1ZSkKQEAgLTMzNSw2ICszMzIsOSBAQCBhdXRvLXJldmVydC1idWZmZXIt bGlzdAogVGhlIHRpbWVyIGZ1bmN0aW9uIGBhdXRvLXJldmVydC1idWZmZXJzJyBpcyByZXNwb25z aWJsZSBmb3IgcHVyZ2luZwogdGhlIGxpc3Qgb2Ygb2xkIGJ1ZmZlcnMuIikKIAorKGRlZnZhci1s b2NhbCBhdXRvLXJldmVydC0tZ2xvYmFsLW1vZGUgbmlsCisgICJOb24tbmlsIGlmIGJ1ZmZlciBp cyBoYW5kbGVkIGJ5IEdsb2JhbCBBdXRvLVJldmVydCBtb2RlLiIpCisKIChkZWZ2YXIgYXV0by1y ZXZlcnQtcmVtYWluaW5nLWJ1ZmZlcnMgKCkKICAgIkJ1ZmZlcnMgbm90IGNoZWNrZWQgd2hlbiB1 c2VyIGlucHV0IHN0b3BwZWQgZXhlY3V0aW9uLiIpCiAKQEAgLTUwMSwzNCArNTAxLDEwNyBAQCBn bG9iYWwtYXV0by1yZXZlcnQtbW9kZQogICA6Z2xvYmFsIHQgOmdyb3VwICdhdXRvLXJldmVydCA6 bGlnaHRlciBnbG9iYWwtYXV0by1yZXZlcnQtbW9kZS10ZXh0CiAgIChhdXRvLXJldmVydC1zZXQt dGltZXIpCiAgIChpZiBnbG9iYWwtYXV0by1yZXZlcnQtbW9kZQotICAgICAgKGF1dG8tcmV2ZXJ0 LWJ1ZmZlcnMpCisgICAgICA7OyBUdXJuIGdsb2JhbC1hdXRvLXJldmVydC1tb2RlIE9OLgorICAg ICAgKHByb2duCisgICAgICAgIChkb2xpc3QgKGJ1ZiAoYnVmZmVyLWxpc3QpKQorICAgICAgICAg ICh3aXRoLWN1cnJlbnQtYnVmZmVyIGJ1ZgorICAgICAgICAgICAgKGF1dG8tcmV2ZXJ0LS1nbG9i YWwtYWRkLWN1cnJlbnQtYnVmZmVyKSkpCisgICAgICAgIDs7IE1ha2Ugc3VyZSBmdXR1cmUgYnVm ZmVycyBhcmUgYWRkZWQgYXMgd2VsbC4KKyAgICAgICAgKGFkZC1ob29rICdmaW5kLWZpbGUtaG9v ayAjJ2F1dG8tcmV2ZXJ0LS1nbG9iYWwtYWRvcHQtY3VycmVudC1idWZmZXIpCisgICAgICAgIChh ZGQtaG9vayAnYWZ0ZXItc2V0LXZpc2l0ZWQtZmlsZS1uYW1lLWhvb2sKKyAgICAgICAgICAgICAg ICAgICMnYXV0by1yZXZlcnQtLWdsb2JhbC1zZXQtdmlzaXRlZC1maWxlLW5hbWUpCisgICAgICAg IDs7IFRvIHRyYWNrIG5vbi1maWxlIGJ1ZmZlcnMsIHdlIG5lZWQgdG8gbGlzdGVuIGluIHRvIGJ1 ZmZlcgorICAgICAgICA7OyBjcmVhdGlvbiBpbiBnZW5lcmFsLiAgTGlzdGVuaW5nIHRvIG1ham9y LW1vZGUgY2hhbmdlcyBpcworICAgICAgICA7OyBzdWl0YWJsZSwgc2luY2Ugd2UgdGhlbiBrbm93 IHdoZXRoZXIgaXQncyBhIG1vZGUgdGhhdCBpcyB0cmFja2VkLgorICAgICAgICAod2hlbiBnbG9i YWwtYXV0by1yZXZlcnQtbm9uLWZpbGUtYnVmZmVycworICAgICAgICAgIChhZGQtaG9vayAnYWZ0 ZXItY2hhbmdlLW1ham9yLW1vZGUtaG9vaworICAgICAgICAgICAgICAgICAgICAjJ2F1dG8tcmV2 ZXJ0LS1nbG9iYWwtYWRvcHQtY3VycmVudC1idWZmZXIpKQorICAgICAgICAoYXV0by1yZXZlcnQt YnVmZmVycykpCisgICAgOzsgVHVybiBnbG9iYWwtYXV0by1yZXZlcnQtbW9kZSBPRkYuCisgICAg KHJlbW92ZS1ob29rICdhZnRlci1jaGFuZ2UtbWFqb3ItbW9kZS1ob29rCisgICAgICAgICAgICAg ICAgICMnYXV0by1yZXZlcnQtLWdsb2JhbC1hZG9wdC1jdXJyZW50LWJ1ZmZlcikKKyAgICAocmVt b3ZlLWhvb2sgJ2FmdGVyLXNldC12aXNpdGVkLWZpbGUtbmFtZS1ob29rCisgICAgICAgICAgICAg ICAgICMnYXV0by1yZXZlcnQtLWdsb2JhbC1zZXQtdmlzaXRlZC1maWxlLW5hbWUpCisgICAgKHJl bW92ZS1ob29rICdmaW5kLWZpbGUtaG9vayAjJ2F1dG8tcmV2ZXJ0LS1nbG9iYWwtYWRvcHQtY3Vy cmVudC1idWZmZXIpCiAgICAgKGRvbGlzdCAoYnVmIChidWZmZXItbGlzdCkpCiAgICAgICAod2l0 aC1jdXJyZW50LWJ1ZmZlciBidWYKLSAgICAgICAgKHdoZW4gKGFuZCBhdXRvLXJldmVydC1ub3Rp Znktd2F0Y2gtZGVzY3JpcHRvcgotICAgICAgICAgICAgICAgICAgIChub3QgKG1lbXEgYnVmIGF1 dG8tcmV2ZXJ0LWJ1ZmZlci1saXN0KSkpCi0JICAoYXV0by1yZXZlcnQtbm90aWZ5LXJtLXdhdGNo KSkpKSkpCisgICAgICAgICh3aGVuIGF1dG8tcmV2ZXJ0LS1nbG9iYWwtbW9kZQorICAgICAgICAg IChzZXRxIGF1dG8tcmV2ZXJ0LS1nbG9iYWwtbW9kZSBuaWwpCisgICAgICAgICAgKHdoZW4gKGFu ZCBhdXRvLXJldmVydC1ub3RpZnktd2F0Y2gtZGVzY3JpcHRvcgorICAgICAgICAgICAgICAgICAg ICAgKG5vdCAob3IgYXV0by1yZXZlcnQtbW9kZSBhdXRvLXJldmVydC10YWlsLW1vZGUpKSkKKwkg ICAgKGF1dG8tcmV2ZXJ0LW5vdGlmeS1ybS13YXRjaCkpKSkpKSkKKworKGRlZnVuIGF1dG8tcmV2 ZXJ0LS1nbG9iYWwtYWRkLWN1cnJlbnQtYnVmZmVyICgpCisgICJTZXQgY3VycmVudCBidWZmZXIg dG8gYmUgdHJhY2tlZCBieSBHbG9iYWwgQXV0by1SZXZlcnQgaWYgYXBwcm9wcmlhdGUuIgorICAo d2hlbiAoYW5kIChub3QgYXV0by1yZXZlcnQtLWdsb2JhbC1tb2RlKQorICAgICAgICAgICAgIChv ciBidWZmZXItZmlsZS1uYW1lCisgICAgICAgICAgICAgICAgIChhbmQgZ2xvYmFsLWF1dG8tcmV2 ZXJ0LW5vbi1maWxlLWJ1ZmZlcnMKKyAgICAgICAgICAgICAgICAgICAgICAobm90IChzdHJpbmct cHJlZml4LXAgIiAiIChidWZmZXItbmFtZSkpKQorICAgICAgICAgICAgICAgICAgICAgIDs7IEFu eSBub24tZmlsZSBidWZmZXIgbXVzdCBoYXZlIGEgY3VzdG9tCisgICAgICAgICAgICAgICAgICAg ICAgOzsgYGJ1ZmZlci1zdGFsZS1mdW5jdGlvbicgdG8gYmUgdHJhY2tlZCwgc2luY2UKKyAgICAg ICAgICAgICAgICAgICAgICA7OyB3ZSB3b3VsZG4ndCBrbm93IHdoZW4gdG8gcmV2ZXJ0IGl0IG90 aGVyd2lzZS4KKyAgICAgICAgICAgICAgICAgICAgICAobm90IChlcSBidWZmZXItc3RhbGUtZnVu Y3Rpb24KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjJ2J1ZmZlci1zdGFsZS0tZGVm YXVsdC1mdW5jdGlvbikpKSkKKyAgICAgICAgICAgICAobm90IChtZW1xICdtYWpvci1tb2RlIGds b2JhbC1hdXRvLXJldmVydC1pZ25vcmUtbW9kZXMpKQorICAgICAgICAgICAgIChub3QgZ2xvYmFs LWF1dG8tcmV2ZXJ0LWlnbm9yZS1idWZmZXIpKQorICAgIChzZXRxIGF1dG8tcmV2ZXJ0LS1nbG9i YWwtbW9kZSB0KSkpCisKKyhkZWZ1biBhdXRvLXJldmVydC0tZ2xvYmFsLWFkb3B0LWN1cnJlbnQt YnVmZmVyICgpCisgICJDb25zaWRlciB0cmFja2luZyBjdXJyZW50IGJ1ZmZlciBpbiBhIHJ1bm5p bmcgR2xvYmFsIEF1dG8tUmV2ZXJ0IG1vZGUuIgorICAoYXV0by1yZXZlcnQtLWdsb2JhbC1hZGQt Y3VycmVudC1idWZmZXIpCisgIChhdXRvLXJldmVydC1zZXQtdGltZXIpKQorCisoZGVmdW4gYXV0 by1yZXZlcnQtLWdsb2JhbC1zZXQtdmlzaXRlZC1maWxlLW5hbWUgKCkKKyAgIlVwZGF0ZSBHbG9i YWwgQXV0by1SZXZlcnQgbWFuYWdlbWVudCBvZiB0aGUgY3VycmVudCBidWZmZXIuCitDYWxsZWQg YWZ0ZXIgYHNldC12aXNpdGVkLWZpbGUtbmFtZScuIgorICA7OyBSZW1vdmUgYW55IGV4aXN0aW5n IG5vdGlmaWVyIGZpcnN0IHNvIHRoYXQgd2UgZG9uJ3QgdHJhY2sgdGhlCisgIDs7IHdyb25nIGZp bGUgaW4gY2FzZSB0aGUgZmlsZSBuYW1lIHdhcyBjaGFuZ2VkLgorICAod2hlbiBhdXRvLXJldmVy dC1ub3RpZnktd2F0Y2gtZGVzY3JpcHRvcgorICAgIChhdXRvLXJldmVydC1ub3RpZnktcm0td2F0 Y2gpKQorICAoYXV0by1yZXZlcnQtLWdsb2JhbC1hZG9wdC1jdXJyZW50LWJ1ZmZlcikpCiAKIChk ZWZ1biBhdXRvLXJldmVydC0tcG9sbGVkLWJ1ZmZlcnMgKCkKICAgIkxpc3Qgb2YgYnVmZmVycyB0 aGF0IG5lZWQgdG8gYmUgcG9sbGVkLiIKLSAgKGNvbmQgKGdsb2JhbC1hdXRvLXJldmVydC1tb2Rl IChidWZmZXItbGlzdCkpCisgIChjb25kIChnbG9iYWwtYXV0by1yZXZlcnQtbW9kZQorICAgICAg ICAgKG1hcGNhbiAobGFtYmRhIChidWZmZXIpCisgICAgICAgICAgICAgICAgICAgKGFuZCAobm90 IChhbmQgYXV0by1yZXZlcnQtYXZvaWQtcG9sbGluZworICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIChidWZmZXItbG9jYWwtdmFsdWUKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJ2F1dG8tcmV2ZXJ0LW5vdGlmeS13YXRjaC1kZXNjcmlwdG9yCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGJ1ZmZlcikpKQorICAgICAgICAgICAgICAgICAgICAg ICAgKG9yIChidWZmZXItbG9jYWwtdmFsdWUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg J2F1dG8tcmV2ZXJ0LS1nbG9iYWwtbW9kZSBidWZmZXIpCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKGJ1ZmZlci1sb2NhbC12YWx1ZSAnYXV0by1yZXZlcnQtbW9kZSBidWZmZXIpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKGJ1ZmZlci1sb2NhbC12YWx1ZSAnYXV0by1yZXZlcnQt dGFpbC1tb2RlIGJ1ZmZlcikpCisgICAgICAgICAgICAgICAgICAgICAgICAobGlzdCBidWZmZXIp KSkKKyAgICAgICAgICAgICAgICAgKGJ1ZmZlci1saXN0KSkpCiAgICAgICAgIChhdXRvLXJldmVy dC1hdm9pZC1wb2xsaW5nCiAgICAgICAgICAobWFwY2FuIChsYW1iZGEgKGJ1ZmZlcikKLSAgICAg ICAgICAgICAgICAgICAgIChhbmQgKG5vdCAoYnVmZmVyLWxvY2FsLXZhbHVlCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICdhdXRvLXJldmVydC1ub3RpZnktd2F0Y2gtZGVzY3JpcHRv ciBidWZmZXIpKQotICAgICAgICAgICAgICAgICAgICAgICAgICAobGlzdCBidWZmZXIpKSkKLSAg ICAgICAgICAgICAgICAgICBhdXRvLXJldmVydC1idWZmZXItbGlzdCkpCisgICAgICAgICAgICAg ICAgICAgKGFuZCAobm90IChidWZmZXItbG9jYWwtdmFsdWUKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICdhdXRvLXJldmVydC1ub3RpZnktd2F0Y2gtZGVzY3JpcHRvciBidWZmZXIpKQor ICAgICAgICAgICAgICAgICAgICAgICAgKGxpc3QgYnVmZmVyKSkpCisgICAgICAgICAgICAgICAg IGF1dG8tcmV2ZXJ0LWJ1ZmZlci1saXN0KSkKICAgICAgICAgKHQgYXV0by1yZXZlcnQtYnVmZmVy LWxpc3QpKSkKIAogOzsgU2FtZSBhcyBhYm92ZSBpbiBhIGJvb2xlYW4gY29udGV4dCwgYnV0IGNo ZWFwZXIuCiAoZGVmdW4gYXV0by1yZXZlcnQtLW5lZWQtcG9sbGluZy1wICgpCiAgICJXaGV0aGVy IHBlcmlvZGljIHBvbGxpbmcgaXMgcmVxdWlyZWQuIgotICAob3IgZ2xvYmFsLWF1dG8tcmV2ZXJ0 LW1vZGUKLSAgICAgIChpZiBhdXRvLXJldmVydC1hdm9pZC1wb2xsaW5nCi0gICAgICAgICAgKG5v dCAoY2wtZXZlcnkgKGxhbWJkYSAoYnVmZmVyKQotICAgICAgICAgICAgICAgICAgICAgICAgICAg KGJ1ZmZlci1sb2NhbC12YWx1ZQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICdhdXRvLXJl dmVydC1ub3RpZnktd2F0Y2gtZGVzY3JpcHRvciBidWZmZXIpKQotICAgICAgICAgICAgICAgICAg ICAgICAgIGF1dG8tcmV2ZXJ0LWJ1ZmZlci1saXN0KSkKLSAgICAgICAgYXV0by1yZXZlcnQtYnVm ZmVyLWxpc3QpKSkKKyAgKGNvbmQgKGdsb2JhbC1hdXRvLXJldmVydC1tb2RlCisgICAgICAgICAo b3IgKG5vdCBhdXRvLXJldmVydC1hdm9pZC1wb2xsaW5nKQorICAgICAgICAgICAgIChjbC1zb21l CisgICAgICAgICAgICAgIChsYW1iZGEgKGJ1ZmZlcikKKyAgICAgICAgICAgICAgICAoYW5kIChu b3QgKGJ1ZmZlci1sb2NhbC12YWx1ZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2F1dG8t cmV2ZXJ0LW5vdGlmeS13YXRjaC1kZXNjcmlwdG9yIGJ1ZmZlcikpCisgICAgICAgICAgICAgICAg ICAgICAob3IgKGJ1ZmZlci1sb2NhbC12YWx1ZSAnYXV0by1yZXZlcnQtLWdsb2JhbC1tb2RlIGJ1 ZmZlcikKKyAgICAgICAgICAgICAgICAgICAgICAgICAoYnVmZmVyLWxvY2FsLXZhbHVlICdhdXRv LXJldmVydC1tb2RlIGJ1ZmZlcikKKyAgICAgICAgICAgICAgICAgICAgICAgICAoYnVmZmVyLWxv Y2FsLXZhbHVlICdhdXRvLXJldmVydC10YWlsLW1vZGUgYnVmZmVyKSkpKQorICAgICAgICAgICAg ICAoYnVmZmVyLWxpc3QpKSkpCisgICAgICAgIChhdXRvLXJldmVydC1hdm9pZC1wb2xsaW5nCisg ICAgICAgICAobm90IChjbC1ldmVyeQorICAgICAgICAgICAgICAgKGxhbWJkYSAoYnVmZmVyKQor ICAgICAgICAgICAgICAgICAoYnVmZmVyLWxvY2FsLXZhbHVlCisgICAgICAgICAgICAgICAgICAn YXV0by1yZXZlcnQtbm90aWZ5LXdhdGNoLWRlc2NyaXB0b3IgYnVmZmVyKSkKKyAgICAgICAgICAg ICAgIGF1dG8tcmV2ZXJ0LWJ1ZmZlci1saXN0KSkpCisgICAgICAgICh0IGF1dG8tcmV2ZXJ0LWJ1 ZmZlci1saXN0KSkpCiAKIChkZWZ1biBhdXRvLXJldmVydC1zZXQtdGltZXIgKCkKICAgIlJlc3Rh cnQgb3IgY2FuY2VsIHRoZSB0aW1lciB1c2VkIGJ5IEF1dG8tUmV2ZXJ0IE1vZGUuCkBAIC02NTIs OSArNzI1LDggQEAgYXV0by1yZXZlcnQtbm90aWZ5LWhhbmRsZXIKICAgICAgICAgICAgICAgICAg ICAgIChudWxsIGJ1ZmZlci1maWxlLW5hbWUpKQogICAgICAgICAgICAgICAgIChhdXRvLXJldmVy dC1ub3RpZnktcm0td2F0Y2gpCiAgICAgICAgICAgICAgICAgOzsgUmVzdGFydCB0aGUgdGltZXIg aWYgaXQgd2Fzbid0IHJ1bm5pbmcuCi0gICAgICAgICAgICAgICAgKHdoZW4gKGFuZCAobWVtcSBi dWZmZXIgYXV0by1yZXZlcnQtYnVmZmVyLWxpc3QpCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAobm90IGF1dG8tcmV2ZXJ0LXRpbWVyKSkKLSAgICAgICAgICAgICAgICAgIChhdXRvLXJldmVy dC1zZXQtdGltZXIpKSkpKQorICAgICAgICAgICAgICAgICh1bmxlc3MgYXV0by1yZXZlcnQtdGlt ZXIpCisgICAgICAgICAgICAgICAgICAoYXV0by1yZXZlcnQtc2V0LXRpbWVyKSkpKQogCiAgICAg ICAgIDs7IExvb3Agb3ZlciBhbGwgYnVmZmVycywgaW4gb3JkZXIgdG8gZmluZCB0aGUgaW50ZW5k ZWQgb25lLgogICAgICAgICAoY2wtZG9saXN0IChidWZmZXIgYnVmZmVycykKQEAgLTcwMCw5ICs3 NzIsNyBAQCBhdXRvLXJldmVydC1hY3RpdmUtcAogICAiQ2hlY2sgaWYgYXV0by1yZXZlcnQgaXMg YWN0aXZlIChpbiBjdXJyZW50IGJ1ZmZlciBvciBnbG9iYWxseSkuIgogICAob3IgYXV0by1yZXZl cnQtbW9kZQogICAgICAgYXV0by1yZXZlcnQtdGFpbC1tb2RlCi0gICAgICAoYW5kIGdsb2JhbC1h dXRvLXJldmVydC1tb2RlCi0gICAgICAgICAgIChub3QgZ2xvYmFsLWF1dG8tcmV2ZXJ0LWlnbm9y ZS1idWZmZXIpCi0gICAgICAgICAgIChub3QgKG1lbXEgbWFqb3ItbW9kZSBnbG9iYWwtYXV0by1y ZXZlcnQtaWdub3JlLW1vZGVzKSkpKSkKKyAgICAgIGF1dG8tcmV2ZXJ0LS1nbG9iYWwtbW9kZSkp CiAKIChkZWZ1biBhdXRvLXJldmVydC1oYW5kbGVyICgpCiAgICJSZXZlcnQgY3VycmVudCBidWZm ZXIsIGlmIGFwcHJvcHJpYXRlLgpkaWZmIC0tZ2l0IGEvbGlzcC9maWxlcy5lbCBiL2xpc3AvZmls ZXMuZWwKaW5kZXggODQ3N2MyMjdiYy4uNDUzYTdmNDU4NCAxMDA2NDQKLS0tIGEvbGlzcC9maWxl cy5lbAorKysgYi9saXNwL2ZpbGVzLmVsCkBAIC00MjIyLDYgKzQyMjIsOSBAQCBjaGFuZ2UtbWFq b3ItbW9kZS13aXRoLWZpbGUtbmFtZQogICA6dHlwZSAnYm9vbGVhbgogICA6Z3JvdXAgJ2VkaXRp bmctYmFzaWNzKQogCisoZGVmdmFyIGFmdGVyLXNldC12aXNpdGVkLWZpbGUtbmFtZS1ob29rIG5p bAorICAiTm9ybWFsIGhvb2sgcnVuIGp1c3QgYWZ0ZXIgc2V0dGluZyB2aXNpdGVkIGZpbGUgbmFt ZSBvZiBjdXJyZW50IGJ1ZmZlci4iKQorCiAoZGVmdW4gc2V0LXZpc2l0ZWQtZmlsZS1uYW1lIChm aWxlbmFtZSAmb3B0aW9uYWwgbm8tcXVlcnkgYWxvbmctd2l0aC1maWxlKQogICAiQ2hhbmdlIG5h bWUgb2YgZmlsZSB2aXNpdGVkIGluIGN1cnJlbnQgYnVmZmVyIHRvIEZJTEVOQU1FLgogVGhpcyBh bHNvIHJlbmFtZXMgdGhlIGJ1ZmZlciB0byBjb3JyZXNwb25kIHRvIHRoZSBuZXcgZmlsZS4KQEAg LTQzNDIsNyArNDM0NSw4IEBAIHNldC12aXNpdGVkLWZpbGUtbmFtZQogCSAgICAgIChzZXQtYXV0 by1tb2RlIHQpCiAJICAgICAgKG9yIChlcSBvbGQgbWFqb3ItbW9kZSkKIAkJICAoaGFjay1sb2Nh bC12YXJpYWJsZXMpKSkpCi0gICAgKGVycm9yIG5pbCkpKSkKKyAgICAgIChlcnJvciBuaWwpKQor ICAgIChydW4taG9va3MgJ2FmdGVyLXNldC12aXNpdGVkLWZpbGUtbmFtZS1ob29rKSkpCiAKIChk ZWZ1biB3cml0ZS1maWxlIChmaWxlbmFtZSAmb3B0aW9uYWwgY29uZmlybSkKICAgIldyaXRlIGN1 cnJlbnQgYnVmZmVyIGludG8gZmlsZSBGSUxFTkFNRS4KLS0gCjIuMjAuMQoK --=-T7U6s0S2T0wBcZWONeYx-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 May 2019 13:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15577545407393 (code B ref 35418); Mon, 13 May 2019 13:36:01 +0000 Received: (at 35418) by debbugs.gnu.org; 13 May 2019 13:35:40 +0000 Received: from localhost ([127.0.0.1]:44467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQB7E-0001vB-D0 for submit@debbugs.gnu.org; Mon, 13 May 2019 09:35:40 -0400 Received: from mout.gmx.net ([212.227.15.15]:33683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQB7C-0001uz-Tp for 35418@debbugs.gnu.org; Mon, 13 May 2019 09:35:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557754530; bh=muctPvQsKeliEiRjmyk7KUE/lm8XiXXiOap+Lhln2wY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=GE0jrUbm1/NYY+yJlqu6SjQekoViDN0q+KU36EiU8NkhNXiZV4bN8MJ2179ktEQmF rFz2mQOJUYl2+057CkB1bzAonhkjI1CVaUac6jxS95Ilhf33cNmC/xWctdueXCxlDy gYItHhQCc0Z7VrnwLl8p7s5S9oIF6izXMI23my98= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.91.238.102]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LjIit-1gqIvu3rO3-00daAF; Mon, 13 May 2019 15:35:30 +0200 From: Michael Albinus References: <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> <877eazx2xd.fsf@gmx.de> <878svcjbxb.fsf@gmx.de> Date: Mon, 13 May 2019 15:35:27 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Sun, 12 May 2019 21:49:33 +0200") Message-ID: <871s12jx40.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:oY6yIUrs9H3Bc6eBTDGR3MMt5JRixYHftK+PEYevPjrK9RXNt3P kZxR8FhadxqAnQgSST6R9jht8/oETYY/tkLt3MzjZPXQg3PBRfreBiSmU9RNFDn6Q65xJyd H86PuMqS5Newg3unucOcf42h53oa3WjGEYHlcyg7l3GQ3IcEbPM3gik7OTEMUQJ+Rdb98IV 31ZlYuLFrH7JTpfkpdCHQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/Gsd7YEkFyU=:1WFT1sddzhCQd8y8GbnYSw 4hilsLxmoNvcJAxZ5t7q8+GVKl43uu5eeldaM5VHON2DnVErCGj5GedBYa5OaucmVNfx1hEuw /Chr8O3Kmk0Htf6zeUlYMcUJ8ZvFrF/SDgbcrcgH1Wo3G2lpunLAj49fLL5zdLfw1RiZRVHsk OoBzCOsHcicI0TAH51L6NyhTzzuUIa/B0mH+Hu/UbxAucn/GbltWTrmaJBG0zR0rBdFXvH3gp AZtERubVKnlN9AjVEiL7jUJ9nch5Hab9SAGVGCor9kkoOXv9L+Cx0hF7DRVQPnh9odOX5GOgt dBhwt45ZUm5nIj8C0AyztK7hy+9LIXoLmHCCZfhmuG6/wR6csidHVk92HORgOYgoi2J8dzkTD IPgMQAR+hdqlwhCZaZuOB9z5/6LNV3C9g6JOXnQs3w/zh4SeLqQBsN9iyiCu7wcaKC67Gb2+6 6mOjY9pnhhgFXoNTO9hrtTa1syto2ovM0gIxpK42GSIFhqZrqaItvpkm4r/qc5cLibTDCRnuo XbPb/X8Ju6ceJGOrrDefvMdoM03J+P53GhkUf2A34g173aV+gH+RynIGts8AMJEqoQ9pPmyfW ROK3B5WUW7pZ75Ofgp1DHQHQuPmJ7po7gtYyNQgzItXms0LOZyPY+8ClUadbE+RxEp07p/Ugj tzCeSFcFSnxB1gh8mz6+j8PB/s/GLr7ENgTGnmqJIn4hsS2zxGpVgjAGDp4e/5NSHkXbKeuqE Vx8L4NxJu6+VyupzWcxaHAKJ7jxeH/wzCy+l/7j8mrvplkueBvOjfZoveobId/dCoVCG8fQDJ 3QpjqF3l0ffCdrxbfpMNEMcQ2yvYoSnVQFoNchilBmfPrnwybNXcKvAkODhL/q44mt9TQiTl1 8JJ1E73No65LJfy8Iwplq+4gLq/Hb/ka5pv9DupVNx2+qu9RLOPy+8r84b6jelM9DLPGEpwCO Sspsy0B6H+w== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, > --- a/doc/emacs/arevert-xtra.texi > +++ b/doc/emacs/arevert-xtra.texi >=20=20 > +@vindex buffer-auto-revert-by-notification > +Some non-file buffers can be updated reliably by file notification on > +their default directory. This can be indicated by setting > +@code{buffer-auto-revert-by-notification} to a non-@code{nil} value in > +that buffer, allowing Auto Revert to avoid periodic polling. Such > +notification does not include changes to files in that directory, only > +to the directory itself. Do we want to say that this is related to a major mode in general? That means, that the mode function shall set this variable. And do we want to mention dired-mode as example? =20=20 > --- a/etc/NEWS > +++ b/etc/NEWS >=20=20 > +*** New variable 'buffer-auto-revert-by-notification' > +Non-file buffers can explicitly declare that notification on their > +default-directory is sufficient to know when updates are required by > +setting the new variable `buffer-auto-revert-by-notification' to a > +non-nil value in that buffer. Auto Revert mode can use this > +information to avoid polling the buffer periodically when > +'auto-revert-avoid-polling' is non-nil. Same remark. Mention major mode dependency. Otherwise, the patch LGTM. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 May 2019 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155776014125995 (code B ref 35418); Mon, 13 May 2019 15:09:02 +0000 Received: (at 35418) by debbugs.gnu.org; 13 May 2019 15:09:01 +0000 Received: from localhost ([127.0.0.1]:45927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQCZY-0006lD-NY for submit@debbugs.gnu.org; Mon, 13 May 2019 11:09:00 -0400 Received: from mout.gmx.net ([212.227.17.21]:48993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQCZV-0006kv-0R for 35418@debbugs.gnu.org; Mon, 13 May 2019 11:08:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557760127; bh=qZVf94id0netltkXHXAchXBoHf0iIC4hZVrIKsu/Blw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=jZMm6ItvWz5SV5SywuZMjFUb+tSST3yQD2PyXb5Sa8hhU4zfZzSnXq1ZitfQDkeir ln0AClEiLtFuusYaE0G6tEx8htgQ8y+v1eoDRM09MWpCNCblH37Pk/AwaD9xgUrJeS 05ZmEgH/4Odu2ZoIPON4e9vVSSdsBQ8U9r61XEI4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.91.238.102]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Lr46Z-1gmlLQ1cOp-00ee1x; Mon, 13 May 2019 17:08:47 +0200 From: Michael Albinus References: <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> <87muju1vx1.fsf@gmx.de> <25E4EBE0-0E65-45B7-B56F-9C67A2862DFA@acm.org> <87a7fu1nv8.fsf@gmx.de> Date: Mon, 13 May 2019 17:08:45 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Mon, 13 May 2019 13:34:59 +0200") Message-ID: <87tvdyie82.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:snscPRo7LZbTCMvLMjiwfqIk5t2rQgjQX55T1Ao4KA+p+dWoEvY nC3IlAhvC9sQj46RgVvf/0r5tjHgY4MON6ZUa4w+w+eQo5IUP0IswyD5K4GwG/B2WSHPp8a 20OBOseNHU5PM83GoW0PuaST3IPFKvXczWzB/zocPkUXVO3wvoAv3gxZgnPiF1RoRt2+zEF lrxYyuJDavV/SeIoU6Fzw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:wlHov5Ev4sg=:y4S7dahVuAgcgBQQzHyzBh TsBM6vnjYtkXdUKKT9s8Ab0bqSq1C1GNP/Q/s+PHZDn0TiAnl2b6qD2d8R3SAWiHF4vW9UmFL pNdRFKHH5TbbhcT2uB5NqDmbWgu0eM10UjPVp4gR/XAeL7oD1D1mfv1Yj1NEix3Ty7qm2FY0m PagP100SnVdF5rbM75OojgfhtQh7ZhB9ZJKKWRpDRRKF+tDyl6PZetDufy3w1wqoEfccmPF8o alPMcgCI1fTMJn+Z/WATMEshqP0MQ27OR8UI//q+oRoWaYt/WO9DVfiH09rFxUEJ71WiQFNpP v7jtDkDcSoSgkeSZAVN6TkUewrP13Bkz2PO46t/5QXfhWzcVorra23CUTeBQWTSWfXRvI9B+o 6MmoEeMByF79WbmkgDFCPglm5apAHU+MYXDhIS8F+/EkIK6yrPpksC4S3Qj9TM1YHeoll5HfW 2f3Ey/On5QbhP6gtKIfrmw0BhmVtxTZ8oqLosxlEcZEbKCTW1acT+eDYehwLlKfABxKIadJj3 Vxq2s4f5v2vaW0xvWzcT0JmlYdI5KZg0hh2f5+a+12g9fTb6j6drIUxMzGHIowEBkvT+2MQDP 881MvolLz6JZuBLdlRgKY5ZnE5xik5Fikg/Aj8pBzfDn5kAfMUCQIFZ8mIOcm3/WTY9CJgtlF 9fWbvEi5Y1QdQutb72U0SzdoAKe5AnzrEjIjInzijDD1zl2UOx6TLKznLoo0XTkxnTA/hU1Ut lrvKHLO8wRZsV20gsb0tQdFBvpwH603T6B4R+QvzgmemqDuaCmdpVqO7MC7/dy0omzS8nsH3m 8jjh6Y2MI9yfy5MWLGLD+aZzLnwVHqHXpfzzJsimnP3JWTGp8KLPJ1GBJs/FZieIU71y50okD VF2Z1IlrKKVtGF+VIeJgc0GB8GVZGR1g4qQzRiZpaqnaMVJZLaUUzZFMektN2JxW+33//afka wlYzbpXZCsQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, >> So we must document in the Elisp manual, that buffers, which want to >> participate in global-auto-revert-mode after a renaming, shall change >> the name via set-visited-file-name. > > Are you sure about that? It sounds quite technical. But if you think it > is necessary, I'll add it. I'm not sure, of course. But how else can such a buffer participate, if we don't poll anymore (and refresh the list of buffers to be watched)? To be tested, I would say. >> Agreed. Those buffers are special (internal) anyway, it's already >> tricky to show them. Nobody needs auto-revert for invisible buffers >> :-) > > The revised patch now excludes such non-file buffers. I wonder if > buffers with file names should be excluded as well. They trivially > occur when visiting a file whose name starts with a space. `list-buffers' shows buffers with a leading space, if they are visiting a file. If they don't visit a file, they are not listed. I would say we shall apply the same rule. The patch LGTM. Do you want also add some tests to autorevert-tests.el? Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2019 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155783942023895 (code B ref 35418); Tue, 14 May 2019 13:11:02 +0000 Received: (at 35418) by debbugs.gnu.org; 14 May 2019 13:10:20 +0000 Received: from localhost ([127.0.0.1]:47660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQXCG-0006DK-Dw for submit@debbugs.gnu.org; Tue, 14 May 2019 09:10:20 -0400 Received: from mail222c50.megamailservers.eu ([91.136.10.232]:56688 helo=mail33c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQXCC-0006D8-7L for 35418@debbugs.gnu.org; Tue, 14 May 2019 09:10:20 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1557837722; bh=qaBfG9f+YMeYTzuToFeHvT5ezkQChv/nJjz6+HRgN+w=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=UMrJPGKVYIJe+iBhuiw6rRUEDiyULkSnqJXWHyZsgc+oz2fEN4KjrvXMxf6+axoeS GtDEtNgEqviK1FaIlOxZSD4vbqZd2XEkgIGugORzdd5ateBWpNoXbyHdediR6LpU9f Tx0c8n+0OzR2/ck2msYVlLMq/k1nWt3eXG95bPUE= Feedback-ID: mattiase@acm.or Received: from dhcppc0 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x4ECfFek012522; Tue, 14 May 2019 12:41:46 +0000 Message-ID: From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Date: Tue, 14 May 2019 14:41:14 +0200 In-Reply-To: <871s12jx40.fsf@gmx.de> References: <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> <877eazx2xd.fsf@gmx.de> <878svcjbxb.fsf@gmx.de> <871s12jx40.fsf@gmx.de> Content-Type: multipart/mixed; boundary="=-AbnrHp4Fx1WmAo7ZgS8g" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 X-CTCH-RefID: str=0001.0A0B0206.5CDAB792.0059, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=QN9GuDDL c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=pYEp7-UgQfvXN1k1ONMA:9 a=QEXdDO2ut3YA:10 a=N54-gffFAAAA:8 a=R2M-SNEywa8nnAsh55UA:9 a=j0DptsLD-MQC913v:21 a=yRhiHEw_fMsjKk05:21 a=B2y7HmGcmWMA:10 a=6l0D2HzqY3Epnrm8mE3f:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-AbnrHp4Fx1WmAo7ZgS8g Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit mån 2019-05-13 klockan 15:35 +0200 skrev Michael Albinus: > > Do we want to say that this is related to a major mode in general? > That > means, that the mode function shall set this variable. And do we want > to > mention dired-mode as example? Good point, paragraph changed. > Same remark. Mention major mode dependency. Done. Updated patch attached. --=-AbnrHp4Fx1WmAo7ZgS8g Content-Disposition: attachment; filename="0001-Don-t-use-file-notification-on-non-file-buffers.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Don-t-use-file-notification-on-non-file-buffers.patch"; charset="UTF-8" RnJvbSBlZmRhODZlZjAzYmVmYjczMzU2YzdiMjNlZTIxZTdkOWVmZDhiMTgxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWF0dGlhcz0yMEVuZ2RlZz1DMz1BNXJkPz0g PG1hdHRpYXNlQGFjbS5vcmc+CkRhdGU6IFdlZCwgOCBNYXkgMjAxOSAwMDowMjo1OSArMDIwMApT dWJqZWN0OiBbUEFUQ0hdIERvbid0IHVzZSBmaWxlIG5vdGlmaWNhdGlvbiBvbiBub24tZmlsZSBi dWZmZXJzCgpNb3N0IG5vbi1maWxlIGJ1ZmZlcnMgYXJlbid0IHNlcnZlZCBieSBmaWxlIG5vdGlm aWNhdGlvbiBpbgphdXRvLXJldmVydCBtb2RlOyB0eXBpY2FsbHksIHRoZXkgbmVlZCB0byBiZSBw b2xsZWQsIGxpa2UgdGhlIEJ1ZmZlciBMaXN0LgpXaXRoIGBhdXRvLXJldmVydC1hdm9pZC1wb2xs aW5nJywgc2V0dGluZyBhIHVzZWxlc3Mgbm90aWZpY2F0aW9uIG1lYW5zCnRoYXQgc3VjaCBidWZm ZXJzIG1heSBuZXZlciBiZSB1cGRhdGVkIGF0IGFsbCAoYnVnIzM1NDE4KS4KCk5vbi1maWxlIGJ1 ZmZlcnMgY2FuIGV4cGxpY2l0bHkgZGVjbGFyZSB0aGF0IG5vdGlmaWNhdGlvbiBvbiB0aGVpcgpk ZWZhdWx0LWRpcmVjdG9yeSBpcyBzdWZmaWNpZW50IHRvIGtub3cgd2hlbiB1cGRhdGVzIGFyZSBy ZXF1aXJlZApieSBzZXR0aW5nIHRoZSBuZXcgdmFyaWFibGUgYGJ1ZmZlci1hdXRvLXJldmVydC1i eS1ub3RpZmljYXRpb24nIHRvCmEgbm9uLW5pbCB2YWx1ZS4KCiogbGlzcC9hdXRvcmV2ZXJ0LmVs IChhdXRvLXJldmVydC1idWZmZXJzKToKTW9kaWZ5IGNvbmRpdGlvbiBmb3IgdXNpbmcgbm90aWZp Y2F0aW9uLgoqIGxpc3AvZmlsZXMuZWwgKGJ1ZmZlci1hdXRvLXJldmVydC1ieS1ub3RpZmljYXRp b24pOiBOZXcgdmFyaWFibGUuCiogbGlzcC9kaXJlZC5lbCAoZGlyZWQtbW9kZSk6IFNldCBidWZm ZXItYXV0by1yZXZlcnQtYnktbm90aWZpY2F0aW9uLgoqIGRvYy9lbWFjcy9hcmV2ZXJ0LXh0cmEu dGV4aSAoTm9uLUZpbGUgQnVmZmVycyk6IERvY3VtZW50IG5ldyB2YXJpYWJsZS4KKiBldGMvTkVX UyAoQ2hhbmdlcyBpbiBTcGVjaWFsaXplZCBNb2RlcyBhbmQgUGFja2FnZXMpOiBEZXNjcmliZSBu ZXcgdmFyaWFibGUuCi0tLQogZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50ZXhpIHwgIDggKysrKysr KysKIGV0Yy9ORVdTICAgICAgICAgICAgICAgICAgICB8ICA3ICsrKysrKysKIGxpc3AvYXV0b3Jl dmVydC5lbCAgICAgICAgICB8ICA2ICsrKysrLQogbGlzcC9kaXJlZC5lbCAgICAgICAgICAgICAg IHwgIDEgKwogbGlzcC9maWxlcy5lbCAgICAgICAgICAgICAgIHwgMTAgKysrKysrKysrKwogNSBm aWxlcyBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0 IGEvZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50ZXhpIGIvZG9jL2VtYWNzL2FyZXZlcnQteHRyYS50 ZXhpCmluZGV4IDllMDFhMTBhY2UuLjM3ZTJmOWU1ODEgMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9h cmV2ZXJ0LXh0cmEudGV4aQorKysgYi9kb2MvZW1hY3MvYXJldmVydC14dHJhLnRleGkKQEAgLTM1 LDYgKzM1LDE0IEBAIE5vbi1GaWxlIEJ1ZmZlcnMKIG1lc3NhZ2VzIHdoaWxlIHJldmVydGluZywg ZXZlbiB3aGVuIEBjb2Rle2F1dG8tcmV2ZXJ0LXZlcmJvc2V9IGlzCiBub24tQGNvZGV7bmlsfS4K IAorQHZpbmRleCBidWZmZXItYXV0by1yZXZlcnQtYnktbm90aWZpY2F0aW9uCitTb21lIG5vbi1m aWxlIGJ1ZmZlcnMgY2FuIGJlIHVwZGF0ZWQgcmVsaWFibHkgYnkgZmlsZSBub3RpZmljYXRpb24g b24KK3RoZWlyIGRlZmF1bHQgZGlyZWN0b3J5OyBEaXJlZCBidWZmZXJzIGlzIGFuIGV4YW1wbGUu ICBUaGUgbWFqb3IgbW9kZQorY2FuIGluZGljYXRlIHRoaXMgYnkgc2V0dGluZyBAY29kZXtidWZm ZXItYXV0by1yZXZlcnQtYnktbm90aWZpY2F0aW9ufQordG8gYSBub24tQGNvZGV7bmlsfSB2YWx1 ZSBpbiB0aGF0IGJ1ZmZlciwgYWxsb3dpbmcgQXV0byBSZXZlcnQgdG8KK2F2b2lkIHBlcmlvZGlj IHBvbGxpbmcuICBTdWNoIG5vdGlmaWNhdGlvbiBkb2VzIG5vdCBpbmNsdWRlIGNoYW5nZXMgdG8K K2ZpbGVzIGluIHRoYXQgZGlyZWN0b3J5LCBvbmx5IHRvIHRoZSBkaXJlY3RvcnkgaXRzZWxmLgor CiBUaGUgZGV0YWlscyBkZXBlbmQgb24gdGhlIHBhcnRpY3VsYXIgdHlwZXMgb2YgYnVmZmVycyBh bmQgYXJlCiBleHBsYWluZWQgaW4gdGhlIGNvcnJlc3BvbmRpbmcgc2VjdGlvbnMuCiAKZGlmZiAt LWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggNDNhZDhiZTFjYy4uNTdlZjc2NjE0ZiAx MDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTE0MjgsNiArMTQyOCwxMyBA QCBvZiBhbiBpZGxlIEVtYWNzLCBidXQgbWF5IGZhaWwgb24gc29tZSBuZXR3b3JrIGZpbGUgc3lz dGVtczsgc2V0CiBub3RpZmljYXRpb24gaXMgbm90IHN1cHBvcnRlZC4gIFRoZSBuZXcgdmFyaWFi bGUgY3VycmVudGx5IGhhcyBubwogZWZmZWN0IGluICdnbG9iYWwtYXV0by1yZXZlcnQtbW9kZScu ICBUaGUgZGVmYXVsdCB2YWx1ZSBpcyBuaWwuCiAKKyoqKiBOZXcgdmFyaWFibGUgJ2J1ZmZlci1h dXRvLXJldmVydC1ieS1ub3RpZmljYXRpb24nCitBIG1ham9yIG1vZGUgY2FuIGRlY2xhcmUgdGhh dCBub3RpZmljYXRpb24gb24gdGhlIGJ1ZmZlcidzIGRlZmF1bHQKK2RpcmVjdG9yeSBpcyBzdWZm aWNpZW50IHRvIGtub3cgd2hlbiB1cGRhdGVzIGFyZSByZXF1aXJlZCwgYnkgc2V0dGluZwordGhl IG5ldyB2YXJpYWJsZSBgYnVmZmVyLWF1dG8tcmV2ZXJ0LWJ5LW5vdGlmaWNhdGlvbicgdG8gYSBu b24tbmlsCit2YWx1ZS4gIEF1dG8gUmV2ZXJ0IG1vZGUgY2FuIHVzZSB0aGlzIGluZm9ybWF0aW9u IHRvIGF2b2lkIHBvbGxpbmcgdGhlCitidWZmZXIgcGVyaW9kaWNhbGx5IHdoZW4gJ2F1dG8tcmV2 ZXJ0LWF2b2lkLXBvbGxpbmcnIGlzIG5vbi1uaWwuCisKIAwKICogTmV3IE1vZGVzIGFuZCBQYWNr YWdlcyBpbiBFbWFjcyAyNy4xCiAKZGlmZiAtLWdpdCBhL2xpc3AvYXV0b3JldmVydC5lbCBiL2xp c3AvYXV0b3JldmVydC5lbAppbmRleCA3Y2Q1ZTdlZThiLi4xOTdhMmJmMTU3IDEwMDY0NAotLS0g YS9saXNwL2F1dG9yZXZlcnQuZWwKKysrIGIvbGlzcC9hdXRvcmV2ZXJ0LmVsCkBAIC04NTgsOCAr ODU4LDEyIEBAIGF1dG8tcmV2ZXJ0LWJ1ZmZlcnMKICAgICAgICAgICAgICAgICAgIChhdXRvLXJl dmVydC1yZW1vdmUtY3VycmVudC1idWZmZXIpKQogICAgICAgICAgICAgICAod2hlbiAoYXV0by1y ZXZlcnQtYWN0aXZlLXApCiAgICAgICAgICAgICAgICAgOzsgRW5hYmxlIGZpbGUgbm90aWZpY2F0 aW9uLgorICAgICAgICAgICAgICAgIDs7IERvbid0IGJvdGhlciBjcmVhdGluZyBhIG5vdGlmaWVy IGZvciBub24tZmlsZSBidWZmZXJzCisgICAgICAgICAgICAgICAgOzsgdW5sZXNzIGl0IGV4cGxp Y2l0bHkgaW5kaWNhdGVzIHRoYXQgdGhpcyB3b3Jrcy4KICAgICAgICAgICAgICAgICAod2hlbiAo YW5kIGF1dG8tcmV2ZXJ0LXVzZS1ub3RpZnkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIChu b3QgYXV0by1yZXZlcnQtbm90aWZ5LXdhdGNoLWRlc2NyaXB0b3IpKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgKG5vdCBhdXRvLXJldmVydC1ub3RpZnktd2F0Y2gtZGVzY3JpcHRvcikKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgIChvciBidWZmZXItZmlsZS1uYW1lCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgYnVmZmVyLWF1dG8tcmV2ZXJ0LWJ5LW5vdGlmaWNhdGlvbikp CiAgICAgICAgICAgICAgICAgICAoYXV0by1yZXZlcnQtbm90aWZ5LWFkZC13YXRjaCkpCiAgICAg ICAgICAgICAgICAgKGF1dG8tcmV2ZXJ0LWhhbmRsZXIpKSkpKQogCShzZXRxIGJ1ZnMgKGNkciBi dWZzKSkpCmRpZmYgLS1naXQgYS9saXNwL2RpcmVkLmVsIGIvbGlzcC9kaXJlZC5lbAppbmRleCAz ODUxMjY1MTRiLi5lYTE5NDNkZTFkIDEwMDY0NAotLS0gYS9saXNwL2RpcmVkLmVsCisrKyBiL2xp c3AvZGlyZWQuZWwKQEAgLTIxNDgsNiArMjE0OCw3IEBAIGRpcmVkLW1vZGUKICAgICAoc2V0cSBi dWZmZXItaW52aXNpYmlsaXR5LXNwZWMgKGxpc3QgdCkpKQogICAoc2V0cS1sb2NhbCByZXZlcnQt YnVmZmVyLWZ1bmN0aW9uICMnZGlyZWQtcmV2ZXJ0KQogICAoc2V0cS1sb2NhbCBidWZmZXItc3Rh bGUtZnVuY3Rpb24gIydkaXJlZC1idWZmZXItc3RhbGUtcCkKKyAgKHNldHEtbG9jYWwgYnVmZmVy LWF1dG8tcmV2ZXJ0LWJ5LW5vdGlmaWNhdGlvbiB0KQogICAoc2V0cS1sb2NhbCBwYWdlLWRlbGlt aXRlciAiXG5cbiIpCiAgIChzZXRxLWxvY2FsIGRpcmVkLWRpcmVjdG9yeSAob3IgZGlybmFtZSBk ZWZhdWx0LWRpcmVjdG9yeSkpCiAgIDs7IGxpc3QtYnVmZmVycyB1c2VzIHRoaXMgdG8gZGlzcGxh eSB0aGUgZGlyIGJlaW5nIGVkaXRlZCBpbiB0aGlzIGJ1ZmZlci4KZGlmZiAtLWdpdCBhL2xpc3Av ZmlsZXMuZWwgYi9saXNwL2ZpbGVzLmVsCmluZGV4IDg0NzdjMjI3YmMuLmJlY2I1YWFiNmYgMTAw NjQ0Ci0tLSBhL2xpc3AvZmlsZXMuZWwKKysrIGIvbGlzcC9maWxlcy5lbApAQCAtNTg0Myw2ICs1 ODQzLDE2IEBAIGJ1ZmZlci1zdGFsZS1mdW5jdGlvbgogRm9yIG1vcmUgaW5mb3JtYXRpb24gb24g aG93IHRoaXMgdmFyaWFibGUgaXMgdXNlZCBieSBBdXRvIFJldmVydCBtb2RlLAogc2VlIEluZm8g bm9kZSBgKGVtYWNzKVN1cHBvcnRpbmcgYWRkaXRpb25hbCBidWZmZXJzJy4iKQogCisoZGVmdmFy LWxvY2FsIGJ1ZmZlci1hdXRvLXJldmVydC1ieS1ub3RpZmljYXRpb24gbmlsCisgICJXaGV0aGVy IGEgYnVmZmVyIGNhbiByZWx5IG9uIG5vdGlmaWNhdGlvbiBpbiBBdXRvLVJldmVydCBtb2RlLgor SWYgbm9uLW5pbCwgbW9uaXRvcmluZyBjaGFuZ2VzIHRvIHRoZSBkaXJlY3Rvcnkgb2YgdGhlIGN1 cnJlbnQKK2J1ZmZlciBpcyBzdWZmaWNpZW50IGZvciBrbm93aW5nIHdoZW4gdGhhdCBidWZmZXIg bmVlZHMgdG8gYmUKK3VwZGF0ZWQgaW4gQXV0byBSZXZlcnQgTW9kZS4gIFN1Y2ggbm90aWZpY2F0 aW9uIGRvZXMgbm90IGluY2x1ZGUKK2NoYW5nZXMgdG8gZmlsZXMgaW4gdGhhdCBkaXJlY3Rvcnks IG9ubHkgdG8gdGhlIGRpcmVjdG9yeSBpdHNlbGYuCisKK1RoaXMgdmFyaWFibGUgb25seSBhcHBs aWVzIHRvIGJ1ZmZlcnMgd2hlcmUgYGJ1ZmZlci1maWxlLW5hbWUnIGlzCituaWw7IG90aGVyIGJ1 ZmZlcnMgYXJlIHRyYWNrZWQgYnkgdGhlaXIgZmlsZXMuIikKKwogKGRlZnZhciBiZWZvcmUtcmV2 ZXJ0LWhvb2sgbmlsCiAgICJOb3JtYWwgaG9vayBmb3IgYHJldmVydC1idWZmZXInIHRvIHJ1biBi ZWZvcmUgcmV2ZXJ0aW5nLgogVGhlIGZ1bmN0aW9uIGByZXZlcnQtYnVmZmVyLS1kZWZhdWx0JyBy dW5zIHRoaXMuCi0tIAoyLjIwLjEKCg== --=-AbnrHp4Fx1WmAo7ZgS8g-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2019 14:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15578455832945 (code B ref 35418); Tue, 14 May 2019 14:54:01 +0000 Received: (at 35418) by debbugs.gnu.org; 14 May 2019 14:53:03 +0000 Received: from localhost ([127.0.0.1]:49590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQYne-0000lR-Mm for submit@debbugs.gnu.org; Tue, 14 May 2019 10:53:02 -0400 Received: from mout.gmx.net ([212.227.17.22]:36441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQYnb-0000ku-85 for 35418@debbugs.gnu.org; Tue, 14 May 2019 10:53:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557845569; bh=ahuaM+MUJ8se9wsI0JPAmh+Q9qXrH4RG2BfQhFYkXqg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=OoIT73oGaFYZWWOG9JaeIFYsRlH3zaVIVDeFTpEC5KpPG+oMIEyN+5bV/nRoHqzqd x+CcHefN4naDCGbLH3ijZUt6zfXIwUSVsza+TzzpufDMglOUPGLo6WY1cXCh14EGSU I1X50NC63FHILdne6Mq3DbtS7djN7FwQrhMAm8jI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.59.178]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M8JyQ-1gUaYt03Ry-00vtdv; Tue, 14 May 2019 16:52:49 +0200 From: Michael Albinus References: <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> <877eazx2xd.fsf@gmx.de> <878svcjbxb.fsf@gmx.de> <871s12jx40.fsf@gmx.de> Date: Tue, 14 May 2019 16:52:46 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Tue, 14 May 2019 14:41:14 +0200") Message-ID: <874l5x3x6p.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:INtNrQCzLHC2EGB5mi9OmbKlgSETk7sykx5k4xiJIFYliweM9aN OngtyOPZxtfWwHVMzCjXD1K6b5QpKuxvggTemLyd6mrxZF6gMV3B4pLyXXH/HltD/D/REV7 dpwXtWlHlVel17h9yIAxYuGXNSAVZ3NbZ+hDpvFu2JiVuZ0r5R9lDfRGW8Jx0eGAew0/+cb ZFAcvQE2wBBmVXi0hagwg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:XxnQsS0NlQ0=:Y5YtSRJqSJ67xE++Oa2QuN uNdGygvst804b3RK3XcYyiEsx1G0jjx7AyIYHV0r0rLUgbhvAtkinCZSGBaP3C9lJ+PbXJIbA MeXeBaUkYsIz++YVXul7ilRSn+5IkAQXFnGWqf6FRm75dzE4ubLvspMkqpMfTAVktlkLFQo9N cceCzOXAmrBab1etROR/ezOmGYRkyoXsBIpIul4tWSEEAWqHlxXHVYm2JsKyGatCoUe6Q0WAm 58mxdbT+sgCENLDZZoHMB6UGRFaGVDeja/yAJBiRRAvx4pUKfy72cb0oVmabDtNsBHLL4B8VK STd8vQOvQ87qQqVDzSKi+E8f7YffU6fYI8NWA0UqhtG6PCW1mPxk6Cc2WmyAo4fXGtZ4Ujeb5 Kjt8Q/hg4dE4M13GsrKCrr2ezfrmuzYpe1/EcHxYZfYN3SjW3PfzBTb9Y/1rqR07C5Konay8R SMLhxRKtf1KlwUUQmRR/WHkLMGdYuCvIspgrC0ihvZY4IgV0SmVaUnZuasBrrQ8XwdFFmXea+ Jvk39zptbmVro6hOKda8C6m3daqPm94ccT/ieV43E3SENqekf01tGfKZ7OQ3vC22fQDZkMzoI ZLR90/b/Purg2BB2Ja3ZBltAqHVASXNKNOKl4NLrcbwzMPi1RAfxbLAItYFSrHJzo5+cQV1G6 HiOijoZ//fLDBfPDfvDzDFmMQaUjNVd9h4gJlhFsTMS0MAXlZJLniOxYBUQKCkrwBLGxUlkpe vOh6QTHRZStHLEGASsICxil9ThPy7gzjJyiiwxxCcAdqT4eM+ExNxs5EoFTpXOp389Be1Tjrs hddipsNQULtkc2dECNhtTLQMBNaYuDRHJf1Zhof2j5hlAElIe2oIcWMsz4AIu2+rnugKGtgTF yJey54qFe3dgciidbq+I3buULmaZIsmOP03kdYRuwa0ooq+ORRpahsVNY3m1TB3adWkxjzS05 mzKdEbWCYkw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, > Updated patch attached. Almost OK, but ... > --- a/etc/NEWS > +++ b/etc/NEWS > +the new variable `buffer-auto-revert-by-notification' to a non-nil ... please quote like 'this'. >From my POV, this can be pushed. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 May 2019 17:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155820115031536 (code B ref 35418); Sat, 18 May 2019 17:40:02 +0000 Received: (at 35418) by debbugs.gnu.org; 18 May 2019 17:39:10 +0000 Received: from localhost ([127.0.0.1]:32947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hS3Ib-0008Ca-SJ for submit@debbugs.gnu.org; Sat, 18 May 2019 13:39:10 -0400 Received: from mail209c50.megamailservers.eu ([91.136.10.219]:54102 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hS3IZ-0008CM-2D for 35418@debbugs.gnu.org; Sat, 18 May 2019 13:39:09 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1558201144; bh=TmQbcFr1lH1chFxuWRPlXZoRhoinRy3q0yVmi4zEvos=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=XnCyd/tjp3QlEE+Ey6CZWX6FG87sjcObhnQmZr5rubM4nNhzJOjVaTGZeUxV4PohE UoW4fthkcOYXs4fUnT4kFu2w+2kDE7Gu5rDDPEl2vJrbTP2tPNmWoLg/gmMM/xPKJr GZQGGj9ji0Ms6qG4LZXxvzSj1I7SzVOjEPE9jtSg= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] ([188.150.171.71]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x4IHd1jl027710; Sat, 18 May 2019 17:39:03 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <4FD5C2DB-8F3D-4317-B8ED-CB7A4605A2F1@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_AF8798C5-E6FE-4D80-B142-17DC723249D5" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Date: Sat, 18 May 2019 19:39:01 +0200 In-Reply-To: <87tvdyie82.fsf@gmx.de> References: <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> <87muju1vx1.fsf@gmx.de> <25E4EBE0-0E65-45B7-B56F-9C67A2862DFA@acm.org> <87a7fu1nv8.fsf@gmx.de> <87tvdyie82.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0211.5CE04338.0010, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=OuZhNR3t c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=5vR_8RYJB1VzvEP9aWYA:9 a=CjuIK1q_8ugA:10 a=aMj-4VGTj6kA:10 a=QqFNrm0a_HcA:10 a=fPw3ZMCt_jpd5vk-e2sA:9 a=B2y7HmGcmWMA:10 X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_AF8798C5-E6FE-4D80-B142-17DC723249D5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 13 maj 2019 kl. 17.08 skrev Michael Albinus : >=20 > The patch LGTM. Do you want also add some tests to = autorevert-tests.el? Thank you -- I added one, but have only access to kqueue at the moment = so I haven't run it on anything else. --Apple-Mail=_AF8798C5-E6FE-4D80-B142-17DC723249D5 Content-Disposition: attachment; filename=0001-Avoid-polling-in-global-auto-revert-mode-bug-35418.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Avoid-polling-in-global-auto-revert-mode-bug-35418.patch" Content-Transfer-Encoding: quoted-printable =46rom=2075ba64612ed8f990a462b7ea65316e5ff4693f67=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Thu,=209=20May=202019=2009:40:46=20+0200=0A= Subject:=20[PATCH]=20Avoid=20polling=20in=20global-auto-revert-mode=20= (bug#35418)=0A=0AMake=20`auto-revert-avoid-polling'=20have=20effect=20in=20= global-auto-revert-mode.=0ABuffers=20actually=20handled=20by=20that=20= mode=20are=20marked=20with=20a=20non-nil=20value=0Aof=20= `auto-revert--global-mode'.=20=20When=20global-auto-revert-mode=20is=0A= entered,=20eligible=20buffers=20are=20marked=20in=20that=20way,=20and=20= hooks=20are=20set=20up=0Ato=20mark=20new=20buffers=20and=20take=20care=20= of=20buffers=20whose=20file=20names=20change.=0AThis=20way=20the=20= existing=20poll-avoidance=20logic=20can=20be=20used,=20since=20the=0A= entire=20set=20of=20buffers=20in=20auto-revert=20is=20known.=0A=0AA=20= new=20hook,=20`after-set-visited-file-name-hook',=20was=20added=20to=20= handle=0Athe=20case=20when=20the=20file=20name=20of=20a=20tracked=20= buffer=20changes.=0A=0A*=20lisp/autorevert.el=20= (auto-revert-avoid-polling):=20Amend=20doc=20string.=0A= (auto-revert--global-mode):=20New=20buffer-local=20variable.=0A= (global-auto-revert-mode):=20Mark=20existing=20buffers=20and=20set=20up=20= hooks=20when=0Amode=20is=20entered;=20do=20the=20opposite=20when=20= exited.=0A(auto-revert--global-add-current-buffer)=0A= (auto-revert--global-adopt-current-buffer)=0A= (auto-revert--set-visited-file-name-advice):=20New=20functions.=0A= (auto-revert--polled-buffers,=20auto-revert--need-polling-p)=0A= (auto-revert-notify-handler)=0A(auto-revert-active-p):=20Modify=20logic=20= to=20cover=20global-auto-revert-mode.=0A*=20lisp/files.el=20= (after-set-visited-file-name-hook):=20New=20hook.=0A= (set-visited-file-name-hook):=20Call=20new=20hook.=0A*=20= test/lisp/autorevert-tests.el=20(top):=20=20Use=20lexical-binding.=0A= (auto-revert-test--write-file,=20auto-revert-test--buffer-string)=0A= (auto-revert-test--wait-for,=20auto-revert-test--wait-for-buffer-text)=0A= (auto-revert-test05-global-notify):=20New=20test.=0A*=20= doc/lispref/hooks.texi=20(Standard=20Hooks):=0AMention=20new=20hook=20= (in=20a=20comment,=20since=20it's=20unclear=20whether=20it=20should=0A= actually=20be=20documented=20here)=0A*=20etc/NEWS=20(Changes=20in=20= Specialized=20Modes=20and=20Packages):=20Update=20entry.=0A---=0A=20= doc/lispref/hooks.texi=20=20=20=20=20=20=20=20|=20=20=201=20+=0A=20= etc/NEWS=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= |=20=20=203=20+-=0A=20lisp/autorevert.el=20=20=20=20=20=20=20=20=20=20=20= =20|=20122=20++++++++++++++++++++++++++--------=0A=20lisp/files.el=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20|=20=20=206=20+-=0A=20= test/lisp/autorevert-tests.el=20|=20=2099=20++++++++++++++++++++++++++-=0A= =205=20files=20changed,=20201=20insertions(+),=2030=20deletions(-)=0A=0A= diff=20--git=20a/doc/lispref/hooks.texi=20b/doc/lispref/hooks.texi=0A= index=2071992464e0..f775aa4d4b=20100644=0A---=20a/doc/lispref/hooks.texi=0A= +++=20b/doc/lispref/hooks.texi=0A@@=20-251,6=20+251,7=20@@=20I=20thought=20= did=20not=20need=20to=20be=20mentioned=20here:=0A=20=0A=20Lisp:=0A=20= after-load-functions=0A+after-set-visited-file-name-hook=0A=20= auto-coding-functions=0A=20choose-completion-string-functions=0A=20= completing-read-function=0Adiff=20--git=20a/etc/NEWS=20b/etc/NEWS=0A= index=20b4aa8d98ff..62ace1ac12=20100644=0A---=20a/etc/NEWS=0A+++=20= b/etc/NEWS=0A@@=20-1443,8=20+1443,7=20@@=20When=20set=20to=20a=20non-nil=20= value,=20buffers=20in=20Auto=20Revert=20mode=20are=20no=20longer=0A=20= polled=20for=20changes=20periodically.=20=20This=20reduces=20the=20power=20= consumption=0A=20of=20an=20idle=20Emacs,=20but=20may=20fail=20on=20some=20= network=20file=20systems;=20set=0A=20= 'auto-revert-notify-exclude-dir-regexp'=20to=20match=20files=20where=0A= -notification=20is=20not=20supported.=20=20The=20new=20variable=20= currently=20has=20no=0A-effect=20in=20'global-auto-revert-mode'.=20=20= The=20default=20value=20is=20nil.=0A+notification=20is=20not=20= supported.=20=20The=20default=20value=20is=20nil.=0A=20=0A=20***=20New=20= variable=20'buffer-auto-revert-by-notification'=0A=20A=20major=20mode=20= can=20declare=20that=20notification=20on=20the=20buffer's=20default=0A= diff=20--git=20a/lisp/autorevert.el=20b/lisp/autorevert.el=0Aindex=20= 197a2bf157..56b8a3fed3=20100644=0A---=20a/lisp/autorevert.el=0A+++=20= b/lisp/autorevert.el=0A@@=20-312,10=20+312,7=20@@=20when=20those=20files=20= are=20modified=20from=20another=20computer.=0A=20=0A=20When=20nil,=20= buffers=20in=20Auto-Revert=20Mode=20will=20always=20be=20polled=20for=0A=20= changes=20to=20their=20files=20on=20disk=20every=20= `auto-revert-interval'=0A-seconds,=20in=20addition=20to=20using=20= notification=20for=20those=20files.=0A-=0A-In=20Global=20Auto-Revert=20= Mode,=20polling=20is=20always=20done=20regardless=20of=0A-the=20value=20= of=20this=20variable."=0A+seconds,=20in=20addition=20to=20using=20= notification=20for=20those=20files."=0A=20=20=20:group=20'auto-revert=0A=20= =20=20:type=20'boolean=0A=20=20=20:set=20(lambda=20(variable=20value)=0A= @@=20-335,6=20+332,9=20@@=20buffers=20to=20this=20list.=0A=20The=20timer=20= function=20`auto-revert-buffers'=20is=20responsible=20for=20purging=0A=20= the=20list=20of=20old=20buffers.")=0A=20=0A+(defvar-local=20= auto-revert--global-mode=20nil=0A+=20=20"Non-nil=20if=20buffer=20is=20= handled=20by=20Global=20Auto-Revert=20mode.")=0A+=0A=20(defvar=20= auto-revert-remaining-buffers=20()=0A=20=20=20"Buffers=20not=20checked=20= when=20user=20input=20stopped=20execution.")=0A=20=0A@@=20-501,34=20= +501,107=20@@=20specifies=20in=20the=20mode=20line."=0A=20=20=20:global=20= t=20:group=20'auto-revert=20:lighter=20global-auto-revert-mode-text=0A=20= =20=20(auto-revert-set-timer)=0A=20=20=20(if=20global-auto-revert-mode=0A= -=20=20=20=20=20=20(auto-revert-buffers)=0A+=20=20=20=20=20=20;;=20Turn=20= global-auto-revert-mode=20ON.=0A+=20=20=20=20=20=20(progn=0A+=20=20=20=20= =20=20=20=20(dolist=20(buf=20(buffer-list))=0A+=20=20=20=20=20=20=20=20=20= =20(with-current-buffer=20buf=0A+=20=20=20=20=20=20=20=20=20=20=20=20= (auto-revert--global-add-current-buffer)))=0A+=20=20=20=20=20=20=20=20;;=20= Make=20sure=20future=20buffers=20are=20added=20as=20well.=0A+=20=20=20=20= =20=20=20=20(add-hook=20'find-file-hook=20= #'auto-revert--global-adopt-current-buffer)=0A+=20=20=20=20=20=20=20=20= (add-hook=20'after-set-visited-file-name-hook=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20= #'auto-revert--global-set-visited-file-name)=0A+=20=20=20=20=20=20=20=20= ;;=20To=20track=20non-file=20buffers,=20we=20need=20to=20listen=20in=20= to=20buffer=0A+=20=20=20=20=20=20=20=20;;=20creation=20in=20general.=20=20= Listening=20to=20major-mode=20changes=20is=0A+=20=20=20=20=20=20=20=20;;=20= suitable,=20since=20we=20then=20know=20whether=20it's=20a=20mode=20that=20= is=20tracked.=0A+=20=20=20=20=20=20=20=20(when=20= global-auto-revert-non-file-buffers=0A+=20=20=20=20=20=20=20=20=20=20= (add-hook=20'after-change-major-mode-hook=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20= #'auto-revert--global-adopt-current-buffer))=0A+=20=20=20=20=20=20=20=20= (auto-revert-buffers))=0A+=20=20=20=20;;=20Turn=20= global-auto-revert-mode=20OFF.=0A+=20=20=20=20(remove-hook=20= 'after-change-major-mode-hook=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20#'auto-revert--global-adopt-current-buffer)=0A+=20=20=20=20= (remove-hook=20'after-set-visited-file-name-hook=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20= #'auto-revert--global-set-visited-file-name)=0A+=20=20=20=20(remove-hook=20= 'find-file-hook=20#'auto-revert--global-adopt-current-buffer)=0A=20=20=20= =20=20(dolist=20(buf=20(buffer-list))=0A=20=20=20=20=20=20=20= (with-current-buffer=20buf=0A-=20=20=20=20=20=20=20=20(when=20(and=20= auto-revert-notify-watch-descriptor=0A-=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(not=20(memq=20buf=20auto-revert-buffer-list)))=0A-=09= =20=20(auto-revert-notify-rm-watch))))))=0A+=20=20=20=20=20=20=20=20= (when=20auto-revert--global-mode=0A+=20=20=20=20=20=20=20=20=20=20(setq=20= auto-revert--global-mode=20nil)=0A+=20=20=20=20=20=20=20=20=20=20(when=20= (and=20auto-revert-notify-watch-descriptor=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(not=20(or=20auto-revert-mode=20= auto-revert-tail-mode)))=0A+=09=20=20=20=20= (auto-revert-notify-rm-watch)))))))=0A+=0A+(defun=20= auto-revert--global-add-current-buffer=20()=0A+=20=20"Set=20current=20= buffer=20to=20be=20tracked=20by=20Global=20Auto-Revert=20if=20= appropriate."=0A+=20=20(when=20(and=20(not=20auto-revert--global-mode)=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20(or=20buffer-file-name=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(and=20= global-auto-revert-non-file-buffers=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20(not=20(string-prefix-p=20"=20"=20= (buffer-name)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20;;=20Any=20non-file=20buffer=20must=20have=20a=20custom=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20= `buffer-stale-function'=20to=20be=20tracked,=20since=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20we=20wouldn't=20= know=20when=20to=20revert=20it=20otherwise.=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(not=20(eq=20= buffer-stale-function=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= #'buffer-stale--default-function))))=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20(not=20(memq=20'major-mode=20global-auto-revert-ignore-modes))=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20(not=20= global-auto-revert-ignore-buffer))=0A+=20=20=20=20(setq=20= auto-revert--global-mode=20t)))=0A+=0A+(defun=20= auto-revert--global-adopt-current-buffer=20()=0A+=20=20"Consider=20= tracking=20current=20buffer=20in=20a=20running=20Global=20Auto-Revert=20= mode."=0A+=20=20(auto-revert--global-add-current-buffer)=0A+=20=20= (auto-revert-set-timer))=0A+=0A+(defun=20= auto-revert--global-set-visited-file-name=20()=0A+=20=20"Update=20Global=20= Auto-Revert=20management=20of=20the=20current=20buffer.=0A+Called=20= after=20`set-visited-file-name'."=0A+=20=20;;=20Remove=20any=20existing=20= notifier=20first=20so=20that=20we=20don't=20track=20the=0A+=20=20;;=20= wrong=20file=20in=20case=20the=20file=20name=20was=20changed.=0A+=20=20= (when=20auto-revert-notify-watch-descriptor=0A+=20=20=20=20= (auto-revert-notify-rm-watch))=0A+=20=20= (auto-revert--global-adopt-current-buffer))=0A=20=0A=20(defun=20= auto-revert--polled-buffers=20()=0A=20=20=20"List=20of=20buffers=20that=20= need=20to=20be=20polled."=0A-=20=20(cond=20(global-auto-revert-mode=20= (buffer-list))=0A+=20=20(cond=20(global-auto-revert-mode=0A+=20=20=20=20=20= =20=20=20=20(mapcan=20(lambda=20(buffer)=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(and=20(not=20(and=20= auto-revert-avoid-polling=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= buffer)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(or=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert--global-mode=20buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=20= 'auto-revert-mode=20buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=20= 'auto-revert-tail-mode=20buffer))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(list=20buffer)))=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(buffer-list)))=0A=20=20=20=20=20=20=20=20= =20(auto-revert-avoid-polling=0A=20=20=20=20=20=20=20=20=20=20(mapcan=20= (lambda=20(buffer)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(and=20(not=20(buffer-local-value=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buffer))=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(list=20buffer)))=0A= -=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffer-list))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(and=20(not=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buffer))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(list=20buffer)))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20auto-revert-buffer-list))=0A= =20=20=20=20=20=20=20=20=20(t=20auto-revert-buffer-list)))=0A=20=0A=20;;=20= Same=20as=20above=20in=20a=20boolean=20context,=20but=20cheaper.=0A=20= (defun=20auto-revert--need-polling-p=20()=0A=20=20=20"Whether=20periodic=20= polling=20is=20required."=0A-=20=20(or=20global-auto-revert-mode=0A-=20=20= =20=20=20=20(if=20auto-revert-avoid-polling=0A-=20=20=20=20=20=20=20=20=20= =20(not=20(cl-every=20(lambda=20(buffer)=0A-=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=0A= -=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20'auto-revert-notify-watch-descriptor=20buffer))=0A-=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffer-list))=0A-=20=20=20=20=20=20=20=20= auto-revert-buffer-list)))=0A+=20=20(cond=20(global-auto-revert-mode=0A+=20= =20=20=20=20=20=20=20=20(or=20(not=20auto-revert-avoid-polling)=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20(cl-some=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(lambda=20(buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(and=20(not=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buffer))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(or=20(buffer-local-value=20= 'auto-revert--global-mode=20buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=20= 'auto-revert-mode=20buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=20= 'auto-revert-tail-mode=20buffer))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(buffer-list))))=0A+=20=20=20=20=20=20=20=20= (auto-revert-avoid-polling=0A+=20=20=20=20=20=20=20=20=20(not=20= (cl-every=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(lambda=20= (buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20'auto-revert-notify-watch-descriptor=20buffer))=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20auto-revert-buffer-list)))=0A+=20=20=20=20=20=20=20= =20(t=20auto-revert-buffer-list)))=0A=20=0A=20(defun=20= auto-revert-set-timer=20()=0A=20=20=20"Restart=20or=20cancel=20the=20= timer=20used=20by=20Auto-Revert=20Mode.=0A@@=20-652,9=20+725,8=20@@=20= system.")=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(null=20buffer-file-name))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(auto-revert-notify-rm-watch)=0A=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20;;=20Restart=20the=20timer=20if=20it=20wasn't=20= running.=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20(and=20= (memq=20buffer=20auto-revert-buffer-list)=0A-=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(not=20= auto-revert-timer))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(auto-revert-set-timer)))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(unless=20auto-revert-timer)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(auto-revert-set-timer))))=0A=20=0A=20=20=20=20=20=20= =20=20=20;;=20Loop=20over=20all=20buffers,=20in=20order=20to=20find=20= the=20intended=20one.=0A=20=20=20=20=20=20=20=20=20(cl-dolist=20(buffer=20= buffers)=0A@@=20-700,9=20+772,7=20@@=20If=20the=20buffer=20needs=20to=20= be=20reverted,=20do=20it=20now."=0A=20=20=20"Check=20if=20auto-revert=20= is=20active=20(in=20current=20buffer=20or=20globally)."=0A=20=20=20(or=20= auto-revert-mode=0A=20=20=20=20=20=20=20auto-revert-tail-mode=0A-=20=20=20= =20=20=20(and=20global-auto-revert-mode=0A-=20=20=20=20=20=20=20=20=20=20= =20(not=20global-auto-revert-ignore-buffer)=0A-=20=20=20=20=20=20=20=20=20= =20=20(not=20(memq=20major-mode=20global-auto-revert-ignore-modes)))))=0A= +=20=20=20=20=20=20auto-revert--global-mode))=0A=20=0A=20(defun=20= auto-revert-handler=20()=0A=20=20=20"Revert=20current=20buffer,=20if=20= appropriate.=0Adiff=20--git=20a/lisp/files.el=20b/lisp/files.el=0Aindex=20= 1dec0ed7ca..287ad14aec=20100644=0A---=20a/lisp/files.el=0A+++=20= b/lisp/files.el=0A@@=20-4269,6=20+4269,9=20@@=20However,=20the=20mode=20= will=20not=20be=20changed=20if=0A=20=20=20:type=20'boolean=0A=20=20=20= :group=20'editing-basics)=0A=20=0A+(defvar=20= after-set-visited-file-name-hook=20nil=0A+=20=20"Normal=20hook=20run=20= just=20after=20setting=20visited=20file=20name=20of=20current=20= buffer.")=0A+=0A=20(defun=20set-visited-file-name=20(filename=20= &optional=20no-query=20along-with-file)=0A=20=20=20"Change=20name=20of=20= file=20visited=20in=20current=20buffer=20to=20FILENAME.=0A=20This=20also=20= renames=20the=20buffer=20to=20correspond=20to=20the=20new=20file.=0A@@=20= -4389,7=20+4392,8=20@@=20the=20old=20visited=20file=20has=20been=20= renamed=20to=20the=20new=20name=20FILENAME."=0A=20=09=20=20=20=20=20=20= (set-auto-mode=20t)=0A=20=09=20=20=20=20=20=20(or=20(eq=20old=20= major-mode)=0A=20=09=09=20=20(hack-local-variables))))=0A-=20=20=20=20= (error=20nil))))=0A+=20=20=20=20=20=20(error=20nil))=0A+=20=20=20=20= (run-hooks=20'after-set-visited-file-name-hook)))=0A=20=0A=20(defun=20= write-file=20(filename=20&optional=20confirm)=0A=20=20=20"Write=20= current=20buffer=20into=20file=20FILENAME.=0Adiff=20--git=20= a/test/lisp/autorevert-tests.el=20b/test/lisp/autorevert-tests.el=0A= index=208cdddf824d..751c2291c8=20100644=0A---=20= a/test/lisp/autorevert-tests.el=0A+++=20b/test/lisp/autorevert-tests.el=0A= @@=20-1,4=20+1,4=20@@=0A-;;;=20auto-revert-tests.el=20---=20Tests=20of=20= auto-revert=0A+;;;=20auto-revert-tests.el=20---=20Tests=20of=20= auto-revert=20=20=20-*-=20lexical-binding:=20t=20-*-=0A=20=0A=20;;=20= Copyright=20(C)=202015-2019=20Free=20Software=20Foundation,=20Inc.=0A=20=0A= @@=20-435,6=20+435,103=20@@=20This=20expects=20`auto-revert--messages'=20= to=20be=20bound=20by=0A=20(auto-revert--deftest-remote=20= auto-revert-test04-auto-revert-mode-dired=0A=20=20=20"Check=20remote=20= autorevert=20for=20dired.")=0A=20=0A+(defun=20= auto-revert-test--write-file=20(string=20file)=0A+=20=20(write-region=20= string=20nil=20file=20nil=20'no-message))=0A+=0A+(defun=20= auto-revert-test--buffer-string=20(buffer)=0A+=20=20(with-current-buffer=20= buffer=0A+=20=20=20=20(buffer-string)))=0A+=0A+(defun=20= auto-revert-test--wait-for=20(pred=20max-wait)=0A+=20=20"Wait=20until=20= PRED=20is=20true,=20or=20MAX-WAIT=20seconds=20elapsed."=0A+=20=20(let=20= ((ct=20(current-time)))=0A+=20=20=20=20(while=20(and=20(<=20(float-time=20= (time-subtract=20(current-time)=20ct))=20max-wait)=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(not=20(funcall=20pred)))=0A+=20=20=20=20=20=20= (read-event=20nil=20nil=200.1))))=0A+=0A+(defun=20= auto-revert-test--wait-for-buffer-text=20(buffer=20string=20max-wait)=0A= +=20=20"Wait=20until=20BUFFER=20has=20the=20contents=20STRING,=20or=20= MAX-WAIT=20seconds=20elapsed."=0A+=20=20(auto-revert-test--wait-for=0A+=20= =20=20(lambda=20()=20(string-equal=20(auto-revert-test--buffer-string=20= buffer)=20string))=0A+=20=20=20max-wait))=0A+=0A+(ert-deftest=20= auto-revert-test05-global-notify=20()=0A+=20=20"Test=20= global-auto-revert-mode=20without=20polling."=0A+=20=20(let*=20= ((auto-revert-avoid-polling=20t)=0A+=20=20=20=20=20=20=20=20=20= (auto-revert-interval=202)=20=20=20=20=20=20=20;=20To=20speed=20up=20the=20= test.=0A+=20=20=20=20=20=20=20=20=20(file-1=20(make-temp-file=20= "global-auto-revert-test-1"))=0A+=20=20=20=20=20=20=20=20=20(file-2=20= (make-temp-file=20"global-auto-revert-test-2"))=0A+=20=20=20=20=20=20=20=20= =20(file-3=20(make-temp-file=20"global-auto-revert-test-3"))=0A+=20=20=20= =20=20=20=20=20=20(file-2b=20(concat=20file-2=20"-b"))=0A+=20=20=20=20=20= =20=20=20=20buf-1=20buf-2=20buf-3)=0A+=20=20=20=20(unwind-protect=0A+=20=20= =20=20=20=20=20=20(progn=0A+=20=20=20=20=20=20=20=20=20=20(setq=20buf-1=20= (find-file-noselect=20file-1))=0A+=20=20=20=20=20=20=20=20=20=20(setq=20= buf-2=20(find-file-noselect=20file-2))=0A+=20=20=20=20=20=20=20=20=20=20= (auto-revert-test--write-file=20"1-a"=20file-1)=0A+=20=20=20=20=20=20=20=20= =20=20(should=20(equal=20(auto-revert-test--buffer-string=20buf-1)=20= ""))=0A+=0A+=20=20=20=20=20=20=20=20=20=20(global-auto-revert-mode=201)=20= =20=20;=20Turn=20it=20on.=0A+=0A+=20=20=20=20=20=20=20=20=20=20(should=20= (buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20'auto-revert-notify-watch-descriptor=20buf-1))=0A+=20=20=20=20=20=20= =20=20=20=20(should=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20'auto-revert-notify-watch-descriptor=20= buf-2))=0A+=0A+=20=20=20=20=20=20=20=20=20=20;;=20buf-1=20should=20have=20= been=20reverted=20immediately=20when=20the=20mode=0A+=20=20=20=20=20=20=20= =20=20=20;;=20was=20enabled.=0A+=20=20=20=20=20=20=20=20=20=20(should=20= (equal=20(auto-revert-test--buffer-string=20buf-1)=20"1-a"))=0A+=0A+=20=20= =20=20=20=20=20=20=20=20;;=20Alter=20a=20file.=0A+=20=20=20=20=20=20=20=20= =20=20(auto-revert-test--write-file=20"2-a"=20file-2)=0A+=20=20=20=20=20=20= =20=20=20=20;;=20Allow=20for=20some=20time=20to=20handle=20notification=20= events.=0A+=20=20=20=20=20=20=20=20=20=20= (auto-revert-test--wait-for-buffer-text=20buf-2=20"2-a"=201)=0A+=20=20=20= =20=20=20=20=20=20=20(should=20(equal=20(auto-revert-test--buffer-string=20= buf-2)=20"2-a"))=0A+=0A+=20=20=20=20=20=20=20=20=20=20;;=20Visit=20a=20= file,=20and=20modify=20it=20on=20disk.=0A+=20=20=20=20=20=20=20=20=20=20= (setq=20buf-3=20(find-file-noselect=20file-3))=0A+=20=20=20=20=20=20=20=20= =20=20;;=20Newly=20opened=20buffers=20won't=20be=20use=20notification=20= until=20the=0A+=20=20=20=20=20=20=20=20=20=20;;=20first=20poll=20cycle;=20= wait=20for=20it.=0A+=20=20=20=20=20=20=20=20=20=20= (auto-revert-test--wait-for=0A+=20=20=20=20=20=20=20=20=20=20=20(lambda=20= ()=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20'auto-revert-notify-watch-descriptor=20buf-3))=0A= +=20=20=20=20=20=20=20=20=20=20=20(+=20auto-revert-interval=201))=0A+=20=20= =20=20=20=20=20=20=20=20(should=20(buffer-local-value=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buf-3))=0A+=20=20=20=20=20=20=20=20= =20=20(auto-revert-test--write-file=20"3-a"=20file-3)=0A+=20=20=20=20=20=20= =20=20=20=20(auto-revert-test--wait-for-buffer-text=20buf-3=20"3-a"=201)=0A= +=20=20=20=20=20=20=20=20=20=20(should=20(equal=20= (auto-revert-test--buffer-string=20buf-3)=20"3-a"))=0A+=20=20=20=20=20=20= =20=20=20=20=0A+=20=20=20=20=20=20=20=20=20=20;;=20Delete=20a=20visited=20= file,=20and=20re-create=20it=20with=20new=20contents.=0A+=20=20=20=20=20=20= =20=20=20=20(delete-file=20file-1)=0A+=20=20=20=20=20=20=20=20=20=20= (sleep-for=200.5)=0A+=20=20=20=20=20=20=20=20=20=20(should=20(equal=20= (auto-revert-test--buffer-string=20buf-1)=20"1-a"))=0A+=20=20=20=20=20=20= =20=20=20=20(auto-revert-test--write-file=20"1-b"=20file-1)=0A+=20=20=20=20= =20=20=20=20=20=20(auto-revert-test--wait-for-buffer-text=20buf-1=20= "1-b"=0A+=20=20=20=20=20=20=20=20=20=20=20(+=20auto-revert-interval=20= 1))=0A+=20=20=20=20=20=20=20=20=20=20(should=20(buffer-local-value=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buf-1))=0A+=0A+=20=20=20=20=20=20=20= =20=20=20;;=20Write=20a=20buffer=20to=20a=20new=20file,=20then=20modify=20= the=20new=20file=20on=20disk.=0A+=20=20=20=20=20=20=20=20=20=20= (with-current-buffer=20buf-2=0A+=20=20=20=20=20=20=20=20=20=20=20=20= (write-file=20file-2b))=0A+=20=20=20=20=20=20=20=20=20=20(should=20= (equal=20(auto-revert-test--buffer-string=20buf-2)=20"2-a"))=0A+=20=20=20= =20=20=20=20=20=20=20(auto-revert-test--write-file=20"2-b"=20file-2b)=0A= +=20=20=20=20=20=20=20=20=20=20(auto-revert-test--wait-for-buffer-text=20= buf-2=20"2-b"=0A+=20=20=20=20=20=20=20=20=20=20=20(+=20= auto-revert-interval=201))=0A+=20=20=20=20=20=20=20=20=20=20(should=20= (buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20'auto-revert-notify-watch-descriptor=20buf-2)))=0A+=20=20=20=20=20=20= =0A+=20=20=20=20=20=20;;=20Clean=20up.=0A+=20=20=20=20=20=20= (global-auto-revert-mode=200)=20=20=20=20=20=20=20;=20Turn=20it=20off.=0A= +=20=20=20=20=20=20(dolist=20(buf=20(list=20buf-1=20buf-2=20buf-3))=0A+=20= =20=20=20=20=20=20=20(when=20(buffer-live-p=20buf)=0A+=20=20=20=20=20=20=20= =20=20=20(kill-buffer=20buf)))=0A+=20=20=20=20=20=20(dolist=20(file=20= (list=20file-1=20file-2=20file-2b=20file-3))=0A+=20=20=20=20=20=20=20=20= (ignore-errors=20(delete-file=20file)))=0A+=20=20=20=20=20=20)))=0A+=0A+=0A= =20(defun=20auto-revert-test-all=20(&optional=20interactive)=0A=20=20=20= "Run=20all=20tests=20for=20\\[auto-revert]."=0A=20=20=20(interactive=20= "p")=0A--=20=0A2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_AF8798C5-E6FE-4D80-B142-17DC723249D5-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 May 2019 09:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15582571706763 (code B ref 35418); Sun, 19 May 2019 09:13:02 +0000 Received: (at 35418) by debbugs.gnu.org; 19 May 2019 09:12:50 +0000 Received: from localhost ([127.0.0.1]:33764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSHs9-0001l1-RL for submit@debbugs.gnu.org; Sun, 19 May 2019 05:12:50 -0400 Received: from mout.gmx.net ([212.227.17.22]:40207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSHs7-0001kn-BZ for 35418@debbugs.gnu.org; Sun, 19 May 2019 05:12:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1558257154; bh=Tf70ZXRRjvAgJ2WVs2Zb44pGaLCHO9tJNH2i3S4d9bI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=konC0LIA9eQi7WSs0VNRM5i1vvqHu6a5AZ1o+K9925Imk27m9O8v7XBSmOlk9SCXf R+G6C3gg9OdkfoOjf0xEEDUP3qUpHzlAhJqnX14T75cJW0V32J8gvcO9v5PTq/Yor9 aeNqhfgRiUIWxqBcFoj0uqP3N6SU86mDBlTu9ll8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.60.145]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Mchyv-1hAU2F06oD-00Hx4b; Sun, 19 May 2019 11:12:34 +0200 From: Michael Albinus References: <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> <87muju1vx1.fsf@gmx.de> <25E4EBE0-0E65-45B7-B56F-9C67A2862DFA@acm.org> <87a7fu1nv8.fsf@gmx.de> <87tvdyie82.fsf@gmx.de> <4FD5C2DB-8F3D-4317-B8ED-CB7A4605A2F1@acm.org> Date: Sun, 19 May 2019 11:12:31 +0200 In-Reply-To: <4FD5C2DB-8F3D-4317-B8ED-CB7A4605A2F1@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Sat, 18 May 2019 19:39:01 +0200") Message-ID: <87woimdczk.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Y4qM9GO0ePIF2rKqueb1jqMqAeFwlzwJ4Qb6quEYtMdL+LXHoyH 5AsqHgK8T5pqZJRopPJYrfGM1VAbsPLgILAspfFt7adS076Zqu/3pMjC5kL1lVVNIR8SQjG OdMv8s2Z80Zzyk1NnP41QqpSd5ggojmqKXH1AEyRbLFME9DK9U4u96uHa10IRGgn196vgk/ FR2KHDevpEctW5VGxeQag== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:jEOas4qzFGE=:ttXLx1cxf5OX5L1+hEBcO9 +V0xTyy16LEu4GOrd2kMVUbCM4cdjuMqsH5WdGfzWrCUMWRoIlU6cWdf7AUB6IZwpr9zixldI lEdxgG3PXqXE48AAyUZZGeiNwwftLHFbPakT278EZI5Iohl8QL4paQ6jZ+nzSaPLDqW+ccxHh OhGuGPiS8CKuL0D7+8sVRb2JsUP3ZrX6odZdpgTSAMoDLqz3lapk/HLSppiFq3iwajYWJHSCn KCRVhdgM1ivxQmSFZBwW9JwZjZ1SAYF9FOrEbUxR1hZOLQyvfHwIu810nrYe1Irh4V3JnS/dH j95Rzzh8un19+v1rCjGWc2RM+fzaXpxds71Z7xkCICKf4zSZg9g5+mjfH/mytoSKM8a7ydOto H1akJPtRUEm/GaEuQm4C9WUUXAzdkhBCCKSqI69ewXm84Nu89sFzF+bhCSM9GxXYQIgmTKqB5 fQKGHRzrEeilQ0CSd7/Qs8/ujG51ijQKo9F4rn0gnbtZQkIVS3pbT14371qoeA8qEmXYHP8dp du8fUxn3BZ7MQlcyXRJOYEk6r+hm/D4zG+DbqGtT4qrq9SgvXFSZlbq1yTbxpVnEkSlQdd9Ge Eq957o0rjbKsek1fNo4PASYT26SSXI5DzfH1xEIWkGShbiqt+RFN6nLbI7taAWte5sRycsiBQ H9XwHR/tfmpVmwIvE96aSJIZnNf2GOagfIe2p0Hkh2Yc/Xr0eOFZ9J9Kz6AQKJCuwu8jQrocj C8C60rXXtdGoDrtZxMU9HSQcUIgcGNXBocH4+NCJuriU8pKm+JTdes29wUoGPFc4yo5S1xyZo 4lxoHvKVMdguZvJXnV6oqhsmZuMtu2Bu09COm5OLgozn62IdSzd15li3jy0TFq+x/Ls5GKh34 ydkCtrjStvbvBK4K/D7LFweMdmdoHFDvPWToRh6v9FI9DXK0+6cR21SxKTyCcSa5Rbsk5XPx0 exc2r+dHOXYerFFLhe/AV3g+YWQLVQhv+ZrXt87f/kzKzQptXb9Ad X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, > Thank you -- I added one, but have only access to kqueue at the moment > so I haven't run it on anything else. Thanks. I've applied it also for inotify, gfile, inotifywait and gio-monitor. All tests passed, at least the local ones. auto-revert-test05-global-notify-remote (see below) failed; this one I could debug myself once the patch has landed in master. I suspect timing issues. Btw, you could always run the four tests on emba.gnu.org. Submit a change (also a git branch would do), and the bot on emba.git.org would run these test constellations for you. Same for filenotify-tests. Comments: > --- a/lisp/autorevert.el > +++ b/lisp/autorevert.el > "Check if auto-revert is active (in current buffer or globally)." Remove "or globally". > --- a/test/lisp/autorevert-tests.el > +++ b/test/lisp/autorevert-tests.el > +(defun auto-revert-test--write-file (string file) > + (write-region string nil file nil 'no-message)) > + > +(defun auto-revert-test--buffer-string (buffer) > + (with-current-buffer buffer > + (buffer-string))) Pls add a docstring. > +(ert-deftest auto-revert-test05-global-notify () > + "Test global-auto-revert-mode without polling." Quote `global-auto-revert-mode'. Check also, whether file notification is enabled: (skip-unless (or file-notify--library (file-remote-p temporary-file-directory))) > + (let* ((auto-revert-avoid-polling t) Enable file notification explicitly. You don't know, whether the user has disabled it. (let* ((auto-revert-use-notify t) (auto-revert-avoid-polling t) > + (auto-revert-interval 2) ; To speed up the test. Do we really want this? I prefer to test the unmodified package. If you believe this takes too much time for ordinary "make check" calls, you might tag the test case as :expensive-test, like auto-revert-test01-auto-revert-several-files and auto-revert-test02-auto-revert-deleted-file. > + (global-auto-revert-mode 1) ; Turn it on. Save the value of global-auto-revert-mode, and reset it in Cleanup. You don't know the user's settings. > + (dolist (buf (list buf-1 buf-2 buf-3)) > + (when (buffer-live-p buf) > + (kill-buffer buf))) Why not (ignore-errors (kill-buffer buf)) ? Add the remote test case: (auto-revert--deftest-remote auto-revert-test05-global-notify "Test `global-auto-revert-mode' without polling for remote buffers." Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 May 2019 20:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155829756722644 (code B ref 35418); Sun, 19 May 2019 20:27:02 +0000 Received: (at 35418) by debbugs.gnu.org; 19 May 2019 20:26:07 +0000 Received: from localhost ([127.0.0.1]:35621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSSNj-0005t9-5h for submit@debbugs.gnu.org; Sun, 19 May 2019 16:26:07 -0400 Received: from mail231c50.megamailservers.eu ([91.136.10.241]:45784 helo=mail37c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSSNe-0005sg-I0 for 35418@debbugs.gnu.org; Sun, 19 May 2019 16:26:04 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1558297560; bh=I+V/ekYuYzOephDAGzfV9buOAo2yZfiSCK+rtW/oqOc=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=LPexf9FYlgn6BIHGuQUS3DtAEeLZxClA7KHUxA73VvClemfLlW4DAaHZR+PtbWTA8 ExYndxqWeBCf54MgRHbWIS1f3vfE6STmm7gOYYXY3EZ2/VEVNXemB9D/kMaloBlOaD HoZCnO0j1DIayyWeYzzskSNLmkLschC/O0xlZUbA= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] ([188.150.171.71]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x4JKPwx7008220; Sun, 19 May 2019 20:25:59 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_EF6DBC5C-583C-44D9-B8C9-D2D2DA0C277A" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Date: Sun, 19 May 2019 22:25:57 +0200 In-Reply-To: <87woimdczk.fsf@gmx.de> References: <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> <87muju1vx1.fsf@gmx.de> <25E4EBE0-0E65-45B7-B56F-9C67A2862DFA@acm.org> <87a7fu1nv8.fsf@gmx.de> <87tvdyie82.fsf@gmx.de> <4FD5C2DB-8F3D-4317-B8ED-CB7A4605A2F1@acm.org> <87woimdczk.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0201.5CE1BBD8.004A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=ItQwjo3g c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=mDV3o1hIAAAA:8 a=lEriqonRAAAA:8 a=MPMERgMrRkygqWAbCeAA:9 a=qj69CpH6klWzQLlh:21 a=6V4oaCkPR5AWawAC:21 a=CjuIK1q_8ugA:10 a=fPw3ZMCt_jpd5vk-e2sA:9 a=B2y7HmGcmWMA:10 a=_FVE-zBwftR9WsbkzFJk:22 a=iCVytvwig4ZIu1j4Gkh3:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_EF6DBC5C-583C-44D9-B8C9-D2D2DA0C277A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 19 maj 2019 kl. 11.12 skrev Michael Albinus : >=20 > Btw, you could always run the four tests on emba.gnu.org. Submit a > change (also a git branch would do), and the bot on emba.git.org would > run these test constellations for you. Same for filenotify-tests. That's good to know -- I'll try that next time. >> "Check if auto-revert is active (in current buffer or globally)." >=20 > Remove "or globally". Done. >> +(defun auto-revert-test--write-file (string file) >> + (write-region string nil file nil 'no-message)) >> + >> +(defun auto-revert-test--buffer-string (buffer) >> + (with-current-buffer buffer >> + (buffer-string))) >=20 > Pls add a docstring. Added. >> +(ert-deftest auto-revert-test05-global-notify () >> + "Test global-auto-revert-mode without polling." >=20 > Quote `global-auto-revert-mode'. Check also, whether file notification > is enabled: >=20 > (skip-unless (or file-notify--library > (file-remote-p temporary-file-directory))) Quoted, and check added. >> + (let* ((auto-revert-avoid-polling t) >=20 > Enable file notification explicitly. You don't know, whether the user > has disabled it. >=20 > (let* ((auto-revert-use-notify t) > (auto-revert-avoid-polling t) Done. >> + (auto-revert-interval 2) ; To speed up the test. >=20 > Do we really want this? I prefer to test the unmodified package. If = you > believe this takes too much time for ordinary "make check" calls, you > might tag the test case as :expensive-test, like > auto-revert-test01-auto-revert-several-files and > auto-revert-test02-auto-revert-deleted-file. That was probably just me being impatient; I've removed that line and = added :expensive-test. >> + (global-auto-revert-mode 1) ; Turn it on. >=20 > Save the value of global-auto-revert-mode, and reset it in Cleanup. = You > don't know the user's settings. Done. >> + (dolist (buf (list buf-1 buf-2 buf-3)) >> + (when (buffer-live-p buf) >> + (kill-buffer buf))) >=20 > Why not (ignore-errors (kill-buffer buf)) ? Using a condition felt more precise, but I have no strong opinion in = this case. Changed to ignore-errors. > Add the remote test case: >=20 > (auto-revert--deftest-remote auto-revert-test05-global-notify > "Test `global-auto-revert-mode' without polling for remote buffers." Added. Thanks for the tests and review! Revised patch attached. --Apple-Mail=_EF6DBC5C-583C-44D9-B8C9-D2D2DA0C277A Content-Disposition: attachment; filename=0001-Avoid-polling-in-global-auto-revert-mode-bug-35418.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Avoid-polling-in-global-auto-revert-mode-bug-35418.patch" Content-Transfer-Encoding: quoted-printable =46rom=202877e205b2fd90fac03b56aa8022d1c7722bfd6f=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Thu,=209=20May=202019=2009:40:46=20+0200=0A= Subject:=20[PATCH]=20Avoid=20polling=20in=20global-auto-revert-mode=20= (bug#35418)=0A=0AMake=20`auto-revert-avoid-polling'=20have=20effect=20in=20= global-auto-revert-mode.=0ABuffers=20actually=20handled=20by=20that=20= mode=20are=20marked=20with=20a=20non-nil=20value=0Aof=20= `auto-revert--global-mode'.=20=20When=20global-auto-revert-mode=20is=0A= entered,=20eligible=20buffers=20are=20marked=20in=20that=20way,=20and=20= hooks=20are=20set=20up=0Ato=20mark=20new=20buffers=20and=20take=20care=20= of=20buffers=20whose=20file=20names=20change.=0AThis=20way=20the=20= existing=20poll-avoidance=20logic=20can=20be=20used,=20since=20the=0A= entire=20set=20of=20buffers=20in=20auto-revert=20is=20known.=0A=0AA=20= new=20hook,=20`after-set-visited-file-name-hook',=20was=20added=20to=20= handle=0Athe=20case=20when=20the=20file=20name=20of=20a=20tracked=20= buffer=20changes.=0A=0A*=20lisp/autorevert.el=20= (auto-revert-avoid-polling):=20Amend=20doc=20string.=0A= (auto-revert--global-mode):=20New=20buffer-local=20variable.=0A= (global-auto-revert-mode):=20Mark=20existing=20buffers=20and=20set=20up=20= hooks=20when=0Amode=20is=20entered;=20do=20the=20opposite=20when=20= exited.=0A(auto-revert--global-add-current-buffer)=0A= (auto-revert--global-adopt-current-buffer)=0A= (auto-revert--set-visited-file-name-advice):=20New=20functions.=0A= (auto-revert--polled-buffers,=20auto-revert--need-polling-p)=0A= (auto-revert-notify-handler)=0A(auto-revert-active-p):=20Modify=20logic=20= to=20cover=20global-auto-revert-mode.=0A*=20lisp/files.el=20= (after-set-visited-file-name-hook):=20New=20hook.=0A= (set-visited-file-name-hook):=20Call=20new=20hook.=0A*=20= test/lisp/autorevert-tests.el=20(top):=20=20Use=20lexical-binding.=0A= (auto-revert-test--write-file,=20auto-revert-test--buffer-string)=0A= (auto-revert-test--wait-for,=20auto-revert-test--wait-for-buffer-text)=0A= (auto-revert-test05-global-notify):=20New=20test.=0A*=20= doc/lispref/hooks.texi=20(Standard=20Hooks):=0AMention=20new=20hook=20= (in=20a=20comment,=20since=20it's=20unclear=20whether=20it=20should=0A= actually=20be=20documented=20here)=0A*=20etc/NEWS=20(Changes=20in=20= Specialized=20Modes=20and=20Packages):=20Update=20entry.=0A---=0A=20= doc/lispref/hooks.texi=20=20=20=20=20=20=20=20|=20=20=201=20+=0A=20= etc/NEWS=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= |=20=20=203=20+-=0A=20lisp/autorevert.el=20=20=20=20=20=20=20=20=20=20=20= =20|=20124=20++++++++++++++++++++++++++--------=0A=20lisp/files.el=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20|=20=20=206=20+-=0A=20= test/lisp/autorevert-tests.el=20|=20107=20++++++++++++++++++++++++++++-=0A= =205=20files=20changed,=20210=20insertions(+),=2031=20deletions(-)=0A=0A= diff=20--git=20a/doc/lispref/hooks.texi=20b/doc/lispref/hooks.texi=0A= index=2071992464e0..f775aa4d4b=20100644=0A---=20a/doc/lispref/hooks.texi=0A= +++=20b/doc/lispref/hooks.texi=0A@@=20-251,6=20+251,7=20@@=20I=20thought=20= did=20not=20need=20to=20be=20mentioned=20here:=0A=20=0A=20Lisp:=0A=20= after-load-functions=0A+after-set-visited-file-name-hook=0A=20= auto-coding-functions=0A=20choose-completion-string-functions=0A=20= completing-read-function=0Adiff=20--git=20a/etc/NEWS=20b/etc/NEWS=0A= index=20d70cda179e..9ca98c370e=20100644=0A---=20a/etc/NEWS=0A+++=20= b/etc/NEWS=0A@@=20-1443,8=20+1443,7=20@@=20When=20set=20to=20a=20non-nil=20= value,=20buffers=20in=20Auto=20Revert=20mode=20are=20no=20longer=0A=20= polled=20for=20changes=20periodically.=20=20This=20reduces=20the=20power=20= consumption=0A=20of=20an=20idle=20Emacs,=20but=20may=20fail=20on=20some=20= network=20file=20systems;=20set=0A=20= 'auto-revert-notify-exclude-dir-regexp'=20to=20match=20files=20where=0A= -notification=20is=20not=20supported.=20=20The=20new=20variable=20= currently=20has=20no=0A-effect=20in=20'global-auto-revert-mode'.=20=20= The=20default=20value=20is=20nil.=0A+notification=20is=20not=20= supported.=20=20The=20default=20value=20is=20nil.=0A=20=0A=20***=20New=20= variable=20'buffer-auto-revert-by-notification'=0A=20A=20major=20mode=20= can=20declare=20that=20notification=20on=20the=20buffer's=20default=0A= diff=20--git=20a/lisp/autorevert.el=20b/lisp/autorevert.el=0Aindex=20= 197a2bf157..2de855b303=20100644=0A---=20a/lisp/autorevert.el=0A+++=20= b/lisp/autorevert.el=0A@@=20-312,10=20+312,7=20@@=20when=20those=20files=20= are=20modified=20from=20another=20computer.=0A=20=0A=20When=20nil,=20= buffers=20in=20Auto-Revert=20Mode=20will=20always=20be=20polled=20for=0A=20= changes=20to=20their=20files=20on=20disk=20every=20= `auto-revert-interval'=0A-seconds,=20in=20addition=20to=20using=20= notification=20for=20those=20files.=0A-=0A-In=20Global=20Auto-Revert=20= Mode,=20polling=20is=20always=20done=20regardless=20of=0A-the=20value=20= of=20this=20variable."=0A+seconds,=20in=20addition=20to=20using=20= notification=20for=20those=20files."=0A=20=20=20:group=20'auto-revert=0A=20= =20=20:type=20'boolean=0A=20=20=20:set=20(lambda=20(variable=20value)=0A= @@=20-335,6=20+332,9=20@@=20buffers=20to=20this=20list.=0A=20The=20timer=20= function=20`auto-revert-buffers'=20is=20responsible=20for=20purging=0A=20= the=20list=20of=20old=20buffers.")=0A=20=0A+(defvar-local=20= auto-revert--global-mode=20nil=0A+=20=20"Non-nil=20if=20buffer=20is=20= handled=20by=20Global=20Auto-Revert=20mode.")=0A+=0A=20(defvar=20= auto-revert-remaining-buffers=20()=0A=20=20=20"Buffers=20not=20checked=20= when=20user=20input=20stopped=20execution.")=0A=20=0A@@=20-501,34=20= +501,107=20@@=20specifies=20in=20the=20mode=20line."=0A=20=20=20:global=20= t=20:group=20'auto-revert=20:lighter=20global-auto-revert-mode-text=0A=20= =20=20(auto-revert-set-timer)=0A=20=20=20(if=20global-auto-revert-mode=0A= -=20=20=20=20=20=20(auto-revert-buffers)=0A+=20=20=20=20=20=20;;=20Turn=20= global-auto-revert-mode=20ON.=0A+=20=20=20=20=20=20(progn=0A+=20=20=20=20= =20=20=20=20(dolist=20(buf=20(buffer-list))=0A+=20=20=20=20=20=20=20=20=20= =20(with-current-buffer=20buf=0A+=20=20=20=20=20=20=20=20=20=20=20=20= (auto-revert--global-add-current-buffer)))=0A+=20=20=20=20=20=20=20=20;;=20= Make=20sure=20future=20buffers=20are=20added=20as=20well.=0A+=20=20=20=20= =20=20=20=20(add-hook=20'find-file-hook=20= #'auto-revert--global-adopt-current-buffer)=0A+=20=20=20=20=20=20=20=20= (add-hook=20'after-set-visited-file-name-hook=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20= #'auto-revert--global-set-visited-file-name)=0A+=20=20=20=20=20=20=20=20= ;;=20To=20track=20non-file=20buffers,=20we=20need=20to=20listen=20in=20= to=20buffer=0A+=20=20=20=20=20=20=20=20;;=20creation=20in=20general.=20=20= Listening=20to=20major-mode=20changes=20is=0A+=20=20=20=20=20=20=20=20;;=20= suitable,=20since=20we=20then=20know=20whether=20it's=20a=20mode=20that=20= is=20tracked.=0A+=20=20=20=20=20=20=20=20(when=20= global-auto-revert-non-file-buffers=0A+=20=20=20=20=20=20=20=20=20=20= (add-hook=20'after-change-major-mode-hook=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20= #'auto-revert--global-adopt-current-buffer))=0A+=20=20=20=20=20=20=20=20= (auto-revert-buffers))=0A+=20=20=20=20;;=20Turn=20= global-auto-revert-mode=20OFF.=0A+=20=20=20=20(remove-hook=20= 'after-change-major-mode-hook=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20#'auto-revert--global-adopt-current-buffer)=0A+=20=20=20=20= (remove-hook=20'after-set-visited-file-name-hook=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20= #'auto-revert--global-set-visited-file-name)=0A+=20=20=20=20(remove-hook=20= 'find-file-hook=20#'auto-revert--global-adopt-current-buffer)=0A=20=20=20= =20=20(dolist=20(buf=20(buffer-list))=0A=20=20=20=20=20=20=20= (with-current-buffer=20buf=0A-=20=20=20=20=20=20=20=20(when=20(and=20= auto-revert-notify-watch-descriptor=0A-=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(not=20(memq=20buf=20auto-revert-buffer-list)))=0A-=09= =20=20(auto-revert-notify-rm-watch))))))=0A+=20=20=20=20=20=20=20=20= (when=20auto-revert--global-mode=0A+=20=20=20=20=20=20=20=20=20=20(setq=20= auto-revert--global-mode=20nil)=0A+=20=20=20=20=20=20=20=20=20=20(when=20= (and=20auto-revert-notify-watch-descriptor=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(not=20(or=20auto-revert-mode=20= auto-revert-tail-mode)))=0A+=09=20=20=20=20= (auto-revert-notify-rm-watch)))))))=0A+=0A+(defun=20= auto-revert--global-add-current-buffer=20()=0A+=20=20"Set=20current=20= buffer=20to=20be=20tracked=20by=20Global=20Auto-Revert=20if=20= appropriate."=0A+=20=20(when=20(and=20(not=20auto-revert--global-mode)=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20(or=20buffer-file-name=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(and=20= global-auto-revert-non-file-buffers=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20(not=20(string-prefix-p=20"=20"=20= (buffer-name)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20;;=20Any=20non-file=20buffer=20must=20have=20a=20custom=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20= `buffer-stale-function'=20to=20be=20tracked,=20since=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20we=20wouldn't=20= know=20when=20to=20revert=20it=20otherwise.=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(not=20(eq=20= buffer-stale-function=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= #'buffer-stale--default-function))))=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20(not=20(memq=20'major-mode=20global-auto-revert-ignore-modes))=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20(not=20= global-auto-revert-ignore-buffer))=0A+=20=20=20=20(setq=20= auto-revert--global-mode=20t)))=0A+=0A+(defun=20= auto-revert--global-adopt-current-buffer=20()=0A+=20=20"Consider=20= tracking=20current=20buffer=20in=20a=20running=20Global=20Auto-Revert=20= mode."=0A+=20=20(auto-revert--global-add-current-buffer)=0A+=20=20= (auto-revert-set-timer))=0A+=0A+(defun=20= auto-revert--global-set-visited-file-name=20()=0A+=20=20"Update=20Global=20= Auto-Revert=20management=20of=20the=20current=20buffer.=0A+Called=20= after=20`set-visited-file-name'."=0A+=20=20;;=20Remove=20any=20existing=20= notifier=20first=20so=20that=20we=20don't=20track=20the=0A+=20=20;;=20= wrong=20file=20in=20case=20the=20file=20name=20was=20changed.=0A+=20=20= (when=20auto-revert-notify-watch-descriptor=0A+=20=20=20=20= (auto-revert-notify-rm-watch))=0A+=20=20= (auto-revert--global-adopt-current-buffer))=0A=20=0A=20(defun=20= auto-revert--polled-buffers=20()=0A=20=20=20"List=20of=20buffers=20that=20= need=20to=20be=20polled."=0A-=20=20(cond=20(global-auto-revert-mode=20= (buffer-list))=0A+=20=20(cond=20(global-auto-revert-mode=0A+=20=20=20=20=20= =20=20=20=20(mapcan=20(lambda=20(buffer)=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(and=20(not=20(and=20= auto-revert-avoid-polling=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= buffer)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(or=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert--global-mode=20buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=20= 'auto-revert-mode=20buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=20= 'auto-revert-tail-mode=20buffer))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(list=20buffer)))=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(buffer-list)))=0A=20=20=20=20=20=20=20=20= =20(auto-revert-avoid-polling=0A=20=20=20=20=20=20=20=20=20=20(mapcan=20= (lambda=20(buffer)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(and=20(not=20(buffer-local-value=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buffer))=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(list=20buffer)))=0A= -=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffer-list))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(and=20(not=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buffer))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(list=20buffer)))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20auto-revert-buffer-list))=0A= =20=20=20=20=20=20=20=20=20(t=20auto-revert-buffer-list)))=0A=20=0A=20;;=20= Same=20as=20above=20in=20a=20boolean=20context,=20but=20cheaper.=0A=20= (defun=20auto-revert--need-polling-p=20()=0A=20=20=20"Whether=20periodic=20= polling=20is=20required."=0A-=20=20(or=20global-auto-revert-mode=0A-=20=20= =20=20=20=20(if=20auto-revert-avoid-polling=0A-=20=20=20=20=20=20=20=20=20= =20(not=20(cl-every=20(lambda=20(buffer)=0A-=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=0A= -=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20'auto-revert-notify-watch-descriptor=20buffer))=0A-=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffer-list))=0A-=20=20=20=20=20=20=20=20= auto-revert-buffer-list)))=0A+=20=20(cond=20(global-auto-revert-mode=0A+=20= =20=20=20=20=20=20=20=20(or=20(not=20auto-revert-avoid-polling)=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20(cl-some=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(lambda=20(buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(and=20(not=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buffer))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(or=20(buffer-local-value=20= 'auto-revert--global-mode=20buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=20= 'auto-revert-mode=20buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(buffer-local-value=20= 'auto-revert-tail-mode=20buffer))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(buffer-list))))=0A+=20=20=20=20=20=20=20=20= (auto-revert-avoid-polling=0A+=20=20=20=20=20=20=20=20=20(not=20= (cl-every=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(lambda=20= (buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20'auto-revert-notify-watch-descriptor=20buffer))=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20auto-revert-buffer-list)))=0A+=20=20=20=20=20=20=20= =20(t=20auto-revert-buffer-list)))=0A=20=0A=20(defun=20= auto-revert-set-timer=20()=0A=20=20=20"Restart=20or=20cancel=20the=20= timer=20used=20by=20Auto-Revert=20Mode.=0A@@=20-652,9=20+725,8=20@@=20= system.")=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(null=20buffer-file-name))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(auto-revert-notify-rm-watch)=0A=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20;;=20Restart=20the=20timer=20if=20it=20wasn't=20= running.=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20(and=20= (memq=20buffer=20auto-revert-buffer-list)=0A-=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(not=20= auto-revert-timer))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(auto-revert-set-timer)))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(unless=20auto-revert-timer)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(auto-revert-set-timer))))=0A=20=0A=20=20=20=20=20=20= =20=20=20;;=20Loop=20over=20all=20buffers,=20in=20order=20to=20find=20= the=20intended=20one.=0A=20=20=20=20=20=20=20=20=20(cl-dolist=20(buffer=20= buffers)=0A@@=20-697,12=20+769,10=20@@=20If=20the=20buffer=20needs=20to=20= be=20reverted,=20do=20it=20now."=0A=20=20=20=20=20=20=20=20=20= (auto-revert-handler)))))=0A=20=0A=20(defun=20auto-revert-active-p=20()=0A= -=20=20"Check=20if=20auto-revert=20is=20active=20(in=20current=20buffer=20= or=20globally)."=0A+=20=20"Check=20if=20auto-revert=20is=20active=20in=20= current=20buffer."=0A=20=20=20(or=20auto-revert-mode=0A=20=20=20=20=20=20= =20auto-revert-tail-mode=0A-=20=20=20=20=20=20(and=20= global-auto-revert-mode=0A-=20=20=20=20=20=20=20=20=20=20=20(not=20= global-auto-revert-ignore-buffer)=0A-=20=20=20=20=20=20=20=20=20=20=20= (not=20(memq=20major-mode=20global-auto-revert-ignore-modes)))))=0A+=20=20= =20=20=20=20auto-revert--global-mode))=0A=20=0A=20(defun=20= auto-revert-handler=20()=0A=20=20=20"Revert=20current=20buffer,=20if=20= appropriate.=0Adiff=20--git=20a/lisp/files.el=20b/lisp/files.el=0Aindex=20= 1dec0ed7ca..287ad14aec=20100644=0A---=20a/lisp/files.el=0A+++=20= b/lisp/files.el=0A@@=20-4269,6=20+4269,9=20@@=20However,=20the=20mode=20= will=20not=20be=20changed=20if=0A=20=20=20:type=20'boolean=0A=20=20=20= :group=20'editing-basics)=0A=20=0A+(defvar=20= after-set-visited-file-name-hook=20nil=0A+=20=20"Normal=20hook=20run=20= just=20after=20setting=20visited=20file=20name=20of=20current=20= buffer.")=0A+=0A=20(defun=20set-visited-file-name=20(filename=20= &optional=20no-query=20along-with-file)=0A=20=20=20"Change=20name=20of=20= file=20visited=20in=20current=20buffer=20to=20FILENAME.=0A=20This=20also=20= renames=20the=20buffer=20to=20correspond=20to=20the=20new=20file.=0A@@=20= -4389,7=20+4392,8=20@@=20the=20old=20visited=20file=20has=20been=20= renamed=20to=20the=20new=20name=20FILENAME."=0A=20=09=20=20=20=20=20=20= (set-auto-mode=20t)=0A=20=09=20=20=20=20=20=20(or=20(eq=20old=20= major-mode)=0A=20=09=09=20=20(hack-local-variables))))=0A-=20=20=20=20= (error=20nil))))=0A+=20=20=20=20=20=20(error=20nil))=0A+=20=20=20=20= (run-hooks=20'after-set-visited-file-name-hook)))=0A=20=0A=20(defun=20= write-file=20(filename=20&optional=20confirm)=0A=20=20=20"Write=20= current=20buffer=20into=20file=20FILENAME.=0Adiff=20--git=20= a/test/lisp/autorevert-tests.el=20b/test/lisp/autorevert-tests.el=0A= index=20af9edac1be..7c8a83d6ca=20100644=0A---=20= a/test/lisp/autorevert-tests.el=0A+++=20b/test/lisp/autorevert-tests.el=0A= @@=20-1,4=20+1,4=20@@=0A-;;;=20auto-revert-tests.el=20---=20Tests=20of=20= auto-revert=0A+;;;=20auto-revert-tests.el=20---=20Tests=20of=20= auto-revert=20=20=20-*-=20lexical-binding:=20t=20-*-=0A=20=0A=20;;=20= Copyright=20(C)=202015-2019=20Free=20Software=20Foundation,=20Inc.=0A=20=0A= @@=20-433,6=20+433,111=20@@=20This=20expects=20`auto-revert--messages'=20= to=20be=20bound=20by=0A=20(auto-revert--deftest-remote=20= auto-revert-test04-auto-revert-mode-dired=0A=20=20=20"Check=20remote=20= autorevert=20for=20dired.")=0A=20=0A+(defun=20= auto-revert-test--write-file=20(string=20file)=0A+=20=20"Write=20STRING=20= to=20FILE."=0A+=20=20(write-region=20string=20nil=20file=20nil=20= 'no-message))=0A+=0A+(defun=20auto-revert-test--buffer-string=20(buffer)=0A= +=20=20"Contents=20of=20BUFFER=20as=20a=20string."=0A+=20=20= (with-current-buffer=20buffer=0A+=20=20=20=20(buffer-string)))=0A+=0A= +(defun=20auto-revert-test--wait-for=20(pred=20max-wait)=0A+=20=20"Wait=20= until=20PRED=20is=20true,=20or=20MAX-WAIT=20seconds=20elapsed."=0A+=20=20= (let=20((ct=20(current-time)))=0A+=20=20=20=20(while=20(and=20(<=20= (float-time=20(time-subtract=20(current-time)=20ct))=20max-wait)=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(not=20(funcall=20pred)))=0A+=20= =20=20=20=20=20(read-event=20nil=20nil=200.1))))=0A+=0A+(defun=20= auto-revert-test--wait-for-buffer-text=20(buffer=20string=20max-wait)=0A= +=20=20"Wait=20until=20BUFFER=20has=20the=20contents=20STRING,=20or=20= MAX-WAIT=20seconds=20elapsed."=0A+=20=20(auto-revert-test--wait-for=0A+=20= =20=20(lambda=20()=20(string-equal=20(auto-revert-test--buffer-string=20= buffer)=20string))=0A+=20=20=20max-wait))=0A+=0A+(ert-deftest=20= auto-revert-test05-global-notify=20()=0A+=20=20"Test=20= `global-auto-revert-mode'=20without=20polling."=0A+=20=20:tags=20= '(:expensive-test)=0A+=20=20(skip-unless=20(or=20file-notify--library=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(file-remote-p=20= temporary-file-directory)))=0A+=20=20(let*=20((auto-revert-use-notify=20= t)=0A+=20=20=20=20=20=20=20=20=20(auto-revert-avoid-polling=20t)=0A+=20=20= =20=20=20=20=20=20=20(was-in-global-auto-revert-mode=20= global-auto-revert-mode)=0A+=20=20=20=20=20=20=20=20=20(file-1=20= (make-temp-file=20"global-auto-revert-test-1"))=0A+=20=20=20=20=20=20=20=20= =20(file-2=20(make-temp-file=20"global-auto-revert-test-2"))=0A+=20=20=20= =20=20=20=20=20=20(file-3=20(make-temp-file=20= "global-auto-revert-test-3"))=0A+=20=20=20=20=20=20=20=20=20(file-2b=20= (concat=20file-2=20"-b"))=0A+=20=20=20=20=20=20=20=20=20buf-1=20buf-2=20= buf-3)=0A+=20=20=20=20(unwind-protect=0A+=20=20=20=20=20=20=20=20(progn=0A= +=20=20=20=20=20=20=20=20=20=20(setq=20buf-1=20(find-file-noselect=20= file-1))=0A+=20=20=20=20=20=20=20=20=20=20(setq=20buf-2=20= (find-file-noselect=20file-2))=0A+=20=20=20=20=20=20=20=20=20=20= (auto-revert-test--write-file=20"1-a"=20file-1)=0A+=20=20=20=20=20=20=20=20= =20=20(should=20(equal=20(auto-revert-test--buffer-string=20buf-1)=20= ""))=0A+=0A+=20=20=20=20=20=20=20=20=20=20(global-auto-revert-mode=201)=20= =20=20;=20Turn=20it=20on.=0A+=0A+=20=20=20=20=20=20=20=20=20=20(should=20= (buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20'auto-revert-notify-watch-descriptor=20buf-1))=0A+=20=20=20=20=20=20= =20=20=20=20(should=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20'auto-revert-notify-watch-descriptor=20= buf-2))=0A+=0A+=20=20=20=20=20=20=20=20=20=20;;=20buf-1=20should=20have=20= been=20reverted=20immediately=20when=20the=20mode=0A+=20=20=20=20=20=20=20= =20=20=20;;=20was=20enabled.=0A+=20=20=20=20=20=20=20=20=20=20(should=20= (equal=20(auto-revert-test--buffer-string=20buf-1)=20"1-a"))=0A+=0A+=20=20= =20=20=20=20=20=20=20=20;;=20Alter=20a=20file.=0A+=20=20=20=20=20=20=20=20= =20=20(auto-revert-test--write-file=20"2-a"=20file-2)=0A+=20=20=20=20=20=20= =20=20=20=20;;=20Allow=20for=20some=20time=20to=20handle=20notification=20= events.=0A+=20=20=20=20=20=20=20=20=20=20= (auto-revert-test--wait-for-buffer-text=20buf-2=20"2-a"=201)=0A+=20=20=20= =20=20=20=20=20=20=20(should=20(equal=20(auto-revert-test--buffer-string=20= buf-2)=20"2-a"))=0A+=0A+=20=20=20=20=20=20=20=20=20=20;;=20Visit=20a=20= file,=20and=20modify=20it=20on=20disk.=0A+=20=20=20=20=20=20=20=20=20=20= (setq=20buf-3=20(find-file-noselect=20file-3))=0A+=20=20=20=20=20=20=20=20= =20=20;;=20Newly=20opened=20buffers=20won't=20be=20use=20notification=20= until=20the=0A+=20=20=20=20=20=20=20=20=20=20;;=20first=20poll=20cycle;=20= wait=20for=20it.=0A+=20=20=20=20=20=20=20=20=20=20= (auto-revert-test--wait-for=0A+=20=20=20=20=20=20=20=20=20=20=20(lambda=20= ()=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20'auto-revert-notify-watch-descriptor=20buf-3))=0A= +=20=20=20=20=20=20=20=20=20=20=20(+=20auto-revert-interval=201))=0A+=20=20= =20=20=20=20=20=20=20=20(should=20(buffer-local-value=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20= 'auto-revert-notify-watch-descriptor=20buf-3))=0A+=20=20=20=20=20=20=20=20= =20=20(auto-revert-test--write-file=20"3-a"=20file-3)=0A+=20=20=20=20=20=20= =20=20=20=20(auto-revert-test--wait-for-buffer-text=20buf-3=20"3-a"=201)=0A= +=20=20=20=20=20=20=20=20=20=20(should=20(equal=20= (auto-revert-test--buffer-string=20buf-3)=20"3-a"))=0A+=0A+=20=20=20=20=20= =20=20=20=20=20;;=20Delete=20a=20visited=20file,=20and=20re-create=20it=20= with=20new=20contents.=0A+=20=20=20=20=20=20=20=20=20=20(delete-file=20= file-1)=0A+=20=20=20=20=20=20=20=20=20=20(sleep-for=200.5)=0A+=20=20=20=20= =20=20=20=20=20=20(should=20(equal=20(auto-revert-test--buffer-string=20= buf-1)=20"1-a"))=0A+=20=20=20=20=20=20=20=20=20=20= (auto-revert-test--write-file=20"1-b"=20file-1)=0A+=20=20=20=20=20=20=20=20= =20=20(auto-revert-test--wait-for-buffer-text=20buf-1=20"1-b"=0A+=20=20=20= =20=20=20=20=20=20=20=20(+=20auto-revert-interval=201))=0A+=20=20=20=20=20= =20=20=20=20=20(should=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20'auto-revert-notify-watch-descriptor=20= buf-1))=0A+=0A+=20=20=20=20=20=20=20=20=20=20;;=20Write=20a=20buffer=20= to=20a=20new=20file,=20then=20modify=20the=20new=20file=20on=20disk.=0A+=20= =20=20=20=20=20=20=20=20=20(with-current-buffer=20buf-2=0A+=20=20=20=20=20= =20=20=20=20=20=20=20(write-file=20file-2b))=0A+=20=20=20=20=20=20=20=20=20= =20(should=20(equal=20(auto-revert-test--buffer-string=20buf-2)=20= "2-a"))=0A+=20=20=20=20=20=20=20=20=20=20(auto-revert-test--write-file=20= "2-b"=20file-2b)=0A+=20=20=20=20=20=20=20=20=20=20= (auto-revert-test--wait-for-buffer-text=20buf-2=20"2-b"=0A+=20=20=20=20=20= =20=20=20=20=20=20(+=20auto-revert-interval=201))=0A+=20=20=20=20=20=20=20= =20=20=20(should=20(buffer-local-value=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20'auto-revert-notify-watch-descriptor=20buf-2)))=0A= +=0A+=20=20=20=20=20=20;;=20Clean=20up.=0A+=20=20=20=20=20=20(unless=20= was-in-global-auto-revert-mode=0A+=20=20=20=20=20=20=20=20= (global-auto-revert-mode=200))=20=20=20=20;=20Turn=20it=20off.=0A+=20=20=20= =20=20=20(dolist=20(buf=20(list=20buf-1=20buf-2=20buf-3))=0A+=20=20=20=20= =20=20=20=20(ignore-errors=20(kill-buffer=20buf)))=0A+=20=20=20=20=20=20= (dolist=20(file=20(list=20file-1=20file-2=20file-2b=20file-3))=0A+=20=20=20= =20=20=20=20=20(ignore-errors=20(delete-file=20file)))=0A+=20=20=20=20=20= =20)))=0A+=0A+(auto-revert--deftest-remote=20= auto-revert-test04-auto-revert-mode-dired=0A+=20=20"Test=20= `global-auto-revert-mode'=20without=20polling=20for=20remote=20= buffers.")=0A+=0A=20(defun=20auto-revert-test-all=20(&optional=20= interactive)=0A=20=20=20"Run=20all=20tests=20for=20\\[auto-revert]."=0A=20= =20=20(interactive=20"p")=0A--=20=0A2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_EF6DBC5C-583C-44D9-B8C9-D2D2DA0C277A-- From unknown Sun Jun 22 08:10:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 May 2019 07:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , 35418@debbugs.gnu.org Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155833741531690 (code B ref 35418); Mon, 20 May 2019 07:31:01 +0000 Received: (at 35418) by debbugs.gnu.org; 20 May 2019 07:30:15 +0000 Received: from localhost ([127.0.0.1]:35994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSckR-0008F3-FH for submit@debbugs.gnu.org; Mon, 20 May 2019 03:30:15 -0400 Received: from mout.gmx.net ([212.227.17.21]:41225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSckP-0008Dv-5f for 35418@debbugs.gnu.org; Mon, 20 May 2019 03:30:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1558337403; bh=PjqTJtQrzaPeUBf/iBxY2+Y6f4jx++qAJjudcL0SaVU=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Sr9sMJQbavXpBIX+VAYyybhyvM6Bhdr3cyjDEGZiwb1Pn1u32BJhQoQIQ3vju64Bu 3AsluMmI3E432Lb5y3uY34eIVMSarNH/uVP94kOZsGPsN8ul0gqSjRVD9LGxdcheLe Xr82XQGx66UUsjqqIAphh285Z/85UopHpd3gGejk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.60.145]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LmOLO-1gt0oL0dn8-00ZtfL; Mon, 20 May 2019 09:30:03 +0200 From: Michael Albinus References: <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> <87muju1vx1.fsf@gmx.de> <25E4EBE0-0E65-45B7-B56F-9C67A2862DFA@acm.org> <87a7fu1nv8.fsf@gmx.de> <87tvdyie82.fsf@gmx.de> <4FD5C2DB-8F3D-4317-B8ED-CB7A4605A2F1@acm.org> <87woimdczk.fsf@gmx.de> Date: Mon, 20 May 2019 09:30:01 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Sun, 19 May 2019 22:25:57 +0200") Message-ID: <87k1eld1mu.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:3SM8/B5s91qAqzVT1KT63JaYF9y4s4OijxBcqu7hwuLBZ02wH/b zwzEMgW1hYKxp70gEj/fgJ8Z3snSMKY+GKkMkMu+oV+JzhOy6cUb3hfe17f9+fX2GgcQoO3 ptuJ3xd+ncAfy0qjQteNIIyMaS6wiOWbRbcmhjHAX1WHXwS0ZGYGwHnzkLdS2XZyCrGMLCF HYEApMDEEy9NvtNr+VNwg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:k2f1fQphMBY=:ExvZcPUq1jH+pDLWB/+sdW fnriFnJwBkrOezxrbzTMpnKyEnVbgd9zhAddGVfh2n3ZYYdfyZfJhmRND8f5CursoMLJSUzhi +yg3hrC5o6eaWtEI0xSVeVDHcn4ceO7Ho3JqbfT0KPjtio/OzYf/ljaYP2J+ra7z+VGgAw1mW wwYpO5jxuknFPtWqgrkXOrW+bSPbGw7lVf8YW9qiX9dw7C5hlwRsrQeOlE8VfuGfmXbLVnMjI oVzm27KAuQH3+lIKfB56hhWzOrWuKAh9RGIbUSVRnHBkHQleirOplJxNZvS98q2RB6z216NZm Zd+0/M7+0LHkzFHEB2IV+6dncgsayY4x4r+6lA5OMmSuiQZxJytBszDXG0sNl6njA+RoA796H elS8Xk4HFkWgmgg3N3hyOOl52UYeZa36ueexF5+j9UMGgVRahPfrL2OBJVKwSXwhu+jzFMe5Q B6zJpSMM3oBITljoJw2KnPYFGK6aZW/ZmcSyIp1rjEB1Ma7sc69XHX7AW0y7BaaYKhtCor0dM ljWNWjfDUa3ed7U4rXBN/WPVkL54k0lScZWkBxAZHpDiguTCFiG3NXuAyIKStjCn/XyCuHMo3 WxDjGRuBgh2gJI96NF7KqCCHEBtnGC+T9xNzgya57isMxKOOZP0XMZ+2FM4e35k9OrqHCqdAd yzFlvy5CZKQMkh/P4huD0w0lX299FWIrbx0kraVMfYOLYglrMSP2FB51dYHfT0a6cWIXOj+aj AWHZe5uIIeiDKy5i4IigGBHORjGShuhcNa0FuusvqyQtXKWvhX7l/sVS7j3RKvcSC3QOJ+xn5 jd0jKdvw/oRG2REKaprZJ+vZM3zn9tijzL3R4gOKeLrTCPfD95pO79ty2UzF47Vm0pwcPIMsM v6aWT+lWFX4nb+kDjPwk0XOi3D3RDC+4db5/wtgxs2QVkhip8UwlCrYdm4esHBj77mE15TFyP +oxJOVTqNHiiTIncHdqgv8aPhqe/Ml1r0GR2y2sFGhXNY503z2b1a X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: Hi Mattias, >> Btw, you could always run the four tests on emba.gnu.org. Submit a >> change (also a git branch would do), and the bot on emba.git.org would >> run these test constellations for you. Same for filenotify-tests. > > That's good to know -- I'll try that next time. You can see it just now :-) >From my POV, the patch is fine, and could be committed. Whether it is successful will be told us by emba.gnu.org (and hydra.nixos.org). This is the last change wrt bug#35418, isn't it? You could close the bug then, if both CI systems do not report an error for autorevert-tests or filenotify-tests. Best regards, Michael. From unknown Sun Jun 22 08:10:26 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Subject: bug#35418: closed (Re: bug#35418: [PATCH] Don't poll auto-revert files that use notification) Message-ID: References: X-Gnu-PR-Message: they-closed 35418 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 35418@debbugs.gnu.org Date: Mon, 20 May 2019 19:20:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1558380002-27854-1" This is a multi-part message in MIME format... ------------=_1558380002-27854-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #35418: [PATCH] Don't poll auto-revert files that use notification which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 35418@debbugs.gnu.org. --=20 35418: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35418 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1558380002-27854-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 35418-done) by debbugs.gnu.org; 20 May 2019 19:19:45 +0000 Received: from localhost ([127.0.0.1]:37944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSnp3-0007Ei-3s for submit@debbugs.gnu.org; Mon, 20 May 2019 15:19:45 -0400 Received: from mail74c50.megamailservers.eu ([91.136.10.84]:41022 helo=mail92c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSnp0-0007EX-N4 for 35418-done@debbugs.gnu.org; Mon, 20 May 2019 15:19:44 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1558379979; bh=FHJKX+5RcBsGxkwkUyp3wnp2bXwkpRZ9lA/sCfi4YZI=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=jAkkd1OW6b77e2VOC4Gvl7xUlkTX4Gga2lXdHBwKqGvOioKotfbDBZIHtp+AQV7hU 7KFZA57ft71wMb8jZB81AOB62Yqvjvi1RDqOZL5CL7eqd9QVXvs4SwR4iCU8XAA+Ie UffUtjNWzeIt8R6nXk9DM5BZj/WsV6xiBi/kCyZc= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] ([188.150.171.71]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x4KJJbWJ021053; Mon, 20 May 2019 19:19:38 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: bug#35418: [PATCH] Don't poll auto-revert files that use notification From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87k1eld1mu.fsf@gmx.de> Date: Mon, 20 May 2019 21:19:37 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <93015872-0F5F-4E27-97BB-94BA0EE72653@acm.org> <87muju1vx1.fsf@gmx.de> <25E4EBE0-0E65-45B7-B56F-9C67A2862DFA@acm.org> <87a7fu1nv8.fsf@gmx.de> <87tvdyie82.fsf@gmx.de> <4FD5C2DB-8F3D-4317-B8ED-CB7A4605A2F1@acm.org> <87woimdczk.fsf@gmx.de> <87k1eld1mu.fsf@gmx.de> To: Michael Albinus X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0214.5CE2FDCB.0048, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=LZQSFAXi c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mDV3o1hIAAAA:8 a=Zeg_oI3sAAAA:8 a=kWkBIV-WsdZTKym2FqoA:9 a=CjuIK1q_8ugA:10 a=aMj-4VGTj6kA:10 a=QqFNrm0a_HcA:10 a=_FVE-zBwftR9WsbkzFJk:22 a=vNaCMWw18gC7IBXgVNBD:22 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 35418-done Cc: Eli Zaretskii , 35418-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 20 maj 2019 kl. 09.30 skrev Michael Albinus : > > From my POV, the patch is fine, and could be committed. Whether it is > successful will be told us by emba.gnu.org (and hydra.nixos.org). Thanks for your diligence and patience; closing. ------------=_1558380002-27854-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Apr 2019 18:15:14 +0000 Received: from localhost ([127.0.0.1]:56476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJMQM-0002vl-8t for submit@debbugs.gnu.org; Wed, 24 Apr 2019 14:15:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJMQI-0002vR-Sc for submit@debbugs.gnu.org; Wed, 24 Apr 2019 14:15:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:54519) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJMQD-0005GY-G3 for submit@debbugs.gnu.org; Wed, 24 Apr 2019 14:15:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJMQC-0000I8-8H for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 14:15:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJMQB-0005Ea-6E for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 14:15:04 -0400 Received: from mail171c50.megamailservers.eu ([91.136.10.181]:43848 helo=mail92c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJMQA-00054H-MJ for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 14:15:03 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556129688; bh=xSPxTb2h8gRW2JNuIR2Pe4XPhfOOzGScaT15CLECOn0=; h=From:Subject:Date:Cc:To:From; b=E2x8sWA+IjmnJD5GH96zhhUbvK7ymW5tFyXwPuo9LLm+KUw4YylAgncXzIEBNVoaV 5j60tulStgnGOTZfe2DgmQxDJfKaDFcR4efAw3WmJFKYRUZaFvPdZNSkQ/IHR9ziob oFoWQQXj3p2ykEK0+5bRwNkGXZ29WQ+7dNj/J+GA= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] ([188.150.171.71]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3OIEkmE016500; Wed, 24 Apr 2019 18:14:48 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_57AAFA11-7B25-4780-B710-1F8E608189CB" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: [PATCH] Don't poll auto-revert files that use notification Message-Id: Date: Wed, 24 Apr 2019 20:14:46 +0200 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0214.5CC0A798.003B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=RrHr0huK c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=ONdRDGFD3O1zXpl4lkEA:9 a=D4b1L8H20t0ULcQ0:21 a=PXXmaejFQU7uZUuD:21 a=CjuIK1q_8ugA:10 a=UwLn2DouPOKXMJmAEYkA:9 a=B2y7HmGcmWMA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.10.181 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --Apple-Mail=_57AAFA11-7B25-4780-B710-1F8E608189CB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii It is a waste of power, on battery-powered devices in particular, to = poll files in auto-revert mode periodically when change notification is = used. The change is straightforward (attached patch); the main concern = is whether the notification system is reliable enough. In general, it probably is. There is a comment in w32notify.c about = SMB-mounted file systems from Samba servers; while Samba does support = notification nowadays, there are probably older systems still be = deficient in that regard. However, isn't this what = `auto-revert-notify-exclude-dir-regexp' is for? I'm not familiar with = the way Emacs is used on Windows, but would adding something like (rx bos (or "\\\\" "//") (one-or-more (not (any "/:\\"))) (any "/\\")) to `auto-revert-notify-exclude-dir-regexp' be a good start? Another note about what this patch does not do: global-auto-revert-mode = will still use polling. This could be added later on, if there is a good = place to hook into for buffer creation. --Apple-Mail=_57AAFA11-7B25-4780-B710-1F8E608189CB Content-Disposition: attachment; filename=0001-Don-t-poll-auto-revert-files-that-use-notification.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Don-t-poll-auto-revert-files-that-use-notification.patch" Content-Transfer-Encoding: quoted-printable =46rom=205074c65347736a716f335842206a1e2a2ad36a87=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Wed,=2024=20Apr=202019=2018:39:05=20+0200=0A= Subject:=20[PATCH]=20Don't=20poll=20auto-revert=20files=20that=20use=20= notification=0A=0AIt=20is=20a=20waste=20to=20periodically=20poll=20files=20= that=20use=20change=20notification=0Ain=20auto-revert=20mode;=20stop=20= doing=20that.=20=20If=20no=20files=20need=20polling,=0Aturn=20off=20the=20= periodic=20execution=20entirely=20to=20further=20avoid=20wasting=20= power.=0AUse=20a=20timer=20to=20inhibit=20immediate=20reversion=20for=20= some=20time=20after=20a=0Anotification.=0A=0AThis=20change=20does=20not=20= apply=20to=20files=20in=20global-auto-revert-mode,=20where=0Apolling=20= is=20still=20necessary.=0A=0A*=20lisp/autorevert.el=20= (auto-revert--polled-buffers):=20New.=0A= (auto-revert-remove-current-buffer,=20auto-revert-mode)=0A= (global-auto-revert-mode,=20auto-revert-set-timer)=0A= (auto-revert-notify-add-watch,=20auto-revert-buffers):=0AMaintain=20and=20= use=20auto-revert--polled-buffers.=0A(auto-revert-buffers-counter):=20= Remove.=0A(auto-revert-buffers-counter-lockedout):=20Remove.=0A= (auto-revert--lockout-interval):=20New.=0A(auto-revert--lockout-timer):=20= New.=0A(auto-revert-notify-handler):=20Maintain=20and=20use=20= auto-revert--polled-buffers.=0AHonour=20new=20lockout=20timer.=20=20= Start=20lockout=20timer=20if=20necessary.=0A(auto-revert--end-lockout):=20= New.=0A---=0A=20lisp/autorevert.el=20|=2084=20= +++++++++++++++++++++++++++++-----------------=0A=201=20file=20changed,=20= 53=20insertions(+),=2031=20deletions(-)=0A=0Adiff=20--git=20= a/lisp/autorevert.el=20b/lisp/autorevert.el=0Aindex=20= 1d20896c83..f7b33360ef=20100644=0A---=20a/lisp/autorevert.el=0A+++=20= b/lisp/autorevert.el=0A@@=20-319,6=20+319,11=20@@=20the=20list=20of=20= old=20buffers.")=0A=20(defvar=20auto-revert-tail-pos=200=0A=20=20=20= "Position=20of=20last=20known=20end=20of=20file.")=0A=20=0A+(defvar=20= auto-revert--polled-buffers=20()=0A+=20=20"List=20of=20buffers=20in=20= Auto-Revert=20Mode=20that=20must=20be=20polled.=0A+It=20contains=20the=20= buffers=20in=20`auto-revert-buffer-list'=20whose=0A= +`auto-revert-notify-watch-descriptor'=20is=20nil.")=0A+=0A=20(defun=20= auto-revert-find-file-function=20()=0A=20=20=20(setq-local=20= auto-revert-tail-pos=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (file-attribute-size=20(file-attributes=20buffer-file-name))))=0A@@=20= -346,8=20+351,12=20@@=20This=20has=20been=20reported=20by=20a=20file=20= notification=20event.")=0A=20(defun=20auto-revert-remove-current-buffer=20= (&optional=20buffer)=0A=20=20=20"Remove=20BUFFER=20from=20= `auto-revert-buffer-list'.=0A=20BUFFER=20defaults=20to=20= `current-buffer'."=0A+=20=20(unless=20buffer=0A+=20=20=20=20(setq=20= buffer=20(current-buffer)))=0A=20=20=20(setq=20auto-revert-buffer-list=0A= -=20=20=20=20=20=20=20=20(delq=20(or=20buffer=20(current-buffer))=20= auto-revert-buffer-list)))=0A+=20=20=20=20=20=20=20=20(delq=20buffer=20= auto-revert-buffer-list))=0A+=20=20(setq=20auto-revert--polled-buffers=0A= +=20=20=20=20=20=20=20=20(delq=20buffer=20auto-revert--polled-buffers)))=0A= =20=0A=20;;;###autoload=0A=20(define-minor-mode=20auto-revert-mode=0A@@=20= -367,6=20+376,7=20@@=20without=20being=20changed=20in=20the=20part=20= that=20is=20already=20in=20the=20buffer."=0A=20=20=20(if=20= auto-revert-mode=0A=20=20=20=20=20=20=20(when=20(not=20(memq=20= (current-buffer)=20auto-revert-buffer-list))=0A=20=20=20=20=20=20=20=20=20= (push=20(current-buffer)=20auto-revert-buffer-list)=0A+=20=20=20=20=20=20= =20=20(push=20(current-buffer)=20auto-revert--polled-buffers)=0A=20=20=20= =20=20=20=20=20=20(add-hook=0A=20=20=20=20=20=20=20=20=20=20= 'kill-buffer-hook=0A=20=20=20=20=20=20=20=20=20=20= #'auto-revert-remove-current-buffer=0A@@=20-479,7=20+489,8=20@@=20= specifies=20in=20the=20mode=20line."=0A=20=20=20=20=20=20=20= (auto-revert-buffers)=0A=20=20=20=20=20(dolist=20(buf=20(buffer-list))=0A= =20=20=20=20=20=20=20(with-current-buffer=20buf=0A-=09(when=20= auto-revert-notify-watch-descriptor=0A+=20=20=20=20=20=20=20=20(when=20= (and=20auto-revert-notify-watch-descriptor=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20(not=20(memq=20buf=20= auto-revert-buffer-list)))=0A=20=09=20=20= (auto-revert-notify-rm-watch))))))=0A=20=0A=20(defun=20= auto-revert-set-timer=20()=0A@@=20-492,7=20+503,7=20@@=20will=20use=20an=20= up-to-date=20value=20of=20`auto-revert-interval'"=0A=20=20=20(if=20= (timerp=20auto-revert-timer)=0A=20=20=20=20=20=20=20(cancel-timer=20= auto-revert-timer))=0A=20=20=20(setq=20auto-revert-timer=0A-=09(if=20(or=20= global-auto-revert-mode=20auto-revert-buffer-list)=0A+=09(if=20(or=20= global-auto-revert-mode=20auto-revert--polled-buffers)=0A=20=09=20=20=20=20= (run-with-timer=20auto-revert-interval=0A=20=09=09=09=20=20=20=20= auto-revert-interval=0A=20=09=09=09=20=20=20=20'auto-revert-buffers))))=0A= @@=20-551,6=20+562,8=20@@=20will=20use=20an=20up-to-date=20value=20of=20= `auto-revert-interval'"=0A=20=09=20=20=20=20=20=20=20(gethash=20= auto-revert-notify-watch-descriptor=0A=20=09=09=20=20=20=20=20=20=20=20= auto-revert--buffers-by-watch-descriptor))=0A=20=20=20=20=20=20=20=20=20=20= auto-revert--buffers-by-watch-descriptor)=0A+=20=20=20=20=20=20=20=20= (setq=20auto-revert--polled-buffers=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(delq=20(current-buffer)=20auto-revert--polled-buffers))=0A=20=20=20= =20=20=20=20=20=20(add-hook=20'kill-buffer-hook=20= #'auto-revert-notify-rm-watch=20nil=20t)))))=0A=20=0A=20;;=20If=20we=20= have=20file=20notifications,=20we=20want=20to=20update=20the=20= auto-revert=20buffers=0A@@=20-558,24=20+571,20=20@@=20will=20use=20an=20= up-to-date=20value=20of=20`auto-revert-interval'"=0A=20;;=20often,=20we=20= want=20to=20skip=20some=20revert=20operations=20so=20that=20we=20don't=20= spend=20all=20our=0A=20;;=20time=20reverting=20the=20buffer.=0A=20;;=0A= -;;=20We=20do=20this=20by=20reverting=20immediately=20in=20response=20to=20= the=20first=20in=20a=20flurry=20of=0A-;;=20notifications.=20We=20= suppress=20subsequent=20notifications=20until=20the=20next=20time=0A-;;=20= `auto-revert-buffers'=20is=20called=20(this=20happens=20on=20a=20timer=20= with=20a=20period=20set=20by=0A-;;=20`auto-revert-interval').=0A-(defvar=20= auto-revert-buffers-counter=201=0A-=20=20"Incremented=20each=20time=20= `auto-revert-buffers'=20is=20called")=0A-(defvar-local=20= auto-revert-buffers-counter-lockedout=200=0A-=20=20"Buffer-local=20value=20= to=20indicate=20whether=20we=20should=20immediately=0A-update=20the=20= buffer=20on=20a=20notification=20event=20or=20not.=20If=0A-=0A-=20=20(=3D=20= auto-revert-buffers-counter-lockedout=0A-=20=20=20=20=20= auto-revert-buffers-counter)=0A-=0A-then=20the=20updates=20are=20locked=20= out,=20and=20we=20wait=20until=20the=20next=20call=0A-of=20= `auto-revert-buffers'=20to=20revert=20the=20buffer.=20If=20no=20lockout=20= is=0A-present,=20then=20we=20revert=20immediately=20and=20set=20the=20= lockout,=20so=20that=0A-no=20more=20reverts=20are=20possible=20until=20= the=20next=20call=20of=0A-`auto-revert-buffers'")=0A+;;=20We=20do=20this=20= by=20reverting=20immediately=20in=20response=20to=20the=20first=20in=20a=0A= +;;=20flurry=20of=20notifications.=20Any=20notifications=20during=20the=20= following=0A+;;=20`auto-revert-lockout-interval'=20seconds=20are=20noted=20= but=20not=20acted=20upon=0A+;;=20until=20the=20end=20of=20that=20= interval.=0A+=0A+(defconst=20auto-revert--lockout-interval=202.5=0A+=20=20= "Duration,=20in=20seconds,=20of=20the=20Auto-Revert=20Mode=20= notification=20lockout.=0A+This=20is=20the=20quiescence=20after=20each=20= notification=20of=20a=20file=20being=0A+changed=20during=20which=20no=20= automatic=20reverting=20takes=20place,=20to=0A+prevent=20many=20updates=20= in=20rapid=20succession=20from=20overwhelming=20the=0A+system.")=0A+=0A= +(defvar-local=20auto-revert--lockout-timer=20nil=0A+=20=20"Timer=20= awaiting=20the=20end=20of=20the=20notification=20lockout=20interval,=20= or=20nil.")=0A=20=0A=20(defun=20auto-revert-notify-handler=20(event)=0A=20= =20=20"Handle=20an=20EVENT=20returned=20from=20file=20notification."=0A= @@=20-604,7=20+613,13=20@@=20no=20more=20reverts=20are=20possible=20= until=20the=20next=20call=20of=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(file-name-nondirectory=20= buffer-file-name)))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20;;=20A=20buffer=20w/o=20a=20file,=20like=20dired.=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(null=20= buffer-file-name))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (auto-revert-notify-rm-watch))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(auto-revert-notify-rm-watch)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(when=20(memq=20buffer=20auto-revert-buffer-list)=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(unless=20(memq=20buffer=20= auto-revert--polled-buffers)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(push=20buffer=20auto-revert--polled-buffers))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20Restart=20the=20= timer=20if=20it=20wasn't=20running.=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(unless=20auto-revert-timer=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(auto-revert-set-timer))))))=0A=20=0A= =20=20=20=20=20=20=20=20=20;;=20Loop=20over=20all=20buffers,=20in=20= order=20to=20find=20the=20intended=20one.=0A=20=20=20=20=20=20=20=20=20= (cl-dolist=20(buffer=20buffers)=0A@@=20-630,11=20+645,21=20@@=20no=20= more=20reverts=20are=20possible=20until=20the=20next=20call=20of=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(setq=20= auto-revert-notify-modified-p=20t)=0A=20=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20;;=20Revert=20the=20buffer=20now=20if=20we're=20not=20= locked=20out.=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20= (/=3D=20auto-revert-buffers-counter-lockedout=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffers-counter)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(unless=20auto-revert--lockout-timer=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(auto-revert-handler)=0A-=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(setq=20= auto-revert-buffers-counter-lockedout=0A-=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20= auto-revert-buffers-counter))))))))))=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(setq=20auto-revert--lockout-timer=0A+=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(run-with-timer=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20auto-revert--lockout-interval=20nil=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20#'auto-revert--end-lockout=20= buffer)))))))))))=0A+=0A+(defun=20auto-revert--end-lockout=20(buffer)=0A= +=20=20"End=20the=20lockout=20period=20after=20a=20notification.=0A+If=20= the=20buffer=20needs=20to=20be=20reverted,=20do=20it=20now."=0A+=20=20= (when=20(buffer-live-p=20buffer)=0A+=20=20=20=20(with-current-buffer=20= buffer=0A+=20=20=20=20=20=20(setq=20auto-revert--lockout-timer=20nil)=0A= +=20=20=20=20=20=20(when=20auto-revert-notify-modified-p=0A+=20=20=20=20=20= =20=20=20(auto-revert-handler)))))=0A=20=0A=20(defun=20= auto-revert-active-p=20()=0A=20=20=20"Check=20if=20auto-revert=20is=20= active=20(in=20current=20buffer=20or=20globally)."=0A@@=20-755,13=20= +780,10=20@@=20This=20function=20is=20also=20responsible=20for=20= removing=20buffers=20no=20longer=20in=0A=20Auto-Revert=20Mode=20from=20= `auto-revert-buffer-list',=20and=20for=20canceling=0A=20the=20timer=20= when=20no=20buffers=20need=20to=20be=20checked."=0A=20=0A-=20=20(setq=20= auto-revert-buffers-counter=0A-=20=20=20=20=20=20=20=20(1+=20= auto-revert-buffers-counter))=0A-=0A=20=20=20(save-match-data=0A=20=20=20= =20=20(let=20((bufs=20(if=20global-auto-revert-mode=0A=20=09=09=20=20=20=20= (buffer-list)=0A-=09=09=20=20auto-revert-buffer-list))=0A+=09=09=20=20= auto-revert--polled-buffers))=0A=20=09=20=20remaining=20new)=0A=20=20=20=20= =20=20=20;;=20Buffers=20with=20remote=20contents=20shall=20be=20reverted=20= only=20if=20the=0A=20=20=20=20=20=20=20;;=20connection=20is=20= established=20already.=0A@@=20-811,7=20+833,7=20@@=20the=20timer=20when=20= no=20buffers=20need=20to=20be=20checked."=0A=20=20=20=20=20=20=20(setq=20= auto-revert-remaining-buffers=20bufs)=0A=20=20=20=20=20=20=20;;=20Check=20= if=20we=20should=20cancel=20the=20timer.=0A=20=20=20=20=20=20=20(when=20= (and=20(not=20global-auto-revert-mode)=0A-=09=09=20(null=20= auto-revert-buffer-list))=0A+=09=09=20(null=20= auto-revert--polled-buffers))=0A=20=20=20=20=20=20=20=20=20(if=20(timerp=20= auto-revert-timer)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= (cancel-timer=20auto-revert-timer))=0A=20=09(setq=20auto-revert-timer=20= nil)))))=0A--=20=0A2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_57AAFA11-7B25-4780-B710-1F8E608189CB-- ------------=_1558380002-27854-1--