From unknown Wed Jun 25 09:10:54 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3541: 23.0.94; missing comma in the macro ad-set-orig-definition Reply-To: Dmitri Paduchikh , 3541@debbugs.gnu.org Resent-From: Dmitri Paduchikh Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 12 Jun 2009 06:15:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 3541 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124478704116242 (code B ref -1); Fri, 12 Jun 2009 06:15:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 12 Jun 2009 06:10:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.6 required=4.0 tests=AWL,IMPRONONCABLE_2, MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5C6AYIa016233 for ; Thu, 11 Jun 2009 23:10:36 -0700 Received: from mail.gnu.org ([199.232.76.166]:58465 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MEzyD-0005uz-Tu for emacs-pretest-bug@gnu.org; Fri, 12 Jun 2009 02:10:33 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MEzyC-0006q8-3C for emacs-pretest-bug@gnu.org; Fri, 12 Jun 2009 02:10:33 -0400 Received: from k66.ru ([87.224.128.21]:58107) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MEzyB-0006mI-0c for emacs-pretest-bug@gnu.org; Fri, 12 Jun 2009 02:10:31 -0400 Received: from paduch.telenet.ru (account dpaduch [90.157.67.22] verified) by k66.ru (CommuniGate Pro SMTP 5.1.13) with ESMTPSA id 313380137 for emacs-pretest-bug@gnu.org; Fri, 12 Jun 2009 12:09:56 +0600 From: Dmitri Paduchikh To: emacs-pretest-bug@gnu.org Date: Fri, 12 Jun 2009 12:09:56 +0600 Message-ID: <87my8ehtjf.fsf@paduch.telenet.ru> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: FreeBSD 6.x (1) Here is a patch which adds the missing comma in the macro ad-set-orig-definition. diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el index fa5d57a..27c65ec 100644 --- a/lisp/emacs-lisp/advice.el +++ b/lisp/emacs-lisp/advice.el @@ -2191,7 +2191,7 @@ Redefining advices affect the construction of an advised definition." (defmacro ad-set-orig-definition (function definition) `(ad-safe-fset - (ad-get-advice-info-field function 'origname) ,definition)) + (ad-get-advice-info-field ,function 'origname) ,definition)) (defmacro ad-clear-orig-definition (function) `(fmakunbound (ad-get-advice-info-field ,function 'origname))) From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 19 20:40:54 2010 Received: (at control) by debbugs.gnu.org; 20 Jan 2010 01:40:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXPYz-0007Wd-5s for submit@debbugs.gnu.org; Tue, 19 Jan 2010 20:40:53 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXPYl-0007WW-Uj for control@debbugs.gnu.org; Tue, 19 Jan 2010 20:40:52 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NXPYi-0007Sl-Bs; Tue, 19 Jan 2010 20:40:36 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19286.24340.350706.582414@gargle.gargle.HOWL> Date: Tue, 19 Jan 2010 20:40:36 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: cyan X-Ran: 8WU:4P)DBN*0i&7=5k?sw9O_ List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) close 2951 tags 4206 moreinfo tags 3098 patch tags 2499 patch tags 5297 patch tags 5290 patch tags 1975 patch tags 4470 patch tags 5055 patch tags 3541 patch tags 2527 patch tags 5119 patch tags 2404 patch From unknown Wed Jun 25 09:10:54 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#3541: 23.0.94; missing comma in the macro ad-set-orig-definition References: <87my8ehtjf.fsf@paduch.telenet.ru> In-Reply-To: <87my8ehtjf.fsf@paduch.telenet.ru> Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jan 2010 23:07:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 3541 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch To: Dmitri Paduchikh Cc: 3541@debbugs.gnu.org Received: via spool by 3541-submit@debbugs.gnu.org id=B3541.126428800317659 (code B ref 3541); Sat, 23 Jan 2010 23:07:02 +0000 Received: (at 3541) by debbugs.gnu.org; 23 Jan 2010 23:06:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYp3z-0004am-3J for submit@debbugs.gnu.org; Sat, 23 Jan 2010 18:06:43 -0500 Received: from pantheon-po18.its.yale.edu ([130.132.50.74]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYp3w-0004ah-NM for 3541@debbugs.gnu.org; Sat, 23 Jan 2010 18:06:41 -0500 Received: from furry ([192.54.222.11]) (authenticated bits=0) by pantheon-po18.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0NN6awB004400 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 23 Jan 2010 18:06:36 -0500 Received: by furry (Postfix, from userid 1000) id 4590FC05D; Sat, 23 Jan 2010 16:06:36 -0700 (MST) From: Chong Yidong Date: Sat, 23 Jan 2010 18:06:36 -0500 Message-ID: <87wrz8s9oj.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -3.1 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) > (defmacro ad-set-orig-definition (function definition) > `(ad-safe-fset > - (ad-get-advice-info-field function 'origname) ,definition)) > + (ad-get-advice-info-field ,function 'origname) ,definition)) > > (defmacro ad-clear-orig-definition (function) > `(fmakunbound (ad-get-advice-info-field ,function 'origname))) Sorry for the delayed response. You're right, this is a mistake. I've checked your patch into the repository, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 23 18:06:55 2010 Received: (at control) by debbugs.gnu.org; 23 Jan 2010 23:06:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYp4B-0004ax-AQ for submit@debbugs.gnu.org; Sat, 23 Jan 2010 18:06:55 -0500 Received: from pantheon-po34.its.yale.edu ([130.132.50.80]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYp49-0004as-L6 for control@debbugs.gnu.org; Sat, 23 Jan 2010 18:06:54 -0500 Received: from furry ([192.54.222.11]) (authenticated bits=0) by pantheon-po34.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0NN6nB9025104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sat, 23 Jan 2010 18:06:49 -0500 Received: by furry (Postfix, from userid 1000) id 9D165C05D; Sat, 23 Jan 2010 16:06:49 -0700 (MST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 3541 Date: Sat, 23 Jan 2010 18:06:49 -0500 Message-ID: <87tyucs9o6.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) close 3541 thanks