GNU bug report logs - #3541
23.0.94; missing comma in the macro ad-set-orig-definition

Previous Next

Package: emacs;

Reported by: Dmitri Paduchikh <dpaduch <at> k66.ru>

Date: Fri, 12 Jun 2009 06:15:04 UTC

Severity: normal

Tags: patch

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3541 in the body.
You can then email your comments to 3541 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#3541; Package emacs. (Fri, 12 Jun 2009 06:15:04 GMT) Full text and rfc822 format available.
Acknowledgement sent to Dmitri Paduchikh <dpaduch <at> k66.ru>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Fri, 12 Jun 2009 06:15:06 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dmitri Paduchikh <dpaduch <at> k66.ru>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.94; missing comma in the macro ad-set-orig-definition
Date: Fri, 12 Jun 2009 12:09:56 +0600

Here is a patch which adds the missing comma in the macro
ad-set-orig-definition.

diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el
index fa5d57a..27c65ec 100644
--- a/lisp/emacs-lisp/advice.el
+++ b/lisp/emacs-lisp/advice.el
@@ -2191,7 +2191,7 @@ Redefining advices affect the construction of an advised definition."
 
 (defmacro ad-set-orig-definition (function definition)
   `(ad-safe-fset
-    (ad-get-advice-info-field function 'origname) ,definition))
+    (ad-get-advice-info-field ,function 'origname) ,definition))
 
 (defmacro ad-clear-orig-definition (function)
   `(fmakunbound (ad-get-advice-info-field ,function 'origname)))
Added tag(s) patch. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 20 Jan 2010 01:41:02 GMT) Full text and rfc822 format available.
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#3541; Package emacs. (Sat, 23 Jan 2010 23:07:02 GMT) Full text and rfc822 format available.

Message #10 received at 3541 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Dmitri Paduchikh <dpaduch <at> k66.ru>
Cc: 3541 <at> debbugs.gnu.org
Subject: Re: 23.0.94; missing comma in the macro ad-set-orig-definition
Date: Sat, 23 Jan 2010 18:06:36 -0500

>  (defmacro ad-set-orig-definition (function definition)
>    `(ad-safe-fset
> -    (ad-get-advice-info-field function 'origname) ,definition))
> +    (ad-get-advice-info-field ,function 'origname) ,definition))
>
>  (defmacro ad-clear-orig-definition (function)
>    `(fmakunbound (ad-get-advice-info-field ,function 'origname)))

Sorry for the delayed response.  You're right, this is a mistake.  I've
checked your patch into the repository, thanks.
bug closed, send any further explanations to Dmitri Paduchikh <dpaduch <at> k66.ru> Request was from Chong Yidong <cyd <at> stupidchicken.com> to control <at> debbugs.gnu.org. (Sat, 23 Jan 2010 23:07:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <bug-gnu-emacs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 21 Feb 2010 12:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 15 years and 127 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.