From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 23 19:26:25 2019 Received: (at submit) by debbugs.gnu.org; 23 Apr 2019 23:26:25 +0000 Received: from localhost ([127.0.0.1]:54625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJ4nx-0000zR-1T for submit@debbugs.gnu.org; Tue, 23 Apr 2019 19:26:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJ4nu-0000zD-7x for submit@debbugs.gnu.org; Tue, 23 Apr 2019 19:26:23 -0400 Received: from lists.gnu.org ([209.51.188.17]:43928) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJ4nm-0007j0-2y for submit@debbugs.gnu.org; Tue, 23 Apr 2019 19:26:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJ4nk-0003UY-Un for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 19:26:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: *** X-Spam-Status: No, score=3.3 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RECEIVED_FROM_WINDOWS_HOST,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJ4nj-0007e2-4j for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 19:26:12 -0400 Received: from mail-oln040092003057.outbound.protection.outlook.com ([40.92.3.57]:57251 helo=NAM02-BL2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJ4ng-0007YB-Si for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 19:26:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NCOW4NiiVAMr4pkb00SlXIjDZvoPZHYkNI8FOWJb/h4=; b=uETlxuqtnJ11os43buFWzSvLlURs/9Mgsu1SePoF34RiWwfo54OaLFHhye3VpytZxgG0XaJoEYy1zab4TlZWO20xYMzpIjkKmDBjdt2zhpNTW4oehyNazAMBgTQExTt8HwHd41AXh2b9fP9rF+dww4fuS+LOAhlllG/l6+UPR+gx2fJtGljqTWdOBNml+7fWyzymizvBfI8slSxvZOa/KFJsI01nc/PhKhFBZ2x+t/iKYjrWLQACAkLKBaJNZGHkRjWTmnNmOtutlJTmdYwjZHl0RSWeeKzLZYEALWGFTJF9z7MdGmD+LDoktRbxzLTvipa/Zdoyo9g3LH/Rcd5ulA== Received: from BL2NAM02FT011.eop-nam02.prod.protection.outlook.com (10.152.76.53) by BL2NAM02HT044.eop-nam02.prod.protection.outlook.com (10.152.76.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1771.16; Tue, 23 Apr 2019 23:26:05 +0000 Received: from MWHPR13MB1136.namprd13.prod.outlook.com (10.152.76.54) by BL2NAM02FT011.mail.protection.outlook.com (10.152.77.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1771.16 via Frontend Transport; Tue, 23 Apr 2019 23:26:05 +0000 Received: from MWHPR13MB1136.namprd13.prod.outlook.com ([fe80::64e1:f32d:aa69:c652]) by MWHPR13MB1136.namprd13.prod.outlook.com ([fe80::64e1:f32d:aa69:c652%4]) with mapi id 15.20.1835.010; Tue, 23 Apr 2019 23:26:05 +0000 From: Josh Howard To: "bug-gnu-emacs@gnu.org" Subject: Build error for emacsclient on FreeBSD Thread-Topic: Build error for emacsclient on FreeBSD Thread-Index: AQHU+ivlNAJJYr2HQ0+P1VWzACZCxg== Date: Tue, 23 Apr 2019 23:26:05 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:E56941FF1960766736C33AAC4B2CA64810EBC2B80DE287D8C690EA308D50DA56; UpperCasedChecksum:628B97B520D6636899BCB531DA2BD774B33DED5A58DE6CFCAEF5098C0FFC80D9; SizeAsReceived:6698; Count:41 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [m9j93aGXMV8AR2kW12+1m8V09m8DL4gXtVtWuZYGgl0BX6N5EUrDtpZYkf8MiN6g] x-ms-publictraffictype: Email x-incomingheadercount: 41 x-eopattributedmessage: 0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(5050001)(7020095)(20181119110)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045); SRVR:BL2NAM02HT044; x-ms-traffictypediagnostic: BL2NAM02HT044: x-microsoft-antispam-message-info: PQeIv30HudgRJ9C8aAWlf+mzcGmclust+0jO0cIFeSQnvw04ln19G58e1M7n3wHGHmKNct9V8bOD+gsyztSGu1ifUp3c1ngvhnjFvlBedWL7XTF0YbxMoQuk3846COA+geAGK6PxTb0H82BZ5sCFCgyEpysT+P6qGZOY9idcjNk0h8uVDS90zfKj+IRTLz6O Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 3c91bde2-5e6e-4376-0dc1-08d6c8430ee6 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2019 23:26:05.6334 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2NAM02HT044 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.92.3.57 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) It appears in a recent commit there was a change to emacsclient.c that brea= ks its ability to build on FreeBSD by using the euidaccess() function which= doesn't exist on the platform.=0A= =0A= CCLD emacsclient=0A= emacsclient.c:1475:11: warning: implicit declaration of function 'euidacces= s' is=0A= invalid in C99 [-Wimplicit-function-declaration]=0A= && euidaccess (sockdirname, X_OK) =3D=3D 0)=0A= ^=0A= 1 warning generated.=0A= /usr/bin/ld: error: undefined symbol: euidaccess=0A= >>> referenced by emacsclient.c:1475=0A= >>> /tmp/emacsclient-a0b189.o:(set_local_socket)=0A= cc: error: linker command failed with exit code 1 (use -v to see invocation= )=0A= gmake: *** [Makefile:399: emacsclient] Error 1=0A= =0A= I'd propose it be switched to eaccess() which should be a synonym on Linux = and makes it a bit more portable.=0A= =0A= diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c=0A= index 5871a18ce6..aac1b3c2b4 100644=0A= --- a/lib-src/emacsclient.c=0A= +++ b/lib-src/emacsclient.c=0A= @@ -1472,7 +1472,7 @@ set_local_socket (char const *server_name)=0A= int sockdirnamelen =3D snprintf (sockdirname, sizeof sockdirname,= =0A= "/run/user/%"PRIuMAX, id);=0A= if (0 <=3D sockdirnamelen && sockdirnamelen < sizeof sockdirname= =0A= - && euidaccess (sockdirname, X_OK) =3D=3D 0)=0A= + && eaccess (sockdirname, X_OK) =3D=3D 0)=0A= message=0A= (true,=0A= ("%s: Should XDG_RUNTIME_DIR=3D'%s' be in the environment?\n= "=0A= =0A= From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 12:10:47 2019 Received: (at 35406) by debbugs.gnu.org; 24 Apr 2019 16:10:48 +0000 Received: from localhost ([127.0.0.1]:56301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJKTv-0006JA-La for submit@debbugs.gnu.org; Wed, 24 Apr 2019 12:10:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJKTs-0006Iw-Of for 35406@debbugs.gnu.org; Wed, 24 Apr 2019 12:10:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJKTY-00042Q-Sz; Wed, 24 Apr 2019 12:10:30 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1hJKTJ-0004bw-GE; Wed, 24 Apr 2019 12:10:09 -0400 From: Glenn Morris Subject: Re: bug#35406: Build error for emacsclient on FreeBSD References: to: 35406@debbugs.gnu.org, Paul Eggert X-Spook: War on Terrorism Uzi top secret Disaster assistance emc X-Ran: vn4D{VV$}2BaUG@JTd6(mg#A_A'~Y>\;U"b)1}Dm*Yyo9m:K$o.*tW-W|[JjFArb;d;8m] X-Hue: brightblue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 24 Apr 2019 12:10:08 -0400 In-Reply-To: (Josh Howard's message of "Tue, 23 Apr 2019 23:26:05 +0000") Message-ID: <2wa7gfwfj3.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35406 Cc: Josh Howard X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) cc'ing the author of http://lists.gnu.org/r/emacs-diffs/2019-04/msg00463.html Josh Howard wrote: > It appears in a recent commit there was a change to emacsclient.c that breaks its ability to build on FreeBSD by using the euidaccess() function which doesn't exist on the platform. > > CCLD emacsclient > emacsclient.c:1475:11: warning: implicit declaration of function 'euidaccess' is > invalid in C99 [-Wimplicit-function-declaration] > && euidaccess (sockdirname, X_OK) == 0) > ^ > 1 warning generated. > /usr/bin/ld: error: undefined symbol: euidaccess >>>> referenced by emacsclient.c:1475 >>>> /tmp/emacsclient-a0b189.o:(set_local_socket) > cc: error: linker command failed with exit code 1 (use -v to see invocation) > gmake: *** [Makefile:399: emacsclient] Error 1 > > I'd propose it be switched to eaccess() which should be a synonym on Linux and makes it a bit more portable. > > diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c > index 5871a18ce6..aac1b3c2b4 100644 > --- a/lib-src/emacsclient.c > +++ b/lib-src/emacsclient.c > @@ -1472,7 +1472,7 @@ set_local_socket (char const *server_name) > int sockdirnamelen = snprintf (sockdirname, sizeof sockdirname, > "/run/user/%"PRIuMAX, id); > if (0 <= sockdirnamelen && sockdirnamelen < sizeof sockdirname > - && euidaccess (sockdirname, X_OK) == 0) > + && eaccess (sockdirname, X_OK) == 0) > message > (true, > ("%s: Should XDG_RUNTIME_DIR='%s' be in the environment?\n" From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 20:45:09 2019 Received: (at 35406) by debbugs.gnu.org; 25 Apr 2019 00:45:09 +0000 Received: from localhost ([127.0.0.1]:56882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJSVh-00080R-G5 for submit@debbugs.gnu.org; Wed, 24 Apr 2019 20:45:09 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:37970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJSVf-00080B-BK for 35406@debbugs.gnu.org; Wed, 24 Apr 2019 20:45:08 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B2A6516183D; Wed, 24 Apr 2019 17:45:01 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id XZRHXIMwmeJl; Wed, 24 Apr 2019 17:45:00 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E1D9C161844; Wed, 24 Apr 2019 17:45:00 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 97dqAbXiu8mM; Wed, 24 Apr 2019 17:45:00 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id BAF1216176D; Wed, 24 Apr 2019 17:45:00 -0700 (PDT) Subject: Re: bug#35406: Build error for emacsclient on FreeBSD To: Glenn Morris , 35406@debbugs.gnu.org References: <2wa7gfwfj3.fsf@fencepost.gnu.org> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Wed, 24 Apr 2019 17:45:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <2wa7gfwfj3.fsf@fencepost.gnu.org> Content-Type: multipart/mixed; boundary="------------1C00DD6B0B758A6504FEBC15" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35406 Cc: Josh Howard X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------1C00DD6B0B758A6504FEBC15 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Josh Howard wrote: > I'd propose it be switched to eaccess() which should be a synonym on Linux and makes it a bit more portable. Sorry, I messed up. I should have used the POSIX-specified faccessat, which has a Gnulib portability emulation for platforms lacking faccessat. I installed the attached into master; please give it a try. --------------1C00DD6B0B758A6504FEBC15 Content-Type: text/x-patch; name="euidaccess.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="euidaccess.patch" diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c index 5871a18ce6..fd56007b15 100644 --- a/lib-src/emacsclient.c +++ b/lib-src/emacsclient.c @@ -1472,7 +1472,7 @@ set_local_socket (char const *server_name) int sockdirnamelen = snprintf (sockdirname, sizeof sockdirname, "/run/user/%"PRIuMAX, id); if (0 <= sockdirnamelen && sockdirnamelen < sizeof sockdirname - && euidaccess (sockdirname, X_OK) == 0) + && faccessat (AT_FDCWD, sockdirname, X_OK, AT_EACCESS) == 0) message (true, ("%s: Should XDG_RUNTIME_DIR='%s' be in the environment?\n" --------------1C00DD6B0B758A6504FEBC15-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 23:21:18 2019 Received: (at 35406) by debbugs.gnu.org; 25 Apr 2019 03:21:18 +0000 Received: from localhost ([127.0.0.1]:57078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJUwm-0003J1-M9 for submit@debbugs.gnu.org; Wed, 24 Apr 2019 23:21:16 -0400 Received: from mail-bl2nam06olkn0151.outbound.protection.outlook.com ([104.47.53.151]:14635 helo=NAM06-BL2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJUwk-0003In-PI for 35406@debbugs.gnu.org; Wed, 24 Apr 2019 23:21:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fNTcaOlVtCfQF9lKdmaXW52p6Q7UD/JrCI1RDN2wUX4=; b=pB5AXLEngBHGrQd/CuDyNhewdrlQBI9mobdqEcPhb0M2A2SVaP5tFF8lS3M4IR7SoMHD0PobvQ/na9idf5R/033+8uRF5VSCRg+5qConElYj+EIzqS6lHbom/MpJ6SgHIIL06sLpEMEZozBKVPf1hkqHW82X8BX1N33Ldy3Of1V89kuVT5IFXJVkXJAebN1HTIMd3bv3Iv1Um0SbdnmizLQC3uWHuQLky7fC0hG3QKCwqRO0rdCoYBf1qD4WOSSqoBd7xzyeVvFjditkQ5M6om1JQI3f82282s2hGHFSAH0+LEcTiO7tYzVrseYjEGvU7xMdT4p7zyC2XdUdMvP1xg== Received: from BL2NAM06FT009.Eop-nam06.prod.protection.outlook.com (10.152.106.58) by BL2NAM06HT022.Eop-nam06.prod.protection.outlook.com (10.152.106.255) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1856.4; Thu, 25 Apr 2019 03:21:08 +0000 Received: from MWHPR13MB1136.namprd13.prod.outlook.com (10.152.106.59) by BL2NAM06FT009.mail.protection.outlook.com (10.152.106.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1856.4 via Frontend Transport; Thu, 25 Apr 2019 03:21:08 +0000 Received: from MWHPR13MB1136.namprd13.prod.outlook.com ([fe80::64e1:f32d:aa69:c652]) by MWHPR13MB1136.namprd13.prod.outlook.com ([fe80::64e1:f32d:aa69:c652%4]) with mapi id 15.20.1856.004; Thu, 25 Apr 2019 03:21:08 +0000 From: Josh Howard To: Paul Eggert , Glenn Morris , "35406@debbugs.gnu.org" <35406@debbugs.gnu.org> Subject: Re: bug#35406: Build error for emacsclient on FreeBSD Thread-Topic: bug#35406: Build error for emacsclient on FreeBSD Thread-Index: AQHU+ivlNAJJYr2HQ0+P1VWzACZCxqZLfC8HgACPsgCAACtNEg== Date: Thu, 25 Apr 2019 03:21:08 +0000 Message-ID: References: <2wa7gfwfj3.fsf@fencepost.gnu.org>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:20979F98DA042642566052AF230AE156BA0AF9033D8A09EACF5ECBA8EC76029C; UpperCasedChecksum:A71AEAEAB0C89BBA3948D88F58B69A50CD6AE37893CF45D0B0152CF590F5D5CA; SizeAsReceived:6922; Count:43 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [wL6EcJbNxuIJ46iDWJ3JdjJqn3zS1sMC] x-ms-publictraffictype: Email x-incomingheadercount: 43 x-eopattributedmessage: 0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(5050001)(7020095)(20181119110)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045); SRVR:BL2NAM06HT022; x-ms-traffictypediagnostic: BL2NAM06HT022: x-microsoft-antispam-message-info: Aa4LZW6buO0yYpkCQI4iRhTzJpC5xD4IGrufZfrUIfq1B3EOGOcsFRMPlp5R/n+Zu+mN0KS6zWxCuLWtvfsUG21HE1raQGePk2VnmMC+NB2wYJpijjW1OcCDYh+36cs7Avnv0JbTDrciNfIDSNTU44AYXQ+UFynR3/k9KENi7IPsOLG2+VS287RCYWICp5FU Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 3a58b2c4-7cf4-4ff8-73df-08d6c92d0f5b X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2019 03:21:08.7326 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2NAM06HT022 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35406 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Paul Eggert =0A= > Sent: Wednesday, April 24, 2019 5:45 PM=0A= > To: Glenn Morris; 35406@debbugs.gnu.org=0A= > Cc: Josh Howard=0A= > Subject: Re: bug#35406: Build error for emacsclient on FreeBSD=0A= > =0A= > Sorry, I messed up. I should have used the POSIX-specified faccessat,=0A= > which has a Gnulib portability emulation for platforms lacking=0A= > faccessat. I installed the attached into master; please give it a try.=0A= =0A= Yep, this works fine. Thanks!=0A= =0A= From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 25 18:16:09 2019 Received: (at 35406-done) by debbugs.gnu.org; 25 Apr 2019 22:16:09 +0000 Received: from localhost ([127.0.0.1]:59524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJmf2-0001Er-Mp for submit@debbugs.gnu.org; Thu, 25 Apr 2019 18:16:08 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:33786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJmez-0001E7-CE for 35406-done@debbugs.gnu.org; Thu, 25 Apr 2019 18:16:07 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CE003161836; Thu, 25 Apr 2019 15:15:59 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id kuk9Tt8jR_rR; Thu, 25 Apr 2019 15:15:59 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 23FAE161853; Thu, 25 Apr 2019 15:15:59 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id b7tzhR2ur8tu; Thu, 25 Apr 2019 15:15:59 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 00A0A16171D; Thu, 25 Apr 2019 15:15:58 -0700 (PDT) Subject: Re: bug#35406: Build error for emacsclient on FreeBSD To: Josh Howard , Glenn Morris , 35406-done@debbugs.gnu.org References: <2wa7gfwfj3.fsf@fencepost.gnu.org> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Thu, 25 Apr 2019 15:15:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35406-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 4/24/19 8:21 PM, Josh Howard wrote: > > Yep, this works fine. Thanks! > Thanks for checking; closing the bug report. From unknown Sun Jun 15 08:45:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 24 May 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator