GNU bug report logs - #354
"Added (how many lines, bytes?!) to file.txt"

Previous Next

Full log

View this message in rfc822 format

From: npostavs <at> users.sourceforge.net
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 354 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, kb1vqh <at> gmail.com
Subject: bug#354: "Added (how many lines, bytes?!) to file.txt"
Date: Sun, 02 Apr 2017 15:09:07 -0400

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> On 04/02/2017 11:40 AM, npostavs <at> users.sourceforge.net wrote:
>> I'm not sure what you
>> mean about "idiomatic English" as both versions produce the same text.
>
> The old version says "Added to FOO" whereas the new says "Added N
> characters of `FOO'". The "to" is more idiomatic than the "of".

Oh, huh.  Apparently I didn't actually read the original code.  I must
*really* not like the multi-format string style.  But yes, producing a
correct message is more important.  Here's the fixed code:

  if (!auto_saving && !noninteractive)
    {
      AUTO_STRING (format, NUMBERP (append)
                   ? "Updated %d characters of `%s'"
                   : ! NILP (append)
                   ? "Added %d characters to `%s'"
                   : "Wrote %d characters to `%s'");
      CALLN (Fmessage, format,
             make_number (XINT (end) - XINT (start)),
             visit_file);
    }

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.