GNU bug report logs - #354
"Added (how many lines, bytes?!) to file.txt"

Previous Next

Full log

View this message in rfc822 format

From: npostavs <at> users.sourceforge.net
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 354 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, kb1vqh <at> gmail.com
Subject: bug#354: "Added (how many lines, bytes?!) to file.txt"
Date: Sun, 02 Apr 2017 14:40:06 -0400

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> On 04/01/2017 08:55 PM, npostavs <at> users.sourceforge.net wrote:
>> +           (build_string ("%s %d characters of `%s'"),
>> +            build_string (NUMBERP (append) ? "Updated"
>> +                          : ! NILP (append) ? "Added"
>> +                          : "Wrote"),
>
> This should use AUTO_STRING instead of build_string.

Okay.  (there seems to be a lot of different ways to create a lisp
string object)

> Also, follow the
> old code and use just one string (a format) instead of two, as it's
> more important to use idiomatic English than to save a few bytes in
> the Emacs executable.

I find the code more readable when there is only one format string,
instead of a conditional choosing amongst three.  I'm not sure what you
mean about "idiomatic English" as both versions produce the same text.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.