GNU bug report logs - #35390
26.2; [PATCH] `ls-lisp--dired', like `dired', should accept nil DIR-OR-LIST argument

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 35390 <at> debbugs.gnu.org
Subject: bug#35390: 26.2; [PATCH] `ls-lisp--dired', like `dired', should accept nil DIR-OR-LIST argument
Date: Sun, 23 Jun 2019 19:25:15 +0200

Drew Adams <drew.adams <at> oracle.com> writes:

> The doc of command `dired' does not define the behavior if its DIRNAME
> argument is not a string or a cons.  `dired' just passes this arg to
> `dired-noselect', and `dired-noselect' starts by doing this:
>
>  (or dir-or-list (setq dir-or-list default-directory))
>
> This means that `dired', via `dired-noselect', handles a nil value for
> DIRNAME by using the value of `default-directory' (a string).
>
> `ls-lisp--dired' should do the same - it is a stand-in for `dired'.

Makes sense.

> Currently it raises an error if passed nil as the directory.  It would
> make sense to add this at the beginning of `ls-lisp--dired' (just after
> the `interactive' spec):
>
>  (unless dir-or-list (setq dir-or-list  default-directory))
>
> That's the "patch" - just add that line as indicated.

In the future, could you submit code changes as real patches, with
changelog entries on the normal format?  Thanks.

I've now done this change manually, though.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.