GNU bug report logs - #35385
27.0.50; Make dired-dwim-target aware of other frames

Previous Next

Full log

Message #31 received at 35385 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> linkov.net>, Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 35385 <at> debbugs.gnu.org
Subject: Re: bug#35385: 27.0.50; Make dired-dwim-target aware of other frames
Date: Thu, 19 Sep 2019 10:18:45 +0200

> BTW, while looking at windows walking functions, I noticed
> an opportunity for simplification.
>
> Martin, could you please confirm if I'm not mistaken with this patch:

Removing the

    (when (framep all-frames)
      (select-window (frame-first-window all-frames) 'norecord))

LGTM.  Whether we should remove the

  (save-selected-window

envelope is another question.  If FUN changes the selected window,
we'd now have a side effect we didn't have so far.

Personally, I would always try to use 'walk-window-tree' instead of
'walk-windows' reserving the latter for operations that are allowed to
create or delete windows.

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.