From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 21 17:40:44 2019 Received: (at submit) by debbugs.gnu.org; 21 Apr 2019 21:40:44 +0000 Received: from localhost ([127.0.0.1]:49216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIKCZ-0008Bq-OK for submit@debbugs.gnu.org; Sun, 21 Apr 2019 17:40:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIKCX-0008Bc-Ff for submit@debbugs.gnu.org; Sun, 21 Apr 2019 17:40:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:41074) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hIKCS-0000RT-5f for submit@debbugs.gnu.org; Sun, 21 Apr 2019 17:40:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIKCR-0007NL-4Y for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 17:40:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIKCQ-0000Q6-7N for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 17:40:35 -0400 Received: from che.mayfirst.org ([2001:470:1:116::7]:51020) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hIKCQ-0000Op-0p for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 17:40:34 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1555882831; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=AsUMTptZGOzVGrR21QtxNQQj3Pydkq+SDedQBJLwhrE=; b=PKNvGHp4Q8T6VzkNIyBPRIKVSvNuwAi/cFA0DcsJTfsEUuWEUFqerqag eAlWE+7XI/ka/SP4nvGOxTHso0hBAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1555882831; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=AsUMTptZGOzVGrR21QtxNQQj3Pydkq+SDedQBJLwhrE=; b=i42B3afRV7O7cd0yVb7iZ5njLR0FKfM7//dKw3EDT3fUhHZ5llkt59wX z/xFGppNIS+/N43TaHccBYQ0XwOMdwpdeRxlrSlpMCJab6dcIXKBYcXNB+ PEQ8o/uoGRMmBAahDDA2K59BYQ6xxGDMcjuF7kYHJOOCXX0+LzFjDz060H 7T1DJB8KltOsuMWgCgDFS36hKjflLYEGSNR3gGUJsSZivMw8oAazP4RW1w QFSl5hNg8gGsPlOBITb9S9tK5IIopIMaS5Jqwo+4KFmsxiszKhZrAqgG8l boaEMnI4RezRBNRHF2D336wegCWBuoyc2Y84/4/1+ZBTXaK0Vpc5hA== Received: from fifthhorseman.net (ool-6c3a0662.static.optonline.net [108.58.6.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 271D8F99E; Sun, 21 Apr 2019 17:40:30 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id C91A1200EC; Sun, 21 Apr 2019 15:25:46 -0400 (EDT) From: Daniel Kahn Gillmor To: David Bremner , Notmuch Mail , bug-gnu-emacs@gnu.org Subject: Re: notmuch-emacs: avoiding deprecated message-default-charset In-Reply-To: <874l6re7zh.fsf@tethera.net> References: <87tveswipo.fsf@fifthhorseman.net> <874l6re7zh.fsf@tethera.net> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQUJA8Jn AAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJcQsbzAhkB AAoJEPIGkReQOOXG4fkBAO1joRxqAZY57PjdzGieXLpluk9RkWa3ufkt3YUVEpH/AP9c+pgIxtyW +FwMQRjlqljuj8amdN4zuEqaCy4hhz/1DbgzBFxCv4sWCSsGAQQB2kcPAQEHQERSZxSPmgtdw6nN u7uxY7bzb9TnPrGAOp9kClBLRwGfiPUEGBYIACYWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUCXEK/ iwIbAgUJAeEzgACBCRDyBpEXkDjlxnYgBBkWCAAdFiEEyQ5tNiAKG5IqFQnndhgZZSmuX/gFAlxC v4sACgkQdhgZZSmuX/iVWgD/fCU4ONzgy8w8UCHGmrmIZfDvdhg512NIBfx+Mz9ls5kA/Rq97vz4 z48MFuBdCuu0W/fVqVjnY7LN5n+CQJwGC0MIA7QA/RyY7Sz2gFIOcrns0RpoHr+3WI+won3xCD8+ sVXSHZvCAP98HCjDnw/b0lGuCR7coTXKLIM44/LFWgXAdZjm1wjODbg4BFxCv50SCisGAQQBl1UB BQEBB0BG4iXnHX/fs35NWKMWQTQoRI7oiAUt0wJHFFJbomxXbAMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJcQr+dAhsMBQkB4TOAAAoJEPIGkReQOOXGe/cBAPlek5d9xzcXUn/D kY6jKmxe26CTws3ZkbK6Aa5Ey/qKAP0VuPQSCRxA7RKfcB/XrEphfUFkraL06Xn/xGwJ+D0hCw== Date: Sun, 21 Apr 2019 15:25:46 -0400 Message-ID: <87a7gjw479.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:470:1:116::7 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sun 2019-04-21 11:41:22 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> When i'm building notmuch in a debian environment with emacs >> 1:26.1+1-3.2, i notice the following deprecation warnings: >> >> In notmuch-maildir-setup-message-for-saving: >> emacs/notmuch-maildir-fcc.el:172:31:Warning: =E2=80=98message-default-ch= arset=E2=80=99 is an >> obsolete variable (as of 26.1); The default charset comes from the >> language environment >> >> I'm not enough of an emacs guru to know the right way to avoid this >> warning, but i'm hoping that someonen else can take a stab at it, since >> extraneous warnings make it easier to ignore real problems. > > Good question. I looked at message.el in emacs master and it > > 1) Obsoletes message-default-charset as in 26.1 > 2) Still uses it in exactly the construction we do. interesting, thanks for digging that up. > I'm not sure if it's exactly a reportable bug in emacs, but it is a bit > annoying. seems reportable, if not exactly high-severity. what does upstream expect downstream users of message-default-charset to do? I'm (trying to) forward this to the emacs upstream bugtracker; maybe we can get guidance from them on what to do. > There is a variable byte-compile-not-obsolete-vars that (probably) can > be used to suppress that warning, but it's not clear that's a good > idea (we currently do something similar for Xapian obsolescence warnings > that we can't fix). I would generally try to avoid that kind of a bypass, because i tend to think that warnings are reasonable to look out for and try to fix before they become real problems. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTJDm02IAobkioVCed2GBllKa5f+AUCXLzDugAKCRB2GBllKa5f +CZdAQCw58ZIKNXezBmU+9GBu96YkS2Gc4vbnbB57N8J6iBmTQD/ebxsB6S/Hu8x SLO5jgOeCd6nCMGVub+RC4AFPs0MeAU= =VrsI -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 21 18:05:29 2019 Received: (at 35370) by debbugs.gnu.org; 21 Apr 2019 22:05:29 +0000 Received: from localhost ([127.0.0.1]:49240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIKaX-0000NR-6x for submit@debbugs.gnu.org; Sun, 21 Apr 2019 18:05:29 -0400 Received: from mail-qk1-f179.google.com ([209.85.222.179]:46539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIKaU-0000ND-W2 for 35370@debbugs.gnu.org; Sun, 21 Apr 2019 18:05:27 -0400 Received: by mail-qk1-f179.google.com with SMTP id w73so3333114qkb.13 for <35370@debbugs.gnu.org>; Sun, 21 Apr 2019 15:05:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=cMyIHanZwB6gSqnJw9bmNvRVD/syxw06OMgmbnM+01k=; b=d36q+JEtWxK7pf517F6qDdMW0JWG3qmNDYf61rhNWzZSt0n2m/ZWYpZThIrWXWBmYf U1ec1iZBbVx3f8rXFnhhSqtejiFbjr6jeWmxoRp6P/yXxrx7rujhXG+nfPnsrEN9nUxl dwuITFklqWXi1jVDVjpVq9YRMa1AcpNkCGWGrBJtiX6P80nLJ69j4X03S7c1kQxCOr7E cUr292Q0fLTp0fdPBKb+f0FnQ4D8TMjJcL7ErSP4qSpGqbHU7uAkBRn9ABJMN6vhMDPT vOgiQnuXR1twhc3p3CCdgz+C9dW7MV6bKkl1XBeTfrbUPQ4lJ+nLHls7RsavPshkJRYo 2H9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=cMyIHanZwB6gSqnJw9bmNvRVD/syxw06OMgmbnM+01k=; b=ZxnzexThmTWo4lJzjgNNv7hDjz7MTC8pFrs7J16Tj6o9Y04ZeRPBmnPGzh2Ch5ByhJ Tde9PMkjN3LYZFX2g7m7iTqOiUIIE0t+KEaY17UbSiZGSQVCdpVCW1Ngcjk0WLpqZ2L2 HZqBZty8Jm07tpOkuLnRCTZAGrOMMTa8Ezp2xdGaqK6iAxpDM908znt7jZ/WF5ePU/BY Xu8InGCNsPW6SGRf+KRnAxzDeplQqe5POy7WX3jvhKJjzXrwuVqwXL5iyBLhN1GvGHDV 0AKbXuZ2GdGb3BGBigBi97PDaLrjSRCJ/IE+XvY2vdymyPiWQYlLXz/1pYQIc1Z0yU7p ATug== X-Gm-Message-State: APjAAAWw2ks6QGgXB9B+Vpo/KAF15Rga5rznSihtD39aYXicD7xZOtPV O0CnG+himtc7w61DAsiWAw8HW88o X-Google-Smtp-Source: APXvYqzoZ6QssbIIaiPOSIm5G1ZlvqqbxOQjVrrSCW5XVR4/9kC4JITvfJ6cUuF1GS6mZbg3L8spwQ== X-Received: by 2002:ae9:e107:: with SMTP id g7mr12546255qkm.272.1555884321253; Sun, 21 Apr 2019 15:05:21 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id p46sm7095997qtc.41.2019.04.21.15.05.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 Apr 2019 15:05:20 -0700 (PDT) From: Noam Postavsky To: Daniel Kahn Gillmor Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset References: <87tveswipo.fsf@fifthhorseman.net> <874l6re7zh.fsf@tethera.net> <87a7gjw479.fsf@fifthhorseman.net> Date: Sun, 21 Apr 2019 18:05:19 -0400 In-Reply-To: <87a7gjw479.fsf@fifthhorseman.net> (Daniel Kahn Gillmor's message of "Sun, 21 Apr 2019 15:25:46 -0400") Message-ID: <87sgubrp40.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 35370 Cc: david@tethera.net, notmuch@notmuchmail.org, 35370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) Daniel Kahn Gillmor writes: >>> In notmuch-maildir-setup-message-for-saving: >>> emacs/notmuch-maildir-fcc.el:172:31:Warning: =E2=80=98message-default-c= harset=E2=80=99 is an >>> obsolete variable (as of 26.1); The default charset comes from the >>> language environment >>> >>> I'm not enough of an emacs guru to know the right way to avoid this >>> warning, but i'm hoping that someonen else can take a stab at it, since >>> extraneous warnings make it easier to ignore real problems. >> >> Good question. I looked at message.el in emacs master and it >> >> 1) Obsoletes message-default-charset as in 26.1 >> 2) Still uses it in exactly the construction we do. > > interesting, thanks for digging that up. > >> I'm not sure if it's exactly a reportable bug in emacs, but it is a bit >> annoying. > > seems reportable, if not exactly high-severity. what does upstream > expect downstream users of message-default-charset to do? I'm > (trying to) forward this to the emacs upstream bugtracker; maybe we can > get guidance from them on what to do. The commit which marks this variable as obsolete, has a couple hunks that just remove uses of it. Not clear why other uses were left in. Oversight? [1: 66d9ef95c0]: 2016-02-14 17:07:48 +1100 Remove compat code for older Emacsen https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D66d9ef95c0f9407d= 2a6d26bcd7ed84a303294b53 --- a/lisp/gnus/gnus-int.el +++ b/lisp/gnus/gnus-int.el @@ -777,8 +777,7 @@ (defun gnus-request-accept-article (group &optional gnu= s-command-method last (message-options-set-recipient) (save-restriction (message-narrow-to-head) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (message-encode-message-body))) (let ((gnus-command-method (or gnus-command-method (gnus-find-method-for-group group))) @@ -800,8 +799,7 @@ (defun gnus-request-replace-article (article group buff= er &optional no-encode) (message-options-set-recipient) (save-restriction (message-narrow-to-head) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (message-encode-message-body))) (let* ((func (car (gnus-group-name-to-method group))) (result (funcall (intern (format "%s-request-replace-article" fun= c)) From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 00:11:15 2019 Received: (at 35370) by debbugs.gnu.org; 22 Apr 2019 04:11:15 +0000 Received: from localhost ([127.0.0.1]:49570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIQIU-0003Jd-Uq for submit@debbugs.gnu.org; Mon, 22 Apr 2019 00:11:15 -0400 Received: from che.mayfirst.org ([162.247.75.118]:41669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIQIS-0003JS-FP for 35370@debbugs.gnu.org; Mon, 22 Apr 2019 00:11:12 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1555906271; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=GiDkL7e1dJl0LZz/lF3UsSjIR0HdcNUEUHbvPi3RaCw=; b=RvgerLRFXShMr/eDspWflEslcV+4RgkfJCTV966hIWe9JwsvamizXync sPRUKhdyJsc5F6FHYGJ1GFBpSrEOBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1555906271; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=GiDkL7e1dJl0LZz/lF3UsSjIR0HdcNUEUHbvPi3RaCw=; b=nT7mXa9EczMJk6CrqCFbY8NNUtDlBG28UX1fN00pad27DPc9fvv6/Xr1 ajnwKcyotYH3XAS5uo817AVD5ZWJqCQlR3c5VSEhKvBIa+hXtLezBf58HI OlzkQz129fqEE3lLHf57PAhtvQXT3oym4L9Hh699+ob8K772z1zEiwuvNQ OJyzZrF1yZOQXU9cjEmpJVjlMnf6x8EUGRN+INMMcrjuvWdweKioJ3lEnu gm6w1wPdkk0WqSzK8WmWUlmgbq5acgI/zS4I8G8lKaTvSD8ZAsakSHSiC0 fKiO1ps4IWtedAt1oe/yACgl3hR2lS7koaD5cnWVPukbNweM16ZVhA== Received: from fifthhorseman.net (ool-6c3a0662.static.optonline.net [108.58.6.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id EB96FF99E; Mon, 22 Apr 2019 00:11:08 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 1847A2019E; Sun, 21 Apr 2019 21:55:39 -0400 (EDT) From: Daniel Kahn Gillmor To: Noam Postavsky Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset In-Reply-To: <87sgubrp40.fsf@gmail.com> References: <87tveswipo.fsf@fifthhorseman.net> <874l6re7zh.fsf@tethera.net> <87a7gjw479.fsf@fifthhorseman.net> <87sgubrp40.fsf@gmail.com> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQUJA8Jn AAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJcQsbzAhkB AAoJEPIGkReQOOXG4fkBAO1joRxqAZY57PjdzGieXLpluk9RkWa3ufkt3YUVEpH/AP9c+pgIxtyW +FwMQRjlqljuj8amdN4zuEqaCy4hhz/1DbgzBFxCv4sWCSsGAQQB2kcPAQEHQERSZxSPmgtdw6nN u7uxY7bzb9TnPrGAOp9kClBLRwGfiPUEGBYIACYWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUCXEK/ iwIbAgUJAeEzgACBCRDyBpEXkDjlxnYgBBkWCAAdFiEEyQ5tNiAKG5IqFQnndhgZZSmuX/gFAlxC v4sACgkQdhgZZSmuX/iVWgD/fCU4ONzgy8w8UCHGmrmIZfDvdhg512NIBfx+Mz9ls5kA/Rq97vz4 z48MFuBdCuu0W/fVqVjnY7LN5n+CQJwGC0MIA7QA/RyY7Sz2gFIOcrns0RpoHr+3WI+won3xCD8+ sVXSHZvCAP98HCjDnw/b0lGuCR7coTXKLIM44/LFWgXAdZjm1wjODbg4BFxCv50SCisGAQQBl1UB BQEBB0BG4iXnHX/fs35NWKMWQTQoRI7oiAUt0wJHFFJbomxXbAMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJcQr+dAhsMBQkB4TOAAAoJEPIGkReQOOXGe/cBAPlek5d9xzcXUn/D kY6jKmxe26CTws3ZkbK6Aa5Ey/qKAP0VuPQSCRxA7RKfcB/XrEphfUFkraL06Xn/xGwJ+D0hCw== Date: Sun, 21 Apr 2019 21:55:38 -0400 Message-ID: <874l6qx0px.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35370 Cc: david@tethera.net, notmuch@notmuchmail.org, 35370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On Sun 2019-04-21 18:05:19 -0400, Noam Postavsky wrote: > The commit which marks this variable as obsolete, has a couple hunks > that just remove uses of it. Not clear why other uses were left in. > Oversight? Thanks, Noam! If that's the right thing for emacs itself, that's good to know. Do you have any recommendation for how an external emacs module (which aims to work with at emacs 25 as well at least) should handle this? --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTJDm02IAobkioVCed2GBllKa5f+AUCXL0fGgAKCRB2GBllKa5f +DQHAQDrJq6DffC0Ya7A1hPrxPNNVscEfBPJbbQMMig8GMYqOgEAteaLpYCkdpV2 O8n7Tvq0tQUU/7mBv5/ugbHO2nVpiQ4= =uInn -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 02:33:46 2019 Received: (at 35370) by debbugs.gnu.org; 22 Apr 2019 06:33:46 +0000 Received: from localhost ([127.0.0.1]:49624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hISWP-0000ZY-Q4 for submit@debbugs.gnu.org; Mon, 22 Apr 2019 02:33:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hISWP-0000ZN-2t for 35370@debbugs.gnu.org; Mon, 22 Apr 2019 02:33:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hISWI-00011Z-7N; Mon, 22 Apr 2019 02:33:38 -0400 Received: from [176.228.60.248] (port=1764 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hISWG-0004VD-62; Mon, 22 Apr 2019 02:33:37 -0400 Date: Mon, 22 Apr 2019 09:33:26 +0300 Message-Id: <83k1fm8s7d.fsf@gnu.org> From: Eli Zaretskii To: Daniel Kahn Gillmor In-reply-to: <874l6qx0px.fsf@fifthhorseman.net> (message from Daniel Kahn Gillmor on Sun, 21 Apr 2019 21:55:38 -0400) Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset References: <87tveswipo.fsf@fifthhorseman.net> <874l6re7zh.fsf@tethera.net> <87a7gjw479.fsf@fifthhorseman.net> <87sgubrp40.fsf@gmail.com> <874l6qx0px.fsf@fifthhorseman.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35370 Cc: david@tethera.net, notmuch@notmuchmail.org, npostavs@gmail.com, 35370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Kahn Gillmor > Date: Sun, 21 Apr 2019 21:55:38 -0400 > Cc: david@tethera.net, notmuch@notmuchmail.org, 35370@debbugs.gnu.org > > Do you have any recommendation for how an external emacs module (which > aims to work with at emacs 25 as well at least) should handle this? Just remove any uses of it. Why are you using it now? From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 10:23:20 2019 Received: (at 35370) by debbugs.gnu.org; 22 Apr 2019 14:23:20 +0000 Received: from localhost ([127.0.0.1]:51185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIZqq-0000AR-C2 for submit@debbugs.gnu.org; Mon, 22 Apr 2019 10:23:20 -0400 Received: from che.mayfirst.org ([162.247.75.118]:48241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIZqn-0000AD-JY for 35370@debbugs.gnu.org; Mon, 22 Apr 2019 10:23:19 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1555942996; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=i5u1vR/T3Cgm1FxtSwkk0T0zorO1w6KeoxlVJ1JLRwA=; b=Bsun62X8hGkVKwoja7W2MQEdvwRugKy5ul09fcIMy7VcpnKyQjE5y6zI tDQ738RIVv5etN6Jg2H1nSJKEbTOCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1555942995; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=i5u1vR/T3Cgm1FxtSwkk0T0zorO1w6KeoxlVJ1JLRwA=; b=b+yz17pfi0mi0KvrwFrmzIG0Sfk14j2afCDMAyxeefnFgRFLGWOp1dBL meMHl5atFZ+nkB9AhZ8PdSYv8mlLxdxQWBfqkv66lmNlnTHWAWsPwT1ymm qUDv3Z/NBnAXrBhp4K0zZ0bGjBsBbix0Q+uLfT//7Q52x3myzpzLrSyN3Q ox6JVoLPz4ms5p/K0G5TZXn03HTQkLft9AKwu6yhTnbA3ptN3StmsWRJ8U 0lDZNYCJ7DaSe/cpgPlmJPR3ZywVgHIY9tcHfF8XtnTHYazKyu1O2++8u5 /cK9NTWlijGUnjhT8nPfP7IHkDhgArHWKm1kx0aUE50LC8F79Sdb/Q== Received: from fifthhorseman.net (unknown [38.109.115.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id C827AF99D; Mon, 22 Apr 2019 10:23:14 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 74A21200EC; Mon, 22 Apr 2019 10:21:25 -0400 (EDT) From: Daniel Kahn Gillmor To: Eli Zaretskii Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset In-Reply-To: <83k1fm8s7d.fsf@gnu.org> References: <87tveswipo.fsf@fifthhorseman.net> <874l6re7zh.fsf@tethera.net> <87a7gjw479.fsf@fifthhorseman.net> <87sgubrp40.fsf@gmail.com> <874l6qx0px.fsf@fifthhorseman.net> <83k1fm8s7d.fsf@gnu.org> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQUJA8Jn AAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJcQsbzAhkB AAoJEPIGkReQOOXG4fkBAO1joRxqAZY57PjdzGieXLpluk9RkWa3ufkt3YUVEpH/AP9c+pgIxtyW +FwMQRjlqljuj8amdN4zuEqaCy4hhz/1DbgzBFxCv4sWCSsGAQQB2kcPAQEHQERSZxSPmgtdw6nN u7uxY7bzb9TnPrGAOp9kClBLRwGfiPUEGBYIACYWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUCXEK/ iwIbAgUJAeEzgACBCRDyBpEXkDjlxnYgBBkWCAAdFiEEyQ5tNiAKG5IqFQnndhgZZSmuX/gFAlxC v4sACgkQdhgZZSmuX/iVWgD/fCU4ONzgy8w8UCHGmrmIZfDvdhg512NIBfx+Mz9ls5kA/Rq97vz4 z48MFuBdCuu0W/fVqVjnY7LN5n+CQJwGC0MIA7QA/RyY7Sz2gFIOcrns0RpoHr+3WI+won3xCD8+ sVXSHZvCAP98HCjDnw/b0lGuCR7coTXKLIM44/LFWgXAdZjm1wjODbg4BFxCv50SCisGAQQBl1UB BQEBB0BG4iXnHX/fs35NWKMWQTQoRI7oiAUt0wJHFFJbomxXbAMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJcQr+dAhsMBQkB4TOAAAoJEPIGkReQOOXGe/cBAPlek5d9xzcXUn/D kY6jKmxe26CTws3ZkbK6Aa5Ey/qKAP0VuPQSCRxA7RKfcB/XrEphfUFkraL06Xn/xGwJ+D0hCw== Date: Mon, 22 Apr 2019 10:21:25 -0400 Message-ID: <871s1uw26y.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35370 Cc: david@tethera.net, notmuch@notmuchmail.org, npostavs@gmail.com, 35370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Eli-- Thanks for the prompt followup! On Mon 2019-04-22 09:33:26 +0300, Eli Zaretskii wrote: > [dkg wrote:] >> Do you have any recommendation for how an external emacs module (which >> aims to work with at emacs 25 as well at least) should handle this? > > Just remove any uses of it. Why are you using it now? in notmuch's emacs/notmuch-maildir-fcc.el, as mentioned at the beginning of this thread: https://git.notmuchmail.org/git?p=notmuch;a=blob;f=emacs/notmuch-maildir-fcc.el;h=1551e8b649102ccdfecad9a2ef278949bfb3d702;hb=HEAD#l172 If we remove that entry from the (let) block, what are the implications for users of notmuch who are still using emacs 25? I don't have much knowledge in the way of deep emacs or message-mode internals, so if there's answer that's obvious to you that you think i'm missing, feel free to just point me to it. Thanks! --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTJDm02IAobkioVCed2GBllKa5f+AUCXL3N5QAKCRB2GBllKa5f +LBcAP98MIRokIhFaxxW0PzYCq808T7EAdtL/JZHj/uN40P3DQD8CTOuVL1VVIuv tFK4RYjlAAs+AKw25NH7885UpxB3DAw= =a7tQ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 11:38:11 2019 Received: (at 35370) by debbugs.gnu.org; 22 Apr 2019 15:38:11 +0000 Received: from localhost ([127.0.0.1]:51277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIb1G-0002AV-NZ for submit@debbugs.gnu.org; Mon, 22 Apr 2019 11:38:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIb1E-0002AH-IE for 35370@debbugs.gnu.org; Mon, 22 Apr 2019 11:38:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIb17-0003CB-Im; Mon, 22 Apr 2019 11:38:01 -0400 Received: from [176.228.60.248] (port=3895 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hIb16-0000Ss-Eg; Mon, 22 Apr 2019 11:38:01 -0400 Date: Mon, 22 Apr 2019 18:37:52 +0300 Message-Id: <831s1u6ofj.fsf@gnu.org> From: Eli Zaretskii To: Daniel Kahn Gillmor In-reply-to: <871s1uw26y.fsf@fifthhorseman.net> (message from Daniel Kahn Gillmor on Mon, 22 Apr 2019 10:21:25 -0400) Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset References: <87tveswipo.fsf@fifthhorseman.net> <874l6re7zh.fsf@tethera.net> <87a7gjw479.fsf@fifthhorseman.net> <87sgubrp40.fsf@gmail.com> <874l6qx0px.fsf@fifthhorseman.net> <83k1fm8s7d.fsf@gnu.org> <871s1uw26y.fsf@fifthhorseman.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35370 Cc: david@tethera.net, notmuch@notmuchmail.org, npostavs@gmail.com, 35370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Kahn Gillmor > Cc: npostavs@gmail.com, david@tethera.net, notmuch@notmuchmail.org, 35370@debbugs.gnu.org > Date: Mon, 22 Apr 2019 10:21:25 -0400 > > > Just remove any uses of it. Why are you using it now? > > in notmuch's emacs/notmuch-maildir-fcc.el, as mentioned at the beginning > of this thread: > > https://git.notmuchmail.org/git?p=notmuch;a=blob;f=emacs/notmuch-maildir-fcc.el;h=1551e8b649102ccdfecad9a2ef278949bfb3d702;hb=HEAD#l172 > > If we remove that entry from the (let) block, what are the implications > for users of notmuch who are still using emacs 25? Nothing, I think. But if you don't want to risk problems, you can use it dependent on the Emacs version. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 16:51:33 2019 Received: (at 35370) by debbugs.gnu.org; 22 Apr 2019 20:51:34 +0000 Received: from localhost ([127.0.0.1]:51718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIfuX-00060m-Ju for submit@debbugs.gnu.org; Mon, 22 Apr 2019 16:51:33 -0400 Received: from che.mayfirst.org ([162.247.75.118]:37049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIfuT-00060b-Qp for 35370@debbugs.gnu.org; Mon, 22 Apr 2019 16:51:33 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1555966287; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding : from; bh=4cD7JryOmb71WTihr1wmk9WfpKLbU+qteRBSBl8ML2A=; b=VGp4nf8mqj2gqe35opnX7656r0cbxbNMoWiyK2stPOHR6ccQsBfLWuSq ydy8WDJ8ICqKv1uzTwgXUh8ZVB7YBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1555966287; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding : from; bh=4cD7JryOmb71WTihr1wmk9WfpKLbU+qteRBSBl8ML2A=; b=fRFdRKG8JouJY3VvYaZXGoSaxwngCIciUbmNnuuPOIi8VywX4UwXXuDv BqlS2Kb9M5PTSsuVGeI9w2A3nJlBgloUvRNkA7rbyX2sBw0CyIhARa/kBD 588PT94+6YGnMUqrPqr+L08cZstJctEqRD6siaowCI57axZkDR9IpDLMsN utMkO9w+5xoJmk2pdB27z0sedju8EUIOLoiuz1N7By8h3ZAqkyogIutCtH 78XFcCOY5PvfQuk0bhY7RrFyHaIspUvbahh1azcbIcLZtqMnF0PBOsidun AjObSKlheR+7V8nZXXoUp1kaegTio6MIIH+5UNLymQhSZBmVWvL7Mg== Received: from fifthhorseman.net (unknown [38.109.115.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 625BBF99D; Mon, 22 Apr 2019 16:51:23 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id B89CC20103; Mon, 22 Apr 2019 16:51:16 -0400 (EDT) From: Daniel Kahn Gillmor To: Notmuch Mail Subject: [PATCH] emacs: drop use of message-default-charset Date: Mon, 22 Apr 2019 16:51:16 -0400 Message-Id: <20190422205116.10694-1-dkg@fifthhorseman.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <831s1u6ofj.fsf@gnu.org> References: <831s1u6ofj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35370 Cc: 35370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Apparently, message-default-charset is deprecated, which causes the following warning messages during the build: In notmuch-maildir-setup-message-for-saving: emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an obsolete variable (as of 26.1); The default charset comes from the language environment In discussion with emacs upstream over on https://debbugs.gnu.org/35370, it appears that we can just drop this entirely and things should still work with emacs 25. --- emacs/notmuch-maildir-fcc.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el index 1551e8b6..ae56bacd 100644 --- a/emacs/notmuch-maildir-fcc.el +++ b/emacs/notmuch-maildir-fcc.el @@ -169,8 +169,7 @@ This is taken from the function message-do-fcc." (message-encode-message-body) (save-restriction (message-narrow-to-headers) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (goto-char (point-min)) (when (re-search-forward (concat "^" (regexp-quote mail-header-separator) "$") -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 17:49:01 2019 Received: (at 35370) by debbugs.gnu.org; 22 Apr 2019 21:49:01 +0000 Received: from localhost ([127.0.0.1]:51793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIgo6-0007Ui-JK for submit@debbugs.gnu.org; Mon, 22 Apr 2019 17:48:59 -0400 Received: from guru.guru-group.fi ([46.183.73.34]:25470 ident=[U2FsdGVkX19fqggNvLxXsgtVoSrAvFyIO6c3r59Nm/c=]) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIgPR-0006qW-Oo for 35370@debbugs.gnu.org; Mon, 22 Apr 2019 17:23:30 -0400 Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 5B02110008E; Tue, 23 Apr 2019 00:23:24 +0300 (EEST) From: Tomi Ollila To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH] emacs: drop use of message-default-charset In-Reply-To: <20190422205116.10694-1-dkg@fifthhorseman.net> References: <831s1u6ofj.fsf@gnu.org> <20190422205116.10694-1-dkg@fifthhorseman.net> User-Agent: Notmuch/0.28.3+73~g5e2df9a (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 35370 X-Mailman-Approved-At: Mon, 22 Apr 2019 17:48:58 -0400 Cc: 35370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) On Mon, Apr 22 2019, Daniel Kahn Gillmor wrote: > Apparently, message-default-charset is deprecated, which causes the > following warning messages during the build: > > In notmuch-maildir-setup-message-for-saving: > emacs/notmuch-maildir-fcc.el:172:31:Warning: =E2=80=98message-default-c= harset=E2=80=99 is an > obsolete variable (as of 26.1); The default charset comes from the > language environment > > In discussion with emacs upstream over on > https://debbugs.gnu.org/35370, it appears that we can just drop this > entirely and things should still work with emacs 25. I looked this a bit (well, quite a few minutes, rfc2047.el in emacs 24.3, 25.2 and 26.1), and while it is impossible to gain any real knowledge with such a shallow peek, I'd guess the following might be true: Since `mail-parse-charset` and `message-default-charset` are (were) both `nil` by default, this change does have any effect for users that never customized message-default-charset. If anyone did, now there is small chance that the line: "If nil, you might be asked to input the charset." (from message-default-charset docstring) can happen. In this context the change is IMO even more unlikely. So this change LGTM. Tomi > --- > emacs/notmuch-maildir-fcc.el | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el > index 1551e8b6..ae56bacd 100644 > --- a/emacs/notmuch-maildir-fcc.el > +++ b/emacs/notmuch-maildir-fcc.el > @@ -169,8 +169,7 @@ This is taken from the function message-do-fcc." > (message-encode-message-body) > (save-restriction > (message-narrow-to-headers) > - (let ((mail-parse-charset message-default-charset)) > - (mail-encode-encoded-word-buffer))) > + (mail-encode-encoded-word-buffer)) > (goto-char (point-min)) > (when (re-search-forward > (concat "^" (regexp-quote mail-header-separator) "$") > --=20 > 2.20.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch From debbugs-submit-bounces@debbugs.gnu.org Tue May 07 05:38:43 2019 Received: (at 35370) by debbugs.gnu.org; 7 May 2019 09:38:43 +0000 Received: from localhost ([127.0.0.1]:58214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNwYd-0003qc-10 for submit@debbugs.gnu.org; Tue, 07 May 2019 05:38:43 -0400 Received: from fethera.tethera.net ([198.245.60.197]:36500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNwYa-0003qR-U8 for 35370@debbugs.gnu.org; Tue, 07 May 2019 05:38:41 -0400 Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1hNwYY-0007tD-IS; Tue, 07 May 2019 05:38:38 -0400 Received: (nullmailer pid 14558 invoked by uid 1000); Tue, 07 May 2019 09:38:36 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH] emacs: drop use of message-default-charset In-Reply-To: <20190422205116.10694-1-dkg@fifthhorseman.net> References: <831s1u6ofj.fsf@gnu.org> <20190422205116.10694-1-dkg@fifthhorseman.net> Date: Tue, 07 May 2019 06:38:36 -0300 Message-ID: <87pnoufvtv.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35370 Cc: 35370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Daniel Kahn Gillmor writes: > Apparently, message-default-charset is deprecated, which causes the > following warning messages during the build: > > In notmuch-maildir-setup-message-for-saving: > emacs/notmuch-maildir-fcc.el:172:31:Warning: =E2=80=98message-default-c= harset=E2=80=99 is an > obsolete variable (as of 26.1); The default charset comes from the > language environment > > In discussion with emacs upstream over on > https://debbugs.gnu.org/35370, it appears that we can just drop this > entirely and things should still work with emacs 25. pushed d From debbugs-submit-bounces@debbugs.gnu.org Tue May 07 08:27:26 2019 Received: (at 35370) by debbugs.gnu.org; 7 May 2019 12:27:26 +0000 Received: from localhost ([127.0.0.1]:58306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNzBt-0001qe-UN for submit@debbugs.gnu.org; Tue, 07 May 2019 08:27:26 -0400 Received: from mail-it1-f178.google.com ([209.85.166.178]:40626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNzBs-0001qQ-43 for 35370@debbugs.gnu.org; Tue, 07 May 2019 08:27:24 -0400 Received: by mail-it1-f178.google.com with SMTP id g71so10325671ita.5 for <35370@debbugs.gnu.org>; Tue, 07 May 2019 05:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hR7NK55JZ96YmhjgPDCzv5jo13FeDf1Bk1Q1da2sCJY=; b=Ttcv+UmRO9JWEcpu4sEVDYoq4RaJDkDBKUxBG/TJiF59BkwfIaNEddBC/rDngGVfhZ FUMlIUXGue+uNOuRR56Xsj01OeEACgR92q1KPDlqiusx8wk22ledVRTQ5M5Q6aCnJAMk FUn99TJ+UojFdThMr62MplYmuCg1HMEtG/fF1iwugAutuKaDU8j51NSVLhf9t3VXyCPz go3DYZvzUR9Gokxq0V17xJtJG/zV5N6XUsY/cDJ6A55Y8EO6lOeefgqx0ZSC+MABcBzQ hLUDg+2xX4B/fgC9WiOUrDUMW4lqDAXcxF56+sBk55qQdfpoYwNOLMbwwSn4n1l+i2lk lCKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hR7NK55JZ96YmhjgPDCzv5jo13FeDf1Bk1Q1da2sCJY=; b=kBEuAEU51/5U9MFvVJf7gRd++/gasex51UyoM5qm6fNpl1GZl+3m/1/4xwWgNJ3/WR MoWAdLgJs/IdkzSGqVj53BldXGJNADrB+i0MC/Xo0idbF7YkOazyZZR4r4hiihNV+l34 p1Q0G6Fhkg5LAUkJXkCjc1uBuzp3GheVTjE0Wasp4GcKZSGh2q1ftfbBWKHpeGBvPbO/ je13n0l8TPmawP5nG1EwDKEFZjKnniknGCK3dQl6AeOvrT2ylMCq7scjofsY6kdPQ46r sBZyaynx/7RH9Dh0/UjTm1+WHGQ04c9iitfY4smgk8JnNCLoil0c8dj7CUCLJevikxzn rfvg== X-Gm-Message-State: APjAAAUDKP5QzEhxqYn5Dsy7jc0Ps/5jvGrlR2DEgRGRT6q4xaxAJNZ/ YlSDOx3xdrPH0c0oh/0xylaniE4i X-Google-Smtp-Source: APXvYqy7N8Iw+zT+H4Yu3TA2bHR3ydTX41MxVVIFswwKl3PnhM/xfP7A8FxlhoN5WjPsIGWM7Por3g== X-Received: by 2002:a24:2758:: with SMTP id g85mr9160093ita.30.1557232037999; Tue, 07 May 2019 05:27:17 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id c11sm418598itj.31.2019.05.07.05.27.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 May 2019 05:27:16 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset References: <87tveswipo.fsf@fifthhorseman.net> <874l6re7zh.fsf@tethera.net> <87a7gjw479.fsf@fifthhorseman.net> <87sgubrp40.fsf@gmail.com> <874l6qx0px.fsf@fifthhorseman.net> <83k1fm8s7d.fsf@gnu.org> Date: Tue, 07 May 2019 08:26:59 -0400 In-Reply-To: <83k1fm8s7d.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 22 Apr 2019 09:33:26 +0300") Message-ID: <87d0kulab0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35370 Cc: david@tethera.net, notmuch@notmuchmail.org, Daniel Kahn Gillmor , 35370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Daniel Kahn Gillmor >> Date: Sun, 21 Apr 2019 21:55:38 -0400 >> Cc: david@tethera.net, notmuch@notmuchmail.org, 35370@debbugs.gnu.org >> >> Do you have any recommendation for how an external emacs module (which >> aims to work with at emacs 25 as well at least) should handle this? > > Just remove any uses of it. Why are you using it now? Should we remove the remaining uses of it from Emacs too? --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=0001-Stop-using-message-default-charset-Bug-35370.patch Content-Description: patch >From a3dca9511e1639ccfdf06bced16af5babb5078de Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Tue, 7 May 2019 08:18:49 -0400 Subject: [PATCH] Stop using message-default-charset (Bug#35370) In 2016-02-14 "Remove compat code for older Emacsen", message-default-charset was obsoleted, and a couple of uses were removed, but others were left behind. * lisp/gnus/message.el (message-send-mail) (message-send-news, message-do-fcc) (message-encode-message-body): * lisp/gnus/mml.el (mml-to-mime): Stop using message-default-charset. --- lisp/gnus/message.el | 13 ++++--------- lisp/gnus/mml.el | 4 +--- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index c8b6f0ee68..2c2122d89a 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -4588,8 +4588,7 @@ (defun message-send-mail (&optional _) (message-generate-headers '(Lines))) ;; Remove some headers. (message-remove-header message-ignored-mail-headers t) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (goto-char (point-max)) ;; require one newline at the end. (or (= (preceding-char) ?\n) @@ -4962,8 +4961,7 @@ (defun message-send-news (&optional arg) (message-generate-headers '(Lines))) ;; Remove some headers. (message-remove-header message-ignored-news-headers t) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (goto-char (point-max)) ;; require one newline at the end. (or (= (preceding-char) ?\n) @@ -5441,8 +5439,7 @@ (defun message-do-fcc () (while (setq file (message-fetch-field "fcc" t)) (push file list) (message-remove-header "fcc" nil t)) - (let ((mail-parse-charset message-default-charset) - (rfc2047-header-encoding-alist + (let ((rfc2047-header-encoding-alist (cons '("Newsgroups" . default) rfc2047-header-encoding-alist))) (mail-encode-encoded-word-buffer))) @@ -8101,9 +8098,7 @@ (defun message-clone-locals (buffer &optional varstr) (defun message-encode-message-body () (unless message-inhibit-body-encoding - (let ((mail-parse-charset (or mail-parse-charset - message-default-charset)) - (case-fold-search t) + (let ((case-fold-search t) lines content-type-p) (message-goto-body) (save-restriction diff --git a/lisp/gnus/mml.el b/lisp/gnus/mml.el index f6d358dfc0..7a99a0dc46 100644 --- a/lisp/gnus/mml.el +++ b/lisp/gnus/mml.el @@ -48,7 +48,6 @@ (autoload 'message-mail-p "message") (defvar gnus-article-mime-handles) (defvar gnus-newsrc-hashtb) -(defvar message-default-charset) (defvar message-deletable-headers) (defvar message-options) (defvar message-posting-charset) @@ -1015,8 +1014,7 @@ (defun mml-to-mime () ;; Skip past any From_ headers. (while (looking-at "From ") (forward-line 1)) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (message-encode-message-body)) (defun mml-insert-mime (handle &optional no-markup) -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 07 10:37:04 2019 Received: (at 35370) by debbugs.gnu.org; 7 May 2019 14:37:04 +0000 Received: from localhost ([127.0.0.1]:59304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hO1DL-00015B-KK for submit@debbugs.gnu.org; Tue, 07 May 2019 10:37:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hO1DH-00014e-6f for 35370@debbugs.gnu.org; Tue, 07 May 2019 10:37:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO1DA-0006tw-HB; Tue, 07 May 2019 10:36:52 -0400 Received: from [176.228.60.248] (port=4625 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hO1D9-00024R-NT; Tue, 07 May 2019 10:36:52 -0400 Date: Tue, 07 May 2019 17:36:37 +0300 Message-Id: <8336lqjpqi.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky , Lars Ingebrigtsen In-reply-to: <87d0kulab0.fsf@gmail.com> (message from Noam Postavsky on Tue, 07 May 2019 08:26:59 -0400) Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset References: <87tveswipo.fsf@fifthhorseman.net> <874l6re7zh.fsf@tethera.net> <87a7gjw479.fsf@fifthhorseman.net> <87sgubrp40.fsf@gmail.com> <874l6qx0px.fsf@fifthhorseman.net> <83k1fm8s7d.fsf@gnu.org> <87d0kulab0.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35370 Cc: david@tethera.net, notmuch@notmuchmail.org, dkg@fifthhorseman.net, 35370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Noam Postavsky > Cc: Daniel Kahn Gillmor , david@tethera.net, notmuch@notmuchmail.org, 35370@debbugs.gnu.org > Date: Tue, 07 May 2019 08:26:59 -0400 > > > Just remove any uses of it. Why are you using it now? > > Should we remove the remaining uses of it from Emacs too? I think so, but I'd be happier if someone from the Gnus folks could eyeball this patch. Lars, any comments/objections? From debbugs-submit-bounces@debbugs.gnu.org Thu May 09 14:33:25 2019 Received: (at 35370) by debbugs.gnu.org; 9 May 2019 18:33:25 +0000 Received: from localhost ([127.0.0.1]:36418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOnrB-000428-7N for submit@debbugs.gnu.org; Thu, 09 May 2019 14:33:25 -0400 Received: from quimby.gnus.org ([80.91.231.51]:32788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOnr9-000420-OQ for 35370@debbugs.gnu.org; Thu, 09 May 2019 14:33:24 -0400 Received: from broadband14.b.subnet.rcn.com ([206.71.230.141] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hOnr3-0007V5-FG; Thu, 09 May 2019 20:33:20 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset References: <87tveswipo.fsf@fifthhorseman.net> <874l6re7zh.fsf@tethera.net> <87a7gjw479.fsf@fifthhorseman.net> <87sgubrp40.fsf@gmail.com> <874l6qx0px.fsf@fifthhorseman.net> <83k1fm8s7d.fsf@gnu.org> <87d0kulab0.fsf@gmail.com> <8336lqjpqi.fsf@gnu.org> Date: Thu, 09 May 2019 14:33:15 -0400 In-Reply-To: <8336lqjpqi.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 07 May 2019 17:36:37 +0300") Message-ID: <87r2974gwk.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I think so, but I'd be happier if someone from the Gnus folks could > eyeball this patch. > > Lars, any comments/objections? I think the patch looks OK -- it'll change the behaviour if you have set enable-multibyte-characters to nil, but... does anybody do that? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35370 Cc: david@tethera.net, notmuch@notmuchmail.org, Noam Postavsky , dkg@fifthhorseman.net, 35370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I think so, but I'd be happier if someone from the Gnus folks could > eyeball this patch. > > Lars, any comments/objections? I think the patch looks OK -- it'll change the behaviour if you have set enable-multibyte-characters to nil, but... does anybody do that? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 01:32:50 2019 Received: (at 35370) by debbugs.gnu.org; 10 May 2019 05:32:51 +0000 Received: from localhost ([127.0.0.1]:36912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOy9G-0005Dq-LX for submit@debbugs.gnu.org; Fri, 10 May 2019 01:32:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOy9E-0005Db-AT for 35370@debbugs.gnu.org; Fri, 10 May 2019 01:32:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOy97-0002uL-Qv; Fri, 10 May 2019 01:32:37 -0400 Received: from [176.228.60.248] (port=3833 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hOy97-0004RI-1J; Fri, 10 May 2019 01:32:37 -0400 Date: Fri, 10 May 2019 08:32:30 +0300 Message-Id: <83y33eg9ht.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87r2974gwk.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Thu, 09 May 2019 14:33:15 -0400) Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset References: <87tveswipo.fsf@fifthhorseman.net> <874l6re7zh.fsf@tethera.net> <87a7gjw479.fsf@fifthhorseman.net> <87sgubrp40.fsf@gmail.com> <874l6qx0px.fsf@fifthhorseman.net> <83k1fm8s7d.fsf@gnu.org> <87d0kulab0.fsf@gmail.com> <8336lqjpqi.fsf@gnu.org> <87r2974gwk.fsf@mouse.gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35370 Cc: david@tethera.net, notmuch@notmuchmail.org, npostavs@gmail.com, dkg@fifthhorseman.net, 35370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Noam Postavsky , david@tethera.net, notmuch@notmuchmail.org, dkg@fifthhorseman.net, 35370@debbugs.gnu.org > Date: Thu, 09 May 2019 14:33:15 -0400 > > Eli Zaretskii writes: > > > I think so, but I'd be happier if someone from the Gnus folks could > > eyeball this patch. > > > > Lars, any comments/objections? > > I think the patch looks OK -- it'll change the behaviour if you have > set enable-multibyte-characters to nil, but... does anybody do that? If they do, it's their funeral. Noam, please go ahead, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 06:45:49 2019 Received: (at 35370) by debbugs.gnu.org; 10 May 2019 10:45:49 +0000 Received: from localhost ([127.0.0.1]:37297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP32D-0007AY-2a for submit@debbugs.gnu.org; Fri, 10 May 2019 06:45:49 -0400 Received: from mail-io1-f49.google.com ([209.85.166.49]:39428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP32A-00072i-Sn; Fri, 10 May 2019 06:45:47 -0400 Received: by mail-io1-f49.google.com with SMTP id m7so4122063ioa.6; Fri, 10 May 2019 03:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RMSkG9XT8V9ydZ6BHDtlEKJqcK+tNGuBVLXc+Gdng7U=; b=TjLyRompR+Py4J6rfIAUcp+TPgqPMoYIWJcxf0XzbLAl6WY9WO0H05iBY9jHsSotw4 M+TFqQqouLgU6Ky9+TOFt7h9MIvZ2P+cd1o22Sk5jtcmG39zMHxg+Xwwjrm9OxQFdqrc V9dZsxy7SyBhfehlrIvefMfqRUSH5Fd7GwyBeFqrRiPt68wOtvGT5Z+aa08QNa9xyD7Q wnuoPIdcNjzlH1uXxlURnVeUnZwyYMnhqQq9OLtNXJoTLP6oxFGepkAB3OP8si6RUn1a fE7MLwCuluLNj5n8am3RDRaXnyGQyrhpmqb0c3VQ8b17U+UxKguPBmsaFvS774CK3eWZ e4Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=RMSkG9XT8V9ydZ6BHDtlEKJqcK+tNGuBVLXc+Gdng7U=; b=ZkoMOiYqE8aUQHhqaUTDMstqI5rpjWyVd7F1rafvGSA+d29ZS1a3WYw5FHbrbwAldu XkI3QSay8NyGXAru0z0mGu2K1mvH2n44KxAWJoWboeHtP+hbBfHydn3um6BmQyw13xfA 5h0tO/wyGeqbEK9S9ZphV9ILmfL34++RdOZJHx3ch4DdNW8kbV/hSrki0NppnHTia2pU JnFcF2ITuLkVIIcpCTa6zWdU+pHqVo3jfqp/MiO54nvq7+WOQt7gn3Hup9gmibraATDC utVYh9ASJfyyS4cWCs9cgXkZLfcFoGnhqhS4Wi46Aj7f4w8jtbme1rGBU5Ql0KBlgLGU hqVA== X-Gm-Message-State: APjAAAW7YuAPZ25Y4g+V4AnxqaEwb0MGefpmm1GD4rjc4dhZwMb8RCw5 KeKnp+LNhOcZPpN+JKao28e/RWmV X-Google-Smtp-Source: APXvYqwePswOiTwKO+iB1u+VbuoMa0cz28jCC7NyZHuBAQBfGCvFuJ/wn50Ja5XAk7hNqXzTPRjQuw== X-Received: by 2002:a6b:7006:: with SMTP id l6mr428159ioc.161.1557485140972; Fri, 10 May 2019 03:45:40 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id g13sm1843746iom.46.2019.05.10.03.45.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 May 2019 03:45:40 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset References: <87tveswipo.fsf@fifthhorseman.net> <874l6re7zh.fsf@tethera.net> <87a7gjw479.fsf@fifthhorseman.net> <87sgubrp40.fsf@gmail.com> <874l6qx0px.fsf@fifthhorseman.net> <83k1fm8s7d.fsf@gnu.org> <87d0kulab0.fsf@gmail.com> <8336lqjpqi.fsf@gnu.org> <87r2974gwk.fsf@mouse.gnus.org> <83y33eg9ht.fsf@gnu.org> Date: Fri, 10 May 2019 06:45:39 -0400 In-Reply-To: <83y33eg9ht.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 May 2019 08:32:30 +0300") Message-ID: <874l62k2p8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35370 Cc: david@tethera.net, Lars Ingebrigtsen , notmuch@notmuchmail.org, dkg@fifthhorseman.net, 35370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 35370 quit Eli Zaretskii writes: >> From: Lars Ingebrigtsen >> I think the patch looks OK -- it'll change the behaviour if you have >> set enable-multibyte-characters to nil, but... does anybody do that? > > If they do, it's their funeral. > > Noam, please go ahead, and thanks. Done. 510aa7505f 2019-05-10T06:41:59-04:00 "Stop using message-default-charset (Bug#35370)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=510aa7505fc14e0ebc6a0d220160397f068c5c04 From unknown Sun Sep 07 01:05:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 07 Jun 2019 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator