GNU bug report logs - #35368
[PATCH] Do potentially destructive operations in prepare-commit-msg

Previous Next

Full log

View this message in rfc822 format

From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
To: npostavs <at> gmail.com
Cc: 35368 <at> debbugs.gnu.org
Subject: bug#35368: [PATCH v3] Do potentially destructive operations in prepare-commit-msg
Date: Thu, 16 May 2019 00:28:58 +0300

В Ср, мая 15, 2019 at 13:40, npostavs <at> gmail.com написал:
> Konstantin Kharlamov <Hi-Angel <at> yandex.ru> writes:
> 
>>  * build-aux/git-hooks/prepare-commit-msg: if someone occasionally 
>> puts
>>  Signed-off line, it will likely get there through -s option of git.
>>  Exploit this fact to abort before a user got a chance to type commit
>>  message.
> 
> Thanks, looks good, but I think it would be helpful to explain that 
> this
> is about catching git commit -s ... in the comments of the file too.
> 
>>  --- a/autogen.sh
>>  +++ b/autogen.sh
>>  @@ -1,4 +1,4 @@
>>  -#!/bin/sh
>>  + #!/bin/sh
> 
> This is a typo or something, right?

Oh, right, sorry about that. It wasn't supposed to get into the commit. 
I was testing the hook by adding this space, and apparently it leaked 
through to my local commit.

Thanks for your comments, I resent a v4 with a comment added, and the 
stray space removed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.