GNU bug report logs - #35368
[PATCH] Do potentially destructive operations in prepare-commit-msg

Previous Next

Full log

View this message in rfc822 format

From: npostavs <at> gmail.com
To: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
Cc: 35368 <at> debbugs.gnu.org
Subject: bug#35368: [PATCH v3] Do potentially destructive operations in prepare-commit-msg
Date: Wed, 15 May 2019 13:40:36 -0400

Konstantin Kharlamov <Hi-Angel <at> yandex.ru> writes:

> * build-aux/git-hooks/prepare-commit-msg: if someone occasionally puts
> Signed-off line, it will likely get there through -s option of git.
> Exploit this fact to abort before a user got a chance to type commit
> message.

Thanks, looks good, but I think it would be helpful to explain that this
is about catching git commit -s ... in the comments of the file too.

> --- a/autogen.sh
> +++ b/autogen.sh
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> + #!/bin/sh

This is a typo or something, right?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.