GNU bug report logs - #35353
26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 35353 <at> debbugs.gnu.org
Subject: bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name
Date: Sat, 22 Aug 2020 16:41:18 +0200

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> The fix is not hard, though. Is the variable more targeted on other
> use cases? Or is it just obscure enough for us not to bother?
>
> The patch looks like this (to be accompanied with an appropriate renaming):

[...]

> -    (define-key map [mouse-1] #'xref-goto-xref)
> -    (define-key map [mouse-2] #'xref--mouse-2)
> +    (define-key map [follow-link] 'mouse-face)
> +    (define-key map [mouse-2] #'xref-goto-xref)
> +    (define-key map [mouse-1] #'xref--mouse-2)

I think that this is basically what most modes that have clickable stuff
do, so I think it might be the right solution for xref, too (even if
xref doesn't have buttons per se).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.