Subject: bug#35345: closed (Re: [bug#35345] [PATCH 2/2] gnu: tlp: Add required x86-energy-perf-policy input dependency.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 27 May 2019 14:44:02 +0000

Your bug report

#35345: [PATCH 0/2] Add missing run-time dependency for TLP (Power management tool for Linux).

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
35345: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35345
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#35345] [PATCH 2/2] gnu: tlp: Add required x86-energy-perf-policy input dependency.
From: Ludovic Courtès <[email-masked]>
To: Stefan Stefanović <[email-masked]>
Cc: [email-masked]
Date: Mon, 27 May 2019 16:43:24 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Stefan Stefanović <[email-masked]> skribis:

> From a7264289ba328478a1dab1978fe080a5b4f392c2 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Stefan=20Stefanovi=C4=87?= <[email-masked]>
> Date: Sat, 20 Apr 2019 16:13:37 +0200
> Subject: [PATCH 2/2] gnu: tlp: Add required x86-energy-perf-policy input
>  dependency.
>
> * gnu/packages/linux.scm (tlp)
> [inputs]: Add system specific x86-energy-perf-policy dependency.
> [arguments]<#:phases>['wrap]:
> Adjust bin-directory procedure to return #f on missing input,
> a guard against system specific input dependencies.
> Filter only strings in the path list. Reformat for-each block.
> Add x86-energy-perf-policy in bin-directory input-name list.

I reworded it to use ‘filter-map’ intead of (filter string? …).

> +              ,@(if (member (or (%current-target-system) (%current-system))
> +                            (package-supported-systems x86-energy-perf-policy))

This would not work, because ‘%current-target-system’ returns a
“triplet”, not a “system type”, so I’ve also rephrased it.

Let me know if something’s broken!

Thanks,
Ludo’.

Subject: [PATCH 0/2] Add missing run-time dependency for TLP (Power management tool for Linux).
From: Stefan Stefanović <[email-masked]>
To: guix-patches <[email-masked]>
Date: Sat, 20 Apr 2019 16:26:31 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello.

The first patch will add system (arch-kernel) specific
x86-energy-perf-policy package,
and the second patch will adjust TLP package to use
x86-energy-perf-policy as a optional/system-specific run-time
dependency.

To understand my motivation please take a look at:
- https://linrunner.de/en/tlp/docs/tlp-configuration.html#scaling
the section explaining ENERGY_PERF_POLICY_ON_AC parameter has the
following note:
"Important: this setting requires the kernel module msr and the tool
x86_energy_perf_policy matching your kernel version."