GNU bug report logs - #35318
[PATCH] Update cargo-build-system to expand package inputs

Previous Next

Package: guix-patches;

Reported by: Ivan Petkov <ivanppetkov <at> gmail.com>

Date: Fri, 19 Apr 2019 05:35:02 UTC

Severity: normal

Tags: patch

Done: Chris Marusich <cmmarusich <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #47 received at 35318 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Petkov <ivanppetkov <at> gmail.com>
To: Chris Marusich <cmmarusich <at> gmail.com>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 35318 <at> debbugs.gnu.org
Subject: Re: [bug#35318] [PATCH] Update cargo-build-system to expand package
 inputs
Date: Sun, 9 Jun 2019 16:53:48 -0700
[Message part 1 (text/plain, inline)]
I’ve updated the patch series with the following improvements:

* I've applied any naming feedback which came from Ludo
* I've changed the cargo-build-system to only unpack inputs into the cargo
vendor directory if the following applies:
  - The input is a path to a gzip tarball
  - The archive contains a file called Cargo.toml at its root
  - This means that we no longer require crate sources to include a
  ".crate" extension

Whew, given that this has gotten pretty long, I'd be happy to land this as it
is for now (barring any blocking issues!), and iterating further going forward!

Thanks again to everyone for their feedback!
—Ivan

[0001-build-system-cargo-expand-transitive-crate-sources.patch (application/octet-stream, attachment)]
[0002-build-system-cargo-use-sources-from-package-sources.patch (application/octet-stream, attachment)]
[0003-build-system-cargo-don-t-copy-source-as-an-output.patch (application/octet-stream, attachment)]
[0004-doc-Update-cargo-build-system-parameter-docs.patch (application/octet-stream, attachment)]
[0005-import-crate-define-dependencies-as-arguments.patch (application/octet-stream, attachment)]
[0006-gnu-crate-add-unicode-xid.patch (application/octet-stream, attachment)]
[0007-gnu-crate-Add-proc-macro2-and-quote.patch (application/octet-stream, attachment)]

This bug report was last modified 5 years and 340 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.