GNU bug report logs - #35312
core-update: Handle jar-files with patches

Previous Next

To reply to this bug, email your comments to 35312 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: <guix-patches <at> gnu.org>
Subject: core-update: Handle jar-files with patches
Date: Thu, 18 Apr 2019 07:06:21 +0200

[Message part 1 (text/plain, inline)]

Please review carefully, this is my first work below the gexp-border.

This patch is the outcome of my question at:

https://lists.gnu.org/archive/html/guix-devel/2019-04/msg00226.html

When a jar-file had patches, it was not recognized and wrongly handled
with "tar xz".

There is one open question: For patch-and-repack, the flags defaults
to '("p1"), but for jar-files we would usually need a "p0". That would
mean for jar-sources with patches, one would need to manually add the
patch-flags with "p0" to the origin. This is not nice. On the other
hand, I would not like to override the patch-flags for jar-files to
always "p0".

WDYT?

Björn

[0001-guix-Handle-patching-of-jar-files-correctly.patch (text/x-patch, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: guix-patches <at> gnu.org
Subject: Re: [bug#35312] core-update: Handle jar-files with patches
Date: Thu, 27 Jun 2019 16:15:50 +0200

On 2019-04-18 07:06, Björn Höfling wrote:
> Please review carefully, this is my first work below the gexp-border.
> 
> This patch is the outcome of my question at:
> 
> https://lists.gnu.org/archive/html/guix-devel/2019-04/msg00226.html
> 
> When a jar-file had patches, it was not recognized and wrongly handled
> with "tar xz".
> 
> There is one open question: For patch-and-repack, the flags defaults
> to '("p1"), but for jar-files we would usually need a "p0". That would
> mean for jar-sources with patches, one would need to manually add the
> patch-flags with "p0" to the origin. This is not nice. On the other
> hand, I would not like to override the patch-flags for jar-files to
> always "p0".
> 
> WDYT?
> 
> Björn
> 
This seem to have fallen through the cracks. Can someone with gexp 
knowledge review this?

-- 
Cheers Swedebugia

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.