GNU bug report logs - #35305
[WIP] LightDM service

Previous Next

Full log

Message #50 received at 35305 <at> debbugs.gnu.org (full text, mbox):

From: L  p R n  d n    <guix <at> lprndn.info>
To: 35305 <at> debbugs.gnu.org
Subject: Re: [bug#35305] LightDM service
Date: Wed, 22 Apr 2020 17:26:04 +0200

[Message part 1 (text/plain, inline)]

Hello,

Here is the new set of patches with quite a few modifications for the
service, everything rebased on 1.1.0.
After a discussion with bricewge on irc, a new design has been adopted
allowing use of multiple seats.
To use the service, you can instantiate a lightdm-service-type, a
lightdm-gtk-greeter-service-type or both. The service should always find
a way to start a working instance of LightDM. :) 
A non exhaustive list of changes that might need further review:

* lightdm-gtk-greeter has its own service extending lightdm-service and
  others.
  
* Seats configuration use now the lightdm-seat-record-type and can be
  defined both in the lightdm-service and lightdm-gtk-greeter-service.
  The greeter now extends the LightDM's service by providing a list of
  seats.

* The `compose` and `extend` field of the lightdm-service-type have seen
  work for this purpose while keeping compatibility with
  `set-xorg-configuration`.

* extra-config fields are list of strings to avoid weird indentation in
  the user's config.

* Fixed customization of lightdm-gtk-greeter's cursor.

* Added some fields to deal with accessibility for
  lightdm-gtk-greeter-configuration.

* Takes default background from guix-artwork.

Also a review of PAM services might be nice as I'm not versed in security.

However, I didn't get rid of etc-service-type's extension as LightDM's
seems to ignore `sessions-directory` when configuration is passed
through `--config`. Patches to fix that are welcome but can wait a
future patch submission, I think.

Otherwise, tested in a WM: default configurations, autologin, sway,
changing greeter appearance and everything worked fine. For passwordless
login, had to actually delete user's password manually to make it work.
I don't know if it's expected.

Have a nice day and good review :)


L  p R n  d n

[0001-gnu-lightdm-Update-1.30.0.patch (text/x-patch, attachment)]

[0002-gnu-lightdm-Add-vala-bindings.patch (text/x-patch, attachment)]

[0003-gnu-lightdm-Disable-python-tests-only.patch (text/x-patch, attachment)]

[0004-gnu-lightdm-gtk-greeter-Fix-at-spi-runtime-dependenc.patch (text/x-patch, attachment)]

[0005-gnu-lightdm-gtk-greeter-Fix-.desktop-file.patch (text/x-patch, attachment)]

[0006-gnu-lightdm-gtk-greeter-Wrap-binary.patch (text/x-patch, attachment)]

[0007-gnu-lightdm-Build-accountsservice-files.patch (text/x-patch, attachment)]

[0008-gnu-lightdm-gtk-greeter-Fix-some-warnings.patch (text/x-patch, attachment)]

[0009-services-Add-lightdm-service-type.patch (text/x-patch, attachment)]

[0010-gnu-lightdm-gtk-greeter-Set-XCURSOR_PATH-in-wrapper.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.