GNU bug report logs - #35281
[PATCH] gnu: docker: Add a couple go dependencies and enable docker-proxy.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35281 in the body.
You can then email your comments to 35281 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: docker: Add a couple go dependencies and enable
 docker-proxy.
Date: Sun, 14 Apr 2019 19:02:53 -0400

[Message part 1 (text/plain, inline)]

Hello Guix!

Before this change, attempting to start a docker registry such as with
the following command[0]:

--8<---------------cut here---------------start------------->8---
docker run -d -p 5000:5000 --restart=always --name registry registry:2
--8<---------------cut here---------------end--------------->8---

Would give the following error:

--8<---------------cut here---------------start------------->8---
/gnu/store/dzaijl53fcd3jhkpd70vsf4cnvv10ywj-docker-cli-18.09.3/bin/docker:
Error response from daemon: driver failed programming external
connectivity on endpoint registry
(709754084a9e208c32075e47ea9584296a6f274deeef08283d0de9c9a5161112):
exec: "docker-proxy": executable file not found in $PATH.
--8<---------------cut here---------------end--------------->8---

This series of patches adds docker-libnetwork-cmd-proxy and a few new go
packages it required.

The docker service is modified to enable (or disable) using a 'docker-proxy'.

Thanks!

Maxim

[0001-gnu-Add-go-sctp.patch (text/x-patch, attachment)]

[0002-gnu-Add-go-netns.patch (text/x-patch, attachment)]

[0003-gnu-Add-go-netlink.patch (text/x-patch, attachment)]

[0004-gnu-Add-docker-libnetwork.patch (text/x-patch, attachment)]

[0005-gnu-Add-docker-libnetwork-cmd-proxy.patch (text/x-patch, attachment)]

[0006-services-docker-Add-new-fields-to-support-proxy.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #12 received at 35281 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 35281 <at> debbugs.gnu.org
Subject: Re: [bug#35281] [PATCH] gnu: docker: Add a couple go dependencies
 and enable docker-proxy.
Date: Mon, 15 Apr 2019 08:22:26 +0200

[Message part 1 (text/plain, inline)]

Hi,

On Sun, 14 Apr 2019 19:02:53 -0400
Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:

> +         ;; The tests fail with the error:
> +         ;; src/github.com/docker/libnetwork/network.go:1057: Warnf format %q
> +         ;; has arg n.configOnly of wrong type bool.
> +         #:tests? #f))
> +      (home-page "https://github.com/docker/libnetwork/")

It might make sense to report that bug upstream--they're helpful people.

Otherwise LGTM!

[Message part 2 (application/pgp-signature, inline)]

Message #15 received at 35281 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 35281 <at> debbugs.gnu.org
Subject: Re: [bug#35281] [PATCH] gnu: docker: Add a couple go dependencies and
 enable docker-proxy.
Date: Mon, 15 Apr 2019 18:14:25 -0400

Hi Danny!

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> Hi,
>
> On Sun, 14 Apr 2019 19:02:53 -0400
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
>> +         ;; The tests fail with the error:
>> +         ;; src/github.com/docker/libnetwork/network.go:1057: Warnf format %q
>> +         ;; has arg n.configOnly of wrong type bool.
>> +         #:tests? #f))
>> +      (home-page "https://github.com/docker/libnetwork/")
>
> It might make sense to report that bug upstream--they're helpful people.
>
> Otherwise LGTM!

Thanks for bringing my attention to that part; I've tried re-enabling
the tests but it seems to fail because of unmet dependencies now --
which makes sense since I'm not adding any inputs.  I've removed the
tests? #f argument and detailed in the top comment that this is simply
used as a template and doesn't even build.

Thanks for the review!

Maxim

Message #20 received at 35281-done <at> debbugs.gnu.org (full text, mbox):

From: T460s laptop <maxim.cournoyer <at> gmail.com>
To: 35281-done <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: Re: [bug#35281] [PATCH] gnu: docker: Add a couple go dependencies and
 enable docker-proxy.
Date: Sun, 05 May 2019 20:26:49 -0400

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hi Danny!
>
> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
>
>> Hi,
>>
>> On Sun, 14 Apr 2019 19:02:53 -0400
>> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>>
>>> +         ;; The tests fail with the error:
>>> +         ;; src/github.com/docker/libnetwork/network.go:1057: Warnf format %q
>>> +         ;; has arg n.configOnly of wrong type bool.
>>> +         #:tests? #f))
>>> +      (home-page "https://github.com/docker/libnetwork/")
>>
>> It might make sense to report that bug upstream--they're helpful people.
>>
>> Otherwise LGTM!
>
> Thanks for bringing my attention to that part; I've tried re-enabling
> the tests but it seems to fail because of unmet dependencies now --
> which makes sense since I'm not adding any inputs.  I've removed the
> tests? #f argument and detailed in the top comment that this is simply
> used as a template and doesn't even build.
>
> Thanks for the review!
>
> Maxim

Pushed as 7a31d93a61. Thanks!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.