Subject: Re: [bug#35278] Add emacs-ace-jump-mode

From: Ludovic Courtès <[email-masked]>
Date: Mon, 15 Apr 2019 18:05:36 +0200

Hi Tim,

Tim Gesthuizen <[email-masked]> skribis:

> I packaged emacs-ace-jump-mode, a small package for navigation in
> Emacs. It would be nice if we could add to Guix. However: The licensing
> notice in the source file is copied out of Emacs. I don't know whether
> that is ok.

I think it’s OK.

> From 3ee0e4071e8063f6404f8e7c43f175a80f652112 Mon Sep 17 00:00:00 2001
> From: Tim Gesthuizen <[email-masked]>
> Date: Sat, 13 Apr 2019 13:46:05 +0200
> Subject: [PATCH] gnu: Add emacs-ace-jump-mode
>
> * gnu/packages/emacs-xyz.scm (emacs-ace-jump-mode): New variable.

I made the adjustments below to satisfy ‘guix lint’ and to fix a couple
of wording issues in the description and committed.

Thanks!

Ludo’.

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2c0106efbf..9d69938683 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -727,20 +727,21 @@ index is considered the key).")
     (name "emacs-ace-jump-mode")
     (version "2.0")
     (home-page "https://github.com/winterTTr/ace-jump-mode")
-    (source
-     (origin
-       (method git-fetch)
-       (uri (git-reference
-	     (url (string-append
-		   home-page ".git"))
-	     (commit (string-append "v" version))))
-       (sha256 (base32 "1bwvzh056ls2v7y26a0s4j5mj582dmds04lx4x6iqihs04ss74bb"))))
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url home-page)
+                    (commit (string-append "v" version))))
+              (sha256
+               (base32
+                "1bwvzh056ls2v7y26a0s4j5mj582dmds04lx4x6iqihs04ss74bb"))
+              (file-name (git-file-name name version))))
     (build-system emacs-build-system)
     (synopsis "Cursor location minor mode for fast navigation")
-    (description "ace-jump-mode is a fast/direct cursor location minor
-mode. It will create the N-Branch search tree internal and marks all
-the possible position with predefined keys in within the whole emacs
-view.  Allowing you to move to the character/word/line almost
+    (description "Ace-jump-mode is a fast/direct cursor location minor
+mode.  It creates an N-Branch search tree internally and marks all
+the possible position with predefined keys in within the whole Emacs
+view.  This allows you to move to the character, word, or line almost
 directly.")
     (license license:gpl3+)))