From unknown Sun Aug 17 22:01:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35277 <35277@debbugs.gnu.org> To: bug#35277 <35277@debbugs.gnu.org> Subject: Status: 26.1.90; Non-assigned variable used in condition Reply-To: bug#35277 <35277@debbugs.gnu.org> Date: Mon, 18 Aug 2025 05:01:35 +0000 retitle 35277 26.1.90; Non-assigned variable used in condition reassign 35277 emacs submitter 35277 =C3=93scar Fuentes severity 35277 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 13:22:06 2019 Received: (at submit) by debbugs.gnu.org; 14 Apr 2019 17:22:06 +0000 Received: from localhost ([127.0.0.1]:33109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFipS-0005xf-2R for submit@debbugs.gnu.org; Sun, 14 Apr 2019 13:22:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56943) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFipQ-0005xB-CK for submit@debbugs.gnu.org; Sun, 14 Apr 2019 13:22:04 -0400 Received: from lists.gnu.org ([209.51.188.17]:37070) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hFipL-0007NP-8H for submit@debbugs.gnu.org; Sun, 14 Apr 2019 13:21:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFipK-00029E-2d for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2019 13:21:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFipJ-0007Lq-5G for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2019 13:21:58 -0400 Received: from relayout04-redir.e.movistar.es ([86.109.101.204]:33723) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hFipH-0007Ap-Bh for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2019 13:21:57 -0400 Received: from sky (81.red-79-151-7.dynamicip.rima-tde.net [79.151.7.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 981711563@telefonica.net) by relayout04.e.movistar.es (Postfix) with ESMTPSA id 44hz2M6ZhRz10WN for ; Sun, 14 Apr 2019 19:21:47 +0200 (CEST) From: =?utf-8?Q?=C3=93scar_Fuentes?= To: bug-gnu-emacs@gnu.org Subject: 26.1.90; Non-assigned variable used in condition Date: Sun, 14 Apr 2019 19:21:46 +0200 Message-ID: <875zrgv6xh.fsf@telefonica.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-TnetOut-Country: IP: 79.151.7.81 | Country: ES X-TnetOut-Information: AntiSPAM and AntiVIRUS on relayout04 X-TnetOut-MsgID: 44hz2M6ZhRz10WN.A139E X-TnetOut-SpamCheck: no es spam, Unknown X-TnetOut-From: ofv@wanadoo.es X-TnetOut-Watermark: 1555867308.62112@GViDyLerdFbt+AdzJlidVw X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 86.109.101.204 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) ../../emacs/src/widget.c: In function =E2=80=98EmacsFrameQueryGeometry=E2= =80=99: ../../emacs/src/widget.c:457:29: warning: =E2=80=98ok_height=E2=80=99 may b= e used uninitialized in this function [-Wmaybe-uninitialized] if ((mask & CWHeight) && (ok_height !=3D request->height)) ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../emacs/src/widget.c:455:18: warning: =E2=80=98ok_width=E2=80=99 may be= used uninitialized in this function [-Wmaybe-uninitialized] result->width =3D ok_width; ~~~~~~~~~~~~~~^~~~~~~~~~ I checked that the warnings are legit. With (setq frame-resize-pixelwise t) ok_width is used in the `if'. Not ok_height, at least on my experiments, but removing the warning would be nice. Note that the warning for `ok_width' points to the assignment, but it is used right before on the `if'. In GNU Emacs 26.1.90 (build 2, x86_64-pc-linux-gnu, X toolkit) of 2019-03-16 built on sky Repository revision: df7ed10e4f15d3ea8b4426f7721bafe60bf8deeb Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: Debian GNU/Linux buster/sid Recent messages: Saving file /home/oscar/elisp/emacs.el... Wrote /home/oscar/elisp/emacs.el Auto-saving...done Saving file /home/oscar/dev/emacs/emacs/src/widget.c... Wrote /home/oscar/dev/emacs/emacs/src/widget.c Saving file /home/oscar/dev/emacs/emacs/src/widget.c... Wrote /home/oscar/dev/emacs/emacs/src/widget.c [C-t] show common commands, [?] describe events, [C-h i] show manual Saving file /home/oscar/elisp/emacs.el... Wrote /home/oscar/elisp/emacs.el Quit Configured using: 'configure --without-toolkit-scroll-bars --with-x-toolkit=3Dlucid --with-modules' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG SOUND GSETTINGS GLIB NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB LUCID X11 XDBE XIM MODULES THREADS Important settings: value of $LANG: C locale-coding-system: nil From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 15 23:58:13 2019 Received: (at 35277-done) by debbugs.gnu.org; 16 Apr 2019 03:58:14 +0000 Received: from localhost ([127.0.0.1]:36115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGFEb-0006Gn-KW for submit@debbugs.gnu.org; Mon, 15 Apr 2019 23:58:13 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGFEa-0006GX-4I for 35277-done@debbugs.gnu.org; Mon, 15 Apr 2019 23:58:12 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D331E1616ED; Mon, 15 Apr 2019 20:58:05 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id DfxVH3wK2VvK; Mon, 15 Apr 2019 20:58:05 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0853216174E; Mon, 15 Apr 2019 20:58:05 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LNxaC2COowQ4; Mon, 15 Apr 2019 20:58:04 -0700 (PDT) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id BF1EB1616DA; Mon, 15 Apr 2019 20:58:04 -0700 (PDT) To: =?UTF-8?Q?=c3=93scar_Fuentes?= From: Paul Eggert Subject: 26.1.90; Non-assigned variable used in condition Organization: UCLA Computer Science Department Message-ID: <156ca2d6-22c1-993c-4210-fc797096ddc2@cs.ucla.edu> Date: Mon, 15 Apr 2019 20:58:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------CE7C89789C8491497B2A1B5C" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35277-done Cc: 35277-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------CE7C89789C8491497B2A1B5C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for reporting that. I installed the attached patch into Emacs master. --------------CE7C89789C8491497B2A1B5C Content-Type: text/x-patch; name="0001-Fix-uninit-var-in-widget.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-uninit-var-in-widget.c.patch" >From debaa72dd89eee0dffc930a7ccff742ca5a81d88 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 15 Apr 2019 20:53:13 -0700 Subject: [PATCH] Fix uninit var in widget.c * src/widget.c (EmacsFrameQueryGeometry): Avoid use of uninitialized variables ok_width, ok_height (Bug#35277). --- src/widget.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/widget.c b/src/widget.c index 508974dd46..e662dd3ecd 100644 --- a/src/widget.c +++ b/src/widget.c @@ -434,21 +434,20 @@ EmacsFrameResize (Widget widget) } static XtGeometryResult -EmacsFrameQueryGeometry (Widget widget, XtWidgetGeometry *request, XtWidgetGeometry *result) +EmacsFrameQueryGeometry (Widget widget, XtWidgetGeometry *request, + XtWidgetGeometry *result) { - EmacsFrame ew = (EmacsFrame) widget; - int mask = request->request_mode; - Dimension ok_width, ok_height; - if (mask & (CWWidth | CWHeight)) + if (mask & (CWWidth | CWHeight) && !frame_resize_pixelwise) { - if (!frame_resize_pixelwise) - round_size_to_char (ew, - (mask & CWWidth) ? request->width : ew->core.width, - ((mask & CWHeight) ? request->height - : ew->core.height), - &ok_width, &ok_height); + EmacsFrame ew = (EmacsFrame) widget; + Dimension ok_width, ok_height; + + round_size_to_char (ew, + mask & CWWidth ? request->width : ew->core.width, + mask & CWHeight ? request->height : ew->core.height, + &ok_width, &ok_height); if ((mask & CWWidth) && (ok_width != request->width)) { result->request_mode |= CWWidth; -- 2.17.1 --------------CE7C89789C8491497B2A1B5C-- From unknown Sun Aug 17 22:01:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 14 May 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator