From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 11:37:24 2019 Received: (at submit) by debbugs.gnu.org; 14 Apr 2019 15:37:24 +0000 Received: from localhost ([127.0.0.1]:33017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFhC8-0001E0-2z for submit@debbugs.gnu.org; Sun, 14 Apr 2019 11:37:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFhC4-0001Dm-12 for submit@debbugs.gnu.org; Sun, 14 Apr 2019 11:37:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:42611) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hFhBy-0007bw-Qz for submit@debbugs.gnu.org; Sun, 14 Apr 2019 11:37:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFhBx-0006rP-Ut for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2019 11:37:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFhBx-0007bY-5r for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2019 11:37:13 -0400 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]:42014) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hFhBw-0007bJ-R2 for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2019 11:37:13 -0400 Received: by mail-pf1-x42e.google.com with SMTP id w25so7358154pfi.9 for ; Sun, 14 Apr 2019 08:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=Lh+7qBFalayE28ZGNKxUFIo1q1eu9BsEY2w2tHdXdCk=; b=go8jntFXMEXZfsoopT+jRm2m1/819kleBj5Aoy82V1hR5/EVhSFAfoec2++5XLjUGl YbCwqO3FAdril3+y4fZERiaVlJJlZkJiVlzImdfXgOcImCBGPYixqxv4hCBamOxqYKVj 1vngr/qlFycbQsqrT1POPm7y5uc5ugoIgI9asD9xdn2+XAIGiOCICMPH6kYmaX793nal RUBzqATFEOXMH1ts9LsW0SuvX+4NZG/4tKdp1sxRRxvxFWsBAS24OkK0YaxZXtuZm8FM JTdlNJTWRMmumJnvQZVptdsdYlQOZ9Tn1bI/x1kM1x2D2IHH05Xl08fBSmYf0MVWAFSB B18w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=Lh+7qBFalayE28ZGNKxUFIo1q1eu9BsEY2w2tHdXdCk=; b=Hs4CdpWfQ9H3jtvwNMWr3fCfAn/+xG7qceSj5CtKFtjS1bF6ozJ2CB7xy9KRmAuQfO 7Zp7ahAL993qE09ghirfwYdGGyWXWOnefPCjorzbQb2gKSqPXACRdfQicWo5Jo13lyjv 3bUmr3kKhKchYKlZ9pfoBRq91x15vqco3/rQEM+IkOZ4Q/ifq0STxxZNzUCiEaTtg0nk rrsqg5+IxOq/IwyYQvxcG7ZGIdgBhxiYss3SJ0bFJDMFBrasjDEcK1v+Q63SCtnM4B1i E8I8/CwURKmF/3bCTDNLk1CIraQAld5DXZQFgI2/JsA/etN2LH2L8xYVUNLbccioLJlD vXDQ== X-Gm-Message-State: APjAAAXOjXf1Gq/Q6yAQLh5FwZ6gCT6HZDLTr15650VburCeMuUtStFl sfG+pVCNBk+L6ZoZiWn7hkzCYPV7 X-Google-Smtp-Source: APXvYqzurIu7GRCJMmUirRQYBsBXQ/ROsigWA9SNcP4BPhRxLuwEh/dTUQ+HdbokVHsnUZ564YcD9Q== X-Received: by 2002:a63:195f:: with SMTP id 31mr65493459pgz.116.1555256230520; Sun, 14 Apr 2019 08:37:10 -0700 (PDT) Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id j20sm34064648pfn.84.2019.04.14.08.37.08 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Apr 2019 08:37:09 -0700 (PDT) From: Alex Gramiak To: bug-gnu-emacs@gnu.org Subject: [PATCH] * lisp/frame.el (frame--size-history): Fix infloop. Date: Sun, 14 Apr 2019 09:37:10 -0600 Message-ID: <87bm18vbrt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::42e X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain frame-size-history can be nil, which resulted in an infloop. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-frame.el-frame-size-history-Fix-infloop.patch Content-Description: infloop >From 5695525ed1477e908536d159da670f0f1ab4a369 Mon Sep 17 00:00:00 2001 From: Alexander Gramiak Date: Sun, 14 Apr 2019 09:27:50 -0600 Subject: [PATCH] * lisp/frame.el (frame--size-history): Fix infloop. --- lisp/frame.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/frame.el b/lisp/frame.el index b5c936a51e..6f9e769e16 100644 --- a/lisp/frame.el +++ b/lisp/frame.el @@ -1610,7 +1610,7 @@ frame--size-history (with-current-buffer (get-buffer-create "*frame-size-history*") (erase-buffer) (insert (format "Frame size history of %s\n" frame)) - (while (listp (setq entry (pop history))) + (while (consp (setq entry (pop history))) (when (eq (car entry) frame) (pop entry) (insert (format "%s" (pop entry))) -- 2.21.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 12:05:01 2019 Received: (at 35272) by debbugs.gnu.org; 14 Apr 2019 16:05:01 +0000 Received: from localhost ([127.0.0.1]:33059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFhcq-0001va-Qh for submit@debbugs.gnu.org; Sun, 14 Apr 2019 12:05:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFhco-0001vO-Vv for 35272@debbugs.gnu.org; Sun, 14 Apr 2019 12:04:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFhch-0000ZM-9U; Sun, 14 Apr 2019 12:04:51 -0400 Received: from [176.228.60.248] (port=3603 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hFhce-0006xw-Tb; Sun, 14 Apr 2019 12:04:49 -0400 Date: Sun, 14 Apr 2019 19:04:38 +0300 Message-Id: <83zhosine1.fsf@gnu.org> From: Eli Zaretskii To: Alex Gramiak In-reply-to: <87bm18vbrt.fsf@gmail.com> (message from Alex Gramiak on Sun, 14 Apr 2019 09:37:10 -0600) Subject: Re: bug#35272: [PATCH] * lisp/frame.el (frame--size-history): Fix infloop. References: <87bm18vbrt.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35272 Cc: 35272@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Alex Gramiak > Date: Sun, 14 Apr 2019 09:37:10 -0600 > > frame-size-history can be nil, which resulted in an infloop. > > >From 5695525ed1477e908536d159da670f0f1ab4a369 Mon Sep 17 00:00:00 2001 > From: Alexander Gramiak > Date: Sun, 14 Apr 2019 09:27:50 -0600 > Subject: [PATCH] * lisp/frame.el (frame--size-history): Fix infloop. > > --- > lisp/frame.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/frame.el b/lisp/frame.el > index b5c936a51e..6f9e769e16 100644 > --- a/lisp/frame.el > +++ b/lisp/frame.el > @@ -1610,7 +1610,7 @@ frame--size-history > (with-current-buffer (get-buffer-create "*frame-size-history*") > (erase-buffer) > (insert (format "Frame size history of %s\n" frame)) > - (while (listp (setq entry (pop history))) > + (while (consp (setq entry (pop history))) > (when (eq (car entry) frame) > (pop entry) > (insert (format "%s" (pop entry))) Thanks. But wouldn't it be better to special-case the nil value, and display something to that effect, instead of just nothing after the header? P.S. Regardless, please be sure to mention the bug number when you push, as it is not in the patch you sent. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 12:25:50 2019 Received: (at 35272) by debbugs.gnu.org; 14 Apr 2019 16:25:50 +0000 Received: from localhost ([127.0.0.1]:33066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFhwz-0002Qh-Mb for submit@debbugs.gnu.org; Sun, 14 Apr 2019 12:25:49 -0400 Received: from mail-pf1-f170.google.com ([209.85.210.170]:37231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFhwy-0002QV-5C for 35272@debbugs.gnu.org; Sun, 14 Apr 2019 12:25:48 -0400 Received: by mail-pf1-f170.google.com with SMTP id 8so7406418pfr.4 for <35272@debbugs.gnu.org>; Sun, 14 Apr 2019 09:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PXZTrvJuyaicS1Mg4tPtnty0p6rxZUy+miynvunmTwI=; b=M/wjGxtUqxQ6vR2tlCgKWWc3kD6JIy3YM2igq44cLgKbRzB7cK716y+ZAd9nN0Nxyh Ya5LpxHBcyC8vEgq+7bBNez5oJc2xMTq9yAzKk3cHto+CjmT+DX4V+lBsMmhRhCwcTvQ MXqrZJKP5Dbj4ZxqLIpV/D10UispwLa9jnqeDuxkKxmHv02wNdz9P9bzk1rFHPhpRoZu tpDpJt/cDIb1liHy93Ibw2Lcq5h0X9Lm4dOroPfH5RQdV7S1y0xsKrrohC+8a2/WIjz/ h8nPhV6/iMqrIwOZjSGUT2NC+8AXp7Xc99QcIkDIa5YJr4XrqNT4+6CDsNb6k94gquvI fQsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=PXZTrvJuyaicS1Mg4tPtnty0p6rxZUy+miynvunmTwI=; b=N+IfiKy3khAs43FzfahYZwnvfj0Iz+FLTI4hkntMAnjPE4NqTW+hPfA8R1vTZsoW8W sU/4aNCzGPzbB+e9fH9TRr/BDA1j6ON2mpKmbqIMHx5nEBv0F6rzWk104RGbKPt7iAkz z97R/RsZII+DgyGQ/KfAiO+zoWwn1FKS6DdF1XKZhoAXzMYafSm8dL/z1cRqX1tdpqAa SbXIH+RPKEim71eCL3kcbysC1adVFe1sXlZzmesvyBoyVHdylJE0fuCqmFCIWhPJYq03 H2ktTIlfyc371FJaKnKdSKqFN3jt5U4zg88rxhEI9poVPzWrSkdVL3+VSPs/jdaomGaC vo4Q== X-Gm-Message-State: APjAAAU5RhMUh1FwLs7L7L9hs+Ct+5ujHsaNwK+VkrdqLPpjGGnW6Q3E 98RqYJq5mNVOSsS0uvylXLchDzl2 X-Google-Smtp-Source: APXvYqywABrE3L9h4p9TzX6cV4Y7PUYYd0l9lCs2/iC4iMR5Skx6urCzxtETCxyJvvBvJhObHItGaw== X-Received: by 2002:a62:1881:: with SMTP id 123mr69875626pfy.25.1555259141940; Sun, 14 Apr 2019 09:25:41 -0700 (PDT) Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id f6sm46895600pgq.11.2019.04.14.09.25.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Apr 2019 09:25:41 -0700 (PDT) From: Alex Gramiak To: Eli Zaretskii Subject: Re: bug#35272: [PATCH] * lisp/frame.el (frame--size-history): Fix infloop. References: <87bm18vbrt.fsf@gmail.com> <83zhosine1.fsf@gnu.org> Date: Sun, 14 Apr 2019 10:25:42 -0600 In-Reply-To: <83zhosine1.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 14 Apr 2019 19:04:38 +0300") Message-ID: <8736mkv9ix.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35272 Cc: 35272@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Alex Gramiak >> Date: Sun, 14 Apr 2019 09:37:10 -0600 >> >> frame-size-history can be nil, which resulted in an infloop. >> >> >From 5695525ed1477e908536d159da670f0f1ab4a369 Mon Sep 17 00:00:00 2001 >> From: Alexander Gramiak >> Date: Sun, 14 Apr 2019 09:27:50 -0600 >> Subject: [PATCH] * lisp/frame.el (frame--size-history): Fix infloop. >> >> --- >> lisp/frame.el | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lisp/frame.el b/lisp/frame.el >> index b5c936a51e..6f9e769e16 100644 >> --- a/lisp/frame.el >> +++ b/lisp/frame.el >> @@ -1610,7 +1610,7 @@ frame--size-history >> (with-current-buffer (get-buffer-create "*frame-size-history*") >> (erase-buffer) >> (insert (format "Frame size history of %s\n" frame)) >> - (while (listp (setq entry (pop history))) >> + (while (consp (setq entry (pop history))) >> (when (eq (car entry) frame) >> (pop entry) >> (insert (format "%s" (pop entry))) > > Thanks. > > But wouldn't it be better to special-case the nil value, and display > something to that effect, instead of just nothing after the header? I suppose so. Here's a version which does that: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-frame.el-frame-size-history-Fix-infloop.-Bug-35.patch Content-Description: infloop >From 2231442f515514480a2cfcedc96972dbbe3e93e7 Mon Sep 17 00:00:00 2001 From: Alexander Gramiak Date: Sun, 14 Apr 2019 09:27:50 -0600 Subject: [PATCH] * lisp/frame.el (frame--size-history): Fix infloop. (Bug#35272) --- lisp/frame.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/frame.el b/lisp/frame.el index b5c936a51e..a4a597af02 100644 --- a/lisp/frame.el +++ b/lisp/frame.el @@ -1610,14 +1610,16 @@ frame--size-history (with-current-buffer (get-buffer-create "*frame-size-history*") (erase-buffer) (insert (format "Frame size history of %s\n" frame)) - (while (listp (setq entry (pop history))) + (while (consp (setq entry (pop history))) (when (eq (car entry) frame) (pop entry) (insert (format "%s" (pop entry))) (move-to-column 24 t) (while entry (insert (format " %s" (pop entry)))) - (insert "\n")))))) + (insert "\n"))) + (when (null frame-size-history) + (insert "No frame size history available.\n"))))) (declare-function x-frame-edges "xfns.c" (&optional frame type)) (declare-function w32-frame-edges "w32fns.c" (&optional frame type)) -- 2.21.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 12:33:43 2019 Received: (at 35272) by debbugs.gnu.org; 14 Apr 2019 16:33:43 +0000 Received: from localhost ([127.0.0.1]:33076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFi4c-0002di-Uc for submit@debbugs.gnu.org; Sun, 14 Apr 2019 12:33:43 -0400 Received: from mail-ed1-f50.google.com ([209.85.208.50]:33616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFi4Z-0002dQ-CM for 35272@debbugs.gnu.org; Sun, 14 Apr 2019 12:33:41 -0400 Received: by mail-ed1-f50.google.com with SMTP id d55so11686348ede.0 for <35272@debbugs.gnu.org>; Sun, 14 Apr 2019 09:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6a2IwQlsRqq2iUelr2crNItw09b6q2SIzUJT6jU0Cls=; b=s+kyqSIzbypBtl4sJjN35fjaQbzBrGeElQMZoBy1APKuKNm9AnX0VFGcsIcnK02glf 2moCG4PmqrAkZAcv9NDmJCShRGmVgsQs6OOK1kXA42EV4EcDAJyftydLFj8nQeEuJfry qcU+CVB4NlST4XDDuTtSNkqLd2RkZmFgfMF09quGfxMbxirZ/YtZRbqns0pc3NO9i5J+ 4n9As7i7Vv4+ffb4AkGXy08Ii44L5a+f+/ErBS3tBQM43Houo7xmOUUpb5mCdwq1ix2g VoLlC9UnY8l9odKEFn/BWnIrpYli4ktovgG3sZt4kLHw9BkctmucYDjLD3ljj4V6xZzP RNoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6a2IwQlsRqq2iUelr2crNItw09b6q2SIzUJT6jU0Cls=; b=RKnhJHRazBmy+TMPViUm2EWbDD0wAiKWD3e7nk0lk3cVYiiCQLxlFOqjAu9SbvPkBR mQQzS7HikpTCUr9kjU9veL+m7DBanqQjxEOITzN3Aqyd7d2GVhx6R/Ub5ieCW1SaDYqr smHoL6fFKIw6guU0uWrSe2sjKqGDho9tekr4BsXaw3iVOWKI7F4rUsw6jotLKZdJ1ABS OpBrAqalXbyrOFMUFNV5luc3jR+OObtdx1H/MPgNQsMpJnGHE4l0xQ6GQpvFVbkDTBp1 wBEs90zhQ7RgHucyivo7eq198qXyVaeyvyhtUh7qOg2pkmSz9l6lyF2mFD9B2TkiwXDx XCzw== X-Gm-Message-State: APjAAAXvYfSrH6cP5bn6XajWrjUANOW1WQhQOTwAeajborCIoAAI7Zdp XRMcbClXu9g+Jv1sdAeeQ1jgNw== X-Google-Smtp-Source: APXvYqzWwtHxkBv2FJLHoh16+To5X7QNmR29gdzAHvObweDu16qBM7QeF/Bl/n3qK781f31OYkPvQQ== X-Received: by 2002:aa7:c891:: with SMTP id p17mr43776953eds.183.1555259613694; Sun, 14 Apr 2019 09:33:33 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:20c2:134e:4f3a:683a]) by smtp.gmail.com with ESMTPSA id d23sm8819661eja.42.2019.04.14.09.33.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 14 Apr 2019 09:33:32 -0700 (PDT) From: "Basil L. Contovounesios" To: Alex Gramiak Subject: Re: bug#35272: [PATCH] * lisp/frame.el (frame--size-history): Fix infloop. References: <87bm18vbrt.fsf@gmail.com> <83zhosine1.fsf@gnu.org> <8736mkv9ix.fsf@gmail.com> Date: Sun, 14 Apr 2019 17:33:31 +0100 In-Reply-To: <8736mkv9ix.fsf@gmail.com> (Alex Gramiak's message of "Sun, 14 Apr 2019 10:25:42 -0600") Message-ID: <87ef64zgv8.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35272 Cc: Eli Zaretskii , 35272@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Gramiak writes: > + (when (null frame-size-history) > + (insert "No frame size history available.\n"))))) AKA (unless frame-size-history ...), if you prefer. Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 12:36:08 2019 Received: (at 35272) by debbugs.gnu.org; 14 Apr 2019 16:36:08 +0000 Received: from localhost ([127.0.0.1]:33080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFi6y-0002jp-CP for submit@debbugs.gnu.org; Sun, 14 Apr 2019 12:36:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFi6v-0002jL-TI for 35272@debbugs.gnu.org; Sun, 14 Apr 2019 12:36:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFi6q-0000sk-KD; Sun, 14 Apr 2019 12:36:00 -0400 Received: from [176.228.60.248] (port=1546 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hFi6q-0000tg-3k; Sun, 14 Apr 2019 12:36:00 -0400 Date: Sun, 14 Apr 2019 19:35:49 +0300 Message-Id: <83wojwily2.fsf@gnu.org> From: Eli Zaretskii To: Alex Gramiak In-reply-to: <8736mkv9ix.fsf@gmail.com> (message from Alex Gramiak on Sun, 14 Apr 2019 10:25:42 -0600) Subject: Re: bug#35272: [PATCH] * lisp/frame.el (frame--size-history): Fix infloop. References: <87bm18vbrt.fsf@gmail.com> <83zhosine1.fsf@gnu.org> <8736mkv9ix.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35272 Cc: 35272@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Alex Gramiak > Cc: 35272@debbugs.gnu.org > Date: Sun, 14 Apr 2019 10:25:42 -0600 > > + (when (null frame-size-history) > + (insert "No frame size history available.\n"))))) LGTM, but maybe say "Frame size history is nil" or some such. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 13:44:05 2019 Received: (at 35272) by debbugs.gnu.org; 14 Apr 2019 17:44:05 +0000 Received: from localhost ([127.0.0.1]:33117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFjAj-0006VW-DQ for submit@debbugs.gnu.org; Sun, 14 Apr 2019 13:44:05 -0400 Received: from mail-pf1-f170.google.com ([209.85.210.170]:44439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFjAg-0006Up-D0; Sun, 14 Apr 2019 13:44:03 -0400 Received: by mail-pf1-f170.google.com with SMTP id y13so7431826pfm.11; Sun, 14 Apr 2019 10:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wC2sGX28w4N+rs6HJAocYnz6k+IP1osNwPw6YTt3cfs=; b=mNqkrT42IqTn9OxRqGUwxDDoN9uLiOXh31DAd+LQWHnVFZYB2COLlXh2FrVMsjG73l tseqwD2ykjKG8cuMbJ4HL6VhT/WfGcaYV4yZWR27vtLDrkgTiBFJMk96jRcisafbgKf7 7M706Ff3ADf4FA+X88PlOamDaNW9YBpXGHLtYNsBqV+W/mTJ+xxcKamsR1eHz1MfEt9J cBrsCqc+Pp8yBfL9IsDHdQ0Q/orspVzC0DhHULMoyootXxmg6RBd3Y6AaqJfSjVFtbwQ CQtcYxKWq45mcRHDXx6qxcFKTOi9yGkKqFOWw3zzPEUrxApSj4rDBJmxKcyLoGmi+8lN /G5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wC2sGX28w4N+rs6HJAocYnz6k+IP1osNwPw6YTt3cfs=; b=HFCplv1fxiSPpaqNv9vc7qLLXsCfeM7PwHfF0i42mlUg53FNZycpGr3+XgBIxn8NmQ bPoxyJf1MxvDkIXNyFurm5Vmn+CVGWlA5vnSn11TXCgdPSFdFpuGXnBf8xKVoKdtFUmS rRkrVHOPzXQN4PflhGlAKsgjCPPvvB+7Hu+KueOjWn5v7l5EbOZ6thoFUOi2j+nRHA6u G7fbOpACrjiIGs10pit0myIU9kDvYZo5namjBo5/7JKzyOrw7ymw8mHIO3pG01Jto8ti IpTQ5QI2NUjySQROVa3ohjs2jeKdo5tPZqYMo4o+1jeLurj6KON8KavnfAOltmwiVjaw /V8g== X-Gm-Message-State: APjAAAXfzjQ1jR3ro/Ps5TL78wnYlAHxBrC6HuPTphlgp/7+zd3dH0Ok wOu3lbYq36s9ZsUCOlO3YoND0KRi X-Google-Smtp-Source: APXvYqwXwsH9Ofwh18vvUJu6o39rAt9D5oAtbk/RshI7N+eb4wHpOCBefzEZJil11zchJnflFwPOJA== X-Received: by 2002:a62:e315:: with SMTP id g21mr70227244pfh.2.1555263836023; Sun, 14 Apr 2019 10:43:56 -0700 (PDT) Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id f1sm61332187pgl.35.2019.04.14.10.43.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Apr 2019 10:43:55 -0700 (PDT) From: Alex Gramiak To: "Basil L. Contovounesios" Subject: Re: bug#35272: [PATCH] * lisp/frame.el (frame--size-history): Fix infloop. References: <87bm18vbrt.fsf@gmail.com> <83zhosine1.fsf@gnu.org> <8736mkv9ix.fsf@gmail.com> <87ef64zgv8.fsf@tcd.ie> Date: Sun, 14 Apr 2019 11:43:56 -0600 In-Reply-To: <87ef64zgv8.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 14 Apr 2019 17:33:31 +0100") Message-ID: <87tvf0trc3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35272 Cc: Eli Zaretskii , 35272@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 35272 quit "Basil L. Contovounesios" writes: > Alex Gramiak writes: > >> + (when (null frame-size-history) >> + (insert "No frame size history available.\n"))))) > > AKA (unless frame-size-history ...), if you prefer. Of course, I just felt like being more explicit when I made the commit. Though unless is generally better, so I used changed the patch to use it. It's pushed as e233dedde to master. P.S. Eli, is there going to be an Emacs 26.3? If so, could this patch and perhaps the GTK memory leak patches be applied to emacs-26? From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 14:22:13 2019 Received: (at 35272) by debbugs.gnu.org; 14 Apr 2019 18:22:13 +0000 Received: from localhost ([127.0.0.1]:33157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFjlc-00014o-6f for submit@debbugs.gnu.org; Sun, 14 Apr 2019 14:22:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFjlZ-00014Z-SG for 35272@debbugs.gnu.org; Sun, 14 Apr 2019 14:22:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFjlT-0001gI-VI; Sun, 14 Apr 2019 14:22:04 -0400 Received: from [176.228.60.248] (port=4263 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hFjlS-0003a4-08; Sun, 14 Apr 2019 14:22:02 -0400 Date: Sun, 14 Apr 2019 21:21:49 +0300 Message-Id: <83sgukih1e.fsf@gnu.org> From: Eli Zaretskii To: Alex Gramiak In-reply-to: <87tvf0trc3.fsf@gmail.com> (message from Alex Gramiak on Sun, 14 Apr 2019 11:43:56 -0600) Subject: Re: bug#35272: [PATCH] * lisp/frame.el (frame--size-history): Fix infloop. References: <87bm18vbrt.fsf@gmail.com> <83zhosine1.fsf@gnu.org> <8736mkv9ix.fsf@gmail.com> <87ef64zgv8.fsf@tcd.ie> <87tvf0trc3.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35272 Cc: contovob@tcd.ie, 35272@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Alex Gramiak > Cc: Eli Zaretskii , 35272@debbugs.gnu.org > Date: Sun, 14 Apr 2019 11:43:56 -0600 > > P.S. Eli, is there going to be an Emacs 26.3? I don't know yet. > If so, could this patch and perhaps the GTK memory leak patches be > applied to emacs-26? Yes, you can backport them. From unknown Tue Jun 17 22:12:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 13 May 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator