GNU bug report logs - #35264
"Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers

Previous Next

Package: emacs;

Reported by: Noam Postavsky <npostavs <at> gmail.com>

Date: Sun, 14 Apr 2019 04:41:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #28 received at 35264 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 35264 <at> debbugs.gnu.org, npostavs <at> gmail.com, monnier <at> iro.umontreal.ca
Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks"
 when hooks only shifted match-data's markers
Date: Wed, 12 May 2021 17:57:14 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

>> I tried the code example in that bug report now (with the patch that
>> removes the sanity check), and it did not crash Emacs.  So that sanity
>> check no longer seems to be necessary?
>
> Probably because some code somewhere uses save-match-data.

I guess.  But we have a case here where the sanity check is definitely
wrong, and we don't have a reproducing case (any more) for the problem
the check is trying to fix...  which seems to indicate to me that we
should apply the patch (i.e., remove the buggy sanity check).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 2 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.