From unknown Tue Jun 17 20:14:30 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35264 <35264@debbugs.gnu.org> To: bug#35264 <35264@debbugs.gnu.org> Subject: Status: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers Reply-To: bug#35264 <35264@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:14:30 +0000 retitle 35264 "Match data clobbered by buffer modification hooks" when hook= s only shifted match-data's markers reassign 35264 emacs submitter 35264 Noam Postavsky severity 35264 normal tag 35264 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 00:40:27 2019 Received: (at submit) by debbugs.gnu.org; 14 Apr 2019 04:40:27 +0000 Received: from localhost ([127.0.0.1]:59647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFWwN-0002q6-4v for submit@debbugs.gnu.org; Sun, 14 Apr 2019 00:40:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFWwL-0002pu-Lr for submit@debbugs.gnu.org; Sun, 14 Apr 2019 00:40:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:37392) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hFWwG-000822-Fm for submit@debbugs.gnu.org; Sun, 14 Apr 2019 00:40:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFWwF-0003SS-8N for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2019 00:40:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFWwE-00080C-7U for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2019 00:40:19 -0400 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]:34464) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hFWwC-0007yT-UT for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2019 00:40:17 -0400 Received: by mail-qk1-x72e.google.com with SMTP id n68so8042246qka.1 for ; Sat, 13 Apr 2019 21:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=t1/blLmDk392Fbv6JE4t/cjh/+eVx5p5RKY4GjxfWW4=; b=EBWU5ddtpH1dV+MYqE6j4S1eBa4Q1JrmzPJmJjFIqMcaTxH3zVdWXMjty5eWgCpayP ewNHArj6TjPo4u65dr3cnELkaBUKWR6h+X1TYublk9+7Jtej5yudw554bG5TeaicqNhk c28J4DQGi+OqfcER+ejTdmixTVaLuojexfthWHwkCI56pF/AbF6EKbBql5qxsnhBH1kK xSRLLU6swKhIqlK3dzcQ5xMnfsLVfvoc6AHQ3QuRm3u7wJRybpqDSlbUfLFh4NTAsIHN Ii3LVNrvAe0jrjfPdNVWmjDqCiZyshlPlaNE5ix/OdS2twlJP7u9DJWXViK6fFG70XpC SyLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=t1/blLmDk392Fbv6JE4t/cjh/+eVx5p5RKY4GjxfWW4=; b=kveMi1aBjEpUpXqjPq3GNEucECbImtr+Y9tEIhU1n3LKKB7OSk05Tp26LU8Fqfu7bh qfMoiYnjGEKNewVbksL3U9T4NTslkMfB5ZhvZTTbPvHOoqWSESI9420DOoZqhEBCYJVy NjNYvu+dlzjAzk5LPiBYo9sdKmSAP2b2MogWaPVakfQ8NX9LJQHnledj+9IlhNEK7OAK v8+lVOs/h/UOaRZHvlBUVQZ1MKj+C34XDg2PfgbXx52ammK8g7FUOjpoGpZewVpjC0aF uxxZdjRpC/MsirSnQcyJP5x9Z/axnOJgJlQJqM8sGjNlTv4TpcdpnJMjVjRS3hVQGEt4 WKOg== X-Gm-Message-State: APjAAAWCPa+f8yXtALHVMF9K7ECnrT7cnPz5aeaIEZcTjSII3EAqAn2o gvtOK4ByaINoShaIphbsfgiYPrQN X-Google-Smtp-Source: APXvYqw6SkCiu13wKAQ2kXfka514OQq+kyRnzatEo+khEL2thCWA3YGI3PeWMj/8tjefukwzU+L/kA== X-Received: by 2002:a37:e507:: with SMTP id e7mr52311435qkg.322.1555216816161; Sat, 13 Apr 2019 21:40:16 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m189sm27646469qkf.2.2019.04.13.21.40.14 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 Apr 2019 21:40:14 -0700 (PDT) From: Noam Postavsky To: bug-gnu-emacs@gnu.org Subject: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers Date: Sun, 14 Apr 2019 00:40:13 -0400 Message-ID: <87h8b119oy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::72e X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Version: 27.0.50 26.2 25.3 X-Debbugs-CC: Stefan Monnier emacs -Q -l bug-xxxx-match-data-marker-clobber.el Hit , gives Debugger entered--Lisp error: (error "Match data clobbered by buffer modification hooks") replace-match("ABCDEF" t t) (let* ((after-change-functions (list (function (lambda (&rest _) (let (... ...) (save-excursion ...))))))) (search-backward "abcdef") (replace-match "ABCDEF" t t)) (save-current-buffer (set-buffer (get-buffer-create "*test*")) (display-buffer (current-buffer)) (erase-buffer) (insert "1234567890\n") (insert "abcdefghilk\n") (make-local-variable (quote after-change-functions)) (let* ((after-change-functions (list (function (lambda (&rest _) (let ... ...)))))) (search-backward "abcdef") (replace-match "ABCDEF" t t))) bug-match-data-marker-clobber() funcall-interactively(bug-match-data-marker-clobber) call-interactively(bug-match-data-marker-clobber nil nil) command-execute(bug-match-data-marker-clobber) But the modification hook in question did call save-match-data. As far as I can tell, the problem is that the match-data consists of markers, whose position gets shifted by deletion of characters. The check for this error uses simple integers, so there's no way it can account for this. I think this is a variant of Bug#23917, there was some talk there about removing the check, perhaps that is the right solution. DEFUN ("replace-match", Freplace_match, Sreplace_match, 1, 5, 0, [...] /* The functions below modify the buffer, so they could trigger various modification hooks (see signal_before_change and signal_after_change). If these hooks clobber the match data we error out since otherwise this will result in confusing bugs. */ ptrdiff_t sub_start = search_regs.start[sub]; ptrdiff_t sub_end = search_regs.end[sub]; unsigned num_regs = search_regs.num_regs; newpoint = search_regs.start[sub] + SCHARS (newtext); /* Replace the old text with the new in the cleanest possible way. */ replace_range (search_regs.start[sub], search_regs.end[sub], newtext, 1, 0, 1, 1); [...] if (search_regs.start[sub] != sub_start || search_regs.end[sub] != sub_end || search_regs.num_regs != num_regs) error ("Match data clobbered by buffer modification hooks"); bug-xxxx-match-data-marker-clobber.el: --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=bug-xxxx-match-data-marker-clobber.el Content-Description: bug reproducer (defun bug-match-data-marker-clobber () (interactive) (with-current-buffer (get-buffer-create "*test*") (display-buffer (current-buffer)) (erase-buffer) (insert "1234567890\n") (insert "abcdefghilk\n") (make-local-variable 'after-change-functions) (let* ((after-change-functions ` (,(lambda (&rest _) (let ((inhibit-modification-hooks nil) (after-change-functions nil)) (save-excursion (save-match-data (goto-char (point-min)) (looking-at "[0-9]") (delete-char 1)) ;; match-data is restored, but markers have a ;; different position now, because of the ;; deletion. ;; ;; (match-data) ;=> (# #) )))))) (search-backward "abcdef") ;; (match-data) ;=> (# #) (replace-match "ABCDEF" t t) ;; Triggers `after-change-functions'. ))) (setq debug-on-error t) (define-key global-map [f12] 'bug-match-data-marker-clobber) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 30 19:04:05 2019 Received: (at 35264) by debbugs.gnu.org; 30 May 2019 23:04:05 +0000 Received: from localhost ([127.0.0.1]:34318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWU5c-0000X5-QM for submit@debbugs.gnu.org; Thu, 30 May 2019 19:04:05 -0400 Received: from mail-it1-f182.google.com ([209.85.166.182]:39899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWU5a-0000WX-0a for 35264@debbugs.gnu.org; Thu, 30 May 2019 19:04:03 -0400 Received: by mail-it1-f182.google.com with SMTP id j204so6893880ite.4 for <35264@debbugs.gnu.org>; Thu, 30 May 2019 16:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uPI4KOQe9rq+2EMxvVflJUtWVIHqOAa0RqZWYYjnu7A=; b=o4Af/+OYqabOf33LYZGYKCyH3L4J+UyiY+X3UXBYdAiHfqhozErz0eNdTrhjKPYTMe NKpAf0Oj4gASFMBI7qnngjhfoIkO7ifzxnSLADVkN+j86YV9aMIXtXUyJ7X04Gz1Macy oHFsZHpOCtmTE9q2k9SbDhPpcwbVglSxKtsFw0R7+jsfXEEgUtg86iJxSwhGimU+dJ5j sOBWHHAXRB+B2YaiHtpFXk/QFnTyXKKLmWgOdyhvs24ne/BvSQo3rQ5Tdo9WkBreiuED 8jnCXHcu+F+tQ38T+CzPoSYsIbJGcU8omdC4VpLed5GoRpflncppCPviFNKqpM5K183B SlPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uPI4KOQe9rq+2EMxvVflJUtWVIHqOAa0RqZWYYjnu7A=; b=KuzdZJsOhWwFxqnny+I0a8ProiGHHluvCBjok1VFVptLt9pENG2WZYXdE1+p6qdnbn GRJyAh0GT33y9S522LlmD03UfkTOglk0ZLV/5VzUXGzc7yvFEDLNj95uThUrS9UEnIP2 hjupXQVkjK/VF0sR//bh5+Js8BSgv8n0JjQVKJpj4F+kev/ufsoQXoD/Dw16pnGspSZP M/R7DMmPwHY6EHoKAiakP6MgHVvxbsVtnwd5OHk3/uAlALDRs+FTHrregAVwlMyEZWTd IUg0B9uiXYEyybfbTyZSPqEx8yS+qg99KQyWqyFtkoPldFvqKQb+I9Qn8mszbx8Pa3uu fa2Q== X-Gm-Message-State: APjAAAUNMdLD5f0+b9OmDg9mqWx3UJLQp5z8289asTLuv5vVGiBNGX+d 2pkYFoRctNGWJ4u2ob5EAAo= X-Google-Smtp-Source: APXvYqwlA5xggJ8h4djSsnldTAJQr+xfPXt5RE3RBtKKR7DjSHZQNC9svppZDr0iRMfwn6eQh9a8HQ== X-Received: by 2002:a24:64c6:: with SMTP id t189mr5012622itc.161.1559257436427; Thu, 30 May 2019 16:03:56 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id u134sm1777255itb.32.2019.05.30.16.03.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 May 2019 16:03:55 -0700 (PDT) From: Noam Postavsky To: 35264@debbugs.gnu.org Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers References: <87h8b119oy.fsf@gmail.com> Date: Thu, 30 May 2019 19:03:54 -0400 In-Reply-To: <87h8b119oy.fsf@gmail.com> (Noam Postavsky's message of "Sun, 14 Apr 2019 00:40:13 -0400") Message-ID: <871s0f7det.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35264 Cc: stefan monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain > I think this is a variant of Bug#23917, there was some talk there about > removing the check, perhaps that is the right solution. So, this, I guess. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Remove-unreliable-test-for-match-data-clobbering-Bug.patch Content-Description: patch >From 6fd6605c63ecc031a3fd6ba8b8e2e754c183b3f2 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Thu, 30 May 2019 19:00:31 -0400 Subject: [PATCH] Remove unreliable test for match data clobbering (Bug#35264) * src/search.c (Freplace_match): Don't test for change in search_regs start and end, this is unreliable if change hooks modify text earlier in the buffer. --- src/search.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/src/search.c b/src/search.c index db7fecd9ba..1d4550849e 100644 --- a/src/search.c +++ b/src/search.c @@ -2730,22 +2730,16 @@ DEFUN ("replace-match", Freplace_match, Sreplace_match, 1, 5, 0, /* The functions below modify the buffer, so they could trigger various modification hooks (see signal_before_change and signal_after_change). If these hooks clobber the match data we - error out since otherwise this will result in confusing bugs. */ - ptrdiff_t sub_start = search_regs.start[sub]; - ptrdiff_t sub_end = search_regs.end[sub]; + error out since otherwise this will result in confusing bugs. We + used to check for changes in search_regs start and end, but that + fails if modification hooks remove or add text earlier in the + buffer, so just check num_regs now. */ unsigned num_regs = search_regs.num_regs; newpoint = search_regs.start[sub] + SCHARS (newtext); /* Replace the old text with the new in the cleanest possible way. */ replace_range (search_regs.start[sub], search_regs.end[sub], newtext, 1, 0, 1, 1); - /* Update saved data to match adjustment made by replace_range. */ - { - ptrdiff_t change = newpoint - sub_end; - if (sub_start >= sub_end) - sub_start += change; - sub_end += change; - } if (case_action == all_caps) Fupcase_region (make_number (search_regs.start[sub]), @@ -2755,9 +2749,7 @@ DEFUN ("replace-match", Freplace_match, Sreplace_match, 1, 5, 0, Fupcase_initials_region (make_number (search_regs.start[sub]), make_number (newpoint)); - if (search_regs.start[sub] != sub_start - || search_regs.end[sub] != sub_end - || search_regs.num_regs != num_regs) + if (search_regs.num_regs != num_regs) error ("Match data clobbered by buffer modification hooks"); /* Put point back where it was in the text. */ -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 21:07:41 2020 Received: (at control) by debbugs.gnu.org; 26 Aug 2020 01:07:41 +0000 Received: from localhost ([127.0.0.1]:36730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAjue-0004WH-SB for submit@debbugs.gnu.org; Tue, 25 Aug 2020 21:07:40 -0400 Received: from mail-yb1-f175.google.com ([209.85.219.175]:39117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAjud-0004W2-Ck for control@debbugs.gnu.org; Tue, 25 Aug 2020 21:07:39 -0400 Received: by mail-yb1-f175.google.com with SMTP id q16so29390ybk.6 for ; Tue, 25 Aug 2020 18:07:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=NY+uxx0LpTihPlQepNvunxSJ456sh9aMTn6Z7sKgA4Q=; b=OdooN5fCi+RY0a1ZXBpP/FPIM7ZBxhGevP7nCJhPVNC18q6lIe5V4sJmlAW9H9CWsu gO5u2BnmnZbUhEuZz7u6ZF2N6WVDK14vbItkIq5ngLzxHsPtQetCWn8D7Cam9EiaYVUC CS3bNJVKRlGiCNdhu1NA1rzAJ7AoaSyv66SKx6NKdmiYSZhCza0yf42DncHDv4hYrS6w ySLrUu14pmVSxU7aojmUV6CrkpZQnLDGYXddtKs6aB7Tbs+Mfe2W5WpRMQQrqNot2H6o LrqSBp2ws0AP3kohomrUXqia0hlJxY2IXswc0aw3U65522Hk59NVy20vuDsoobmzY7ia SFgQ== X-Gm-Message-State: AOAM532VVQ4wWyV/pCrrPcyp+e0viD9A9FQwPIuypSvrOz9Y9BSWaUW4 0sWswSKpU8kWTNTa/dzo219Y32vc4lb0U2/Hd7Z/noQqqs0= X-Google-Smtp-Source: ABdhPJxGcKTsxnHi2C1OEtpfzfjqDpNEGICznx3cMhQz7w4pThatEElDIMquxL6O4Nncb0rpLSaV79XYyH2tOxajb7k= X-Received: by 2002:a5b:410:: with SMTP id m16mr17557875ybp.309.1598404053940; Tue, 25 Aug 2020 18:07:33 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 25 Aug 2020 18:07:33 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Tue, 25 Aug 2020 18:07:33 -0700 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 35264 + patch thanks Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.175 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.175 listed in wl.mailspike.net] 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 35264 + patch thanks Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.175 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.175 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 BLANK_SUBJECT Subject is present but empty -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different tags 35264 + patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 02 00:48:13 2020 Received: (at 35264) by debbugs.gnu.org; 2 Oct 2020 04:48:13 +0000 Received: from localhost ([127.0.0.1]:39026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOCzN-00049b-02 for submit@debbugs.gnu.org; Fri, 02 Oct 2020 00:48:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOCzJ-00049G-AI for 35264@debbugs.gnu.org; Fri, 02 Oct 2020 00:48:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+9rERkCqMUUjOzgJNLh0VbnOZqDYIQNCLQh3K7RxCDk=; b=PP0VFqqsXFYUnrwvhRTCEczvHg MzUoO7a18f+W86DOyefvOdlAMrqPm3ONUHxldvhqeY+vBf34w/jhZg/v3RhF95HToiJoR7bu86sr8 qOySeRr38qlDSGQs+ZjD0lXbSSmGMOfWvCr+oo5cqBUaWuY4lrU3SaH6TaIDWp2QIO28=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOCz6-0007jm-BN; Fri, 02 Oct 2020 06:48:02 +0200 From: Lars Ingebrigtsen To: Noam Postavsky Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> X-Now-Playing: Joni Mitchell's _Travelogue (2)_: "The Dawntreader" Date: Fri, 02 Oct 2020 06:47:55 +0200 In-Reply-To: <871s0f7det.fsf@gmail.com> (Noam Postavsky's message of "Thu, 30 May 2019 19:03:54 -0400") Message-ID: <87a6x5z11g.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Noam Postavsky writes: >> I think this is a variant of Bug#23917, there was some talk there about >> removing the check, perhaps that is the right solution. > > So, this, I guess. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35264 Cc: stefan monnier , 35264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: >> I think this is a variant of Bug#23917, there was some talk there about >> removing the check, perhaps that is the right solution. > > So, this, I guess. [...] > * src/search.c (Freplace_match): Don't test for change in search_regs > start and end, this is unreliable if change hooks modify text earlier > in the buffer. [...] > - if (search_regs.start[sub] != sub_start > - || search_regs.end[sub] != sub_end > - || search_regs.num_regs != num_regs) > + if (search_regs.num_regs != num_regs) > error ("Match data clobbered by buffer modification hooks"); > > /* Put point back where it was in the text. */ There were unfortunately no comments on this patch at the time. Noam said: > But the modification hook in question did call save-match-data. As far > as I can tell, the problem is that the match-data consists of markers, > whose position gets shifted by deletion of characters. The check for > this error uses simple integers, so there's no way it can account for > this. That does make sense, but removing this (somewhat buggy) sanity check is perhaps a bit scary. Any comments on this? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 10:35:52 2021 Received: (at 35264) by debbugs.gnu.org; 12 May 2021 14:35:52 +0000 Received: from localhost ([127.0.0.1]:40000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgpxo-0001pN-2s for submit@debbugs.gnu.org; Wed, 12 May 2021 10:35:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgpxl-0001p6-42 for 35264@debbugs.gnu.org; Wed, 12 May 2021 10:35:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=z3iwCZZfKxFAiAWQO/4YJjkK3g70lhODoBI/UVKaBHA=; b=tXvz6NryY7N+bfq4IcYNiuVumk BoEpCF3xGy+s4VM/XwDfe1LFgb/+7n1CZIK+Wdkw/ckGdBj7geq1HAp/R0C4TIjCOAujNHdcu4qN+ 16+/QcTgIk3a17+Y3kD+rqOgJd2ALxAXtSii9jNiBULH82lXf7JsbNosCAFVK8chib/Y=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgpxb-0005cc-Bc; Wed, 12 May 2021 16:35:41 +0200 From: Lars Ingebrigtsen To: Noam Postavsky Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers In-Reply-To: <87a6x5z11g.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 02 Oct 2020 06:47:55 +0200") References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> <87a6x5z11g.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) X-Now-Playing: Fire!'s _Defeat_: "Each millimeter of the toad, part 2" Date: Wed, 12 May 2021 16:35:38 +0200 Message-ID: <8735usj9z9.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: >> But the modification hook in question did call save-match-data. As far >> as I can tell, the problem is that the match-data consists of markers, >> whose position gets shifted by deletion of charac [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35264 Cc: stefan monnier , 35264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: >> But the modification hook in question did call save-match-data. As far >> as I can tell, the problem is that the match-data consists of markers, >> whose position gets shifted by deletion of characters. The check for >> this error uses simple integers, so there's no way it can account for >> this. > > That does make sense, but removing this (somewhat buggy) sanity check is > perhaps a bit scary. Any comments on this? There were no comments, and the patch no longer applies. I've respun it now for Emacs 28, and this fixes the case reported in this bug report (which still reproduces in Emacs 28). Any comments? diff --git a/src/search.c b/src/search.c index c757bf3d1f..df384e1dcf 100644 --- a/src/search.c +++ b/src/search.c @@ -2723,7 +2723,6 @@ DEFUN ("replace-match", Freplace_match, Sreplace_match, 1, 5, 0, } newpoint = sub_start + SCHARS (newtext); - ptrdiff_t newstart = sub_start == sub_end ? newpoint : sub_start; /* Replace the old text with the new in the cleanest possible way. */ replace_range (sub_start, sub_end, newtext, 1, 0, 1, true); @@ -2739,11 +2738,11 @@ DEFUN ("replace-match", Freplace_match, Sreplace_match, 1, 5, 0, /* The replace_range etc. functions can trigger modification hooks (see signal_before_change and signal_after_change). Try to error out if these hooks clobber the match data since clobbering can - result in confusing bugs. Although this sanity check does not - catch all possible clobberings, it should catch many of them. */ - if (! (search_regs.num_regs == num_regs - && search_regs.start[sub] == newstart - && search_regs.end[sub] == newpoint)) + result in confusing bugs. We used to check for changes in + search_regs start and end, but that fails if modification hooks + remove or add text earlier in the buffer, so just check num_regs + now. */ + if (search_regs.num_regs != num_regs) error ("Match data clobbered by buffer modification hooks"); /* Put point back where it was in the text, if possible. */ -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 10:56:00 2021 Received: (at 35264) by debbugs.gnu.org; 12 May 2021 14:56:00 +0000 Received: from localhost ([127.0.0.1]:40046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgqHI-0002Mu-6c for submit@debbugs.gnu.org; Wed, 12 May 2021 10:56:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgqHF-0002Mi-TP for 35264@debbugs.gnu.org; Wed, 12 May 2021 10:55:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60626) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgqHA-0003MG-31; Wed, 12 May 2021 10:55:52 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2061 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgqH9-0004OT-7U; Wed, 12 May 2021 10:55:51 -0400 Date: Wed, 12 May 2021 17:55:58 +0300 Message-Id: <83o8dg2e81.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <8735usj9z9.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 12 May 2021 16:35:38 +0200) Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> <87a6x5z11g.fsf@gnus.org> <8735usj9z9.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35264 Cc: 35264@debbugs.gnu.org, npostavs@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Wed, 12 May 2021 16:35:38 +0200 > Cc: stefan monnier , 35264@debbugs.gnu.org > > Lars Ingebrigtsen writes: > > >> But the modification hook in question did call save-match-data. As far > >> as I can tell, the problem is that the match-data consists of markers, > >> whose position gets shifted by deletion of characters. The check for > >> this error uses simple integers, so there's no way it can account for > >> this. > > > > That does make sense, but removing this (somewhat buggy) sanity check is > > perhaps a bit scary. Any comments on this? > > There were no comments, and the patch no longer applies. I've respun it > now for Emacs 28, and this fixes the case reported in this bug report > (which still reproduces in Emacs 28). > > Any comments? What about bug#23869, which triggered the addition of that code? From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 11:43:45 2021 Received: (at 35264) by debbugs.gnu.org; 12 May 2021 15:43:45 +0000 Received: from localhost ([127.0.0.1]:40101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgr1V-0003ew-6H for submit@debbugs.gnu.org; Wed, 12 May 2021 11:43:45 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgr1T-0003ei-06 for 35264@debbugs.gnu.org; Wed, 12 May 2021 11:43:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Vp6R63QlvmyWgKh7Ywd8O6Z71fHSDeTVniJRO4V3e1I=; b=HY8WBS01t1V9RtMqUUiTaXIZJ0 +gjI3iNmwZwCX+G0Cl8etdMlb1ppYfomGd7JIIeBacJjQRwanfDsgXfrMa2G4XRgLlCt4y/365nEO pTbjZew69AxAtInWZyGAXvNikHmwWVLuQCSC9MH627EnIykc0wnUJ323Xdz/5nYYyxlY=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgr1J-0006IQ-KI; Wed, 12 May 2021 17:43:36 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> <87a6x5z11g.fsf@gnus.org> <8735usj9z9.fsf@gnus.org> <83o8dg2e81.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAAAAAByaaZbAAAAAXNSR0IArs4c6QAAAAJiS0dE AP+Hj8y/AAAACXBIWXMAAAsSAAALEgHS3X78AAAAB3RJTUUH5QUMDycje5WUcwAAAJhJREFUSMft k9ENgCAMRIGwkqPclF3KUfzBQC3aw/ihwX4R0tdryxHXMBZpMH9OIAeUk3BAXOqZQlqgIXBaQQF7 BjolyKFhLrRCCGKSRPNDa0WnJSgBsV2lXpWrgZyWrETml4R+Sx7Gb6lgiTEQGo3jw7nxwh9344tS UU3MKTSmJxXqQzw/tGgBFzDOcRUwChxjSvP9wEeBDeQcFNLrTcmuAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIxLTA1LTEyVDE1OjM5OjM1KzAwOjAwHFhWQgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0w NS0xMlQxNTozOTozNSswMDowMG0F7v4AAAA4dEVYdGljYzpjb3B5cmlnaHQAQ29weXJpZ2h0IChj KSAxOTk4IEhld2xldHQtUGFja2FyZCBDb21wYW55+Vd5NwAAACF0RVh0aWNjOmRlc2NyaXB0aW9u AHNSR0IgSUVDNjE5NjYtMi4xV63aRwAAACZ0RVh0aWNjOm1hbnVmYWN0dXJlcgBJRUMgaHR0cDov L3d3dy5pZWMuY2gcfwBMAAAAN3RFWHRpY2M6bW9kZWwASUVDIDYxOTY2LTIuMSBEZWZhdWx0IFJH QiBjb2xvdXIgc3BhY2UgLSBzUkdCRFNIqQAAAABJRU5ErkJggg== X-Now-Playing: Lost Girls's _Menneskekollektivet_: "Real Life" Date: Wed, 12 May 2021 17:43:33 +0200 In-Reply-To: <83o8dg2e81.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 May 2021 17:55:58 +0300") Message-ID: <87cztwhs9m.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > What about bug#23869, which triggered the addition of that code? I tried the code example in that bug report now (with the patch that removes the sanity check), and it did not crash Emacs. So that sanity check no longer seems to be necessary? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35264 Cc: 35264@debbugs.gnu.org, npostavs@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > What about bug#23869, which triggered the addition of that code? I tried the code example in that bug report now (with the patch that removes the sanity check), and it did not crash Emacs. So that sanity check no longer seems to be necessary? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 11:48:54 2021 Received: (at 35264) by debbugs.gnu.org; 12 May 2021 15:48:54 +0000 Received: from localhost ([127.0.0.1]:40108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgr6U-0005zN-0v for submit@debbugs.gnu.org; Wed, 12 May 2021 11:48:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgr6Q-0005z8-Uo for 35264@debbugs.gnu.org; Wed, 12 May 2021 11:48:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34210) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgr6L-00022m-Ju; Wed, 12 May 2021 11:48:45 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1322 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgr6K-00015g-Da; Wed, 12 May 2021 11:48:45 -0400 Date: Wed, 12 May 2021 18:48:54 +0300 Message-Id: <83im3o2brt.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87cztwhs9m.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 12 May 2021 17:43:33 +0200) Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> <87a6x5z11g.fsf@gnus.org> <8735usj9z9.fsf@gnus.org> <83o8dg2e81.fsf@gnu.org> <87cztwhs9m.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35264 Cc: 35264@debbugs.gnu.org, npostavs@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: npostavs@gmail.com, monnier@iro.umontreal.ca, 35264@debbugs.gnu.org > Date: Wed, 12 May 2021 17:43:33 +0200 > > Eli Zaretskii writes: > > > What about bug#23869, which triggered the addition of that code? > > I tried the code example in that bug report now (with the patch that > removes the sanity check), and it did not crash Emacs. So that sanity > check no longer seems to be necessary? Probably because some code somewhere uses save-match-data. From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 11:57:25 2021 Received: (at 35264) by debbugs.gnu.org; 12 May 2021 15:57:25 +0000 Received: from localhost ([127.0.0.1]:40122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgrEj-0006E0-A7 for submit@debbugs.gnu.org; Wed, 12 May 2021 11:57:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:60154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgrEi-0006Do-3p for 35264@debbugs.gnu.org; Wed, 12 May 2021 11:57:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=03q7tLAPOtyNabpURVT4RzeJEyDRaNfNQebQHn+c0KA=; b=rNi3WZIkTXTjuq7H9/8hL7oyDY qCFQkf2uWRkc+qDydQENvU0NS9iNPAgp5btMpV3v/fE/ccdVWvpAGTl5sh8qkLVW5WJzmBa2jysIC 1vJ9Uz2tOtTfu2+BA4F0vgsMBrOL5UN+DXaBgbYgT1IieKxRcmFhsFWxOZy/q55ITWIQ=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgrEY-0006Om-Ud; Wed, 12 May 2021 17:57:17 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> <87a6x5z11g.fsf@gnus.org> <8735usj9z9.fsf@gnus.org> <83o8dg2e81.fsf@gnu.org> <87cztwhs9m.fsf@gnus.org> <83im3o2brt.fsf@gnu.org> X-Now-Playing: Tuxedomoon's _Live in Alberobello, Italy_: "Muchos Colores" Date: Wed, 12 May 2021 17:57:14 +0200 In-Reply-To: <83im3o2brt.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 May 2021 18:48:54 +0300") Message-ID: <87v97ogd2d.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> I tried the code example in that bug report now (with the patch that >> removes the sanity check), and it did not crash Emacs. So that sanity >> check no longer seems to be necessary? > > Probably [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35264 Cc: 35264@debbugs.gnu.org, npostavs@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> I tried the code example in that bug report now (with the patch that >> removes the sanity check), and it did not crash Emacs. So that sanity >> check no longer seems to be necessary? > > Probably because some code somewhere uses save-match-data. I guess. But we have a case here where the sanity check is definitely wrong, and we don't have a reproducing case (any more) for the problem the check is trying to fix... which seems to indicate to me that we should apply the patch (i.e., remove the buggy sanity check). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 12:03:05 2021 Received: (at 35264) by debbugs.gnu.org; 12 May 2021 16:03:05 +0000 Received: from localhost ([127.0.0.1]:40148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgrKD-0006PR-6e for submit@debbugs.gnu.org; Wed, 12 May 2021 12:03:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgrKA-0006Oc-LX for 35264@debbugs.gnu.org; Wed, 12 May 2021 12:03:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34804) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgrK5-00027p-2o; Wed, 12 May 2021 12:02:57 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2190 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgrK4-0008Cj-D2; Wed, 12 May 2021 12:02:56 -0400 Date: Wed, 12 May 2021 19:03:04 +0300 Message-Id: <83fsys2b47.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87v97ogd2d.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 12 May 2021 17:57:14 +0200) Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> <87a6x5z11g.fsf@gnus.org> <8735usj9z9.fsf@gnus.org> <83o8dg2e81.fsf@gnu.org> <87cztwhs9m.fsf@gnus.org> <83im3o2brt.fsf@gnu.org> <87v97ogd2d.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35264 Cc: 35264@debbugs.gnu.org, npostavs@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: npostavs@gmail.com, monnier@iro.umontreal.ca, 35264@debbugs.gnu.org > Date: Wed, 12 May 2021 17:57:14 +0200 > > Eli Zaretskii writes: > > >> I tried the code example in that bug report now (with the patch that > >> removes the sanity check), and it did not crash Emacs. So that sanity > >> check no longer seems to be necessary? > > > > Probably because some code somewhere uses save-match-data. > > I guess. But we have a case here where the sanity check is definitely > wrong, and we don't have a reproducing case (any more) for the problem > the check is trying to fix... which seems to indicate to me that we > should apply the patch (i.e., remove the buggy sanity check). I'm not against applying the change, I just wonder why Stefan wasn't against it back then as he is now. From debbugs-submit-bounces@debbugs.gnu.org Thu May 13 05:11:53 2021 Received: (at 35264) by debbugs.gnu.org; 13 May 2021 09:11:53 +0000 Received: from localhost ([127.0.0.1]:41307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lh7Np-0006BR-3W for submit@debbugs.gnu.org; Thu, 13 May 2021 05:11:53 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lh7Nk-0006B8-5X for 35264@debbugs.gnu.org; Thu, 13 May 2021 05:11:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oF/qnk6PAta6Mqg1DhwEpFF8a+pmn1buOZZfAcpRlqc=; b=KueTkIs6feUFcFdKH+EmaucykD xSvCTVhv67aMqO26l3zS6DkAkR5PGvTX1slnLNgfuSlr6907GsSA0wukLsQ9+QK1IPb2xkXouyB49 aGDlc/gjb/DvyFhNcWijpk47jG2VdX/T8LqginJOtArONRdLjXp9WGYcyb5GdeS++ssQ=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lh7NY-00022C-4O; Thu, 13 May 2021 11:11:38 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> <87a6x5z11g.fsf@gnus.org> <8735usj9z9.fsf@gnus.org> <83o8dg2e81.fsf@gnu.org> <87cztwhs9m.fsf@gnus.org> <83im3o2brt.fsf@gnu.org> <87v97ogd2d.fsf@gnus.org> <83fsys2b47.fsf@gnu.org> X-Now-Playing: Chrome Hoof's _Pre-Emptive False Rapture_: "Tonyte" Date: Thu, 13 May 2021 11:11:35 +0200 In-Reply-To: <83fsys2b47.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 May 2021 19:03:04 +0300") Message-ID: <87k0o3roag.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I'm not against applying the change, I just wonder why Stefan wasn't > against it back then as he is now. Hm. Is he against it now? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35264 Cc: npostavs@gmail.com, monnier@iro.umontreal.ca, 35264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I'm not against applying the change, I just wonder why Stefan wasn't > against it back then as he is now. Hm. Is he against it now? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu May 13 06:14:26 2021 Received: (at 35264) by debbugs.gnu.org; 13 May 2021 10:14:27 +0000 Received: from localhost ([127.0.0.1]:41393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lh8MM-0001S5-N4 for submit@debbugs.gnu.org; Thu, 13 May 2021 06:14:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lh8MK-0001Rq-R3 for 35264@debbugs.gnu.org; Thu, 13 May 2021 06:14:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36548) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lh8M6-0008VJ-OD; Thu, 13 May 2021 06:14:18 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3013 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lh8M4-0006Uu-M6; Thu, 13 May 2021 06:14:10 -0400 Date: Thu, 13 May 2021 13:14:19 +0300 Message-Id: <83mtsz0wlg.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87k0o3roag.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 13 May 2021 11:11:35 +0200) Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> <87a6x5z11g.fsf@gnus.org> <8735usj9z9.fsf@gnus.org> <83o8dg2e81.fsf@gnu.org> <87cztwhs9m.fsf@gnus.org> <83im3o2brt.fsf@gnu.org> <87v97ogd2d.fsf@gnus.org> <83fsys2b47.fsf@gnu.org> <87k0o3roag.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35264 Cc: npostavs@gmail.com, monnier@iro.umontreal.ca, 35264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: 35264@debbugs.gnu.org, npostavs@gmail.com, monnier@iro.umontreal.ca > Date: Thu, 13 May 2021 11:11:35 +0200 > > Eli Zaretskii writes: > > > I'm not against applying the change, I just wonder why Stefan wasn't > > against it back then as he is now. > > Hm. Is he against it now? Sorry for sloppy wording: Stefan isn't against applying the change _you_ want to apply now. What I alluded to is that he seems to think the change I installed back then was problematic. But he didn't think so back then. From debbugs-submit-bounces@debbugs.gnu.org Thu May 13 12:03:58 2021 Received: (at 35264) by debbugs.gnu.org; 13 May 2021 16:03:58 +0000 Received: from localhost ([127.0.0.1]:44163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhDob-0007HC-Uq for submit@debbugs.gnu.org; Thu, 13 May 2021 12:03:58 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhDoZ-0007Gu-PX for 35264@debbugs.gnu.org; Thu, 13 May 2021 12:03:56 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 82D8F440BDC; Thu, 13 May 2021 12:03:50 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 50604440B41; Thu, 13 May 2021 12:03:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1620921829; bh=2CQfQ/rcQMRpGxZ0JWxzqLzEQLrROmMu6TEsyM9oMWo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kuUHJNRxhgLaq9c/faHc6jUHARhpYWF38elHDcQtwbIN2wSEJ8uHogobgowkz3ryL /R8VNoFCwX41AEJAHPPDbgK7E4tkC6Nepo6eDL3bsCcE/pBARZ+IJSQt8PFfYICRs3 i2of77QZID20Nk3Ed87kuM5gYS4amC48z03Qu5Gzd6I6yZ2lBL7Ux9xdTvgRVfhYyP 3puq8DwYOL845HP3yu+TCoz3Tol5RTKdPimhpp/puyJKuXh+ppmlaFrR30xY210qih 7CpAc9k3GphL4iaTn9sxSukN2oOaTRJvdvrV8GY7vKi/y4HjnZIOKc8Bx3gJN4XrSL B7ykM+NYqR8tQ== Received: from alfajor (76-10-140-76.dsl.teksavvy.com [76.10.140.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0D4C51201BE; Thu, 13 May 2021 12:03:49 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers Message-ID: References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> <87a6x5z11g.fsf@gnus.org> <8735usj9z9.fsf@gnus.org> <83o8dg2e81.fsf@gnu.org> <87cztwhs9m.fsf@gnus.org> <83im3o2brt.fsf@gnu.org> <87v97ogd2d.fsf@gnus.org> <83fsys2b47.fsf@gnu.org> <87k0o3roag.fsf@gnus.org> <83mtsz0wlg.fsf@gnu.org> Date: Thu, 13 May 2021 12:03:48 -0400 In-Reply-To: <83mtsz0wlg.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 May 2021 13:14:19 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35264 Cc: Lars Ingebrigtsen , npostavs@gmail.com, 35264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > I'm not against applying the change, I just wonder why Stefan wasn't >> > against it back then as he is now. >> Hm. Is he against it now? > Sorry for sloppy wording: Stefan isn't against applying the change > _you_ want to apply now. What I alluded to is that he seems to think > the change I installed back then was problematic. But he didn't think > so back then. Am I the "Stefan" you're referring to? I can't remember what you're referring to, and I can't find any intervention of mine in that bug report. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu May 13 13:09:19 2021 Received: (at 35264) by debbugs.gnu.org; 13 May 2021 17:09:19 +0000 Received: from localhost ([127.0.0.1]:44207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhEpr-0000Mv-Ia for submit@debbugs.gnu.org; Thu, 13 May 2021 13:09:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhEpp-0000Mh-8A for 35264@debbugs.gnu.org; Thu, 13 May 2021 13:09:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50114) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEpj-0000xJ-Tt; Thu, 13 May 2021 13:09:11 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1241 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEpj-0006Jf-4M; Thu, 13 May 2021 13:09:11 -0400 Date: Thu, 13 May 2021 20:09:20 +0300 Message-Id: <835yzm1ry7.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Thu, 13 May 2021 12:03:48 -0400) Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> <87a6x5z11g.fsf@gnus.org> <8735usj9z9.fsf@gnus.org> <83o8dg2e81.fsf@gnu.org> <87cztwhs9m.fsf@gnus.org> <83im3o2brt.fsf@gnu.org> <87v97ogd2d.fsf@gnus.org> <83fsys2b47.fsf@gnu.org> <87k0o3roag.fsf@gnus.org> <83mtsz0wlg.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35264 Cc: larsi@gnus.org, npostavs@gmail.com, 35264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Lars Ingebrigtsen , 35264@debbugs.gnu.org, > npostavs@gmail.com > Date: Thu, 13 May 2021 12:03:48 -0400 > > >> > I'm not against applying the change, I just wonder why Stefan wasn't > >> > against it back then as he is now. > >> Hm. Is he against it now? > > Sorry for sloppy wording: Stefan isn't against applying the change > > _you_ want to apply now. What I alluded to is that he seems to think > > the change I installed back then was problematic. But he didn't think > > so back then. > > Am I the "Stefan" you're referring to? > I can't remember what you're referring to, and I can't find any > intervention of mine in that bug report. Forget it, it isn't worth it to waste so many messages on a minor remark. From debbugs-submit-bounces@debbugs.gnu.org Sun May 16 09:20:46 2021 Received: (at 35264) by debbugs.gnu.org; 16 May 2021 13:20:46 +0000 Received: from localhost ([127.0.0.1]:49825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liGhK-0002UF-7X for submit@debbugs.gnu.org; Sun, 16 May 2021 09:20:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liGhH-0002Ty-NT for 35264@debbugs.gnu.org; Sun, 16 May 2021 09:20:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZovTvYurLNLCchtDYSSpTqJJVybmA9L464N9zlnl2MI=; b=CFVD+KGAsrwfgN7/lxdWNxnoeb 1v7F9TWSsYwgusKJiGDW+pZILjUuvZ6Z/VikVME077Iws76YEHjxkeV2qJKptQM7ipBE8SO+sncpp Q/aLMKnqg0CXYrkKEU2LdTAAjbyzfkMu9nepxufIuQPUoamMa62P694zsIENv5PB8TSU=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liGh6-0007DN-TU; Sun, 16 May 2021 15:20:35 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers References: <87h8b119oy.fsf@gmail.com> <871s0f7det.fsf@gmail.com> <87a6x5z11g.fsf@gnus.org> <8735usj9z9.fsf@gnus.org> <83o8dg2e81.fsf@gnu.org> <87cztwhs9m.fsf@gnus.org> <83im3o2brt.fsf@gnu.org> <87v97ogd2d.fsf@gnus.org> <83fsys2b47.fsf@gnu.org> X-Now-Playing: Gil Scott-Heron & Jamie Xx's _We're New Here_: "Running" Date: Sun, 16 May 2021 15:20:32 +0200 In-Reply-To: <83fsys2b47.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 May 2021 19:03:04 +0300") Message-ID: <87r1i6q0gv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I'm not against applying the change, I just wonder why Stefan wasn't > against it back then as he is now. OK, I've now applied Noam's patch to Emacs 28. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35264 Cc: npostavs@gmail.com, monnier@iro.umontreal.ca, 35264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I'm not against applying the change, I just wonder why Stefan wasn't > against it back then as he is now. OK, I've now applied Noam's patch to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun May 16 09:20:49 2021 Received: (at control) by debbugs.gnu.org; 16 May 2021 13:20:49 +0000 Received: from localhost ([127.0.0.1]:49828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liGhN-0002UU-F6 for submit@debbugs.gnu.org; Sun, 16 May 2021 09:20:49 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liGhK-0002U3-Im for control@debbugs.gnu.org; Sun, 16 May 2021 09:20:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KOKpMaHx7gm9VH718jHgZR/9IUab9x3jbEs+/CLbnMw=; b=gEQmJxA3dJanMmOgiVnCLGgdRt Smdgy1Sv2KLPLfvY85Yz3hbal4TDxN9/OX/0ZEanxLVZV0GMYUBD6RUb1ZB4XjFhfHtwDn2Anv11D pft59WwLfe6SFZx2ujv62k79sa3qumbidjN9zvfx8hFiWECBz1G5mbvRHP+MBD9x4g5k=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liGhD-0007DY-3M for control@debbugs.gnu.org; Sun, 16 May 2021 15:20:41 +0200 Date: Sun, 16 May 2021 15:20:38 +0200 Message-Id: <87pmxqq0gp.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #35264 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 35264 fixed close 35264 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35264 fixed close 35264 28.1 quit From unknown Tue Jun 17 20:14:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 14 Jun 2021 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator