Subject: bug#35259: 27.0.50; Segmentation fault (xstrdup gdk_monitor_get_model)

From: Alex Gramiak <[email-masked]>
Date: Sat, 13 Apr 2019 16:16:51 -0600

Jhair Tocancipa Triana <[email-masked]> writes:

> Emacs crashes randomly, sometimes when clicking links in eww. The crash
> is not easily reproducible, nevertheless the core dump points to a
> segfault at xfns.c:
>
> a35e06bbe27 (Alexander Gramiak   2019-04-06 5033)       mi->name = xstrdup (gdk_monitor_get_model (monitor));
>
> gkd_monitor_get_model is returning NULL in my case causing the segfault
> at xstrdup.
>
> The gkd_monitor_get_model documentation says the function may return
> NULL.
>
> https://developer.gnome.org/gdk3/stable/GdkMonitor.html#gdk-monitor-get-model
>
> Maybe we need to guard against a NULL return value.
>
> Please find attached the bt full gdb output.

I just pushed commit 7308c2edf which should fix this. Can you confirm?
If you can't easily reproduce it, could you see if it crashed before
when just calling M-: (x-display-monitor-attributes-list)?

Sorry for the trouble.