Subject: Re: bug#35259: 27.0.50; Segmentation fault (xstrdup gdk_monitor_get_model)

From: Jhair Tocancipa Triana <[email-masked]>
Date: Sun, 14 Apr 2019 11:07:21 +0200

As suggested, before commit 7308c2edf evaluating
x-display-monitor-attributes-list triggers the segfault:

,----
| $ ./emacs -Q --eval "(x-display-monitor-attributes-list)"
| ...
| /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb)[0x7f880cf3509b]
| ./emacs(+0x3f13a)[0x561dbeb0813a]
| Segmentation fault (core dumped)
`----

With commit 7308c2edf the issue was resolved.

Thanks!

Alex Gramiak <[email-masked]> writes:

> Jhair Tocancipa Triana <[email-masked]> writes:
>
>> Emacs crashes randomly, sometimes when clicking links in eww. The crash
>> is not easily reproducible, nevertheless the core dump points to a
>> segfault at xfns.c:
>>
>> a35e06bbe27 (Alexander Gramiak 2019-04-06 5033) mi->name = xstrdup
>> (gdk_monitor_get_model (monitor));
>>
>> gkd_monitor_get_model is returning NULL in my case causing the segfault
>> at xstrdup.
>>
>> The gkd_monitor_get_model documentation says the function may return
>> NULL.
>>
>> https://developer.gnome.org/gdk3/stable/GdkMonitor.html#gdk-monitor-get-model
>>
>> Maybe we need to guard against a NULL return value.
>>
>> Please find attached the bt full gdb output.
>
> I just pushed commit 7308c2edf which should fix this. Can you confirm?
> If you can't easily reproduce it, could you see if it crashed before
> when just calling M-: (x-display-monitor-attributes-list)?
>
> Sorry for the trouble.
>
>
>
>

-- 
Key fingerprint = 5917 806E 3A2F 659B BE6A  8DEE 04B5 52D9 BC07 29A4