GNU bug report logs - #35247
[PATCH] Add alacritty to terminal list supporting colors

Previous Next

To reply to this bug, email your comments to 35247 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: doron.behar <at> gmail.com
To: bug-coreutils <at> gnu.org
Subject: [PATCH] Add alacritty to terminal list supporting colors
Date: Fri, 12 Apr 2019 22:20:04 +0300

From: Doron Behar <doron.behar <at> gmail.com>

https://github.com/jwilm/alacritty
---
 src/dircolors.hin | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/dircolors.hin b/src/dircolors.hin
index 3aa445bfa..424ed5b19 100644
--- a/src/dircolors.hin
+++ b/src/dircolors.hin
@@ -12,6 +12,7 @@
 # against the TERM environment variable to determine if it is colorizable.
 TERM Eterm
 TERM ansi
+TERM alacritty
 TERM *color*
 TERM con[0-9]*x[0-9]*
 TERM cons25
-- 
2.21.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Doron Behar <doron.behar <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: Re: [PATCH] Add alacritty to terminal list supporting colors
Date: Fri, 10 May 2019 16:06:06 +0300

Hey, can you please take a look at this patch please?

On Fri, Apr 12, 2019 at 10:20:04PM +0300, doron.behar <at> gmail.com wrote:
> From: Doron Behar <doron.behar <at> gmail.com>
> 
> https://github.com/jwilm/alacritty
> ---
>  src/dircolors.hin | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/dircolors.hin b/src/dircolors.hin
> index 3aa445bfa..424ed5b19 100644
> --- a/src/dircolors.hin
> +++ b/src/dircolors.hin
> @@ -12,6 +12,7 @@
>  # against the TERM environment variable to determine if it is colorizable.
>  TERM Eterm
>  TERM ansi
> +TERM alacritty
>  TERM *color*
>  TERM con[0-9]*x[0-9]*
>  TERM cons25
> -- 
> 2.21.0
> 

Message #11 received at 35247 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: doron.behar <at> gmail.com, 35247 <at> debbugs.gnu.org
Subject: Re: bug#35247: [PATCH] Add alacritty to terminal list supporting
 colors
Date: Fri, 10 May 2019 08:24:09 -0700

On 12/04/19 12:20, doron.behar <at> gmail.com wrote:
> From: Doron Behar <doron.behar <at> gmail.com>
> 
> https://github.com/jwilm/alacritty
> ---
>  src/dircolors.hin | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/dircolors.hin b/src/dircolors.hin
> index 3aa445bfa..424ed5b19 100644
> --- a/src/dircolors.hin
> +++ b/src/dircolors.hin
> @@ -12,6 +12,7 @@
>  # against the TERM environment variable to determine if it is colorizable.
>  TERM Eterm
>  TERM ansi
> +TERM alacritty
>  TERM *color*
>  TERM con[0-9]*x[0-9]*
>  TERM cons25
> 

I don't see this terminal packaged for Feodra at least.
Why does it need its own TERM ?
If it does, could one add 'color' to get the existing matching?

thanks,
Pádraig

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Doron Behar <doron.behar <at> gmail.com>
To: Pádraig Brady <P <at> draigbrady.com>,
	bug-coreutils <at> gnu.org
Subject: Re: bug#35247: [PATCH] Add alacritty to terminal list supporting
 colors
Date: Sat, 11 May 2019 16:57:40 +0300

Well I'm not a developer of alacritty, just a humble user. I had only
taken the effort to investigate why I dircolors wouldn't define colors
for me when in this terminal.

Under it's installation section of the README, listed the supported
packages for the various distros:

https://github.com/jwilm/alacritty#installation

On Fri, May 10, 2019 at 08:24:09AM -0700, Pádraig Brady wrote:
> On 12/04/19 12:20, doron.behar <at> gmail.com wrote:
> > From: Doron Behar <doron.behar <at> gmail.com>
> > 
> > https://github.com/jwilm/alacritty
> > ---
> >  src/dircolors.hin | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/dircolors.hin b/src/dircolors.hin
> > index 3aa445bfa..424ed5b19 100644
> > --- a/src/dircolors.hin
> > +++ b/src/dircolors.hin
> > @@ -12,6 +12,7 @@
> >  # against the TERM environment variable to determine if it is colorizable.
> >  TERM Eterm
> >  TERM ansi
> > +TERM alacritty
> >  TERM *color*
> >  TERM con[0-9]*x[0-9]*
> >  TERM cons25
> > 
> 
> I don't see this terminal packaged for Feodra at least.
> Why does it need its own TERM ?
> If it does, could one add 'color' to get the existing matching?
> 
> thanks,
> Pádraig

Message #17 received at 35247 <at> debbugs.gnu.org (full text, mbox):

From: Tycho Andersen <tycho <at> tycho.pizza>
To: coreutils <at> gnu.org
Cc: 35247 <at> debbugs.gnu.org, Tycho Andersen <tycho <at> tycho.pizza>
Subject: [PATCH] dircolors: add alacritty(-direct) terminal types
Date: Thu, 27 Jan 2022 09:47:25 -0700

In the spirit of 974848a4866f ("dircolors: add st/st-256color terminal
types") let's add alacritty as well. There was a previous attempt at this:

https://lists.gnu.org/archive/html/bug-coreutils/2019-05/msg00029.html

It seems as though Fedora has a package now for a couple releases at
least:

https://fedora.pkgs.org/34/fedora-x86_64/alacritty-0.7.2-2.fc34.x86_64.rpm.html
https://fedora.pkgs.org/35/fedora-aarch64/alacritty-0.9.0-1.fc35.aarch64.rpm.html

As for the original question of "why does alacritty need its own $TERM",
one argument is: because it implements a different set of features than any
existing common $TERM.

This differs slightly from the original in that it adds support for
alacritty*, since there are two common alacritty $TERMs, alacritty and
alacritty-direct.
---
 src/dircolors.hin | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/dircolors.hin b/src/dircolors.hin
index 59a9b51d7..d73e8432e 100644
--- a/src/dircolors.hin
+++ b/src/dircolors.hin
@@ -11,6 +11,7 @@
 # Below are TERM entries, which can be a glob patterns, to match
 # against the TERM environment variable to determine if it is colorable.
 TERM Eterm
+TERM alacritty*
 TERM ansi
 TERM *color*
 TERM con[0-9]*x[0-9]*

base-commit: 4a0a8fdbec1f522f529801082e918c47e70166c0
-- 
2.32.0

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eike Gebauer <bug-coreutils <at> rcx.one>
To: bug-coreutils <at> gnu.org
Subject: bug#35247: [PATCH] Add alacritty to terminal list supporting colors
Date: Thu, 28 Mar 2024 17:58:36 +0100

By now alacritty has been packaged for Fedora for quite a while 
(https://packages.fedoraproject.org/pkgs/rust-alacritty/alacritty/) and 
is used by a relatively large community (>50k Stars on Github).

The corresponding issue on the alacritty side has sadly been closed as 
"wontfix" (https://github.com/alacritty/alacritty/issues/2210), so I 
would like to ask you to add `TERM alacritty` to dircolors.hin instead, 
as originally requested by Doron Behar.

Regards,

Eike

PS
I did not find a way to reply to the old thread from the mailing list 
archive with the correct `In-Reply-To` header, so this might not be 
threaded correctly with the original messages from 2019.

On Sat, 11 May 2019 16:57:40 +0300, Doron Behar wrote:
> Well I'm not a developer of alacritty, just a humble user. I had only
> taken the effort to investigate why I dircolors wouldn't define colors
> for me when in this terminal.
>
> Under it's installation section of the README, listed the supported
> packages for the various distros:
>
> https://github.com/jwilm/alacritty#installation
>
> On Fri, May 10, 2019 at 08:24:09AM -0700, Pádraig Brady wrote:On 
28/03/2024 17:34, bug-coreutils-request <at> gnu.org wrote:
> > On 12/04/19 12:20, address <at> hidden wrote:
> > > From: Doron Behar <address <at> hidden>
> > >
> > > https://github.com/jwilm/alacritty
> > > ---
> > >  src/dircolors.hin | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/src/dircolors.hin b/src/dircolors.hin
> > > index 3aa445bfa..424ed5b19 100644
> > > --- a/src/dircolors.hin
> > > +++ b/src/dircolors.hin
> > > @@ -12,6 +12,7 @@
> > >  # against the TERM environment variable to determine if it is 
colorizable.
> > >  TERM Eterm
> > >  TERM ansi
> > > +TERM alacritty
> > >  TERM *color*
> > >  TERM con[0-9]*x[0-9]*
> > >  TERM cons25
> > >
> >
> > I don't see this terminal packaged for Feodra at least.
> > Why does it need its own TERM ?
> > If it does, could one add 'color' to get the existing matching?
> >
> > thanks,
> > Pádraig

Message #23 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eike Gebauer <eike <at> zettelkiste.de>
To: bug-coreutils <at> gnu.org
Subject: Re: bug#35247: [PATCH] Add alacritty to terminal list supporting
 colors
Date: Tue, 9 Apr 2024 14:31:06 +0200

I am not trying to spam this mailing list, but I received several DMARC 
reports after sending the previous mail (never happened to me before, no 
idea why).
So I am trying again from a different domain, in case the email wasn't 
received at all.

Sorry for the inconvenience.
Regards
Eike Gebauer

On 28/03/2024 17:58, Eike Gebauer wrote:
> By now alacritty has been packaged for Fedora for quite a while 
> (https://packages.fedoraproject.org/pkgs/rust-alacritty/alacritty/) 
> and is used by a relatively large community (>50k Stars on Github).
>
> The corresponding issue on the alacritty side has sadly been closed as 
> "wontfix" (https://github.com/alacritty/alacritty/issues/2210), so I 
> would like to ask you to add `TERM alacritty` to dircolors.hin 
> instead, as originally requested by Doron Behar.
>
> Regards,
>
> Eike
>
> PS
> I did not find a way to reply to the old thread from the mailing list 
> archive with the correct `In-Reply-To` header, so this might not be 
> threaded correctly with the original messages from 2019.
>
> On Sat, 11 May 2019 16:57:40 +0300, Doron Behar wrote:
> > Well I'm not a developer of alacritty, just a humble user. I had only
> > taken the effort to investigate why I dircolors wouldn't define colors
> > for me when in this terminal.
> >
> > Under it's installation section of the README, listed the supported
> > packages for the various distros:
> >
> > https://github.com/jwilm/alacritty#installation
> >
> > On Fri, May 10, 2019 at 08:24:09AM -0700, Pádraig Brady wrote:On 
> 28/03/2024 17:34, bug-coreutils-request <at> gnu.org wrote:
> > > On 12/04/19 12:20, address <at> hidden wrote:
> > > > From: Doron Behar <address <at> hidden>
> > > >
> > > > https://github.com/jwilm/alacritty
> > > > ---
> > > >  src/dircolors.hin | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/src/dircolors.hin b/src/dircolors.hin
> > > > index 3aa445bfa..424ed5b19 100644
> > > > --- a/src/dircolors.hin
> > > > +++ b/src/dircolors.hin
> > > > @@ -12,6 +12,7 @@
> > > >  # against the TERM environment variable to determine if it is 
> colorizable.
> > > >  TERM Eterm
> > > >  TERM ansi
> > > > +TERM alacritty
> > > >  TERM *color*
> > > >  TERM con[0-9]*x[0-9]*
> > > >  TERM cons25
> > > >
> > >
> > > I don't see this terminal packaged for Feodra at least.
> > > Why does it need its own TERM ?
> > > If it does, could one add 'color' to get the existing matching?
> > >
> > > thanks,
> > > Pádraig
>
>
>
>

Message #26 received at 35247 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Eike Gebauer <eike <at> zettelkiste.de>, 35247 <at> debbugs.gnu.org
Subject: Re: bug#35247: [PATCH] Add alacritty to terminal list supporting
 colors
Date: Wed, 10 Apr 2024 15:35:07 +0100

Things have changed a little since the original request.
alacritty sets $COLORTERM, and dircolors now auto accepts that since:
https://github.com/coreutils/coreutils/commit/75c9fc674

There are some complications with remote shells, but
they should boil down to setting up ssh to send/accept COLORTERM.

For some background for setting colors based on env vars
from the Fedora side of things at least, see:
https://fedoraproject.org/wiki/Features/256_Color_Terminals
https://fedoraproject.org/wiki/Changes/Drop_256term.sh

cheers,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.