From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 18:42:55 2019 Received: (at submit) by debbugs.gnu.org; 11 Apr 2019 22:42:55 +0000 Received: from localhost ([127.0.0.1]:55278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEiPH-00017Q-FN for submit@debbugs.gnu.org; Thu, 11 Apr 2019 18:42:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEiPF-00017D-Pc for submit@debbugs.gnu.org; Thu, 11 Apr 2019 18:42:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:53855) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEiP9-0007t2-5I for submit@debbugs.gnu.org; Thu, 11 Apr 2019 18:42:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEiP8-0003wW-3o for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 18:42:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEiP6-0007rz-5E for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 18:42:45 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:35836) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEiP2-0007pf-9q for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 18:42:42 -0400 Received: by mail-ed1-x532.google.com with SMTP id s39so6670782edb.2 for ; Thu, 11 Apr 2019 15:42:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:user-agent:mime-version; bh=+P9JNvzqCjBZZA8J+BUYB9GbTrbcOb/a+NqGG6qnfaU=; b=YY/4mXoxK9JVpSiV6DajvLJWuR6odxA2geWs107SNEo97Th4y5pvf/AZmjF8/klXZF HP+fSbMw2mJqLVJhPp2OnfQ0H/h++1+dhhj3JpJ8YmyGU/7857T0VT0d8HHu3cVZ1EdG CTTfICLvYXPmGXC++uZorztXA8wEOjtugU8jLMIEgFHizuTDHnTO1s3zLyRPt6BJT0Ul dRy76G1GWHbdrVHRjJ1hExPtY1fAyDgsS54vpnzt+G1YzB8qG2aYatNIUVde4DGFklF1 egCyeq+L4Fbsbcvmj2z6+bOmifc9EHh3u04CTgTc0hUWAbR3Z4uQFRWZdgLNfnaSmWtM EaSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=+P9JNvzqCjBZZA8J+BUYB9GbTrbcOb/a+NqGG6qnfaU=; b=CAbJF6+PRuWsu294YQrC8DcsNg7yHPnrrCexByKj1rGZgsoMYCROMC2d0AsiBcJa8G KyG4SEou4qaXa2zuUmrwXF7XBHfQ33f/pNP5NWNpzG2Xv8MQ38BMeHMirn9DMF9m5EZD 9xWDbx2/4J1KIiexEDtUb0UHizrMpqciuFH1Qrk80KZVqHYxC6Ti6mmdP9Vmir8gKfgz 4nFDVdwjNeBDWSnbue1hs0KFySGwsIK20IKYMaTxsttzj4T98cMn2UYt+aIGVQpvkjdz ChJt7igCXnKH2vOou4XWsdo008rFMnzIhjwV2emJqayxR8LtMU71nEJmzFmiKkBgRPN4 cErg== X-Gm-Message-State: APjAAAXDqf2xCHvEj+HbMzv3aS6XO7reiEyjOsMQEHhd2+lM+jRLCrxt uK3NHFuoteOT4GcU8pVM97wkArQCn9dtzkB0 X-Google-Smtp-Source: APXvYqzTBquLTfizOpNvV1b3WqEeoXRup2tllt43s3fMZ/TYWD70CiDms0Y01V6f6EKnwEudQU20dg== X-Received: by 2002:aa7:c6c6:: with SMTP id b6mr32478236eds.69.1555022557036; Thu, 11 Apr 2019 15:42:37 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id i91sm3814952edd.72.2019.04.11.15.42.35 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 11 Apr 2019 15:42:35 -0700 (PDT) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Clarify eventp behaviour with booleans X-Debbugs-Cc: Stefan Monnier Date: Thu, 11 Apr 2019 23:42:30 +0100 Message-ID: <87pnpsp3jd.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::532 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Severity: minor Tags: patch As mentioned in a past commit[1], nil is not an event. Since the car of a mouse click event is considered its type, shouldn't (nil) also be rejected as an event? (eventp '(nil)) ; => t Should t be counted as an event? (eventp t) ; => t (eventp '(t)) ; => t If not, would the following change be welcome? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=eventp.diff diff --git a/lisp/subr.el b/lisp/subr.el index bdf98979c4..8c4df5bc6c 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -1227,12 +1227,14 @@ listify-key-sequence c))) key))) -(defun eventp (obj) - "True if the argument is an event object." - (when obj - (or (integerp obj) - (and (symbolp obj) obj (not (keywordp obj))) - (and (consp obj) (symbolp (car obj)))))) +(defun eventp (object) + "Return non-nil if OBJECT is an input event or event object." + (or (integerp object) + (and (symbolp (if (consp object) + (setq object (car object)) + object)) + (not (booleanp object)) + (not (keywordp object))))) (defun event-modifiers (event) "Return a list of symbols representing the modifier keys in event EVENT. --=-=-= Content-Type: text/plain [1: e18941095a]: * lisp/term/x-win.el (x-menu-bar-open): ... 2012-08-10 10:47:12 -0400 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e18941095a56075d6eb908a65aafcd1697fea2ae Thanks, -- Basil In GNU Emacs 27.0.50 (build 9, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2019-04-11 built on thunk Repository revision: 0627a8d7bc6ffa29d7a503fd36e760778ecb9fa1 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: Debian GNU/Linux buster/sid --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 19:42:50 2019 Received: (at 35238) by debbugs.gnu.org; 11 Apr 2019 23:42:51 +0000 Received: from localhost ([127.0.0.1]:55303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEjLG-0002WJ-Md for submit@debbugs.gnu.org; Thu, 11 Apr 2019 19:42:50 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:53900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEjLD-0002W8-U3 for 35238@debbugs.gnu.org; Thu, 11 Apr 2019 19:42:48 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x3BNgk1W014633; Thu, 11 Apr 2019 19:42:46 -0400 Received: by pastel.home (Postfix, from userid 20848) id 77B566AD80; Thu, 11 Apr 2019 19:42:46 -0400 (EDT) From: Stefan Monnier To: "Basil L. Contovounesios" Subject: Re: bug#35238: 27.0.50; Clarify eventp behaviour with booleans Message-ID: References: <87pnpsp3jd.fsf@tcd.ie> Date: Thu, 11 Apr 2019 19:42:46 -0400 In-Reply-To: <87pnpsp3jd.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 11 Apr 2019 23:42:30 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6523=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6523> : inlines <7052> : streams <1818393> : uri <2830451> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35238 Cc: 35238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > As mentioned in a past commit[1], nil is not an event. > Since the car of a mouse click event is considered its type, > shouldn't (nil) also be rejected as an event? Not sure it's worth the trouble (there are already lots of other objects that aren't events but for which eventp returns non-nil). > Should t be counted as an event? > > (eventp t) ; => t > (eventp '(t)) ; => t Not sure if we ever generate such an event, but what would be the benefit of rejecting it? Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 12 07:11:11 2019 Received: (at 35238) by debbugs.gnu.org; 12 Apr 2019 11:11:11 +0000 Received: from localhost ([127.0.0.1]:55512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEu5P-0004f8-4O for submit@debbugs.gnu.org; Fri, 12 Apr 2019 07:11:11 -0400 Received: from mail-ed1-f44.google.com ([209.85.208.44]:40957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEu5N-0004et-2S for 35238@debbugs.gnu.org; Fri, 12 Apr 2019 07:11:09 -0400 Received: by mail-ed1-f44.google.com with SMTP id d46so3171696eda.7 for <35238@debbugs.gnu.org>; Fri, 12 Apr 2019 04:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=zHMg20rTE4RfySz+MwdNl6SBDv7AVlfIduLUNWMpAWI=; b=xAxS2qkgWk9//gHHysvpfAADRrVcz7Ne3FVtZeYr60Wq5eSx2B5yVTC30DjrO/Xgfm oa+2QAEftlivJ+0FJVYsp7YQi0SsAZuaHOXfgIsGtAxDi+kqnFoZlPej1qjB4+gnM+Gf TRWzOzxowiHmFnuLO9xUPbk8MIGLRq2+P/r8VOYiytKhq2gfiIjkAmsN7yNSgYSdvqvk DE35PoziglkOfmuYw5OW5P+DVpIrR3HAUmFJNockJG4gCyZZgyrFyjHV2C1FeOUH+ONl cSwxEwkP76qUO8zgAtK+VfIOQh4TxPGMsvmldX0ZseJ6N5js6msNeCaFIUAtOaZDJUGZ yCag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=zHMg20rTE4RfySz+MwdNl6SBDv7AVlfIduLUNWMpAWI=; b=lccVecyPgVBZL3albdAO4aMOFJ7KKmUq9wvNpDfQVstg7590gxeZRxTJjdAglhhELH MjG0au1r8C4AMae7DSDFkD2RAA24AuegYFbLXN0lU9ckkCGs35aER1YRw+iqnCm6cj7y XqVCXrZ/oMZ0OuDb5dMkgIY7xJAa9XUPca0BN21CaYyK/VvqQ3WZu2JebFe0nluihwUy 3Mek4xW/aF6LoYCVOfmmZTfnpfJav+A1KN8OsFjJUsR/Gkrm87jCf9TJKLcCZwmAoRyt u6gKQhteoWZq7ofSozETXbqk3bEbf1KNVkPrNvZIb07bIHBcUJ6ZUKyZny72jKxvlt9a Yrvw== X-Gm-Message-State: APjAAAVZLtg8bfFtXgp8rtF5mnnJ0J2V5T+V0TTmm0RYZsFIo0QhI0gD ukYdeHZlgCe3FyxRfbh2DQDnZ0dADYa7xvzO X-Google-Smtp-Source: APXvYqzdX5Na9O3WLoE0lRltKk6ituMa8TpoCPma5HFxe6Rw2WQXBIMMobIdmpFOzRpZtFRip8LQSg== X-Received: by 2002:aa7:c383:: with SMTP id k3mr26879377edq.137.1555067463423; Fri, 12 Apr 2019 04:11:03 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id i91sm4228834edd.72.2019.04.12.04.11.02 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 12 Apr 2019 04:11:02 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Monnier Subject: Re: bug#35238: 27.0.50; Clarify eventp behaviour with booleans References: <87pnpsp3jd.fsf@tcd.ie> Date: Fri, 12 Apr 2019 12:11:01 +0100 In-Reply-To: (Stefan Monnier's message of "Thu, 11 Apr 2019 19:42:46 -0400") Message-ID: <87y34fscl6.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35238 Cc: 35238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Stefan Monnier writes: >> As mentioned in a past commit[1], nil is not an event. >> Since the car of a mouse click event is considered its type, >> shouldn't (nil) also be rejected as an event? > > Not sure it's worth the trouble (there are already lots of other objects > that aren't events but for which eventp returns non-nil). Sure, but the following would at least make eventp treat nil consistently: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=eventp.diff diff --git a/lisp/subr.el b/lisp/subr.el index bdf98979c4..407bd6379d 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -1227,12 +1227,13 @@ listify-key-sequence c))) key))) -(defun eventp (obj) - "True if the argument is an event object." - (when obj - (or (integerp obj) - (and (symbolp obj) obj (not (keywordp obj))) - (and (consp obj) (symbolp (car obj)))))) +(defun eventp (object) + "Return non-nil if OBJECT is an input event or event object." + (or (integerp object) + (and (symbolp (if (consp object) + (setq object (car object)) + object)) + (not (keywordp object))))) (defun event-modifiers (event) "Return a list of symbols representing the modifier keys in event EVENT. --=-=-= Content-Type: text/plain >> Should t be counted as an event? >> >> (eventp t) ; => t >> (eventp '(t)) ; => t > > Not sure if we ever generate such an event, but what would be the > benefit of rejecting it? I don't know, it could even be detrimental; I was just curious. Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 12 08:25:06 2019 Received: (at 35238) by debbugs.gnu.org; 12 Apr 2019 12:25:06 +0000 Received: from localhost ([127.0.0.1]:55573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEvEw-00024Y-3O for submit@debbugs.gnu.org; Fri, 12 Apr 2019 08:25:06 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:36309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEvEt-00024Q-PQ for 35238@debbugs.gnu.org; Fri, 12 Apr 2019 08:25:04 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x3CCP2JE026103; Fri, 12 Apr 2019 08:25:02 -0400 Received: by pastel.home (Postfix, from userid 20848) id 456146AD96; Fri, 12 Apr 2019 08:25:01 -0400 (EDT) From: Stefan Monnier To: "Basil L. Contovounesios" Subject: Re: bug#35238: 27.0.50; Clarify eventp behaviour with booleans Message-ID: References: <87pnpsp3jd.fsf@tcd.ie> <87y34fscl6.fsf@tcd.ie> Date: Fri, 12 Apr 2019 08:25:01 -0400 In-Reply-To: <87y34fscl6.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 12 Apr 2019 12:11:01 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.1 X-NAI-Spam-Rules: 3 Rules triggered GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6523=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6523> : inlines <7052> : streams <1818443> : uri <2830769> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35238 Cc: 35238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Sure, but the following would at least make eventp treat nil > consistently: No objection on my side (nor to the previous patch, FWIW), Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 12 08:31:10 2019 Received: (at 35238) by debbugs.gnu.org; 12 Apr 2019 12:31:10 +0000 Received: from localhost ([127.0.0.1]:55579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEvKn-0002EX-TA for submit@debbugs.gnu.org; Fri, 12 Apr 2019 08:31:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEvKm-0002EK-J7 for 35238@debbugs.gnu.org; Fri, 12 Apr 2019 08:31:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEvKg-0006wM-UM; Fri, 12 Apr 2019 08:31:03 -0400 Received: from [176.228.60.248] (port=2048 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hEvKe-0002dj-JP; Fri, 12 Apr 2019 08:31:01 -0400 Date: Fri, 12 Apr 2019 15:30:42 +0300 Message-Id: <83bm1bmmml.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-reply-to: <87y34fscl6.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#35238: 27.0.50; Clarify eventp behaviour with booleans References: <87pnpsp3jd.fsf@tcd.ie> <87y34fscl6.fsf@tcd.ie> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35238 Cc: 35238@debbugs.gnu.org, monnier@IRO.UMontreal.CA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: "Basil L. Contovounesios" > Date: Fri, 12 Apr 2019 12:11:01 +0100 > Cc: 35238@debbugs.gnu.org > > -(defun eventp (obj) > - "True if the argument is an event object." > - (when obj > - (or (integerp obj) > - (and (symbolp obj) obj (not (keywordp obj))) > - (and (consp obj) (symbolp (car obj)))))) > +(defun eventp (object) > + "Return non-nil if OBJECT is an input event or event object." > + (or (integerp object) > + (and (symbolp (if (consp object) > + (setq object (car object)) > + object)) > + (not (keywordp object))))) Please make sure the ELisp manual is kept in sync. Also, does this need to be called out in NEWS? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 13:53:27 2019 Received: (at 35238) by debbugs.gnu.org; 13 Apr 2019 17:53:27 +0000 Received: from localhost ([127.0.0.1]:59026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFMqF-0005wk-1X for submit@debbugs.gnu.org; Sat, 13 Apr 2019 13:53:27 -0400 Received: from mail-ed1-f49.google.com ([209.85.208.49]:44054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFMqD-0005wX-5F for 35238@debbugs.gnu.org; Sat, 13 Apr 2019 13:53:25 -0400 Received: by mail-ed1-f49.google.com with SMTP id i13so378738edf.11 for <35238@debbugs.gnu.org>; Sat, 13 Apr 2019 10:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=gg5UHCJl8KxZtOnGAN97S6HMxh7jrhtS9ZDXjYtuh9Y=; b=DayDT2E6yvzfkLvqNk6DPoCSWaxBAaCZZSCvOGBJ/H1jb6Nn+eDSyTpqZZTJF+bmZy coeqX2ttpByEgZjMyfBEKema2lfmGOvryLZOU9Yyu2/Ucn33L7Hf5Muy7FK/9FUKru/0 ULJUgbOXiJ0IOEFbsD0gYS77OiM4IBCd2DyCrn9FTnqK/F1wBWotznbmYGCJL8R4naz9 EqVAWzmoD8hRuraVskcsTmO1tUCnbFh/UgNbkcwNRco1CtzHjxJmau1wfu2DcihazjUr T5Xe494hrSyiMsd3GiSyCJMxKOQDspFgbWP6gmZ4NVkkYvTTjMJuGcIU/LUVcbwQt3ps x8VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=gg5UHCJl8KxZtOnGAN97S6HMxh7jrhtS9ZDXjYtuh9Y=; b=ruv6FaVOJzBObWh67PmsJHf43oOwgK9x5iWwYTXrHYy1t3eQw7mZtzo4nJZel20iNB h2i9NzcSBTytSmFkvoihTI1y54d+YLQJXx4AtYGa794t5w7TM62OMOMRNXUjJqEmpk15 PTZ51g00jMzZZZ2eZsDvhc1kx8e2CXcotiQdaAKBCZO0U6pGpdkINDPRqqnAbR5tq+eU 4NVA1GC6Nl9WLnJYrQbK/6FmUuhNsGWTKeFOwcAT1bCjTaOQRmtG60LdfroIzpGulBDd O7DShV3f1pGMMjf+ZW2EaBXFaVBGyVFRKs27Rt6BpEksmepvE/EUOo3J/xkao7KtWnMB 54KA== X-Gm-Message-State: APjAAAWaC9Y53lBv7HZGY+5QFzLETTt8qXLo+7cHOcf5xq+pr5kkobdB NTDul171KKamkVI8ZGAx6rj4Wg== X-Google-Smtp-Source: APXvYqx0wUkaRttq2cqe018npl1M0n5Q7MYHRQMA33n0ZXzYVN9oa94qwenyVL2UglU8P28qRZKybw== X-Received: by 2002:a17:906:a841:: with SMTP id dx1mr33192135ejb.99.1555177999362; Sat, 13 Apr 2019 10:53:19 -0700 (PDT) Received: from localhost ([86.43.103.106]) by smtp.gmail.com with ESMTPSA id c38sm757684ede.61.2019.04.13.10.53.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 13 Apr 2019 10:53:18 -0700 (PDT) From: "Basil L. Contovounesios" To: Eli Zaretskii Subject: Re: bug#35238: 27.0.50; Clarify eventp behaviour with booleans References: <87pnpsp3jd.fsf@tcd.ie> <87y34fscl6.fsf@tcd.ie> <83bm1bmmml.fsf@gnu.org> Date: Sat, 13 Apr 2019 18:53:12 +0100 In-Reply-To: <83bm1bmmml.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Apr 2019 15:30:42 +0300") Message-ID: <87zhothjw7.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35238 Cc: 35238@debbugs.gnu.org, monnier@IRO.UMontreal.CA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Please make sure the ELisp manual is kept in sync. While skimming the manual, I came across recent-keys in (info "(elisp) Recording Input"). Stefan extended this function in Emacs 25.1[1] with an optional argument INCLUDE-CMDS which causes it to output "events of the form (nil . COMMAND)". (The manual wasn't updated to document this alternative behaviour, but I can do that in addition to / instead of the eventp change if one of ye doesn't beat me to it.) The question is, should eventp continue returning non-nil for these events of the form (nil . COMMAND)? Or should recent-keys be changed to return a different form of event? If my assumption is correct that the former option is preferred, I will check that the manual documents such events consistently instead of changing the behaviour of eventp. Note that (seq-every-p #'eventp (recent-keys t)) is currently non-nil, and the only caller that specifies INCLUDE-CMDS non-nil is view-lossage, which doesn't rely on eventp. [1: eca1ea9655]: * lisp/help.el (view-lossage): ... 2014-11-09 21:58:52 -0500 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=eca1ea96559e04e18a62a61208d501c557dd4cab > Also, does this need to be called out in NEWS? Depends on what actually ends up needing to be changed, I think. My original intention to treat events of the form (nil ...) as nil now seems less plausible, so the only changes I foresee are docfixes. Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 23:13:28 2019 Received: (at 35238) by debbugs.gnu.org; 14 Apr 2019 03:13:28 +0000 Received: from localhost ([127.0.0.1]:59631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFVaB-0000iZ-OV for submit@debbugs.gnu.org; Sat, 13 Apr 2019 23:13:27 -0400 Received: from pmta11.teksavvy.com ([76.10.157.34]:41157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFVa9-0000iM-HK for 35238@debbugs.gnu.org; Sat, 13 Apr 2019 23:13:26 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2GXDwA/pLJc//zyd0tmH4NfKoFaEoNuh?= =?us-ascii?q?HqESYouggwTIgGaDRCEZAMEAgKFdiQ4EwEDAQEBCQEBAQECAgJpKIVMAQQBViM?= =?us-ascii?q?FCws0EhQYDSSCakuBeg+sPYongTKLYYF/hCM+iiUDpjIJggeSMYF4AYlYiSKgH?= =?us-ascii?q?QyBZiKBVjMaCDCDKJBnJpEiAQE?= X-IPAS-Result: =?us-ascii?q?A2GXDwA/pLJc//zyd0tmH4NfKoFaEoNuhHqESYouggwTIgG?= =?us-ascii?q?aDRCEZAMEAgKFdiQ4EwEDAQEBCQEBAQECAgJpKIVMAQQBViMFCws0EhQYDSSCa?= =?us-ascii?q?kuBeg+sPYongTKLYYF/hCM+iiUDpjIJggeSMYF4AYlYiSKgHQyBZiKBVjMaCDC?= =?us-ascii?q?DKJBnJpEiAQE?= X-IronPort-AV: E=Sophos;i="5.60,347,1549947600"; d="scan'208";a="92307211" Received: from 75-119-242-252.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([75.119.242.252]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2019 23:13:19 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 89561AE526; Sat, 13 Apr 2019 23:13:19 -0400 (EDT) From: Stefan Monnier To: "Basil L. Contovounesios" Subject: Re: bug#35238: 27.0.50; Clarify eventp behaviour with booleans Message-ID: References: <87pnpsp3jd.fsf@tcd.ie> <87y34fscl6.fsf@tcd.ie> <83bm1bmmml.fsf@gnu.org> <87zhothjw7.fsf@tcd.ie> Date: Sat, 13 Apr 2019 23:13:19 -0400 In-Reply-To: <87zhothjw7.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 13 Apr 2019 18:53:12 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 35238 Cc: Eli Zaretskii , 35238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > The question is, should eventp continue returning non-nil for these > events of the form (nil . COMMAND)? I don't think we need to consider them as events. More specifically, recent-keys uses this representation for the execution of a command because it expects that no event would have such a shape. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 19:20:03 2019 Received: (at 35238) by debbugs.gnu.org; 22 Apr 2019 23:20:03 +0000 Received: from localhost ([127.0.0.1]:51876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIiED-0003IE-V0 for submit@debbugs.gnu.org; Mon, 22 Apr 2019 19:20:02 -0400 Received: from mail-ed1-f42.google.com ([209.85.208.42]:33898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIiEB-0003Hq-GU for 35238@debbugs.gnu.org; Mon, 22 Apr 2019 19:20:00 -0400 Received: by mail-ed1-f42.google.com with SMTP id a6so10943976edv.1 for <35238@debbugs.gnu.org>; Mon, 22 Apr 2019 16:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=sjjJV9iC1U1d1RiYs5kAn+h3hFBmCMnlHTXqhShNdP0=; b=1kA1XHkCjRctiN+xXmTcRyzphCaET9OSpeN/jdKjn+nRE/p2IsBgvJpdzkvcEePbOf DKnTgYWsQRmsvY9G+AcNHTwSN5+Fr5BoxjPa1ymQ4e53rodrsdjdxbMqv4uii9uQzDIN 96p0Lx/OWgueOYYQrSrTqZ3XVNFarPjphQEPoBzyx2BFcv5T7liRQA50WkaMB8+uflBg 770HCztJ1NQWwgMHfWEqjJfvnVAU0abGA+mSAwuvfQyMXvGLcz93Hlv9d8mU5sfAInIf EzrNdibFnyWlx3obD/k5Co0tpzmCk27YP+xZAHJkRc/4VSnnQDtfR5m2ilETXDXaoxVZ 5CNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=sjjJV9iC1U1d1RiYs5kAn+h3hFBmCMnlHTXqhShNdP0=; b=tXa5ztkI+3atOL76TMxsqYlF3Uueqj881RyolOm7oiVknvHbZzuTTQASV9TbMBLxDG I0oKLp/EhH5wXhJHEdqSSEnmFoAI6H/DnEMDcmwW4wpUz3UURjwm2hQgL/7ckHvKD3II fvwnsPoEBfRN7G+iteOC0nxPeLyHXkGbJaciSV8wRa/r70+npXrqGRIP3DDKaVY2vUHH +3LNuiiqxfAgsAMJozO31YUnSzuolmRoIMwQjHOEHDTxafdKa+1BFb9yc0uEY+y1qPei Z37+Wz5PHxwTSti0T0MncCSpnk/mxnoBOtbuZrIx5gODkNiI9F1RxMEEoQMWIkTccxkr C6gQ== X-Gm-Message-State: APjAAAWsPNlACprAKRXn0r7RvoNdCJiXKsKwtwIUwWXAUG+xR+pyGvHL sIvcNiCwgTWrKyDbJgm657iYUiypE8k8KQ== X-Google-Smtp-Source: APXvYqwlNtG2BkCt6qYtXeGXHKWU2jrIja4/7pmR8xFZuPhRXXAhr1ZnSBtNE8ucmMMFpotmP5v6pw== X-Received: by 2002:a50:ac72:: with SMTP id w47mr13811238edc.127.1555975193776; Mon, 22 Apr 2019 16:19:53 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:8f5:8e00:4345:7c72]) by smtp.gmail.com with ESMTPSA id p7sm3953383eds.81.2019.04.22.16.19.51 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 22 Apr 2019 16:19:52 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Monnier Subject: Re: bug#35238: 27.0.50; Clarify eventp behaviour with booleans References: <87pnpsp3jd.fsf@tcd.ie> <87y34fscl6.fsf@tcd.ie> <83bm1bmmml.fsf@gnu.org> <87zhothjw7.fsf@tcd.ie> Date: Tue, 23 Apr 2019 00:19:45 +0100 In-Reply-To: (Stefan Monnier's message of "Sat, 13 Apr 2019 23:13:19 -0400") Message-ID: <87a7gh39wu.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 35238 Cc: Eli Zaretskii , 35238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) --=-=-= Content-Type: text/plain Stefan Monnier writes: >> The question is, should eventp continue returning non-nil for these >> events of the form (nil . COMMAND)? > > I don't think we need to consider them as events. > More specifically, recent-keys uses this representation for the > execution of a command because it expects that no event would have such > a shape. OK, then how's the following? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Clarify-what-constitutes-an-event-bug-35238.patch >From 62f82c31406b9ea3ca59258bba9663184b8d5734 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sun, 21 Apr 2019 23:02:01 +0100 Subject: [PATCH] Clarify what constitutes an event (bug#35238) * doc/lispref/commands.texi (Input Events): Specify that events are non-nil and remove vestiges of bug#10190. * doc/lispref/os.texi (Recording Input): Document optional argument of recent-keys. * lisp/subr.el (eventp): Check that the car of conses is non-nil. * etc/NEWS: Announce it as an incompatible change. * src/keyboard.c (Frecent_keys): Clarify that returned "events" are not real events. --- doc/lispref/commands.texi | 9 +++------ doc/lispref/os.texi | 7 ++++++- etc/NEWS | 5 +++++ lisp/subr.el | 14 ++++++++------ src/keyboard.c | 2 +- 5 files changed, 23 insertions(+), 14 deletions(-) diff --git a/doc/lispref/commands.texi b/doc/lispref/commands.texi index cd44c1c87e..5ea0be2667 100644 --- a/doc/lispref/commands.texi +++ b/doc/lispref/commands.texi @@ -1047,12 +1047,9 @@ Input Events This function returns non-@code{nil} if @var{object} is an input event or event type. -Note that any symbol might be used as an event or an event type. -@code{eventp} cannot distinguish whether a symbol is intended by Lisp -code to be used as an event. Instead, it distinguishes whether the -symbol has actually been used in an event that has been read as input in -the current Emacs session. If a symbol has not yet been so used, -@code{eventp} returns @code{nil}. +Note that any non-@code{nil} symbol might be used as an event or an +event type; @code{eventp} cannot distinguish whether a symbol is +intended by Lisp code to be used as an event. @end defun @menu diff --git a/doc/lispref/os.texi b/doc/lispref/os.texi index 59cd5a8fe8..fef954eb7a 100644 --- a/doc/lispref/os.texi +++ b/doc/lispref/os.texi @@ -2197,7 +2197,7 @@ Recording Input @subsection Recording Input @cindex recording input -@defun recent-keys +@defun recent-keys &optional include-cmds This function returns a vector containing the last 300 input events from the keyboard or mouse. All input events are included, whether or not they were used as parts of key sequences. Thus, you always get the last @@ -2205,6 +2205,11 @@ Recording Input (These are excluded because they are less interesting for debugging; it should be enough to see the events that invoked the macros.) +If @var{include-cmds} is non-@code{nil}, complete key sequences in the +result vector are interleaved with pseudo-events of the form +@code{(nil . @var{COMMAND})}, where @var{COMMAND} is the binding of +the key sequence (@pxref{Command Overview}). + A call to @code{clear-this-command-keys} (@pxref{Command Loop Info}) causes this function to return an empty vector immediately afterward. @end defun diff --git a/etc/NEWS b/etc/NEWS index b13ab47768..76943391bc 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1526,6 +1526,11 @@ performs (setq-local indent-line-function #'indent-relative). ** 'make-process' no longer accepts a non-nil ':stop' key. This has never worked reliably, and now causes an error. ++++ +** 'eventp' no longer returns non-nil for lists whose car is nil. +This is consistent with the fact that nil, though a symbol, is not a +valid event type. + * Lisp Changes in Emacs 27.1 diff --git a/lisp/subr.el b/lisp/subr.el index f68f9dd419..be21dc67a0 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -1238,12 +1238,14 @@ listify-key-sequence c))) key))) -(defun eventp (obj) - "True if the argument is an event object." - (when obj - (or (integerp obj) - (and (symbolp obj) obj (not (keywordp obj))) - (and (consp obj) (symbolp (car obj)))))) +(defun eventp (object) + "Return non-nil if OBJECT is an input event or event object." + (or (integerp object) + (and (if (consp object) + (setq object (car object)) + object) + (symbolp object) + (not (keywordp object))))) (defun event-modifiers (event) "Return a list of symbols representing the modifier keys in event EVENT. diff --git a/src/keyboard.c b/src/keyboard.c index dff8f6b2fc..6d3030644a 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -9966,7 +9966,7 @@ If CHECK-TIMERS is non-nil, timers that are ready to run will do so. */) DEFUN ("recent-keys", Frecent_keys, Srecent_keys, 0, 1, 0, doc: /* Return vector of last few events, not counting those from keyboard macros. If INCLUDE-CMDS is non-nil, include the commands that were run, -represented as events of the form (nil . COMMAND). */) +represented as pseudo-events of the form (nil . COMMAND). */) (Lisp_Object include_cmds) { bool cmds = !NILP (include_cmds); -- 2.20.1 --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 22:06:48 2019 Received: (at 35238) by debbugs.gnu.org; 23 Apr 2019 02:06:48 +0000 Received: from localhost ([127.0.0.1]:52039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIkpc-0000va-8C for submit@debbugs.gnu.org; Mon, 22 Apr 2019 22:06:48 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:42951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIkpZ-0000vP-Ae for 35238@debbugs.gnu.org; Mon, 22 Apr 2019 22:06:47 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x3N26gk0030733; Mon, 22 Apr 2019 22:06:43 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 8A94566184; Mon, 22 Apr 2019 22:06:41 -0400 (EDT) From: Stefan Monnier To: "Basil L. Contovounesios" Subject: Re: bug#35238: 27.0.50; Clarify eventp behaviour with booleans Message-ID: References: <87pnpsp3jd.fsf@tcd.ie> <87y34fscl6.fsf@tcd.ie> <83bm1bmmml.fsf@gnu.org> <87zhothjw7.fsf@tcd.ie> <87a7gh39wu.fsf@tcd.ie> Date: Mon, 22 Apr 2019 22:06:41 -0400 In-Reply-To: <87a7gh39wu.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 23 Apr 2019 00:19:45 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.1 X-NAI-Spam-Rules: 3 Rules triggered GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6530=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6530> : inlines <7058> : streams <1819452> : uri <2835930> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35238 Cc: Eli Zaretskii , 35238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > OK, then how's the following? LGTM Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue May 07 13:08:39 2019 Received: (at control) by debbugs.gnu.org; 7 May 2019 17:08:39 +0000 Received: from localhost ([127.0.0.1]:59465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hO3a2-0000gh-QY for submit@debbugs.gnu.org; Tue, 07 May 2019 13:08:39 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:46649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hO3a0-0000gJ-Ml for control@debbugs.gnu.org; Tue, 07 May 2019 13:08:37 -0400 Received: by mail-wr1-f50.google.com with SMTP id r7so23352806wrr.13 for ; Tue, 07 May 2019 10:08:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EECg1Wv9yDf4L2SVw+QTAvC+0W9MsY1X8MeeMvBcZVc=; b=BvgrDRP1tuYxDuIAkv9UlThbc91bEBlON4Jrwhv8cz+B80CfWzroY75glGOZJpBqH9 icqbCX88LCkkpj8yt9GxOA2YMiMWRsIGExXGIUNEHCBDbg9ikcdDfxDlZQ1F0vPvfICc PpOiGSukBDLc5z8tSxp8lMYFFnuB0yChweWYjwC7nEymtchzg3l2zyo7owbwn6VraY6R h9d1L8sWAYs+cI41kOa98ksKcmbVxwKyYI7dUPv5Hpc6cOr5i65lBpeUjCPxm2opXRUW 7Rwx5MrJh4Arrdi8YpKhvlveIP0B2bWpdXLt6NRFJX2rVNLUtYXP/FfQocwROZO/jnwK tXjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=EECg1Wv9yDf4L2SVw+QTAvC+0W9MsY1X8MeeMvBcZVc=; b=mPKeJuo0ogDIOtdC258r4pcBX0CRFTR1HJj9M3viUsQA6RhPkvUJQErNqmH8MUPC7A Brn8oIS1ED4gsyXpaUc/YTcD1G5HYQlVtFRW4A29+++C5tLOh/AAIp72M3oe4jLkWuki +W2voYtSFlK4xTG9B0MBl1RoutYEu4MvHQPcW3XCLTlN7hynHv01aS9bscOF/yAV+07f J/wc6+L0pXSfKzYwRbgbqbuBmrQOzAbUkbrvQ37dWcVbSssM27ZTcINnRhRLhFvSC2PC mDXttYNEBKZjkLmOHLFmbSHAvH7vt03MEITtadx4jMYPHwGRpLADUgz/3dBUne+1qmSf tHMg== X-Gm-Message-State: APjAAAWIvzz2DER/tBHxlMTvG9jW3/YTJcgwZ7xCx3DiUQNPwQHVrlJM Suxp6P/Q8WhCeblNTGCb1eKCoA== X-Google-Smtp-Source: APXvYqzGpvoYvhaK+Qztdjnw7IFM/mrlLjuuS7lkA3+yCbH+JbNpYh91L0gOC2NJLYxJfp0y0h0dFQ== X-Received: by 2002:a5d:4348:: with SMTP id u8mr24744822wrr.129.1557248909516; Tue, 07 May 2019 10:08:29 -0700 (PDT) Received: from localhost ([163.172.211.46]) by smtp.gmail.com with ESMTPSA id z17sm13599292wrm.33.2019.05.07.10.08.27 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 07 May 2019 10:08:28 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Monnier Subject: Re: bug#35238: 27.0.50; Clarify eventp behaviour with booleans References: <87pnpsp3jd.fsf@tcd.ie> <87y34fscl6.fsf@tcd.ie> <83bm1bmmml.fsf@gnu.org> <87zhothjw7.fsf@tcd.ie> <87a7gh39wu.fsf@tcd.ie> Date: Tue, 07 May 2019 18:08:26 +0100 In-Reply-To: (Stefan Monnier's message of "Mon, 22 Apr 2019 22:06:41 -0400") Message-ID: <87imum2nw5.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: Eli Zaretskii , 35238-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35238 fixed close 35238 quit Stefan Monnier writes: >> OK, then how's the following? > > LGTM Thanks, I pushed to master[1] and am therefore closing this report. [1: c972da907d]: Clarify what constitutes an event (bug#35238) 2019-05-07 18:00:20 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c972da907d494b6d5efd423aa3b5d0b23f7b7801 -- Basil From unknown Sat Jun 14 19:00:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 05 Jun 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator