From unknown Tue Jun 17 01:48:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: yamaoka@jpl.org, eric@ericabrahamsen.net, bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 11 Apr 2019 16:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35233 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: To: 35233@debbugs.gnu.org Cc: Katsumi Yamaoka , Eric Abrahamsen X-Debbugs-Original-To: submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys) X-Debbugs-Original-Xcc: Katsumi Yamaoka , Eric Abrahamsen Received: via spool by submit@debbugs.gnu.org id=B.15550016894962 (code B ref -1); Thu, 11 Apr 2019 16:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Apr 2019 16:54:49 +0000 Received: from localhost ([127.0.0.1]:55110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEcyN-0001Hw-Qf for submit@debbugs.gnu.org; Thu, 11 Apr 2019 12:54:49 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:43413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEcyK-0001He-P3 for submit@debbugs.gnu.org; Thu, 11 Apr 2019 12:54:45 -0400 Received: by mail-ed1-f68.google.com with SMTP id w3so5817977edu.10 for ; Thu, 11 Apr 2019 09:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:user-agent:mime-version; bh=sEj6Eiy83pbHwFu1A+55V/eepaAmqWasoEhP5eIZXD4=; b=QVy5NH4oXwhsP8r0dTDIB1l5+7ze2pZ/wSa8BLdhGz/vDRO38OiGgQf8F7g8nwrhcr 1NnN97BfKHkDg8f0u5KbSaqMwZoB+LoMce62z1y3ofCb+6LdMoIyOA0ymYihSHsi8kMm 9DjoeSM1bXo+MQ73cnKSH4d4rEYC8Q2yubUVlzgKo0KAnXb5RvS+by3e1bYJQSFpBSkx LF30mDfGg8/Q4qP/I0SiAZBoM2fOBkdxjXDPhhUJpCjjWDIXkHQiZIQsB63jl9Xhz51H kAsrMta3P0MlXClLU22w0G4BYyCBn38J0/EuSWo4N2A3ofZy4USlUpWK+eJUFmUArPuh Ekhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=sEj6Eiy83pbHwFu1A+55V/eepaAmqWasoEhP5eIZXD4=; b=Dq5tMgspPWD1wqwAELpF7AcJOOvpUrsMS71fSZl4m19bWazAeXytXDO4coN/zasJkw ADTyOgBSB6CU359l7Z0/z9cp4bNZB+aH+IUZVb0ql4+2Xv189K9HdrfBH8CSYRDkAokW gPbmGe2G3lNabogiHESYD4sCrpfaa/zXo6biWihxXrlO0RTTwLaqNwxKIZI7jQyIWikV LoT+mcjEkvcX91ykiWwslQB12+l6QSBqMDxwrAeByLNJs4Qwyfj1S3G7KQfQz46HpPII /qYvv6Mtnc4fFjsJJ1a7huy/Wg1MRywjxgrf+dDu6GgNQFoBtgOX4kcX9evi+aY5Zf/z h61Q== X-Gm-Message-State: APjAAAUxE7jEOPcYbD0ioko5eY4GMQM3eGelu3PgiiPZoVdM+31iYqx3 MF+uoE2ide87vQnRiyR9o5A1iftIWYXIGA== X-Google-Smtp-Source: APXvYqwX2YxKxjRhSSqAkdm+A2TKk1yZBebGewwUBhpVt5v8DpqxzDq2taRoiljdWDz+qqkunL/iww== X-Received: by 2002:a50:8985:: with SMTP id g5mr11240762edg.65.1555001678184; Thu, 11 Apr 2019 09:54:38 -0700 (PDT) Received: from localhost ([163.172.211.46]) by smtp.gmail.com with ESMTPSA id 10sm1591721ejn.37.2019.04.11.09.54.36 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 11 Apr 2019 09:54:37 -0700 (PDT) From: "Basil L. Contovounesios" Date: Thu, 11 Apr 2019 17:54:25 +0100 Message-ID: <87d0ls32ke.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The recent move to hash-tables[1] introduced the following regression: 0. HOME=$(mktemp -d) emacs -Q 1. (setq gnus-select-method '(nntp "news.gwene.org")) C-j 2. M-x gnus RET s M-d Wrong number of arguments: #, 1 Passing string-lessp to sort further leads to the following: 3. Steps 0-2 as above. Wrong type argument: vectorp, #s(hash-table ...) Replacing (intern group gnus-description-hashtb) with just group, and repeating steps 0-2 as above, reveals that gnus-group-describe-all-groups inserts the group name twice, rather than the group name followed by its description. This regression predates the move to hash-tables[2]. [1: c1b63af445]: Change Gnus hash tables into real hash tables 2019-03-22 10:23:30 -0700 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c1b63af4458e92bad33da0def2b15c206656e2fa [2: 3982245371]: Sort groups before inserting them into the group buffer 2016-02-13 18:45:11 +1100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3982245371c0b8e17b4d96d16ed4b1d87c0ffc25 Patch fixing these to follow. -- Basil Gnus v5.13 In GNU Emacs 27.0.50 (build 9, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2019-04-11 built on thunk Repository revision: 0627a8d7bc6ffa29d7a503fd36e760778ecb9fa1 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: Debian GNU/Linux buster/sid From unknown Tue Jun 17 01:48:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 11 Apr 2019 17:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35233 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: To: 35233@debbugs.gnu.org Cc: Eric Abrahamsen , Katsumi Yamaoka Received: via spool by 35233-submit@debbugs.gnu.org id=B35233.15550020115550 (code B ref 35233); Thu, 11 Apr 2019 17:01:01 +0000 Received: (at 35233) by debbugs.gnu.org; 11 Apr 2019 17:00:11 +0000 Received: from localhost ([127.0.0.1]:55121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEd3b-0001RN-9W for submit@debbugs.gnu.org; Thu, 11 Apr 2019 13:00:11 -0400 Received: from mail-ed1-f51.google.com ([209.85.208.51]:38527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEd3W-0001PG-Jb for 35233@debbugs.gnu.org; Thu, 11 Apr 2019 13:00:09 -0400 Received: by mail-ed1-f51.google.com with SMTP id d13so5858063edr.5 for <35233@debbugs.gnu.org>; Thu, 11 Apr 2019 10:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dd3uhxdpPyuIS3o6dlWDrSirHFBbrbiHKvgbGRWnE4c=; b=vgifLwi539Vn7DVOLW+rGbFpTRXWle9imwb793eLst0YNNKT6BGz6ZxH0vTTqCfjZQ FMu9K6RYNkG1M6yF/qtAd00F+9fgTFQMybw4TLfW7gGzyfTogmqGWXbvIAMAJDw8B4J2 t72mzjnfFit+jo1CoXNh8uPqrec/ApIwQiAadB+P4PxqudGscO7XtEpkQDut1i1AsR+r ospGaMAeEej+9QupT6yd3uDmuEISrmz33rQ8BINIpNgTuQ6QNt4BTW0wevGXCOe1DKci qAdYKbwl34BCJVPN6nh9nagCMGKYct2BRMscy7pjRBrn3tHJDat1O1emo2dXxNNzqoS0 IYuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=dd3uhxdpPyuIS3o6dlWDrSirHFBbrbiHKvgbGRWnE4c=; b=MlhKAWFCUQHR7gDvM6lOgyILNA2Pr3iMLXhcQDNsSKcP21WmxR/sfSHqNDDjRo4Pzt eCsH6TyUG6AAIDuyG7yF0nwEgeVDiCL3Cn3UYAx+EOsBFNHdatAVhFlaXkxgP2JMgPRg vNc27KsRCKt7OiKn08RZFwcj+890dFNZsjX5l6L4zgfLuIbXqr1TXLuxLTKNhHYSQhI4 qVhXKr2trOESgMyyi2ypra4sSkvyYIVisDEV7BgC+NZpB1UHqnxKZ8DWOuXDHM1r+cTB /O3032W88UhbwvYGpkoW7cCOvsYCEQzXPzJqmbco3lS3eKPpP5YQj28F8Z4JMosEGdC9 FnIA== X-Gm-Message-State: APjAAAXLKPuwDiElRn3di1Vs2R3iv0OW3gLoHpQMBPdcRUteIyRSwvzd D8BJCMDZ0wtuNp/cxpVJfjQtuZgUzGKPQ99y X-Google-Smtp-Source: APXvYqw8LExEouR0PXAIdAXkmGUt7Skt+l+QMUxj4jblElxAm7pIuymMRe1kb5vq9lSH5nV/7XDvNA== X-Received: by 2002:aa7:d6cb:: with SMTP id x11mr30989297edr.85.1555002000624; Thu, 11 Apr 2019 10:00:00 -0700 (PDT) Received: from localhost ([163.172.211.46]) by smtp.gmail.com with ESMTPSA id 63sm1102742edn.32.2019.04.11.09.59.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 11 Apr 2019 09:59:59 -0700 (PDT) From: "Basil L. Contovounesios" References: <87d0ls32ke.fsf@tcd.ie> Date: Thu, 11 Apr 2019 17:59:52 +0100 In-Reply-To: <87d0ls32ke.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 11 Apr 2019 17:54:25 +0100") Message-ID: <877ec032bb.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 35233 patch quit --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-gnus-group-describe-all-groups-bug-35233.patch >From 6402b26d5fb0340b90cd5647a6799fff2cb35e43 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Thu, 11 Apr 2019 17:16:00 +0100 Subject: [PATCH] Fix gnus-group-describe-all-groups (bug#35233) This fixes oversights from 2018-04-26T16:26:27-07:00!eric@ericabrahamsen.net and 2016-02-13T18:45:11+11:00!larsi@gnus.org. * lisp/gnus/gnus-group.el (gnus-group-describe-all-groups): Insert group name and description instead of group name twice. Do not pass a hash-table to intern. Call sort with correct number of arguments. --- lisp/gnus/gnus-group.el | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el index 144496bdd2..e1554cab8a 100644 --- a/lisp/gnus/gnus-group.el +++ b/lisp/gnus/gnus-group.el @@ -4149,20 +4149,19 @@ gnus-group-describe-all-groups (when (not (or gnus-description-hashtb (gnus-read-all-descriptions-files))) (error "Couldn't request descriptions file")) - (let ((buffer-read-only nil) - (groups (sort (hash-table-keys gnus-description-hashtb))) - b) + (let ((buffer-read-only nil)) (erase-buffer) - (dolist (group groups) - (setq b (point)) - (let ((charset (gnus-group-name-charset nil group))) + (dolist (group (sort (hash-table-keys gnus-description-hashtb) #'string<)) + (let ((b (point)) + (desc (gethash group gnus-description-hashtb)) + (charset (gnus-group-name-charset nil group))) (insert (format " *: %-20s %s\n" (gnus-group-name-decode group charset) - (gnus-group-name-decode group charset)))) - (add-text-properties - b (1+ b) (list 'gnus-group (intern group gnus-description-hashtb) - 'gnus-unread t 'gnus-marked nil - 'gnus-level (1+ gnus-level-subscribed)))) + (gnus-group-name-decode desc charset))) + (add-text-properties + b (1+ b) (list 'gnus-group group + 'gnus-unread t 'gnus-marked nil + 'gnus-level (1+ gnus-level-subscribed))))) (goto-char (point-min)) (gnus-group-position-point))) -- 2.20.1 --=-=-= Content-Type: text/plain "Basil L. Contovounesios" writes: > Patch fixing these to follow. I attach said patch. Thanks, -- Basil --=-=-=-- From unknown Tue Jun 17 01:48:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 11 Apr 2019 17:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35233 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch To: "Basil L. Contovounesios" Cc: Katsumi Yamaoka , 35233@debbugs.gnu.org Received: via spool by 35233-submit@debbugs.gnu.org id=B35233.155500543318815 (code B ref 35233); Thu, 11 Apr 2019 17:58:01 +0000 Received: (at 35233) by debbugs.gnu.org; 11 Apr 2019 17:57:13 +0000 Received: from localhost ([127.0.0.1]:55142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEdwm-0004tO-Rs for submit@debbugs.gnu.org; Thu, 11 Apr 2019 13:57:13 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:58416 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEdwk-0004tB-9m for 35233@debbugs.gnu.org; Thu, 11 Apr 2019 13:57:11 -0400 Received: from localhost (97-126-87-168.tukw.qwest.net [97.126.87.168]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 4CEFBFA05C; Thu, 11 Apr 2019 17:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1555005424; bh=7/19vHHPMPvFSxpDngmh7hEGqqwehqyjcZ22qatZYHs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZI5G8qnH4nOL9Xfbna/TuuZA0TaI2ExpPn2iJu7y3M1u1s24mCA3AebIN0M610ipp apaOoDHS1ed6SFqtPqlHjmPwZETP6OsieVXqO/7iSQMEC6w92UgobtxMSiLIkeQM+3 s4Nk6F5rUSAfQaC8ZCVltvUy2E4c+7cqGjqGMs34= From: Eric Abrahamsen References: <87d0ls32ke.fsf@tcd.ie> Date: Thu, 11 Apr 2019 10:57:03 -0700 In-Reply-To: <87d0ls32ke.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 11 Apr 2019 17:54:25 +0100") Message-ID: <87v9zke87k.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > The recent move to hash-tables[1] introduced the following regression: > > 0. HOME=$(mktemp -d) emacs -Q > 1. (setq gnus-select-method '(nntp "news.gwene.org")) C-j > 2. M-x gnus RET s M-d > Wrong number of arguments: #, 1 > > Passing string-lessp to sort further leads to the following: > > 3. Steps 0-2 as above. > Wrong type argument: vectorp, #s(hash-table ...) > > Replacing (intern group gnus-description-hashtb) with just group, and > repeating steps 0-2 as above, reveals that > gnus-group-describe-all-groups inserts the group name twice, rather than > the group name followed by its description. This regression predates > the move to hash-tables[2]. > > [1: c1b63af445]: Change Gnus hash tables into real hash tables > 2019-03-22 10:23:30 -0700 > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c1b63af4458e92bad33da0def2b15c206656e2fa > > [2: 3982245371]: Sort groups before inserting them into the group buffer > 2016-02-13 18:45:11 +1100 > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3982245371c0b8e17b4d96d16ed4b1d87c0ffc25 > > Patch fixing these to follow. Ugh, thank you for catching those very stupid mistakes! From unknown Tue Jun 17 01:48:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 11 Apr 2019 20:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35233 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch To: Eric Abrahamsen Cc: Katsumi Yamaoka , 35233@debbugs.gnu.org Received: via spool by 35233-submit@debbugs.gnu.org id=B35233.155501293831181 (code B ref 35233); Thu, 11 Apr 2019 20:03:02 +0000 Received: (at 35233) by debbugs.gnu.org; 11 Apr 2019 20:02:18 +0000 Received: from localhost ([127.0.0.1]:55195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEftq-00086q-1G for submit@debbugs.gnu.org; Thu, 11 Apr 2019 16:02:18 -0400 Received: from mail-ed1-f51.google.com ([209.85.208.51]:41866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEftn-00086X-H7 for 35233@debbugs.gnu.org; Thu, 11 Apr 2019 16:02:16 -0400 Received: by mail-ed1-f51.google.com with SMTP id g6so2367597edc.8 for <35233@debbugs.gnu.org>; Thu, 11 Apr 2019 13:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SpHwKxLKlHpVf6Vq0HUggaSXZ6liMLfUYikanTa7Bdc=; b=AS+yovAeFugK4M79xdIwYm7w8z89lwDd2mnZEZS5RvI6EJQ8Fh15PpSG3+H+og7fcL NNvA+WGnZ/fvdkNU8k77/traiasYLE/gcJUTr4jk+RTSvLkTQcI4LNhkIHHHDkhqxjED A+lA5eN4XbwGxPBjzj1ihQ1bKtOHcMFvV8dmafkUlZCaQOXVs3TyJL544tEmFO7xnzLX b/ylSFxhxyepnHZxiikZLjXJl+z7FkI8P4qm+fm/kixhCczlJjbFSk2/NKv7xrV4n/n8 XsIgbfnNwKZ0mJKuQxHWKrqvHP4Mj0iBakDt5WTnj4gIiSdX9STTJOrwhHnBFnFQdprw R/HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=SpHwKxLKlHpVf6Vq0HUggaSXZ6liMLfUYikanTa7Bdc=; b=DyKgD+YkrwkfzLgTXHA450346CA6LZ0hb3SVjPSlj9ZbNnrmkQfRsd3A9fWe8DHvP0 2X9alwhE2D4pFUcfog30flHKNO00nq1NUEMdBay4CWpHK9bUGwYeGH6OXlL++bdeYU6h YilrLWO+woLPV7YztSnlT1kF8OOdqg0WySgg5VfVUp8eB+bG2d0pSP761D8WrQ3uRglf jQKp4buWrTGl5Qm7bHZDhihWX8ODdGOpnngjKpW60TDVx1Il9LY2G6hk74H8XAhyla5k fc2Iq+chPofOuEGKa4segPPnkW6qNUu7uXWLGqE8kL8dKbqGTZuebqcBE/tzs6myLYfs 57KQ== X-Gm-Message-State: APjAAAW6u/uM+gqTD/t8Ee1yNc3O7b9bRy5X6yK/smXcD41GQracnb7r x2IxQrv4sgUhOGlbe/w8RsAaSg== X-Google-Smtp-Source: APXvYqwPSSsVRcl1jkQa43orBKW++PTotJL4cqzfsxKugmAF/obsHuQyHbhkGCSmUnVW+/XqBkNmOg== X-Received: by 2002:a50:cf49:: with SMTP id d9mr33510791edk.214.1555012929824; Thu, 11 Apr 2019 13:02:09 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id l44sm11815510edb.37.2019.04.11.13.02.08 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 11 Apr 2019 13:02:08 -0700 (PDT) From: "Basil L. Contovounesios" References: <87d0ls32ke.fsf@tcd.ie> <87v9zke87k.fsf@ericabrahamsen.net> Date: Thu, 11 Apr 2019 21:02:07 +0100 In-Reply-To: <87v9zke87k.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 11 Apr 2019 10:57:03 -0700") Message-ID: <87h8b4tio0.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > "Basil L. Contovounesios" writes: > >> Patch fixing these to follow. > > Ugh, thank you for catching those very stupid mistakes! No worries, I take that as permission to push (after waiting a day or two). :) Thanks, -- Basil From unknown Tue Jun 17 01:48:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 11 Apr 2019 20:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35233 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch To: "Basil L. Contovounesios" Cc: Katsumi Yamaoka , 35233@debbugs.gnu.org Received: via spool by 35233-submit@debbugs.gnu.org id=B35233.15550153362246 (code B ref 35233); Thu, 11 Apr 2019 20:43:02 +0000 Received: (at 35233) by debbugs.gnu.org; 11 Apr 2019 20:42:16 +0000 Received: from localhost ([127.0.0.1]:55203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEgWW-0000aA-8l for submit@debbugs.gnu.org; Thu, 11 Apr 2019 16:42:16 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:59122 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEgWT-0000Zw-FK for 35233@debbugs.gnu.org; Thu, 11 Apr 2019 16:42:14 -0400 Received: from localhost (unknown [207.109.85.82]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 06079FA05C; Thu, 11 Apr 2019 20:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1555015327; bh=w5O5RTnPyfvnCyJFGAxAG/HDTdhGAiLlLD8+GkfexAM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HervHCrZdNV7ol2gN9OD9whPLJdW0nYnG5Es6z/K3OgjKJa/nfiA6QxNV88dZEtb3 5bUx/A3F/bf1JOfOaV/lZBRD/lcwJ98JEMfrCK/+zKu2oudN+yDU5ORZVG9lR/eHke AY0aoswmYIfYA0hergwTJPNhlgdTZIu1a4Hoq2Bk= From: Eric Abrahamsen References: <87d0ls32ke.fsf@tcd.ie> <87v9zke87k.fsf@ericabrahamsen.net> <87h8b4tio0.fsf@tcd.ie> Date: Thu, 11 Apr 2019 13:42:01 -0700 In-Reply-To: <87h8b4tio0.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 11 Apr 2019 21:02:07 +0100") Message-ID: <87wok0w9ye.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 04/11/19 21:02 PM, Basil L. Contovounesios wrote: > Eric Abrahamsen writes: > >> "Basil L. Contovounesios" writes: >> >>> Patch fixing these to follow. >> >> Ugh, thank you for catching those very stupid mistakes! > > No worries, I take that as permission to push (after waiting a day or > two). :) Inasmuch as my "permission" means anything, yes :) From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 21:12:06 2019 Received: (at control) by debbugs.gnu.org; 14 Apr 2019 01:12:06 +0000 Received: from localhost ([127.0.0.1]:59504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFTgk-0008OE-CG for submit@debbugs.gnu.org; Sat, 13 Apr 2019 21:12:06 -0400 Received: from mail-ed1-f51.google.com ([209.85.208.51]:34669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFTgj-0008Nb-AR for control@debbugs.gnu.org; Sat, 13 Apr 2019 21:12:05 -0400 Received: by mail-ed1-f51.google.com with SMTP id a6so302235edv.1 for ; Sat, 13 Apr 2019 18:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XPFMjC9NuZgx8FP/bz1TVI2VSCif3AU41yoR/dTDp4Q=; b=NlExHvUv5eSuA6ObLS3hC7XCZI2zeavEweo6/neJX5Fi0mNc7I2uGApr58q/uib5hO 7hTSL1tgD5VgQjkBKKiI5oSxIhFZsSvDd77A1VOUPdj1HWLbXto31G/r+AYzL4fXlQmw IRxlh2ECK9GmHlN9O++luDkGcBT2yEpQ+ufsRWEKiSLc5oYkg5cE94fS4TTbpgIYCvnc HZulZdW3ky6YJD3s9CZy5wtfsUtw9jc9KCeFEG2zbRGxkUjxO0dd411EjLuMPcqMrLcS L741siYbQwbaX0dFZ5BRd4T6qHOtsiR/I25fHF/8eY6iwMWj0tTS/cgkw3kaNFPgu7jQ fTrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XPFMjC9NuZgx8FP/bz1TVI2VSCif3AU41yoR/dTDp4Q=; b=eIJDmsP+ug+lgKNmRMEJxybjUP0s6BXawHwdPPKbu27cqiUwxuAL+Wj7cVYT9DEmJs szHDZwS34Vcp9QRSqcHquAQr9IbNMjY/B5I2kl+wAqcXwSBQrOCyYQlPqgbtWUMNw4Eu nt1Blt2EMSqWAq+C2FAWk6EDi3Szy3jI2rUZ+5PLlf/v6d9FfKM7Gfuw2AZR6x6dz3TO v+kHwWI69u8OXfB6A/+e6gG0c6+cdZktNkuOL9u6LE2jR+5ZV4xQBNJ+LyweZIE0M/w4 mLXfHfl2JANcL2YX66/3utijDrCMApc5LCxKtPJHXhZ2CBOY4ukJRGVlPXRTwfiUTfHt c0jQ== X-Gm-Message-State: APjAAAVy11/yaZUOhI5Lk0ovRIoqxkAbvAg01xxIYgWcSjq4kbue3mkv XyBfnQLI0ic2s1kGhPjChblZRg== X-Google-Smtp-Source: APXvYqxC7uKzOLBZIC9eImbwp7abA455dgFEu25QJ9Ixs58oEM7LsKmU3b8t6W3qSyjqrTb4totCnA== X-Received: by 2002:a17:906:32c7:: with SMTP id k7mr30783358ejk.42.1555204319536; Sat, 13 Apr 2019 18:11:59 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id u10sm5854156edf.50.2019.04.13.18.11.58 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 13 Apr 2019 18:11:58 -0700 (PDT) From: "Basil L. Contovounesios" To: Eric Abrahamsen Subject: Re: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups References: <87d0ls32ke.fsf@tcd.ie> <87v9zke87k.fsf@ericabrahamsen.net> <87h8b4tio0.fsf@tcd.ie> <87wok0w9ye.fsf@ericabrahamsen.net> Date: Sun, 14 Apr 2019 02:11:50 +0100 In-Reply-To: <87wok0w9ye.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 11 Apr 2019 13:42:01 -0700") Message-ID: <87sgule6g9.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 35233-done@debbugs.gnu.org, Katsumi Yamaoka X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35233 fixed close 35233 quit Eric Abrahamsen writes: > On 04/11/19 21:02 PM, Basil L. Contovounesios wrote: >> Eric Abrahamsen writes: >> >>> "Basil L. Contovounesios" writes: >>> >>>> Patch fixing these to follow. >>> >>> Ugh, thank you for catching those very stupid mistakes! >> >> No worries, I take that as permission to push (after waiting a day or >> two). :) > > Inasmuch as my "permission" means anything, yes :) I'd rather be blamed for programming oversights than failing to ask and waiting for a review. ;) Plus your recent efforts in this area afford you a certain level of "ownership". I've pushed the patch to master[1] and am thus closing this report. [1: c49f5d573b]: Fix gnus-group-describe-all-groups (bug#35233) 2019-04-14 01:58:47 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c49f5d573b37f7aaa8d480d568c7e26d975f0320 Thanks, -- Basil