GNU bug report logs - #35233
27.0.50; Error in gnus-group-describe-all-groups

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35233 in the body.
You can then email your comments to 35233 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: 27.0.50; Error in gnus-group-describe-all-groups
Date: Thu, 11 Apr 2019 17:54:25 +0100

The recent move to hash-tables[1] introduced the following regression:

0. HOME=$(mktemp -d) emacs -Q
1. (setq gnus-select-method '(nntp "news.gwene.org")) C-j
2. M-x gnus RET s M-d
   Wrong number of arguments: #<subr sort>, 1

Passing string-lessp to sort further leads to the following:

3. Steps 0-2 as above.
   Wrong type argument: vectorp, #s(hash-table ...)

Replacing (intern group gnus-description-hashtb) with just group, and
repeating steps 0-2 as above, reveals that
gnus-group-describe-all-groups inserts the group name twice, rather than
the group name followed by its description.  This regression predates
the move to hash-tables[2].

[1: c1b63af445]: Change Gnus hash tables into real hash tables
  2019-03-22 10:23:30 -0700
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c1b63af4458e92bad33da0def2b15c206656e2fa

[2: 3982245371]: Sort groups before inserting them into the group buffer
  2016-02-13 18:45:11 +1100
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3982245371c0b8e17b4d96d16ed4b1d87c0ffc25

Patch fixing these to follow.

-- 
Basil

Gnus v5.13
In GNU Emacs 27.0.50 (build 9, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2019-04-11 built on thunk
Repository revision: 0627a8d7bc6ffa29d7a503fd36e760778ecb9fa1
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12003000
System Description: Debian GNU/Linux buster/sid

Message #8 received at 35233 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: 35233 <at> debbugs.gnu.org
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>,
 Katsumi Yamaoka <yamaoka <at> jpl.org>
Subject: Re: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups
Date: Thu, 11 Apr 2019 17:59:52 +0100

[Message part 1 (text/plain, inline)]

tags 35233 patch
quit

[0001-Fix-gnus-group-describe-all-groups-bug-35233.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Patch fixing these to follow.

I attach said patch.

Thanks,

-- 
Basil

Message #13 received at 35233 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: Katsumi Yamaoka <yamaoka <at> jpl.org>, 35233 <at> debbugs.gnu.org
Subject: Re: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups
Date: Thu, 11 Apr 2019 10:57:03 -0700

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> The recent move to hash-tables[1] introduced the following regression:
>
> 0. HOME=$(mktemp -d) emacs -Q
> 1. (setq gnus-select-method '(nntp "news.gwene.org")) C-j
> 2. M-x gnus RET s M-d
>    Wrong number of arguments: #<subr sort>, 1
>
> Passing string-lessp to sort further leads to the following:
>
> 3. Steps 0-2 as above.
>    Wrong type argument: vectorp, #s(hash-table ...)
>
> Replacing (intern group gnus-description-hashtb) with just group, and
> repeating steps 0-2 as above, reveals that
> gnus-group-describe-all-groups inserts the group name twice, rather than
> the group name followed by its description.  This regression predates
> the move to hash-tables[2].
>
> [1: c1b63af445]: Change Gnus hash tables into real hash tables
>   2019-03-22 10:23:30 -0700
>   https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c1b63af4458e92bad33da0def2b15c206656e2fa
>
> [2: 3982245371]: Sort groups before inserting them into the group buffer
>   2016-02-13 18:45:11 +1100
>   https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3982245371c0b8e17b4d96d16ed4b1d87c0ffc25
>
> Patch fixing these to follow.

Ugh, thank you for catching those very stupid mistakes!

Message #16 received at 35233 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Katsumi Yamaoka <yamaoka <at> jpl.org>, 35233 <at> debbugs.gnu.org
Subject: Re: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups
Date: Thu, 11 Apr 2019 21:02:07 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> Patch fixing these to follow.
>
> Ugh, thank you for catching those very stupid mistakes!

No worries, I take that as permission to push (after waiting a day or
two). :)

Thanks,

-- 
Basil

Message #19 received at 35233 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: Katsumi Yamaoka <yamaoka <at> jpl.org>, 35233 <at> debbugs.gnu.org
Subject: Re: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups
Date: Thu, 11 Apr 2019 13:42:01 -0700

On 04/11/19 21:02 PM, Basil L. Contovounesios wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>>
>>> Patch fixing these to follow.
>>
>> Ugh, thank you for catching those very stupid mistakes!
>
> No worries, I take that as permission to push (after waiting a day or
> two). :)

Inasmuch as my "permission" means anything, yes :)

Message #26 received at 35233-done <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 35233-done <at> debbugs.gnu.org, Katsumi Yamaoka <yamaoka <at> jpl.org>
Subject: Re: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups
Date: Sun, 14 Apr 2019 02:11:50 +0100

tags 35233 fixed
close 35233
quit

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> On 04/11/19 21:02 PM, Basil L. Contovounesios wrote:
>> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>>
>>> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>>>
>>>> Patch fixing these to follow.
>>>
>>> Ugh, thank you for catching those very stupid mistakes!
>>
>> No worries, I take that as permission to push (after waiting a day or
>> two). :)
>
> Inasmuch as my "permission" means anything, yes :)

I'd rather be blamed for programming oversights than failing to ask and
waiting for a review. ;) Plus your recent efforts in this area afford
you a certain level of "ownership".

I've pushed the patch to master[1] and am thus closing this report.

[1: c49f5d573b]: Fix gnus-group-describe-all-groups (bug#35233)
  2019-04-14 01:58:47 +0100
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c49f5d573b37f7aaa8d480d568c7e26d975f0320

Thanks,

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.