Subject: bug#35223: closed (Re: [bug#35223] [PATCH] gnu: linux-libre: Set DEVPTS_MULTIPLE_INSTANCES only where needed.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 14 Apr 2019 18:22:02 +0000

Your bug report

#35223: [PATCH] gnu: linux-libre: Set DEVPTS_MULTIPLE_INSTANCES only where needed.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
35223: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35223
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#35223] [PATCH] gnu: linux-libre: Set DEVPTS_MULTIPLE_INSTANCES only where needed.
From: Tobias Geerinckx-Rice <[email-masked]>
To: [email-masked]
Date: Sun, 14 Apr 2019 20:20:58 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Tobias Geerinckx-Rice wrote:
>>> * gnu/packages/linux.scm (%default-extra-linux-options): Move
>>> obsolete
>>> CONFIG_DEVPTS_MULTIPLE_INSTANCES option…
>>> (linux-libre-4.4): …here.

[…]

>> As long as things still work after this patch, go for it!
>
> AFAICT: yes.

Pushed as 8b4e76249a4d1b4af5da6a8b07f4fb3c92234c07.

Kind regards,

T G-R

Subject: [PATCH] gnu: linux-libre: Set DEVPTS_MULTIPLE_INSTANCES only where needed.
From: Tobias Geerinckx-Rice <[email-masked]>
To: [email-masked]
Cc: Tobias Geerinckx-Rice <[email-masked]>
Date: Thu, 11 Apr 2019 01:19:36 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

From: Tobias Geerinckx-Rice <[email-masked]>

* gnu/packages/linux.scm (%default-extra-linux-options): Move obsolete
CONFIG_DEVPTS_MULTIPLE_INSTANCES option…
(linux-libre-4.4): …here.
---
 gnu/packages/linux.scm | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 710fd2d299..c80cee6422 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -264,9 +264,7 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration."
     (search-auxiliary-file file)))
 
 (define %default-extra-linux-options
-  `(;; https://lists.gnu.org/archive/html/guix-devel/2014-04/msg00039.html
-    ("CONFIG_DEVPTS_MULTIPLE_INSTANCES" . #t)
-    ;; Modules required for initrd:
+  `(;; Modules required for initrd:
     ("CONFIG_NET_9P" . m)
     ("CONFIG_NET_9P_VIRTIO" . m)
     ("CONFIG_VIRTIO_BLK" . m)
@@ -471,7 +469,13 @@ It has been modified to remove all non-free binary blobs.")
   (make-linux-libre "4.4.178"
                     "1lgsd760md6b32qb5ng3anfq1n754a9d0c4xnf2mjxkimncb1jpp"
                     '("x86_64-linux" "i686-linux")
-                    #:configuration-file kernel-config))
+                    #:configuration-file kernel-config
+                    #:extra-options
+                    (append
+                     `(;; https://lists.gnu.org/archive/html/guix-devel/2014-04/msg00039.html
+                       ;; This option was removed upstream in version 4.7.
+                       ("CONFIG_DEVPTS_MULTIPLE_INSTANCES" . #t))
+                     %default-extra-linux-options)))
 
 (define-public linux-libre-arm-generic
   (make-linux-libre %linux-libre-version
-- 
2.21.0