From unknown Sun Aug 17 01:43:59 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35222 <35222@debbugs.gnu.org> To: bug#35222 <35222@debbugs.gnu.org> Subject: Status: 26.1; `read-command' documentation Reply-To: bug#35222 <35222@debbugs.gnu.org> Date: Sun, 17 Aug 2025 08:43:59 +0000 retitle 35222 26.1; `read-command' documentation reassign 35222 emacs submitter 35222 Drew Adams severity 35222 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 18:13:49 2019 Received: (at submit) by debbugs.gnu.org; 10 Apr 2019 22:13:49 +0000 Received: from localhost ([127.0.0.1]:53641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hELTY-0004hm-P9 for submit@debbugs.gnu.org; Wed, 10 Apr 2019 18:13:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hELTU-0004hU-M5 for submit@debbugs.gnu.org; Wed, 10 Apr 2019 18:13:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:37866) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hELTP-0000li-Ie for submit@debbugs.gnu.org; Wed, 10 Apr 2019 18:13:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hELTO-0005fA-Cd for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 18:13:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hELTN-0000jA-EK for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 18:13:38 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:40696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hELTM-0000c6-5N for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 18:13:36 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3AMAOQb103969 for ; Wed, 10 Apr 2019 22:13:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=+0Q0CiuaOzXyhZsw/PUEaS6zxmrX1JozVVfKwvPNrn8=; b=AFeVBvZww5t7v243L+PObbxeIN7heBxkFpyf70FQmavnHGvPQHUFZ7V/djGWDIkx46N2 VCuKE4SVGFPXiqxsjqRYscEgEF9xG/ZhH37haU029HzpUya2EO2rqPmHqhTPunxBK6n7 kr83lb+L27VH5EgpHpF6AIcfLBRnVxi4u9zgkf1bomxJyLuWN0bs2894WBbDfSjva1rI eCdBtOKzdKcFfx/RJhT1MZFsvo+RIrr84bP5CDBQL5GClRU4p8w68yKsckM/ca0zfyKN zgGwjfM6Jv2D0ZFLwcU9djr+VVfpTewS3HtNstoBz5SIjX4I/4n1wOHF58iO92R8puSP kw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2rpmrqdkdr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 10 Apr 2019 22:13:34 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3AMBfge045787 for ; Wed, 10 Apr 2019 22:13:33 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 2rpytcg06c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 10 Apr 2019 22:13:33 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x3AMDWqt006393 for ; Wed, 10 Apr 2019 22:13:33 GMT MIME-Version: 1.0 Message-ID: <54098355-6406-459c-9a3a-b7c5b4fe286b@default> Date: Wed, 10 Apr 2019 15:13:31 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 26.1; `read-command' documentation X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4834.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9223 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904100144 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9223 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904100144 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.85 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) 1. The doc string does not say what happens if DEFAULT is not provided (so `nil') and the user enters empty input. And what happens is not obvious. Please add that information to the doc string. 2. What does happen? Well, it's documented in (elisp) `High-Level Completion'. But please add information to that Info node that helps users understand a return value that is an empty-named interned symbol, which has the print and read syntax `##'. It's pretty unusual for the default behavior of a read command to return such an odd beast. (The default behavior is the case when arg DEFAULT is absent, hence `nil'.) And please provide a cross-reference to node `Symbol Type', which explains this syntax. User code that tests the result of `read-command' typically needs to deal with the default DEFAULT case, hence with the possibility of the function returning an uninterned symbol. Users need to be aware of this possibility - it's a gotcha. In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32) of 2018-05-30 Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea Windowing system distributor `Microsoft Corp.', version 10.0.17134 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 18:24:33 2019 Received: (at 35222) by debbugs.gnu.org; 10 Apr 2019 22:24:33 +0000 Received: from localhost ([127.0.0.1]:53653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hELdx-00050r-Bw for submit@debbugs.gnu.org; Wed, 10 Apr 2019 18:24:33 -0400 Received: from mail-oi1-f175.google.com ([209.85.167.175]:46741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hELdu-00050d-Kq for 35222@debbugs.gnu.org; Wed, 10 Apr 2019 18:24:31 -0400 Received: by mail-oi1-f175.google.com with SMTP id x188so3175624oia.13 for <35222@debbugs.gnu.org>; Wed, 10 Apr 2019 15:24:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y6prHShPe5lABs+eXp1EZGUHXOoJBv8a++Pnf7/a8f4=; b=WdWy1YoCYBcXfyBXRTemr7dxghe31zvl7DXpBI7RkGAsTQQvMEy/iC77xYNSag8r05 vpeBLb3qwg6LN2rCD5/T3ahbeomo93faYRrU7fMaxcjPGykVdX8HCGZ2K1B8BfCYQXRJ dc9W4X8iwG5fZJXKAjrzVjB/K92dYP3yDPZl139l8zTEWMNOy641ZiPKGT38BaH8HL7Y uEjAFiUU+NjSD+8any03S5VYNCNPZcvD8FUs8Hp6cw2sOa+a/gWuuGiLJHtQRS/GElh5 Ju8Iku5rEEToWL/bSAPi+t6HaIgFZKYYyfSklGB5+05o3TAuH++/DSjFUs9TcfCPZ8xF u/+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y6prHShPe5lABs+eXp1EZGUHXOoJBv8a++Pnf7/a8f4=; b=HBCcU4tozsTjENZZuQGS5IelqIg2iFXLuDzuanRx/qZbClx8o7JG6DLlppwf7XNilg xbwkCM0hoeSJgnpxfY+3kja3Sygp6oMMc0b6X9V8dd9T1+j/Ct/SJIAtuATkQi6adE0i m+ojXptoav+mXKG6pcQ+SmuHmEgzQbVSZIQJ0uPftVWW8kc15BKF0RPn3fCrzyqu2S32 kMwB4sTcl9TEgHtcMipNJ7E4Em6qBzaqPIZd7Z4xCJXS037ZRgLZHN+r3FbFUm+ekDL+ sKLKacQe5RYjHuEkp19Pbxe4+PikeJvdO/vwNG5K79QtthFWwvRz66rlafsp2CWLkKvt gLmw== X-Gm-Message-State: APjAAAVycfzu2NoMqxJov8gYeBPXYrfTJ59il95B23obDkf8Bqm9qXP8 6OtZqxQUL8NV0nXQrRo8FBnxLzxQEbReHDsVk1A= X-Google-Smtp-Source: APXvYqxIXWX9mycKY+8qiIYS0vZDuhPXuNUnd6YbwDwOEsv2xzEogNFIgfHemsmBYvJ6ySprL/EFUVnARimt3iszRyU= X-Received: by 2002:aca:ac84:: with SMTP id v126mr3993852oie.87.1554935064945; Wed, 10 Apr 2019 15:24:24 -0700 (PDT) MIME-Version: 1.0 References: <54098355-6406-459c-9a3a-b7c5b4fe286b@default> In-Reply-To: <54098355-6406-459c-9a3a-b7c5b4fe286b@default> From: Noam Postavsky Date: Wed, 10 Apr 2019 18:24:14 -0400 Message-ID: Subject: Re: bug#35222: 26.1; `read-command' documentation To: Drew Adams Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35222 Cc: 35222@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 10 Apr 2019 at 18:14, Drew Adams wrote: > > 1. The doc string does not say what happens if DEFAULT is not provided > (so `nil') and the user enters empty input. And what happens is not > obvious. Please add that information to the doc string. Um, can we declare the current behaviour a bug, and instead return nil in this case? That matches the current doc string (i.e., return DEFAULT-VALUE), and avoids the whole mess with the empty string symbol which is weird and pretty useless as far as I can tell. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 19:33:00 2019 Received: (at 35222) by debbugs.gnu.org; 10 Apr 2019 23:33:00 +0000 Received: from localhost ([127.0.0.1]:53666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEMiC-0006bT-6K for submit@debbugs.gnu.org; Wed, 10 Apr 2019 19:33:00 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:38712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEMiA-0006bF-H8 for 35222@debbugs.gnu.org; Wed, 10 Apr 2019 19:32:59 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3ANU6Jm155035; Wed, 10 Apr 2019 23:32:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=6/TzvzWfHWZMXoL9eMMKxypu8v2VR+5UAQ+TS1WTEEg=; b=28JJhpRQOgGR9PeelJAz7oDxOXKXrEnFy+1hspbHUSjTBsc5mJszxF4TvuLbyKmE2K+W 5C/+1JlL6JJUhIw00Fr5ON7EW4AI7SYI1vJhmreKV5roCUg9b5MD0xnwfp3JeAU284AN kQtBQ3fh/GtEb3B3Z9UWaGy9oimgcP+VDiVAje1S5yVlPEiKr1d0HSnzrjnTzsNFlJIc ErM8uDd3cvaDAsTElN5Umz6bcHzqeEHFdkUYh7k/UWGQbT5hSuWts1QqL4y5TSPDjBsl pn1FyqSX7fGxWSq74Qa8b3WMYA721Umtx+zTQM/InvsMODBmyjPZ879pchP5gJjcJERG OA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 2rphmep1ts-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Apr 2019 23:32:51 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3ANVxn1130546; Wed, 10 Apr 2019 23:32:50 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2rpkek64hg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Apr 2019 23:32:50 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x3ANWmWx027194; Wed, 10 Apr 2019 23:32:49 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 10 Apr 2019 16:32:47 -0700 (PDT) From: Drew Adams To: Noam Postavsky Subject: RE: bug#35222: 26.1; `read-command' documentation References: <54098355-6406-459c-9a3a-b7c5b4fe286b@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4834.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9223 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904100153 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9223 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904100153 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35222 Cc: 35222@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > 1. The doc string does not say what happens if DEFAULT is not provided > > (so `nil') and the user enters empty input. And what happens is not > > obvious. Please add that information to the doc string. >=20 > Um, can we declare the current behaviour a bug, and instead return nil > in this case? That matches the current doc string (i.e., return > DEFAULT-VALUE), and avoids the whole mess with the empty string symbol > which is weird and pretty useless as far as I can tell. Good question. That was in fact my first reaction. I wrote the bug report that way, then reconsidered. I agree that the behavior is weird, and I'm not sure what users, in what use cases, it could help. IOW, why? But the behavior has apparently always been thus. (Prior to Emacs 24 there was no such read/print syntax for uninterned symbols, so it was arguably even weirder. If you used the result as a variable value and did `C-h v' it would show you nothing!) I ended up figuring that someone wanted this for some good reason that I couldn't think of, and that since it is documented this way (always returns a symbol) and it is of long date we should just leave it and make sure the doc string also helps. But it sure is a gotcha. Why the default DEFAULT behavior would be something so unexpected is a good question. Hysterical accident? Intentional design? Anyone know or have an idea what good this is? All I could think of is that code using it can be sure to get a symbol. But it sure isn't sure to get a command... I don't have the C sources, but a priori (e.g. if I were writing `read-command' from scratch in Lisp) it seems like it should _require_ a commandp symbol, i.e., use `completing-read' with non-nil REQUIRE arg. Someone is sure to enlighten us. When that happens, and if the decision is to continue the behavior, hopefully people will agree even more strongly with the need to provide clear doc about this odd default case. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 10:02:49 2019 Received: (at 35222-done) by debbugs.gnu.org; 11 Apr 2019 14:02:49 +0000 Received: from localhost ([127.0.0.1]:54981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEaHx-0003Nw-7U for submit@debbugs.gnu.org; Thu, 11 Apr 2019 10:02:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEaHt-0003Nb-FW for 35222-done@debbugs.gnu.org; Thu, 11 Apr 2019 10:02:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEaHn-0000xl-Vz; Thu, 11 Apr 2019 10:02:40 -0400 Received: from [176.228.60.248] (port=1615 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hEaHn-0003sJ-91; Thu, 11 Apr 2019 10:02:39 -0400 Date: Thu, 11 Apr 2019 17:02:20 +0300 Message-Id: <834l7463o3.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-reply-to: <54098355-6406-459c-9a3a-b7c5b4fe286b@default> (message from Drew Adams on Wed, 10 Apr 2019 15:13:31 -0700 (PDT)) Subject: Re: bug#35222: 26.1; `read-command' documentation References: <54098355-6406-459c-9a3a-b7c5b4fe286b@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35222-done Cc: 35222-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 10 Apr 2019 15:13:31 -0700 (PDT) > From: Drew Adams > > 1. The doc string does not say what happens if DEFAULT is not provided > (so `nil') and the user enters empty input. And what happens is not > obvious. Please add that information to the doc string. Thanks, fixed. > 2. What does happen? Well, it's documented in (elisp) `High-Level > Completion'. But please add information to that Info node that helps > users understand a return value that is an empty-named interned > symbol, which has the print and read syntax `##'. It's pretty > unusual for the default behavior of a read command to return such an > odd beast. (The default behavior is the case when arg DEFAULT is > absent, hence `nil'.) And please provide a cross-reference to node > `Symbol Type', which explains this syntax. Done. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 14:55:50 2019 Received: (at 35222) by debbugs.gnu.org; 11 Apr 2019 18:55:51 +0000 Received: from localhost ([127.0.0.1]:55168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEerW-0006Jk-KV for submit@debbugs.gnu.org; Thu, 11 Apr 2019 14:55:50 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:42177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEerU-0006Jc-PR for 35222@debbugs.gnu.org; Thu, 11 Apr 2019 14:55:49 -0400 Received: from lechazo.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x3BItljb009595; Thu, 11 Apr 2019 14:55:48 -0400 Received: by lechazo.home (Postfix, from userid 20848) id A98AE604F0; Thu, 11 Apr 2019 14:55:47 -0400 (EDT) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#35222: 26.1; `read-command' documentation Message-ID: References: <54098355-6406-459c-9a3a-b7c5b4fe286b@default> Date: Thu, 11 Apr 2019 14:55:47 -0400 In-Reply-To: (Noam Postavsky's message of "Wed, 10 Apr 2019 18:24:14 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6523=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6523> : inlines <7052> : streams <1818374> : uri <2830338> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35222 Cc: 35222@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> 1. The doc string does not say what happens if DEFAULT is not provided >> (so `nil') and the user enters empty input. And what happens is not >> obvious. Please add that information to the doc string. > Um, can we declare the current behaviour a bug, and instead return nil > in this case? That matches the current doc string (i.e., return > DEFAULT-VALUE), and avoids the whole mess with the empty string symbol > which is weird and pretty useless as far as I can tell. Yes, it would seem to be more in line with the usual expected behavior. The caller can get the current behavior by passing ## as the DEFAULT argument, so there doesn't seem to be any good reason to return ## when DEFAULT was nil. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 20:11:24 2019 Received: (at 35222) by debbugs.gnu.org; 12 Apr 2019 00:11:24 +0000 Received: from localhost ([127.0.0.1]:55314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEjmu-0003Dm-AR for submit@debbugs.gnu.org; Thu, 11 Apr 2019 20:11:24 -0400 Received: from mail-qt1-f170.google.com ([209.85.160.170]:37267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEjms-0003DX-TQ for 35222@debbugs.gnu.org; Thu, 11 Apr 2019 20:11:23 -0400 Received: by mail-qt1-f170.google.com with SMTP id z16so9331528qtn.4 for <35222@debbugs.gnu.org>; Thu, 11 Apr 2019 17:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PG6RBenpmZs1MErzLPzGVaZBDuUhgLkF2v1LxpZgZjg=; b=hafl7DeNW0yj+tQp5FycP4tIvRDfn++i1+wkM+VkMExMRF+IPUtigkS1RS0VoZkV3X 2MKwEP86uINqNICyRKojxuxtdorMUW4V3Mh2pXZPbBL7tUnlYZnpiJOK8pCH0RYEs4Pn mKZh5/7Gqz6Na0ggC2ZM0DgYcI2WSbMtxrzJVXxy5aPtv0w3pjXmAWw4WT7NTO1/qyIS oQsnjyeB4mymYph3sSMZZ+s3DMJJOlOJhrr/wIdBtQ+PjxddXxX6l3PG04BMpPb9y8E4 R0DEpU8r/ehh9fzS7J2GIglhN2jnzF5iJNmNL5zNmBk0h38ttUKj3UNJhSXg7vuYrBYt tQlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=PG6RBenpmZs1MErzLPzGVaZBDuUhgLkF2v1LxpZgZjg=; b=GdgzGT2ik7tmvD82Q4aWycb7Ld7qjALdVH5r8/5/FJyJV+LKL7m2t3tEAc/tke+wCx W4YR2tfsEPOqa5xnecgciR8QjjVdhnU9iofFhLOpSNW5KlZv3yQFEcyGXbe6IShAD5sX hz0C3bsTiBcFYWDugvD0qtY0f+5jjjdRQVA2Ht1S1x1rLmr9mJABEX7R6V1B5krAKTza Rs4xU7RirS3sZfciBjn28qeWPBDDp4ExfrQ92b615XY7kWZqh4OxiusUnWtM4/LTC8kb QRPeT55IXf0BJPpof2O0kJERVyYC1jQh12da3d7qbjNhhUYen3hK/Q4cvYQMYZNEdEe8 vROg== X-Gm-Message-State: APjAAAUzmUMDpzGmmVmPX4mcfRcun00EGXeVXWZt8gZxfeOtXwB0Pwu0 M0L+8FAwNbqDb4vEuDJxuEU= X-Google-Smtp-Source: APXvYqwKQ0DP3ZQHhHCNlrAvHHgSx0xlcHoNDPOxDxd0FbpGiQ5PuILx3V7gbsVu2Yxaa7sn9qpIiQ== X-Received: by 2002:a0c:9945:: with SMTP id i5mr42708284qvd.159.1555027877530; Thu, 11 Apr 2019 17:11:17 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v8sm25784880qtc.69.2019.04.11.17.11.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Apr 2019 17:11:16 -0700 (PDT) From: Noam Postavsky To: Stefan Monnier Subject: Re: bug#35222: 26.1; `read-command' documentation References: <54098355-6406-459c-9a3a-b7c5b4fe286b@default> Date: Thu, 11 Apr 2019 20:11:15 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 11 Apr 2019 14:55:47 -0400") Message-ID: <87imvk9j6k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35222 Cc: 35222@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >>> 1. The doc string does not say what happens if DEFAULT is not provided >>> (so `nil') and the user enters empty input. And what happens is not >>> obvious. Please add that information to the doc string. >> Um, can we declare the current behaviour a bug, and instead return nil >> in this case? That matches the current doc string (i.e., return >> DEFAULT-VALUE), and avoids the whole mess with the empty string symbol >> which is weird and pretty useless as far as I can tell. > > Yes, it would seem to be more in line with the usual expected behavior. > The caller can get the current behavior by passing ## as the DEFAULT > argument, so there doesn't seem to be any good reason to return ## when > DEFAULT was nil. Since this bug is already closed, this should go Bug#35231. From unknown Sun Aug 17 01:43:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 10 May 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator