From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 09:15:53 2019 Received: (at submit) by debbugs.gnu.org; 10 Apr 2019 13:15:53 +0000 Received: from localhost ([127.0.0.1]:52486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hED4w-0003kL-Gb for submit@debbugs.gnu.org; Wed, 10 Apr 2019 09:15:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hED4u-0003k8-P6 for submit@debbugs.gnu.org; Wed, 10 Apr 2019 09:15:49 -0400 Received: from lists.gnu.org ([209.51.188.17]:44120) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hED4p-0006wg-G3 for submit@debbugs.gnu.org; Wed, 10 Apr 2019 09:15:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hED4o-0006OG-7s for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 09:15:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hED4n-0006vS-5a for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 09:15:42 -0400 Received: from quimby.gnus.org ([80.91.231.51]:55916) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hED4m-0006uY-QA for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 09:15:41 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hED4g-0004LI-KN for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2019 15:15:38 +0200 From: Lars Ingebrigtsen To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Problems with nnimap groups with non-ASCII characters Date: Wed, 10 Apr 2019 15:15:34 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This started showing up yesterday after recent changes in Gnus: To reproduce: Create an nnimap group called "T=C3=A9st". Restarting Gnus will properly create the group "T=C3=A9st", but Gnus will also say nnimap read 12k from quimby.gnus.org (initial sync of 3 groups; please wait) If you then quit Gnus and restart Gnus, this group will appear: *: nnimap+quimby.gnus.org:T\351st If you try to kill it, all the groups in the buffer will disappear. So something went wrong during whatever the most recent group-related changes were. :-) In GNU Emacs 27.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2019-04-09 built on stories Repository revision: 44b306d3510e54432b76724583ea9405f1c90686 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11604000 System Description: Debian GNU/Linux 9 (stretch) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 13:14:44 2019 Received: (at 35219) by debbugs.gnu.org; 10 Apr 2019 17:14:44 +0000 Received: from localhost ([127.0.0.1]:53498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEGo7-0005Wn-OT for submit@debbugs.gnu.org; Wed, 10 Apr 2019 13:14:43 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:52678 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEGo5-0005WX-MX for 35219@debbugs.gnu.org; Wed, 10 Apr 2019 13:14:42 -0400 Received: from localhost (97-113-35-98.tukw.qwest.net [97.113.35.98]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id E8BABFA028; Wed, 10 Apr 2019 17:14:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554916476; bh=BL6m3eJwcPRNParGXlw/VccillbdudXiOjUQmv4yVt4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=hcbWSfLM4ynAdZ5tmlMfOmCkYCMdR7SiG3mXZNDjvKdHdf+XMagh1v/6hoc0WTD06 vrwMW1N/OtUE9MdI37xawUqKMaxQZ4fMJIxMMF2jhJRxnTuRI7DuQA96XzKCqPRSRD QDca+Z/LvMAN5ucVMoMiS04cegFEg3j5BJ3T72qs= From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#35219: 27.0.50; Problems with nnimap groups with non-ASCII characters References: Date: Wed, 10 Apr 2019 10:14:34 -0700 In-Reply-To: (Lars Ingebrigtsen's message of "Wed, 10 Apr 2019 15:15:34 +0200") Message-ID: <87ftqphjet.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35219 Cc: 35219@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > This started showing up yesterday after recent changes in Gnus: > > To reproduce: Create an nnimap group called "T=C3=A9st". Restarting Gnus > will properly create the group "T=C3=A9st", but Gnus will also say > > nnimap read 12k from quimby.gnus.org (initial sync of 3 groups; please wa= it) > > If you then quit Gnus and restart Gnus, this group will appear: > > *: nnimap+quimby.gnus.org:T\351st > > If you try to kill it, all the groups in the buffer will disappear. > > So something went wrong during whatever the most recent group-related > changes were. :-) Gaah... I've got a pile of tests in place for exactly this! Give me a bit and I'll try to reproduce. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 22:19:54 2019 Received: (at 35219) by debbugs.gnu.org; 15 Apr 2019 02:19:54 +0000 Received: from localhost ([127.0.0.1]:33510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFrDt-0002Mu-Rl for submit@debbugs.gnu.org; Sun, 14 Apr 2019 22:19:54 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:52282 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFrDr-0002Mg-Qn for 35219@debbugs.gnu.org; Sun, 14 Apr 2019 22:19:52 -0400 Received: from localhost (97-126-87-168.tukw.qwest.net [97.126.87.168]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id C299CFA05C; Mon, 15 Apr 2019 02:19:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1555294786; bh=jR7bjb1lC+zqb6d0dfhH7LEfX1qNmgbE1j7QcN43lTA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ATqPyV9l9kgYwoJehgVcsGYrLxRZ8BDyavIJAdsiKHKhS6e2J0WoQ5UQsXG4/kwa0 QByxecUdJjjVsPKZt20GvZq+0qLjCITl+ZdgCH5UrIYWvQLYveS2iSF8z1gJUUaPm2 /QNukjYcpcMwf2beH+QEIGnxuajDvx579/+QOcu4= From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#35219: 27.0.50; Problems with nnimap groups with non-ASCII characters References: <87ftqphjet.fsf@ericabrahamsen.net> Date: Sun, 14 Apr 2019 19:19:44 -0700 In-Reply-To: <87ftqphjet.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 10 Apr 2019 10:14:34 -0700") Message-ID: <87imvgnh6n.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35219 Cc: 35219@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eric Abrahamsen writes: > Lars Ingebrigtsen writes: > >> This started showing up yesterday after recent changes in Gnus: >> >> To reproduce: Create an nnimap group called "T=C3=A9st". Restarting Gnus >> will properly create the group "T=C3=A9st", but Gnus will also say >> >> nnimap read 12k from quimby.gnus.org (initial sync of 3 groups; please w= ait) >> >> If you then quit Gnus and restart Gnus, this group will appear: >> >> *: nnimap+quimby.gnus.org:T\351st >> >> If you try to kill it, all the groups in the buffer will disappear. >> >> So something went wrong during whatever the most recent group-related >> changes were. :-) > > Gaah... I've got a pile of tests in place for exactly this! Give me a > bit and I'll try to reproduce. Lars, would you give this a shot? I should only have been messing with encoding for group names that were coming from symbols. Thanks, Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=group-encoding-fix.diff diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el index 2beb685822..606155d741 100644 --- a/lisp/gnus/gnus-start.el +++ b/lisp/gnus/gnus-start.el @@ -2146,14 +2146,14 @@ gnus-active-to-gnus-format (if (and (stringp (progn (setq group (read cur) group - (encode-coding-string - (cond ((numberp group) - (number-to-string group)) - ((symbolp group) - (symbol-name group)) - ((stringp group) - group)) - 'latin-1)))) + (cond ((numberp group) + (number-to-string group)) + ((symbolp group) + (encode-coding-string + (symbol-name group) + 'latin-1)) + ((stringp group) + group))))) (numberp (setq max (read cur))) (numberp (setq min (read cur))) (null (progn --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 18 11:55:55 2019 Received: (at 35219) by debbugs.gnu.org; 18 Apr 2019 15:55:55 +0000 Received: from localhost ([127.0.0.1]:42351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hH9OF-0002wM-1J for submit@debbugs.gnu.org; Thu, 18 Apr 2019 11:55:55 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:50526 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hH9OC-0002wA-Ag for 35219@debbugs.gnu.org; Thu, 18 Apr 2019 11:55:53 -0400 Received: from localhost (97-126-87-168.tukw.qwest.net [97.126.87.168]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 004FDFA05C; Thu, 18 Apr 2019 15:55:45 +0000 (UTC) From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#35219: 27.0.50; Problems with nnimap groups with non-ASCII characters References: <87ftqphjet.fsf@ericabrahamsen.net> <87imvgnh6n.fsf@ericabrahamsen.net> Date: Thu, 18 Apr 2019 08:55:44 -0700 In-Reply-To: <87imvgnh6n.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 14 Apr 2019 19:19:44 -0700") Message-ID: <875zrbi9z3.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35219 Cc: 35219@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > Eric Abrahamsen writes: > >> Lars Ingebrigtsen writes: >> >>> This started showing up yesterday after recent changes in Gnus: >>> >>> To reproduce: Create an nnimap group called "T=C3=A9st". Restarting Gn= us >>> will properly create the group "T=C3=A9st", but Gnus will also say >>> >>> nnimap read 12k from quimby.gnus.org (initial sync of 3 groups; please = wait) >>> >>> If you then quit Gnus and restart Gnus, this group will appear: >>> >>> *: nnimap+quimby.gnus.org:T\351st >>> >>> If you try to kill it, all the groups in the buffer will disappear. >>> >>> So something went wrong during whatever the most recent group-related >>> changes were. :-) >> >> Gaah... I've got a pile of tests in place for exactly this! Give me a >> bit and I'll try to reproduce. > > Lars, would you give this a shot? I should only have been messing with > encoding for group names that were coming from symbols. This may not be the full solution (though I think it is), but it's definitely a necessary part. I'm going to push this first so more people don't end up with corrupted .newsrc.eld files, and then see where we're at. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 18 13:52:43 2019 Received: (at submit) by debbugs.gnu.org; 18 Apr 2019 17:52:43 +0000 Received: from localhost ([127.0.0.1]:42436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHBDG-00060C-W6 for submit@debbugs.gnu.org; Thu, 18 Apr 2019 13:52:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHBDF-0005zx-07 for submit@debbugs.gnu.org; Thu, 18 Apr 2019 13:52:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:42011) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHBD9-0004wi-Ng for submit@debbugs.gnu.org; Thu, 18 Apr 2019 13:52:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHBD8-0007Bw-Iq for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2019 13:52:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RDNS_NONE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHB4v-0000dX-1H for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2019 13:44:06 -0400 Received: from [195.159.176.226] (port=48996 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHB4u-0000Y6-RV for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2019 13:44:04 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hHB4q-000766-Kn for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2019 19:44:00 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#35219: 27.0.50; Problems with nnimap groups with non-ASCII characters Date: Thu, 18 Apr 2019 18:43:55 +0100 Message-ID: References: <87ftqphjet.fsf@ericabrahamsen.net> <87imvgnh6n.fsf@ericabrahamsen.net> <875zrbi9z3.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) Cancel-Lock: sha1:JuL7yv3dz5mWuy2vlQn8klbE3LQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) On Thu 18 Apr 2019, Eric Abrahamsen wrote: > Eric Abrahamsen writes: > >> Eric Abrahamsen writes: >> >>> Lars Ingebrigtsen writes: >>> >>>> This started showing up yesterday after recent changes in Gnus: >>>> >>>> To reproduce: Create an nnimap group called "Tést". Restarting Gnus >>>> will properly create the group "Tést", but Gnus will also say >>>> >>>> nnimap read 12k from quimby.gnus.org (initial sync of 3 groups; please wait) >>>> >>>> If you then quit Gnus and restart Gnus, this group will appear: >>>> >>>> *: nnimap+quimby.gnus.org:T\351st >>>> >>>> If you try to kill it, all the groups in the buffer will disappear. >>>> >>>> So something went wrong during whatever the most recent group-related >>>> changes were. :-) >>> >>> Gaah... I've got a pile of tests in place for exactly this! Give me a >>> bit and I'll try to reproduce. >> >> Lars, would you give this a shot? I should only have been messing with >> encoding for group names that were coming from symbols. > > This may not be the full solution (though I think it is), but it's > definitely a necessary part. I'm going to push this first so more people > don't end up with corrupted .newsrc.eld files, and then see where we're at. I see a similar symptom, but with a different recipe: - start Gnus - open the server buffer, select a server, and subscribe to a new group - quit the server buffer - in the group buffer, kill the group line for the new group At this point, emacs is busy but unresponsive. Breaking in with ^G results in emacs becoming responsive agin, but all of the group lines disappear from the group buffer. Something is still not quite right. AndyM From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 18 15:48:57 2019 Received: (at 35219) by debbugs.gnu.org; 18 Apr 2019 19:48:57 +0000 Received: from localhost ([127.0.0.1]:42532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHD1k-0000X0-PD for submit@debbugs.gnu.org; Thu, 18 Apr 2019 15:48:57 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:41828 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHD1i-0000Wn-JJ for 35219@debbugs.gnu.org; Thu, 18 Apr 2019 15:48:55 -0400 Received: from localhost (97-126-87-168.tukw.qwest.net [97.126.87.168]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id D0C37FA028; Thu, 18 Apr 2019 19:48:47 +0000 (UTC) From: Eric Abrahamsen To: Andy Moreton Subject: Re: bug#35219: 27.0.50; Problems with nnimap groups with non-ASCII characters References: <87ftqphjet.fsf@ericabrahamsen.net> <87imvgnh6n.fsf@ericabrahamsen.net> <875zrbi9z3.fsf@ericabrahamsen.net> Date: Thu, 18 Apr 2019 12:48:42 -0700 In-Reply-To: (Andy Moreton's message of "Thu, 18 Apr 2019 18:43:55 +0100") Message-ID: <878sw7gkmd.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35219 Cc: 35219@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andy Moreton writes: > On Thu 18 Apr 2019, Eric Abrahamsen wrote: > >> Eric Abrahamsen writes: >> >>> Eric Abrahamsen writes: >>> >>>> Lars Ingebrigtsen writes: >>>> >>>>> This started showing up yesterday after recent changes in Gnus: >>>>> >>>>> To reproduce: Create an nnimap group called "T=C3=A9st". Restarting = Gnus >>>>> will properly create the group "T=C3=A9st", but Gnus will also say >>>>> >>>>> nnimap read 12k from quimby.gnus.org (initial sync of 3 groups; pleas= e wait) >>>>> >>>>> If you then quit Gnus and restart Gnus, this group will appear: >>>>> >>>>> *: nnimap+quimby.gnus.org:T\351st >>>>> >>>>> If you try to kill it, all the groups in the buffer will disappear. >>>>> >>>>> So something went wrong during whatever the most recent group-related >>>>> changes were. :-) >>>> >>>> Gaah... I've got a pile of tests in place for exactly this! Give me a >>>> bit and I'll try to reproduce. >>> >>> Lars, would you give this a shot? I should only have been messing with >>> encoding for group names that were coming from symbols. >> >> This may not be the full solution (though I think it is), but it's >> definitely a necessary part. I'm going to push this first so more people >> don't end up with corrupted .newsrc.eld files, and then see where we're = at. > > I see a similar symptom, but with a different recipe: > - start Gnus > - open the server buffer, select a server, and subscribe to a new group > - quit the server buffer > - in the group buffer, kill the group line for the new group > At this point, emacs is busy but unresponsive. Breaking in with ^G > results in emacs becoming responsive agin, but all of the group lines > disappear from the group buffer. > > Something is still not quite right. I'm not able to reproduce that, using a nntp group from gmane -- can you give me more detail about how you trigger it? Unfortunately, the last round of changes might have left some cruft in your .newsrc.eld file, if you had groups with non-ascii names. If you've got some of that cruft in your group list, I suppose it's possible that trying to kill a group might enter some sort of loop... From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 18 16:43:15 2019 Received: (at submit) by debbugs.gnu.org; 18 Apr 2019 20:43:16 +0000 Received: from localhost ([127.0.0.1]:42564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHDsJ-0001sN-Lj for submit@debbugs.gnu.org; Thu, 18 Apr 2019 16:43:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38071) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHDsH-0001sB-P7 for submit@debbugs.gnu.org; Thu, 18 Apr 2019 16:43:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:32919) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHDsC-0007g5-KO for submit@debbugs.gnu.org; Thu, 18 Apr 2019 16:43:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHDsB-0000Wt-Cm for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2019 16:43:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RDNS_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHDsA-0007dw-BM for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2019 16:43:07 -0400 Received: from [195.159.176.226] (port=60592 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHDsA-0007ct-3n for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2019 16:43:06 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hHDs6-0008Lf-T1 for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2019 22:43:02 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#35219: 27.0.50; Problems with nnimap groups with non-ASCII characters Date: Thu, 18 Apr 2019 21:42:57 +0100 Message-ID: References: <87ftqphjet.fsf@ericabrahamsen.net> <87imvgnh6n.fsf@ericabrahamsen.net> <875zrbi9z3.fsf@ericabrahamsen.net> <878sw7gkmd.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) Cancel-Lock: sha1:rHk83MPm9krvP37aftKLJzPSiuY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) On Thu 18 Apr 2019, Eric Abrahamsen wrote: > Andy Moreton writes: >> I see a similar symptom, but with a different recipe: >> - start Gnus >> - open the server buffer, select a server, and subscribe to a new group >> - quit the server buffer >> - in the group buffer, kill the group line for the new group >> At this point, emacs is busy but unresponsive. Breaking in with ^G >> results in emacs becoming responsive agin, but all of the group lines >> disappear from the group buffer. >> >> Something is still not quite right. > > I'm not able to reproduce that, using a nntp group from gmane -- can you > give me more detail about how you trigger it? I used an nntp group from gmane to check this. After hitting ^g in the recipe above, emacs shows the last 3 lines of the original group buffer, and typing 'g' toudpate the group buffer restores the display to all of the missing groups. After more testing, it seems that this wrong display depends on using topics in the group buffer. If I toggle topics off ('t' in the group buffer) then killing the newly added group appears to work normally. With topics enabled, adding a new group and then saving .newsrc.eld ('s' in the group buffer) still results in the bad behaviour when killing the new group. Killing/yanking a group that was already in .newsrc.eld before gnus was started works normally. I've only checked this with my usual config though, rather than something stripped down to produce a minimal test case. > Unfortunately, the last round of changes might have left some cruft in > your .newsrc.eld file, if you had groups with non-ascii names. If you've > got some of that cruft in your group list, I suppose it's possible that > trying to kill a group might enter some sort of loop... All of the groups in my .newsrc.eld have ASCII names. AndyM From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 18 19:54:09 2019 Received: (at 35219) by debbugs.gnu.org; 18 Apr 2019 23:54:09 +0000 Received: from localhost ([127.0.0.1]:42774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHGr2-0006X5-Rq for submit@debbugs.gnu.org; Thu, 18 Apr 2019 19:54:09 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:46382 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHGr1-0006WY-3B for 35219@debbugs.gnu.org; Thu, 18 Apr 2019 19:54:07 -0400 Received: from localhost (97-126-87-168.tukw.qwest.net [97.126.87.168]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 63C29FA028; Thu, 18 Apr 2019 23:54:00 +0000 (UTC) From: Eric Abrahamsen To: Andy Moreton Subject: Re: bug#35219: 27.0.50; Problems with nnimap groups with non-ASCII characters References: <87ftqphjet.fsf@ericabrahamsen.net> <87imvgnh6n.fsf@ericabrahamsen.net> <875zrbi9z3.fsf@ericabrahamsen.net> <878sw7gkmd.fsf@ericabrahamsen.net> Date: Thu, 18 Apr 2019 16:53:54 -0700 In-Reply-To: (Andy Moreton's message of "Thu, 18 Apr 2019 21:42:57 +0100") Message-ID: <878sw6g99p.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35219 Cc: yamaoka@jpl.org, 35219@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Andy Moreton writes: > On Thu 18 Apr 2019, Eric Abrahamsen wrote: > >> Andy Moreton writes: >>> I see a similar symptom, but with a different recipe: >>> - start Gnus >>> - open the server buffer, select a server, and subscribe to a new group >>> - quit the server buffer >>> - in the group buffer, kill the group line for the new group >>> At this point, emacs is busy but unresponsive. Breaking in with ^G >>> results in emacs becoming responsive agin, but all of the group lines >>> disappear from the group buffer. >>> >>> Something is still not quite right. >> >> I'm not able to reproduce that, using a nntp group from gmane -- can you >> give me more detail about how you trigger it? > > I used an nntp group from gmane to check this. After hitting ^g in the > recipe above, emacs shows the last 3 lines of the original group buffer, > and typing 'g' toudpate the group buffer restores the display to all of > the missing groups. > > After more testing, it seems that this wrong display depends on using > topics in the group buffer. If I toggle topics off ('t' in the group > buffer) then killing the newly added group appears to work normally. > > With topics enabled, adding a new group and then saving .newsrc.eld ('s' > in the group buffer) still results in the bad behaviour when killing the > new group. Okay, this was a fairly intense deep dive! Thanks for the report. It looks like the flurry of fixes over the past week or so also introduced some new bugs. The infloop comes from `gnus-group-goto-group' returning 1 instead of nil when it can't find a group. So `while' loops in gnus-topic.el never exit. The attached patch should fix it. Yamaoka-san, this would revert some of your changes. I think this is correct because the original `gnus-group-goto-group' function did not actually check that a group exists in the newsrc or active hashtables: it used `gnus-intern-safe' which _always returned the group name_, no matter what. In fact, I don't know why the original function even bothered checking that, but the point is that the goto function would always have a group name to work with. With the attached change, Gnus' original behavior is restored for me, including the fact that `gnus-group-jump-to-group' will jump to non-existent groups (creating them in the process). > Killing/yanking a group that was already in.newsrc.eld before gnus was > started works normally. > > I've only checked this with my usual config though, rather than > something stripped down to produce a minimal test case. FWIW, I have a package in ELPA called gnus-mock that I'm using for development: it's a trashable-and-restorable Gnus installation with dummy data that you can use to play with Gnus changes. I'm not expecting anyone else to go to the trouble of using this to report bugs, but it is there. I'm working on a semi-interactive set of ERT tests that are meant to run while Gnus is open, and ensure that point ends up in the right place after various commands, etc. Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=goto-group-fix.diff diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el index b1e4091c97..c757c82fbc 100644 --- a/lisp/gnus/gnus-group.el +++ b/lisp/gnus/gnus-group.el @@ -2549,37 +2549,33 @@ gnus-group-jump-to-group (gnus-group-position-point))) (defun gnus-group-goto-group (group &optional far test-marked) - "Goto to newsgroup GROUP. + "Go to newsgroup GROUP. If FAR, it is likely that the group is not on the current line. -If TEST-MARKED, the line must be marked." +If TEST-MARKED, the line must be marked. + +Return nil if GROUP is not found." (when group - (let ((start (point)) - (active (and (or - ;; Some kind of group may be only there. - (gnus-active group) - ;; All groups (but with exception) are there. - (gnus-group-entry group)) - group))) + (let ((start (point))) (beginning-of-line) (cond ;; It's quite likely that we are on the right line, so ;; we check the current line first. ((and (not far) - (equal (get-text-property (point) 'gnus-group) active) + (equal (get-text-property (point) 'gnus-group) group) (or (not test-marked) (gnus-group-mark-line-p))) (point)) ;; Previous and next line are also likely, so we check them as well. ((and (not far) (save-excursion (forward-line -1) - (and (equal (get-text-property (point) 'gnus-group) active) + (and (equal (get-text-property (point) 'gnus-group) group) (or (not test-marked) (gnus-group-mark-line-p))))) (forward-line -1) (point)) ((and (not far) (save-excursion (forward-line 1) - (and (equal (get-text-property (point) 'gnus-group) active) + (and (equal (get-text-property (point) 'gnus-group) group) (or (not test-marked) (gnus-group-mark-line-p))))) (forward-line 1) (point)) @@ -2588,7 +2584,7 @@ gnus-group-goto-group (let (found) (while (and (not found) (gnus-text-property-search - 'gnus-group active 'forward 'goto)) + 'gnus-group group 'forward 'goto)) (if (gnus-group-mark-line-p) (setq found t) (forward-line 1))) @@ -2596,7 +2592,7 @@ gnus-group-goto-group (t ;; Search through the entire buffer. (if (gnus-text-property-search - 'gnus-group active nil 'goto) + 'gnus-group group nil 'goto) (point) (goto-char start) nil)))))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 19 01:48:48 2019 Received: (at 35219) by debbugs.gnu.org; 19 Apr 2019 05:48:48 +0000 Received: from localhost ([127.0.0.1]:42909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHMOG-0002jZ-7A for submit@debbugs.gnu.org; Fri, 19 Apr 2019 01:48:48 -0400 Received: from bisque.maple.relay.mailchannels.net ([23.83.214.18]:54330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHMOE-0002jQ-Le for 35219@debbugs.gnu.org; Fri, 19 Apr 2019 01:48:47 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 2E5D11246C3; Fri, 19 Apr 2019 05:48:45 +0000 (UTC) Received: from hampton.hostforweb.net (unknown [100.96.28.64]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 9564312427D; Fri, 19 Apr 2019 05:48:44 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Fri, 19 Apr 2019 05:48:45 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Supply-Battle: 697c45b90c56ad13_1555652924983_3785577236 X-MC-Loop-Signature: 1555652924983:3765901122 X-MC-Ingress-Time: 1555652924982 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hHMO8-00ESk4-PK; Fri, 19 Apr 2019 00:48:42 -0500 Date: Fri, 19 Apr 2019 14:48:38 +0900 Message-ID: From: Katsumi Yamaoka To: Eric Abrahamsen Subject: Re: bug#35219: 27.0.50; Problems with nnimap groups with non-ASCII characters References: <87ftqphjet.fsf@ericabrahamsen.net> <87imvgnh6n.fsf@ericabrahamsen.net> <875zrbi9z3.fsf@ericabrahamsen.net> <878sw7gkmd.fsf@ericabrahamsen.net> <878sw6g99p.fsf@ericabrahamsen.net> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-cygwin) Cancel-Lock: sha1:F//hlCchFAbF3jCKMMLyPofFcvU= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35219 Cc: Andy Moreton , 35219@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 18 Apr 2019 16:53:54 -0700, Eric Abrahamsen wrote: >>> Andy Moreton writes: >>>> I see a similar symptom, but with a different recipe: >>>> - start Gnus >>>> - open the server buffer, select a server, and subscribe to a new group >>>> - quit the server buffer >>>> - in the group buffer, kill the group line for the new group >>>> At this point, emacs is busy but unresponsive. Breaking in with ^G >>>> results in emacs becoming responsive agin, but all of the group lines >>>> disappear from the group buffer. [...] >> After more testing, it seems that this wrong display depends on using >> topics in the group buffer. If I toggle topics off ('t' in the group >> buffer) then killing the newly added group appears to work normally. [...] I found what is happening then, too. At first such a new group is registered in only `gnus-newsrc-hashtb', not `gnus-active-hashtb'. When trying to kill the group in the group buffer of the topic mode, during the course of the procedures `gnus-group-change-level' deletes the group from `gnus-newsrc-hashtb', even so `gnus-group-goto-group' tries to go to the group, and fails. I also realized what `gnus-group-goto-group' does when the group is not found in the hash tables is nonsense. [...] > Yamaoka-san, this would revert some of your changes. Not revert but great improve. What is especially great is that making `g-g-g-g' needless to refer to the hash tables: > - (let ((start (point)) > - (active (and (or > - ;; Some kind of group may be only there. > - (gnus-active group) > - ;; All groups (but with exception) are there. > - (gnus-group-entry group)) > - group))) > + (let ((start (point))) [...] > (gnus-text-property-search > - 'gnus-group active 'forward 'goto)) > + 'gnus-group group 'forward 'goto)) Yes, the existing group should be found but nonexistent one should not be found. > With the attached change, Gnus' original behavior is restored for me, > including the fact that `gnus-group-jump-to-group' will jump to > non-existent groups (creating them in the process). Wow! I don't remember it but Gnus in Emacs 26.2 surely does so. It is probably the right behavior of `gnus-group-jump-to-group': 2011-01-31 Lars Ingebrigtsen * gnus-group.el (gnus-group-jump-to-group): Allow jumping to groups that Gnus doesn't know exists again. 2011-01-28 Julien Danjou * gnus-group.el (gnus-group-jump-to-group): Set must match to t. Probably Lars or someone made it allow non-existent group unconditionally at some time. In No Gnus, (gnus-read-active-file-p) was used as the must-match flag. 2004-05-21 Lars Magne Ingebrigtsen * gnus-group.el (gnus-group-jump-to-group): Don't prompt for non-active groups. Anyway there is no other problem so far, so please push the patch. Thanks. Regards, From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 19 08:44:08 2019 Received: (at submit) by debbugs.gnu.org; 19 Apr 2019 12:44:08 +0000 Received: from localhost ([127.0.0.1]:43558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHSsA-0000Mv-Ms for submit@debbugs.gnu.org; Fri, 19 Apr 2019 08:44:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHSs8-0000MJ-F2 for submit@debbugs.gnu.org; Fri, 19 Apr 2019 08:44:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:54661) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHSs3-0003Bh-5C for submit@debbugs.gnu.org; Fri, 19 Apr 2019 08:43:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHSs2-00007o-59 for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 08:43:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_20,FREEMAIL_FROM, RDNS_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHSs1-00039R-Bu for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 08:43:58 -0400 Received: from [195.159.176.226] (port=46840 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHSs1-00037c-5W for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 08:43:57 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hHSry-000kRu-Ha for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 14:43:54 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#35219: 27.0.50; Problems with nnimap groups with non-ASCII characters Date: Fri, 19 Apr 2019 13:43:48 +0100 Message-ID: <86d0liupvf.fsf@gmail.com> References: <87ftqphjet.fsf@ericabrahamsen.net> <87imvgnh6n.fsf@ericabrahamsen.net> <875zrbi9z3.fsf@ericabrahamsen.net> <878sw7gkmd.fsf@ericabrahamsen.net> <878sw6g99p.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) Cancel-Lock: sha1:I+wmg5cjThClvw42EJgWehETXaU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) On Thu 18 Apr 2019, Eric Abrahamsen wrote: > Okay, this was a fairly intense deep dive! Thanks for the report. It > looks like the flurry of fixes over the past week or so also introduced > some new bugs. > > The infloop comes from `gnus-group-goto-group' returning 1 instead of > nil when it can't find a group. So `while' loops in gnus-topic.el never > exit. The attached patch should fix it. Thanks for the speedy fix! The patch fixes the problem for me. AndyM From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 19 12:15:06 2019 Received: (at 35219) by debbugs.gnu.org; 19 Apr 2019 16:15:06 +0000 Received: from localhost ([127.0.0.1]:44532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHWAM-0005tb-DG for submit@debbugs.gnu.org; Fri, 19 Apr 2019 12:15:06 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:36416 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHWAI-0005sf-8P; Fri, 19 Apr 2019 12:15:02 -0400 Received: from localhost (97-126-87-168.tukw.qwest.net [97.126.87.168]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 1EEC9FA05C; Fri, 19 Apr 2019 16:14:55 +0000 (UTC) From: Eric Abrahamsen To: Katsumi Yamaoka Subject: Re: bug#35219: 27.0.50; Problems with nnimap groups with non-ASCII characters References: <87ftqphjet.fsf@ericabrahamsen.net> <87imvgnh6n.fsf@ericabrahamsen.net> <875zrbi9z3.fsf@ericabrahamsen.net> <878sw7gkmd.fsf@ericabrahamsen.net> <878sw6g99p.fsf@ericabrahamsen.net> Date: Fri, 19 Apr 2019 09:14:54 -0700 In-Reply-To: (Katsumi Yamaoka's message of "Fri, 19 Apr 2019 14:48:38 +0900") Message-ID: <87wojqdla9.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35219 Cc: 35219-done@debbugs.gnu.org, Andy Moreton , 35219@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Katsumi Yamaoka writes: > On Thu, 18 Apr 2019 16:53:54 -0700, Eric Abrahamsen wrote: >>>> Andy Moreton writes: >>>>> I see a similar symptom, but with a different recipe: >>>>> - start Gnus >>>>> - open the server buffer, select a server, and subscribe to a new group >>>>> - quit the server buffer >>>>> - in the group buffer, kill the group line for the new group >>>>> At this point, emacs is busy but unresponsive. Breaking in with ^G >>>>> results in emacs becoming responsive agin, but all of the group lines >>>>> disappear from the group buffer. > [...] >>> After more testing, it seems that this wrong display depends on using >>> topics in the group buffer. If I toggle topics off ('t' in the group >>> buffer) then killing the newly added group appears to work normally. > [...] > > I found what is happening then, too. At first such a new group > is registered in only `gnus-newsrc-hashtb', not `gnus-active-hashtb'. > When trying to kill the group in the group buffer of the topic mode, > during the course of the procedures `gnus-group-change-level' > deletes the group from `gnus-newsrc-hashtb', even so > `gnus-group-goto-group' tries to go to the group, and fails. > > I also realized what `gnus-group-goto-group' does when the group > is not found in the hash tables is nonsense. > > [...] >> Yamaoka-san, this would revert some of your changes. > > Not revert but great improve. What is especially great is that > making `g-g-g-g' needless to refer to the hash tables: Yes, I like how this is simpler now. >> - (let ((start (point)) >> - (active (and (or >> - ;; Some kind of group may be only there. >> - (gnus-active group) >> - ;; All groups (but with exception) are there. >> - (gnus-group-entry group)) >> - group))) >> + (let ((start (point))) > [...] >> (gnus-text-property-search >> - 'gnus-group active 'forward 'goto)) >> + 'gnus-group group 'forward 'goto)) [...] > > Anyway there is no other problem so far, so please push the patch. Done! Thanks to both of you for testing. Eric From unknown Mon Aug 18 09:01:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 18 May 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator