Subject: bug#35193: closed (Re: bug#35193: [PATCH 0/3] Add python-mypy and required packages)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 03 Apr 2021 03:21:02 +0000

Your bug report

#35193: [PATCH 0/3] Add python-mypy and required packages

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
35193: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35193
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#35193: [PATCH 0/3] Add python-mypy and required packages
From: Maxim Cournoyer <[email-masked]>
To: wednesday <[email-masked]>
Cc: swedebugia <[email-masked]>, [email-masked]
Date: Fri, 02 Apr 2021 23:20:21 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi!

swedebugia <[email-masked]> writes:

> On 2019-04-30 17:29, wednesday wrote:
>> * gnu/packages/python-xyz.scm (python-mypy): New public variable.
>> ---
>>   gnu/packages/python-xyz.scm | 27 +++++++++++++++++++++++++++
>>   1 file changed, 27 insertions(+)
>> diff --git a/gnu/packages/python-xyz.scm
>> b/gnu/packages/python-xyz.scm
>> index 01c065fc83..c528d2849d 100644
>> --- a/gnu/packages/python-xyz.scm
>> +++ b/gnu/packages/python-xyz.scm
>> @@ -15679,3 +15679,30 @@ standard @code{typing} module that are supported by the mypy typechecker.")
>>                (propagated-inputs
>>                 `(("python2-typing" ,python2-typing)
>>                   ,@(package-propagated-inputs mypy))))))
>> +
>> +(define-public python-mypy
>> +  (package
>> +    (name "python-mypy")
>> +    (version "0.701")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "mypy" version))
>> +       (sha256
>> +        (base32
>> +         "05479r3gbq17r22hyhxjg49smx5q864pgx8ayy23rsdj4w6z2r2p"))))
>> +    (build-system python-build-system)
>> +    ;; FIXME: tests freeze at 80%
>
> We really would like to understand why these fail and mitigate if possible.
>
> Have you reported this upstream?
>
>> +    (arguments '(#:tests? #f))
>> +    (propagated-inputs
>> +     `(("python-mypy-extensions" ,python-mypy-extensions)
>> +       ("python-typed-ast" ,python-typed-ast)
>> +       ("python-psutil" ,python-psutil)))
>> +    (home-page "http://www.mypy-lang.org/")
>> +    (synopsis "Optional static typing for Python 3 and 2 (PEP 484)")
>> +    (description "Add type annotations to your Python programs, and use mypy to type check
>> +them.  
>
> This phrase is a little eh weird. Could you rephrase to something like
> "Mypy checks type annotations..." or "Mypy is a ..."?
>
>> Mypy is essentially a Python linter on steroids, and it can catch many programming
>> +errors by analyzing your program, without actually having to run it.  Mypy has a powerful
>> +type system with features such as type inference, gradual typing, generics and union
>> +types.")
>> +    (license license:expat)))
>
>
> The LICENSE file contains this: "Portions of mypy are licensed under
> different licenses.  The files under stdlib-samples are licensed under 
> the PSF 2 License, reproduced below."
>
> Could you update the patch when you get an answer from upstream?
>
> Thanks for the patch. :)

It seems python-mypy and the required dependencies were merged (last
year) from another contributor that probably had failed to notice about
them here.  Thank you nonetheless, and thanks to swedebugia for the
review!

Closing.

Maxim

Subject: [PATCH 0/3] Add python-mypy and required packages
From: JesseJohnGildersleve <[email-masked]>
To: "[email-masked]" <[email-masked]>
Date: Mon, 08 Apr 2019 13:44:38 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

The next 3 patches will add python-mypy, and its dependencies python-typed-ast and python-mypy-extension/python2-mypy-extension. This is a program for type checking python code.