GNU bug report logs - #35172
[PATCH] gnu: Add git-lfs.

Previous Next

Full log

Message #16 received at 35172-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35172-done <at> debbugs.gnu.org
Subject: Re: [bug#35172] [PATCH] gnu: Add git-lfs.
Date: Sat, 20 Apr 2019 16:42:00 -0400

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hello,
>
> Kei Kebreau <kkebreau <at> posteo.net> skribis:
>
>> Kei Kebreau <kkebreau <at> posteo.net> writes:
>>
>>> +(define-public git-lfs
>>> +  (package
>>> +    (name "git-lfs")
>>> +    (version "2.7.1")
>>> +    (source (origin
>>> +              (method git-fetch)
>>> +              (uri (git-reference
>>> +                    (url "https://github.com/git-lfs/git-lfs")
>>> +                    (commit (string-append "v" version))))
>>> +              (file-name (git-file-name name version))
>>> +              (sha256
>>> +               (base32
>>> +                "10v38w8qfz0x8750kv31n8gg2dimvq4wz40m374pd1xaypfs9670"))))
>>> +    (build-system go-build-system)
>>> +    (arguments
>>> +     '(#:import-path "github.com/git-lfs/git-lfs"))
>>> +    (home-page "https://git-lfs.github.com/")
>>> +    (synopsis "Git extension for versioning large files")
>>> +    (description
>>> + "Git Large File Storage (LFS) replaces large files such as audio
>>> samples,
>>> +videos, datasets, and graphics with text pointers inside Git,
>>> while storing the
>>> +file contents on a remote server like GitHub.com or GitHub Enterprise.")
>>
>> I realize that I can remove the GitHub promotion from the description
>> without any loss of understanding.
>
> Agreed.
>
>>> +    (license license:expat)))
>>
>> This is my first Go package, so any corrections or tips are especially
>> appreciated!
>
> I’m no nothing about Go, but it LGTM!  If something is broken, don’t
> worry, people will tell you.  ;-)
>

:-)

> Thank you,
> Ludo’.

Pushed to master, thank you for reviewing!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.